[jira] [Commented] (OFBIZ-9243) load demo data failure
[
https://issues.apache.org/jira/browse/OFBIZ-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893875#comment-15893875
]
Jacques Le Roux commented on OFBIZ-9243:
I don't reproduce this issue using
https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework-buildbot/trunk
{code}
Line 695: 2017-03-03 08:47:43,387 |main
|EntityDataLoadContainer |I|
file:/C:/projectsASF/ofbiz-framework-buildbot/plugins/myportal/data/MyPortalDemoData.xml
Line 2808: 2017-03-03 08:48:05,393 |main
|EntitySaxReader |I| Beginning import from URL:
file:/C:/projectsASF/ofbiz-framework-buildbot/plugins/myportal/data/MyPortalDemoData.xml
Line 2810: 2017-03-03 08:48:05,413 |main
|EntitySaxReader |I| Finished 10 values from
file:/C:/projectsASF/ofbiz-framework-buildbot/plugins/myportal/data/MyPortalDemoData.xml
Line 3105: 2017-03-03 08:48:06,231 |main
|EntityDataLoadContainer |I| 00010 of 16625 from
file:/C:/projectsASF/ofbiz-framework-buildbot/plugins/myportal/data/MyPortalDemoData.xml
{code}
https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework-buildbot/trunk use
externals . It's used in Buildbot for test and for trunk demo. You can also use
it locally for your tests. Later a pullAllPluginsSource Gradle task will be
used for the same but w/o the externals coupling.
> load demo data failure
> --
>
> Key: OFBIZ-9243
> URL: https://issues.apache.org/jira/browse/OFBIZ-9243
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wai
>
> checkout latest ofbiz-framework and ofbiz-plugins
> $ gradlew cleanAll build
> $ gradlew loadDefault...using derby
> console output...
> 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer
> |I| 00040 of 17229 from
> file:/ofbiz-framework/plugins/webpos/data/PosSyncSettings.xml
> 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer
> |I| The following errors occurred in the data load:
> 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer
> |I| [loadData]: Error loading XML Resource
> "file:/ofbiz-framework/plugins/ebay/data/DemoEbayData.xml"; Error was: A
> transaction error occurred reading data
> 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer
> |I| [loadData]: Error loading XML Resource
> "file:/ofbiz-framework/plugins/myportal/data/MyPortalDemoData.xml"; Error
> was: A transaction error occurred reading data
> 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer
> |I| =-=-=-=-=-=-= Finished the data load with 17229 rows changed.
> }}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9230) Missing reference to the delegator in framework/widget/templates/HtmlFormMacroLibrary.ftl
[
https://issues.apache.org/jira/browse/OFBIZ-9230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893856#comment-15893856
]
Jacques Le Roux commented on OFBIZ-9230:
Let's think about the situation in all its aspects (and be ready to dive in ;)).
First your proposition for WidgetWorker would be actually something like this
{code}
Index: framework/widget/src/main/java/org/apache/ofbiz/widget/WidgetWorker.java
===
--- framework/widget/src/main/java/org/apache/ofbiz/widget/WidgetWorker.java
(revision 1785155)
+++ framework/widget/src/main/java/org/apache/ofbiz/widget/WidgetWorker.java
(working copy)
@@ -35,6 +35,7 @@
import org.apache.ofbiz.base.util.UtilHttp;
import org.apache.ofbiz.base.util.UtilValidate;
import org.apache.ofbiz.entity.Delegator;
+import org.apache.ofbiz.entity.DelegatorFactory;
import org.apache.ofbiz.service.LocalDispatcher;
import org.apache.ofbiz.webapp.control.ConfigXMLReader;
import org.apache.ofbiz.webapp.control.RequestHandler;
@@ -410,6 +411,16 @@
public static Delegator getDelegator(Map context) {
Delegator delegator = (Delegator) context.get("delegator");
+if (delegator == null) {
+// this will be the common case for now as the delegator isn't
available where we want to do this
+// we'll cheat a little here and assume the default delegator
+Debug.logError("Could not get a delegator using the 'default'
delegator", module);
+delegator = DelegatorFactory.getDelegator("default");
+if (delegator == null) {
+Debug.logError("Could not get a delegator even trying with the
'default' delegator", module);
+return null;
+}
+}
return delegator;
}
}
{code}
In the convo, you suggested
{code}
delegator = DelegatorFactory.getDelegator(delegatorName);
{code}
I asked you what should be in delegatorName, but you did not answer and that's
the crux of the problem. We will see that later
I suggested to use in EntityUtilProperties.getSystemPropertyValue()
{code}
delegator = DelegatorFactory.getDelegator("default");
{code}
because it fixes the problem at hand while the patch above for getDelegator()
does not (simply try it w/o the getSystemPropertyValue() patch).
So far so good, we saw that we have the same kind of think in checkRhsType(),
which should then actually be patched with
{code}
Index:
framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityExpr.java
===
---
framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityExpr.java
(revision 1785155)
+++
framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityExpr.java
(working copy)
@@ -18,11 +18,13 @@
***/
package org.apache.ofbiz.entity.condition;
+import java.io.IOException;
import java.util.Collection;
import java.util.List;
import java.util.Map;
import org.apache.ofbiz.base.util.Debug;
+import org.apache.ofbiz.base.util.GeneralException;
import org.apache.ofbiz.base.util.ObjectType;
import org.apache.ofbiz.base.util.UtilGenerics;
import org.apache.ofbiz.entity.Delegator;
@@ -161,7 +163,7 @@
visitor.acceptEntityExpr(this);
}
-public void checkRhsType(ModelEntity modelEntity, Delegator delegator) {
+public void checkRhsType(ModelEntity modelEntity, Delegator delegator)
throws IOException, GeneralException {
if (this.rhs == null || this.rhs == GenericEntity.NULL_FIELD ||
modelEntity == null) return;
Object value = this.rhs;
@@ -179,9 +181,13 @@
}
if (delegator == null) {
-// this will be the common case for now as the delegator isn't
available where we want to do this
-// we'll cheat a little here and assume the default delegator
delegator = DelegatorFactory.getDelegator("default");
+Debug.logError("Could not get a delegator using the 'default'
delegator", module);
+if (delegator == null) {
+Debug.logError("Could not get a delegator even trying with the
'default' delegator", module);
+GeneralException exception = new GeneralException("Could not
get a delegator even trying with the 'default' delegator");
+throw exception;
+}
}
String fieldName = null;
{code}
And now I get to the reason for this analysis: *multitenant*! My patch for
getSystemPropertyValue() works in a simple tenant context. But in a
multitenant context it will always refer to the "default" tenant, which can be
a problem. Same for the other patches above including the checkRhsType() one.
BTW the change introduced there is prior (2008) to multitenant
[jira] [Assigned] (OFBIZ-9230) Missing reference to the delegator in framework/widget/templates/HtmlFormMacroLibrary.ftl
[
https://issues.apache.org/jira/browse/OFBIZ-9230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki reassigned OFBIZ-9230:
Assignee: Jacques Le Roux (was: Rishi Solanki)
Not sure how this assigned to me. Assigning back.
> Missing reference to the delegator in
> framework/widget/templates/HtmlFormMacroLibrary.ftl
> -
>
> Key: OFBIZ-9230
> URL: https://issues.apache.org/jira/browse/OFBIZ-9230
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wei Zhang
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-9230.patch
>
>
> To reproduce
> 1. Load test data systemPropertyId="widget.autocompleter.defaultMinLength"
> systemPropertyValue="3"/>
> 2. Open https://localhost:8443/partymgr/control/main
> 3. You will still get warning below in log file
> {quote}
> 2017-02-24 12:56:16,348 |http-nio-8443-exec-7 |EntityUtilProperties
> |I| Could not get a system property for widget.autocompleter.defaultMinLength
> : null
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (OFBIZ-9243) load demo data failure
Wai created OFBIZ-9243: -- Summary: load demo data failure Key: OFBIZ-9243 URL: https://issues.apache.org/jira/browse/OFBIZ-9243 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Wai checkout latest ofbiz-framework and ofbiz-plugins $ gradlew cleanAll build $ gradlew loadDefault...using derby console output... 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer |I| 00040 of 17229 from file:/ofbiz-framework/plugins/webpos/data/PosSyncSettings.xml 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer |I| The following errors occurred in the data load: 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer |I| [loadData]: Error loading XML Resource "file:/ofbiz-framework/plugins/ebay/data/DemoEbayData.xml"; Error was: A transaction error occurred reading data 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer |I| [loadData]: Error loading XML Resource "file:/ofbiz-framework/plugins/myportal/data/MyPortalDemoData.xml"; Error was: A transaction error occurred reading data 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer |I| =-=-=-=-=-=-= Finished the data load with 17229 rows changed. }} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-9237) order entry initial screen does not show productStore
[ https://issues.apache.org/jira/browse/OFBIZ-9237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wai closed OFBIZ-9237. -- Resolution: Not A Problem I only checkout the source for ofbiz-framework. Realized that there was a second step to checkout the plugins. Hence, the demo data was not what I expected. > order entry initial screen does not show productStore > - > > Key: OFBIZ-9237 > URL: https://issues.apache.org/jira/browse/OFBIZ-9237 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Wai > > -using demo data > -use https://localhost:8443/ordermgr/control/orderentry > notice productStore is empty -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9242) http redirect to https missing port#
[ https://issues.apache.org/jira/browse/OFBIZ-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wai updated OFBIZ-9242: --- Summary: http redirect to https missing port# (was: ssl error) > http redirect to https missing port# > > > Key: OFBIZ-9242 > URL: https://issues.apache.org/jira/browse/OFBIZ-9242 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Wai > > -install ofbiz-framework sources only (ie no plugins) > -compile > -loaded demo data > -go to http://localhost:8080/partymgr > -gets redirected to https://localhost/ordermgr/control/main -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9242) ssl error
[ https://issues.apache.org/jira/browse/OFBIZ-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wai updated OFBIZ-9242: --- Description: -install ofbiz-framework sources only (ie no plugins) -compile -loaded demo data -go to http://localhost:8080/partymgr -gets redirected to https://localhost/ordermgr/control/main was: -install ofbiz-framework sources only (ie no plugins) -compile -loaded demo data -go to https://localhost:8080/partymgr/control/main -browser shows... Secure Connection Failed An error occurred during a connection to localhost:8080. SSL received a record that exceeded the maximum permissible length. Error code: SSL_ERROR_RX_RECORD_TOO_LONG console output shows... 2017-03-02 09:05:37,061 |http-nio-8080-exec-3 |RequestHandler |I| Sending redirect to: [https://localhost/partymgr/control/main]. Hidden sessionId by default. 2017-03-02 09:05:37,114 |http-nio-8080-exec-3 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default 2017-03-02 09:05:37,141 |http-nio-8080-exec-3 |ControlServlet |T| [[[main(Domain:http://localhost)] Request Done- total:0.563,since last([main(Domain:http...):0.563]] Mar 02, 2017 9:05:48 AM org.apache.coyote.http11.AbstractHttp11Processor process INFO: Error parsing HTTP request header Note: further occurrences of HTTP header parsing errors will be logged at DEBUG level. java.lang.IllegalArgumentException: Invalid character found in method name. HTTP method names must be tokens at org.apache.coyote.http11.AbstractNioInputBuffer.parseRequestLine(AbstractNioInputBuffer.java:233) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1017) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:684) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1520) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1476) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) at java.lang.Thread.run(Thread.java:745) > ssl error > - > > Key: OFBIZ-9242 > URL: https://issues.apache.org/jira/browse/OFBIZ-9242 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Wai > > -install ofbiz-framework sources only (ie no plugins) > -compile > -loaded demo data > -go to http://localhost:8080/partymgr > -gets redirected to https://localhost/ordermgr/control/main -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9242) ssl error
Wai created OFBIZ-9242: -- Summary: ssl error Key: OFBIZ-9242 URL: https://issues.apache.org/jira/browse/OFBIZ-9242 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Wai -install ofbiz-framework sources only (ie no plugins) -compile -loaded demo data -go to https://localhost:8080/partymgr/control/main -browser shows... Secure Connection Failed An error occurred during a connection to localhost:8080. SSL received a record that exceeded the maximum permissible length. Error code: SSL_ERROR_RX_RECORD_TOO_LONG console output shows... 2017-03-02 09:05:37,061 |http-nio-8080-exec-3 |RequestHandler |I| Sending redirect to: [https://localhost/partymgr/control/main]. Hidden sessionId by default. 2017-03-02 09:05:37,114 |http-nio-8080-exec-3 |ServerHitBin |I| Visit delegatorName=default, ServerHitBin delegatorName=default 2017-03-02 09:05:37,141 |http-nio-8080-exec-3 |ControlServlet |T| [[[main(Domain:http://localhost)] Request Done- total:0.563,since last([main(Domain:http...):0.563]] Mar 02, 2017 9:05:48 AM org.apache.coyote.http11.AbstractHttp11Processor process INFO: Error parsing HTTP request header Note: further occurrences of HTTP header parsing errors will be logged at DEBUG level. java.lang.IllegalArgumentException: Invalid character found in method name. HTTP method names must be tokens at org.apache.coyote.http11.AbstractNioInputBuffer.parseRequestLine(AbstractNioInputBuffer.java:233) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1017) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:684) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1520) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1476) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) at java.lang.Thread.run(Thread.java:745) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9230) Missing reference to the delegator in framework/widget/templates/HtmlFormMacroLibrary.ftl
[
https://issues.apache.org/jira/browse/OFBIZ-9230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892108#comment-15892108
]
Rishi Solanki commented on OFBIZ-9230:
--
Thanks for putting all things together and I'm good with the fix provided. The
patch attached will fix the issue reported. Also I like the idea of logging the
message that system lost the delegator and now using the default delegator,
Thanks!
==
Debug.logError("Could not get delegator using the 'default'
delegator", module);
==
Apart from the patch provided, can we consider the WidgetWorker class fix
suggested over ML. I think it would cover the #3 point mentioned by Wei, that
means systel will have the capability to get the delegator again if some how it
drops due to some reason. I don't have very strong recommendations see if we
can consider this.
> Missing reference to the delegator in
> framework/widget/templates/HtmlFormMacroLibrary.ftl
> -
>
> Key: OFBIZ-9230
> URL: https://issues.apache.org/jira/browse/OFBIZ-9230
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wei Zhang
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-9230.patch
>
>
> To reproduce
> 1. Load test data systemPropertyId="widget.autocompleter.defaultMinLength"
> systemPropertyValue="3"/>
> 2. Open https://localhost:8443/partymgr/control/main
> 3. You will still get warning below in log file
> {quote}
> 2017-02-24 12:56:16,348 |http-nio-8443-exec-7 |EntityUtilProperties
> |I| Could not get a system property for widget.autocompleter.defaultMinLength
> : null
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (OFBIZ-9230) Missing reference to the delegator in framework/widget/templates/HtmlFormMacroLibrary.ftl
[
https://issues.apache.org/jira/browse/OFBIZ-9230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki reassigned OFBIZ-9230:
Assignee: Rishi Solanki (was: Jacques Le Roux)
> Missing reference to the delegator in
> framework/widget/templates/HtmlFormMacroLibrary.ftl
> -
>
> Key: OFBIZ-9230
> URL: https://issues.apache.org/jira/browse/OFBIZ-9230
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wei Zhang
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-9230.patch
>
>
> To reproduce
> 1. Load test data systemPropertyId="widget.autocompleter.defaultMinLength"
> systemPropertyValue="3"/>
> 2. Open https://localhost:8443/partymgr/control/main
> 3. You will still get warning below in log file
> {quote}
> 2017-02-24 12:56:16,348 |http-nio-8443-exec-7 |EntityUtilProperties
> |I| Could not get a system property for widget.autocompleter.defaultMinLength
> : null
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9206) Login and logout process in demo backends (Management Apps) shows a certificate issue
[ https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892029#comment-15892029 ] Jacques Le Roux commented on OFBIZ-9206: Actually I just found the refresh needed issue is not only in logout but each time you pass before in login. For instance, not being logged, getting to profile implies that you need to login. Once logged in, you get a blanck page in stable before refreshing and seeing the profile page. It's even worse in old where the port 28080 is appended to the demo-old.ofbiz.apache.org domain. I did not change the home page after r1785098 for this reason, to be revisited... In the meantime it works well using the ofbiz-vm2.apache.org:port URLs > Login and logout process in demo backends (Management Apps) shows a > certificate issue > - > > Key: OFBIZ-9206 > URL: https://issues.apache.org/jira/browse/OFBIZ-9206 > Project: OFBiz > Issue Type: Bug > Components: Demo >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Attachments: access_log-trunk.txt, console.log-trunk.txt.zip, > OFBIZ-9206.patch, ofbiz-vm2.apache.org.yaml > > > When, from the site main page http://ofbiz.apache.org/, you get to the demos > depending on browser (tested on Windows 7) you get some issues: > * FF > ** Management Apps: OK > ** Ecommerce: OK > * Chrome (Management Apps or Ecommerce) > ** stable: OK > ** old: KO - If you copy the URL by hand it works, and after even from the > main page it works. > ** trunk: OK > * IE, same than Chrome > If, from any browser, you logout from Management Apps you get a certificate > issue. Actually as we use HSTS the browsers protect us from any 3rd party > intrusions... Same issue when login in. > So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. > Maybe it's due to how OFBiz redirects when login in or login out because, so > far, only the login page is concerned... -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9230) Missing reference to the delegator in framework/widget/templates/HtmlFormMacroLibrary.ftl
[
https://issues.apache.org/jira/browse/OFBIZ-9230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-9230:
---
Attachment: OFBIZ-9230.patch
This patch is my proposition after we discussed in dev ML:
https://s.apache.org/yaqx
Maybe we should rather show the error at the UI level and fix it, but I don't
want to shave the yak alone...
> Missing reference to the delegator in
> framework/widget/templates/HtmlFormMacroLibrary.ftl
> -
>
> Key: OFBIZ-9230
> URL: https://issues.apache.org/jira/browse/OFBIZ-9230
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wei Zhang
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-9230.patch
>
>
> To reproduce
> 1. Load test data systemPropertyId="widget.autocompleter.defaultMinLength"
> systemPropertyValue="3"/>
> 2. Open https://localhost:8443/partymgr/control/main
> 3. You will still get warning below in log file
> {quote}
> 2017-02-24 12:56:16,348 |http-nio-8443-exec-7 |EntityUtilProperties
> |I| Could not get a system property for widget.autocompleter.defaultMinLength
> : null
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9233) Enable a service to run by a specific service engine
[ https://issues.apache.org/jira/browse/OFBIZ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891928#comment-15891928 ] Shi Jinghai commented on OFBIZ-9233: Hi Jacques, Thanks for your reviewing! Very appreciated. BTW, I didn't change the service-config.xsd, it allows multiple elements of service-engine in serviceengine.xml, so it's ok. Yeah, I should write more test cases :(, for example, poolId in JobSandbox can be corrected to the one in the service configuration automatically. Kind Regards, > Enable a service to run by a specific service engine > > > Key: OFBIZ-9233 > URL: https://issues.apache.org/jira/browse/OFBIZ-9233 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-9233-20170301.patch, > OFBIZ-9233-MultiServiceEnginesEnv.png > > > Currently, all of the services of OFBiz are run by the 'default' service > engine. > In a project, we have to make a service run by different service engines > rather than the 'default' one, i.e. order services run by 'order' service > engine and 'orderpool', shipment services run by 'shipment' service engine > and 'shipmentpool'. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9233) Enable a service to run by a specific service engine
[ https://issues.apache.org/jira/browse/OFBIZ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891787#comment-15891787 ] Jacques Le Roux commented on OFBIZ-9233: Hi Jinghai, I just cursorily read the patch for now, and I think it's missing changes in service-config.xsd, thanks. It's great to see a test in your patch :) > Enable a service to run by a specific service engine > > > Key: OFBIZ-9233 > URL: https://issues.apache.org/jira/browse/OFBIZ-9233 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-9233-20170301.patch, > OFBIZ-9233-MultiServiceEnginesEnv.png > > > Currently, all of the services of OFBiz are run by the 'default' service > engine. > In a project, we have to make a service run by different service engines > rather than the 'default' one, i.e. order services run by 'order' service > engine and 'orderpool', shipment services run by 'shipment' service engine > and 'shipmentpool'. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
