[jira] [Updated] (OFBIZ-7759) Link in LookupContent causes unwanted behaviour

2017-03-26 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-7759:
-
Attachment: OFBIZ-7759.patch

> Link in LookupContent causes unwanted behaviour
> ---
>
> Key: OFBIZ-7759
> URL: https://issues.apache.org/jira/browse/OFBIZ-7759
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Aditya Sharma
>Priority: Minor
>  Labels: content, locale, lookup
> Attachments: OFBIZ-7759.patch
>
>
> How to reproduce :
> - Log in the Content component
> - Go to the Content tab
> - In the search form, open the lookup of the field ' Owner Content Id '
> - Click on the search button
> - In the result list, click on a button link in the column 'Data Resource Id'
> - The form to edit the Content will be displayed (a whole OFBiz seems to be 
> accessible from this new page)
> - Close the lookup.
> - Try to reopen it, it doesn't show anything anymore.
> The only hint I've found for explaining this problem is that the request to 
> open the lookup is somehow changed.
> At first it is : 
> https://localhost:8443/content/control/LookupContent
> But then it becomes :
> https://localhost:8443/content/control/LookupLocale
> The other lookup seems unusable too after that.
> Did you already encounter this kind of problem before ?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-7759) Link in LookupContent causes unwanted behaviour

2017-03-26 Thread Aditya Sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942622#comment-15942622
 ] 

Aditya Sharma commented on OFBIZ-7759:
--

Problem:
1. Lookup dialog for ownerContentId uses "ListLookupContent" form to list 
Content records.
2. "ListLookupContent" form extends "ListContent" form for all the fields.
3. As fields dataResourceId and ownerContentId are extended fields they creates 
a link to Edit pages.
Solution:
First of all it is a lookup to select ownerContentId so as the pattern followed 
in other lookups in OFBiz it should not have any links to Edit page. If links 
are removed there will not be the problem as well.
Apart from that added 'widget-style="smallSubmit"' to contentId according to 
the uniform pattern followed.
Link to edit ownerContentId shows contentId in description rather than 
ownerContentId in "ListLookupContent" form 
updated that too.

> Link in LookupContent causes unwanted behaviour
> ---
>
> Key: OFBIZ-7759
> URL: https://issues.apache.org/jira/browse/OFBIZ-7759
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Montalbano Florian
>Assignee: Aditya Sharma
>Priority: Minor
>  Labels: content, locale, lookup
> Attachments: OFBIZ-7759.patch
>
>
> How to reproduce :
> - Log in the Content component
> - Go to the Content tab
> - In the search form, open the lookup of the field ' Owner Content Id '
> - Click on the search button
> - In the result list, click on a button link in the column 'Data Resource Id'
> - The form to edit the Content will be displayed (a whole OFBiz seems to be 
> accessible from this new page)
> - Close the lookup.
> - Try to reopen it, it doesn't show anything anymore.
> The only hint I've found for explaining this problem is that the request to 
> open the lookup is somehow changed.
> At first it is : 
> https://localhost:8443/content/control/LookupContent
> But then it becomes :
> https://localhost:8443/content/control/LookupLocale
> The other lookup seems unusable too after that.
> Did you already encounter this kind of problem before ?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (OFBIZ-8202) Use try-with-resources statement wherever it's possible

2017-03-26 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-8202.
--
Resolution: Implemented

This is finally done with r1787949

> Use try-with-resources statement wherever it's possible
> ---
>
> Key: OFBIZ-8202
> URL: https://issues.apache.org/jira/browse/OFBIZ-8202
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Release
>
>
> This is a non functional change task.
> I have already commited some such changes for OFBIZ-8115 and at r1759082



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (OFBIZ-9284) Improvement: warn users about sending a flexible report before having published it

2017-03-26 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9284.
--
Resolution: Implemented

> Improvement: warn users about sending a flexible report before having 
> published it
> --
>
> Key: OFBIZ-9284
> URL: https://issues.apache.org/jira/browse/OFBIZ-9284
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Release
>
>
> When you create a Flexible Report you get to the EditFlexibleReport screen. 
> There is a Preview panel with a Send button. If you send before having 
> # downloaded the file, 
> # conveniently edited it in Birt Report Designer 
> # and then uploaded it, 
> you get an error which is embarrassing and difficult to avoid 
> programmatically. I decided to warn users, when necessary (ie when the report 
> is not published) at the UI level. This completes OFBIZ-9194



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Reopened] (OFBIZ-9284) Improvement: warn users about sending a flexible report before having published it

2017-03-26 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-9284:


> Improvement: warn users about sending a flexible report before having 
> published it
> --
>
> Key: OFBIZ-9284
> URL: https://issues.apache.org/jira/browse/OFBIZ-9284
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Release
>
>
> When you create a Flexible Report you get to the EditFlexibleReport screen. 
> There is a Preview panel with a Send button. If you send before having 
> # downloaded the file, 
> # conveniently edited it in Birt Report Designer 
> # and then uploaded it, 
> you get an error which is embarrassing and difficult to avoid 
> programmatically. I decided to warn users, when necessary (ie when the report 
> is not published) at the UI level. This completes OFBIZ-9194



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (OFBIZ-9188) Complete Birt Flexible Reports documentation

2017-03-26 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9188.
--
Resolution: Implemented

Completed at revisions: 1788759  + 1788762


> Complete Birt Flexible Reports documentation
> 
>
> Key: OFBIZ-9188
> URL: https://issues.apache.org/jira/browse/OFBIZ-9188
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
>
> We have the documentation in French and partly in English (no users doc) but 
> since then the UI has changed and the files are PDF. We will rather provide 
> README.MD files which will also be used to generate pages in the wiki using 
> Pandoc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (OFBIZ-9284) Improvement: warn users about sending a flexible report before having published it

2017-03-26 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9284.
--
Resolution: Fixed

Implemented at revision: 1788750  


> Improvement: warn users about sending a flexible report before having 
> published it
> --
>
> Key: OFBIZ-9284
> URL: https://issues.apache.org/jira/browse/OFBIZ-9284
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Release
>
>
> When you create a Flexible Report you get to the EditFlexibleReport screen. 
> There is a Preview panel with a Send button. If you send before having 
> # downloaded the file, 
> # conveniently edited it in Birt Report Designer 
> # and then uploaded it, 
> you get an error which is embarrassing and difficult to avoid 
> programmatically. I decided to warn users, when necessary (ie when the report 
> is not published) at the UI level. This completes OFBIZ-9194



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9284) Improvement: warn users about sending a flexible report before having published it

2017-03-26 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9284:
---
Description: 
When you create a Flexible Report you get to the EditFlexibleReport screen. 
There is a Preview panel with a Send button. If you send before having 
# downloaded the file, 
# conveniently edited it in Birt Report Designer 
# and then uploaded it, 
you get an error which is embarrassing and difficult to avoid programmatically. 
I decided to warn users, when necessary (ie when the report is not published) 
at the UI level. This completes OFBIZ-9194

  was:When you create a Flexible Report you get to the EditFlexibleReport 
screen. There is a Preview panel with a Send button. If you send before having 
downloaded the file, conveniently edited it in Birt Report Designer and then 
uploaded it, you get an error which is embarrasing and difficult to avoid 
programmatically. I decided to warn users, when necessary (ie when the report 
is not published) at the UI level. This completes OFBIZ-9194


> Improvement: warn users about sending a flexible report before having 
> published it
> --
>
> Key: OFBIZ-9284
> URL: https://issues.apache.org/jira/browse/OFBIZ-9284
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Release
>
>
> When you create a Flexible Report you get to the EditFlexibleReport screen. 
> There is a Preview panel with a Send button. If you send before having 
> # downloaded the file, 
> # conveniently edited it in Birt Report Designer 
> # and then uploaded it, 
> you get an error which is embarrassing and difficult to avoid 
> programmatically. I decided to warn users, when necessary (ie when the report 
> is not published) at the UI level. This completes OFBIZ-9194



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9284) Improvement: warn users about sending a flexible report before having published it

2017-03-26 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9284:
---
Summary: Improvement: warn users about sending a flexible report before 
having published it  (was: Improvement: warn users about sending a flexible 
report before having pubished it)

> Improvement: warn users about sending a flexible report before having 
> published it
> --
>
> Key: OFBIZ-9284
> URL: https://issues.apache.org/jira/browse/OFBIZ-9284
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: birt
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Release
>
>
> When you create a Flexible Report you get to the EditFlexibleReport screen. 
> There is a Preview panel with a Send button. If you send before having 
> downloaded the file, conveniently edited it in Birt Report Designer and then 
> uploaded it, you get an error which is embarrasing and difficult to avoid 
> programmatically. I decided to warn users, when necessary (ie when the report 
> is not published) at the UI level. This completes OFBIZ-9194



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (OFBIZ-9284) Improvement: warn users about sending a flexible report before having pubished it

2017-03-26 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-9284:
--

 Summary: Improvement: warn users about sending a flexible report 
before having pubished it
 Key: OFBIZ-9284
 URL: https://issues.apache.org/jira/browse/OFBIZ-9284
 Project: OFBiz
  Issue Type: Sub-task
  Components: birt
Affects Versions: Trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Trivial
 Fix For: Upcoming Release


When you create a Flexible Report you get to the EditFlexibleReport screen. 
There is a Preview panel with a Send button. If you send before having 
downloaded the file, conveniently edited it in Birt Report Designer and then 
uploaded it, you get an error which is embarrasing and difficult to avoid 
programmatically. I decided to warn users, when necessary (ie when the report 
is not published) at the UI level. This completes OFBIZ-9194



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2017-03-26 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942334#comment-15942334
 ] 

Shi Jinghai commented on OFBIZ-9123:


Thank you Jacques for the reopen, and thanks Pierre and Michael for the code 
review and suggestion!

I submitted the changes in rev. 1788744, please check if it's ok now.

Kind Regards,

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9282) Refactor lists related to gateway transactions in accounting

2017-03-26 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-9282:

Attachment: OFBIZ-9282-Accounting-GatewayTransactions.patch

This patch addresses the issue.

> Refactor lists related to gateway transactions in accounting
> 
>
> Key: OFBIZ-9282
> URL: https://issues.apache.org/jira/browse/OFBIZ-9282
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>  Labels: refactoring, widget
> Attachments: OFBIZ-9282-Accounting-GatewayTransactions.patch
>
>
> Refactor various list forms into grids.
> Refactor various list form references in screen widgets.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)