[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987878#comment-15987878 ] Shi Jinghai commented on OFBIZ-8316: Thanks Michael. Go go go :) > Update Apache Solr/Lucene to release 6.2.1 > -- > > Key: OFBIZ-8316 > URL: https://issues.apache.org/jira/browse/OFBIZ-8316 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-8316_corrected.patch, > ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, > solr6.2.1_1.patch > > > According to the announcements in > https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E > and > https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E > there is a new Solr/Lucene release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9339) adding product to purchase order auto assigned PRODUCT_ORDER_ITEM
Wai created OFBIZ-9339: -- Summary: adding product to purchase order auto assigned PRODUCT_ORDER_ITEM Key: OFBIZ-9339 URL: https://issues.apache.org/jira/browse/OFBIZ-9339 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Wai When creating a purchase order. Adding an product without specifying the "Item Type" is automatically given value of PRODUCT_ORDER_ITEM. The permitted values should be: ASSET_ORDER_ITEM, SUPPLIES_ORDER_ITEM, INVENTORY_ORDER_ITEM (as shown in the dropdown) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987616#comment-15987616 ] Michael Brohl commented on OFBIZ-8316: -- solr 6.5.1 was released today. > Update Apache Solr/Lucene to release 6.2.1 > -- > > Key: OFBIZ-8316 > URL: https://issues.apache.org/jira/browse/OFBIZ-8316 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-8316_corrected.patch, > ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, > solr6.2.1_1.patch > > > According to the announcements in > https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E > and > https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E > there is a new Solr/Lucene release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9166) Create and use an OWASP PolicyFactory for content sanitization in ContentWorker for Birt Flexible Reports
[ https://issues.apache.org/jira/browse/OFBIZ-9166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9166: --- Summary: Create and use an OWASP PolicyFactory for content sanitization in ContentWorker for Birt Flexible Reports (was: Create and use an OWASP PolicyFactory for content sanitization in ContentWorker for Birt Report Builder) > Create and use an OWASP PolicyFactory for content sanitization in > ContentWorker for Birt Flexible Reports > - > > Key: OFBIZ-9166 > URL: https://issues.apache.org/jira/browse/OFBIZ-9166 > Project: OFBiz > Issue Type: Sub-task > Components: birt, content, framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: Upcoming Release > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9251) Add support for 'set-if-null' and 'set-if-empty' attributes on screens for set element.
[ https://issues.apache.org/jira/browse/OFBIZ-9251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9251: - Attachment: OFBIZ-9251.patch 1. Updated widget-common.xsd with the new attributes. 2. is implemented with SetField inner class of AbstractModelAction. 3. Added new fields setIdEmpty and setIfNull & added checks for the same. > Add support for 'set-if-null' and 'set-if-empty' attributes on screens for > set element. > --- > > Key: OFBIZ-9251 > URL: https://issues.apache.org/jira/browse/OFBIZ-9251 > Project: OFBiz > Issue Type: Improvement >Reporter: Aditya Sharma >Assignee: Aditya Sharma > Attachments: OFBIZ-9251.patch > > > "set-if-null" controls if field can be set to null and "set-if-empty" > controls if field can be set to an empty value. Both these attributes are > supported by "set" element of simple-method and similar support should be > there on the screen. > As stated in the discussion: > http://ofbiz.markmail.org/thread/hembr4hiabgwr7cs -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9338) Several file names do not adhere to conventions applied to same files in other components
[ https://issues.apache.org/jira/browse/OFBIZ-9338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986536#comment-15986536 ] Michael Brohl commented on OFBIZ-9338: -- [~pfm.smits], you should at least list the file names you want renamed, else the Jira is quite useless. Please enhance, thanks. > Several file names do not adhere to conventions applied to same files in > other components > - > > Key: OFBIZ-9338 > URL: https://issues.apache.org/jira/browse/OFBIZ-9338 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order, product >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Trivial > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (OFBIZ-9338) Several file names do not adhere to conventions applied to same files in other components
[ https://issues.apache.org/jira/browse/OFBIZ-9338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-9338: Assignee: Michael Brohl > Several file names do not adhere to conventions applied to same files in > other components > - > > Key: OFBIZ-9338 > URL: https://issues.apache.org/jira/browse/OFBIZ-9338 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order, product >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Trivial > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9338) Several file names do not adhere to conventions applied to same files in other components
[ https://issues.apache.org/jira/browse/OFBIZ-9338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-9338: - Issue Type: Improvement (was: Bug) > Several file names do not adhere to conventions applied to same files in > other components > - > > Key: OFBIZ-9338 > URL: https://issues.apache.org/jira/browse/OFBIZ-9338 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order, product >Affects Versions: Trunk >Reporter: Pierre Smits > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9338) Several file names do not adhere to conventions applied to same files in other components
Pierre Smits created OFBIZ-9338: --- Summary: Several file names do not adhere to conventions applied to same files in other components Key: OFBIZ-9338 URL: https://issues.apache.org/jira/browse/OFBIZ-9338 Project: OFBiz Issue Type: Bug Components: accounting, order, product Affects Versions: Trunk Reporter: Pierre Smits -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9322) Remove all dependencies from OFBiz framework to plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986414#comment-15986414 ] Taher Alkhateeb commented on OFBIZ-9322: Made first commits in ofbiz-framework r1792866 and ofbizplugins r1792867 which removed most (I think over 90%) of all dependencies. I only have about 9 or so tests failing on ofbiz-framework standalone. > Remove all dependencies from OFBiz framework to plugins > --- > > Key: OFBIZ-9322 > URL: https://issues.apache.org/jira/browse/OFBIZ-9322 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > > The OFBiz [framework > repository|http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk] fails > to build and run tests unless the [plugins > repository|http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk] is > added first. > The reason for this failure is mostly due to dependencies of some tests > defined in the framework on data that is defined in the ecommerce plugin. > The purpose of this JIRA is to completely remove all these dependencies and > achieve a successful build of the framework using the command "./gradlew > cleanAll loadDefault testIntegration" > This task requires multiple different approaches including: > - Moving some demo data from ecommerce to framework > - Moving some tests where relevant from framework to ecommerce > - Refactoring and/or removing some tests to disentangle the dependencies -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9322) Remove all dependencies from OFBiz framework to plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986414#comment-15986414 ] Taher Alkhateeb edited comment on OFBIZ-9322 at 4/27/17 11:44 AM: -- Made first commits in ofbiz-framework r1792866 and ofbiz-plugins r1792867 which removed most (I think over 90%) of all dependencies. I only have about 9 or so tests failing on ofbiz-framework standalone. was (Author: taher): Made first commits in ofbiz-framework r1792866 and ofbizplugins r1792867 which removed most (I think over 90%) of all dependencies. I only have about 9 or so tests failing on ofbiz-framework standalone. > Remove all dependencies from OFBiz framework to plugins > --- > > Key: OFBIZ-9322 > URL: https://issues.apache.org/jira/browse/OFBIZ-9322 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > > The OFBiz [framework > repository|http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk] fails > to build and run tests unless the [plugins > repository|http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk] is > added first. > The reason for this failure is mostly due to dependencies of some tests > defined in the framework on data that is defined in the ecommerce plugin. > The purpose of this JIRA is to completely remove all these dependencies and > achieve a successful build of the framework using the command "./gradlew > cleanAll loadDefault testIntegration" > This task requires multiple different approaches including: > - Moving some demo data from ecommerce to framework > - Moving some tests where relevant from framework to ecommerce > - Refactoring and/or removing some tests to disentangle the dependencies -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9303) Remove hard-coded success/error message variables set in service output
[
https://issues.apache.org/jira/browse/OFBIZ-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986263#comment-15986263
]
Devanshu Vyas commented on OFBIZ-9303:
--
Hi Deepak,
I checked, there are no instances to fixed in the plugins. I think you are
referring to code such as..
{code}
result = ServiceUtil.returnError(result.get("errorMessage").toString());
{code}
This ticket is solely for the purpose of correcting the
{code}
result.put("errorMessage", errMsg);
{code}
I will be creating a separate ticket for this after the current effort. Thanks
for reminding me, I almost forgot :)
And I haven't got the chance to look at the missing occurrences after patch
applied, will check and update the ticket accordingly.
> Remove hard-coded success/error message variables set in service output
>
>
> Key: OFBIZ-9303
> URL: https://issues.apache.org/jira/browse/OFBIZ-9303
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9303.patch
>
>
> I found that certain services in OFBiz set error/success message values in o
> hard-codedly like:
> {code}
> result.put("errorMessage", errMsg);
> result.put("successMessage", message);
> {code}
> I think it shouldn't be set like this, as we have constants in ModelService
> class for this purpose.
> ModelService.ERROR_MESSAGE/ModelService.SUCCESS_MESSAGE should be used to set
> the error and success messages, for in case we want to change the constant's
> value, no services will be affected.
> {code}
> result.put(ModelService.ERROR_MESSAGE, errMsg);
> result.put(ModelService.SUCCESS_MESSAGE, errMsg);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
