[jira] [Commented] (OFBIZ-9346) Maximise utilisation of common labels in AccountingMenus.xml

2017-05-06 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999576#comment-15999576
 ] 

Jacques Le Roux commented on OFBIZ-9346:


Pierre,

I did not look into every details here, but in what is this sub-taks different 
from others which were closed?

> Maximise utilisation of common labels in AccountingMenus.xml
> 
>
> Key: OFBIZ-9346
> URL: https://issues.apache.org/jira/browse/OFBIZ-9346
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-9346-AccountingMenus.xml.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-9347) Loading standard web application

2017-05-06 Thread James Yong (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999487#comment-15999487
 ] 

James Yong commented on OFBIZ-9347:
---

For testing, you can unzip a WAR file and put the folder under *webapp* folder 
as shown below
{code}
[plugins]
-> [your plugin name]
-> ofbiz-component.xml
-> [webapp]
-> [put your unzip WAR file here]
{code}

Contents of ofbiz-component.xml will be something like
{code}
http://www.w3.org/2001/XMLSchema-instance;

xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/ofbiz-component.xsd;>


{code}

> Loading standard web application
> 
>
> Key: OFBIZ-9347
> URL: https://issues.apache.org/jira/browse/OFBIZ-9347
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Release
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9347.patch
>
>
> Not all libraries can be embedded and used via Java API. 
> Some, like CAS SSO, need to be loaded as a standard web application and 
> access via REST API. 
> So we need to allow OFBiz to load standard web application where there is no 
> controller.xml and the jar files residing in WEB-INF/lib folder.  
> Proposing to add an attribute named 'type' to the 'webapp' tag at 
> ofbiz-component.xml, i.e.
> {code}
>  type="standard"  <--- new proposed attribute
> title="Myapp"
> server="myapp-server"
> location="webapp/myapp"
> mount-point="/myapp"/>
> {code}
> This new attribute will help to differentiate standard web applications from 
> those in OFBiz, and allows Catalina Container to load them accordingly.
> When type="standard", will load as standard web application.
> When type is empty, load according to OFBiz way.
> There are some discussions on this at 
> https://lists.apache.org/thread.html/4d1b501c2ce6297ab0b41712b61c0fcb8881510512deaf380b49ab9d@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9347) Loading standard web application

2017-05-06 Thread James Yong (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-9347:
--
Attachment: OFBIZ-9347.patch

> Loading standard web application
> 
>
> Key: OFBIZ-9347
> URL: https://issues.apache.org/jira/browse/OFBIZ-9347
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Release
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9347.patch
>
>
> Not all libraries can be embedded and used via Java API. 
> Some, like CAS SSO, need to be loaded as a standard web application and 
> access via REST API. 
> So we need to allow OFBiz to load standard web application where there is no 
> controller.xml and the jar files residing in WEB-INF/lib folder.  
> Proposing to add an attribute named 'type' to the 'webapp' tag at 
> ofbiz-component.xml, i.e.
> {code}
>  type="standard"  <--- new proposed attribute
> title="Myapp"
> server="myapp-server"
> location="webapp/myapp"
> mount-point="/myapp"/>
> {code}
> This new attribute will help to differentiate standard web applications from 
> those in OFBiz, and allows Catalina Container to load them accordingly.
> When type="standard", will load as standard web application.
> When type is empty, load according to OFBiz way.
> There are some discussions on this at 
> https://lists.apache.org/thread.html/4d1b501c2ce6297ab0b41712b61c0fcb8881510512deaf380b49ab9d@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (OFBIZ-9347) Loading standard web application

2017-05-06 Thread James Yong (JIRA)
James Yong created OFBIZ-9347:
-

 Summary: Loading standard web application
 Key: OFBIZ-9347
 URL: https://issues.apache.org/jira/browse/OFBIZ-9347
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Upcoming Release
Reporter: James Yong
Assignee: James Yong
Priority: Minor
 Fix For: Upcoming Release


Not all libraries can be embedded and used via Java API. 
Some, like CAS SSO, need to be loaded as a standard web application and access 
via REST API. 

So we need to allow OFBiz to load standard web application where there is no 
controller.xml and the jar files residing in WEB-INF/lib folder.  

Proposing to add an attribute named 'type' to the 'webapp' tag at 
ofbiz-component.xml, i.e.
{code}

{code}

This new attribute will help to differentiate standard web applications from 
those in OFBiz, and allows Catalina Container to load them accordingly.

When type="standard", will load as standard web application.
When type is empty, load according to OFBiz way.

There are some discussions on this at 
https://lists.apache.org/thread.html/4d1b501c2ce6297ab0b41712b61c0fcb8881510512deaf380b49ab9d@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-9346) Maximise utilisation of common labels in AccountingMenus.xml

2017-05-06 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999437#comment-15999437
 ] 

Michael Brohl commented on OFBIZ-9346:
--

I think we should close as "Not A Problem" following the discussion in 
OFBIZ-8056.

> Maximise utilisation of common labels in AccountingMenus.xml
> 
>
> Key: OFBIZ-9346
> URL: https://issues.apache.org/jira/browse/OFBIZ-9346
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-9346-AccountingMenus.xml.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9346) Maximise utilisation of common labels in AccountingMenus.xml

2017-05-06 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-9346:
-
Priority: Minor  (was: Major)

> Maximise utilisation of common labels in AccountingMenus.xml
> 
>
> Key: OFBIZ-9346
> URL: https://issues.apache.org/jira/browse/OFBIZ-9346
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-9346-AccountingMenus.xml.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (OFBIZ-6738) Enhance PartyTypeAttr with a description field

2017-05-06 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-6738:
---

Assignee: Pierre Smits  (was: Jacques Le Roux)

> Enhance PartyTypeAttr with a description field
> --
>
> Key: OFBIZ-6738
> URL: https://issues.apache.org/jira/browse/OFBIZ-6738
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Fix For: 16.11.01
>
> Attachments: OFBIZ-6738-datamodel.patch, 
> OFBIZ-6738-entitymodel.xml.patch
>
>
> Currently the PartyTypeAttr entity doesn't have a means to store a 
> description for a PartyTypeAttr record. Having it enhances the user 
> experience.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9346) Maximise utilisation of common labels in AccountingMenus.xml

2017-05-06 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-9346:

Attachment: OFBIZ-9346-AccountingMenus.xml.patch

This patch addresses the issue.

> Maximise utilisation of common labels in AccountingMenus.xml
> 
>
> Key: OFBIZ-9346
> URL: https://issues.apache.org/jira/browse/OFBIZ-9346
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
> Attachments: OFBIZ-9346-AccountingMenus.xml.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (OFBIZ-9346) Maximise utilisation of common labels in AccountingMenus.xml

2017-05-06 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-9346:
---

 Summary: Maximise utilisation of common labels in 
AccountingMenus.xml
 Key: OFBIZ-9346
 URL: https://issues.apache.org/jira/browse/OFBIZ-9346
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-7265) Could not obtain Lock on lucene index Lock

2017-05-06 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999391#comment-15999391
 ] 

Jacques Le Roux commented on OFBIZ-7265:


OK done for
trunk r1794132
R16.11 and R15.12 r1794133

No need to svn:ignore, done at a upper level


> Could not obtain Lock on lucene index Lock
> --
>
> Key: OFBIZ-7265
> URL: https://issues.apache.org/jira/browse/OFBIZ-7265
> Project: OFBiz
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Release Branch 15.12, Upcoming Release, 16.11.02
>
>
> I found this message in error.log
> |xer_default_products |DocumentIndexer   |E| Could not obtain 
> Lock on lucene index Lock held by this virtual machine: 
> C:\projectASF-Mars\ofbiz\runtime\indexes\products\write.lock
> Here is Jacopo's answer:
> bq. We should not worry (because the "lucene" component is just an 
> experimental one) but let's keep an eye on it: it is caused when two threads 
> are trying to update documents in the Lucene index; it may happen when two 
> events modify data that trigger the execution of the document update. We 
> could consider to enhance the DocumentIndexer to properly manage these 
> scenarios.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-9345) Error viewing tomahawk-themed page when externalLoginKey is not enabled

2017-05-06 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999369#comment-15999369
 ] 

Jacques Le Roux commented on OFBIZ-9345:


Right James, we changed the name but did not update the doc, done, thanks!

> Error viewing tomahawk-themed page when externalLoginKey is not enabled
> ---
>
> Key: OFBIZ-9345
> URL: https://issues.apache.org/jira/browse/OFBIZ-9345
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Upcoming Release
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: tomahawk
> Fix For: Upcoming Release, 16.11.02
>
> Attachments: OFBIZ-9345.patch
>
>
> The following error occurs when the theme is set to *tomahawk* and 
> *security.login.externalLoginKey.enabled=false*:
> {code}
> 2017-05-04 22:57:42,818 |http-nio-8443-exec-8 |FreeMarkerWorker  
> |E| null
> freemarker.core.InvalidReferenceException: The following has evaluated to 
> null or missing:
> ==> externalLoginKey  [in template 
> "component://tomahawk/template/AppBarClose.ftl" at line 88, column 113]
> 
> Tip: If the failing expression is known to be legally refer to something 
> that's sometimes null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
> 
> 
> FTL stack trace ("~" means nesting-related):
>   - Failed at: ${externalLoginKey}  [in template 
> "component://tomahawk/template/AppBarClose.ftl" at line 88, column 111]
> 
>   at 
> freemarker.core.InvalidReferenceException.getInstance(InvalidReferenceException.java:134)
>  ~[freemarker-2.3.25-incubating.jar:2.3.25]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-9345) Error viewing tomahawk-themed page when externalLoginKey is not enabled

2017-05-06 Thread James Yong (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999364#comment-15999364
 ] 

James Yong commented on OFBIZ-9345:
---

Thanks [~jacques.le.roux] for the correction and follow-up.

In the wiki section mentioned, should the terms "Upcoming Branch" be "Upcoming 
Release" instead? 

> Error viewing tomahawk-themed page when externalLoginKey is not enabled
> ---
>
> Key: OFBIZ-9345
> URL: https://issues.apache.org/jira/browse/OFBIZ-9345
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Upcoming Release
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: tomahawk
> Fix For: Upcoming Release, 16.11.02
>
> Attachments: OFBIZ-9345.patch
>
>
> The following error occurs when the theme is set to *tomahawk* and 
> *security.login.externalLoginKey.enabled=false*:
> {code}
> 2017-05-04 22:57:42,818 |http-nio-8443-exec-8 |FreeMarkerWorker  
> |E| null
> freemarker.core.InvalidReferenceException: The following has evaluated to 
> null or missing:
> ==> externalLoginKey  [in template 
> "component://tomahawk/template/AppBarClose.ftl" at line 88, column 113]
> 
> Tip: If the failing expression is known to be legally refer to something 
> that's sometimes null or missing, either specify a default value like 
> myOptionalVar!myDefault, or use <#if 
> myOptionalVar??>when-present<#else>when-missing. (These only cover the 
> last step of the expression; to cover the whole expression, use parenthesis: 
> (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
> 
> 
> FTL stack trace ("~" means nesting-related):
>   - Failed at: ${externalLoginKey}  [in template 
> "component://tomahawk/template/AppBarClose.ftl" at line 88, column 111]
> 
>   at 
> freemarker.core.InvalidReferenceException.getInstance(InvalidReferenceException.java:134)
>  ~[freemarker-2.3.25-incubating.jar:2.3.25]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)