[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005852#comment-16005852 ] Shi Jinghai commented on OFBIZ-8316: Thanks Cao Pengan for the new 6.5.1 patch! I have submitted it to plugins-trunk, rev.1794770, 1794771. Cheers, > Update Apache Solr/Lucene to release 6.2.1 > -- > > Key: OFBIZ-8316 > URL: https://issues.apache.org/jira/browse/OFBIZ-8316 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-8316_corrected.patch, > ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, > solr6.2.1_1.patch > > > According to the announcements in > https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E > and > https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E > there is a new Solr/Lucene release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9352) Remove unused labels from AccountingUiLabels.xml
[ https://issues.apache.org/jira/browse/OFBIZ-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005721#comment-16005721 ] Scott Gray commented on OFBIZ-9352: --- Before removing them I would prefer it if we answered the question: why are they unused? It's extremely rare for a label to be introduced without being used, so we can probably assume that they were used at some point. Having a few unused labels isn't a big deal compared to the time required to gain the translations in the first place. So even if it is a bit arduous to figure out, I would prefer to know how these labels came to be unused before we remove them. The English versions seem to me to be potentially useful enough for adopters if they have a use-case, even if OFBiz doesn't currently have a use for them. > Remove unused labels from AccountingUiLabels.xml > > > Key: OFBIZ-9352 > URL: https://issues.apache.org/jira/browse/OFBIZ-9352 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-9352-AccountingUiLabels.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9347) Loading standard web application
[
https://issues.apache.org/jira/browse/OFBIZ-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005709#comment-16005709
]
Scott Gray commented on OFBIZ-9347:
---
Maybe my knowledge is out of date, but this used to be possible without needing
any framework changes. So long as there is a web.xml file in the appropriate
place and your servlets/filters etc. are on the classpath then everything
should just work. No component is hard-coded to use the ControlServlet, it's
just that all OFBiz apps are configured to use it.
Could you describe the issue you ran into?
> Loading standard web application
>
>
> Key: OFBIZ-9347
> URL: https://issues.apache.org/jira/browse/OFBIZ-9347
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Upcoming Release
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9347.patch
>
>
> Not all libraries can be embedded and used via Java API.
> Some, like CAS SSO, need to be loaded as a standard web application and
> access via REST API.
> So we need to allow OFBiz to load standard web application where there is no
> controller.xml and the jar files residing in WEB-INF/lib folder.
> Proposing to add an attribute named 'type' to the 'webapp' tag at
> ofbiz-component.xml, i.e.
> {code}
> type="standard" <--- new proposed attribute
> title="Myapp"
> server="myapp-server"
> location="webapp/myapp"
> mount-point="/myapp"/>
> {code}
> This new attribute will help to differentiate standard web applications from
> those in OFBiz, and allows Catalina Container to load them accordingly.
> When type="standard", will load as standard web application.
> When type is empty, load according to OFBiz way.
> There are some discussions on this at
> https://lists.apache.org/thread.html/4d1b501c2ce6297ab0b41712b61c0fcb8881510512deaf380b49ab9d@%3Cdev.ofbiz.apache.org%3E
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9339) adding product to purchase order auto assigned PRODUCT_ORDER_ITEM
[ https://issues.apache.org/jira/browse/OFBIZ-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005517#comment-16005517 ] Wai commented on OFBIZ-9339: Michael Brohl: I haven't checked the code. Looks like it's in the user interface. I'll check later. > adding product to purchase order auto assigned PRODUCT_ORDER_ITEM > - > > Key: OFBIZ-9339 > URL: https://issues.apache.org/jira/browse/OFBIZ-9339 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Wai > > When creating a purchase order. Adding an product without specifying the > "Item Type" is automatically given value of PRODUCT_ORDER_ITEM. The permitted > values should be: ASSET_ORDER_ITEM, SUPPLIES_ORDER_ITEM, INVENTORY_ORDER_ITEM > (as shown in the dropdown) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-9354) Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong" respectively which are primary keys
[ https://issues.apache.org/jira/browse/OFBIZ-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9354. -- Resolution: Done Fix Version/s: Upcoming Release Thanks Aditya, Deepak, Aditya, your patches are in trunk at revision: 1794743 Later when we will do OFBIZ-9355, it will be easy to check that we have not forgotten any concerned primary keys. As mentionned Deepak it was redundant/useless to use id-ne for them. > Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", > "id-long" and "id-vlong" respectively which are primary keys > --- > > Key: OFBIZ-9354 > URL: https://issues.apache.org/jira/browse/OFBIZ-9354 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Release > > Attachments: OFBIZ-9354_frameworkEntityModel.patch, > OFBIZ-9354_frameworkEntityModelTest.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (OFBIZ-9354) Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong" respectively which are primary keys
[ https://issues.apache.org/jira/browse/OFBIZ-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9354: -- Assignee: Jacques Le Roux > Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", > "id-long" and "id-vlong" respectively which are primary keys > --- > > Key: OFBIZ-9354 > URL: https://issues.apache.org/jira/browse/OFBIZ-9354 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: OFBIZ-9354_frameworkEntityModel.patch, > OFBIZ-9354_frameworkEntityModelTest.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9354) Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong" respectively which are primary keys
[ https://issues.apache.org/jira/browse/OFBIZ-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9354: - Attachment: OFBIZ-9354_frameworkEntityModelTest.patch OFBIZ-9354_frameworkEntityModel.patch Replaced in entitymodel.xml and entitymodel_test.xml (framework). > Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", > "id-long" and "id-vlong" respectively which are primary keys > --- > > Key: OFBIZ-9354 > URL: https://issues.apache.org/jira/browse/OFBIZ-9354 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Priority: Trivial > Attachments: OFBIZ-9354_frameworkEntityModel.patch, > OFBIZ-9354_frameworkEntityModelTest.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9354) Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong" respectively which are primary keys
Aditya Sharma created OFBIZ-9354: Summary: Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong" respectively which are primary keys Key: OFBIZ-9354 URL: https://issues.apache.org/jira/browse/OFBIZ-9354 Project: OFBiz Issue Type: Sub-task Reporter: Aditya Sharma Priority: Trivial -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9355) Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong" respectively which are not primary keys
Aditya Sharma created OFBIZ-9355: Summary: Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong" respectively which are not primary keys Key: OFBIZ-9355 URL: https://issues.apache.org/jira/browse/OFBIZ-9355 Project: OFBiz Issue Type: Sub-task Reporter: Aditya Sharma Priority: Trivial -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004706#comment-16004706
]
Aditya Sharma commented on OFBIZ-9351:
--
+1
As no of occurrences is a really large figure.
Just to keep a track and distinguish them I would prefer to create 2 separate
sub-tickets for primary and non-primary occurrences.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9339) adding product to purchase order auto assigned PRODUCT_ORDER_ITEM
[ https://issues.apache.org/jira/browse/OFBIZ-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004410#comment-16004410 ] Jacques Le Roux edited comment on OFBIZ-9339 at 5/10/17 9:46 AM: - Thanks Wai, Michael, Yes, it should be a least using a label in the drop-down, as it's the default. I guess the rest should be OK (according to Michael, did not check details) was (Author: jacques.le.roux): Thanks Wai, Michael, Yes, it should be a least using a label as it's the default. I guess the rest should be OK (according to Michael, did not check details) > adding product to purchase order auto assigned PRODUCT_ORDER_ITEM > - > > Key: OFBIZ-9339 > URL: https://issues.apache.org/jira/browse/OFBIZ-9339 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Wai > > When creating a purchase order. Adding an product without specifying the > "Item Type" is automatically given value of PRODUCT_ORDER_ITEM. The permitted > values should be: ASSET_ORDER_ITEM, SUPPLIES_ORDER_ITEM, INVENTORY_ORDER_ITEM > (as shown in the dropdown) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9339) adding product to purchase order auto assigned PRODUCT_ORDER_ITEM
[ https://issues.apache.org/jira/browse/OFBIZ-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004410#comment-16004410 ] Jacques Le Roux commented on OFBIZ-9339: Thanks Wai, Michael, Yes, it should be a least using a label as it's the default. I guess the rest should be OK (according to Michael, did not check details) > adding product to purchase order auto assigned PRODUCT_ORDER_ITEM > - > > Key: OFBIZ-9339 > URL: https://issues.apache.org/jira/browse/OFBIZ-9339 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Wai > > When creating a purchase order. Adding an product without specifying the > "Item Type" is automatically given value of PRODUCT_ORDER_ITEM. The permitted > values should be: ASSET_ORDER_ITEM, SUPPLIES_ORDER_ITEM, INVENTORY_ORDER_ITEM > (as shown in the dropdown) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
