[jira] [Created] (OFBIZ-9357) Rename Lucene runtime folders to clearly show the origin
Jacques Le Roux created OFBIZ-9357: -- Summary: Rename Lucene runtime folders to clearly show the origin Key: OFBIZ-9357 URL: https://issues.apache.org/jira/browse/OFBIZ-9357 Project: OFBiz Issue Type: Improvement Components: lucene Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Trivial Fix For: Upcoming Release As explained at bottom of OFBIZ-8316: The runtime\indexes\content and runtime\indexes\product dirs are only used by Lucene. I suggest to have as defaults runtime\indexes\lucene\content and runtime\indexes\product and to keep runtime\indexes\solr as is. It will be configurable using properties. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8316. -- Resolution: Done Fix Version/s: Upcoming Release > Update Apache Solr/Lucene to release 6.2.1 > -- > > Key: OFBIZ-8316 > URL: https://issues.apache.org/jira/browse/OFBIZ-8316 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Shi Jinghai >Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-8316_corrected.patch, > ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, > solr6.2.1_1.patch > > > According to the announcements in > https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E > and > https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E > there is a new Solr/Lucene release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007244#comment-16007244
]
Jacques Le Roux commented on OFBIZ-8316:
Thanks Jinghai, Michael,
Michael,
bq. I would leave it as it is here. Solr uses Lucene for indexing so there is
in fact no Solr index but a Lucene index created through Solr. Since the
component is named Solr, it makes sense to name it as is.
After JInghai's answer, I made a quick review. The runtime\indexes\content and
runtime\indexes\product dirs are only used by Lucene. The runtime\indexes\solr
is only used by Solr. So I suggest rather to have as defaults
runtime\indexes\lucene\content and runtime\indexes\product and to keep
runtime\indexes\solr as is. I agree it should be configurable and it's worth
another issue, I'll create one after closing here, where from my POV all is
clear.
I noticed that Solr separates the index and the data (snapshot_metadata) and
not Lucene. For Solr this is related with solr.data.dir definition, in OFBIz
it's runtime/indexes/solr (I changed that recently with OFBIZ-7265)
bq. ${solr.data.dir:runtime/indexes/solr}
I think it's not an issue, our usage of Lucene is OFBiz specific.
> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
> Issue Type: Improvement
> Components: lucene, solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch,
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch,
> solr6.2.1_1.patch
>
>
> According to the announcements in
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
> and
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
> there is a new Solr/Lucene release available.
> This issue takes care of the update.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (OFBIZ-9356) Enable org.apache.ofbiz.stats group
Deepak Dixit created OFBIZ-9356: --- Summary: Enable org.apache.ofbiz.stats group Key: OFBIZ-9356 URL: https://issues.apache.org/jira/browse/OFBIZ-9356 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Deepak Dixit Priority: Minor At r#1647271, stats related entities foreign key relation has been removed by Jacopo and new group org.apache.ofbiz.stats introduced for stats related entity but this group is commented out, Enable org.apache.ofbiz.stats group and add this in delegator group mapping in entityengine.xml -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006930#comment-16006930 ] Michael Brohl commented on OFBIZ-8316: -- [~jacques.le.roux], ??I wonder if we should not rename "runtime/indexes/solr" to "runtime/indexes/solrAndLucene" just to let know users that all Solr and Lucene indexes are there.?? I would leave it as it is here. Solr uses Lucene for indexing so there is in fact no Solr index but a Lucene index created through Solr. Since the component is named Solr, it makes sense to name it as is. > Update Apache Solr/Lucene to release 6.2.1 > -- > > Key: OFBIZ-8316 > URL: https://issues.apache.org/jira/browse/OFBIZ-8316 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-8316_corrected.patch, > ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, > solr6.2.1_1.patch > > > According to the announcements in > https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E > and > https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E > there is a new Solr/Lucene release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006190#comment-16006190 ] Shi Jinghai commented on OFBIZ-8316: Yes, Pengan and me are in the same team. Pengan gave me the patch face to face a week ago. I'm a bit late to check them in. :) I removed the comments related to this issue in rev. 1794801. On the "runtime/indexes/products", the "products" index name is hardcoded in plugins/lucene/src/main/java/org/apache/ofbiz/content/search/SearchServices.java: DocumentIndexer indexer = DocumentIndexer.getInstance(delegator, "products"); > Update Apache Solr/Lucene to release 6.2.1 > -- > > Key: OFBIZ-8316 > URL: https://issues.apache.org/jira/browse/OFBIZ-8316 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-8316_corrected.patch, > ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, > solr6.2.1_1.patch > > > According to the announcements in > https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E > and > https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E > there is a new Solr/Lucene release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006114#comment-16006114
]
Jacques Le Roux edited comment on OFBIZ-8316 at 5/11/17 8:58 AM:
-
Thanks Cao Pengan, Jinghai, Michael,
The error I reported
bq. Error waiting for SolrCore to be created
I guess (as suggested by Jinghai) was fixed by OFBIZ-7265 (can't reproduce)
After reviewing rev.1794770, 1794771 I tough see few reasons to keep this
issue open, for at least discussion.
Jinghai, do we really need to keep these commented out lines?
https://s.apache.org/DTEG
Form your comment
bq. OFBiz-8316, the LongPoint should be reused when updating to Solr 6.4.1 or
later
it seems not.
What about
{code}
- ${solr.data.dir:runtime/indexes/solr}
+ ${ofbiz.home}/runtime/indexes/products/
{code}
Should we not put all under runtime/indexes/solr. So here
runtime/indexes/solr/products? I know it changes habits, so not sure.
I wonder if we should not rename "runtime/indexes/solr" to
"runtime/indexes/solrAndLucene" just to let know users that all Solr and Lucene
indexes are there.
On the Solr admin UI, can't we remove the now confusing "Use original UI",
since we only use one now (not a big deal).
Ah Jinghai, I just noticed something trivial and very ASF formal. You say
bq. Thanks Cao Pengan for the new 6.5.1 patch!
But I don't see this patch. For me, it's not really an issue. But, following
ASF rules, the patch should have been attached by Cao Pengan before being
committed by you ;)
+The idea is:+ it's the *person* who contribute who delegates her/his rights
(copyright) to the ASF. Of course if you did not have wrote this sentence I'd
not know. I know other teams (I guess you somehow works with Cao Pengan) are
doing that (still not orthodox). Not a big deal, more for you to know :)
was (Author: jacques.le.roux):
Thanks Cao Pengan, Jinghai, Michael,
The error I reported
bq. Error waiting for SolrCore to be created
I guess (as suggested by Jinghai) was fixed by OFBIZ-7265 (can't reproduce)
After reviewing rev.1794770, 1794771 I tough see few reason to keep this issue
open, for at least discussion.
Jinghai, do we really need to keep these commented out lines?
https://s.apache.org/DTEG
Form your comment
bq. OFBiz-8316, the LongPoint should be reused when updating to Solr 6.4.1 or
later
it seems not.
What about
{code}
- ${solr.data.dir:runtime/indexes/solr}
+ ${ofbiz.home}/runtime/indexes/products/
{code}
Should we not put all under runtime/indexes/solr. So here
runtime/indexes/solr/products? I know it changes habits, so not sure.
I wonder if we should not rename "runtime/indexes/solr" to
"runtime/indexes/solrAndLucene" just to let know users that all Solr and Lucene
indexes are there.
On the Solr admin UI, can't we remove the now confusing "Use original UI",
since we only use it now (not a big deal).
Ah Jinghai, I just noticed something trivial and very ASF formal. You say
bq. Thanks Cao Pengan for the new 6.5.1 patch!
But I don't see this patch. For me, it's not really an issue. But, following
ASF rules, the patch should have been attached by Cao Pengan before being
committed by you ;)
+The idea is:+ it's the *person* who contribute who delegates her/his rights
(copyright) to the ASF. Of course if you did not have wrote this sentence I'd
not know. I know other teams (I guess you somehow works with Cao Pengan) are
doing that (still not orthodox). Not a big deal, more for you to know :)
> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
> Issue Type: Improvement
> Components: lucene, solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch,
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch,
> solr6.2.1_1.patch
>
>
> According to the announcements in
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
> and
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
> there is a new Solr/Lucene release available.
> This issue takes care of the update.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006114#comment-16006114
]
Jacques Le Roux commented on OFBIZ-8316:
Thanks Cao Pengan, Jinghai, Michael,
The error I reported
bq. Error waiting for SolrCore to be created
I guess (as suggested by Jinghai) was fixed by OFBIZ-7265 (can't reproduce)
After reviewing rev.1794770, 1794771 I tough see few reason to keep this issue
open, for at least discussion.
Jinghai, do we really need to keep these commented out lines?
https://s.apache.org/DTEG
Form your comment
bq. OFBiz-8316, the LongPoint should be reused when updating to Solr 6.4.1 or
later
it seems not.
What about
{code}
- ${solr.data.dir:runtime/indexes/solr}
+ ${ofbiz.home}/runtime/indexes/products/
{code}
Should we not put all under runtime/indexes/solr. So here
runtime/indexes/solr/products? I know it changes habits, so not sure.
I wonder if we should not rename "runtime/indexes/solr" to
"runtime/indexes/solrAndLucene" just to let know users that all Solr and Lucene
indexes are there.
On the Solr admin UI, can't we remove the now confusing "Use original UI",
since we only use it now (not a big deal).
Ah Jinghai, I just noticed something trivial and very ASF formal. You say
bq. Thanks Cao Pengan for the new 6.5.1 patch!
But I don't see this patch. For me, it's not really an issue. But, following
ASF rules, the patch should have been attached by Cao Pengan before being
committed by you ;)
+The idea is:+ it's the *person* who contribute who delegates her/his rights
(copyright) to the ASF. Of course if you did not have wrote this sentence I'd
not know. I know other teams (I guess you somehow works with Cao Pengan) are
doing that (still not orthodox). Not a big deal, more for you to know :)
> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
> Issue Type: Improvement
> Components: lucene, solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch,
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch,
> solr6.2.1_1.patch
>
>
> According to the announcements in
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
> and
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
> there is a new Solr/Lucene release available.
> This issue takes care of the update.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9347) Loading standard web application
[
https://issues.apache.org/jira/browse/OFBIZ-9347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006092#comment-16006092
]
James Yong commented on OFBIZ-9347:
---
Hi [~lektran],
I was using Gradle to download, explode and overlay a CAS SSO war during OFBiz
build process.
After getting the above working which include some changes to
CatalinaContainer, I wrongly assumed that a standard web application manually
placed in webapp folder no longer works. Just tested that loading standard web
application is still working in trunk version.
My sincere apologies for the mistake.
Regards,
James Yong
> Loading standard web application
>
>
> Key: OFBIZ-9347
> URL: https://issues.apache.org/jira/browse/OFBIZ-9347
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Upcoming Release
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9347.patch
>
>
> Not all libraries can be embedded and used via Java API.
> Some, like CAS SSO, need to be loaded as a standard web application and
> access via REST API.
> So we need to allow OFBiz to load standard web application where there is no
> controller.xml and the jar files residing in WEB-INF/lib folder.
> Proposing to add an attribute named 'type' to the 'webapp' tag at
> ofbiz-component.xml, i.e.
> {code}
> type="standard" <--- new proposed attribute
> title="Myapp"
> server="myapp-server"
> location="webapp/myapp"
> mount-point="/myapp"/>
> {code}
> This new attribute will help to differentiate standard web applications from
> those in OFBiz, and allows Catalina Container to load them accordingly.
> When type="standard", will load as standard web application.
> When type is empty, load according to OFBiz way.
> There are some discussions on this at
> https://lists.apache.org/thread.html/4d1b501c2ce6297ab0b41712b61c0fcb8881510512deaf380b49ab9d@%3Cdev.ofbiz.apache.org%3E
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9352) Remove unused labels from AccountingUiLabels.xml
[ https://issues.apache.org/jira/browse/OFBIZ-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006081#comment-16006081 ] Michael Brohl commented on OFBIZ-9352: -- I agree with Scott that we should check why labels are obsolete. If we find that they are unused for good reasons, e.g. the were not removed when the corresponding code was removed or they were introduced but never used, they should be deleted. It's like unused code to stay commented in the code base because one might find it useful some day. It clutters the codebase. If we want to resurrect them, we have the version control for it. Another way would be to put them in another place outside of the project but I'm not sure if it is worth the effort. > Remove unused labels from AccountingUiLabels.xml > > > Key: OFBIZ-9352 > URL: https://issues.apache.org/jira/browse/OFBIZ-9352 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-9352-AccountingUiLabels.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006013#comment-16006013 ] Michael Brohl commented on OFBIZ-8316: -- Thanks, [~shi.jinghai], I think you can close this ticket, no? Regards, Michael > Update Apache Solr/Lucene to release 6.2.1 > -- > > Key: OFBIZ-8316 > URL: https://issues.apache.org/jira/browse/OFBIZ-8316 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-8316_corrected.patch, > ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, > solr6.2.1_1.patch > > > According to the announcements in > https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E > and > https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E > there is a new Solr/Lucene release available. > This issue takes care of the update. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
