[jira] [Closed] (OFBIZ-9390) Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, OAuth2LinkedIn and LinkedInUser entities.
[ https://issues.apache.org/jira/browse/OFBIZ-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Renuka Srishti closed OFBIZ-9390. - > Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, > OAuth2LinkedIn and LinkedInUser entities. > --- > > Key: OFBIZ-9390 > URL: https://issues.apache.org/jira/browse/OFBIZ-9390 > Project: OFBiz > Issue Type: Bug > Components: passport >Affects Versions: Trunk >Reporter: Renuka Srishti >Assignee: Renuka Srishti > Fix For: Trunk > > Attachments: OFBIZ-9390.patch, OFBiz9390.png > > > PassportEntityLabels does not exist, but its reference is used in > passport/entitydef/entitymodel.xml -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9390) Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, OAuth2LinkedIn and LinkedInUser entities.
[ https://issues.apache.org/jira/browse/OFBIZ-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042790#comment-16042790 ] Renuka Srishti commented on OFBIZ-9390: --- Thanks Shi and Thanks Jacques for the honor. > Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, > OAuth2LinkedIn and LinkedInUser entities. > --- > > Key: OFBIZ-9390 > URL: https://issues.apache.org/jira/browse/OFBIZ-9390 > Project: OFBiz > Issue Type: Bug > Components: passport >Affects Versions: Trunk >Reporter: Renuka Srishti >Assignee: Renuka Srishti > Attachments: OFBIZ-9390.patch, OFBiz9390.png > > > PassportEntityLabels does not exist, but its reference is used in > passport/entitydef/entitymodel.xml -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9390) Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, OAuth2LinkedIn and LinkedInUser entities.
[ https://issues.apache.org/jira/browse/OFBIZ-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042649#comment-16042649 ] Jacques Le Roux commented on OFBIZ-9390: Thanks to both, We now need to close the issue. Renuka would you like the honor :) ? > Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, > OAuth2LinkedIn and LinkedInUser entities. > --- > > Key: OFBIZ-9390 > URL: https://issues.apache.org/jira/browse/OFBIZ-9390 > Project: OFBiz > Issue Type: Bug > Components: passport >Affects Versions: Trunk >Reporter: Renuka Srishti >Assignee: Renuka Srishti > Attachments: OFBIZ-9390.patch, OFBiz9390.png > > > PassportEntityLabels does not exist, but its reference is used in > passport/entitydef/entitymodel.xml -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9392) Refactor CatalinaContainer
[ https://issues.apache.org/jira/browse/OFBIZ-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-9392: --- Attachment: OFBIZ-9392.patch Attaching a patch for refactoring the CatalinaContainer No functional change, but an almost complete rewrite of the tomcat container with the following highlights: - breakup the logic in init() many smaller functions each specializing in one thing - Unify the host creation logic between main host and context-specific hosts - introduce streams and lambdas where appropriate - rename loadComponents() to loadWebapps() - rename createContext() to createCallableContext() - rename configureContext() to prepareContext() - remove instance variables that are not necessary / redundant for operating the container correctly and refactor the code logic accordingly - remove unnecessary valve comments and point to documentation URL - remove any commented out code - remove the static block for initializing SSLUtil.loadJsseProperties(). This code is already called and hence redundant - remove redundant / dead / unused code - add missing FilterDef to context - lots and lots of re-arranging and small code improvements > Refactor CatalinaContainer > -- > > Key: OFBIZ-9392 > URL: https://issues.apache.org/jira/browse/OFBIZ-9392 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9392.patch > > > The implementation of CatalinaContainer.java is currently very verbose, has > replicated code, and is difficult to navigate. > The objective of this JIRA is to breakup the logic into smaller manageable > functions to allow for further enhancements in the future. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9385) EntityListIterator closed but not in case of exception
[ https://issues.apache.org/jira/browse/OFBIZ-9385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042588#comment-16042588 ] Jacques Le Roux commented on OFBIZ-9385: Done at revision: 1797792 for ContentEvents.updateAllContentKeywords() > EntityListIterator closed but not in case of exception > -- > > Key: OFBIZ-9385 > URL: https://issues.apache.org/jira/browse/OFBIZ-9385 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > > I found several cases. This is an improvement only because no cases were > reported. But obviously in case of unlucky exception after the > EntityListIterator creation and before it's closed the EntityListIterator > remains in memory. It should be closed in EntityListIterator.finalize() but > the less happens there the better. > The solution is to use try-with-ressources when (easily) possible (some cases > are quite convoluted) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9390) Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, OAuth2LinkedIn and LinkedInUser entities.
[ https://issues.apache.org/jira/browse/OFBIZ-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042345#comment-16042345 ] Shi Jinghai commented on OFBIZ-9390: Thanks Renuka! I agree with you, your patch is in rev. 1798029. Please check if it's right. > Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, > OAuth2LinkedIn and LinkedInUser entities. > --- > > Key: OFBIZ-9390 > URL: https://issues.apache.org/jira/browse/OFBIZ-9390 > Project: OFBiz > Issue Type: Bug > Components: passport >Affects Versions: Trunk >Reporter: Renuka Srishti >Assignee: Renuka Srishti > Attachments: OFBIZ-9390.patch, OFBiz9390.png > > > PassportEntityLabels does not exist, but its reference is used in > passport/entitydef/entitymodel.xml -- This message was sent by Atlassian JIRA (v6.3.15#6346)
