[jira] [Updated] (OFBIZ-9358) Integrating google phone number library for validating telecom numbers

2017-07-09 Thread Renuka Srishti (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-9358:
--
Attachment: OFBIZ-9358.patch

> Integrating google phone number library for validating telecom numbers
> --
>
> Key: OFBIZ-9358
> URL: https://issues.apache.org/jira/browse/OFBIZ-9358
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Release
>Reporter: Suraj Khurana
>Assignee: Renuka Srishti
> Attachments: OFBIZ-9358.patch, OFBIZ-9358.patch, OFBIZ-9358.patch
>
>
> As per discussion at 
> https://lists.apache.org/list.html?d...@ofbiz.apache.org:lte=1M:Validating%20telecom%20numbers
> Need to integrate Google telephone number to validate telephone numbers 
> formats of various countries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8462) Improvements in ShipmentItemBilling entity definition and services

2017-07-09 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079871#comment-16079871
 ] 

Rishi Solanki commented on OFBIZ-8462:
--

[~devanshu.vyas]: Thanks for providing patch, looks good to me. Changed the 
ticket status to patch available. Thanks again.

> Improvements in ShipmentItemBilling entity definition and services
> --
>
> Key: OFBIZ-8462
> URL: https://issues.apache.org/jira/browse/OFBIZ-8462
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Priority: Minor
> Attachments: OFBIZ-8462.patch
>
>
> Required improvements;
> - All is good with entity definition.
> - Add CRUD services using entity-auto.Make sure PK is not optional while 
> create service as there is composite primary key.
> - Do related changes if any occurrence found for direct create/delete of this 
> entity, and replace them with crud services implemented.
> - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9484) Enable webapp's META-INF/context.xml works

2017-07-09 Thread Shi Jinghai (JIRA)
Shi Jinghai created OFBIZ-9484:
--

 Summary: Enable webapp's META-INF/context.xml works
 Key: OFBIZ-9484
 URL: https://issues.apache.org/jira/browse/OFBIZ-9484
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: 16.11.02
Reporter: Shi Jinghai
Priority: Trivial


Besides the EL error, another problem when deploying Drools-Workbench in OFBiz 
I met is the webapp's META-INF/context.xml not loaded.

Add the following code in 
framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java
 and drools-wb works fine in OFBiz:

{code:java}
context.addLifecycleListener(new ContextConfig());

// adding webapp's META-INF/context.xml begin
String contextXmlFilePath = new 
StringBuilder().append("file:///").append(location).append("/").append(Constants.ApplicationContextXml).toString();
URL contextXmlUrl = null;
try {
contextXmlUrl = 
FlexibleLocation.resolveLocation(contextXmlFilePath);
contextXmlFilePath = new 
StringBuilder().append(location).append("/").append(Constants.ApplicationContextXml).toString();
File contextXmlFile = FileUtil.getFile(contextXmlFilePath);
if(contextXmlFile.exists() && contextXmlFile.isFile()) { 
// Debug.logInfo(contextXmlFilePath + " found and will be 
loaded.", module);
context.setConfigFile(contextXmlUrl);
}
} catch (MalformedURLException e) {
// Debug.logInfo(contextXmlFilePath+ " not found.", module);
}
// add webapp's META-INF/context.xml end

Tomcat.initWebappDefaults(context);
{code}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9483) Enable EL in OFBiz

2017-07-09 Thread Shi Jinghai (JIRA)
Shi Jinghai created OFBIZ-9483:
--

 Summary: Enable EL in OFBiz
 Key: OFBIZ-9483
 URL: https://issues.apache.org/jira/browse/OFBIZ-9483
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: 16.11.02
Reporter: Shi Jinghai
Assignee: Shi Jinghai
Priority: Trivial


While deploying CAS and Drools-Workbench in OFBiz 16.11.02, the pages with EL 
report error messages:
 
{code:java}
java.lang.NullPointerException
javax.el.CompositeELResolver.add(CompositeELResolver.java:117)
org.apache.jasper.el.JasperELResolver.add(JasperELResolver.java:70)
org.apache.jasper.el.JasperELResolver.(JasperELResolver.java:58)

org.apache.jasper.runtime.JspApplicationContextImpl.createELResolver(JspApplicationContextImpl.java:120)

org.apache.jasper.runtime.JspApplicationContextImpl.createELContext(JspApplicationContextImpl.java:89)

org.apache.jasper.runtime.PageContextImpl.getELContext(PageContextImpl.java:949)

org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate(PageContextImpl.java:934)

org.apache.jsp.WEB_002dINF.view.jsp.default_.ui.casGenericSuccessView_jsp._jspService(casGenericSuccessView_jsp.java:152)
{code}


According to the doc of javax.el.ExpressionFactorym 
(http://docs.oracle.com/javaee/6/api/javax/el/ExpressionFactory.html):

{code:java}
Creates a new instance of a ExpressionFactory?. This method uses the following 
ordered lookup procedure to determine the ExpressionFactory? implementation 
class to load: 
•Use the Services API (as detailed in the JAR specification). If a resource 
with the name of META-INF/services/javax.el.ExpressionFactory? exists, then its 
first line, if present, is used as the UTF-8 encoded name of the implementation 
class. 
•Use the properties file "lib/el.properties" in the JRE directory. If this file 
exists and it is readable by the java.util.Properties.load(InputStream?) 
method, and it contains an entry whose key is "javax.el.ExpressionFactory?", 
then the value of that entry is used as the name of the implementation class. 
•Use the javax.el.ExpressionFactory? system property. If a system property with 
this name is defined, then its value is used as the name of the implementation 
class. 
•Use a platform default implementation. 

{code}

I added an el.properties in ${jre_home}/lib/, the el.properties has one line:

{code:java}
javax.el.ExpressionFactory=org.apache.el.ExpressionFactoryImpl
{code}

Restarting OFBiz, the error messages are still there, so there is at least a 
META-INF/services/javax.el.ExpressionFactory in runtime jars. It comes to 
'de.odysseus.juel:juel-spi:2.2.7', unzip it, it only contains a 
javax.el.ExpressionFactory file with de.odysseus.el.ExpressionFactoryImpl.

Remove runtime 'de.odysseus.juel:juel-spi:2.2.7' and restart OFBiz, the error 
messages are still there. Unzip 'de.odysseus.juel:juel-impl:2.2.7', an 
OSGI-INF/services.xml found:

{code:java}

http://www.osgi.org/xmlns/scr/v1.1.0;>







{code}

It's easy to get it defines javax.el.ExpressionFactory implemented by 
de.odysseus.el.ExpressionFactoryImpl. Unzip it and create a new jar with 
command:

{code:java}
jar cf juel-impl-no-osgi-2.2.7.jar de/ META-INF/
{code}

Put the juel-impl-no-osgi-2.2.7.jar under ${ofbiz.home}/lib/, change the 
build.gradle:
{code:java}
// compile 'de.odysseus.juel:juel-impl:2.2.7'
compile files('./lib/juel-impl-no-osgi-2.2.7.jar')
{code}

Restart OFBiz, both OFBiz pages and EL pages are ok now.

Stop OFBiz, remove ${jre_home}/lib/el.properties, start OFBiz, EL pages fail. 
Obviously, this fail is caused by no javax.el.ExpressionFactory defined. Add a 
META-INF/javax.el.ExpressionFactory with one line content of 
org.apache.el.ExpressionFactoryImpl in juel-impl-no-osgi-2.2.7.jar.

Restart OFBiz, all OFBiz and EL pages are right.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9483) Enable EL in OFBiz

2017-07-09 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-9483:
---
Attachment: juel-impl-no-osgi-2.2.7.jar

The juel-impl-no-osgi-2.2.7.jar mentioned in the description.

> Enable EL in OFBiz
> --
>
> Key: OFBIZ-9483
> URL: https://issues.apache.org/jira/browse/OFBIZ-9483
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: 16.11.02
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Attachments: juel-impl-no-osgi-2.2.7.jar
>
>
> While deploying CAS and Drools-Workbench in OFBiz 16.11.02, the pages with EL 
> report error messages:
>  
> {code:java}
> java.lang.NullPointerException
>   javax.el.CompositeELResolver.add(CompositeELResolver.java:117)
>   org.apache.jasper.el.JasperELResolver.add(JasperELResolver.java:70)
>   org.apache.jasper.el.JasperELResolver.(JasperELResolver.java:58)
>   
> org.apache.jasper.runtime.JspApplicationContextImpl.createELResolver(JspApplicationContextImpl.java:120)
>   
> org.apache.jasper.runtime.JspApplicationContextImpl.createELContext(JspApplicationContextImpl.java:89)
>   
> org.apache.jasper.runtime.PageContextImpl.getELContext(PageContextImpl.java:949)
>   
> org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate(PageContextImpl.java:934)
>   
> org.apache.jsp.WEB_002dINF.view.jsp.default_.ui.casGenericSuccessView_jsp._jspService(casGenericSuccessView_jsp.java:152)
> {code}
> According to the doc of javax.el.ExpressionFactorym 
> (http://docs.oracle.com/javaee/6/api/javax/el/ExpressionFactory.html):
> {code:java}
> Creates a new instance of a ExpressionFactory?. This method uses the 
> following ordered lookup procedure to determine the ExpressionFactory? 
> implementation class to load: 
> •Use the Services API (as detailed in the JAR specification). If a resource 
> with the name of META-INF/services/javax.el.ExpressionFactory? exists, then 
> its first line, if present, is used as the UTF-8 encoded name of the 
> implementation class. 
> •Use the properties file "lib/el.properties" in the JRE directory. If this 
> file exists and it is readable by the java.util.Properties.load(InputStream?) 
> method, and it contains an entry whose key is "javax.el.ExpressionFactory?", 
> then the value of that entry is used as the name of the implementation class. 
> •Use the javax.el.ExpressionFactory? system property. If a system property 
> with this name is defined, then its value is used as the name of the 
> implementation class. 
> •Use a platform default implementation. 
> {code}
> I added an el.properties in ${jre_home}/lib/, the el.properties has one line:
> {code:java}
> javax.el.ExpressionFactory=org.apache.el.ExpressionFactoryImpl
> {code}
> Restarting OFBiz, the error messages are still there, so there is at least a 
> META-INF/services/javax.el.ExpressionFactory in runtime jars. It comes to 
> 'de.odysseus.juel:juel-spi:2.2.7', unzip it, it only contains a 
> javax.el.ExpressionFactory file with de.odysseus.el.ExpressionFactoryImpl.
> Remove runtime 'de.odysseus.juel:juel-spi:2.2.7' and restart OFBiz, the error 
> messages are still there. Unzip 'de.odysseus.juel:juel-impl:2.2.7', an 
> OSGI-INF/services.xml found:
> {code:java}
> 
> http://www.osgi.org/xmlns/scr/v1.1.0;>
>   
>   
>   
>   
>   
>   
> 
> {code}
> It's easy to get it defines javax.el.ExpressionFactory implemented by 
> de.odysseus.el.ExpressionFactoryImpl. Unzip it and create a new jar with 
> command:
> {code:java}
> jar cf juel-impl-no-osgi-2.2.7.jar de/ META-INF/
> {code}
> Put the juel-impl-no-osgi-2.2.7.jar under ${ofbiz.home}/lib/, change the 
> build.gradle:
> {code:java}
> // compile 'de.odysseus.juel:juel-impl:2.2.7'
> compile files('./lib/juel-impl-no-osgi-2.2.7.jar')
> {code}
> Restart OFBiz, both OFBiz pages and EL pages are ok now.
> Stop OFBiz, remove ${jre_home}/lib/el.properties, start OFBiz, EL pages fail. 
> Obviously, this fail is caused by no javax.el.ExpressionFactory defined. Add 
> a META-INF/javax.el.ExpressionFactory with one line content of 
> org.apache.el.ExpressionFactoryImpl in juel-impl-no-osgi-2.2.7.jar.
> Restart OFBiz, all OFBiz and EL pages are right.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9482) send email from quote screen cause exception

2017-07-09 Thread Wai (JIRA)
Wai created OFBIZ-9482:
--

 Summary: send email from quote screen cause exception
 Key: OFBIZ-9482
 URL: https://issues.apache.org/jira/browse/OFBIZ-9482
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Trunk
Reporter: Wai


use https://localhost:8443/ordermgr/control/ViewQuote?quoteId=CQ0001
click on "Send Report By Mail".
enter destination email
enter message
click "submit"

notice the exception message on popup dialog...
The Following Errors Occurred:
Error rendering screen for email: 
org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
[component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteSimple]: 
org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
[component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteTemplate]: 
org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
[component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
[component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
java.lang.NullPointerException (null) (Error rendering screen 
[component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
java.lang.NullPointerException (null)) (Error rendering screen 
[component://order/widget/ordermgr/QuoteScreens.xml#ViewQuoteInfo]: 
org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering screen 
[component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 
java.lang.NullPointerException (null) (Error rendering screen 
[component://order/widget/ordermgr/QuoteScreens.xml#ListQuoteInfo]: 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9481) order page shows widget exceptions

2017-07-09 Thread Wai (JIRA)
Wai created OFBIZ-9481:
--

 Summary: order page shows widget exceptions
 Key: OFBIZ-9481
 URL: https://issues.apache.org/jira/browse/OFBIZ-9481
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Trunk
Reporter: Wai


use https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10091
notice widget exceptions

console output...
2017-07-09 16:22:35,812 |jsse-nio-8443-exec-1 |ScreenFactory 
|I| Got 40 screens in 0.021s from: 
file:/ofbiz-trunk/applications/party/widget/partymgr/PartyScreens.xml
2017-07-09 16:22:35,871 |jsse-nio-8443-exec-1 |FreeMarkerWorker  
|E| null
freemarker.core.NonBooleanException: For "!" right-hand operand: Expected a 
boolean, but this has evaluated to a string (wrapper: f.t.SimpleScalar):
==> "ORDER_COMPLETED"  [in template 
"component://order/template/order/OrderContactInfo.ftl" at line 21, column 10]


FTL stack trace ("~" means nesting-related):
- Failed at: #if (!"ORDER_COMPLETED" == orderHeade...  [in template 
"component://order/template/order/OrderContactInfo.ftl" in macro 
"updateOrderContactMech" at line 21, column 3]
- Reached through: @updateOrderContactMech orderHeader=(...  [in 
template "component://order/template/order/OrderContactInfo.ftl" at line 123, 
column 19]

at freemarker.core.Expression.modelToBoolean(Expression.java:163) 
~[freemarker-2.3.25-incubating.jar:2.3.25]




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9399) ServiceSemaphore.waitOrFail() remove redundant logging

2017-07-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9399.
--
   Resolution: Done
 Assignee: Jacques Le Roux
Fix Version/s: Upcoming Release

Thanks Martin,

Your patch is in trunk at revision: 1801380  


> ServiceSemaphore.waitOrFail() remove redundant logging
> --
>
> Key: OFBIZ-9399
> URL: https://issues.apache.org/jira/browse/OFBIZ-9399
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9399_ServiceSemaphoreRemoveRedundantLogging.patch
>
>
> Removes the redundant logging done in ServiceSemaphore.waitOrFail() since the 
> error will be logged by the ServiceEngine anyway.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9391) Update Apache Solr/Lucene to release 6.6.0

2017-07-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079659#comment-16079659
 ] 

Jacques Le Roux commented on OFBIZ-9391:


Yep Michael, saw it already elsewhere indeed 

> Update Apache Solr/Lucene to release 6.6.0
> --
>
> Key: OFBIZ-9391
> URL: https://issues.apache.org/jira/browse/OFBIZ-9391
> Project: OFBiz
>  Issue Type: Improvement
>  Components: solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> There are new Solr/Lucene versions 6.6.0 available, see 
> https://lucene.apache.org/core/6_6_0/changes/Changes.html and 
> https://lucene.apache.org/solr/6_6_0/changes/Changes.html.
> This Jira takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9328) Create New button is misplaced on Party Content Screen

2017-07-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9328:
---
Issue Type: Improvement  (was: Bug)

> Create New button is misplaced on Party Content Screen
> --
>
> Key: OFBIZ-9328
> URL: https://issues.apache.org/jira/browse/OFBIZ-9328
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: CreateNewButton.png, OFBIZ-9328.patch, OFBIZ-9328.patch
>
>
> The Create New button is wrongly placed on the Party Content screen(navigated 
> from a Party Profile screen). The button should be placed outside of the 
> Content List section instead of inside. (CreateNewButton.png)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9135) popup info about image in ordermgr shows html markup

2017-07-09 Thread Wai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wai closed OFBIZ-9135.
--
Resolution: Fixed

I cannot reproduce the issue. Closing. Thanks

> popup info about image in ordermgr shows html markup
> 
>
> Key: OFBIZ-9135
> URL: https://issues.apache.org/jira/browse/OFBIZ-9135
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Wai
>
> -use https://localhost:8443/ordermgr/control/orderentry
> -fill all necessary required order info
> -select productId=WG-9943
> -click 'Add to Order'
> -Notice the images in the 'You might be interested in these as well:' section.
> -hover mouse over the image.
> -the popup shows html markup



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-8843) Improvements in CommEventContentAssoc entity definition and services

2017-07-09 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-8843:
-
Attachment: OFBIZ-8843.patch

Here is the patch for the same with some modification from the details shared 
in the ticket description.

- Did not convert the create operation as create service handling some 
scenarios and conditionally set the now time stamp in from date field.
- In update service match the input parameters to match the existing allowed 
fields to update.

> Improvements in CommEventContentAssoc entity definition and services
> 
>
> Key: OFBIZ-8843
> URL: https://issues.apache.org/jira/browse/OFBIZ-8843
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-8843.patch
>
>
> Required improvements;
> - All is good with entity definition .
> - Add crud services using entity-auto (services_commevent.xml). Also remove 
> the existing services from ContentServices.xml. 
> - Do related changes if any occurrence found for direct create/update/delete 
> of this entity, and replace them with crud services implemented.
> - As existing workflows are implemented to delete the records so use the 
> delete action for the same.
> - Need to convert Update and Delete services. Create can not be converted due 
> to some conditional code. Keep the existing services names as is.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9444) Dependency problem between Solr 6.6.0 and Guava

2017-07-09 Thread Michael Brohl (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-9444:


Assignee: Michael Brohl  (was: Renuka Srishti)

> Dependency problem between Solr 6.6.0 and Guava
> ---
>
> Key: OFBIZ-9444
> URL: https://issues.apache.org/jira/browse/OFBIZ-9444
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
> Attachments: dependencies.txt, OFBIZ-9444.patch
>
>
> It seems we have a dependency problem in our codebase.
> The Solr code needs access to a method 
> com.google.common.base.Objects.firstNonNull, which was removed from Guava 
> from version 21 (see [1]).
> I tried to add the dependency both through the Solr build.gradle with
> {code:java}
> dependencies {
> pluginLibsCompile 'org.apache.solr:solr-core:6.6.0'
> pluginLibsCompile 'com.google.guava:guava:20.0'
> }
> {code}
> and also as a runtime dependency in main build.gradle
> {code:java}
> dependencies {
> // ofbiz compile libs
> ...
> runtime 'com.google.guava:guava:20.0'
> ...
> }
> {code}
> Both did not work. Running my Solo tests I get the error
> {code:java}
> 2017-07-01 14:25:18,049 |jsse-nio-8443-exec-4 |HttpSolrCall  
> |E| null:java.lang.RuntimeException: java.lang.NoSuchMethodError: 
> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
> at 
> org.apache.solr.servlet.HttpSolrCall.sendError(HttpSolrCall.java:676)
> at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:544)
> at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361)
> at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305)
> at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.doFilter(OFBizSolrContextFilter.java:151)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
> at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
> at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
> at 
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
> at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
> at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
> at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
> at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NoSuchMethodError: 
> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
> at 
> org.apache.solr.handler.component.HighlightComponent.prepare(HighlightComponent.java:118)
> at 
> org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:270)
> at 
> org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173)
> at org.apache.solr.core.SolrCore.execute(SolrCore.java:2477)
> at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:723)
> at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:529)
> ... 25 more
> {code}
> 

[jira] [Commented] (OFBIZ-9391) Update Apache Solr/Lucene to release 6.6.0

2017-07-09 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079570#comment-16079570
 ] 

Michael Brohl commented on OFBIZ-9391:
--

Sure, Jacques. It seems that Safari's auto correction substitutes Gradle -> 
Cradle, found the same in another issue.

> Update Apache Solr/Lucene to release 6.6.0
> --
>
> Key: OFBIZ-9391
> URL: https://issues.apache.org/jira/browse/OFBIZ-9391
> Project: OFBiz
>  Issue Type: Improvement
>  Components: solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> There are new Solr/Lucene versions 6.6.0 available, see 
> https://lucene.apache.org/core/6_6_0/changes/Changes.html and 
> https://lucene.apache.org/solr/6_6_0/changes/Changes.html.
> This Jira takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-9391) Update Apache Solr/Lucene to release 6.6.0

2017-07-09 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079105#comment-16079105
 ] 

Michael Brohl edited comment on OFBIZ-9391 at 7/9/17 11:29 AM:
---

This is still blocked by the Guava dependency problem. Any help from the Gradle 
specialists is appreciated :-)


was (Author: mbrohl):
This is still blocked by the Guava dependency problem. Any help from the Cradle 
specialists is appreciated :-)

> Update Apache Solr/Lucene to release 6.6.0
> --
>
> Key: OFBIZ-9391
> URL: https://issues.apache.org/jira/browse/OFBIZ-9391
> Project: OFBiz
>  Issue Type: Improvement
>  Components: solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> There are new Solr/Lucene versions 6.6.0 available, see 
> https://lucene.apache.org/core/6_6_0/changes/Changes.html and 
> https://lucene.apache.org/solr/6_6_0/changes/Changes.html.
> This Jira takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9444) Dependency problem between Solr 6.6.0 and Guava

2017-07-09 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079569#comment-16079569
 ] 

Michael Brohl commented on OFBIZ-9444:
--

Hi [~Renuka_Srishti],

thanks for your response. This is similar to the resolutionStrategy/force 
solution above and both work, but I don't think that it is a valid solution.

I think the framework should not be tailored to dependencies of the now 
independent plugins, therefore I am searching for a way to introduce 
new/changed dependencies from the plugins to the framework.

It would be good to have a solution for this because we cannot (and will not) 
keep dependencies for plugins inside the framework, at least if we find a way 
to avoid it.

I am hoping that some of our Gradle gurus will find a solution for it.

Thanks!

> Dependency problem between Solr 6.6.0 and Guava
> ---
>
> Key: OFBIZ-9444
> URL: https://issues.apache.org/jira/browse/OFBIZ-9444
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Renuka Srishti
> Attachments: dependencies.txt, OFBIZ-9444.patch
>
>
> It seems we have a dependency problem in our codebase.
> The Solr code needs access to a method 
> com.google.common.base.Objects.firstNonNull, which was removed from Guava 
> from version 21 (see [1]).
> I tried to add the dependency both through the Solr build.gradle with
> {code:java}
> dependencies {
> pluginLibsCompile 'org.apache.solr:solr-core:6.6.0'
> pluginLibsCompile 'com.google.guava:guava:20.0'
> }
> {code}
> and also as a runtime dependency in main build.gradle
> {code:java}
> dependencies {
> // ofbiz compile libs
> ...
> runtime 'com.google.guava:guava:20.0'
> ...
> }
> {code}
> Both did not work. Running my Solo tests I get the error
> {code:java}
> 2017-07-01 14:25:18,049 |jsse-nio-8443-exec-4 |HttpSolrCall  
> |E| null:java.lang.RuntimeException: java.lang.NoSuchMethodError: 
> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
> at 
> org.apache.solr.servlet.HttpSolrCall.sendError(HttpSolrCall.java:676)
> at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:544)
> at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361)
> at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305)
> at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.doFilter(OFBizSolrContextFilter.java:151)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
> at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
> at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
> at 
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
> at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
> at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
> at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
> at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NoSuchMethodError: 
> 

[jira] [Comment Edited] (OFBIZ-9444) Dependency problem between Solr 6.6.0 and Guava

2017-07-09 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071307#comment-16071307
 ] 

Michael Brohl edited comment on OFBIZ-9444 at 7/9/17 11:28 AM:
---

I was able to successfully run the tests with the following configuration in 
the main build.gradle file:

{code:java}
configurations.all {
resolutionStrategy {
  // force certain versions of dependencies (including transitive)
  //  *append new forced modules:
  force 'com.google.guava:guava:20.0'
  //  *replace existing forced modules with new ones:
  forcedModules = ['com.google.guava:guava:20.0']
}
}
{code}

The Guava 22 files are not loaded by Gradle then.

The tests fail if I put this configuration in the Solr plugin build.gradle 
file. The Guava 22 version is loaded and the tests fail.

I know that this is not an acceptable solution because it introduces 
dependencies (or configurations) for a plugin in the base project.

Any hints how to force a certain dependency version using the child project 
build file instead of the main build file?


was (Author: mbrohl):
I was able to successfully run the tests with the following configuration in 
the main build.gradle file:

{code:java}
configurations.all {
resolutionStrategy {
  // force certain versions of dependencies (including transitive)
  //  *append new forced modules:
  force 'com.google.guava:guava:20.0'
  //  *replace existing forced modules with new ones:
  forcedModules = ['com.google.guava:guava:20.0']
}
}
{code}

The Guava 22 files are not loaded by Cradle then.

The tests fail if I put this configuration in the Solr plugin build.gradle 
file. The Guava 22 version is loaded and the tests fail.

I know that this is not an acceptable solution because it introduces 
dependencies (or configurations) for a plugin in the base project.

Any hints how to force a certain dependency version using the child project 
build file instead of the main build file?

> Dependency problem between Solr 6.6.0 and Guava
> ---
>
> Key: OFBIZ-9444
> URL: https://issues.apache.org/jira/browse/OFBIZ-9444
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Renuka Srishti
> Attachments: dependencies.txt, OFBIZ-9444.patch
>
>
> It seems we have a dependency problem in our codebase.
> The Solr code needs access to a method 
> com.google.common.base.Objects.firstNonNull, which was removed from Guava 
> from version 21 (see [1]).
> I tried to add the dependency both through the Solr build.gradle with
> {code:java}
> dependencies {
> pluginLibsCompile 'org.apache.solr:solr-core:6.6.0'
> pluginLibsCompile 'com.google.guava:guava:20.0'
> }
> {code}
> and also as a runtime dependency in main build.gradle
> {code:java}
> dependencies {
> // ofbiz compile libs
> ...
> runtime 'com.google.guava:guava:20.0'
> ...
> }
> {code}
> Both did not work. Running my Solo tests I get the error
> {code:java}
> 2017-07-01 14:25:18,049 |jsse-nio-8443-exec-4 |HttpSolrCall  
> |E| null:java.lang.RuntimeException: java.lang.NoSuchMethodError: 
> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
> at 
> org.apache.solr.servlet.HttpSolrCall.sendError(HttpSolrCall.java:676)
> at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:544)
> at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361)
> at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305)
> at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.doFilter(OFBizSolrContextFilter.java:151)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
> at 
> 

[jira] [Issue Comment Deleted] (OFBIZ-9404) Insufficient checking of checkOutPaymentId in CheckOutEvents.getSelectedPaymentMethods

2017-07-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9404:
---
Comment: was deleted

(was: Bac)

> Insufficient checking of checkOutPaymentId in 
> CheckOutEvents.getSelectedPaymentMethods
> --
>
> Key: OFBIZ-9404
> URL: https://issues.apache.org/jira/browse/OFBIZ-9404
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Arun Patidar
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9404_empty-check_checkOutPaymentId.patch
>
>
> The following patch fixes a bug where the paymentMethod in 
> CheckOutEvents.getSelectedPaymentMethods might be filled with a phantom 
> payment method.
> It checks for an empty parameter, not only NULL, to avoid a phantom 
> paymentMethod with ID "" in selectedPaymentMethods, that causes subsequent 
> errors in payment handling (e.g. ShoppingCart.getValueObject).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Reopened] (OFBIZ-9404) Insufficient checking of checkOutPaymentId in CheckOutEvents.getSelectedPaymentMethods

2017-07-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-9404:


Bac

> Insufficient checking of checkOutPaymentId in 
> CheckOutEvents.getSelectedPaymentMethods
> --
>
> Key: OFBIZ-9404
> URL: https://issues.apache.org/jira/browse/OFBIZ-9404
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Arun Patidar
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9404_empty-check_checkOutPaymentId.patch
>
>
> The following patch fixes a bug where the paymentMethod in 
> CheckOutEvents.getSelectedPaymentMethods might be filled with a phantom 
> payment method.
> It checks for an empty parameter, not only NULL, to avoid a phantom 
> paymentMethod with ID "" in selectedPaymentMethods, that causes subsequent 
> errors in payment handling (e.g. ShoppingCart.getValueObject).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9404) Insufficient checking of checkOutPaymentId in CheckOutEvents.getSelectedPaymentMethods

2017-07-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9404.
--
   Resolution: Fixed
Fix Version/s: (was: Upcoming Release)
   16.11.04

Backported in R16.11 at r1801369

> Insufficient checking of checkOutPaymentId in 
> CheckOutEvents.getSelectedPaymentMethods
> --
>
> Key: OFBIZ-9404
> URL: https://issues.apache.org/jira/browse/OFBIZ-9404
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Arun Patidar
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9404_empty-check_checkOutPaymentId.patch
>
>
> The following patch fixes a bug where the paymentMethod in 
> CheckOutEvents.getSelectedPaymentMethods might be filled with a phantom 
> payment method.
> It checks for an empty parameter, not only NULL, to avoid a phantom 
> paymentMethod with ID "" in selectedPaymentMethods, that causes subsequent 
> errors in payment handling (e.g. ShoppingCart.getValueObject).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-9259) Uploading images at catalog/control/addImageForProduct does not work

2017-07-09 Thread Devanshu Vyas (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079531#comment-16079531
 ] 

Devanshu Vyas edited comment on OFBIZ-9259 at 7/9/17 11:07 AM:
---

Hello Jacques, 

I tried to regenerate the issue, but I found a different issue.
{code}
java.lang.Exception: Service [addMultipleuploadForProduct] threw an unexpected 
exception/error
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
 [ofbiz.jar:?]


2017-07-09 15:42:40,189 |sse-nio-8443-exec-11 |CallService   
|E| ERROR: Could not complete the Method to upload multiple images for product 
[file:/home/devanshu/ofbiz_dev/bug_crush/trunk/applications/product/minilang/product/imagemanagement/ImageManagementServices.xml#UploadProductImages]
 process [problem invoking the [addMultipleuploadForProduct] service with the 
map named [addAdditionalViewForProductMap] containing 
[{userLogin=[GenericEntity:UserLogin][createdStamp,2017-07-09 
02:42:04.614(java.sql.Timestamp)][createdTxStamp,2017-07-09 
02:42:04.609(java.sql.Timestamp)][currentPassword,{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,null()][externalAuthId,null()][hasLoggedOut,null()][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Calcutta(java.lang.String)][lastUpdatedStamp,2017-07-09
 02:43:49.871(java.sql.Timestamp)][lastUpdatedTxStamp,2017-07-09 
02:43:49.702(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,admin(java.lang.String)],
 productId=GZ-1000, _uploadedFile_contentType=image/png, 
timeZone=sun.util.calendar.ZoneInfo[id="Asia/Calcutta",offset=1980,dstSavings=0,useDaylight=false,transitions=6,lastRule=null],
 locale=en_US, productContentTypeId=IMAGE, imageResize=null, 
uploadedFile=java.nio.HeapByteBuffer[pos=0 lim=204237 cap=204237], 
_uploadedFile_fileName=3d Spider Man Homecoming M Movie Tickets Online Booking  
Showtimes in Indore   Paytm.com.png}]: Service [addMultipleuploadForProduct] 
target threw an unexpected exception (null)]

{code}

Steps followed for regeneration:
- Go to Catalog application.
- Click on the (Image Management) menu item.
- Click on the (Upload) sub-menu item.
- Set a product and upload image(s).
- Click on the (Upload) button.

Let me know if this is the issue you are referring to or is entirely different.


was (Author: devanshu.vyas):
Hello Jaques, 

I tried to regenerate the issue, but I found a different issue.
{code}
java.lang.Exception: Service [addMultipleuploadForProduct] threw an unexpected 
exception/error
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
 [ofbiz.jar:?]


2017-07-09 15:42:40,189 |sse-nio-8443-exec-11 |CallService   
|E| ERROR: Could not complete the Method to upload multiple images for product 
[file:/home/devanshu/ofbiz_dev/bug_crush/trunk/applications/product/minilang/product/imagemanagement/ImageManagementServices.xml#UploadProductImages]
 process [problem invoking the [addMultipleuploadForProduct] service with the 
map named [addAdditionalViewForProductMap] containing 
[{userLogin=[GenericEntity:UserLogin][createdStamp,2017-07-09 
02:42:04.614(java.sql.Timestamp)][createdTxStamp,2017-07-09 
02:42:04.609(java.sql.Timestamp)][currentPassword,{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,null()][externalAuthId,null()][hasLoggedOut,null()][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Calcutta(java.lang.String)][lastUpdatedStamp,2017-07-09
 02:43:49.871(java.sql.Timestamp)][lastUpdatedTxStamp,2017-07-09 
02:43:49.702(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,admin(java.lang.String)],
 productId=GZ-1000, _uploadedFile_contentType=image/png, 
timeZone=sun.util.calendar.ZoneInfo[id="Asia/Calcutta",offset=1980,dstSavings=0,useDaylight=false,transitions=6,lastRule=null],
 locale=en_US, productContentTypeId=IMAGE, imageResize=null, 
uploadedFile=java.nio.HeapByteBuffer[pos=0 lim=204237 cap=204237], 
_uploadedFile_fileName=3d Spider Man Homecoming M Movie Tickets Online Booking  
Showtimes in Indore   Paytm.com.png}]: Service [addMultipleuploadForProduct] 
target threw an unexpected exception (null)]

{code}

Steps followed for regeneration:
- Go to Catalog application.
- Click on the (Image Management) 

[jira] [Commented] (OFBIZ-9391) Update Apache Solr/Lucene to release 6.6.0

2017-07-09 Thread Renuka Srishti (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079560#comment-16079560
 ] 

Renuka Srishti commented on OFBIZ-9391:
---

Hii Michael,
I think the comment in OFBIZ-9444 will help you. :)

> Update Apache Solr/Lucene to release 6.6.0
> --
>
> Key: OFBIZ-9391
> URL: https://issues.apache.org/jira/browse/OFBIZ-9391
> Project: OFBiz
>  Issue Type: Improvement
>  Components: solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> There are new Solr/Lucene versions 6.6.0 available, see 
> https://lucene.apache.org/core/6_6_0/changes/Changes.html and 
> https://lucene.apache.org/solr/6_6_0/changes/Changes.html.
> This Jira takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8972) OFBIZ-7520: Consistency and Readability improvements for include-menu tag

2017-07-09 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079557#comment-16079557
 ] 

Rishi Solanki commented on OFBIZ-8972:
--

Can we resolve this one as OFBIZ-9114 is closed.

> OFBIZ-7520: Consistency and Readability improvements for include-menu tag
> -
>
> Key: OFBIZ-8972
> URL: https://issues.apache.org/jira/browse/OFBIZ-8972
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8972.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
>  location="component://marketing/widget/sfa/SfaMenus.xml"/>



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8991) OFBIZ-7520: Consistency and Readability improvements for condition tag

2017-07-09 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079559#comment-16079559
 ] 

Rishi Solanki commented on OFBIZ-8991:
--

Can we resolve this one as OFBIZ-9114 is closed.

> OFBIZ-7520: Consistency and Readability improvements for condition tag
> --
>
> Key: OFBIZ-8991
> URL: https://issues.apache.org/jira/browse/OFBIZ-8991
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8991.patch
>
>
> Code written in Minilang for the entity-and is not consistent throughout the 
> application. The correct pattern to write is
>  value="FINACT_TRNS_APPROVED"/>



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8986) OFBIZ-7520: Consistency and Readability improvements for make-value tag

2017-07-09 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079558#comment-16079558
 ] 

Rishi Solanki commented on OFBIZ-8986:
--

Can we resolve this one as OFBIZ-9114 is closed.

> OFBIZ-7520: Consistency and Readability improvements for make-value tag
> ---
>
> Key: OFBIZ-8986
> URL: https://issues.apache.org/jira/browse/OFBIZ-8986
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8986.patch
>
>
> Code written in Minilang for the entity-one tag is not consistent throughout 
> the application. The correct pattern to write is
> 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-7077) Unknown request error when generating Acctg Trans Entries PDF from invoice overview page

2017-07-09 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7077:
---
Description: 
Problem:
Unknown request [InvoiceAcctgTransEntriesPdf]

Step to regenerate:
1) Go to http://demo-stable.ofbiz.apache.org/ar/control/FindArInvoices
2) Go to invoice overview page of any sales invoice.
3) Click on "Acctg Trans Entries PDF" button.

Root Cause:
InvoiceAcctgTransEntriesPdf  request was available in the birt component of 
specialpurpose and that component was removed from the specialpurpose in 13.07 
release.


  was:
Problem:
Unknown request [InvoiceAcctgTransEntriesPdf]

Step to regenerate:
1) Go to http://demo-stable-ofbiz.apache.org/ar/control/FindArInvoices
2) Go to invoice overview page of any sales invoice.
3) Click on "Acctg Trans Entries PDF" button.

Root Cause:
InvoiceAcctgTransEntriesPdf  request was available in the birt component of 
specialpurpose and that component was removed from the specialpurpose in 13.07 
release.



> Unknown request error when generating Acctg Trans Entries PDF from invoice 
> overview page
> 
>
> Key: OFBIZ-7077
> URL: https://issues.apache.org/jira/browse/OFBIZ-7077
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, birt
>Affects Versions: Release Branch 13.07
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
>
> Problem:
> Unknown request [InvoiceAcctgTransEntriesPdf]
> Step to regenerate:
> 1) Go to http://demo-stable.ofbiz.apache.org/ar/control/FindArInvoices
> 2) Go to invoice overview page of any sales invoice.
> 3) Click on "Acctg Trans Entries PDF" button.
> Root Cause:
> InvoiceAcctgTransEntriesPdf  request was available in the birt component of 
> specialpurpose and that component was removed from the specialpurpose in 
> 13.07 release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-8462) Improvements in ShipmentItemBilling entity definition and services

2017-07-09 Thread Devanshu Vyas (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Devanshu Vyas updated OFBIZ-8462:
-
Attachment: OFBIZ-8462.patch

Uploaded patch CRUD service definition and related changes. 

> Improvements in ShipmentItemBilling entity definition and services
> --
>
> Key: OFBIZ-8462
> URL: https://issues.apache.org/jira/browse/OFBIZ-8462
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Priority: Minor
> Attachments: OFBIZ-8462.patch
>
>
> Required improvements;
> - All is good with entity definition.
> - Add CRUD services using entity-auto.Make sure PK is not optional while 
> create service as there is composite primary key.
> - Do related changes if any occurrence found for direct create/delete of this 
> entity, and replace them with crud services implemented.
> - As no status/from date/thru date exists in entity, so nothing needs to be 
> taken care while deleting the records from service.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8965) OFBIZ-7520: Consistency and Readability improvements for event tag (controller.xml)

2017-07-09 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079556#comment-16079556
 ] 

Rishi Solanki commented on OFBIZ-8965:
--

Can we resolve this one as OFBIZ-9114 is closed.

> OFBIZ-7520: Consistency and Readability improvements for event tag 
> (controller.xml)
> ---
>
> Key: OFBIZ-8965
> URL: https://issues.apache.org/jira/browse/OFBIZ-8965
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8965.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write is
> 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8953) OFBIZ-7520: Consistency and Readability improvements for call-service tag

2017-07-09 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079555#comment-16079555
 ] 

Rishi Solanki commented on OFBIZ-8953:
--

Can we resolve this one as OFBIZ-9114 is closed.

> OFBIZ-7520: Consistency and Readability improvements for call-service tag
> -
>
> Key: OFBIZ-8953
> URL: https://issues.apache.org/jira/browse/OFBIZ-8953
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Ankush Upadhyay
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-8953.patch
>
>
> Code written in Minilang for the if-compare tag is not consistent throughout 
> the application. The correct pattern to write:
> 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9444) Dependency problem between Solr 6.6.0 and Guava

2017-07-09 Thread Renuka Srishti (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-9444:
--
Attachment: OFBIZ-9444.patch

I hope this patch will help you.

> Dependency problem between Solr 6.6.0 and Guava
> ---
>
> Key: OFBIZ-9444
> URL: https://issues.apache.org/jira/browse/OFBIZ-9444
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Renuka Srishti
> Attachments: dependencies.txt, OFBIZ-9444.patch
>
>
> It seems we have a dependency problem in our codebase.
> The Solr code needs access to a method 
> com.google.common.base.Objects.firstNonNull, which was removed from Guava 
> from version 21 (see [1]).
> I tried to add the dependency both through the Solr build.gradle with
> {code:java}
> dependencies {
> pluginLibsCompile 'org.apache.solr:solr-core:6.6.0'
> pluginLibsCompile 'com.google.guava:guava:20.0'
> }
> {code}
> and also as a runtime dependency in main build.gradle
> {code:java}
> dependencies {
> // ofbiz compile libs
> ...
> runtime 'com.google.guava:guava:20.0'
> ...
> }
> {code}
> Both did not work. Running my Solo tests I get the error
> {code:java}
> 2017-07-01 14:25:18,049 |jsse-nio-8443-exec-4 |HttpSolrCall  
> |E| null:java.lang.RuntimeException: java.lang.NoSuchMethodError: 
> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
> at 
> org.apache.solr.servlet.HttpSolrCall.sendError(HttpSolrCall.java:676)
> at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:544)
> at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361)
> at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305)
> at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.doFilter(OFBizSolrContextFilter.java:151)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
> at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
> at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
> at 
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
> at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
> at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
> at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
> at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NoSuchMethodError: 
> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
> at 
> org.apache.solr.handler.component.HighlightComponent.prepare(HighlightComponent.java:118)
> at 
> org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:270)
> at 
> org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173)
> at org.apache.solr.core.SolrCore.execute(SolrCore.java:2477)
> at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:723)
> at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:529)
> ... 25 more

[jira] [Assigned] (OFBIZ-9444) Dependency problem between Solr 6.6.0 and Guava

2017-07-09 Thread Renuka Srishti (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti reassigned OFBIZ-9444:
-

Assignee: Renuka Srishti

> Dependency problem between Solr 6.6.0 and Guava
> ---
>
> Key: OFBIZ-9444
> URL: https://issues.apache.org/jira/browse/OFBIZ-9444
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Renuka Srishti
> Attachments: dependencies.txt
>
>
> It seems we have a dependency problem in our codebase.
> The Solr code needs access to a method 
> com.google.common.base.Objects.firstNonNull, which was removed from Guava 
> from version 21 (see [1]).
> I tried to add the dependency both through the Solr build.gradle with
> {code:java}
> dependencies {
> pluginLibsCompile 'org.apache.solr:solr-core:6.6.0'
> pluginLibsCompile 'com.google.guava:guava:20.0'
> }
> {code}
> and also as a runtime dependency in main build.gradle
> {code:java}
> dependencies {
> // ofbiz compile libs
> ...
> runtime 'com.google.guava:guava:20.0'
> ...
> }
> {code}
> Both did not work. Running my Solo tests I get the error
> {code:java}
> 2017-07-01 14:25:18,049 |jsse-nio-8443-exec-4 |HttpSolrCall  
> |E| null:java.lang.RuntimeException: java.lang.NoSuchMethodError: 
> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
> at 
> org.apache.solr.servlet.HttpSolrCall.sendError(HttpSolrCall.java:676)
> at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:544)
> at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361)
> at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305)
> at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.doFilter(OFBizSolrContextFilter.java:151)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
> at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
> at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
> at 
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
> at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
> at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
> at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
> at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NoSuchMethodError: 
> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
> at 
> org.apache.solr.handler.component.HighlightComponent.prepare(HighlightComponent.java:118)
> at 
> org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:270)
> at 
> org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173)
> at org.apache.solr.core.SolrCore.execute(SolrCore.java:2477)
> at org.apache.solr.servlet.HttpSolrCall.execute(HttpSolrCall.java:723)
> at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:529)
> ... 25 more
> {code}
> After removing my grade cache and 

[jira] [Commented] (OFBIZ-9444) Dependency problem between Solr 6.6.0 and Guava

2017-07-09 Thread Renuka Srishti (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079544#comment-16079544
 ] 

Renuka Srishti commented on OFBIZ-9444:
---

Hii Michael,
Add dependency in main build.gradle
{code}
compile group: 'com.google.guava', name: 'guava', version: '20.0'
{code}
I have tried this and it's not showing any error. Please check and let me know 
if you find any issue.

> Dependency problem between Solr 6.6.0 and Guava
> ---
>
> Key: OFBIZ-9444
> URL: https://issues.apache.org/jira/browse/OFBIZ-9444
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
> Attachments: dependencies.txt
>
>
> It seems we have a dependency problem in our codebase.
> The Solr code needs access to a method 
> com.google.common.base.Objects.firstNonNull, which was removed from Guava 
> from version 21 (see [1]).
> I tried to add the dependency both through the Solr build.gradle with
> {code:java}
> dependencies {
> pluginLibsCompile 'org.apache.solr:solr-core:6.6.0'
> pluginLibsCompile 'com.google.guava:guava:20.0'
> }
> {code}
> and also as a runtime dependency in main build.gradle
> {code:java}
> dependencies {
> // ofbiz compile libs
> ...
> runtime 'com.google.guava:guava:20.0'
> ...
> }
> {code}
> Both did not work. Running my Solo tests I get the error
> {code:java}
> 2017-07-01 14:25:18,049 |jsse-nio-8443-exec-4 |HttpSolrCall  
> |E| null:java.lang.RuntimeException: java.lang.NoSuchMethodError: 
> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
> at 
> org.apache.solr.servlet.HttpSolrCall.sendError(HttpSolrCall.java:676)
> at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:544)
> at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:361)
> at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:305)
> at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.doFilter(OFBizSolrContextFilter.java:151)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
> at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
> at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
> at 
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
> at 
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
> at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
> at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
> at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NoSuchMethodError: 
> com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
> at 
> org.apache.solr.handler.component.HighlightComponent.prepare(HighlightComponent.java:118)
> at 
> org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:270)
> at 
> org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:173)
> at org.apache.solr.core.SolrCore.execute(SolrCore.java:2477)
> at 

[jira] [Commented] (OFBIZ-8323) can enter empty content for product facility

2017-07-09 Thread priya sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079534#comment-16079534
 ] 

priya sharma commented on OFBIZ-8323:
-

Hello Wai,

Actually when you click the add button, facility field contains the first value 
in the dropdown box and the same is being submitted with the form. So the 
content is not empty.

But yes I do see that when the same facility is added again error and success 
message are seen simultaneously. Perhaps we can look into that issue.

Regards!

> can enter empty content for product facility
> 
>
> Key: OFBIZ-8323
> URL: https://issues.apache.org/jira/browse/OFBIZ-8323
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Wai
>
> -go to 
> https://localhost:8443/catalog/control/EditProductFacilities?productId=WG-9943
> -click on add button.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9328) Create New button is misplaced on Party Content Screen

2017-07-09 Thread Humera Khan (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079532#comment-16079532
 ] 

Humera Khan commented on OFBIZ-9328:


Thanks, Arun :)

> Create New button is misplaced on Party Content Screen
> --
>
> Key: OFBIZ-9328
> URL: https://issues.apache.org/jira/browse/OFBIZ-9328
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: CreateNewButton.png, OFBIZ-9328.patch, OFBIZ-9328.patch
>
>
> The Create New button is wrongly placed on the Party Content screen(navigated 
> from a Party Profile screen). The button should be placed outside of the 
> Content List section instead of inside. (CreateNewButton.png)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9259) Uploading images at catalog/control/addImageForProduct does not work

2017-07-09 Thread Devanshu Vyas (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079531#comment-16079531
 ] 

Devanshu Vyas commented on OFBIZ-9259:
--

Hello Jaques, 

I tried to regenerate the issue, but I found a different issue.
{code}
java.lang.Exception: Service [addMultipleuploadForProduct] threw an unexpected 
exception/error
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
 [ofbiz.jar:?]


2017-07-09 15:42:40,189 |sse-nio-8443-exec-11 |CallService   
|E| ERROR: Could not complete the Method to upload multiple images for product 
[file:/home/devanshu/ofbiz_dev/bug_crush/trunk/applications/product/minilang/product/imagemanagement/ImageManagementServices.xml#UploadProductImages]
 process [problem invoking the [addMultipleuploadForProduct] service with the 
map named [addAdditionalViewForProductMap] containing 
[{userLogin=[GenericEntity:UserLogin][createdStamp,2017-07-09 
02:42:04.614(java.sql.Timestamp)][createdTxStamp,2017-07-09 
02:42:04.609(java.sql.Timestamp)][currentPassword,{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,null()][externalAuthId,null()][hasLoggedOut,null()][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Calcutta(java.lang.String)][lastUpdatedStamp,2017-07-09
 02:43:49.871(java.sql.Timestamp)][lastUpdatedTxStamp,2017-07-09 
02:43:49.702(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,admin(java.lang.String)],
 productId=GZ-1000, _uploadedFile_contentType=image/png, 
timeZone=sun.util.calendar.ZoneInfo[id="Asia/Calcutta",offset=1980,dstSavings=0,useDaylight=false,transitions=6,lastRule=null],
 locale=en_US, productContentTypeId=IMAGE, imageResize=null, 
uploadedFile=java.nio.HeapByteBuffer[pos=0 lim=204237 cap=204237], 
_uploadedFile_fileName=3d Spider Man Homecoming M Movie Tickets Online Booking  
Showtimes in Indore   Paytm.com.png}]: Service [addMultipleuploadForProduct] 
target threw an unexpected exception (null)]

{code}

Steps followed for regeneration:
- Go to Catalog application.
- Click on the (Image Management) menu item.
- Click on the (Upload) sub-menu item.
- Set a product and upload image(s).
- Click on the (Upload) button.

Let me know if this is the issue you are referring to or is entirely different.

> Uploading images at catalog/control/addImageForProduct does not work
> 
>
> Key: OFBIZ-9259
> URL: https://issues.apache.org/jira/browse/OFBIZ-9259
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> This the error I got on trunk demo. The same happens locally, I did not try 
> older branches.
> bq. org.apache.ofbiz.webapp.event.EventHandlerException: Problems reading 
> uploaded data (Processing of multipart/form-data request failed. 
> runtime/tmp/upload_36728b66_61cb_4e79_a4c0_3d9fffd64a3a_0002.tmp (No such 
> file or directory))



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7828) Entity and Service definition

2017-07-09 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079530#comment-16079530
 ] 

Rishi Solanki commented on OFBIZ-7828:
--

ShipmentItemBilling, Lot and CommEventContentAssoc entities work still remains. 
Also not able to find more entities/services which fall under this category 
except OrderHeader. So This ticket is towards completion.

The above entities have many occurrence of delegator used inline in the code. 
And bit complex to replace by services, will do some sanity and upload the 
patches soon. After that this we can say this ticket is complete. 

> Entity and Service definition
> -
>
> Key: OFBIZ-7828
> URL: https://issues.apache.org/jira/browse/OFBIZ-7828
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Assignee: Arun Patidar
>
> As per discussion on dev list on email thread-: "Entity and Service 
> definition" Here is the parent task for the same.
> TODO's from same thread, review entities/services on following parameters;
> 1) Many entity definitions having relationships with view-entities, like 
> OrderHeader entity maintain relationship with OrderHeaderNoteView and 
> OrderItemAndShipGroupAssoc. We should remove it, maintain the relationship at 
> view-entities level if required. Also change the code where this relation is 
> in use.
> 2) Many entities having service implementation exists but they can be simply 
> convert into entity-auto, that means can use the power OFBiz provides.
> 3) As mentioned initially many entities do not have CRUD services exists, we 
> should implement or use entity-auto for them wherever applicable. Also remove 
> direct use of delegator for them.
> 4) Many entities having from date and thru date, Or status Or Enumeration to 
> manage the historical data, but services actually remove those entity data. 
> We should change the service implementation to maintain the historical data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-6774) ACCTG TRANS ENTRIES PDF link on invoiceOverview does not work

2017-07-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079522#comment-16079522
 ] 

Deepak Dixit commented on OFBIZ-6774:
-

Backported missing file in R16.11 at r#1801361

> ACCTG TRANS ENTRIES PDF link on invoiceOverview does not work
> -
>
> Key: OFBIZ-6774
> URL: https://issues.apache.org/jira/browse/OFBIZ-6774
> Project: OFBiz
>  Issue Type: Bug
>  Components: birt, order
>Affects Versions: Release Branch 13.07
> Environment: Ubuntu linux 15.04, JVM 7u91-2.6.3-0ubuntu0.15.04.1
>Reporter: Morten Jensen
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 16.11.04
>
> Attachments: OFBIZ-6774_16.11.patch, OFBIZ-6774_trunk.patch
>
>
> Whenever I click on the ACCTG TRANS ENTRIES PDF link in the invoice overview 
> screen I get the following error:
> org.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [InvoiceAcctgTransEntriesPdf]; this request does not exist or cannot be 
> called directly.
> A grep through the full ofbiz repo yields no results for an implementation or 
> freemarker template - only the link itself in accounting menus xml:
> git checkout release13.07
> find . -type f -exec grep -i InvoiceAcctgTransEntriesPdf {} \; -ls
> 
> 528005   72 -rw-rw-r--   1 xxx  xxx 70103 Dec 17 07:05 
> ./applications/accounting/widget/AccountingMenus.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-6774) ACCTG TRANS ENTRIES PDF link on invoiceOverview does not work

2017-07-09 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079521#comment-16079521
 ] 

Arun Patidar commented on OFBIZ-6774:
-

Added missing file in ofbiz framework trunk at r#1801359.

> ACCTG TRANS ENTRIES PDF link on invoiceOverview does not work
> -
>
> Key: OFBIZ-6774
> URL: https://issues.apache.org/jira/browse/OFBIZ-6774
> Project: OFBiz
>  Issue Type: Bug
>  Components: birt, order
>Affects Versions: Release Branch 13.07
> Environment: Ubuntu linux 15.04, JVM 7u91-2.6.3-0ubuntu0.15.04.1
>Reporter: Morten Jensen
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 16.11.04
>
> Attachments: OFBIZ-6774_16.11.patch, OFBIZ-6774_trunk.patch
>
>
> Whenever I click on the ACCTG TRANS ENTRIES PDF link in the invoice overview 
> screen I get the following error:
> org.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [InvoiceAcctgTransEntriesPdf]; this request does not exist or cannot be 
> called directly.
> A grep through the full ofbiz repo yields no results for an implementation or 
> freemarker template - only the link itself in accounting menus xml:
> git checkout release13.07
> find . -type f -exec grep -i InvoiceAcctgTransEntriesPdf {} \; -ls
> 
> 528005   72 -rw-rw-r--   1 xxx  xxx 70103 Dec 17 07:05 
> ./applications/accounting/widget/AccountingMenus.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9391) Update Apache Solr/Lucene to release 6.6.0

2017-07-09 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079520#comment-16079520
 ] 

Jacques Le Roux commented on OFBIZ-9391:


Hi Michael,

bq. Any help from the Cradle specialists is appreciated 
I guess you mean Gradle? ;)

> Update Apache Solr/Lucene to release 6.6.0
> --
>
> Key: OFBIZ-9391
> URL: https://issues.apache.org/jira/browse/OFBIZ-9391
> Project: OFBiz
>  Issue Type: Improvement
>  Components: solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> There are new Solr/Lucene versions 6.6.0 available, see 
> https://lucene.apache.org/core/6_6_0/changes/Changes.html and 
> https://lucene.apache.org/solr/6_6_0/changes/Changes.html.
> This Jira takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9143) The copyAgreement service fails

2017-07-09 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-9143.
---
   Resolution: Fixed
Fix Version/s: 16.11.04

> The copyAgreement service fails
> ---
>
> Key: OFBIZ-9143
> URL: https://issues.apache.org/jira/browse/OFBIZ-9143
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9143.patch
>
>
> Error (in French)
> Le service dispatcher a renvoyé une exception :Outgoing result (in runSync : 
> copyAgreement) does not match expected requirements (Le paramètre requis 
> suivant manque : [OUT] [copyAgreement.agreementId])
> In other words, [copyAgreement.agreementId [OUT] parameter misses



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9143) The copyAgreement service fails

2017-07-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079518#comment-16079518
 ] 

Deepak Dixit commented on OFBIZ-9143:
-

Thanks Jacques and Renuka for your contribution.
This has been fixed at ofbiz framework trunk at r#1801357
R16.11 at r#1801358

> The copyAgreement service fails
> ---
>
> Key: OFBIZ-9143
> URL: https://issues.apache.org/jira/browse/OFBIZ-9143
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Renuka Srishti
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9143.patch
>
>
> Error (in French)
> Le service dispatcher a renvoyé une exception :Outgoing result (in runSync : 
> copyAgreement) does not match expected requirements (Le paramètre requis 
> suivant manque : [OUT] [copyAgreement.agreementId])
> In other words, [copyAgreement.agreementId [OUT] parameter misses



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9143) The copyAgreement service fails

2017-07-09 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-9143:
---

Assignee: Deepak Dixit  (was: Renuka Srishti)

> The copyAgreement service fails
> ---
>
> Key: OFBIZ-9143
> URL: https://issues.apache.org/jira/browse/OFBIZ-9143
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9143.patch
>
>
> Error (in French)
> Le service dispatcher a renvoyé une exception :Outgoing result (in runSync : 
> copyAgreement) does not match expected requirements (Le paramètre requis 
> suivant manque : [OUT] [copyAgreement.agreementId])
> In other words, [copyAgreement.agreementId [OUT] parameter misses



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9478) RequestHandlerException in dataResource and fixed asset lookup.

2017-07-09 Thread Humera Khan (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Humera Khan updated OFBIZ-9478:
---
Attachment: OFBIZ-9478-Budget.patch
ActualResult_Budget_Lookup.png
ExpectedResult_Budget_Lookup.png

> RequestHandlerException in dataResource and fixed asset lookup.
> ---
>
> Key: OFBIZ-9478
> URL: https://issues.apache.org/jira/browse/OFBIZ-9478
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pallavi Goyal
>Priority: Minor
> Attachments: ActualResult_Budget_Lookup.png, 
> ActualResult_DataResource_Lookup.png, ActualResult_FixedAsset_Lookup.png, 
> ExpectedResult_Budget_Lookup.png, ExpectedResult_DataResource_Lookup.png, 
> ExpectedResult_FixedAsset_Lookup.png, OFBIZ-9478-Budget.patch, 
> OFBIZ-9478-FixedAsset.patch, OFBIZ-9478.patch
>
>
> *Steps to regenerate exception in dataResource lookup - *
> 1. Go to "Facility" component.
> 2. Click on [ Content ] menu-tab.
> 3. Open lookup of "Existing Content Id".
> 4. The content lookup will open.
> 5. Open the lookup of "Data Resource Id"
> Actual - RequestHandlerException
> Expected - The dataResource lookup should open.
> *Steps to regenerate exception in fixed asset lookup - *
> 1. Go to "Facility" component.
> 2. Click on [ Inventory Items Details ] menu-tab.
> 3. Open lookup of "Work Effort Id".
> 4. The Work Effort By Name lookup will open.
> 5. Open the lookup of "Fixed Asset Id".
> Actual - RequestHandlerException
> Expected - The fixed asset lookup should open.
> *Steps to regenerate exception in budget lookup - *
> 1. Go to "Party" component.
> 2. Find and view party.
> 2. Click on [ Employment Applications ] menu-tab.
> 3. Open lookup of "Empl Position Id".
> 4. The EmplPosition By Name lookup will open.
> 5. Open the lookup of "Budget Id".
> Actual - RequestHandlerException
> Expected - The budget lookup should open.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9478) RequestHandlerException in dataResource and fixed asset lookup.

2017-07-09 Thread Pallavi Goyal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pallavi Goyal updated OFBIZ-9478:
-
Description: 
*Steps to regenerate exception in dataResource lookup - *
1. Go to "Facility" component.
2. Click on [ Content ] menu-tab.
3. Open lookup of "Existing Content Id".
4. The content lookup will open.
5. Open the lookup of "Data Resource Id"

Actual - RequestHandlerException

Expected - The dataResource lookup should open.

*Steps to regenerate exception in fixed asset lookup - *
1. Go to "Facility" component.
2. Click on [ Inventory Items Details ] menu-tab.
3. Open lookup of "Work Effort Id".
4. The Work Effort By Name lookup will open.
5. Open the lookup of "Fixed Asset Id".

Actual - RequestHandlerException

Expected - The fixed asset lookup should open.

*Steps to regenerate exception in budget lookup - *
1. Go to "Party" component.
2. Find and view party.
2. Click on [ Employment Applications ] menu-tab.
3. Open lookup of "Empl Position Id".
4. The EmplPosition By Name lookup will open.
5. Open the lookup of "Budget Id".

Actual - RequestHandlerException

Expected - The budget lookup should open.


  was:
*Steps to regenerate exception in dataResource lookup - *
1. Go to "Facility" component.
2. Click on [ Content ] menu-tab.
3. Open lookup of "Existing Content Id".
4. The content lookup will open.
5. Open the lookup of "Data Resource Id"

Actual - RequestHandlerException

Expected - The dataResource lookup should open.

*Steps to regenerate exception in fixed asset lookup - *
1. Go to "Facility" component.
2. Click on [ Inventory Items Details ] menu-tab.
3. Open lookup of "Work Effort Id".
4. The Work Effort By Name lookup will open.
5. Open the lookup of "Fixed Asset Id".

Actual - RequestHandlerException

Expected - The fixed asset lookup should open.



> RequestHandlerException in dataResource and fixed asset lookup.
> ---
>
> Key: OFBIZ-9478
> URL: https://issues.apache.org/jira/browse/OFBIZ-9478
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pallavi Goyal
>Priority: Minor
> Attachments: ActualResult_DataResource_Lookup.png, 
> ActualResult_FixedAsset_Lookup.png, ExpectedResult_DataResource_Lookup.png, 
> ExpectedResult_FixedAsset_Lookup.png, OFBIZ-9478-FixedAsset.patch, 
> OFBIZ-9478.patch
>
>
> *Steps to regenerate exception in dataResource lookup - *
> 1. Go to "Facility" component.
> 2. Click on [ Content ] menu-tab.
> 3. Open lookup of "Existing Content Id".
> 4. The content lookup will open.
> 5. Open the lookup of "Data Resource Id"
> Actual - RequestHandlerException
> Expected - The dataResource lookup should open.
> *Steps to regenerate exception in fixed asset lookup - *
> 1. Go to "Facility" component.
> 2. Click on [ Inventory Items Details ] menu-tab.
> 3. Open lookup of "Work Effort Id".
> 4. The Work Effort By Name lookup will open.
> 5. Open the lookup of "Fixed Asset Id".
> Actual - RequestHandlerException
> Expected - The fixed asset lookup should open.
> *Steps to regenerate exception in budget lookup - *
> 1. Go to "Party" component.
> 2. Find and view party.
> 2. Click on [ Employment Applications ] menu-tab.
> 3. Open lookup of "Empl Position Id".
> 4. The EmplPosition By Name lookup will open.
> 5. Open the lookup of "Budget Id".
> Actual - RequestHandlerException
> Expected - The budget lookup should open.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9479) Use FlexibleLocation.resolveLocation() instead of hard-coded path

2017-07-09 Thread Devanshu Vyas (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Devanshu Vyas updated OFBIZ-9479:
-
Attachment: OFBIZ-9479.patch

Uploaded patch with fixes to use FlexibleLocation.resolveLocation() method in 
place of hard-coded URL path preparation.

> Use FlexibleLocation.resolveLocation() instead of hard-coded path
> -
>
> Key: OFBIZ-9479
> URL: https://issues.apache.org/jira/browse/OFBIZ-9479
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-9479.patch
>
>
> I found some occurrences where file path URL is prepared using the actual 
> path of the file rather than the relative path. For e.g. 
> {code}
> String imgPropertyFullPath = System.getProperty("ofbiz.home") + 
> "/applications/product/config/ImageProperties.xml";
> {code}
> IMO the location URL of files should be prepared dynamically using relative 
> paths and this can be achieved by using
> FlexibleLocation.resolveLocation() method. This method covers all the 
> scenarios and in future, if we want to change anything, then all we need is 
> to update the method and all instances will be fixed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9480) Remove cancelAgreement service

2017-07-09 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9480:

Component/s: accounting

> Remove cancelAgreement service 
> ---
>
> Key: OFBIZ-9480
> URL: https://issues.apache.org/jira/browse/OFBIZ-9480
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Fix For: Upcoming Release
>
>
> Remove cancelAgreement service , add entity-auto expireAgreement service 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9480) Remove cancelAgreement service

2017-07-09 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9480:

Affects Version/s: Trunk

> Remove cancelAgreement service 
> ---
>
> Key: OFBIZ-9480
> URL: https://issues.apache.org/jira/browse/OFBIZ-9480
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Fix For: Upcoming Release
>
>
> Remove cancelAgreement service , add entity-auto expireAgreement service 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9480) Remove cancelAgreement service

2017-07-09 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-9480.
---
   Resolution: Done
Fix Version/s: Upcoming Release

> Remove cancelAgreement service 
> ---
>
> Key: OFBIZ-9480
> URL: https://issues.apache.org/jira/browse/OFBIZ-9480
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Fix For: Upcoming Release
>
>
> Remove cancelAgreement service , add entity-auto expireAgreement service 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9480) Remove cancelAgreement service

2017-07-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079513#comment-16079513
 ] 

Deepak Dixit commented on OFBIZ-9480:
-

This has been done at ofbiz framework trunk at r#1801355

> Remove cancelAgreement service 
> ---
>
> Key: OFBIZ-9480
> URL: https://issues.apache.org/jira/browse/OFBIZ-9480
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>
> Remove cancelAgreement service , add entity-auto expireAgreement service 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9477) UI issue in Lead Lookup on find opportunity

2017-07-09 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9477:
---

Assignee: Arun Patidar

> UI issue in Lead Lookup on find opportunity
> ---
>
> Key: OFBIZ-9477
> URL: https://issues.apache.org/jira/browse/OFBIZ-9477
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Jagpreet Kaur
>Assignee: Arun Patidar
> Attachments: screenshot-1.png
>
>
> Issue #1
> 1) Go to SFA component.
> 2) Click on Find Opportunity tab 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity]
> 3) In Find Opportunity section the open the "Lead Lookup"
> Issue #2
> The autocompleter of Lead displays the wrong suggestions



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9143) The copyAgreement service fails

2017-07-09 Thread Renuka Srishti (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti reassigned OFBIZ-9143:
-

Assignee: Renuka Srishti

> The copyAgreement service fails
> ---
>
> Key: OFBIZ-9143
> URL: https://issues.apache.org/jira/browse/OFBIZ-9143
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Renuka Srishti
> Attachments: OFBIZ-9143.patch
>
>
> Error (in French)
> Le service dispatcher a renvoyé une exception :Outgoing result (in runSync : 
> copyAgreement) does not match expected requirements (Le paramètre requis 
> suivant manque : [OUT] [copyAgreement.agreementId])
> In other words, [copyAgreement.agreementId [OUT] parameter misses



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-9143) The copyAgreement service fails

2017-07-09 Thread Renuka Srishti (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079390#comment-16079390
 ] 

Renuka Srishti edited comment on OFBIZ-9143 at 7/9/17 8:52 AM:
---

Able to regenerate the issue. Providing the patch for this issue.


was (Author: renuka_srishti):
Hii Jacques,
Please share the steps to regenerate this issue.

> The copyAgreement service fails
> ---
>
> Key: OFBIZ-9143
> URL: https://issues.apache.org/jira/browse/OFBIZ-9143
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>
> Error (in French)
> Le service dispatcher a renvoyé une exception :Outgoing result (in runSync : 
> copyAgreement) does not match expected requirements (Le paramètre requis 
> suivant manque : [OUT] [copyAgreement.agreementId])
> In other words, [copyAgreement.agreementId [OUT] parameter misses



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9479) Use FlexibleLocation.resolveLocation() instead of hard-coded path

2017-07-09 Thread Devanshu Vyas (JIRA)
Devanshu Vyas created OFBIZ-9479:


 Summary: Use FlexibleLocation.resolveLocation() instead of 
hard-coded path
 Key: OFBIZ-9479
 URL: https://issues.apache.org/jira/browse/OFBIZ-9479
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Devanshu Vyas
Priority: Minor


I found some occurrences where file path URL is prepared using the actual path 
of the file rather than the relative path. For e.g. 
{code}
String imgPropertyFullPath = System.getProperty("ofbiz.home") + 
"/applications/product/config/ImageProperties.xml";
{code}

IMO the location URL of files should be prepared dynamically using relative 
paths and this can be achieved by using
FlexibleLocation.resolveLocation() method. This method covers all the scenarios 
and in future, if we want to change anything, then all we need is to update the 
method and all instances will be fixed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9476) UI issue in payment lookup.

2017-07-09 Thread Pallavi Goyal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pallavi Goyal updated OFBIZ-9476:
-
Attachment: OFBIZ-9476.patch

*Steps to verify -*
1. Follow the steps in the description.
2. The lookup should have two sections - form and list of results.
On click of [ Find ] button, the list should render in proper tabular manner.

Providing OFBIZ-9476.patch for the ticket.

> UI issue in payment lookup.
> ---
>
> Key: OFBIZ-9476
> URL: https://issues.apache.org/jira/browse/OFBIZ-9476
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9476.patch, payment-lookup-ui-issuepng
>
>
> *Steps to regenerate -*
> 1. Go to "Accounting - AR" component.
> 2. Click on [ Invoices ] menu tab.
> 3. Open any invoice whose status is not "Paid" or "Ready for posting".
> 4. Click on [ Applications ] sub-menu tab.
> 5. Open the "Payment Lookup".
> Actual - The column headers of List Payments table are not in format and 
> therefore the list of payments is also not displayed.
> Expected - The columns should be in proper tabular format and the list should 
> be displayed upon find.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9478) RequestHandlerException in dataResource and fixed asset lookup.

2017-07-09 Thread Humera Khan (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Humera Khan updated OFBIZ-9478:
---
Attachment: ActualResult_FixedAsset_Lookup.png
ExpectedResult_FixedAsset_Lookup.png

> RequestHandlerException in dataResource and fixed asset lookup.
> ---
>
> Key: OFBIZ-9478
> URL: https://issues.apache.org/jira/browse/OFBIZ-9478
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pallavi Goyal
>Priority: Minor
> Attachments: ActualResult_DataResource_Lookup.png, 
> ActualResult_FixedAsset_Lookup.png, ExpectedResult_DataResource_Lookup.png, 
> ExpectedResult_FixedAsset_Lookup.png, OFBIZ-9478-FixedAsset.patch, 
> OFBIZ-9478.patch
>
>
> *Steps to regenerate exception in dataResource lookup - *
> 1. Go to "Facility" component.
> 2. Click on [ Content ] menu-tab.
> 3. Open lookup of "Existing Content Id".
> 4. The content lookup will open.
> 5. Open the lookup of "Data Resource Id"
> Actual - RequestHandlerException
> Expected - The dataResource lookup should open.
> *Steps to regenerate exception in fixed asset lookup - *
> 1. Go to "Facility" component.
> 2. Click on [ Inventory Items Details ] menu-tab.
> 3. Open lookup of "Work Effort Id".
> 4. The Work Effort By Name lookup will open.
> 5. Open the lookup of "Fixed Asset Id".
> Actual - RequestHandlerException
> Expected - The fixed asset lookup should open.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9478) RequestHandlerException in dataResource and fixed asset lookup.

2017-07-09 Thread Humera Khan (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Humera Khan updated OFBIZ-9478:
---
Attachment: OFBIZ-9478-FixedAsset.patch

> RequestHandlerException in dataResource and fixed asset lookup.
> ---
>
> Key: OFBIZ-9478
> URL: https://issues.apache.org/jira/browse/OFBIZ-9478
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pallavi Goyal
>Priority: Minor
> Attachments: ActualResult_DataResource_Lookup.png, 
> ActualResult_FixedAsset_Lookup.png, ExpectedResult_DataResource_Lookup.png, 
> ExpectedResult_FixedAsset_Lookup.png, OFBIZ-9478-FixedAsset.patch, 
> OFBIZ-9478.patch
>
>
> *Steps to regenerate exception in dataResource lookup - *
> 1. Go to "Facility" component.
> 2. Click on [ Content ] menu-tab.
> 3. Open lookup of "Existing Content Id".
> 4. The content lookup will open.
> 5. Open the lookup of "Data Resource Id"
> Actual - RequestHandlerException
> Expected - The dataResource lookup should open.
> *Steps to regenerate exception in fixed asset lookup - *
> 1. Go to "Facility" component.
> 2. Click on [ Inventory Items Details ] menu-tab.
> 3. Open lookup of "Work Effort Id".
> 4. The Work Effort By Name lookup will open.
> 5. Open the lookup of "Fixed Asset Id".
> Actual - RequestHandlerException
> Expected - The fixed asset lookup should open.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9478) RequestHandlerException in dataResource and fixed asset lookup.

2017-07-09 Thread Pallavi Goyal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pallavi Goyal updated OFBIZ-9478:
-
Description: 
*Steps to regenerate exception in dataResource lookup - *
1. Go to "Facility" component.
2. Click on [ Content ] menu-tab.
3. Open lookup of "Existing Content Id".
4. The content lookup will open.
5. Open the lookup of "Data Resource Id"

Actual - RequestHandlerException

Expected - The dataResource lookup should open.

*Steps to regenerate exception in fixed asset lookup - *
1. Go to "Facility" component.
2. Click on [ Inventory Items Details ] menu-tab.
3. Open lookup of "Work Effort Id".
4. The Work Effort By Name lookup will open.
5. Open the lookup of "Fixed Asset Id".

Actual - RequestHandlerException

Expected - The fixed asset lookup should open.


  was:
*Steps to regenerate - *
1. Go to "Facility" component.
2. Click on [ Content ] menu-tab.
3. Open lookup of "Existing Content Id".
4. The content lookup will open.
5. Open the lookup of "Data Resource Id"

Actual - RequestHandlerException

Expected - The dataResource lookup should open.


> RequestHandlerException in dataResource and fixed asset lookup.
> ---
>
> Key: OFBIZ-9478
> URL: https://issues.apache.org/jira/browse/OFBIZ-9478
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pallavi Goyal
>Priority: Minor
> Attachments: ActualResult_DataResource_Lookup.png, 
> ExpectedResult_DataResource_Lookup.png, OFBIZ-9478.patch
>
>
> *Steps to regenerate exception in dataResource lookup - *
> 1. Go to "Facility" component.
> 2. Click on [ Content ] menu-tab.
> 3. Open lookup of "Existing Content Id".
> 4. The content lookup will open.
> 5. Open the lookup of "Data Resource Id"
> Actual - RequestHandlerException
> Expected - The dataResource lookup should open.
> *Steps to regenerate exception in fixed asset lookup - *
> 1. Go to "Facility" component.
> 2. Click on [ Inventory Items Details ] menu-tab.
> 3. Open lookup of "Work Effort Id".
> 4. The Work Effort By Name lookup will open.
> 5. Open the lookup of "Fixed Asset Id".
> Actual - RequestHandlerException
> Expected - The fixed asset lookup should open.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9478) RequestHandlerException in dataResource and fixed asset lookup.

2017-07-09 Thread Pallavi Goyal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pallavi Goyal updated OFBIZ-9478:
-
Summary: RequestHandlerException in dataResource and fixed asset lookup.  
(was: RequestHandlerException in dataResource loopkup.)

> RequestHandlerException in dataResource and fixed asset lookup.
> ---
>
> Key: OFBIZ-9478
> URL: https://issues.apache.org/jira/browse/OFBIZ-9478
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pallavi Goyal
>Priority: Minor
> Attachments: ActualResult_DataResource_Lookup.png, 
> ExpectedResult_DataResource_Lookup.png, OFBIZ-9478.patch
>
>
> *Steps to regenerate - *
> 1. Go to "Facility" component.
> 2. Click on [ Content ] menu-tab.
> 3. Open lookup of "Existing Content Id".
> 4. The content lookup will open.
> 5. Open the lookup of "Data Resource Id"
> Actual - RequestHandlerException
> Expected - The dataResource lookup should open.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9478) RequestHandlerException in dataResource loopkup.

2017-07-09 Thread Humera Khan (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Humera Khan updated OFBIZ-9478:
---
Attachment: ActualResult_DataResource_Lookup.png
ExpectedResult_DataResource_Lookup.png

> RequestHandlerException in dataResource loopkup.
> 
>
> Key: OFBIZ-9478
> URL: https://issues.apache.org/jira/browse/OFBIZ-9478
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pallavi Goyal
>Priority: Minor
> Attachments: ActualResult_DataResource_Lookup.png, 
> ExpectedResult_DataResource_Lookup.png, OFBIZ-9478.patch
>
>
> *Steps to regenerate - *
> 1. Go to "Facility" component.
> 2. Click on [ Content ] menu-tab.
> 3. Open lookup of "Existing Content Id".
> 4. The content lookup will open.
> 5. Open the lookup of "Data Resource Id"
> Actual - RequestHandlerException
> Expected - The dataResource lookup should open.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9478) RequestHandlerException in dataResource loopkup.

2017-07-09 Thread Humera Khan (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Humera Khan updated OFBIZ-9478:
---
Attachment: OFBIZ-9478.patch

> RequestHandlerException in dataResource loopkup.
> 
>
> Key: OFBIZ-9478
> URL: https://issues.apache.org/jira/browse/OFBIZ-9478
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pallavi Goyal
>Priority: Minor
> Attachments: OFBIZ-9478.patch
>
>
> *Steps to regenerate - *
> 1. Go to "Facility" component.
> 2. Click on [ Content ] menu-tab.
> 3. Open lookup of "Existing Content Id".
> 4. The content lookup will open.
> 5. Open the lookup of "Data Resource Id"
> Actual - RequestHandlerException
> Expected - The dataResource lookup should open.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9478) RequestHandlerException in dataResource loopkup.

2017-07-09 Thread Pallavi Goyal (JIRA)
Pallavi Goyal created OFBIZ-9478:


 Summary: RequestHandlerException in dataResource loopkup.
 Key: OFBIZ-9478
 URL: https://issues.apache.org/jira/browse/OFBIZ-9478
 Project: OFBiz
  Issue Type: Bug
Reporter: Pallavi Goyal
Priority: Minor


*Steps to regenerate - *
1. Go to "Facility" component.
2. Click on [ Content ] menu-tab.
3. Open lookup of "Existing Content Id".
4. The content lookup will open.
5. Open the lookup of "Data Resource Id"

Actual - RequestHandlerException

Expected - The dataResource lookup should open.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong

2017-07-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079502#comment-16079502
 ] 

Deepak Dixit commented on OFBIZ-9185:
-

I think deleteWorkEffort service is not useful, as WorkEffort is very complex 
data model so instead of deleting workEffort it should be managed through 
status or from setting thruDate in assoc entities. 

There is no sense to keep delete workEffort service. 
Same apply for Party, Product, UserLogin etc.

> The deleteWorkEffort service is incomplete and even wrong
> -
>
> Key: OFBIZ-9185
> URL: https://issues.apache.org/jira/browse/OFBIZ-9185
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This issue is very old (pre Apache) so all versions are affected (I just 
> tested with R09.04)
> When you try to delete a Workeffort which has an established relationship 
> with a RuntimeData or any of the entities Workeffort has a relation with (eg 
> NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one 
> fails
> Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort, 
> would be to add
> {code}
>  relation-name="CustRequestWorkEffort"/>
> {code}
> Besides (minor) ApplicationSandbox is maybe missing in the implementation of 
> deleteWorkEffort.
> There is indeed a workeffortId in ApplicationSandbox.
> So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData.
> But it can anyway be deleted by a simple delete-by-and (or alike), so not a 
> problem for deleteWorkEffort, though this case could be handled there also.
> Summary: the deleteWorkEffort service  needs more work. The only solution I 
> see is to remove the FK from the Workeffort (ie put null in the related field 
> if it's not) and then deleted the related entity instead of directly calling 
> remove-related



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9403) DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted (refactored) code from getMimeType(...) method

2017-07-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079500#comment-16079500
 ] 

Deepak Dixit commented on OFBIZ-9403:
-

Hi Martin,

Why we are returning default mime type id in this methods?

I think it should not return default mime type, instead  it should return null 
so that at the calling end we can take decision accordingly  

> DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted 
> (refactored) code from getMimeType(...) method
> -
>
> Key: OFBIZ-9403
> URL: https://issues.apache.org/jira/browse/OFBIZ-9403
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9403_DataResourceWorker-getMimeType.patch
>
>
> The method DataResourceWorker.getMimeType(GenericValue) has been refactored 
> into two separate methods. The new additional method 
> getMimeTypeFromFileName(Delegator,Filename) solely focuses on getting the 
> MimeType from the file extension and is invoked by getMimeType(GenericValue) 
> if needed. getMimeType returns the type if possible via the data resource. 
> This results in cleaner code with the responsibility of both methods clearly 
> defined by the methods names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9477) UI issue in Lead Lookup on find opportunity

2017-07-09 Thread Jagpreet Kaur (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jagpreet Kaur updated OFBIZ-9477:
-
Description: 
Issue #1
1) Go to SFA component.
2) Click on Find Opportunity tab 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity]
3) In Find Opportunity section the open the "Lead Lookup"

Issue #2
The autocompleter of Lookup displays the wrong suggestions

  was:
Issue #1
1) Go to SFA component.
2) Click on Find Opportunity tab 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity]
3) In Find Opportunity section the open the "Lead Lookup"

Issue #2
The autocomplete with Lookup 


> UI issue in Lead Lookup on find opportunity
> ---
>
> Key: OFBIZ-9477
> URL: https://issues.apache.org/jira/browse/OFBIZ-9477
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Jagpreet Kaur
>
> Issue #1
> 1) Go to SFA component.
> 2) Click on Find Opportunity tab 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity]
> 3) In Find Opportunity section the open the "Lead Lookup"
> Issue #2
> The autocompleter of Lookup displays the wrong suggestions



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9477) UI issue in Lead Lookup on find opportunity

2017-07-09 Thread Jagpreet Kaur (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jagpreet Kaur updated OFBIZ-9477:
-
Description: 
Issue #1
1) Go to SFA component.
2) Click on Find Opportunity tab 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity]
3) In Find Opportunity section the open the "Lead Lookup"

Issue #2
The autocomplete with Lookup 

  was:
1) Go to SFA component.
2) Click on Find Opportunity tab 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity]
3) In Find Opportunity section the open the "Lead Lookup"


> UI issue in Lead Lookup on find opportunity
> ---
>
> Key: OFBIZ-9477
> URL: https://issues.apache.org/jira/browse/OFBIZ-9477
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Jagpreet Kaur
>
> Issue #1
> 1) Go to SFA component.
> 2) Click on Find Opportunity tab 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity]
> 3) In Find Opportunity section the open the "Lead Lookup"
> Issue #2
> The autocomplete with Lookup 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9477) UI issue in Lead Lookup on find opportunity

2017-07-09 Thread Jagpreet Kaur (JIRA)
Jagpreet Kaur created OFBIZ-9477:


 Summary: UI issue in Lead Lookup on find opportunity
 Key: OFBIZ-9477
 URL: https://issues.apache.org/jira/browse/OFBIZ-9477
 Project: OFBiz
  Issue Type: Bug
  Components: marketing
Reporter: Jagpreet Kaur


1) Go to SFA component.
2) Click on Find Opportunity tab 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity]
3) In Find Opportunity section the open the "Lead Lookup"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9477) UI issue in Lead Lookup on find opportunity

2017-07-09 Thread Jagpreet Kaur (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jagpreet Kaur updated OFBIZ-9477:
-
Description: 
Issue #1
1) Go to SFA component.
2) Click on Find Opportunity tab 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity]
3) In Find Opportunity section the open the "Lead Lookup"

Issue #2
The autocompleter of Lead displays the wrong suggestions

  was:
Issue #1
1) Go to SFA component.
2) Click on Find Opportunity tab 
[https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity]
3) In Find Opportunity section the open the "Lead Lookup"

Issue #2
The autocompleter of Lookup displays the wrong suggestions


> UI issue in Lead Lookup on find opportunity
> ---
>
> Key: OFBIZ-9477
> URL: https://issues.apache.org/jira/browse/OFBIZ-9477
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Jagpreet Kaur
> Attachments: screenshot-1.png
>
>
> Issue #1
> 1) Go to SFA component.
> 2) Click on Find Opportunity tab 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity]
> 3) In Find Opportunity section the open the "Lead Lookup"
> Issue #2
> The autocompleter of Lead displays the wrong suggestions



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9477) UI issue in Lead Lookup on find opportunity

2017-07-09 Thread Jagpreet Kaur (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jagpreet Kaur updated OFBIZ-9477:
-
Attachment: screenshot-1.png

> UI issue in Lead Lookup on find opportunity
> ---
>
> Key: OFBIZ-9477
> URL: https://issues.apache.org/jira/browse/OFBIZ-9477
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Jagpreet Kaur
> Attachments: screenshot-1.png
>
>
> Issue #1
> 1) Go to SFA component.
> 2) Click on Find Opportunity tab 
> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindSalesOpportunity]
> 3) In Find Opportunity section the open the "Lead Lookup"
> Issue #2
> The autocompleter of Lookup displays the wrong suggestions



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9476) UI issue in payment lookup.

2017-07-09 Thread Pallavi Goyal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pallavi Goyal updated OFBIZ-9476:
-
Attachment: payment-lookup-ui-issuepng

Attaching the screenshot of the UI issue.

> UI issue in payment lookup.
> ---
>
> Key: OFBIZ-9476
> URL: https://issues.apache.org/jira/browse/OFBIZ-9476
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: payment-lookup-ui-issuepng
>
>
> *Steps to regenerate -*
> 1. Go to "Accounting - AR" component.
> 2. Click on [ Invoices ] menu tab.
> 3. Open any invoice whose status is not "Paid" or "Ready for posting".
> 4. Click on [ Applications ] sub-menu tab.
> 5. Open the "Payment Lookup".
> Actual - The column headers of List Payments table are not in format and 
> therefore the list of payments is also not displayed.
> Expected - The columns should be in proper tabular format and the list should 
> be displayed upon find.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9476) UI issue in payment lookup.

2017-07-09 Thread Pallavi Goyal (JIRA)
Pallavi Goyal created OFBIZ-9476:


 Summary: UI issue in payment lookup.
 Key: OFBIZ-9476
 URL: https://issues.apache.org/jira/browse/OFBIZ-9476
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: Trunk
Reporter: Pallavi Goyal
Priority: Minor
 Fix For: Upcoming Release


*Steps to regenerate -*
1. Go to "Accounting - AR" component.
2. Click on [ Invoices ] menu tab.
3. Open any invoice whose status is not "Paid" or "Ready for posting".
4. Click on [ Applications ] sub-menu tab.
5. Open the "Payment Lookup".

Actual - The column headers of List Payments table are not in format and 
therefore the list of payments is also not displayed.

Expected - The columns should be in proper tabular format and the list should 
be displayed upon find.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9403) DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted (refactored) code from getMimeType(...) method

2017-07-09 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-9403:
---

Assignee: Deepak Dixit

> DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted 
> (refactored) code from getMimeType(...) method
> -
>
> Key: OFBIZ-9403
> URL: https://issues.apache.org/jira/browse/OFBIZ-9403
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Trunk
>Reporter: Martin Becker
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9403_DataResourceWorker-getMimeType.patch
>
>
> The method DataResourceWorker.getMimeType(GenericValue) has been refactored 
> into two separate methods. The new additional method 
> getMimeTypeFromFileName(Delegator,Filename) solely focuses on getting the 
> MimeType from the file extension and is invoked by getMimeType(GenericValue) 
> if needed. getMimeType returns the type if possible via the data resource. 
> This results in cleaner code with the responsibility of both methods clearly 
> defined by the methods names.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-8831) Typo in error message when OFBiz is unable to connect to database.

2017-07-09 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-8831.
---
   Resolution: Implemented
Fix Version/s: (was: Trunk)
   Upcoming Release

> Typo in error message when OFBiz is unable to connect to database.
> --
>
> Key: OFBIZ-8831
> URL: https://issues.apache.org/jira/browse/OFBIZ-8831
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Humera Khan
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-8831.patch
>
>
> Steps to regenerate : 
> 1. Go to entityengine.xml file of framework component.
> 2. Change the name of the database in entityengine.xml to random which does 
> not exists in your database.
> 3. Restart the OFBiz and check the error message on console.
> 4.It shows "Unable to esablish connection to database".
> Expected : It should show "Unable to establish connection to database".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8831) Typo in error message when OFBiz is unable to connect to database.

2017-07-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079490#comment-16079490
 ] 

Deepak Dixit commented on OFBIZ-8831:
-

This has been already fixed at r#1768808

> Typo in error message when OFBiz is unable to connect to database.
> --
>
> Key: OFBIZ-8831
> URL: https://issues.apache.org/jira/browse/OFBIZ-8831
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Humera Khan
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-8831.patch
>
>
> Steps to regenerate : 
> 1. Go to entityengine.xml file of framework component.
> 2. Change the name of the database in entityengine.xml to random which does 
> not exists in your database.
> 3. Restart the OFBiz and check the error message on console.
> 4.It shows "Unable to esablish connection to database".
> Expected : It should show "Unable to establish connection to database".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-9254) Inconsistent String Comparisons

2017-07-09 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079101#comment-16079101
 ] 

Arun Patidar edited comment on OFBIZ-9254 at 7/9/17 6:53 AM:
-

OFBIZ-9254_FTL-I.patch :- Committed revision 1801268
OFBIZ-9254_ftl_themes.patch :- Committed revision 1801278
OFBIZ-9254_ftl_product.patch: -Committed revision 1801280
OFBIZ-9254_ftl_plugins_pricat_projmgr.patch: Committed revision 1801282
OFBIZ-9254_ftl_plugins_ecommerce.patch:Committed revision 1801284




was (Author: arunpati):
OFBIZ-9254_FTL-I.patch :- Committed revision 1801268
OFBIZ-9254_ftl_themes.patch :- Committed revision 1801278
OFBIZ-9254_ftl_product.patch: -Committed revision 1801280


> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9251_ftl_accounting.patch, 
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch, 
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch, 
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch, 
> OFBIZ-9251_ftl_plugins_ecommerce.patch, 
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch, 
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254_FTL-I.patch, 
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch, 
> OFBIZ-9254_java_accounting.patch, OFBIZ-9254_java_base.patch, 
> OFBIZ-9254_java_content.patch, OFBIZ-9254_java_entity.patch, 
> OFBIZ-9254_java_order.patch, OFBIZ-9254_java_Party_WE_MFC.patch, 
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch, 
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch, 
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch, 
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins_groovy.patch, 
> OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison 
> statusId.equals("PRUN_COMPLETED") whereas it should be written as 
> "PRUN_COMPLETED".equals(statusId) 
> cause the former can throw NullPointerException if the variable found to be 
> NULL.
> This pattern should be applied to 
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-8831) Typo in error message when OFBiz is unable to connect to database.

2017-07-09 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-8831:
---

Assignee: Deepak Dixit  (was: Pritam Kute)

> Typo in error message when OFBiz is unable to connect to database.
> --
>
> Key: OFBIZ-8831
> URL: https://issues.apache.org/jira/browse/OFBIZ-8831
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Humera Khan
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-8831.patch
>
>
> Steps to regenerate : 
> 1. Go to entityengine.xml file of framework component.
> 2. Change the name of the database in entityengine.xml to random which does 
> not exists in your database.
> 3. Restart the OFBiz and check the error message on console.
> 4.It shows "Unable to esablish connection to database".
> Expected : It should show "Unable to establish connection to database".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9317) WorkEffort shows error on adding party with specific role to Timesheet.

2017-07-09 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-9317.
---
   Resolution: Fixed
Fix Version/s: Upcoming Release

Committed revision 1801350.

Thanks Jagpreet for your contribution.

> WorkEffort shows error on adding party with specific role to Timesheet. 
> 
>
> Key: OFBIZ-9317
> URL: https://issues.apache.org/jira/browse/OFBIZ-9317
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Reporter: Jagpreet Kaur
>Assignee: Arun Patidar
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9317.patch, screenshot-1.png
>
>
> 1) Go to WorkEffort component.
> 2) Click on Timesheet tab 
> [https://localhost:8443/workeffort/control/FindTimesheet].
> 3) Click on Find button.
> 4) Choose any timesheet 
> [https://localhost:8443/workeffort/control/EditTimesheet?timesheetId=1]
> 5) Click on Parties Tab 
> [https://localhost:8443/workeffort/control/EditTimesheetRoles?timesheetId=1]
> 6) Choose any party from look up and click on Add.
> 7) Error will be displayed on screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-8849) Search operation on 'OrderReportPurchasesGroupByProduct' entity causing exception.

2017-07-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079488#comment-16079488
 ] 

Deepak Dixit commented on OFBIZ-8849:
-

Hi Pallavi,

Its not good idea to set group-by true for all fields. 
This entity is used to generate Purchases by Organization Report from 
[OrderPurchaseReportOptions|https://localhost:8443/ordermgr/control/OrderPurchaseReportOptions]
 and its working properly. 

> Search operation on 'OrderReportPurchasesGroupByProduct' entity causing 
> exception.
> --
>
> Key: OFBIZ-8849
> URL: https://issues.apache.org/jira/browse/OFBIZ-8849
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pallavi Goyal
> Fix For: Trunk
>
> Attachments: OFBIZ-8849.patch, OrderReport_Actual.png, 
> OrderReport_Expected.png
>
>
> Steps to regenerate : 
> 1. Go to Entity Data Maintenance in webtools.
> 2. Search entity 'OrderReportPurchasesGroupByProduct'. Click on it and go to 
> the overview page.
> 3. Click on the Find button.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9317) WorkEffort shows error on adding party with specific role to Timesheet.

2017-07-09 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9317:
---

Assignee: Arun Patidar

> WorkEffort shows error on adding party with specific role to Timesheet. 
> 
>
> Key: OFBIZ-9317
> URL: https://issues.apache.org/jira/browse/OFBIZ-9317
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Reporter: Jagpreet Kaur
>Assignee: Arun Patidar
> Attachments: OFBIZ-9317.patch, screenshot-1.png
>
>
> 1) Go to WorkEffort component.
> 2) Click on Timesheet tab 
> [https://localhost:8443/workeffort/control/FindTimesheet].
> 3) Click on Find button.
> 4) Choose any timesheet 
> [https://localhost:8443/workeffort/control/EditTimesheet?timesheetId=1]
> 5) Click on Parties Tab 
> [https://localhost:8443/workeffort/control/EditTimesheetRoles?timesheetId=1]
> 6) Choose any party from look up and click on Add.
> 7) Error will be displayed on screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9316) Error displayed while adding WorkEffort Contact Mechs.

2017-07-09 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-9316.
---
   Resolution: Fixed
Fix Version/s: Upcoming Release

Committed revision 1801349.

Modified patch. Returned error message from service if both contactMechId and 
ContactMechTypeId are empty.

Thanks Jagpreet for your contribution.

> Error displayed while adding WorkEffort Contact Mechs.
> --
>
> Key: OFBIZ-9316
> URL: https://issues.apache.org/jira/browse/OFBIZ-9316
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Reporter: Jagpreet Kaur
>Assignee: Arun Patidar
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9316.patch, screenshot-1.png
>
>
> 1) Go to workEffort component.
> 2) Navigate to Task List tab. 
> [https://localhost:8443/workeffort/control/mytasks]
> 3) Select any task from the list.
> 4) Navigate to Contact Mechs tab and try to add any contact mech id after 
> choosing from look up.
> 5) Error will be displayed on screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9475) Refactor serialize and non-serialize inventory item implementaion

2017-07-09 Thread Renuka Srishti (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti reassigned OFBIZ-9475:
-

Assignee: Renuka Srishti

> Refactor serialize and non-serialize inventory item implementaion
> -
>
> Key: OFBIZ-9475
> URL: https://issues.apache.org/jira/browse/OFBIZ-9475
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Deepak Dixit
>Assignee: Renuka Srishti
>
> As discussed on dev mailing list [1][2] we need to refactor serialize and 
> non-serialize inventory item design.
> As per current implementation serialize inventory item work on status and 
> non-serialized inventory item work on inventory item detail.
> Proposed Design:
> - Use inventory item detail for both serialize and non-serialize inventory 
> item. Only one additional condition for serialized inventory item that qoh 
> can't be greater then one.
> - We can maintain inventory item status record for both type
> [1] http://markmail.org/thread/bd2bpiv6c5wvl7km
> [2] http://ofbiz.markmail.org/thread/kro5kcggp4fcose7



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9358) Integrating google phone number library for validating telecom numbers

2017-07-09 Thread Renuka Srishti (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Renuka Srishti updated OFBIZ-9358:
--
Attachment: OFBIZ-9358.patch

Add one more point to the available patch:
Use @Deprecated annotation to deprecate isUSPhoneNumber, isUSPhoneAreaCode, 
isUSPhoneMainNumber and isInternationalPhoneNumber methods of class 
UtilValidate.

> Integrating google phone number library for validating telecom numbers
> --
>
> Key: OFBIZ-9358
> URL: https://issues.apache.org/jira/browse/OFBIZ-9358
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Release
>Reporter: Suraj Khurana
>Assignee: Renuka Srishti
> Attachments: OFBIZ-9358.patch, OFBIZ-9358.patch
>
>
> As per discussion at 
> https://lists.apache.org/list.html?d...@ofbiz.apache.org:lte=1M:Validating%20telecom%20numbers
> Need to integrate Google telephone number to validate telephone numbers 
> formats of various countries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9111) Service "deletePayHistory" does not have correct implementation

2017-07-09 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-9111.
---
   Resolution: Done
Fix Version/s: Upcoming Release

This has been done at ofbiz framework at r#1801348
Thanks Pawan Vemra for your contribution.

> Service "deletePayHistory" does not have correct implementation
> ---
>
> Key: OFBIZ-9111
> URL: https://issues.apache.org/jira/browse/OFBIZ-9111
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9111.patch, OFBIZ-9111.patch
>
>
> Service "deletePayHistory" does not have correct implementation.This service 
> set thru_date then remove record of PayHistory.This should be corrected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9111) Service "deletePayHistory" does not have correct implementation

2017-07-09 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-9111:

Issue Type: Improvement  (was: Bug)

> Service "deletePayHistory" does not have correct implementation
> ---
>
> Key: OFBIZ-9111
> URL: https://issues.apache.org/jira/browse/OFBIZ-9111
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9111.patch, OFBIZ-9111.patch
>
>
> Service "deletePayHistory" does not have correct implementation.This service 
> set thru_date then remove record of PayHistory.This should be corrected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9111) Service "deletePayHistory" does not have correct implementation

2017-07-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079465#comment-16079465
 ] 

Deepak Dixit commented on OFBIZ-9111:
-

I think instead of delete it should call expirePayHistory. 

> Service "deletePayHistory" does not have correct implementation
> ---
>
> Key: OFBIZ-9111
> URL: https://issues.apache.org/jira/browse/OFBIZ-9111
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-9111.patch, OFBIZ-9111.patch
>
>
> Service "deletePayHistory" does not have correct implementation.This service 
> set thru_date then remove record of PayHistory.This should be corrected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)