[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115171#comment-16115171
]
Wai commented on OFBIZ-9351:
Now that "id-ne", "id-long-ne" and "id-vlong-ne" has been modified with "id",
"id-long" and "id-vlong" respectively.
How does this affect an existing database with production data?
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch,
> OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9550) Manage life span of marketing related entites
[ https://issues.apache.org/jira/browse/OFBIZ-9550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114884#comment-16114884 ] Nicolas Malin commented on OFBIZ-9550: -- Hello Suraj, Thanks for your submission. I have a doubt about remove directly some service definition with deprecated procedure. I will open a thread on mailing list to have some suggest how to manage it. > Manage life span of marketing related entites > - > > Key: OFBIZ-9550 > URL: https://issues.apache.org/jira/browse/OFBIZ-9550 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Reporter: Suraj Khurana >Assignee: Suraj Khurana > Attachments: OFBIZ-9550.patch > > > Found few entities related to marketing component that should maintain life > span of data. Here is the list: > 1) MarketingCampaignPrice > 2) MarketingCampaignPromo > 3) MarketingCampaignRole > Will add more if found. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9549) Refactor EntityListIterator
[
https://issues.apache.org/jira/browse/OFBIZ-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114845#comment-16114845
]
Jacques Le Roux commented on OFBIZ-9549:
Hi Tobias,
I reviewed your patch, I globally like it. I have few questions and opinions.
# Why do you prefer a return to an else in close() (I see why in absolute() and
hasNext()) ?
# Please explain
{code}
if (rowNum == 0 && resultSet.getType() != ResultSet.TYPE_FORWARD_ONLY) {
{code}
# While at it I'd prefer this formatting for this note
{code}
* PLEASE NOTE: Because of the nature of the JDBC ResultSet interface this
method can be very inefficient
* It is much better to just use next() until it returns null
* For example, you could use the following to iterate through the results
in an EntityListIterator:
{code}
Same in hasPrevious()
# I'd keep the comment
{code}
// do a quick game to see if the resultSet is empty:
// if we are not in the last or afterLast positions and we
haven't made any values yet, the result set is empty so return false
{code}
in hasPrevious()
# Why did you prefer an ArrayList vs a LinkedList in getCompleteList() and
getPartialList(). Did you make some performance reviews using a profiler?
Thanks!
> Refactor EntityListIterator
> ---
>
> Key: OFBIZ-9549
> URL: https://issues.apache.org/jira/browse/OFBIZ-9549
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Tobias Laufkötter
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-9549.patch
>
>
> The EntityListIterator contains duplicate code and has need for refactoring
> in general.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9542) Can't Create a new PartyAcctgPreference in 16.11.03
[ https://issues.apache.org/jira/browse/OFBIZ-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114585#comment-16114585 ] Sharan Foga commented on OFBIZ-9542: Thanks very much Deepak for the fix! I've tested it and it is now working fine. > Can't Create a new PartyAcctgPreference in 16.11.03 > --- > > Key: OFBIZ-9542 > URL: https://issues.apache.org/jira/browse/OFBIZ-9542 > Project: OFBiz > Issue Type: Bug >Affects Versions: 16.11.03 >Reporter: Sharan Foga >Assignee: Deepak Dixit >Priority: Minor > Fix For: 16.11.04 > > Attachments: 13.07-create-acctg-co.png, 16.11-create-acctg-co.png > > > Hi > I was running through some tests on a clean OFBiz 16.11.03 install loaded > with only the seed and seed-initial data and it will not display the screen > to create a new PartyAcctgPreference.. > In the past (version 13.07) it definitely used to work but in 16.11.03 I > can't get it to work. This setup is important because creating a new > PartyAcctgPreference is the first step needed to manage the accounting setup > for a new party. Initially I thought it was missing data setup or permissions > but I've run through the data and security groups and couldn't find anything > missing. > I've gone through the exact same steps using 13.07.03 and 16.11.03 and it > works in 13.07 but not in 16.11 > The steps to reproduce are below: > 1. Install seed and seed initial (./gradlew "ofbiz ââload-data > readers=seed,seed-initial") > 2. Load the admin user (loadAdminUserLogin -PuserLoginId=admin) > 3. Login to Party Manager and create a new party group (eg MyTestCompany) and > add the role Internal Organisation > 4. Go to Accounting / Organisation GL Settings / Create new accounting > company > The new party (with the internal organisation role) appears in the dropdown > selection box but when you select it and click the "Create new accounting > company" button the screen stays blank. > It should display the Party accounting preferences setup screen in add mode > and allow you to enter the accounting details such as the Fiscal Year Start > and Month, GL Journal or Invoice Sequencing) etc. > I will attach copies of the screenshots from my tests > Thanks -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9552) Unable to change facility Id in Facility lookup under Inventory Transfer section
Renuka Srishti created OFBIZ-9552: - Summary: Unable to change facility Id in Facility lookup under Inventory Transfer section Key: OFBIZ-9552 URL: https://issues.apache.org/jira/browse/OFBIZ-9552 Project: OFBiz Issue Type: Bug Affects Versions: Trunk Reporter: Renuka Srishti 1. Go to Facility component. 2. Select facility Id and click on submit button. 3. Here you can see "InventoryXfers" label, click on it. 4. Now you will redirect to [https://demo-trunk.ofbiz.apache.org/facility/control/FindFacilityTransfers?facilityId=WebStoreWarehouse] 5. Click on "Inventory Transfer" button. You will redirect to [https://demo-trunk.ofbiz.apache.org/facility/control/TransferInventoryItem?facilityId=WebStoreWarehouse] 6. Here enter inventory item id in the input box which is labeled as inventory item id and press enter. 7. Now you will "Inventory Transfer" section. Here click on "To Location" look up. First time look up will show "facility Id" label and if you want to change the facility Id, after one-time search you can't change it. You need to reopen the look up. The proposed solution: Facility Id label should remain there after clicking on Find button in Facility Lookup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service
[ https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-9551: - Attachment: OFBIZ-9551.patch Here is the patch with proper improvement. Please have a look, also remove CampaignServices.xml file while applying the patch, as it is of now use now. > Convert createMarketingCampaignRole service to entity-auto service > -- > > Key: OFBIZ-9551 > URL: https://issues.apache.org/jira/browse/OFBIZ-9551 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana > Attachments: OFBIZ-9551.patch > > > Currently, this service is having some permission related code at > CampaignServices.xml which is of no use and can be deleted, we can move that > code to a separate permission check service that can be used elsewhere as > well. > Also, this pattern is currently used in other areas like Party etc -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service
[ https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9551: - Issue Type: Sub-task (was: Improvement) Parent: OFBIZ-8408 > Convert createMarketingCampaignRole service to entity-auto service > -- > > Key: OFBIZ-9551 > URL: https://issues.apache.org/jira/browse/OFBIZ-9551 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana > > Currently, this service is having some permission related code at > CampaignServices.xml which is of no use and can be deleted, we can move that > code to a separate permission check service that can be used elsewhere as > well. > Also, this pattern is currently used in other areas like Party etc -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service
[ https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9551: - Affects Version/s: Trunk > Convert createMarketingCampaignRole service to entity-auto service > -- > > Key: OFBIZ-9551 > URL: https://issues.apache.org/jira/browse/OFBIZ-9551 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana > > Currently, this service is having some permission related code at > CampaignServices.xml which is of no use and can be deleted, we can move that > code to a separate permission check service that can be used elsewhere as > well. > Also, this pattern is currently used in other areas like Party etc -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service
Suraj Khurana created OFBIZ-9551: Summary: Convert createMarketingCampaignRole service to entity-auto service Key: OFBIZ-9551 URL: https://issues.apache.org/jira/browse/OFBIZ-9551 Project: OFBiz Issue Type: Improvement Components: marketing Reporter: Suraj Khurana Assignee: Suraj Khurana Currently, this service is having some permission related code at CampaignServices.xml which is of no use and can be deleted, we can move that code to a separate permission check service that can be used elsewhere as well. Also, this pattern is currently used in other areas like Party etc -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-9138: - Attachment: common-theme-macro.svg common-theme-screen.svg I uploaded two diagrams that try to explain how the theme system now work to resolve the ftl macro library and decorator screen. I hope it would be more easier with them to understand the code change realized. > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9550) Manage life span of marketing related entites
[ https://issues.apache.org/jira/browse/OFBIZ-9550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-9550: - Attachment: OFBIZ-9550.patch Here is the patch with the proper fix. Also added crud service for these entities as well. > Manage life span of marketing related entites > - > > Key: OFBIZ-9550 > URL: https://issues.apache.org/jira/browse/OFBIZ-9550 > Project: OFBiz > Issue Type: Improvement > Components: marketing >Reporter: Suraj Khurana >Assignee: Suraj Khurana > Attachments: OFBIZ-9550.patch > > > Found few entities related to marketing component that should maintain life > span of data. Here is the list: > 1) MarketingCampaignPrice > 2) MarketingCampaignPromo > 3) MarketingCampaignRole > Will add more if found. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9550) Manage life span of marketing related entites
Suraj Khurana created OFBIZ-9550: Summary: Manage life span of marketing related entites Key: OFBIZ-9550 URL: https://issues.apache.org/jira/browse/OFBIZ-9550 Project: OFBiz Issue Type: Improvement Components: marketing Reporter: Suraj Khurana Assignee: Suraj Khurana Found few entities related to marketing component that should maintain life span of data. Here is the list: 1) MarketingCampaignPrice 2) MarketingCampaignPromo 3) MarketingCampaignRole Will add more if found. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114080#comment-16114080 ] Taher Alkhateeb commented on OFBIZ-9441: Thank you for your help, I'll wait for your review before committing. It's good to have a fresh pair of eyes. > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114065#comment-16114065 ] Jacques Le Roux commented on OFBIZ-9441: 1st, I like the README.md rewriting, I'll continue later... > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9549) Refactor EntityListIterator
[ https://issues.apache.org/jira/browse/OFBIZ-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9549: -- Assignee: Jacques Le Roux > Refactor EntityListIterator > --- > > Key: OFBIZ-9549 > URL: https://issues.apache.org/jira/browse/OFBIZ-9549 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Tobias Laufkötter >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-9549.patch > > > The EntityListIterator contains duplicate code and has need for refactoring > in general. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114050#comment-16114050 ] Jacques Le Roux commented on OFBIZ-9441: Oops, got it now, one name is not right. It should not be OFBIZ-9411.patch ;) OK remains the last question :) > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114052#comment-16114052 ] Jacques Le Roux commented on OFBIZ-9441: Ah we crossed on wire, good to know, thanks! > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114047#comment-16114047 ] Taher Alkhateeb commented on OFBIZ-9441: Ignore all the patches, they are for illustration only. the latest patch does everything > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114045#comment-16114045 ] Jacques Le Roux commented on OFBIZ-9441: HI Taher, I remember now, what refrained me to review is that it's not clear which is the last patch version. I understand there are 2 different patches # OFBIZ-9411.patch # OFBIZ-9441-fix-continue-on-failure.patch And that the last OFBIZ-9411.patch is from 21/Jul/17 16:14. But patches are weirdly grayed so I'm (a bit) unsure and especially I'd like to understand why it's so. Also is now the OFBIZ-9441-fix-continue-on-failure.patch included in the last OFBIZ-9411.patch? Thanks! > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9549) Refactor EntityListIterator
[ https://issues.apache.org/jira/browse/OFBIZ-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Laufkötter updated OFBIZ-9549: - Attachment: OFBIZ-9549.patch > Refactor EntityListIterator > --- > > Key: OFBIZ-9549 > URL: https://issues.apache.org/jira/browse/OFBIZ-9549 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Tobias Laufkötter >Priority: Minor > Attachments: OFBIZ-9549.patch > > > The EntityListIterator contains duplicate code and has need for refactoring > in general. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9549) Refactor EntityListIterator
Tobias Laufkötter created OFBIZ-9549: Summary: Refactor EntityListIterator Key: OFBIZ-9549 URL: https://issues.apache.org/jira/browse/OFBIZ-9549 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Tobias Laufkötter Priority: Minor The EntityListIterator contains duplicate code and has need for refactoring in general. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114018#comment-16114018
]
Jacques Le Roux commented on OFBIZ-9351:
Good catch, thanks Aditya.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch,
> OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
