[jira] [Assigned] (OFBIZ-9747) Error while updating Agreement

2017-09-22 Thread Padmavati Rawat (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Padmavati Rawat reassigned OFBIZ-9747:
--

Assignee: (was: Padmavati Rawat)

> Error while updating Agreement 
> ---
>
> Key: OFBIZ-9747
> URL: https://issues.apache.org/jira/browse/OFBIZ-9747
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/updateAgreement
>Reporter: Padmavati Rawat
>
> Steps:
> 1. Search any existing Agreement.
> 2. Click on the update button.
> 3. Try to change the Role Type Id From, Role Type Id To and Agreement Type Id.
> 4. Click on submit button.
> Actual:
> Error displayed on the screen on clicking submit button.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9746) updateContentAssoc does not return success/error message to the UI.

2017-09-22 Thread Rohit Rai (JIRA)
Rohit Rai created OFBIZ-9746:


 Summary: updateContentAssoc does not return success/error message 
to the UI.
 Key: OFBIZ-9746
 URL: https://issues.apache.org/jira/browse/OFBIZ-9746
 Project: OFBiz
  Issue Type: Bug
  Components: content
Reporter: Rohit Rai


1. Go to, Content.
2. Find contents using the find form and select any content from the list./
3. Click on the submenu "Association"
4. In the Edit content association section, select a through date and click on 
update

The date gets updated but the user is not presented with the success message on 
the UI.
Here is the link to the form,
https://demo-trunk.ofbiz.apache.org/content/control/updateContentAssoc



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9698) Party Id field missing while creating contact list party in the marketing component

2017-09-22 Thread Padmavati Rawat (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Padmavati Rawat updated OFBIZ-9698:
---
Attachment: ErroronAgreement.png

> Party Id field missing while creating contact list party in the marketing 
> component
> ---
>
> Key: OFBIZ-9698
> URL: https://issues.apache.org/jira/browse/OFBIZ-9698
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Reporter: Rubia Elza Joshep
>Assignee: Garima jain
> Attachments: ErroronAgreement.png, screenshot-1.png
>
>
> Steps to regenerate-
> 1) Open URL 
> https://demo-trunk.ofbiz.apache.org/marketing/control/FindContactListParties?contactListId=1=Y
> 2) Navigate to the Marketing component and select contact list menu.
> 3) After creating a contact list menu, select the sub menu parties.
> 4) Click on Create New contact list party and click on Save button.
> Actual: Party Id field is missing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9747) Error while updating Agreement

2017-09-22 Thread Padmavati Rawat (JIRA)
Padmavati Rawat created OFBIZ-9747:
--

 Summary: Error while updating Agreement 
 Key: OFBIZ-9747
 URL: https://issues.apache.org/jira/browse/OFBIZ-9747
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
 Environment: 
https://demo-trunk.ofbiz.apache.org/accounting/control/updateAgreement
Reporter: Padmavati Rawat
Assignee: Padmavati Rawat


Steps:
1. Search any existing Agreement.
2. Click on the update button.
3. Try to change the Role Type Id From, Role Type Id To and Agreement Type Id.
4. Click on submit button.

Actual:
Error displayed on the screen on clicking submit button.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9746) updateContentAssoc does not return success/error message to the UI.

2017-09-22 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai reassigned OFBIZ-9746:


Assignee: Rohit Rai

> updateContentAssoc does not return success/error message to the UI.
> ---
>
> Key: OFBIZ-9746
> URL: https://issues.apache.org/jira/browse/OFBIZ-9746
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
>
> 1. Go to, Content.
> 2. Find contents using the find form and select any content from the list./
> 3. Click on the submenu "Association"
> 4. In the Edit content association section, select a through date and click 
> on update
> The date gets updated but the user is not presented with the success message 
> on the UI.
> Here is the link to the form,
> https://demo-trunk.ofbiz.apache.org/content/control/updateContentAssoc



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9696) Fix type entities to follow convention of hasTable

2017-09-22 Thread Aman Agrawal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Agrawal updated OFBIZ-9696:

Attachment: OFBIZ-9696.patch

Patch available for ShipmentGatewayConfigType entity.
In this changed the type field like:
"FEDEX" -> "SHIP_GATEWAY_FEDEX"
and also made changes in ShipmentGatewayConfig entity.

> Fix type entities to follow convention of hasTable
> --
>
> Key: OFBIZ-9696
> URL: https://issues.apache.org/jira/browse/OFBIZ-9696
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
> Attachments: OFBIZ-9696.patch
>
>
> 'hasTable' field of 'Type' entities is used to give an idea that detail 
> entity exists or not. We generally get the name of detail entity on the basis 
> of typeId field value. 
> For example : 
> ContactMechType,contactMechTypeId = "POSTAL_ADDRESS"  then we go to 
> PostalAddress for detail.
> similarly,
> ContactMechType,contactMechTypeId = "TELECOM_NUMBER"  then we go to 
> TelecomNumber for detail.
> We should follow the naming convention.
> Below are some entities that are not following the pattern. Some of them are:
>- ShipmentGatewayConfigType
>- PaymentGatewayConfigType



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9680) No option to add Event Purpose on Events page.

2017-09-22 Thread Lalit Dashora (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora reassigned OFBIZ-9680:


Assignee: Lalit Dashora

> No option to add Event Purpose on Events page.
> --
>
> Key: OFBIZ-9680
> URL: https://issues.apache.org/jira/browse/OFBIZ-9680
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Sonal Patwari
>Assignee: Lalit Dashora
>
> Navigate to SFA component > Events > Create Event.
> - While creating an event, there is no option to enter purpose.
> - On Events screen there is 'Purpose' field in the table which remains empty 
> as there is no option for adding it.
> Here are the helpful links :
> - [Events Page|https://demo-stable.ofbiz.apache.org/sfa/control/Events]
> - [Create Event|https://demo-stable.ofbiz.apache.org/sfa/control/EditEvent]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9745) Labels messed up because of missing UiLabels

2017-09-22 Thread Ankit Joshi (JIRA)
Ankit Joshi created OFBIZ-9745:
--

 Summary: Labels messed up because of missing UiLabels
 Key: OFBIZ-9745
 URL: https://issues.apache.org/jira/browse/OFBIZ-9745
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Ankit Joshi
Assignee: Ankit Joshi
Priority: Minor


1) Navigate to SFA and search for contacts.
2) Move to Contact Profile detail screen.
3) Try following processes with UserLogin 
  i) Create / Update  User Login.
  ii) Assign / Edit Security Group to the User Login.

Result: Several UX labels messed up because of missing UiLabels.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9744) Inventory count is not updating correctly.

2017-09-22 Thread Tejas Khanna (JIRA)
Tejas Khanna created OFBIZ-9744:
---

 Summary: Inventory count is not updating correctly.
 Key: OFBIZ-9744
 URL: https://issues.apache.org/jira/browse/OFBIZ-9744
 Project: OFBiz
  Issue Type: Bug
  Components: hhfacility
 Environment: 
https://demo-trunk.ofbiz.apache.org/accounting/control/InventoryValuation
Reporter: Tejas Khanna


Steps to reproduce:
1. Place purchase order with some quantities.
2. Receive and complete the invoice of purchase order.
3. Check the Inventory count and its respective valuation in Inventory 
Valuation report.

Actual Behavior:
Inventory count is not updating in Inventory Valuation Report.

Expected result:
Inventory count should update in report. Also, the valuation should get change.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9358) Integrating google phone number library for validating telecom numbers

2017-09-22 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9358:
---

Assignee: Arun Patidar  (was: Renuka Srishti)

> Integrating google phone number library for validating telecom numbers
> --
>
> Key: OFBIZ-9358
> URL: https://issues.apache.org/jira/browse/OFBIZ-9358
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Release
>Reporter: Suraj Khurana
>Assignee: Arun Patidar
> Attachments: OFBIZ-9358.patch, OFBIZ-9358.patch, OFBIZ-9358.patch
>
>
> As per discussion at 
> https://lists.apache.org/list.html?d...@ofbiz.apache.org:lte=1M:Validating%20telecom%20numbers
> Need to integrate Google telephone number to validate telephone numbers 
> formats of various countries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9643) Improvements in Find Invoice and Find Payment screen

2017-09-22 Thread Ayushi Rathod (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ayushi Rathod reassigned OFBIZ-9643:


Assignee: Ayushi Rathod

> Improvements in Find Invoice and Find Payment screen
> 
>
> Key: OFBIZ-9643
> URL: https://issues.apache.org/jira/browse/OFBIZ-9643
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Renuka Srishti
>Assignee: Ayushi Rathod
>Priority: Minor
>
> Go to [https://demo-trunk.ofbiz.apache.org/accounting/control/main]
> Here you can see two headings under Accounting Manager Main Page:
> * Invoice
> * Payments
> For example:
> If you want to search invoices with approved status, you will click on *Show 
> Invoice Approved*
> and it will redirect you to  
> [https://demo-trunk.ofbiz.apache.org/accounting/control/findInvoices?lookupFlag=Y=INVOICE_APPROVED]
> Here you can see all approved invoices, but the status check box is not 
> selected. Check box should be selected for chosen search criteria.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9743) updateContent service does not return an error/success message

2017-09-22 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai reassigned OFBIZ-9743:


Assignee: Rohit Rai

> updateContent service does not return an error/success message 
> ---
>
> Key: OFBIZ-9743
> URL: https://issues.apache.org/jira/browse/OFBIZ-9743
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
>
> 1. Go to Content,
> 2. Click on Find in the search options to get a list of all the contents in 
> the system.
> 3. Select a content from the list of content.
> 4. Edit Content form should get opened.
> 5. Click on update, the user is not presented with success or error message 
> on the screen.
> Although, the service works and the content gets updated.
> Here is a link to the issue,
> https://demo-trunk.ofbiz.apache.org/content/control/editContent?contentId=TEMPLATE_MASTER



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9743) updateContent service does not return an error/success message

2017-09-22 Thread Rohit Rai (JIRA)
Rohit Rai created OFBIZ-9743:


 Summary: updateContent service does not return an error/success 
message 
 Key: OFBIZ-9743
 URL: https://issues.apache.org/jira/browse/OFBIZ-9743
 Project: OFBiz
  Issue Type: Bug
  Components: content
Reporter: Rohit Rai


1. Go to Content,
2. Click on Find in the search options to get a list of all the contents in the 
system.
3. Select a content from the list of content.
4. Edit Content form should get opened.
5. Click on update, the user is not presented with success or error message on 
the screen.
Although, the service works and the content gets updated.

Here is a link to the issue,
https://demo-trunk.ofbiz.apache.org/content/control/editContent?contentId=TEMPLATE_MASTER



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-7253) UI issue on web pos for different themes

2017-09-22 Thread Yogesh Naroliya (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yogesh Naroliya reassigned OFBIZ-7253:
--

Assignee: (was: Yogesh Naroliya)

> UI issue on web pos for different themes
> 
>
> Key: OFBIZ-7253
> URL: https://issues.apache.org/jira/browse/OFBIZ-7253
> Project: OFBiz
>  Issue Type: Bug
>  Components: webpos
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Anurag Chandak
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-7253-Trunk.patch, WebPos-BlueLight-Theme.png, 
> WebPos-FlatGray-Theme.png
>
>
> Steps to regenerate:
> - Go to web pos
> - Do login with any terminal
> - UI of "Cart", "Browse Categories" and "Products from this category" 
> screenlets are not proper.
> NOTE: This issue is found on the Flat Grey theme.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-7253) UI issue on web pos for different themes

2017-09-22 Thread Yogesh Naroliya (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yogesh Naroliya updated OFBIZ-7253:
---
Attachment: WebPos-BlueLight-Theme.png
WebPos-FlatGray-Theme.png
OFBIZ-7253-Trunk.patch

Hi [~anurag.chan...@hotwaxsystems.com], Thanks for reporting the issue.

While working on this issue, I found that the issue already persists in 
BlueLight theme.

I am providing the patch created from trunk for proper rendering of "Cart", 
"Browse Categories" and "Products from this category" sections.
FYI: I have verified that changes are working fine for all themes.

The attached screenshots has been taken after applying patch on local instance.

> UI issue on web pos for different themes
> 
>
> Key: OFBIZ-7253
> URL: https://issues.apache.org/jira/browse/OFBIZ-7253
> Project: OFBiz
>  Issue Type: Bug
>  Components: webpos
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Anurag Chandak
>Assignee: Yogesh Naroliya
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-7253-Trunk.patch, WebPos-BlueLight-Theme.png, 
> WebPos-FlatGray-Theme.png
>
>
> Steps to regenerate:
> - Go to web pos
> - Do login with any terminal
> - UI of "Cart", "Browse Categories" and "Products from this category" 
> screenlets are not proper.
> NOTE: This issue is found on the Flat Grey theme.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9739) Required field indicator (*) is missing from the required field on create website form

2017-09-22 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-9739:
-

Assignee: Akash Jain  (was: Rohit Rai)

> Required field indicator (*) is missing from the required field on create 
> website form
> --
>
> Key: OFBIZ-9739
> URL: https://issues.apache.org/jira/browse/OFBIZ-9739
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Akash Jain
> Attachments: OFBIZ-9739.patch
>
>
> Go to,
> Content -> Create Website
> Here is the link to the form,
> https://demo-trunk.ofbiz.apache.org/content/control/createWebSite
> Web Site Id and Site Name are the required fields in the form, no required 
> field indicator is present, the createWebSite service throws an error if the 
> required fields are not found.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9742) Ftl error shown on Edit Shopping List page in ecommerce component

2017-09-22 Thread Parakh Maheshwari (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Parakh Maheshwari updated OFBIZ-9742:
-
Attachment: FTLError.png

> Ftl error shown on Edit Shopping List page in ecommerce component
> -
>
> Key: OFBIZ-9742
> URL: https://issues.apache.org/jira/browse/OFBIZ-9742
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Reporter: Parakh Maheshwari
> Attachments: FTLError.png
>
>
> Steps to regenerate the issue:
> 1)Login to E-commerce component :
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
> 2)Navigate to Shopping Lists.
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/editShoppingList]
> 3)Ftl error show on Shopping List page.
>  NOTE: Please refer the screenshot for the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9741) Required field indicator (*) is missing from the required field on create website content form

2017-09-22 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-9741:
-

Assignee: Akash Jain  (was: Rohit Rai)

> Required field indicator (*) is missing from the required field on create 
> website content form
> --
>
> Key: OFBIZ-9741
> URL: https://issues.apache.org/jira/browse/OFBIZ-9741
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Akash Jain
> Attachments: OFBIZ-9741.patch
>
>
> 1. Go to Content -> WebSites
> 2. Select a website from the list of sites.
> 3. click on content from the submenu, it will lead you to follow link
> https://demo-trunk.ofbiz.apache.org/content/control/ListWebSiteContent?webSiteId=WebStorePos
> 4. Content Id is a required parameter for the service, a required field 
> indicator must be placed on the form.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9742) Ftl error shown on Edit Shopping List page in ecommerce component

2017-09-22 Thread Parakh Maheshwari (JIRA)
Parakh Maheshwari created OFBIZ-9742:


 Summary: Ftl error shown on Edit Shopping List page in ecommerce 
component
 Key: OFBIZ-9742
 URL: https://issues.apache.org/jira/browse/OFBIZ-9742
 Project: OFBiz
  Issue Type: Bug
  Components: ecommerce
Reporter: Parakh Maheshwari


Steps to regenerate the issue:
1)Login to E-commerce component :
[https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
2)Navigate to Shopping Lists.
[https://demo-trunk.ofbiz.apache.org/ecommerce/control/editShoppingList]
3)Ftl error show on Shopping List page.

 NOTE: Please refer the screenshot for the same.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9741) Required field indicator (*) is missing from the required field on create website content form

2017-09-22 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai updated OFBIZ-9741:
-
Attachment: OFBIZ-9741.patch

Attaching a patch for the task.

> Required field indicator (*) is missing from the required field on create 
> website content form
> --
>
> Key: OFBIZ-9741
> URL: https://issues.apache.org/jira/browse/OFBIZ-9741
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
> Attachments: OFBIZ-9741.patch
>
>
> 1. Go to Content -> WebSites
> 2. Select a website from the list of sites.
> 3. click on content from the submenu, it will lead you to follow link
> https://demo-trunk.ofbiz.apache.org/content/control/ListWebSiteContent?webSiteId=WebStorePos
> 4. Content Id is a required parameter for the service, a required field 
> indicator must be placed on the form.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9625) Improvements in work effort calendar

2017-09-22 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-9625:


Assignee: Suraj Khurana

> Improvements in work effort calendar
> 
>
> Key: OFBIZ-9625
> URL: https://issues.apache.org/jira/browse/OFBIZ-9625
> Project: OFBiz
>  Issue Type: Improvement
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>
> As per communication on dev list:
> Current implementation is we are using enumeration for calendar types and 
> user can't add new calendar types as per own requirements (like holiday 
> calendar, training calendar, meeting calendar etc.)
> Instead of using an enumeration for that, we can use work effort of type 
> CALENDAR and associate it with calendar events as work effort assoc.
> Benefits:
> * User can create a personalized calendar.
> * Same event can be associated with multiple calendars.
> * Enumerations are hard-coded as of now, after this, the method to fetch 
> calendar events will become generic and this improves the beauty of code base 
> and it is not so good as of now.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9544) Verify contact mech details (expired or not) before copying it to new order while re-ordering

2017-09-22 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-9544:


Assignee: Suraj Khurana

> Verify contact mech details (expired or not) before copying it to new order 
> while re-ordering
> -
>
> Key: OFBIZ-9544
> URL: https://issues.apache.org/jira/browse/OFBIZ-9544
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>
> While re-ordering any order, previous contact mech (such as address, contact 
> info etc.) are copied for customer's benefits. We need to have a check that 
> could validate that contact mech is still in use or not.
> There might be other places in the code base where we need that check in 
> place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9741) Required field indicator (*) is missing from the required field on create website content form

2017-09-22 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai reassigned OFBIZ-9741:


Assignee: Rohit Rai

> Required field indicator (*) is missing from the required field on create 
> website content form
> --
>
> Key: OFBIZ-9741
> URL: https://issues.apache.org/jira/browse/OFBIZ-9741
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
>
> 1. Go to Content -> WebSites
> 2. Select a website from the list of sites.
> 3. click on content from the submenu, it will lead you to follow link
> https://demo-trunk.ofbiz.apache.org/content/control/ListWebSiteContent?webSiteId=WebStorePos
> 4. Content Id is a required parameter for the service, a required field 
> indicator must be placed on the form.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9741) Required field indicator (*) is missing from the required field on create website content form

2017-09-22 Thread Rohit Rai (JIRA)
Rohit Rai created OFBIZ-9741:


 Summary: Required field indicator (*) is missing from the required 
field on create website content form
 Key: OFBIZ-9741
 URL: https://issues.apache.org/jira/browse/OFBIZ-9741
 Project: OFBiz
  Issue Type: Bug
  Components: content
Reporter: Rohit Rai


1. Go to Content -> WebSites
2. Select a website from the list of sites.
3. click on content from the submenu, it will lead you to follow link
https://demo-trunk.ofbiz.apache.org/content/control/ListWebSiteContent?webSiteId=WebStorePos
4. Content Id is a required parameter for the service, a required field 
indicator must be placed on the form.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9740) Proper use of if-has-permission

2017-09-22 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-9740:


 Summary: Proper use of if-has-permission
 Key: OFBIZ-9740
 URL: https://issues.apache.org/jira/browse/OFBIZ-9740
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Reporter: Suraj Khurana


As per discussion in dev mailing list:
We use 
It should be like 
Now if someone has LABEL_MANAGER_ADMIN permission, then that user won't be 
granted permission. It should check for _ADMIN permission as well. 

This is properly handled when you pass action attribute, it checks for specific 
permission passed and _ADMIN permission as well.

Proposed solution:

We must use permission and action attributes at every such code occurrences to 
avoid this situation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9740) Proper use of if-has-permission

2017-09-22 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-9740:


Assignee: Suraj Khurana

> Proper use of if-has-permission
> ---
>
> Key: OFBIZ-9740
> URL: https://issues.apache.org/jira/browse/OFBIZ-9740
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>
> As per discussion in dev mailing list:
> We use  logged in party.
> There are two supported attributes as well in which permission is mandatory 
> and action is optional.
> If action is not passed then it looks for specific permission.
> For Example: 
> 
> It should be like  action="_VIEW"/>
> Now if someone has LABEL_MANAGER_ADMIN permission, then that user won't be 
> granted permission. It should check for _ADMIN permission as well. 
> This is properly handled when you pass action attribute, it checks for 
> specific permission passed and _ADMIN permission as well.
> Proposed solution:
> We must use permission and action attributes at every such code occurrences 
> to avoid this situation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9739) Required field indicator (*) is missing from the required field on create website form

2017-09-22 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai updated OFBIZ-9739:
-
Attachment: OFBIZ-9739.patch

Attaching the patch for the task.

> Required field indicator (*) is missing from the required field on create 
> website form
> --
>
> Key: OFBIZ-9739
> URL: https://issues.apache.org/jira/browse/OFBIZ-9739
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
> Attachments: OFBIZ-9739.patch
>
>
> Go to,
> Content -> Create Website
> Here is the link to the form,
> https://demo-trunk.ofbiz.apache.org/content/control/createWebSite
> Web Site Id and Site Name are the required fields in the form, no required 
> field indicator is present, the createWebSite service throws an error if the 
> required fields are not found.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9739) Required field indicator (*) is missing from the required field on create website form

2017-09-22 Thread Rohit Rai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Rai reassigned OFBIZ-9739:


Assignee: Rohit Rai

> Required field indicator (*) is missing from the required field on create 
> website form
> --
>
> Key: OFBIZ-9739
> URL: https://issues.apache.org/jira/browse/OFBIZ-9739
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Reporter: Rohit Rai
>Assignee: Rohit Rai
>
> Go to,
> Content -> Create Website
> Here is the link to the form,
> https://demo-trunk.ofbiz.apache.org/content/control/createWebSite
> Web Site Id and Site Name are the required fields in the form, no required 
> field indicator is present, the createWebSite service throws an error if the 
> required fields are not found.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9739) Required field indicator (*) is missing from the required field on create website form

2017-09-22 Thread Rohit Rai (JIRA)
Rohit Rai created OFBIZ-9739:


 Summary: Required field indicator (*) is missing from the required 
field on create website form
 Key: OFBIZ-9739
 URL: https://issues.apache.org/jira/browse/OFBIZ-9739
 Project: OFBiz
  Issue Type: Bug
  Components: content
Reporter: Rohit Rai


Go to,
Content -> Create Website
Here is the link to the form,
https://demo-trunk.ofbiz.apache.org/content/control/createWebSite

Web Site Id and Site Name are the required fields in the form, no required 
field indicator is present, the createWebSite service throws an error if the 
required fields are not found.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-7183) Completed Service Order Items are being allowed to be received along with finished goods over Approved PO

2017-09-22 Thread Ankush Upadhyay (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay reassigned OFBIZ-7183:
--

Assignee: Ankush Upadhyay

> Completed Service Order Items are being allowed to be received along with 
> finished goods over Approved PO 
> --
>
> Key: OFBIZ-7183
> URL: https://issues.apache.org/jira/browse/OFBIZ-7183
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Reporter: Swapnil Shah
>Assignee: Ankush Upadhyay
> Attachments: COMP_REC_1.png
>
>
> Whenever a PO has both service type and finished good products then order 
> items having service type products get completed on Order approval itself. 
> But when such PO is received the service type items (despite being completed) 
> are listed along with finished goods to be received and eventually get 
> received as well if done so. 
> We could try preventing service type items to be listed like we do for any 
> regular finished good items when they get completed.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9678) Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId in UserPreference entity

2017-09-22 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-9678:
-

Assignee: Akash Jain  (was: Aditya Sharma)

> Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId 
> in UserPreference entity
> 
>
> Key: OFBIZ-9678
> URL: https://issues.apache.org/jira/browse/OFBIZ-9678
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Aditya Sharma
>Assignee: Akash Jain
> Attachments: OFBIZ-9678.patch
>
>
> UserPreference.userLoginId is related to UserLogin.userLoginId.
> UserPreference.userPrefGroupTypeId is related to 
> UserPrefGroupType.userPrefGroupTypeId.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9696) Extend type entities to add name of detail entity where hasTable is true

2017-09-22 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177492#comment-16177492
 ] 

Arun Patidar commented on OFBIZ-9696:
-

As we concluded on the mailing list to not extend entity, we should follow 
convention.  so updating ticket description and title.

> Extend type entities to add name of detail entity where hasTable is true
> 
>
> Key: OFBIZ-9696
> URL: https://issues.apache.org/jira/browse/OFBIZ-9696
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>
> 'hasTable' field of 'Type' entities is used to give an idea that detail 
> entity exists or not. We generally get the name of detail entity on the basis 
> of typeId field value. 
> For example : 
> ContactMechType,contactMechTypeId = "POSTAL_ADDRESS"  then we go to 
> PostalAddress for detail.
> similarly,
> ContactMechType,contactMechTypeId = "TELECOM_NUMBER"  then we go to 
> TelecomNumber for detail.
> We should follow the naming convention.
> Below are some entities that are not following the pattern. Some of them are:
>- ShipmentGatewayConfigType
>- PaymentGatewayConfigType



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9696) Fix type entities to follow convention of hasTable

2017-09-22 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-9696:

Summary: Fix type entities to follow convention of hasTable  (was: Extend 
type entities to add name of detail entity where hasTable is true)

> Fix type entities to follow convention of hasTable
> --
>
> Key: OFBIZ-9696
> URL: https://issues.apache.org/jira/browse/OFBIZ-9696
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>
> 'hasTable' field of 'Type' entities is used to give an idea that detail 
> entity exists or not. We generally get the name of detail entity on the basis 
> of typeId field value. 
> For example : 
> ContactMechType,contactMechTypeId = "POSTAL_ADDRESS"  then we go to 
> PostalAddress for detail.
> similarly,
> ContactMechType,contactMechTypeId = "TELECOM_NUMBER"  then we go to 
> TelecomNumber for detail.
> We should follow the naming convention.
> Below are some entities that are not following the pattern. Some of them are:
>- ShipmentGatewayConfigType
>- PaymentGatewayConfigType



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9696) Extend type entities to add name of detail entity where hasTable is true

2017-09-22 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-9696:

Description: 
'hasTable' field of 'Type' entities is used to give an idea that detail entity 
exists or not. We generally get the name of detail entity on the basis of 
typeId field value. 

For example : 

ContactMechType,contactMechTypeId = "POSTAL_ADDRESS"  then we go to 
PostalAddress for detail.

similarly,
ContactMechType,contactMechTypeId = "TELECOM_NUMBER"  then we go to 
TelecomNumber for detail.

We should follow the naming convention.

Below are some entities that are not following the pattern. Some of them are:
   - ShipmentGatewayConfigType
   - PaymentGatewayConfigType


  was:
'hasTable' field of 'Type' entities is used to give an idea that detail entity 
exists or not. We generally get the name of detail entity on the basis of 
typeId field value. 

For example : 

ContactMechType,contactMechTypeId = "POSTAL_ADDRESS"  then we go to 
PostalAddress for detail.

similarly,
ContactMechType,contactMechTypeId = "TELECOM_NUMBER"  then we go to 
TelecomNumber for detail.

We can add a field in Type entities to mention the name of detail entity.

Also,there are some entities that are not following the pattern. Some of them 
are:
   - ShipmentGatewayConfigType
   - PaymentGatewayConfigType



> Extend type entities to add name of detail entity where hasTable is true
> 
>
> Key: OFBIZ-9696
> URL: https://issues.apache.org/jira/browse/OFBIZ-9696
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>
> 'hasTable' field of 'Type' entities is used to give an idea that detail 
> entity exists or not. We generally get the name of detail entity on the basis 
> of typeId field value. 
> For example : 
> ContactMechType,contactMechTypeId = "POSTAL_ADDRESS"  then we go to 
> PostalAddress for detail.
> similarly,
> ContactMechType,contactMechTypeId = "TELECOM_NUMBER"  then we go to 
> TelecomNumber for detail.
> We should follow the naming convention.
> Below are some entities that are not following the pattern. Some of them are:
>- ShipmentGatewayConfigType
>- PaymentGatewayConfigType



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9678) Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId in UserPreference entity

2017-09-22 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9678:
-
Attachment: OFBIZ-9678.patch

Added relation for UserPreference.userLoginId to UserLogin.userLoginId & 
UserPreference.userPrefGroupTypeId to UserPrefGroupType.userPrefGroupTypeId.


> Missing foreign key constraint for fields userLoginId & userPrefGroupTypeId 
> in UserPreference entity
> 
>
> Key: OFBIZ-9678
> URL: https://issues.apache.org/jira/browse/OFBIZ-9678
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
> Attachments: OFBIZ-9678.patch
>
>
> UserPreference.userLoginId is related to UserLogin.userLoginId.
> UserPreference.userPrefGroupTypeId is related to 
> UserPrefGroupType.userPrefGroupTypeId.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-7183) Completed Service Order Items are being allowed to be received along with finished goods over Approved PO

2017-09-22 Thread Swapnil Shah (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah reassigned OFBIZ-7183:
---

Assignee: (was: Divesh Dutta)

> Completed Service Order Items are being allowed to be received along with 
> finished goods over Approved PO 
> --
>
> Key: OFBIZ-7183
> URL: https://issues.apache.org/jira/browse/OFBIZ-7183
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Reporter: Swapnil Shah
> Attachments: COMP_REC_1.png
>
>
> Whenever a PO has both service type and finished good products then order 
> items having service type products get completed on Order approval itself. 
> But when such PO is received the service type items (despite being completed) 
> are listed along with finished goods to be received and eventually get 
> received as well if done so. 
> We could try preventing service type items to be listed like we do for any 
> regular finished good items when they get completed.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-7377) Introduce the option for specifying Check (Reference) Number upon using Check as payment method during ordering

2017-09-22 Thread Swapnil Shah (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah reassigned OFBIZ-7377:
---

Assignee: (was: Swapnil Shah)

> Introduce the option for specifying Check (Reference) Number upon using Check 
> as payment method during ordering
> ---
>
> Key: OFBIZ-7377
> URL: https://issues.apache.org/jira/browse/OFBIZ-7377
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Swapnil Shah
> Attachments: OrdPmt.png
>
>
> Currently there is no option during ordering to specify the actual Check 
> Number that could be used for making payment upon selecting Check as payment 
> method.
> We could provide a text entry box for recording check number and same could 
> be set as Payment.PaymentRefNumber upon order creation. 
> Please refer to attached screenshot



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-7610) Product Price set based on 'Purchase Price Agreement' isn't honored while same is used during ordering

2017-09-22 Thread Swapnil Shah (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah reassigned OFBIZ-7610:
---

Assignee: (was: Swapnil Shah)

> Product Price set based on 'Purchase Price Agreement' isn't honored while 
> same is used during ordering
> --
>
> Key: OFBIZ-7610
> URL: https://issues.apache.org/jira/browse/OFBIZ-7610
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Swapnil Shah
> Attachments: SA_1.png, SA_2.png, SA_3.png, SA_4.png, SA_5.png
>
>
> Once any Purchase Agreement is created with supplier for certain products at 
> pre-determined price, its get successfully transformed into SupplierProduct. 
> But at the time of Purchase order creation is same agreement is enforced then 
> agreement prices for products are ignored while setting the price on cart and 
> eventually on order itself.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-7607) Promotions Shouldn't get auto-applied when "Sales/Price Agreement" is in force on sales order

2017-09-22 Thread Swapnil Shah (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah reassigned OFBIZ-7607:
---

Assignee: (was: Swapnil Shah)

> Promotions Shouldn't get auto-applied when "Sales/Price Agreement" is in 
> force on sales order
> -
>
> Key: OFBIZ-7607
> URL: https://issues.apache.org/jira/browse/OFBIZ-7607
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
> Attachments: PA_1.png, PA_2.png, PA_3.png
>
>
> More often than not if any sales(price) agreement with customer on any 
> product is in play on any order then other active promotions/discounts/price 
> rules (which are supposed to get auto-applied on List/Default price on any 
> normal order) should take back seat unless specified otherwise. 
> Currently, it seems to be happening otherwise, all the normal 
> adjustments/discounts gets activated on Agreement Price itself (that are 
> supposed to be applied on List/Default prices) whenever agreement is  
> enforced while placing the sales order.
> Even if we need to do so, it could be allowed to be done on case by case 
> basis as follows:
> *Proposed solution:*
> # Let's add the flag (checkbox) on screen Order Entry where any active 
> agreements is allowed to be selected with label "Apply Active Promotions"
> ## If above flag is not checked, then order should be placed only and only 
> with prices set on selected active agreement
> ## If above flag is checked then as its happening currently, do apply all 
> active promotions/discounts/rules on agreement prices.
> ## By default the flag should remain unchecked, so it gets activated only if 
> user specially select it to give other promotions on such order and it 
> doesn't happen inadvertently.
> Please refer to attached screenshot for references.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-7714) Introduce a quick way for adding Purchase Price agreements with Suppliers for any specific product from Catalog

2017-09-22 Thread Swapnil Shah (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah reassigned OFBIZ-7714:
---

Assignee: (was: Swapnil Shah)

> Introduce a quick way for adding Purchase Price agreements with Suppliers for 
> any specific product from Catalog
> ---
>
> Key: OFBIZ-7714
> URL: https://issues.apache.org/jira/browse/OFBIZ-7714
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: 14.12.01, 15.12.01
>Reporter: Swapnil Shah
> Attachments: PPA.png
>
>
> Currently new pricing agreements creation takes user to Accounting app where 
> it is quite an long and arduous process. And many a times a buyer or 
> procurement users doesn't have direct accounting permission in case quick 
> pricing agreement needs to be placed with Supplier for specific product(s).
> We can provide a quick option from Catalog >> Product >> Agreement screen 
> over "Purchase" section that could unfold as follows:
> # Have a 'Create Price Agreement' link/button on the 'Purchases' Panel and 
> hitting this link could ask user to enter following very basic parameters:
> #- Party Id From (Default it to facility's owner party id)
> #- Party Id To (show list of suppliers like we show at the time of Purchase 
> Order entry screen)
> #- From Date (default it to show as now() timestamp)
> #- Through Date
> #- Description
> #- Price
> #- Currency
> #- Supplier Product Id
> # Upon successful submission of above details system should create Agreement 
> and AgreementItem & SupplierProduct between Supplier and organization by 
> passing following default values:
> #- Role Type Id From = 'Internal Organization'
> #- Role Type Id To = ''Supplier"
> #- Agreement Type Id = 'Purchase'
> #- Agreement Item Type Id = 'Pricing'
> #- Product Id= ''
> Please refer to attached screenshot for reference placeholder
> !PPA.png|thumbnail!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-8014) Introduce the "Product" Screen under Party app to manage the products supplied by any supplier

2017-09-22 Thread Swapnil Shah (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Shah reassigned OFBIZ-8014:
---

Assignee: (was: Swapnil Shah)

> Introduce the "Product" Screen under Party app to manage the products 
> supplied by any supplier
> --
>
> Key: OFBIZ-8014
> URL: https://issues.apache.org/jira/browse/OFBIZ-8014
> Project: OFBiz
>  Issue Type: New Feature
>Affects Versions: Release Branch 14.12, 16.11.01, Release Branch 15.12
>Reporter: Swapnil Shah
> Attachments: SupplierProduct.png
>
>
> Currently, upon logging into the Party application (or login as supplier 
> itself) and go to any specific supplier view then there is no way to manage 
> the list of supplied products. 
> # We can try introducing the "Product" tab/screen along with other tabs. (to 
> begin with we can simply mimic the Supplier screen from Catalog app e.g., 
> https://ofbiz-vm.apache.org:8443/catalog/control/EditProductSuppliers?productId=MAT_A_COST)
>  
> # We can also choose to show the "Products" tab for only Parties in supplier 
> role and later can try to extend for other roles with further needed 
> refinements. 
> Please refer to attached screenshot for the same.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Reopened] (OFBIZ-5701) Bug SQL Count Distinct command in GenericDAO.java

2017-09-22 Thread Pawan Verma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reopened OFBIZ-5701:


Hey Guys,
I have tested this flow with both Static and Dynamic View Entity. It is working 
fine for the Static View(Tested for *PartyAndPerson* entity).
But in case of the Dynamic View, it is not working. Previously it was not 
applying distinct but now method getResultsSizeAfterPartialList() always 
returns 1 in all the cases.
Below is my testing View Entity:
{code}
workEffortAndGoodStandard = new DynamicViewEntity();

workEffortAndGoodStandard.addMemberEntity("WE", "WorkEffort");
workEffortAndGoodStandard.addAlias("WE", "workEffortId",null, null, false, 
true, null);
workEffortAndGoodStandard.addAlias("WE", "workEffortPurposeTypeId",null, null, 
false, true, null);

workEffortAndGoodStandard.addMemberEntity("WEGS", "WorkEffortGoodStandard");
workEffortAndGoodStandard.addAlias("WEGS", "workEffortId", null, null, false, 
true, null);
workEffortAndGoodStandard.addAlias("WEGS", "productId", null, null, true, true, 
null);
workEffortAndGoodStandard.addViewLink("WEGS", "WE", Boolean.FALSE, 
ModelKeyMap.makeKeyMapList("workEffortId", "workEffortId"));

workEffortAndGoodStandardListItr = 
select("productId").from(workEffortAndGoodStandard).distinct().queryIterator();
workEffortAndGoodStandardListSize = 
workEffortAndGoodStandardListItr.getResultsSizeAfterPartialList();
{code}

> Bug SQL Count Distinct command in GenericDAO.java 
> --
>
> Key: OFBIZ-5701
> URL: https://issues.apache.org/jira/browse/OFBIZ-5701
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: kieuanhvu
>Assignee: Jacques Le Roux
> Fix For: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, 16.11.04
>
> Attachments: GenericDAO.java.patch, GenericDAO.java.patch, 
> SQLDistinctGenericDAO.diff, SQLDistinctGenericDAO.diff
>
>
> I have encounter the problem is: How can ofbiz framework count distinct for 
> all selected fields in query function of delegator? Although 
> EntityFindOptions.setDistinct(true) and the selected fields are all field, 
> the ofbiz framework always count distinct follow only one field.
> I have resolved problem as my attact file



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-9728) Empty rows affect the imported

2017-09-22 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176062#comment-16176062
 ] 

Jacques Le Roux edited comment on OFBIZ-9728 at 9/22/17 7:40 AM:
-

Thanks Liang,

Your patch is in trunk at revision 1809270; previous branches are not concerned.

The pricat component was missing in Jira I added it.

2 small remarks:
# We don't uset tabs but 4 spaces instead
# Please create your patches from the root to have a complete path from there. 
Easier when patching

See 
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
 for details (look for "Guidelines" notably, reading the whole page is worth it)


was (Author: jacques.le.roux):
Thanks Liang,

Your patch is in trunk at revision 1809270; previous branches are not concerned/

The pricat component was missing in Jira I added it.

2 small remarks:
# We don't uset tabs but 4 spaces instead
# Please create your patches from the root to have a complete path from there. 
Easier when patching

See 
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
 for details (look for "Guidelines" notably, reading the whole page is worth it)

> Empty rows affect the imported
> --
>
> Key: OFBIZ-9728
> URL: https://issues.apache.org/jira/browse/OFBIZ-9728
> Project: OFBiz
>  Issue Type: Bug
>  Components: pricat
>Affects Versions: Trunk
>Reporter: zhang.liang
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: SamplePricatParser.java.patch
>
>
> ofbiz-plugins pricat Component
> Affected by the empty rows, the number of rows actually imported is less than 
>  rows of excel.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9728) Empty rows affect the imported

2017-09-22 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9728.
--
Resolution: Fixed

Thanks Liang,

Your patch is in trunk at revision 1809270; previous branches are not concerned/

The pricat component was missing in Jira I added it.

2 small remarks:
# We don't uset tabs but 4 spaces instead
# Please create your patches from the root to have a complete path from there. 
Easier when patching

See 
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
 for details (look for "Guidelines" notably, reading the whole page is worth it)

> Empty rows affect the imported
> --
>
> Key: OFBIZ-9728
> URL: https://issues.apache.org/jira/browse/OFBIZ-9728
> Project: OFBiz
>  Issue Type: Bug
>  Components: pricat
>Affects Versions: Trunk
>Reporter: zhang.liang
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: SamplePricatParser.java.patch
>
>
> ofbiz-plugins pricat Component
> Affected by the empty rows, the number of rows actually imported is less than 
>  rows of excel.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9728) Empty rows affect the imported

2017-09-22 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9728:
--

Assignee: Jacques Le Roux

> Empty rows affect the imported
> --
>
> Key: OFBIZ-9728
> URL: https://issues.apache.org/jira/browse/OFBIZ-9728
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: zhang.liang
>Assignee: Jacques Le Roux
> Attachments: SamplePricatParser.java.patch
>
>
> ofbiz-plugins pricat Component
> Affected by the empty rows, the number of rows actually imported is less than 
>  rows of excel.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)