[jira] [Updated] (OFBIZ-9831) Use Vaadin as alternative for screens/forms
[ https://issues.apache.org/jira/browse/OFBIZ-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-9831: --- Summary: Use Vaadin as alternative for screens/forms (was: Us Vaadin as alternative for screens/forms) > Use Vaadin as alternative for screens/forms > --- > > Key: OFBIZ-9831 > URL: https://issues.apache.org/jira/browse/OFBIZ-9831 > Project: OFBiz > Issue Type: New Feature > Components: ALL APPLICATIONS >Affects Versions: Trunk > Environment: any >Reporter: Hans Bakker >Priority: Minor > Labels: ui, vaadin > Fix For: Trunk > > Attachments: vaadin-test.zip > > > Please find attached the latest version (9 oct 2017) of our vaadin proof on > concept. > put this zip and extract in the plugins directory and read the Readme.txt > file for installation instructions > This is still a work in progress, the latest version can be downloaded with > your preferred GIT client at: git clone > https://gerrit.antwebsystems.com/vaadin-test -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9831) Us Vaadin as alternative for screens/forms
[ https://issues.apache.org/jira/browse/OFBIZ-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-9831: --- Attachment: vaadin-test.zip the vaadin-test component > Us Vaadin as alternative for screens/forms > -- > > Key: OFBIZ-9831 > URL: https://issues.apache.org/jira/browse/OFBIZ-9831 > Project: OFBiz > Issue Type: New Feature > Components: ALL APPLICATIONS >Affects Versions: Trunk > Environment: any >Reporter: Hans Bakker >Priority: Minor > Labels: ui, vaadin > Fix For: Trunk > > Attachments: vaadin-test.zip > > > Please find attached the latest version (9 oct 2017) of our vaadin proof on > concept. > put this zip and extract in the plugins directory and read the Readme.txt > file for installation instructions > This is still a work in progress, the latest version can be downloaded with > your preferred GIT client at: git clone > https://gerrit.antwebsystems.com/vaadin-test -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9831) Us Vaadin as alternative for screens/forms
Hans Bakker created OFBIZ-9831: -- Summary: Us Vaadin as alternative for screens/forms Key: OFBIZ-9831 URL: https://issues.apache.org/jira/browse/OFBIZ-9831 Project: OFBiz Issue Type: New Feature Components: ALL APPLICATIONS Affects Versions: Trunk Environment: any Reporter: Hans Bakker Priority: Minor Fix For: Trunk Please find attached the latest version (9 oct 2017) of our vaadin proof on concept. put this zip and extract in the plugins directory and read the Readme.txt file for installation instructions This is still a work in progress, the latest version can be downloaded with your preferred GIT client at: git clone https://gerrit.antwebsystems.com/vaadin-test -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-9829) Add a new plugin for the redis
[ https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shi Jinghai reassigned OFBIZ-9829: -- Assignee: Shi Jinghai > Add a new plugin for the redis > -- > > Key: OFBIZ-9829 > URL: https://issues.apache.org/jira/browse/OFBIZ-9829 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Hadwin Dai >Assignee: Shi Jinghai > Labels: redis > Attachments: OFBIZ-9829_redis-plugins.patch > > > Redis is an open source (BSD licensed), in-memory data structure store, used > as a database, cache and message broker. > Included services: get data, set data and delete data. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9830) Template edit are not working correctly
[ https://issues.apache.org/jira/browse/OFBIZ-9830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fumiyoshi.to updated OFBIZ-9830: Attachment: EditSubContent.groovy.jpg > Template edit are not working correctly > --- > > Key: OFBIZ-9830 > URL: https://issues.apache.org/jira/browse/OFBIZ-9830 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Release >Reporter: fumiyoshi.to > Attachments: EditSubContent.groovy.jpg, EditSubContent.groovy.patch > > > Steps to recreate: > 1. Go to ContentManager. > 2. Go to Template. > 3. Click Find, then click LEFTBAR in the search result. > 4. Click Edit, then we get a error page. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9830) Template edit are not working correctly
[ https://issues.apache.org/jira/browse/OFBIZ-9830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fumiyoshi.to updated OFBIZ-9830: Attachment: EditSubContent.groovy.patch > Template edit are not working correctly > --- > > Key: OFBIZ-9830 > URL: https://issues.apache.org/jira/browse/OFBIZ-9830 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Upcoming Release >Reporter: fumiyoshi.to > Attachments: EditSubContent.groovy.patch > > > Steps to recreate: > 1. Go to ContentManager. > 2. Go to Template. > 3. Click Find, then click LEFTBAR in the search result. > 4. Click Edit, then we get a error page. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-9830) Template edit are not working correctly
fumiyoshi.to created OFBIZ-9830: --- Summary: Template edit are not working correctly Key: OFBIZ-9830 URL: https://issues.apache.org/jira/browse/OFBIZ-9830 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Upcoming Release Reporter: fumiyoshi.to Steps to recreate: 1. Go to ContentManager. 2. Go to Template. 3. Click Find, then click LEFTBAR in the search result. 4. Click Edit, then we get a error page. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-9688) [FB] Package org.apache.ofbiz.service.engine
[
https://issues.apache.org/jira/browse/OFBIZ-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-9688.
Resolution: Implemented
Fix Version/s: Upcoming Release
Thanks Dennis,
your patch is in trunk r1811468.
> [FB] Package org.apache.ofbiz.service.engine
>
>
> Key: OFBIZ-9688
> URL: https://issues.apache.org/jira/browse/OFBIZ-9688
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9688_org.apache.ofbiz.service.engine_bugfixes.patch
>
>
> - GenericEngineFactory.java:67, REC_CATCH_EXCEPTION
> REC: Exception is caught when Exception is not thrown in
> org.apache.ofbiz.service.engine.GenericEngineFactory.getGenericEngine(String)
> This method uses a try-catch block that catches Exception objects, but
> Exception is not thrown within the try block, and RuntimeException is not
> explicitly caught. It is a common bug pattern to say try { ... } catch
> (Exception e) { something } as a shorthand for catching a number of types of
> exception each of whose catch blocks is identical, but this construct also
> accidentally catches RuntimeException as well, masking potential bugs.
> A better approach is to either explicitly catch the specific exceptions that
> are thrown, or to explicitly catch RuntimeException exception, rethrow it,
> and then catch all non-Runtime Exceptions, as shown below:
> try {
> ...
> } catch (RuntimeException e) {
> throw e;
> } catch (Exception e) {
> ... deal with all non-runtime exceptions ...
> }
> - GroovyEngine.java:-1, CI_CONFUSED_INHERITANCE
> CI: Class org.apache.ofbiz.service.engine.GroovyEngine is final but declares
> protected field org.apache.ofbiz.service.engine.GroovyEngine.EMPTY_ARGS
> This class is declared to be final, but declares fields to be protected.
> Since the class is final, it can not be derived from, and the use of
> protected is confusing. The access modifier for the field should be changed
> to private or public to represent the true use for the field.
> - HttpEngine.java:64, REC_CATCH_EXCEPTION
> REC: Exception is caught when Exception is not thrown in
> org.apache.ofbiz.service.engine.HttpEngine.runSync(String, ModelService, Map)
> This method uses a try-catch block that catches Exception objects, but
> Exception is not thrown within the try block, and RuntimeException is not
> explicitly caught. It is a common bug pattern to say try { ... } catch
> (Exception e) { something } as a shorthand for catching a number of types of
> exception each of whose catch blocks is identical, but this construct also
> accidentally catches RuntimeException as well, masking potential bugs.
> A better approach is to either explicitly catch the specific exceptions that
> are thrown, or to explicitly catch RuntimeException exception, rethrow it,
> and then catch all non-Runtime Exceptions, as shown below:
> try {
> ...
> } catch (RuntimeException e) {
> throw e;
> } catch (Exception e) {
> ... deal with all non-runtime exceptions ...
> }
> - HttpEngine.java:137, REC_CATCH_EXCEPTION
> REC: Exception is caught when Exception is not thrown in
> org.apache.ofbiz.service.engine.HttpEngine.httpEngine(HttpServletRequest,
> HttpServletResponse)
> This method uses a try-catch block that catches Exception objects, but
> Exception is not thrown within the try block, and RuntimeException is not
> explicitly caught. It is a common bug pattern to say try { ... } catch
> (Exception e) { something } as a shorthand for catching a number of types of
> exception each of whose catch blocks is identical, but this construct also
> accidentally catches RuntimeException as well, masking potential bugs.
> A better approach is to either explicitly catch the specific exceptions that
> are thrown, or to explicitly catch RuntimeException exception, rethrow it,
> and then catch all non-Runtime Exceptions, as shown below:
> try {
> ...
> } catch (RuntimeException e) {
> throw e;
> } catch (Exception e) {
> ... deal with all non-runtime exceptions ...
> }
> - HttpEngine.java:185, DM_DEFAULT_ENCODING
> Dm: Found reliance on default encoding in
> org.apache.ofbiz.service.engine.HttpEngine.httpEngine(HttpServletRequest,
> HttpServletResponse): String.getBytes()
> Found a call to a method which will perform a byte to String (or String to
> byte) conversion, and will assume that the default platform encoding is
> suitable. This will cause the application behaviour to vary between
> platforms. Use an alternative API and specify a charset name or Charset
> object explicitly.
> - SOAPClientEngine.java:135,
[jira] [Assigned] (OFBIZ-9688) [FB] Package org.apache.ofbiz.service.engine
[
https://issues.apache.org/jira/browse/OFBIZ-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-9688:
Assignee: Michael Brohl
> [FB] Package org.apache.ofbiz.service.engine
>
>
> Key: OFBIZ-9688
> URL: https://issues.apache.org/jira/browse/OFBIZ-9688
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-9688_org.apache.ofbiz.service.engine_bugfixes.patch
>
>
> - GenericEngineFactory.java:67, REC_CATCH_EXCEPTION
> REC: Exception is caught when Exception is not thrown in
> org.apache.ofbiz.service.engine.GenericEngineFactory.getGenericEngine(String)
> This method uses a try-catch block that catches Exception objects, but
> Exception is not thrown within the try block, and RuntimeException is not
> explicitly caught. It is a common bug pattern to say try { ... } catch
> (Exception e) { something } as a shorthand for catching a number of types of
> exception each of whose catch blocks is identical, but this construct also
> accidentally catches RuntimeException as well, masking potential bugs.
> A better approach is to either explicitly catch the specific exceptions that
> are thrown, or to explicitly catch RuntimeException exception, rethrow it,
> and then catch all non-Runtime Exceptions, as shown below:
> try {
> ...
> } catch (RuntimeException e) {
> throw e;
> } catch (Exception e) {
> ... deal with all non-runtime exceptions ...
> }
> - GroovyEngine.java:-1, CI_CONFUSED_INHERITANCE
> CI: Class org.apache.ofbiz.service.engine.GroovyEngine is final but declares
> protected field org.apache.ofbiz.service.engine.GroovyEngine.EMPTY_ARGS
> This class is declared to be final, but declares fields to be protected.
> Since the class is final, it can not be derived from, and the use of
> protected is confusing. The access modifier for the field should be changed
> to private or public to represent the true use for the field.
> - HttpEngine.java:64, REC_CATCH_EXCEPTION
> REC: Exception is caught when Exception is not thrown in
> org.apache.ofbiz.service.engine.HttpEngine.runSync(String, ModelService, Map)
> This method uses a try-catch block that catches Exception objects, but
> Exception is not thrown within the try block, and RuntimeException is not
> explicitly caught. It is a common bug pattern to say try { ... } catch
> (Exception e) { something } as a shorthand for catching a number of types of
> exception each of whose catch blocks is identical, but this construct also
> accidentally catches RuntimeException as well, masking potential bugs.
> A better approach is to either explicitly catch the specific exceptions that
> are thrown, or to explicitly catch RuntimeException exception, rethrow it,
> and then catch all non-Runtime Exceptions, as shown below:
> try {
> ...
> } catch (RuntimeException e) {
> throw e;
> } catch (Exception e) {
> ... deal with all non-runtime exceptions ...
> }
> - HttpEngine.java:137, REC_CATCH_EXCEPTION
> REC: Exception is caught when Exception is not thrown in
> org.apache.ofbiz.service.engine.HttpEngine.httpEngine(HttpServletRequest,
> HttpServletResponse)
> This method uses a try-catch block that catches Exception objects, but
> Exception is not thrown within the try block, and RuntimeException is not
> explicitly caught. It is a common bug pattern to say try { ... } catch
> (Exception e) { something } as a shorthand for catching a number of types of
> exception each of whose catch blocks is identical, but this construct also
> accidentally catches RuntimeException as well, masking potential bugs.
> A better approach is to either explicitly catch the specific exceptions that
> are thrown, or to explicitly catch RuntimeException exception, rethrow it,
> and then catch all non-Runtime Exceptions, as shown below:
> try {
> ...
> } catch (RuntimeException e) {
> throw e;
> } catch (Exception e) {
> ... deal with all non-runtime exceptions ...
> }
> - HttpEngine.java:185, DM_DEFAULT_ENCODING
> Dm: Found reliance on default encoding in
> org.apache.ofbiz.service.engine.HttpEngine.httpEngine(HttpServletRequest,
> HttpServletResponse): String.getBytes()
> Found a call to a method which will perform a byte to String (or String to
> byte) conversion, and will assume that the default platform encoding is
> suitable. This will cause the application behaviour to vary between
> platforms. Use an alternative API and specify a charset name or Charset
> object explicitly.
> - SOAPClientEngine.java:135, REC_CATCH_EXCEPTION
> REC: Exception is caught when Exception is not thrown in
>
[jira] [Closed] (OFBIZ-9684) [FB] Package org.apache.ofbiz.service.group
[ https://issues.apache.org/jira/browse/OFBIZ-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-9684. Resolution: Implemented Fix Version/s: Upcoming Release Thanks Julian, your patch is in trunk r1811467. > [FB] Package org.apache.ofbiz.service.group > --- > > Key: OFBIZ-9684 > URL: https://issues.apache.org/jira/browse/OFBIZ-9684 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS, ALL COMPONENTS >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-9684_org.apache.ofbiz.service.group_bugfixes.patch > > > GroupModel.java:55, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE > - RCN: Redundant nullcheck of > org.apache.ofbiz.service.group.GroupModel.groupName, which is known to be > non-null in new org.apache.ofbiz.service.group.GroupModel(Element) > This method contains a redundant check of a known non-null value against the > constant null. > GroupServiceModel.java:107, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE > - RCN: Redundant nullcheck of model, which is known to be non-null in > org.apache.ofbiz.service.group.GroupServiceModel.invoke(ServiceDispatcher, > String, Map) > This method contains a redundant check of a known non-null value against the > constant null. > ServiceGroupReader.java:43, MS_SHOULD_BE_FINAL, Priorität: Hoch > - MS: org.apache.ofbiz.service.group.ServiceGroupReader.groupsCache isn't > final but should be > This static field public but not final, and could be changed by malicious > code or by accident from another package. The field could be made final to > avoid this vulnerability. > ServiceGroupReader.java:78, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE > - RCN: Redundant nullcheck of groupName, which is known to be non-null in > org.apache.ofbiz.service.group.ServiceGroupReader.addGroupDefinitions(ResourceHandler) > This method contains a redundant check of a known non-null value against the > constant null. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9682) [FB] Package org.apache.ofbiz.service.config.model
[
https://issues.apache.org/jira/browse/OFBIZ-9682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196040#comment-16196040
]
Michael Brohl commented on OFBIZ-9682:
--
Hi Julian,
this patch wrongly changes the exception messages, please check and provide a
correct patch.
> [FB] Package org.apache.ofbiz.service.config.model
> --
>
> Key: OFBIZ-9682
> URL: https://issues.apache.org/jira/browse/OFBIZ-9682
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS, ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
> Attachments:
> OFBIZ-9682_org.apache.ofbiz.service.config.model_bugfixes.patch
>
>
> ThreadPool.java:135, REC_CATCH_EXCEPTION
> REC: Exception is caught when Exception is not thrown in new
> org.apache.ofbiz.service.config.model.ThreadPool(Element)
> This method uses a try-catch block that catches Exception objects, but
> Exception is not thrown within the try block, and RuntimeException is not
> explicitly caught. It is a common bug pattern to say try { ... } catch
> (Exception e) { something } as a shorthand for catching a number of types of
> exception each of whose catch blocks is identical, but this construct also
> accidentally catches RuntimeException as well, masking potential bugs.
> A better approach is to either explicitly catch the specific exceptions that
> are thrown, or to explicitly catch RuntimeException exception, rethrow it,
> and then catch all non-Runtime Exceptions, as shown below:
> try {
> ...
> } catch (RuntimeException e) {
> throw e;
> } catch (Exception e) {
> ... deal with all non-runtime exceptions ...
> }
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-5938) GlAccountOrganizations manually added using accounting forms do not appear on trial report because fromDate gets set to NULL
[ https://issues.apache.org/jira/browse/OFBIZ-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196031#comment-16196031 ] Rajesh Kumar Mallah commented on OFBIZ-5938: I faced this issue with 11.6 also and had to manually update using SQL update gl_account_organization set from_date='2001-01-01 00:00:00+05:30' where organization_party_id='1'; steps summary: 1) create a new organisation 2) assign gl_accounts to it 3) carry out some transations 4) try checking trial balance. it shall display cr:0 dr:0 after updating the 'from_date' it worked as expected. regds mallah. > GlAccountOrganizations manually added using accounting forms do not appear on > trial report because fromDate gets set to NULL > > > Key: OFBIZ-5938 > URL: https://issues.apache.org/jira/browse/OFBIZ-5938 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 14.12, Trunk >Reporter: Christian Carlow >Assignee: Pranay Pandey >Priority: Minor > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-5938.patch > > > To reproduce: > 1. Manually assign a glAccount to an organization (Accounting->Global GL > Settings->Chart Of Accounts->Assign Gl Account or Accounting->Organization GL > Settings->Setup->Chart of Accounts) > 2. Perform operations that create transactions for the organizations > glAccount > 3. Run the Accounting->Organization GL Settings->Accounting->Reports->Trial > Balance > Notice that the glAccountId assigned in step 1 is not listed in the results. > This is due to TrialBalance.groovy applying a fromDate filter to > GlAccountOrganizationAndClass which is not set in step 1. Updating > glAccountOrganization fromDate to something within the trial balance range > resolves the problem. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
