[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis

2017-10-11 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201303#comment-16201303
 ] 

Shi Jinghai commented on OFBIZ-9829:


Thank you Michael, got it. I'll start a thread on whether it's OK to add this 
redis plugin to codebase.

> Add a new plugin for the redis
> --
>
> Key: OFBIZ-9829
> URL: https://issues.apache.org/jira/browse/OFBIZ-9829
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Hadwin Dai
>Assignee: Shi Jinghai
>  Labels: redis
> Attachments: OFBIZ-9829_redis-plugins.patch
>
>
> Redis is an open source (BSD licensed), in-memory data structure store, used 
> as a database, cache and message broker.
> Included services: get data, set data and delete data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis

2017-10-11 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200973#comment-16200973
 ] 

Michael Brohl commented on OFBIZ-9829:
--

[~shi.jinghai],

my concern is not about Redis and it does not matter if I personally like it or 
not. In fact, I have no strong opinion about it at the moment, because I had 
not the chance to think about it.

My concern is about the way you commit a new plugin to the codebase without 
asking the community.

Apache OFBiz is a community project. Architectural changes, refactorings, 
changes of business logic and also the introduction of new functionality and 
enhancements should be explained, discussed, reviewed and approved with a 
consensus.

I kindly ask you to revert the commit and start a proposal to introduce a Redis 
integration for OFBiz.

If you have good arguments for adding it and if the solution does fit in the 
sense of quality, user benefit and documentation, I'm pretty sure it will find 
it's way to the codebase.

Thanks,
Michael


> Add a new plugin for the redis
> --
>
> Key: OFBIZ-9829
> URL: https://issues.apache.org/jira/browse/OFBIZ-9829
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Hadwin Dai
>Assignee: Shi Jinghai
>  Labels: redis
> Attachments: OFBIZ-9829_redis-plugins.patch
>
>
> Redis is an open source (BSD licensed), in-memory data structure store, used 
> as a database, cache and message broker.
> Included services: get data, set data and delete data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9500) Maintain accountingQuantity for all COGS valuation methods

2017-10-11 Thread Paul Foxworthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Foxworthy updated OFBIZ-9500:
--
Description: 
>From 
>http://ofbiz.135035.n4.nabble.com/AccountingQuantity-COGS-method-and-inventory-valuation-td4700867.html

*Why accounting quantity?*

When inventory is shipped, there's an accounting transaction that debits the 
inventory on hand value and credits Cost of Goods Sold (COGS). 

There's more than one way of deciding what value is added to COGS. 

First and most obvious is the actual cost of the inventory item. But companies 
may prefer other strategies. OFBiz has the option of three others: average 
cost, first-in-first-out or last-in-first-out. There's a nice survey of _why_ 
you might choose one of these at 
http://www.dummies.com/business/operations-management/choosing-an-accounting-method-for-the-cost-of-goods-sold-expense/,
 
http://www.dummies.com/business/accounting/the-fifo-method-for-cost-of-goods-sold/,
 
http://www.dummies.com/business/accounting/the-lifo-method-for-cost-of-goods-sold/
 

Note that if you choose anything other than inventory item cost, the money 
amount transferred to the COGS account may be *different* to the cost price of 
the inventory items being shipped. When you choose FIFO or LIFO, the amount may 
have originated from a different inventory item, received at a different time. 

*Current situation in OFBiz*

The cogsMethodId field in the PartyAcctgPreference entity is a enum with four 
possible values: COGS_INV_COST, COGS_AVG_COST,  COGS_FIFO, COGS_LIFO.. 

The accountingQuantity field in the InventoryItem entity and 
accountingQuantityDiff in the InventoryItemDetail entity track the quantity of 
an item still "live" for the purpose of inventory valuation and COGS. 

In the service createAcctgTransForShipmentReceipt implemented in 
/applications/accounting/minilang/ledger/GeneralLedgerServices.xml 
(http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1306)
 

the accountingQuantity is always set to the same value as the quantity received 
(i.e. the same as the quantityOnHand) for a newly received inventory item 
regardless of the COGS method. 

When items are shipped, the service createAcctgTransForSalesShipmentIssuance 
will only reduce the accounting quantity if the COGS method is FIFO or LIFO 
(http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1127).
 With FIFO, when an item is shipped, inventory items for the product with a 
non-zero accounting quantity are found sorted from earliest to latest received. 
The quantity of the item shipped must be decremented from the accounting 
quantities, starting with the earliest. Similarly, with LIFO, items are sorted 
from latest to earliest, and the latest item or items are decremented. 

In other words, if you have chosen a COGS method of COGS_INV_COST or 
COGS_AVG_COST, the accounting quantity is meaningless and in OFBiz as of 
now, should be ignored. 

And yet, the Inventory Valuation report uses accounting quantity, regardless of 
the the COGS method 
(http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml?view=markup#l535).
 In other words, the Inventory Valuation report is broken for COGS methods of 
COGS_INV_COST or COGS_AVG_COST. 

*What should happen*

The Inventory Valuation report, and anybody else who cares, should always be 
able to trust the accounting quantity. For COGS_INV_COST and COGS_AVG_COST, 
maintaining the accounting quantity is simple - 
createAcctgTransForSalesShipmentIssuance should just adjust it to match the 
remaining quantity on hand for the InventoryItem.

So shipping an InventoryItem may cause adjustments to accounting quantities in 
other items for FIFO and LIFO, but when the COGS method is actual or average 
cost, the adjustment is always in-place - the actual InventoryItem being 
shipped.

No matter what the COGS method, the total accounting quantity for a product 
across all inventory items should always be equal to the total QOH. 

  was:
>From 
>http://ofbiz.135035.n4.nabble.com/AccountingQuantity-COGS-method-and-inventory-valuation-td4700867.html

*Why accounting quantity?*

When inventory is shipped, there's an accounting transaction that debits the 
inventory on hand value and credits Cost of Goods Sold (COGS). 

There's more than one way of deciding what value is added to COGS. 

First and most obvious is the actual cost of the inventory item. But companies 
may prefer other strategies. OFBiz has the option of three others: average 
cost, first-in-first-out or last-in-first-out. There's a nice survey of _why_ 
you might choose one of these at 

[jira] [Updated] (OFBIZ-9500) Maintain accountingQuantity for all COGS valuation methods

2017-10-11 Thread Paul Foxworthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Foxworthy updated OFBIZ-9500:
--
Description: 
>From 
>http://ofbiz.135035.n4.nabble.com/AccountingQuantity-COGS-method-and-inventory-valuation-td4700867.html

*Why accounting quantity?*

When inventory is shipped, there's an accounting transaction that debits the 
inventory on hand value and credits Cost of Goods Sold (COGS). 

There's more than one way of deciding what value is added to COGS. 

First and most obvious is the actual cost of the inventory item. But companies 
may prefer other strategies. OFBiz has the option of three others: average 
cost, first-in-first-out or last-in-first-out. There's a nice survey of _why_ 
you might choose one of these at 
http://www.dummies.com/business/operations-management/choosing-an-accounting-method-for-the-cost-of-goods-sold-expense/,
 
http://www.dummies.com/business/accounting/the-fifo-method-for-cost-of-goods-sold/,
 
http://www.dummies.com/business/accounting/the-lifo-method-for-cost-of-goods-sold/
 

Note that if you choose anything other than inventory item cost, the money 
amount transferred to the COGS account may be *different* to the cost price of 
the inventory items being shipped. When you choose FIFO or LIFO, the amount may 
have originated from a different inventory item, received at a different time. 

*Current situation in OFBiz*

The cogsMethodId field in the PartyAcctgPreference entity is a enum with four 
possible values: COGS_INV_COST, COGS_AVG_COST,  COGS_FIFO, COGS_LIFO.. 

The accountingQuantity field in the InventoryItem entity and 
accountingQuantityDiff in the InventoryItemDetail entity track the quantity of 
an item still "live" for the purpose of inventory valuation and COGS. 

In the service createAcctgTransForShipmentReceipt implemented in 
/applications/accounting/minilang/ledger/GeneralLedgerServices.xml 
(http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1306)
 

the accountingQuantity is always set to the same value as the quantity received 
(i.e. the same as the quantityOnHand) for a newly received inventory item 
regardless of the COGS method. 

When items are shipped, the service createAcctgTransForSalesShipmentIssuance 
will only reduce the accounting quantity if the COGS method is FIFO or LIFO 
(http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1127).
 With FIFO, when an item is shipped, inventory items for the product with a 
non-zero accounting quantity are found sorted from earliest to latest received. 
The quantity of the item shipped must be decremented from the accounting 
quantities, starting with the earliest. Similarly, with LIFO, items are sorted 
from latest to earliest, and the latest item or items are 
decremented. 

In other words, if you have chosen a COGS method of COGS_INV_COST or 
COGS_AVG_COST, the accounting quantity is meaningless and in OFBiz as of 
now, should be ignored. 

And yet, the Inventory Valuation report uses accounting quantity, regardless of 
the the COGS method 
(http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml?view=markup#l535).
 In other words, the Inventory Valuation report is broken for COGS methods of 
COGS_INV_COST or COGS_AVG_COST. 

*What should happen*

The Inventory Valuation report, and anybody else who cares, should always be 
able to trust the accounting quantity. For COGS_INV_COST and COGS_AVG_COST, 
maintaining the accounting quantity is simple - 
createAcctgTransForSalesShipmentIssuanceit should just adjust it to match the 
remaining quantity on hand.

No matter what the COGS method, the total accounting quantity for a product 
across all inventory items should always be equal to the total QOH. 

  was:
>From 
>http://ofbiz.135035.n4.nabble.com/AccountingQuantity-COGS-method-and-inventory-valuation-td4700867.html

*Why accounting quantity?*

When inventory is shipped, there's an accounting transaction that debits the 
inventory on hand value and credits Cost of Goods Sold (COGS). 

There's more than one way of deciding what value is added to COGS. 

First and most obvious is the actual cost of the inventory item. But companies 
may prefer other strategies. OFBiz has the option of three others: average 
cost, first-in-first-out or last-in-first-out. There's a nice survey of _why_ 
you might choose one of these at 
http://www.dummies.com/business/operations-management/choosing-an-accounting-method-for-the-cost-of-goods-sold-expense/,
 
http://www.dummies.com/business/accounting/the-fifo-method-for-cost-of-goods-sold/,
 
http://www.dummies.com/business/accounting/the-lifo-method-for-cost-of-goods-sold/
 

Note that if you choose anything other than inventory item cost, 

[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis

2017-10-11 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200456#comment-16200456
 ] 

Shi Jinghai commented on OFBIZ-9829:


Hi Michael,

Thank you for your concern!

Redis is a key-value db in memory, which makes it's the fastest way to get/set 
info. In CRM, we can get the customer info when a call in by phone number as 
Redis key, a chat in by openid and etc. In ecommerce systems of China, Redis is 
heavily used in Alibaba, JingDong, 12306, Qunar and many others to support 
rush-hour requests on products, tickets, caches and etc.

I think a Redis plugin would be very helpful to OFBiz. Please see Redis project 
on https://github.com/antirez/redis, it's very popular, over 25,000 stars and 
almost 10,000 forks.

Redis has become an important part of modern infrastructures, Amazon, Azure, 
Twitter, Youtube, SAP, I have to say, almost everybody are supporting it.

I'm sure you'll like it.

Kind Regards,


> Add a new plugin for the redis
> --
>
> Key: OFBIZ-9829
> URL: https://issues.apache.org/jira/browse/OFBIZ-9829
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Hadwin Dai
>Assignee: Shi Jinghai
>  Labels: redis
> Attachments: OFBIZ-9829_redis-plugins.patch
>
>
> Redis is an open source (BSD licensed), in-memory data structure store, used 
> as a database, cache and message broker.
> Included services: get data, set data and delete data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9674) Update build.gradle to the latest dependencies

2017-10-11 Thread Julian Leichert (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Leichert updated OFBIZ-9674:
---
Attachment: OFBIZ-9674_Update_buildgradle.patch

- removed gradle-versions-plugin from patch file

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-9674
> URL: https://issues.apache.org/jira/browse/OFBIZ-9674
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-9674_Update_buildgradle.patch
>
>
> I wondered how up-to-date our project dependencies are and searched for an 
> efficient way how to check this. I found the gradle-versions-plugin [1] which 
> analyzes the dependencies and checks if there are newer versions available.
> I ran the check with 
> {code:java}
> ./gradlew dependencyUpdates -Drevision=release
> {code}
> and got the following result:
> 
> : Project Dependency Updates (report to plain text file)
> 
> The following dependencies are using the latest release version:
>  - net.sf.barcode4j:barcode4j:2.1
>  - net.sf.barcode4j:barcode4j-fop-ext:2.1
>  - org.codeartisans.thirdparties.swing:batik-all:1.8pre-r1084380
>  - org.apache.commons:commons-collections4:4.1
>  - com.googlecode.ez-vcard:ez-vcard:0.9.10
>  - org.apache.geronimo.specs:geronimo-jms_1.1_spec:1.1.1
>  - org.apache.geronimo.components:geronimo-transaction:3.1.4
>  - at.bxm.gradleplugins:gradle-svntools-plugin:2.2.1
>  - com.github.ben-manes:gradle-versions-plugin:0.15.0
>  - org.hamcrest:hamcrest-all:1.3
>  - net.fortuna.ical4j:ical4j:1.0-rc3-atlassian-11
>  - javax.el:javax.el-api:3.0.1-b04
>  - de.odysseus.juel:juel-impl:2.2.7
>  - de.odysseus.juel:juel-spi:2.2.7
>  - junit:junit:4.12
>  - oro:oro:2.0.8
>  - apache-xerces:xercesImpl:2.9.1
> The following dependencies exceed the version found at the release revision 
> level:
>  - com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer 
> [20160628.1 <- 1.1]
> The following dependencies have later release versions:
>  - org.apache.ant:ant-junit [1.9.0 -> 1.10.1]
>  - org.apache.ant:ant-junit [1.9.7 -> 1.10.1]
>  - org.apache.axis2:axis2-kernel [1.7.1 -> 1.7.6]
>  - org.apache.axis2:axis2-transport-http [1.7.1 -> 1.7.6]
>  - org.apache.axis2:axis2-transport-local [1.7.1 -> 1.7.6]
>  - commons-cli:commons-cli [1.3.1 -> 1.4]
>  - org.apache.commons:commons-csv [1.1 -> 1.5]
>  - org.apache.commons:commons-dbcp2 [2.1 -> 2.1.1]
>  - commons-net:commons-net [3.3 -> 3.6]
>  - commons-validator:commons-validator [1.5.1 -> 1.6]
>  - com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru [1.0 -> 
> 1.4.2]
>  - com.google.zxing:core [3.2.1 -> 3.3.0]
>  - org.apache.derby:derby [10.11.1.1 -> 10.13.1.1]
>  - org.owasp.esapi:esapi [2.1.0 -> 2.1.0.1]
>  - org.apache.xmlgraphics:fop [2.1 -> 2.2]
>  - org.freemarker:freemarker [2.3.25-incubating -> 2.3.26-incubating]
>  - org.codehaus.groovy:groovy-all [2.4.12 -> 2.5.0-beta-1]
>  - org.apache.httpcomponents:httpclient-cache [4.4.1 -> 4.5.3]
>  - com.ibm.icu:icu4j [57.1 -> 59.1]
>  - com.lowagie:itext [2.1.7 -> 4.2.2]
>  - org.zapodot:jackson-databind-java-optional [2.4.2 -> 2.6.1]
>  - com.sun.mail:javax.mail [1.5.1 -> 1.6.0]
>  - javax.servlet:javax.servlet-api [3.1.0 -> 4.0.0]
>  - javax.servlet.jsp:javax.servlet.jsp-api [2.3.0 -> 2.3.2-b02]
>  - junit:junit-dep [4.10 -> 4.11]
>  - com.googlecode.libphonenumber:libphonenumber [8.6.0 -> 8.8.0]
>  - org.apache.logging.log4j:log4j-1.2-api [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-api [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-core [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-jul [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-slf4j-impl [2.6.2 -> 2.9.0]
>  - org.mockito:mockito-core [1.10.19 -> 2.9.0]
>  - org.apache.poi:poi [3.14 -> 3.17-beta1]
>  - org.apache.shiro:shiro-core [1.3.0 -> 1.4.0]
>  - org.springframework:spring-test [4.2.3.RELEASE -> 4.3.10.RELEASE]
>  - org.apache.tika:tika-core [1.12 -> 1.16]
>  - org.apache.tika:tika-parsers [1.12 -> 1.16]
>  - org.apache.tomcat:tomcat-catalina [8.5.16 -> 9.0.0.M26]
>  - org.apache.tomcat:tomcat-catalina-ha [8.5.16 -> 9.0.0.M25]
>  - org.apache.tomcat:tomcat-jasper [8.5.16 -> 9.0.0.M26]
>  - org.apache.tomcat:tomcat-tribes [8.5.16 -> 9.0.0.M25]
>  - wsdl4j:wsdl4j [1.6.2 -> 1.6.3]
>  - org.apache.xmlrpc:xmlrpc-client [3.1.2 -> 3.1.3]
>  - org.apache.xmlrpc:xmlrpc-server [3.1.2 -> 3.1.3]
>  - com.thoughtworks.xstream:xstream [1.4.9 -> 1.4.10]
> Failed to determine the latest version for the following dependencies (use 
> --info for details):
>  - 

[jira] [Updated] (OFBIZ-9674) Update build.gradle to the latest dependencies

2017-10-11 Thread Julian Leichert (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Leichert updated OFBIZ-9674:
---
Attachment: (was: OFBIZ-9674_Update_buildgradle.patch)

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-9674
> URL: https://issues.apache.org/jira/browse/OFBIZ-9674
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> I wondered how up-to-date our project dependencies are and searched for an 
> efficient way how to check this. I found the gradle-versions-plugin [1] which 
> analyzes the dependencies and checks if there are newer versions available.
> I ran the check with 
> {code:java}
> ./gradlew dependencyUpdates -Drevision=release
> {code}
> and got the following result:
> 
> : Project Dependency Updates (report to plain text file)
> 
> The following dependencies are using the latest release version:
>  - net.sf.barcode4j:barcode4j:2.1
>  - net.sf.barcode4j:barcode4j-fop-ext:2.1
>  - org.codeartisans.thirdparties.swing:batik-all:1.8pre-r1084380
>  - org.apache.commons:commons-collections4:4.1
>  - com.googlecode.ez-vcard:ez-vcard:0.9.10
>  - org.apache.geronimo.specs:geronimo-jms_1.1_spec:1.1.1
>  - org.apache.geronimo.components:geronimo-transaction:3.1.4
>  - at.bxm.gradleplugins:gradle-svntools-plugin:2.2.1
>  - com.github.ben-manes:gradle-versions-plugin:0.15.0
>  - org.hamcrest:hamcrest-all:1.3
>  - net.fortuna.ical4j:ical4j:1.0-rc3-atlassian-11
>  - javax.el:javax.el-api:3.0.1-b04
>  - de.odysseus.juel:juel-impl:2.2.7
>  - de.odysseus.juel:juel-spi:2.2.7
>  - junit:junit:4.12
>  - oro:oro:2.0.8
>  - apache-xerces:xercesImpl:2.9.1
> The following dependencies exceed the version found at the release revision 
> level:
>  - com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer 
> [20160628.1 <- 1.1]
> The following dependencies have later release versions:
>  - org.apache.ant:ant-junit [1.9.0 -> 1.10.1]
>  - org.apache.ant:ant-junit [1.9.7 -> 1.10.1]
>  - org.apache.axis2:axis2-kernel [1.7.1 -> 1.7.6]
>  - org.apache.axis2:axis2-transport-http [1.7.1 -> 1.7.6]
>  - org.apache.axis2:axis2-transport-local [1.7.1 -> 1.7.6]
>  - commons-cli:commons-cli [1.3.1 -> 1.4]
>  - org.apache.commons:commons-csv [1.1 -> 1.5]
>  - org.apache.commons:commons-dbcp2 [2.1 -> 2.1.1]
>  - commons-net:commons-net [3.3 -> 3.6]
>  - commons-validator:commons-validator [1.5.1 -> 1.6]
>  - com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru [1.0 -> 
> 1.4.2]
>  - com.google.zxing:core [3.2.1 -> 3.3.0]
>  - org.apache.derby:derby [10.11.1.1 -> 10.13.1.1]
>  - org.owasp.esapi:esapi [2.1.0 -> 2.1.0.1]
>  - org.apache.xmlgraphics:fop [2.1 -> 2.2]
>  - org.freemarker:freemarker [2.3.25-incubating -> 2.3.26-incubating]
>  - org.codehaus.groovy:groovy-all [2.4.12 -> 2.5.0-beta-1]
>  - org.apache.httpcomponents:httpclient-cache [4.4.1 -> 4.5.3]
>  - com.ibm.icu:icu4j [57.1 -> 59.1]
>  - com.lowagie:itext [2.1.7 -> 4.2.2]
>  - org.zapodot:jackson-databind-java-optional [2.4.2 -> 2.6.1]
>  - com.sun.mail:javax.mail [1.5.1 -> 1.6.0]
>  - javax.servlet:javax.servlet-api [3.1.0 -> 4.0.0]
>  - javax.servlet.jsp:javax.servlet.jsp-api [2.3.0 -> 2.3.2-b02]
>  - junit:junit-dep [4.10 -> 4.11]
>  - com.googlecode.libphonenumber:libphonenumber [8.6.0 -> 8.8.0]
>  - org.apache.logging.log4j:log4j-1.2-api [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-api [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-core [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-jul [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-slf4j-impl [2.6.2 -> 2.9.0]
>  - org.mockito:mockito-core [1.10.19 -> 2.9.0]
>  - org.apache.poi:poi [3.14 -> 3.17-beta1]
>  - org.apache.shiro:shiro-core [1.3.0 -> 1.4.0]
>  - org.springframework:spring-test [4.2.3.RELEASE -> 4.3.10.RELEASE]
>  - org.apache.tika:tika-core [1.12 -> 1.16]
>  - org.apache.tika:tika-parsers [1.12 -> 1.16]
>  - org.apache.tomcat:tomcat-catalina [8.5.16 -> 9.0.0.M26]
>  - org.apache.tomcat:tomcat-catalina-ha [8.5.16 -> 9.0.0.M25]
>  - org.apache.tomcat:tomcat-jasper [8.5.16 -> 9.0.0.M26]
>  - org.apache.tomcat:tomcat-tribes [8.5.16 -> 9.0.0.M25]
>  - wsdl4j:wsdl4j [1.6.2 -> 1.6.3]
>  - org.apache.xmlrpc:xmlrpc-client [3.1.2 -> 3.1.3]
>  - org.apache.xmlrpc:xmlrpc-server [3.1.2 -> 3.1.3]
>  - com.thoughtworks.xstream:xstream [1.4.9 -> 1.4.10]
> Failed to determine the latest version for the following dependencies (use 
> --info for details):
>  - com.sun.syndication:com.springsource.com.sun.syndication
>  - org.apache.geronimo.specs:geronimo-jaxrpc_1.1_spec
> Generated 

[jira] [Updated] (OFBIZ-9674) Update build.gradle to the latest dependencies

2017-10-11 Thread Julian Leichert (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Leichert updated OFBIZ-9674:
---
Attachment: (was: OFBIZ-9674_Update_buildgradle.patch)

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-9674
> URL: https://issues.apache.org/jira/browse/OFBIZ-9674
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-9674_Update_buildgradle.patch
>
>
> I wondered how up-to-date our project dependencies are and searched for an 
> efficient way how to check this. I found the gradle-versions-plugin [1] which 
> analyzes the dependencies and checks if there are newer versions available.
> I ran the check with 
> {code:java}
> ./gradlew dependencyUpdates -Drevision=release
> {code}
> and got the following result:
> 
> : Project Dependency Updates (report to plain text file)
> 
> The following dependencies are using the latest release version:
>  - net.sf.barcode4j:barcode4j:2.1
>  - net.sf.barcode4j:barcode4j-fop-ext:2.1
>  - org.codeartisans.thirdparties.swing:batik-all:1.8pre-r1084380
>  - org.apache.commons:commons-collections4:4.1
>  - com.googlecode.ez-vcard:ez-vcard:0.9.10
>  - org.apache.geronimo.specs:geronimo-jms_1.1_spec:1.1.1
>  - org.apache.geronimo.components:geronimo-transaction:3.1.4
>  - at.bxm.gradleplugins:gradle-svntools-plugin:2.2.1
>  - com.github.ben-manes:gradle-versions-plugin:0.15.0
>  - org.hamcrest:hamcrest-all:1.3
>  - net.fortuna.ical4j:ical4j:1.0-rc3-atlassian-11
>  - javax.el:javax.el-api:3.0.1-b04
>  - de.odysseus.juel:juel-impl:2.2.7
>  - de.odysseus.juel:juel-spi:2.2.7
>  - junit:junit:4.12
>  - oro:oro:2.0.8
>  - apache-xerces:xercesImpl:2.9.1
> The following dependencies exceed the version found at the release revision 
> level:
>  - com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer 
> [20160628.1 <- 1.1]
> The following dependencies have later release versions:
>  - org.apache.ant:ant-junit [1.9.0 -> 1.10.1]
>  - org.apache.ant:ant-junit [1.9.7 -> 1.10.1]
>  - org.apache.axis2:axis2-kernel [1.7.1 -> 1.7.6]
>  - org.apache.axis2:axis2-transport-http [1.7.1 -> 1.7.6]
>  - org.apache.axis2:axis2-transport-local [1.7.1 -> 1.7.6]
>  - commons-cli:commons-cli [1.3.1 -> 1.4]
>  - org.apache.commons:commons-csv [1.1 -> 1.5]
>  - org.apache.commons:commons-dbcp2 [2.1 -> 2.1.1]
>  - commons-net:commons-net [3.3 -> 3.6]
>  - commons-validator:commons-validator [1.5.1 -> 1.6]
>  - com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru [1.0 -> 
> 1.4.2]
>  - com.google.zxing:core [3.2.1 -> 3.3.0]
>  - org.apache.derby:derby [10.11.1.1 -> 10.13.1.1]
>  - org.owasp.esapi:esapi [2.1.0 -> 2.1.0.1]
>  - org.apache.xmlgraphics:fop [2.1 -> 2.2]
>  - org.freemarker:freemarker [2.3.25-incubating -> 2.3.26-incubating]
>  - org.codehaus.groovy:groovy-all [2.4.12 -> 2.5.0-beta-1]
>  - org.apache.httpcomponents:httpclient-cache [4.4.1 -> 4.5.3]
>  - com.ibm.icu:icu4j [57.1 -> 59.1]
>  - com.lowagie:itext [2.1.7 -> 4.2.2]
>  - org.zapodot:jackson-databind-java-optional [2.4.2 -> 2.6.1]
>  - com.sun.mail:javax.mail [1.5.1 -> 1.6.0]
>  - javax.servlet:javax.servlet-api [3.1.0 -> 4.0.0]
>  - javax.servlet.jsp:javax.servlet.jsp-api [2.3.0 -> 2.3.2-b02]
>  - junit:junit-dep [4.10 -> 4.11]
>  - com.googlecode.libphonenumber:libphonenumber [8.6.0 -> 8.8.0]
>  - org.apache.logging.log4j:log4j-1.2-api [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-api [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-core [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-jul [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-slf4j-impl [2.6.2 -> 2.9.0]
>  - org.mockito:mockito-core [1.10.19 -> 2.9.0]
>  - org.apache.poi:poi [3.14 -> 3.17-beta1]
>  - org.apache.shiro:shiro-core [1.3.0 -> 1.4.0]
>  - org.springframework:spring-test [4.2.3.RELEASE -> 4.3.10.RELEASE]
>  - org.apache.tika:tika-core [1.12 -> 1.16]
>  - org.apache.tika:tika-parsers [1.12 -> 1.16]
>  - org.apache.tomcat:tomcat-catalina [8.5.16 -> 9.0.0.M26]
>  - org.apache.tomcat:tomcat-catalina-ha [8.5.16 -> 9.0.0.M25]
>  - org.apache.tomcat:tomcat-jasper [8.5.16 -> 9.0.0.M26]
>  - org.apache.tomcat:tomcat-tribes [8.5.16 -> 9.0.0.M25]
>  - wsdl4j:wsdl4j [1.6.2 -> 1.6.3]
>  - org.apache.xmlrpc:xmlrpc-client [3.1.2 -> 3.1.3]
>  - org.apache.xmlrpc:xmlrpc-server [3.1.2 -> 3.1.3]
>  - com.thoughtworks.xstream:xstream [1.4.9 -> 1.4.10]
> Failed to determine the latest version for the following dependencies (use 
> --info for details):
>  - com.sun.syndication:com.springsource.com.sun.syndication
>  - 

[jira] [Commented] (OFBIZ-9833) Token Based Authentication

2017-10-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200420#comment-16200420
 ] 

Jacques Le Roux commented on OFBIZ-9833:


This is a quite interesting article even if it should be contextualised (no 
silver bullet): [10 Things You Should Know about Tokens| 
https://auth0.com/blog/ten-things-you-should-know-about-tokens-and-cookies/]

> Token Based Authentication
> --
>
> Key: OFBIZ-9833
> URL: https://issues.apache.org/jira/browse/OFBIZ-9833
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Deepak Dixit
>Assignee: Jacques Le Roux
> Attachments: JSON Web Tokens.pdf, Token Based Authentication in 
> Apache OfBiz.pdf, Token Based Authentication.pdf, rfc7519.pdf
>
>
> Here is dev list discussion for token based authentication work:
> http://markmail.org/message/vyskeh2wujqpkbwg



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis

2017-10-11 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200406#comment-16200406
 ] 

Michael Brohl commented on OFBIZ-9829:
--

[~shi.jinghai],

this might be a useful addition to our codebase but I really do think that we 
should discuss the addition first before adding it to the official OFBiz 
plugins repository.
This issue lacks an introduction how it is of use to the project, what should 
be achieved, how it is implemented and used within OFBiz.

We are trying hard to stabilize our codebase and assure good quality. The 
addition of a new plugin in the official codebase is nothing we should do on 
the go. 
It needs review, discussion and a consensus. Please be patient.

Until we decide the addition, please revert the commit.

Thanks and regards,
Michael


> Add a new plugin for the redis
> --
>
> Key: OFBIZ-9829
> URL: https://issues.apache.org/jira/browse/OFBIZ-9829
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Hadwin Dai
>Assignee: Shi Jinghai
>  Labels: redis
> Attachments: OFBIZ-9829_redis-plugins.patch
>
>
> Redis is an open source (BSD licensed), in-memory data structure store, used 
> as a database, cache and message broker.
> Included services: get data, set data and delete data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis

2017-10-11 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200352#comment-16200352
 ] 

Shi Jinghai commented on OFBIZ-9829:


Thank you Haipeng (代海鹏)!

This redis component is in trunk rev. 1811826.

I changed the READ.md to include some introductions on the Redis, Codis and 
Redisson.

And I changed redis port from 19000 to 6379 as well.

BTW, would you please modify the getRedisInfo and setRedisInfo to allow empty 
redis.encrypt.password and plain text values in Redis?

Regards,

> Add a new plugin for the redis
> --
>
> Key: OFBIZ-9829
> URL: https://issues.apache.org/jira/browse/OFBIZ-9829
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Hadwin Dai
>Assignee: Shi Jinghai
>  Labels: redis
> Attachments: OFBIZ-9829_redis-plugins.patch
>
>
> Redis is an open source (BSD licensed), in-memory data structure store, used 
> as a database, cache and message broker.
> Included services: get data, set data and delete data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9674) Update build.gradle to the latest dependencies

2017-10-11 Thread Julian Leichert (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Leichert updated OFBIZ-9674:
---
Attachment: (was: OFBIZ-9674_Update_buildgradle.patch)

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-9674
> URL: https://issues.apache.org/jira/browse/OFBIZ-9674
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-9674_Update_buildgradle.patch
>
>
> I wondered how up-to-date our project dependencies are and searched for an 
> efficient way how to check this. I found the gradle-versions-plugin [1] which 
> analyzes the dependencies and checks if there are newer versions available.
> I ran the check with 
> {code:java}
> ./gradlew dependencyUpdates -Drevision=release
> {code}
> and got the following result:
> 
> : Project Dependency Updates (report to plain text file)
> 
> The following dependencies are using the latest release version:
>  - net.sf.barcode4j:barcode4j:2.1
>  - net.sf.barcode4j:barcode4j-fop-ext:2.1
>  - org.codeartisans.thirdparties.swing:batik-all:1.8pre-r1084380
>  - org.apache.commons:commons-collections4:4.1
>  - com.googlecode.ez-vcard:ez-vcard:0.9.10
>  - org.apache.geronimo.specs:geronimo-jms_1.1_spec:1.1.1
>  - org.apache.geronimo.components:geronimo-transaction:3.1.4
>  - at.bxm.gradleplugins:gradle-svntools-plugin:2.2.1
>  - com.github.ben-manes:gradle-versions-plugin:0.15.0
>  - org.hamcrest:hamcrest-all:1.3
>  - net.fortuna.ical4j:ical4j:1.0-rc3-atlassian-11
>  - javax.el:javax.el-api:3.0.1-b04
>  - de.odysseus.juel:juel-impl:2.2.7
>  - de.odysseus.juel:juel-spi:2.2.7
>  - junit:junit:4.12
>  - oro:oro:2.0.8
>  - apache-xerces:xercesImpl:2.9.1
> The following dependencies exceed the version found at the release revision 
> level:
>  - com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer 
> [20160628.1 <- 1.1]
> The following dependencies have later release versions:
>  - org.apache.ant:ant-junit [1.9.0 -> 1.10.1]
>  - org.apache.ant:ant-junit [1.9.7 -> 1.10.1]
>  - org.apache.axis2:axis2-kernel [1.7.1 -> 1.7.6]
>  - org.apache.axis2:axis2-transport-http [1.7.1 -> 1.7.6]
>  - org.apache.axis2:axis2-transport-local [1.7.1 -> 1.7.6]
>  - commons-cli:commons-cli [1.3.1 -> 1.4]
>  - org.apache.commons:commons-csv [1.1 -> 1.5]
>  - org.apache.commons:commons-dbcp2 [2.1 -> 2.1.1]
>  - commons-net:commons-net [3.3 -> 3.6]
>  - commons-validator:commons-validator [1.5.1 -> 1.6]
>  - com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru [1.0 -> 
> 1.4.2]
>  - com.google.zxing:core [3.2.1 -> 3.3.0]
>  - org.apache.derby:derby [10.11.1.1 -> 10.13.1.1]
>  - org.owasp.esapi:esapi [2.1.0 -> 2.1.0.1]
>  - org.apache.xmlgraphics:fop [2.1 -> 2.2]
>  - org.freemarker:freemarker [2.3.25-incubating -> 2.3.26-incubating]
>  - org.codehaus.groovy:groovy-all [2.4.12 -> 2.5.0-beta-1]
>  - org.apache.httpcomponents:httpclient-cache [4.4.1 -> 4.5.3]
>  - com.ibm.icu:icu4j [57.1 -> 59.1]
>  - com.lowagie:itext [2.1.7 -> 4.2.2]
>  - org.zapodot:jackson-databind-java-optional [2.4.2 -> 2.6.1]
>  - com.sun.mail:javax.mail [1.5.1 -> 1.6.0]
>  - javax.servlet:javax.servlet-api [3.1.0 -> 4.0.0]
>  - javax.servlet.jsp:javax.servlet.jsp-api [2.3.0 -> 2.3.2-b02]
>  - junit:junit-dep [4.10 -> 4.11]
>  - com.googlecode.libphonenumber:libphonenumber [8.6.0 -> 8.8.0]
>  - org.apache.logging.log4j:log4j-1.2-api [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-api [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-core [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-jul [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-slf4j-impl [2.6.2 -> 2.9.0]
>  - org.mockito:mockito-core [1.10.19 -> 2.9.0]
>  - org.apache.poi:poi [3.14 -> 3.17-beta1]
>  - org.apache.shiro:shiro-core [1.3.0 -> 1.4.0]
>  - org.springframework:spring-test [4.2.3.RELEASE -> 4.3.10.RELEASE]
>  - org.apache.tika:tika-core [1.12 -> 1.16]
>  - org.apache.tika:tika-parsers [1.12 -> 1.16]
>  - org.apache.tomcat:tomcat-catalina [8.5.16 -> 9.0.0.M26]
>  - org.apache.tomcat:tomcat-catalina-ha [8.5.16 -> 9.0.0.M25]
>  - org.apache.tomcat:tomcat-jasper [8.5.16 -> 9.0.0.M26]
>  - org.apache.tomcat:tomcat-tribes [8.5.16 -> 9.0.0.M25]
>  - wsdl4j:wsdl4j [1.6.2 -> 1.6.3]
>  - org.apache.xmlrpc:xmlrpc-client [3.1.2 -> 3.1.3]
>  - org.apache.xmlrpc:xmlrpc-server [3.1.2 -> 3.1.3]
>  - com.thoughtworks.xstream:xstream [1.4.9 -> 1.4.10]
> Failed to determine the latest version for the following dependencies (use 
> --info for details):
>  - com.sun.syndication:com.springsource.com.sun.syndication
>  - 

[jira] [Updated] (OFBIZ-9674) Update build.gradle to the latest dependencies

2017-10-11 Thread Julian Leichert (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Leichert updated OFBIZ-9674:
---
Attachment: OFBIZ-9674_Update_buildgradle.patch

- Changed itext dependency to 4.2.0

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-9674
> URL: https://issues.apache.org/jira/browse/OFBIZ-9674
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-9674_Update_buildgradle.patch
>
>
> I wondered how up-to-date our project dependencies are and searched for an 
> efficient way how to check this. I found the gradle-versions-plugin [1] which 
> analyzes the dependencies and checks if there are newer versions available.
> I ran the check with 
> {code:java}
> ./gradlew dependencyUpdates -Drevision=release
> {code}
> and got the following result:
> 
> : Project Dependency Updates (report to plain text file)
> 
> The following dependencies are using the latest release version:
>  - net.sf.barcode4j:barcode4j:2.1
>  - net.sf.barcode4j:barcode4j-fop-ext:2.1
>  - org.codeartisans.thirdparties.swing:batik-all:1.8pre-r1084380
>  - org.apache.commons:commons-collections4:4.1
>  - com.googlecode.ez-vcard:ez-vcard:0.9.10
>  - org.apache.geronimo.specs:geronimo-jms_1.1_spec:1.1.1
>  - org.apache.geronimo.components:geronimo-transaction:3.1.4
>  - at.bxm.gradleplugins:gradle-svntools-plugin:2.2.1
>  - com.github.ben-manes:gradle-versions-plugin:0.15.0
>  - org.hamcrest:hamcrest-all:1.3
>  - net.fortuna.ical4j:ical4j:1.0-rc3-atlassian-11
>  - javax.el:javax.el-api:3.0.1-b04
>  - de.odysseus.juel:juel-impl:2.2.7
>  - de.odysseus.juel:juel-spi:2.2.7
>  - junit:junit:4.12
>  - oro:oro:2.0.8
>  - apache-xerces:xercesImpl:2.9.1
> The following dependencies exceed the version found at the release revision 
> level:
>  - com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer 
> [20160628.1 <- 1.1]
> The following dependencies have later release versions:
>  - org.apache.ant:ant-junit [1.9.0 -> 1.10.1]
>  - org.apache.ant:ant-junit [1.9.7 -> 1.10.1]
>  - org.apache.axis2:axis2-kernel [1.7.1 -> 1.7.6]
>  - org.apache.axis2:axis2-transport-http [1.7.1 -> 1.7.6]
>  - org.apache.axis2:axis2-transport-local [1.7.1 -> 1.7.6]
>  - commons-cli:commons-cli [1.3.1 -> 1.4]
>  - org.apache.commons:commons-csv [1.1 -> 1.5]
>  - org.apache.commons:commons-dbcp2 [2.1 -> 2.1.1]
>  - commons-net:commons-net [3.3 -> 3.6]
>  - commons-validator:commons-validator [1.5.1 -> 1.6]
>  - com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru [1.0 -> 
> 1.4.2]
>  - com.google.zxing:core [3.2.1 -> 3.3.0]
>  - org.apache.derby:derby [10.11.1.1 -> 10.13.1.1]
>  - org.owasp.esapi:esapi [2.1.0 -> 2.1.0.1]
>  - org.apache.xmlgraphics:fop [2.1 -> 2.2]
>  - org.freemarker:freemarker [2.3.25-incubating -> 2.3.26-incubating]
>  - org.codehaus.groovy:groovy-all [2.4.12 -> 2.5.0-beta-1]
>  - org.apache.httpcomponents:httpclient-cache [4.4.1 -> 4.5.3]
>  - com.ibm.icu:icu4j [57.1 -> 59.1]
>  - com.lowagie:itext [2.1.7 -> 4.2.2]
>  - org.zapodot:jackson-databind-java-optional [2.4.2 -> 2.6.1]
>  - com.sun.mail:javax.mail [1.5.1 -> 1.6.0]
>  - javax.servlet:javax.servlet-api [3.1.0 -> 4.0.0]
>  - javax.servlet.jsp:javax.servlet.jsp-api [2.3.0 -> 2.3.2-b02]
>  - junit:junit-dep [4.10 -> 4.11]
>  - com.googlecode.libphonenumber:libphonenumber [8.6.0 -> 8.8.0]
>  - org.apache.logging.log4j:log4j-1.2-api [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-api [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-core [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-jul [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-slf4j-impl [2.6.2 -> 2.9.0]
>  - org.mockito:mockito-core [1.10.19 -> 2.9.0]
>  - org.apache.poi:poi [3.14 -> 3.17-beta1]
>  - org.apache.shiro:shiro-core [1.3.0 -> 1.4.0]
>  - org.springframework:spring-test [4.2.3.RELEASE -> 4.3.10.RELEASE]
>  - org.apache.tika:tika-core [1.12 -> 1.16]
>  - org.apache.tika:tika-parsers [1.12 -> 1.16]
>  - org.apache.tomcat:tomcat-catalina [8.5.16 -> 9.0.0.M26]
>  - org.apache.tomcat:tomcat-catalina-ha [8.5.16 -> 9.0.0.M25]
>  - org.apache.tomcat:tomcat-jasper [8.5.16 -> 9.0.0.M26]
>  - org.apache.tomcat:tomcat-tribes [8.5.16 -> 9.0.0.M25]
>  - wsdl4j:wsdl4j [1.6.2 -> 1.6.3]
>  - org.apache.xmlrpc:xmlrpc-client [3.1.2 -> 3.1.3]
>  - org.apache.xmlrpc:xmlrpc-server [3.1.2 -> 3.1.3]
>  - com.thoughtworks.xstream:xstream [1.4.9 -> 1.4.10]
> Failed to determine the latest version for the following dependencies (use 
> --info for details):
>  - 

[jira] [Updated] (OFBIZ-9840) Mime Type not supported Error while generating a Composite Pdf

2017-10-11 Thread Julian Leichert (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Leichert updated OFBIZ-9840:
---
Description: 
When generating a Composite Pdf in the Content Manager an Error occurs :
Mime Type not Supported
Steps to recreate the Error Message:
  Content Manager-> CompDoc ->T ree-> View Instances-> Tree -> Generate 
Composite Pdf

Error log:
{code:java}
java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
supported
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229) 
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
 [ofbiz.jar:?]
at 
org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
 [ofbiz.jar:?]
...
{code}


  was:
When generating a Composite Pdf in the Content Manager an Error occurs :
Mime Type not Supported
Steps to recreate the Error Message:
  Content Manager-> CompDoc ->Tree-> View Instances-> Tree -> Generate 
Composite Pdf


> Mime Type not supported Error while generating a Composite Pdf
> --
>
> Key: OFBIZ-9840
> URL: https://issues.apache.org/jira/browse/OFBIZ-9840
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Julian Leichert
>
> When generating a Composite Pdf in the Content Manager an Error occurs :
> Mime Type not Supported
> Steps to recreate the Error Message:
>   Content Manager-> CompDoc ->T ree-> View Instances-> Tree -> Generate 
> Composite Pdf
> Error log:
> {code:java}
> java.lang.Exception: Error in Service [renderCompDocPdf]: Mime Type not 
> supported
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:361)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:302)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:537)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:229)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.content.compdoc.CompDocEvents.genCompDocPdf(CompDocEvents.java:171)
>  [ofbiz.jar:?]
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9840) Mime Type not supported Error while generating a Composite Pdf

2017-10-11 Thread Julian Leichert (JIRA)
Julian Leichert created OFBIZ-9840:
--

 Summary: Mime Type not supported Error while generating a 
Composite Pdf
 Key: OFBIZ-9840
 URL: https://issues.apache.org/jira/browse/OFBIZ-9840
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: Trunk
Reporter: Julian Leichert


When generating a Composite Pdf in the Content Manager an Error occurs :
Mime Type not Supported
Steps to recreate the Error Message:
  Content Manager-> CompDoc ->Tree-> View Instances-> Tree -> Generate 
Composite Pdf



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9674) Update build.gradle to the latest dependencies

2017-10-11 Thread Julian Leichert (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Leichert updated OFBIZ-9674:
---
Attachment: OFBIZ-9674_Update_buildgradle.patch

I created a patch to update the dependencies in the build.gradle, as mentioned 
above.

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-9674
> URL: https://issues.apache.org/jira/browse/OFBIZ-9674
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-9674_Update_buildgradle.patch
>
>
> I wondered how up-to-date our project dependencies are and searched for an 
> efficient way how to check this. I found the gradle-versions-plugin [1] which 
> analyzes the dependencies and checks if there are newer versions available.
> I ran the check with 
> {code:java}
> ./gradlew dependencyUpdates -Drevision=release
> {code}
> and got the following result:
> 
> : Project Dependency Updates (report to plain text file)
> 
> The following dependencies are using the latest release version:
>  - net.sf.barcode4j:barcode4j:2.1
>  - net.sf.barcode4j:barcode4j-fop-ext:2.1
>  - org.codeartisans.thirdparties.swing:batik-all:1.8pre-r1084380
>  - org.apache.commons:commons-collections4:4.1
>  - com.googlecode.ez-vcard:ez-vcard:0.9.10
>  - org.apache.geronimo.specs:geronimo-jms_1.1_spec:1.1.1
>  - org.apache.geronimo.components:geronimo-transaction:3.1.4
>  - at.bxm.gradleplugins:gradle-svntools-plugin:2.2.1
>  - com.github.ben-manes:gradle-versions-plugin:0.15.0
>  - org.hamcrest:hamcrest-all:1.3
>  - net.fortuna.ical4j:ical4j:1.0-rc3-atlassian-11
>  - javax.el:javax.el-api:3.0.1-b04
>  - de.odysseus.juel:juel-impl:2.2.7
>  - de.odysseus.juel:juel-spi:2.2.7
>  - junit:junit:4.12
>  - oro:oro:2.0.8
>  - apache-xerces:xercesImpl:2.9.1
> The following dependencies exceed the version found at the release revision 
> level:
>  - com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer 
> [20160628.1 <- 1.1]
> The following dependencies have later release versions:
>  - org.apache.ant:ant-junit [1.9.0 -> 1.10.1]
>  - org.apache.ant:ant-junit [1.9.7 -> 1.10.1]
>  - org.apache.axis2:axis2-kernel [1.7.1 -> 1.7.6]
>  - org.apache.axis2:axis2-transport-http [1.7.1 -> 1.7.6]
>  - org.apache.axis2:axis2-transport-local [1.7.1 -> 1.7.6]
>  - commons-cli:commons-cli [1.3.1 -> 1.4]
>  - org.apache.commons:commons-csv [1.1 -> 1.5]
>  - org.apache.commons:commons-dbcp2 [2.1 -> 2.1.1]
>  - commons-net:commons-net [3.3 -> 3.6]
>  - commons-validator:commons-validator [1.5.1 -> 1.6]
>  - com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru [1.0 -> 
> 1.4.2]
>  - com.google.zxing:core [3.2.1 -> 3.3.0]
>  - org.apache.derby:derby [10.11.1.1 -> 10.13.1.1]
>  - org.owasp.esapi:esapi [2.1.0 -> 2.1.0.1]
>  - org.apache.xmlgraphics:fop [2.1 -> 2.2]
>  - org.freemarker:freemarker [2.3.25-incubating -> 2.3.26-incubating]
>  - org.codehaus.groovy:groovy-all [2.4.12 -> 2.5.0-beta-1]
>  - org.apache.httpcomponents:httpclient-cache [4.4.1 -> 4.5.3]
>  - com.ibm.icu:icu4j [57.1 -> 59.1]
>  - com.lowagie:itext [2.1.7 -> 4.2.2]
>  - org.zapodot:jackson-databind-java-optional [2.4.2 -> 2.6.1]
>  - com.sun.mail:javax.mail [1.5.1 -> 1.6.0]
>  - javax.servlet:javax.servlet-api [3.1.0 -> 4.0.0]
>  - javax.servlet.jsp:javax.servlet.jsp-api [2.3.0 -> 2.3.2-b02]
>  - junit:junit-dep [4.10 -> 4.11]
>  - com.googlecode.libphonenumber:libphonenumber [8.6.0 -> 8.8.0]
>  - org.apache.logging.log4j:log4j-1.2-api [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-api [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-core [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-jul [2.6.2 -> 2.9.0]
>  - org.apache.logging.log4j:log4j-slf4j-impl [2.6.2 -> 2.9.0]
>  - org.mockito:mockito-core [1.10.19 -> 2.9.0]
>  - org.apache.poi:poi [3.14 -> 3.17-beta1]
>  - org.apache.shiro:shiro-core [1.3.0 -> 1.4.0]
>  - org.springframework:spring-test [4.2.3.RELEASE -> 4.3.10.RELEASE]
>  - org.apache.tika:tika-core [1.12 -> 1.16]
>  - org.apache.tika:tika-parsers [1.12 -> 1.16]
>  - org.apache.tomcat:tomcat-catalina [8.5.16 -> 9.0.0.M26]
>  - org.apache.tomcat:tomcat-catalina-ha [8.5.16 -> 9.0.0.M25]
>  - org.apache.tomcat:tomcat-jasper [8.5.16 -> 9.0.0.M26]
>  - org.apache.tomcat:tomcat-tribes [8.5.16 -> 9.0.0.M25]
>  - wsdl4j:wsdl4j [1.6.2 -> 1.6.3]
>  - org.apache.xmlrpc:xmlrpc-client [3.1.2 -> 3.1.3]
>  - org.apache.xmlrpc:xmlrpc-server [3.1.2 -> 3.1.3]
>  - com.thoughtworks.xstream:xstream [1.4.9 -> 1.4.10]
> Failed to determine the latest version for the following dependencies (use 
> --info for 

[jira] [Comment Edited] (OFBIZ-9839) Using try-with-resources with JDBC objects

2017-10-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200194#comment-16200194
 ] 

Jacques Le Roux edited comment on OFBIZ-9839 at 10/11/17 12:30 PM:
---

I'm all for it, please go Yash :)


was (Author: jacques.le.roux):
I'm all for it, please fo Yash :)

> Using try-with-resources with JDBC objects
> --
>
> Key: OFBIZ-9839
> URL: https://issues.apache.org/jira/browse/OFBIZ-9839
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Pradhan Yash Sharma
>
> Proposal to use try with resources for SQL objects like ResultSet and other 
> objects. SQL classes have AutoCloseable interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9839) Using try-with-resources with JDBC objects

2017-10-11 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200194#comment-16200194
 ] 

Jacques Le Roux commented on OFBIZ-9839:


I'm all for it, please fo Yash :)

> Using try-with-resources with JDBC objects
> --
>
> Key: OFBIZ-9839
> URL: https://issues.apache.org/jira/browse/OFBIZ-9839
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Pradhan Yash Sharma
>
> Proposal to use try with resources for SQL objects like ResultSet and other 
> objects. SQL classes have AutoCloseable interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9839) Using try-with-resources with JDBC objects

2017-10-11 Thread Pradhan Yash Sharma (JIRA)
Pradhan Yash Sharma created OFBIZ-9839:
--

 Summary: Using try-with-resources with JDBC objects
 Key: OFBIZ-9839
 URL: https://issues.apache.org/jira/browse/OFBIZ-9839
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Pradhan Yash Sharma
Assignee: Pradhan Yash Sharma


Proposal to use try with resources for SQL objects like ResultSet and other 
objects. SQL classes have AutoCloseable interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9827) Components loading twice while starting OFBiz

2017-10-11 Thread Pradhan Yash Sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199973#comment-16199973
 ] 

Pradhan Yash Sharma commented on OFBIZ-9827:


Hi Taher, 

I was looking through log files and went on some wrong assumptions, neither 
components nor webapps are loading twice as task repetition was so frequent 
that I assumed the whole webapp is loading twice. Task spawned after these two 
processes are repeating as shown in logs. Thank you for looking into this and 
helping me out to drill down the problem, I am looking into it will share Root 
Cause and Analysis of why some SECAs are loading multiple times or to be very 
precise why some jobs submitted to Execution pool are loading twice.

> Components loading twice while starting OFBiz
> -
>
> Key: OFBIZ-9827
> URL: https://issues.apache.org/jira/browse/OFBIZ-9827
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12, 
> Release Branch 16.11
>Reporter: Pradhan Yash Sharma
>Assignee: Pradhan Yash Sharma
> Attachments: logs.tar.gz
>
>
> Components loading multiple times while OFBiz starts. 
> While CatalinaContainer loads webapps it creates the future task, which loads 
> more than once (depends on numbers of System cores and speed). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9500) Maintain accountingQuantity for all COGS valuation methods

2017-10-11 Thread Jacopo Cappellato (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199945#comment-16199945
 ] 

Jacopo Cappellato commented on OFBIZ-9500:
--

I have voted for this issue! [~paul_foxworthy]'s description of the current 
situation and the proposed fix is perfect.
On a side note, there are other processes (alternative use cases/corner cases) 
that may introduce some errors in the accounting quantity values; but we will 
analyze and fix them after the above changes have been introduced as suggested 
by Paul.

> Maintain accountingQuantity for all COGS valuation methods
> --
>
> Key: OFBIZ-9500
> URL: https://issues.apache.org/jira/browse/OFBIZ-9500
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, order, product
>Affects Versions: Trunk
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>  Labels: accounting, inventory, stock, valuation
>
> From 
> http://ofbiz.135035.n4.nabble.com/AccountingQuantity-COGS-method-and-inventory-valuation-td4700867.html
> *Why accounting quantity?*
> When inventory is shipped, there's an accounting transaction that debits the 
> inventory on hand value and credits Cost of Goods Sold (COGS). 
> There's more than one way of deciding what value is added to COGS. 
> First and most obvious is the actual cost of the inventory item. But 
> companies may prefer other strategies. OFBiz has the option of three others: 
> average cost, first-in-first-out or last-in-first-out. There's a nice survey 
> of _why_ you might choose one of these at 
> http://www.dummies.com/business/operations-management/choosing-an-accounting-method-for-the-cost-of-goods-sold-expense/,
>  
> http://www.dummies.com/business/accounting/the-fifo-method-for-cost-of-goods-sold/,
>  
> http://www.dummies.com/business/accounting/the-lifo-method-for-cost-of-goods-sold/
>  
> Note that if you choose anything other than inventory item cost, the money 
> amount transferred to the COGS account may be *different* to the cost price 
> of the inventory items being shipped. When you choose FIFO or LIFO, the 
> amount may have originated from a different inventory item, received at a 
> different time. 
> *Current situation in OFBiz*
> The cogsMethodId field in the PartyAcctgPreference entity is a enum with four 
> possible values: COGS_INV_COST, COGS_AVG_COST,  COGS_FIFO, COGS_LIFO.. 
> The accountingQuantity field in the InventoryItem entity and 
> accountingQuantityDiff in the InventoryItemDetail entity track the quantity 
> of an item still "live" for the purpose of inventory valuation and COGS. 
> In the service createAcctgTransForShipmentReceipt implemented in 
> /applications/accounting/minilang/ledger/GeneralLedgerServices.xml 
> (http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1306)
>  
> the accountingQuantity is always set to the same value as the quantity 
> received (i.e. the same as the quantityOnHand) for a newly received inventory 
> item regardless of the COGS method. 
> When items are shipped, the service createAcctgTransForSalesShipmentIssuance 
> will only reduce the accounting quantity if the COGS method is FIFO or LIFO 
> (http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1127).
>  With FIFO, when an item is shipped, inventory items for the product with a 
> non-zero accounting quantity are found sorted from earliest to latest 
> received. The quantity of the item shipped must be decremented from the 
> accounting quantities, starting with the earliest. Similarly, with LIFO, 
> items are sorted from latest to earliest, and the latest item or items are 
> decremented. 
> In other words, if you have chosen a COGS method of COGS_INV_COST or 
> COGS_AVG_COST, the accounting quantity is meaningless and in OFBiz as of 
> now, should be ignored. 
> And yet, the Inventory Valuation report uses accounting quantity, regardless 
> of the the COGS method 
> (http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml?view=markup#l535).
>  In other words, the Inventory Valuation report is broken for COGS methods of 
> COGS_INV_COST or COGS_AVG_COST. 
> *What should happen*
> The Inventory Valuation report, and anybody else who cares, should always be 
> able to trust the accounting quantity. For COGS_INV_COST and COGS_AVG_COST, 
> maintaining the accounting quantity is simple - 
> createAcctgTransForSalesShipmentIssuanceit should just adjust it to match the 
> remaining quantity on hand.
> No matter what the COGS method, the total accounting quantity for a product 
> across all inventory items should always be equal to the total 

[jira] [Updated] (OFBIZ-9500) Maintain accountingQuantity for all COGS valuation methods

2017-10-11 Thread Paul Foxworthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Foxworthy updated OFBIZ-9500:
--
Description: 
>From 
>http://ofbiz.135035.n4.nabble.com/AccountingQuantity-COGS-method-and-inventory-valuation-td4700867.html

*Why accounting quantity?*

When inventory is shipped, there's an accounting transaction that debits the 
inventory on hand value and credits Cost of Goods Sold (COGS). 

There's more than one way of deciding what value is added to COGS. 

First and most obvious is the actual cost of the inventory item. But companies 
may prefer other strategies. OFBiz has the option of three others: average 
cost, first-in-first-out or last-in-first-out. There's a nice survey of _why_ 
you might choose one of these at 
http://www.dummies.com/business/operations-management/choosing-an-accounting-method-for-the-cost-of-goods-sold-expense/,
 
http://www.dummies.com/business/accounting/the-fifo-method-for-cost-of-goods-sold/,
 
http://www.dummies.com/business/accounting/the-lifo-method-for-cost-of-goods-sold/
 

Note that if you choose anything other than inventory item cost, the money 
amount transferred to the COGS account may be *different* to the cost price of 
the inventory items being shipped. When you choose FIFO or LIFO, the amount may 
have originated from a different inventory item, received at a different time. 

*Current situation in OFBiz*

The cogsMethodId field in the PartyAcctgPreference entity is a enum with four 
possible values: COGS_INV_COST, COGS_AVG_COST,  COGS_FIFO, COGS_LIFO.. 

The accountingQuantity field in the InventoryItem entity and 
accountingQuantityDiff in the InventoryItemDetail entity track the quantity of 
an item still "live" for the purpose of inventory valuation and COGS. 

In the service createAcctgTransForShipmentReceipt implemented in 
/applications/accounting/minilang/ledger/GeneralLedgerServices.xml 
(http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1306)
 

the accountingQuantity is always set to the same value as the quantity received 
(i.e. the same as the quantityOnHand) for a newly received inventory item 
regardless of the COGS method. 

When items are shipped, the service createAcctgTransForSalesShipmentIssuance 
will only reduce the accounting quantity if the COGS method is FIFO or LIFO 
(http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1127).
 With FIFO, when an item is shipped, inventory items for the product with a 
non-zero accounting quantity are found sorted from earliest to latest received. 
The quantity of the item shipped must be decremented from the accounting 
quantities, starting with the earliest. Similarly, with LIFO, items are sorted 
from latest to earliest, and the latest item or items are 
decremented. 

In other words, if you have chosen a COGS method of COGS_INV_COST or 
COGS_AVG_COST, the accounting quantity is meaningless and in OFBiz as of 
now, should be ignored. 

And yet, the Inventory Valuation report uses accounting quantity, regardless of 
the the COGS method 
(http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml?view=markup#l535).
 In other words, the Inventory Valuation report is broken for COGS methods of 
COGS_INV_COST or COGS_AVG_COST. 

*What should happen*

The Inventory Valuation report, and anybody else who cares, should always be 
able to trust the accounting quantity. For COGS_INV_COST and COGS_AVG_COST, 
maintaining the accounting quantity is simple - 
createAcctgTransForSalesShipmentIssuanceit should just adjust it to match the 
remaining quantity on hand.

No matter what the COGS method, the total accounting quantity for a product 
across all inventory items should always be equal to the total QOH. 

  was:
>From 
>http://ofbiz.135035.n4.nabble.com/AccountingQuantity-COGS-method-and-inventory-valuation-td4700867.html

*Why accounting quantity?*

When inventory is shipped, there's an accounting transaction that debits the 
inventory on hand value and credits Cost of Goods Sold (COGS). 

There's more than one way of deciding what value is added to COGS. 

First and most obvious is the actual cost of the inventory item. But companies 
may prefer other strategies. OFBiz has the option of three others: average 
cost, first-in-first-out or last-in-first-out. There's a nice survey of _why_ 
you might choose one of these at 
http://www.dummies.com/business/operations-management/choosing-an-accounting-method-for-the-cost-of-goods-sold-expense/,
 
http://www.dummies.com/business/accounting/the-fifo-method-for-cost-of-goods-sold/,
 
http://www.dummies.com/business/accounting/the-lifo-method-for-cost-of-goods-sold/
 

Note that if you choose anything other than inventory item cost, the money 
amount 

[jira] [Assigned] (OFBIZ-9500) Maintain accountingQuantity for all COGS valuation methods

2017-10-11 Thread Paul Foxworthy (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Foxworthy reassigned OFBIZ-9500:
-

Assignee: Paul Foxworthy

> Maintain accountingQuantity for all COGS valuation methods
> --
>
> Key: OFBIZ-9500
> URL: https://issues.apache.org/jira/browse/OFBIZ-9500
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, order, product
>Affects Versions: Trunk
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>  Labels: accounting, inventory, stock, valuation
>
> From 
> http://ofbiz.135035.n4.nabble.com/AccountingQuantity-COGS-method-and-inventory-valuation-td4700867.html
> *Why accounting quantity?*
> When inventory is shipped, there's an accounting transaction that debits the 
> inventory on hand value and credits Cost of Goods Sold (COGS). 
> There's more than one way of deciding what value is added to COGS. 
> First and most obvious is the actual cost of the inventory item. But 
> companies may prefer other strategies. OFBiz has the option of three others: 
> average cost, first-in-first-out or last-in-first-out. There's a nice survey 
> of _why_ you might choose one of these at 
> http://www.dummies.com/business/operations-management/choosing-an-accounting-method-for-the-cost-of-goods-sold-expense/,
>  
> http://www.dummies.com/business/accounting/the-fifo-method-for-cost-of-goods-sold/,
>  
> http://www.dummies.com/business/accounting/the-lifo-method-for-cost-of-goods-sold/
>  
> Note that if you choose anything other than inventory item cost, the money 
> amount transferred to the COGS account may be *different* to the cost price 
> of the inventory items being shipped. When you choose FIFO or LIFO, the 
> amount may have originated from a different inventory item, received at a 
> different time. 
> *Current situation in OFBiz*
> The cogsMethodId field in the PartyAcctgPreference entity is a enum with four 
> possible values: COGS_INV_COST, COGS_AVG_COST,  COGS_FIFO, COGS_LIFO.. 
> The accountingQuantity field in the InventoryItem entity and 
> accountingQuantityDiff in the InventoryItemDetail entity track the quantity 
> of an item still "live" for the purpose of inventory valuation and COGS. 
> In the service createAcctgTransForShipmentReceipt implemented in 
> /applications/accounting/minilang/ledger/GeneralLedgerServices.xml 
> (http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1306)
>  
> the accountingQuantity is always set to the same value as the quantity 
> received (i.e. the same as the quantityOnHand) for a newly received inventory 
> item regardless of the COGS method. 
> When items are shipped, the service createAcctgTransForSalesShipmentIssuance 
> will only reduce the accounting quantity if the COGS method is FIFO or LIFO 
> (http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?view=markup#l1127).
>  With FIFO, when an item is shipped, inventory items for the product with a 
> non-zero accounting quantity are found sorted from earliest to latest 
> received. The quantity of the item shipped must be decremented from the 
> accounting quantities, starting with the earliest. Similarly, with LIFO, 
> items are sorted from latest to earliest, and the latest item or items are 
> decremented. 
> In other words, if you have chosen a COGS method of COGS_INV_COST or 
> COGS_AVG_COST, the accounting quantity is meaningless and in OFBiz as of 
> now, should be ignored. 
> And yet, the Inventory Valuation report uses accounting quantity, regardless 
> of the the COGS method 
> (http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml?view=markup#l535).
>  In other words, the Inventory Valuation report is broken for COGS methods of 
> COGS_INV_COST or COGS_AVG_COST. 
> *What should happen*
> The Inventory Valuation report, and anybody else who cares, should always be 
> able to trust the accounting quantity. For COGS_INV_COST and COGS_AVG_COST, 
> maintaining the accounting quantity is simple - 
> createAcctgTransForSalesShipmentIssuanceit should just adjust it to match the 
> remaining quantity on hand.
> No matter what the COGS method, the total accounting quantity for a product 
> across all inventory items should always be equal to the total QOH. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9838) Purchase Order is not getting canceled automatically if all items are canceled

2017-10-11 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9838.
--
   Resolution: Fixed
Fix Version/s: 16.11.04

Thanks Renuka,

Your patch is in 
trunk r1811794  
R16.11  r1811795


> Purchase Order is not getting canceled automatically if all items are canceled
> --
>
> Key: OFBIZ-9838
> URL: https://issues.apache.org/jira/browse/OFBIZ-9838
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Renuka Srishti
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9838.patch
>
>
> Steps to regenerate:
> * Go to OrderView screen. (Purchase Order view screen)
> * Click on Edit Items.
> * Now cancel all the items.
> * Purchase Order status does not change to Cancel status.
> Reference mail [http://markmail.org/message/eghwtpym5w76bnrq]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9838) Purchase Order is not getting canceled automatically if all items are canceled

2017-10-11 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9838:
--

Assignee: Jacques Le Roux  (was: Renuka Srishti)

> Purchase Order is not getting canceled automatically if all items are canceled
> --
>
> Key: OFBIZ-9838
> URL: https://issues.apache.org/jira/browse/OFBIZ-9838
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Renuka Srishti
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-9838.patch
>
>
> Steps to regenerate:
> * Go to OrderView screen. (Purchase Order view screen)
> * Click on Edit Items.
> * Now cancel all the items.
> * Purchase Order status does not change to Cancel status.
> Reference mail [http://markmail.org/message/eghwtpym5w76bnrq]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)