[jira] [Commented] (OFBIZ-7792) Update OFBiz Website

2017-11-14 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16252174#comment-16252174
 ] 

Jacques Le Roux commented on OFBIZ-7792:


Thanks for the reminder Sharan,

At revision 1815265 I have done the point 2.4. The point 2.5 had been already 
done.

It's too much work for me to identify the useless images so I let it be.

I'll work on the point 3 later...

> Update OFBiz Website
> 
>
> Key: OFBIZ-7792
> URL: https://issues.apache.org/jira/browse/OFBIZ-7792
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Sharan Foga
>Assignee: Jacques Le Roux
>Priority: Minor
>
> The current OFBiz website needs to be updated. This JIRA covers updates 
> required to the complete site.
> HIgh Level Plan
> Phase 1: Requirements Definition : COMPLETED
> Phase 2: Design & Structure : COMPLETED
> Phase 3 Build & Construct : COMPLETED
> Phase 4: Validate & Test : COMPLETED
> Phase 5: Transition & Publish: COMPLETED
> Phase 6: Stabilisation: IN PROGRESS
> More details of around the website planning, tasks and construction can be 
> found on the wiki.
> https://cwiki.apache.org/confluence/display/OFBIZ/New+OFBiz+Website



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9980) Add ability to store latitude and longitude as well while creating postal address

2017-11-14 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251346#comment-16251346
 ] 

Jacques Le Roux commented on OFBIZ-9980:


+1 

Inspired by Google Map, I even thought to add the altitude in the past. We have 
the elevation field for that thanks to [BJ's 
proposition|http://markmail.org/message/ztgwpuwmqzbhnamn] then I went crazy in 
OFBIZ-3198 :D Long future will tell...

> Add ability to store latitude and longitude as well while creating postal 
> address
> -
>
> Key: OFBIZ-9980
> URL: https://issues.apache.org/jira/browse/OFBIZ-9980
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>
> While creating a postal address for any party or facility, we can enable 
> service to store its latitude and longitude if available and create a geo 
> point for the same. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9958) Sales by Store report calculates Value Sold incorrectly

2017-11-14 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9958.
--
   Resolution: Fixed
Fix Version/s: (was: Trunk)

Thanks Oleg, 

I did not expect you to work on this :) I also understand your argument on the 
point 1. I think it's minor but I still find weird that an offered product is 
counted w/o notice in the value sold. Anyway this is indeed intended to sales 
managers and they are certainly more interested by raw values than precise 
accounting. 

Nevertheless I find Pierre's proposition interesting and more detailled than 
mine, So Pierre, I let you decide if you wants to create a Jira for that.

For now I'm closing here.

> Sales by Store report calculates Value Sold incorrectly 
> 
>
> Key: OFBIZ-9958
> URL: https://issues.apache.org/jira/browse/OFBIZ-9958
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, Release Branch 16.11
>Reporter: Oleg Andreyev
>Assignee: Jacques Le Roux
> Fix For: Release Branch 16.11
>
> Attachments: report.diff, sales_by_store_after.png, 
> sales_by_store_before.png
>
>
> Sales by Store report calculate Value Sold without taking into account order 
> item quantity. See the first screenshot. It was 2 orders for the same product 
> priced at $10. One order had 1 of the product, second has 2 of the product. 
> Sales by Store report display correct quantity sold 3 and incorrect value 
> sold $20. I guess it should be $30.
> The Second screenshot illustrates result after the patch.
> Patch is tested with trunk and 16.11. This bug exists from the very 
> beginning.  Perhaps this is not too valuable report if the issue left 
> unnoticed for so long time. But I have been asked about it twice recently and 
> I think it's time to fix it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9981) Handle service response effectively

2017-11-14 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-9981:


 Summary: Handle service response effectively
 Key: OFBIZ-9981
 URL: https://issues.apache.org/jira/browse/OFBIZ-9981
 Project: OFBiz
  Issue Type: Bug
Reporter: Suraj Khurana
Assignee: Suraj Khurana


As per discussion on Dev ML:
==
Every service calling from java/groovy must handle errors by service util 
methods such as isError, reutrnError etc. and similarly in case of XML 


[jira] [Comment Edited] (OFBIZ-9958) Sales by Store report calculates Value Sold incorrectly

2017-11-14 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239609#comment-16239609
 ] 

Jacques Le Roux edited comment on OFBIZ-9958 at 11/14/17 10:13 AM:
---

We could indeed also close and open 2 others
# For the point I noticed
# for your suggestions Pierre
I let Oleg decides... 


was (Author: jacques.le.roux):
We could indeed also close and open 2 others
# For thepoint I noticed
# for your suggestions Pierre
I let Oleg decides... 

> Sales by Store report calculates Value Sold incorrectly 
> 
>
> Key: OFBIZ-9958
> URL: https://issues.apache.org/jira/browse/OFBIZ-9958
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, Release Branch 16.11
>Reporter: Oleg Andreyev
>Assignee: Jacques Le Roux
> Fix For: Trunk, Release Branch 16.11
>
> Attachments: report.diff, sales_by_store_after.png, 
> sales_by_store_before.png
>
>
> Sales by Store report calculate Value Sold without taking into account order 
> item quantity. See the first screenshot. It was 2 orders for the same product 
> priced at $10. One order had 1 of the product, second has 2 of the product. 
> Sales by Store report display correct quantity sold 3 and incorrect value 
> sold $20. I guess it should be $30.
> The Second screenshot illustrates result after the patch.
> Patch is tested with trunk and 16.11. This bug exists from the very 
> beginning.  Perhaps this is not too valuable report if the issue left 
> unnoticed for so long time. But I have been asked about it twice recently and 
> I think it's time to fix it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9405) refactor list related forms in PartyScreen widgets

2017-11-14 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251189#comment-16251189
 ] 

Jacques Le Roux commented on OFBIZ-9405:


Your patch was slightly deprecated due to expirePartyRate in 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/party/widget/partymgr/PartyForms.xml?r1=1799252=1799251=1799252

> refactor list related forms in PartyScreen widgets
> --
>
> Key: OFBIZ-9405
> URL: https://issues.apache.org/jira/browse/OFBIZ-9405
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: refactor, widget
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9405-party.patch
>
>
> Refactoring various list forms into grids
> Refactoring various list form references in screens



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9415) Refactor list related form widgets in various WorkEffort screens

2017-11-14 Thread Pierre Smits (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-9415:
---

Assignee: Pierre Smits  (was: Jacques Le Roux)

> Refactor list related form widgets in various WorkEffort screens
> 
>
> Key: OFBIZ-9415
> URL: https://issues.apache.org/jira/browse/OFBIZ-9415
> Project: OFBiz
>  Issue Type: Improvement
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>  Labels: refactor, widgets
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9414-WorkEffort-widget.patch
>
>
> Refactoring various list forms into grids
> Refactoring various list form references in screens



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9415) Refactor list related form widgets in various WorkEffort screens

2017-11-14 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251177#comment-16251177
 ] 

Pierre Smits commented on OFBIZ-9415:
-

Thanks Jacques.

> Refactor list related form widgets in various WorkEffort screens
> 
>
> Key: OFBIZ-9415
> URL: https://issues.apache.org/jira/browse/OFBIZ-9415
> Project: OFBiz
>  Issue Type: Improvement
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: refactor, widgets
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9414-WorkEffort-widget.patch
>
>
> Refactoring various list forms into grids
> Refactoring various list form references in screens



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9415) Refactor list related form widgets in various WorkEffort screens

2017-11-14 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9415.
--
   Resolution: Implemented
 Assignee: Jacques Le Roux  (was: Pierre Smits)
Fix Version/s: Upcoming Release

Thanks Pierre,

Your patch is in trunk at r1815194

> Refactor list related form widgets in various WorkEffort screens
> 
>
> Key: OFBIZ-9415
> URL: https://issues.apache.org/jira/browse/OFBIZ-9415
> Project: OFBiz
>  Issue Type: Improvement
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: refactor, widgets
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9414-WorkEffort-widget.patch
>
>
> Refactoring various list forms into grids
> Refactoring various list form references in screens



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9405) refactor list related forms in PartyScreen widgets

2017-11-14 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9405.
--
   Resolution: Implemented
 Assignee: Jacques Le Roux  (was: Pierre Smits)
Fix Version/s: Upcoming Release

Thanks Pierre,

Your  slightly adapted patch  because of r1799252 is in trunk at revision: 
1815193  



> refactor list related forms in PartyScreen widgets
> --
>
> Key: OFBIZ-9405
> URL: https://issues.apache.org/jira/browse/OFBIZ-9405
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: refactor, widget
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9405-party.patch
>
>
> Refactoring various list forms into grids
> Refactoring various list form references in screens



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9958) Sales by Store report calculates Value Sold incorrectly

2017-11-14 Thread Oleg Andreyev (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251151#comment-16251151
 ] 

Oleg Andreyev commented on OFBIZ-9958:
--

I appreciate your comments on this ticket and I think they would make sense 
under some circumstances. However, I don't plan to work on these. At least this 
is not a near time task. I do not see the obvious needs for these changes.

1. Given products may be viewed as a part of the promotion and thus counted in 
sales. For example, if the company gives a customer some discount then we 
calculate value including the discount and I think this is a correct way. 100% 
discount just a particular case.

2. I don't think profitability is a great concern for sales managers. While 
these reports still primitive and may be improved a lot I don't see real demand 
for this change.

I would close this issue.

> Sales by Store report calculates Value Sold incorrectly 
> 
>
> Key: OFBIZ-9958
> URL: https://issues.apache.org/jira/browse/OFBIZ-9958
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, Release Branch 16.11
>Reporter: Oleg Andreyev
>Assignee: Jacques Le Roux
> Fix For: Trunk, Release Branch 16.11
>
> Attachments: report.diff, sales_by_store_after.png, 
> sales_by_store_before.png
>
>
> Sales by Store report calculate Value Sold without taking into account order 
> item quantity. See the first screenshot. It was 2 orders for the same product 
> priced at $10. One order had 1 of the product, second has 2 of the product. 
> Sales by Store report display correct quantity sold 3 and incorrect value 
> sold $20. I guess it should be $30.
> The Second screenshot illustrates result after the patch.
> Patch is tested with trunk and 16.11. This bug exists from the very 
> beginning.  Perhaps this is not too valuable report if the issue left 
> unnoticed for so long time. But I have been asked about it twice recently and 
> I think it's time to fix it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-7792) Update OFBiz Website

2017-11-14 Thread Sharan Foga (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharan Foga reassigned OFBIZ-7792:
--

Assignee: (was: Sharan Foga)

> Update OFBiz Website
> 
>
> Key: OFBIZ-7792
> URL: https://issues.apache.org/jira/browse/OFBIZ-7792
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Sharan Foga
>Priority: Minor
>
> The current OFBiz website needs to be updated. This JIRA covers updates 
> required to the complete site.
> HIgh Level Plan
> Phase 1: Requirements Definition : COMPLETED
> Phase 2: Design & Structure : COMPLETED
> Phase 3 Build & Construct : COMPLETED
> Phase 4: Validate & Test : COMPLETED
> Phase 5: Transition & Publish: COMPLETED
> Phase 6: Stabilisation: IN PROGRESS
> More details of around the website planning, tasks and construction can be 
> found on the wiki.
> https://cwiki.apache.org/confluence/display/OFBIZ/New+OFBiz+Website



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7792) Update OFBiz Website

2017-11-14 Thread Sharan Foga (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251098#comment-16251098
 ] 

Sharan Foga commented on OFBIZ-7792:


I'll unassign myself from this issue so that anyone that wants to finish off 
anything can work on it.

> Update OFBiz Website
> 
>
> Key: OFBIZ-7792
> URL: https://issues.apache.org/jira/browse/OFBIZ-7792
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Sharan Foga
>Assignee: Sharan Foga
>Priority: Minor
>
> The current OFBiz website needs to be updated. This JIRA covers updates 
> required to the complete site.
> HIgh Level Plan
> Phase 1: Requirements Definition : COMPLETED
> Phase 2: Design & Structure : COMPLETED
> Phase 3 Build & Construct : COMPLETED
> Phase 4: Validate & Test : COMPLETED
> Phase 5: Transition & Publish: COMPLETED
> Phase 6: Stabilisation: IN PROGRESS
> More details of around the website planning, tasks and construction can be 
> found on the wiki.
> https://cwiki.apache.org/confluence/display/OFBIZ/New+OFBiz+Website



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9980) Add ability to store latitude and longitude as well while creating postal address

2017-11-14 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-9980:


 Summary: Add ability to store latitude and longitude as well while 
creating postal address
 Key: OFBIZ-9980
 URL: https://issues.apache.org/jira/browse/OFBIZ-9980
 Project: OFBiz
  Issue Type: Bug
Reporter: Suraj Khurana
Assignee: Suraj Khurana


While creating a postal address for any party or facility, we can enable 
service to store its latitude and longitude if available and create a geo point 
for the same. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)