[jira] [Comment Edited] (OFBIZ-9978) Upgrade Jquery 1.11.0 to JQuery 3.2.1

[Aditya Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266455#comment-16266455
 ] 

Aditya Sharma edited comment on OFBIZ-9978 at 11/27/17 7:30 AM:


Hi Jacques,
We were not including css file. Added a patch to add css file which will solve 
the issue. We will work on using microseconds and timezone later.
Though we have css code for date time picker in style.css (like 
themes/bluelight/webapp/bluelight/style.css) too. I am not certain if there is 
anything custom so I am not removing that right now.


was (Author: aditya.sharma):
Hi Jacques,
We were not including css files. Added a patch to add css files which will 
solve the issue. We will work on using microseconds and timezone later.
Though we have css code for date time picker in style.css (like 
themes/bluelight/webapp/bluelight/style.css) too. I am not certain if there is 
anything custom so I am not removing that right now.

> Upgrade Jquery 1.11.0 to JQuery 3.2.1
> -
>
> Key: OFBIZ-9978
> URL: https://issues.apache.org/jira/browse/OFBIZ-9978
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Attachments: Image 001.png, Image 002.png, Image 003.png, 
> OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, 
> OFBIZ-9978_plugins.patch, Screenshot-2017-11-26 OFBiz Example .png
>
>
> Migration Steps:
> 1. Upgrade JQuery 1.11.0 to 3.2.1
>   * Remove JQuery 1.x & JQuery migrate 1.x
>   * Add JQuery 3.2.1 & JQuery migrate 3.0.0
>   * Rectify any broken code and plugin
> 2. Upgrade all the JQuery plugins to latest
> 3. Remove JQuery migrate 3.0.0 & rectify any broken code



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9978) Upgrade Jquery 1.11.0 to JQuery 3.2.1

[Aditya Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9978:
-
Attachment: OFBIZ-9978.patch
OFBIZ-9978_plugins.patch

Hi Jacques,
We were not including css files. Added a patch to add css files which will 
solve the issue. We will work on using microseconds and timezone later.
Though we have css code for date time picker in style.css (like 
themes/bluelight/webapp/bluelight/style.css) too. I am not certain if there is 
anything custom so I am not removing that right now.

> Upgrade Jquery 1.11.0 to JQuery 3.2.1
> -
>
> Key: OFBIZ-9978
> URL: https://issues.apache.org/jira/browse/OFBIZ-9978
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Attachments: Image 001.png, Image 002.png, Image 003.png, 
> OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, 
> OFBIZ-9978_plugins.patch, Screenshot-2017-11-26 OFBiz Example .png
>
>
> Migration Steps:
> 1. Upgrade JQuery 1.11.0 to 3.2.1
>   * Remove JQuery 1.x & JQuery migrate 1.x
>   * Add JQuery 3.2.1 & JQuery migrate 3.0.0
>   * Rectify any broken code and plugin
> 2. Upgrade all the JQuery plugins to latest
> 3. Remove JQuery migrate 3.0.0 & rectify any broken code



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-9971) Inventory transfer creates unnecessary record with 0

[Suraj Khurana (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266433#comment-16266433
 ] 

Suraj Khurana commented on OFBIZ-9971:
--

Thanks [~pfm.smits], for the detailed information.

Do these transactions are not occurring in the current scenario? 
If everything is working fine, I think we can close this issue. :) 

> Inventory transfer creates unnecessary record with 0
> 
>
> Key: OFBIZ-9971
> URL: https://issues.apache.org/jira/browse/OFBIZ-9971
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Suraj Khurana
>Assignee: Akash Jain
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9971.patch
>
>
> While using inventory transfer for a product having multiple inventory items, 
> it creates an unnecessary record with 0 transfer quantity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-9981) Handle service response effectively

[Suraj Khurana (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266426#comment-16266426
 ] 

Suraj Khurana commented on OFBIZ-9981:
--

Thanks [~deepak.dixit],

I will upload component-wise patch from the next patch. :) 
Uploaded a patch for accounting component on OFBIZ-10021.

> Handle service response effectively
> ---
>
> Key: OFBIZ-9981
> URL: https://issues.apache.org/jira/browse/OFBIZ-9981
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-9981.patch
>
>
> As per discussion on Dev ML:
> ==
> Every service calling from java/groovy must handle errors by service util 
> methods such as isError, reutrnError etc. and similarly in case of XML 
>  executed successfully.
> Apart from this, one suggestion is to include *Debug.logError* in 
> *_ServiceUtil.returnProblem_* so that in case of any error occurred and 
> handled, it will always be logged on the console.
> ==



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (OFBIZ-9981) Handle service response effectively

[Suraj Khurana (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266425#comment-16266425
 ] 

Suraj Khurana edited comment on OFBIZ-9981 at 11/27/17 6:28 AM:


Here is the patch in which Debug.logError is added on ServiceUtil.returnProblem 
so that every return error will be also logged on the console.


was (Author: suraj.khurana):
Here is the patch in which Deb.logError is added on ServiceUtil.returnProblem 
so that every return error will be also logged on the console.

> Handle service response effectively
> ---
>
> Key: OFBIZ-9981
> URL: https://issues.apache.org/jira/browse/OFBIZ-9981
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-9981.patch
>
>
> As per discussion on Dev ML:
> ==
> Every service calling from java/groovy must handle errors by service util 
> methods such as isError, reutrnError etc. and similarly in case of XML 
>  executed successfully.
> Apart from this, one suggestion is to include *Debug.logError* in 
> *_ServiceUtil.returnProblem_* so that in case of any error occurred and 
> handled, it will always be logged on the console.
> ==



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9981) Handle service response effectively

[Suraj Khurana (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-9981:
-
Attachment: OFBIZ-9981.patch

Here is the patch in which Deb.logError is added on ServiceUtil.returnProblem 
so that every return error will be also logged on the console.

> Handle service response effectively
> ---
>
> Key: OFBIZ-9981
> URL: https://issues.apache.org/jira/browse/OFBIZ-9981
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-9981.patch
>
>
> As per discussion on Dev ML:
> ==
> Every service calling from java/groovy must handle errors by service util 
> methods such as isError, reutrnError etc. and similarly in case of XML 
>  executed successfully.
> Apart from this, one suggestion is to include *Debug.logError* in 
> *_ServiceUtil.returnProblem_* so that in case of any error occurred and 
> handled, it will always be logged on the console.
> ==



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-10021) Accounting: Handle service response effectively

[Suraj Khurana (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10021:
--
Attachment: OFBIZ-10021.patch

Here is the proposed patch for all changes.

> Accounting: Handle service response effectively
> ---
>
> Key: OFBIZ-10021
> URL: https://issues.apache.org/jira/browse/OFBIZ-10021
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-10021.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-9981) Handle service response effectively

[Deepak Dixit (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266419#comment-16266419
 ] 

Deepak Dixit commented on OFBIZ-9981:
-

Hi [~suraj.khurana]

I think instead of creating sub ticket it would be good if you upload patch 
component-wise, as there is no such major functional change that require new 
ticket :)

> Handle service response effectively
> ---
>
> Key: OFBIZ-9981
> URL: https://issues.apache.org/jira/browse/OFBIZ-9981
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>
> As per discussion on Dev ML:
> ==
> Every service calling from java/groovy must handle errors by service util 
> methods such as isError, reutrnError etc. and similarly in case of XML 
>  executed successfully.
> Apart from this, one suggestion is to include *Debug.logError* in 
> *_ServiceUtil.returnProblem_* so that in case of any error occurred and 
> handled, it will always be logged on the console.
> ==



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-10000) Remove occurrences of all deprecated delegator methods by EntityQuery methods

[Suraj Khurana (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266411#comment-16266411
 ] 

Suraj Khurana commented on OFBIZ-1:
---

:-D

> Remove occurrences of all deprecated delegator methods by EntityQuery methods
> -
>
> Key: OFBIZ-1
> URL: https://issues.apache.org/jira/browse/OFBIZ-1
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>
> There are some console warnings as well regarding this. Replace all 
> occurrences of such methods by EntityQuery methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OFBIZ-10021) Accounting: Handle service response effectively

[Suraj Khurana (JIRA)]

Suraj Khurana created OFBIZ-10021:
-

 Summary: Accounting: Handle service response effectively
 Key: OFBIZ-10021
 URL: https://issues.apache.org/jira/browse/OFBIZ-10021
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Reporter: Suraj Khurana
Assignee: Suraj Khurana






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-9981) Handle service response effectively

[Suraj Khurana (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266401#comment-16266401
 ] 

Suraj Khurana commented on OFBIZ-9981:
--

Hello,

I researched and found that there are many such occurrences of this 
improvement. I will create component-wise child tickets for the same. 

> Handle service response effectively
> ---
>
> Key: OFBIZ-9981
> URL: https://issues.apache.org/jira/browse/OFBIZ-9981
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>
> As per discussion on Dev ML:
> ==
> Every service calling from java/groovy must handle errors by service util 
> methods such as isError, reutrnError etc. and similarly in case of XML 
>  executed successfully.
> Apart from this, one suggestion is to include *Debug.logError* in 
> *_ServiceUtil.returnProblem_* so that in case of any error occurred and 
> handled, it will always be logged on the console.
> ==



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (OFBIZ-9971) Inventory transfer creates unnecessary record with 0

[Akash Jain (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reopened OFBIZ-9971:
---

Thanks Pierre Smits, I am reopening this ticket to verify this scenario and 
will take further action accordingly.

> Inventory transfer creates unnecessary record with 0
> 
>
> Key: OFBIZ-9971
> URL: https://issues.apache.org/jira/browse/OFBIZ-9971
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Suraj Khurana
>Assignee: Akash Jain
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9971.patch
>
>
> While using inventory transfer for a product having multiple inventory items, 
> it creates an unnecessary record with 0 transfer quantity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-10020) Improve groovy DSL : makeValue accept fields map and call delegator.makeValidValue

[Nicolas Malin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-10020:
--
Attachment: OFBIZ-10020.patch

> Improve groovy DSL : makeValue accept fields map and call 
> delegator.makeValidValue
> --
>
> Key: OFBIZ-10020
> URL: https://issues.apache.org/jira/browse/OFBIZ-10020
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: DSL
> Attachments: OFBIZ-10020.patch
>
>
> When you create a Generic value with groovy, you need to initial it with 
> makeValue and after set all fields.
> {code}
> GenericValue product = makeValue('Product')
> product.internalName = parameters.internalName
> {code}
> I propose to simplify this dsl with an automatic parameters check so you can 
> call directly like that :
> {code}
> GenericValue product = makeValue('Product', parameters)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OFBIZ-10020) Improve groovy DSL : makeValue accept fields map and call delegator.makeValidValue

[Nicolas Malin (JIRA)]

Nicolas Malin created OFBIZ-10020:
-

 Summary: Improve groovy DSL : makeValue accept fields map and call 
delegator.makeValidValue
 Key: OFBIZ-10020
 URL: https://issues.apache.org/jira/browse/OFBIZ-10020
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Nicolas Malin
Assignee: Nicolas Malin
Priority: Minor


When you create a Generic value with groovy, you need to initial it with 
makeValue and after set all fields.

{code}
GenericValue product = makeValue('Product')
product.internalName = parameters.internalName
{code}

I propose to simplify this dsl with an automatic parameters check so you can 
call directly like that :

{code}
GenericValue product = makeValue('Product', parameters)
{code}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

[Taher Alkhateeb (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265970#comment-16265970
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


So I think it is more important for us to make progress on this issue than to 
set policy. We are thinking together here of the best approach, but if what I 
suggest is going to slow you down considerably then please disregard it. We can 
always go back and clean it up later. The most important thing right now is to 
move the data.

With that being said, I don't have a specific strategy in my mind but perhaps 
the below items are component-specific:
- Security data: user interface security or component access security
- Component help: help on how to use the interface of a certain component
- User interface: Portlets and interfaces in the database that belongs to a 
certain screen in a certain component

So from the above, maybe we can suggest that if a certain piece of data is 
useful on its own because it adds to the domain and knowledge of the system, 
then it fits better in the data-model component. If on the other hand, this 
data is useless without that component then perhaps it belongs in that 
component.

I hope this helps? Either way, great job you guys

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-10012) Alert message : "Developer: for lookups to work you must provide a form name!" appears when try to select contentId from Lookup

[Michael Brohl (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265967#comment-16265967
 ] 

Michael Brohl commented on OFBIZ-10012:
---

This was introduced in revision 1056731.

> Alert message : "Developer: for lookups to work you must provide a form 
> name!" appears when try to select contentId from Lookup
> ---
>
> Key: OFBIZ-10012
> URL: https://issues.apache.org/jira/browse/OFBIZ-10012
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Sonal Patwari
> Attachments: ContentSearchOptionsAlertShowing (1).png
>
>
> Steps to reproduce:
> 1. Go to [Content 
> Component|https://demo-trunk.ofbiz.apache.org/content/control/main]
> 2. Click on Content from 
> [submenu|https://demo-trunk.ofbiz.apache.org/content/control/findContent].
> 3. Click on the Advanced Search button 
> [https://demo-trunk.ofbiz.apache.org/content/control/ContentSearchOptions].
> 4. Provide Content Id.
> 5. User should be able to see the alert message.
> 6. For reference screenshot is attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (OFBIZ-9978) Upgrade Jquery 1.11.0 to JQuery 3.2.1

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265963#comment-16265963
 ] 

Jacques Le Roux edited comment on OFBIZ-9978 at 11/26/17 10:59 AM:
---

Thanks Aditya,

Your patch is in trunk at revision: 1816377  

I noticed that we have to enlarge the date time picker layer or reduce the size 
of the time field: !Screenshot-2017-11-26 OFBiz Example .png!

As required with such changes I ran the createJsLanguageFileMapping  service to 
create or update the JsLanguageFilesMapping class content (this is documented 
in JsLanguageFileMappingCreator class)
We got some new ones:
-fa.js
-lv.js
-mk.js
-sl.js
-sq.js
but lost CZ (not quite sure about that one, I vaguely remember something we
discussed)



was (Author: jacques.le.roux):
Thanks Aditya,

Your patch is in trunk at revision: 1816377  

I noticed that we have to enlarge the date time picker layer or reduce the size 
of the date field: !Screenshot-2017-11-26 OFBiz Example .png!

As required with such changes I ran the createJsLanguageFileMapping  service to 
create or update the JsLanguageFilesMapping class content (this is documented 
in JsLanguageFileMappingCreator class)
We got some new ones:
-fa.js
-lv.js
-mk.js
-sl.js
-sq.js
but lost CZ (not quite sure about that one, I vaguely remember something we
discussed)


> Upgrade Jquery 1.11.0 to JQuery 3.2.1
> -
>
> Key: OFBIZ-9978
> URL: https://issues.apache.org/jira/browse/OFBIZ-9978
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Attachments: Image 001.png, Image 002.png, Image 003.png, 
> OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, 
> Screenshot-2017-11-26 OFBiz Example .png
>
>
> Migration Steps:
> 1. Upgrade JQuery 1.11.0 to 3.2.1
>   * Remove JQuery 1.x & JQuery migrate 1.x
>   * Add JQuery 3.2.1 & JQuery migrate 3.0.0
>   * Rectify any broken code and plugin
> 2. Upgrade all the JQuery plugins to latest
> 3. Remove JQuery migrate 3.0.0 & rectify any broken code



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (OFBIZ-9978) Upgrade Jquery 1.11.0 to JQuery 3.2.1

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265963#comment-16265963
 ] 

Jacques Le Roux edited comment on OFBIZ-9978 at 11/26/17 10:59 AM:
---

Thanks Aditya,

Your patch is in trunk at revision: 1816377  

I noticed that we have to enlarge the date time picker layer or reduce the size 
of the time field: !Screenshot-2017-11-26 OFBiz Example .png!

As required with such changes I ran the createJsLanguageFileMapping  service to 
update the JsLanguageFilesMapping class content (this is documented in 
JsLanguageFileMappingCreator class)
We got some new ones:
-fa.js
-lv.js
-mk.js
-sl.js
-sq.js
but lost CZ (not quite sure about that one, I vaguely remember something we
discussed)



was (Author: jacques.le.roux):
Thanks Aditya,

Your patch is in trunk at revision: 1816377  

I noticed that we have to enlarge the date time picker layer or reduce the size 
of the time field: !Screenshot-2017-11-26 OFBiz Example .png!

As required with such changes I ran the createJsLanguageFileMapping  service to 
create or update the JsLanguageFilesMapping class content (this is documented 
in JsLanguageFileMappingCreator class)
We got some new ones:
-fa.js
-lv.js
-mk.js
-sl.js
-sq.js
but lost CZ (not quite sure about that one, I vaguely remember something we
discussed)


> Upgrade Jquery 1.11.0 to JQuery 3.2.1
> -
>
> Key: OFBIZ-9978
> URL: https://issues.apache.org/jira/browse/OFBIZ-9978
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Attachments: Image 001.png, Image 002.png, Image 003.png, 
> OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, 
> Screenshot-2017-11-26 OFBiz Example .png
>
>
> Migration Steps:
> 1. Upgrade JQuery 1.11.0 to 3.2.1
>   * Remove JQuery 1.x & JQuery migrate 1.x
>   * Add JQuery 3.2.1 & JQuery migrate 3.0.0
>   * Rectify any broken code and plugin
> 2. Upgrade all the JQuery plugins to latest
> 3. Remove JQuery migrate 3.0.0 & rectify any broken code



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9978) Upgrade Jquery 1.11.0 to JQuery 3.2.1

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9978:
---
Attachment: Screenshot-2017-11-26 OFBiz Example .png

Thanks Aditya,

Your patch is in trunk at revision: 1816377  

I noticed that we have to enlarge the date time picker layer or reduce the size 
of the date field: !Screenshot-2017-11-26 OFBiz Example .png!

As required with such changes I ran the createJsLanguageFileMapping  service to 
create or update the JsLanguageFilesMapping class content (this is documented 
in JsLanguageFileMappingCreator class)
We got some new ones:
-fa.js
-lv.js
-mk.js
-sl.js
-sq.js
but lost CZ (not quite sure about that one, I vaguely remember something we
discussed)


> Upgrade Jquery 1.11.0 to JQuery 3.2.1
> -
>
> Key: OFBIZ-9978
> URL: https://issues.apache.org/jira/browse/OFBIZ-9978
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Attachments: Image 001.png, Image 002.png, Image 003.png, 
> OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, 
> Screenshot-2017-11-26 OFBiz Example .png
>
>
> Migration Steps:
> 1. Upgrade JQuery 1.11.0 to 3.2.1
>   * Remove JQuery 1.x & JQuery migrate 1.x
>   * Add JQuery 3.2.1 & JQuery migrate 3.0.0
>   * Rectify any broken code and plugin
> 2. Upgrade all the JQuery plugins to latest
> 3. Remove JQuery migrate 3.0.0 & rectify any broken code



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-10012) Alert message : "Developer: for lookups to work you must provide a form name!" appears when try to select contentId from Lookup

[Pierre Smits (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265949#comment-16265949
 ] 

Pierre Smits commented on OFBIZ-10012:
--

Nah.I just wonder when and by whom this was introduced. And which committer 
allowed this to pass. (but that is just my curiosity).

> Alert message : "Developer: for lookups to work you must provide a form 
> name!" appears when try to select contentId from Lookup
> ---
>
> Key: OFBIZ-10012
> URL: https://issues.apache.org/jira/browse/OFBIZ-10012
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Sonal Patwari
> Attachments: ContentSearchOptionsAlertShowing (1).png
>
>
> Steps to reproduce:
> 1. Go to [Content 
> Component|https://demo-trunk.ofbiz.apache.org/content/control/main]
> 2. Click on Content from 
> [submenu|https://demo-trunk.ofbiz.apache.org/content/control/findContent].
> 3. Click on the Advanced Search button 
> [https://demo-trunk.ofbiz.apache.org/content/control/ContentSearchOptions].
> 4. Provide Content Id.
> 5. User should be able to see the alert message.
> 6. For reference screenshot is attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-9905) Issue with Agreement under Accounting

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265948#comment-16265948
 ] 

Jacques Le Roux commented on OFBIZ-9905:


Hi Sourabh,

Your patch looks good and this is something which annoyed me as well back in 
the days. I went to an easier/lighter solution see 
http://svn.apache.org/viewvc?view=revision=829895
bq.  I have also modified the content of PageTitleEditAgreement label in French 
(only) because translation of the sole Edit was not enough to give some sense.

So it was only in French but we could do it in all other languages for all the 
screen you mentionned including French if I missed it somewhere, easier/lighter 
hè ?

> Issue with Agreement under Accounting
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-9905.patch, UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (OFBIZ-9905) Issue with Agreement under Accounting

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9905:
--

Assignee: sourabh jain  (was: Jacques Le Roux)

> Issue with Agreement under Accounting
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: sourabh jain
> Attachments: OFBIZ-9905.patch, UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (OFBIZ-9905) Issue with Agreement under Accounting

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9905:
--

Assignee: Jacques Le Roux  (was: sourabh jain)

> Issue with Agreement under Accounting
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-9905.patch, UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (OFBIZ-10010) No option to create the account contacts in SFA component

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10010.
---
   Resolution: Fixed
Fix Version/s: 16.11.04

Thanks Rubia and Pradeep,

Pradeep your patch is in 
trunk r1816373  
R16.11 r1816374


> No option to create the account contacts in SFA component
> -
>
> Key: OFBIZ-10010
> URL: https://issues.apache.org/jira/browse/OFBIZ-10010
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Rubia Elza Joshep
>Assignee: Jacques Le Roux
> Fix For: 16.11.04
>
> Attachments: Accountcontacts.png, Accountscontact01.png, 
> OFBIZ-10010.patch
>
>
> Steps to regenerate:
> 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/FindAccounts]
> 2) Select an account from the list or create a new account.
> 3) In the account profile page, click on "Create New" in the "List Related 
> Contacts" section.
> Actual: No option to create the account contacts.
> Expected: There should be an option to create account's contact.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (OFBIZ-10010) No option to create the account contacts in SFA component

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10010:
---

Assignee: Jacques Le Roux  (was: Pradeep Choudhary)

> No option to create the account contacts in SFA component
> -
>
> Key: OFBIZ-10010
> URL: https://issues.apache.org/jira/browse/OFBIZ-10010
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Rubia Elza Joshep
>Assignee: Jacques Le Roux
> Attachments: Accountcontacts.png, Accountscontact01.png, 
> OFBIZ-10010.patch
>
>
> Steps to regenerate:
> 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/FindAccounts]
> 2) Select an account from the list or create a new account.
> 3) In the account profile page, click on "Create New" in the "List Related 
> Contacts" section.
> Actual: No option to create the account contacts.
> Expected: There should be an option to create account's contact.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (OFBIZ-9899) UI Issue with Account Limit at Find Billing Account(s)

[Jacques Le Roux (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9899.
--
   Resolution: Fixed
Fix Version/s: 16.11.04

Thanks Aayush and Ankush 

Ankush, your patch is in 
trunk r1816369  
R16.11 r1816370


> UI Issue with Account Limit at Find Billing Account(s)
> --
>
> Key: OFBIZ-9899
> URL: https://issues.apache.org/jira/browse/OFBIZ-9899
> Project: OFBiz
>  Issue Type: Bug
> Environment: demo-trunk.ofbiz.apache.org
>Reporter: Aayush jain
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 16.11.04
>
> Attachments: Find_Billing_Account.png, OFBIZ-9899.patch
>
>
> Steps:
> 1. Open 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindBillingAccount
> 2. Navigate to Find Billing account
> 3. Check for Search Results
> Actual: At Account Limit section, symbol is been displayed
> Expected: Currency Symbols should be displayed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)