[jira] [Updated] (OFBIZ-9852) Replace Inline js with External js in makeHyperlinkString macro

2017-12-22 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9852:
-
Affects Version/s: Trunk

> Replace Inline js with External js in makeHyperlinkString macro
> ---
>
> Key: OFBIZ-9852
> URL: https://issues.apache.org/jira/browse/OFBIZ-9852
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9852.patch, OFBIZ-9852_plugins.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9852) Replace Inline js with External js in makeHyperlinkString macro

2017-12-22 Thread Aditya Sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302254#comment-16302254
 ] 

Aditya Sharma commented on OFBIZ-9852:
--

Thanks Deepak :)

> Replace Inline js with External js in makeHyperlinkString macro
> ---
>
> Key: OFBIZ-9852
> URL: https://issues.apache.org/jira/browse/OFBIZ-9852
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9852.patch, OFBIZ-9852_plugins.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10112) service:updateTextContent fails

2017-12-22 Thread Wai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wai updated OFBIZ-10112:

Attachment: OFBIZ-10112.patch

> service:updateTextContent fails
> ---
>
> Key: OFBIZ-10112
> URL: https://issues.apache.org/jira/browse/OFBIZ-10112
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Wai
> Attachments: OFBIZ-10112.patch
>
>
> service:updateTextContent  causes exception



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9852) Replace Inline js with External js in makeHyperlinkString macro

2017-12-22 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-9852.
---
   Resolution: Done
Fix Version/s: Upcoming Release

> Replace Inline js with External js in makeHyperlinkString macro
> ---
>
> Key: OFBIZ-9852
> URL: https://issues.apache.org/jira/browse/OFBIZ-9852
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9852.patch, OFBIZ-9852_plugins.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9852) Replace Inline js with External js in makeHyperlinkString macro

2017-12-22 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302237#comment-16302237
 ] 

Deepak Dixit commented on OFBIZ-9852:
-

Your patch has been committed at ofbiz framework trunk at r#1819113 and ofbiz 
plugins trunk at r#1819114

Thanks Aditya Sharma for your contribution.

> Replace Inline js with External js in makeHyperlinkString macro
> ---
>
> Key: OFBIZ-9852
> URL: https://issues.apache.org/jira/browse/OFBIZ-9852
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9852.patch, OFBIZ-9852_plugins.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component

2017-12-22 Thread Rubia Elza Joshep (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rubia Elza Joshep reassigned OFBIZ-10111:
-

Assignee: Pradeep Choudhary

> The child event added is not listed in the Child Work Efforts. While if we 
> add an existing event it is listed in the WorkEffort component
> -
>
> Key: OFBIZ-10111
> URL: https://issues.apache.org/jira/browse/OFBIZ-10111
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Reporter: Rubia Elza Joshep
>Assignee: Pradeep Choudhary
> Attachments: screenshot-1.png
>
>
> Steps to regenerate:
> 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events]
> 2) Click on the event created.
> 3) To create the child events, click on the "Children" button.
> 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill 
> in the details of the child events. Click on the Save button.
> Actual: The child event added is not listed in the Child Work Efforts. While 
> if we add an existing event it is listed.
> 5) Open URL 
> [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001]
> 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details 
> below" label is repeated twice.
> Note: ScreenShot Attached.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component

2017-12-22 Thread Rubia Elza Joshep (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rubia Elza Joshep updated OFBIZ-10111:
--
Attachment: screenshot-1.png

> The child event added is not listed in the Child Work Efforts. While if we 
> add an existing event it is listed in the WorkEffort component
> -
>
> Key: OFBIZ-10111
> URL: https://issues.apache.org/jira/browse/OFBIZ-10111
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Reporter: Rubia Elza Joshep
> Attachments: screenshot-1.png
>
>
> Steps to regenerate:
> 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events]
> 2) Click on the event created.
> 3) To create the child events, click on the "Children" button.
> 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill 
> in the details of the child events. Click on the Save button.
> Actual: The child event added is not listed in the Child Work Efforts. While 
> if we add an existing event it is listed.
> 5) Open URL 
> [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001]
> 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details 
> below" label is repeated twice.
> Note: ScreenShot Attached.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component

2017-12-22 Thread Rubia Elza Joshep (JIRA)
Rubia Elza Joshep created OFBIZ-10111:
-

 Summary: The child event added is not listed in the Child Work 
Efforts. While if we add an existing event it is listed in the WorkEffort 
component
 Key: OFBIZ-10111
 URL: https://issues.apache.org/jira/browse/OFBIZ-10111
 Project: OFBiz
  Issue Type: Bug
  Components: workeffort
Reporter: Rubia Elza Joshep


Steps to regenerate:
1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events]
2) Click on the event created.
3) To create the child events, click on the "Children" button.
4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill 
in the details of the child events. Click on the Save button.

Actual: The child event added is not listed in the Child Work Efforts. While if 
we add an existing event it is listed.

5) Open URL 
[https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001]
6) "Enter an existing workEffortId below, OR enter the WorkEffort Details 
below" label is repeated twice.

Note: ScreenShot Attached.


 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-6941) Layered-Modal link type doesn't work with parameters

2017-12-22 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302221#comment-16302221
 ] 

Arun Patidar commented on OFBIZ-6941:
-

Hi [~pfm.smits]

Are we still considering backporting in r15.12? As it is not an official 
release.

> Layered-Modal link type doesn't work with parameters
> 
>
> Key: OFBIZ-6941
> URL: https://issues.apache.org/jira/browse/OFBIZ-6941
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Arun Patidar
>  Labels: modalwindow, renderer
> Attachments: Example.png, OFBIZ-6941-Screenshot-1.png
>
>
> When having a link of type layered-modal it should with assocated parameters. 
> However the parameters aren't passed to the modal window.
> Example code:
> {code}
>  link-type="layered-modal"  width="1000" height="400">
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9852) Replace Inline js with External js in makeHyperlinkString macro

2017-12-22 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-9852:
---

Assignee: Deepak Dixit  (was: Aditya Sharma)

> Replace Inline js with External js in makeHyperlinkString macro
> ---
>
> Key: OFBIZ-9852
> URL: https://issues.apache.org/jira/browse/OFBIZ-9852
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
> Attachments: OFBIZ-9852.patch, OFBIZ-9852_plugins.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9493) Replace Masked Input Plugin with jQuery-Mask-Plugin.

2017-12-22 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9493:
-
Affects Version/s: Trunk

> Replace Masked Input Plugin with jQuery-Mask-Plugin.
> 
>
> Key: OFBIZ-9493
> URL: https://issues.apache.org/jira/browse/OFBIZ-9493
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-9493.patch, OFBIZ-9493_plugins.patch, 
> jQuery-Mask-Plugin.tar.gz
>
>
> Current plugin Masked Input  Plugin 
> (http://digitalbush.com/projects/masked-input-plugin/) can be replaced with 
> jQuery-Mask-Plugin (https://igorescobar.github.io/jQuery-Mask-Plugin/).
> * jQuery-Mask-Plugin has much better community support on GitHub while Masked 
> Input  Plugin is handled by Josh Bush on digitalbush.com. 
> * jQuery-Mask-Plugin has 135 releases while Masked Input Plugin has very few 
> releases yet.
> * Both the plugin has MIT license.
> Refer https://github.com/igorescobar/jQuery-Mask-Plugin for more features and 
> other information.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9978) Upgrade jQuery 1.11.0 to jQuery 3.2.1

2017-12-22 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9978:
-
Affects Version/s: Trunk

> Upgrade jQuery 1.11.0 to jQuery 3.2.1
> -
>
> Key: OFBIZ-9978
> URL: https://issues.apache.org/jira/browse/OFBIZ-9978
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Attachments: Image 001.png, Image 002.png, Image 003.png, Image 
> 007.png, OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, 
> OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_pluginswithReadmore2.2.0.patch, 
> OFBIZ-9978withReadmore2.2.0.patch, Readmore.tar.gz, Screenshot-2017-11-26 
> OFBiz Example .png, images.tar.gz, jquery-jgrowl.tar.gz
>
>
> Migration Steps:
> 1. Upgrade JQuery 1.11.0 to 3.2.1
>   * Remove JQuery 1.x & JQuery migrate 1.x
>   * Add JQuery 3.2.1 & JQuery migrate 3.0.0
>   * Rectify any broken code and plugin
> 2. Upgrade all the JQuery plugins to latest
> 3. Remove JQuery migrate 3.0.0 & rectify any broken code



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9978) Upgrade jQuery 1.11.0 to jQuery 3.2.1

2017-12-22 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9978:
-
Component/s: ALL APPLICATIONS

> Upgrade jQuery 1.11.0 to jQuery 3.2.1
> -
>
> Key: OFBIZ-9978
> URL: https://issues.apache.org/jira/browse/OFBIZ-9978
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
> Attachments: Image 001.png, Image 002.png, Image 003.png, Image 
> 007.png, OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, 
> OFBIZ-9978.patch, OFBIZ-9978.patch, OFBIZ-9978.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, OFBIZ-9978_plugins.patch, 
> OFBIZ-9978_plugins.patch, OFBIZ-9978_pluginswithReadmore2.2.0.patch, 
> OFBIZ-9978withReadmore2.2.0.patch, Readmore.tar.gz, Screenshot-2017-11-26 
> OFBiz Example .png, images.tar.gz, jquery-jgrowl.tar.gz
>
>
> Migration Steps:
> 1. Upgrade JQuery 1.11.0 to 3.2.1
>   * Remove JQuery 1.x & JQuery migrate 1.x
>   * Add JQuery 3.2.1 & JQuery migrate 3.0.0
>   * Rectify any broken code and plugin
> 2. Upgrade all the JQuery plugins to latest
> 3. Remove JQuery migrate 3.0.0 & rectify any broken code



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10109) Encoding issue while exporting CSV

2017-12-22 Thread Aman Agrawal (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Agrawal updated OFBIZ-10109:
-
Attachment: OFBIZ-10109.patch

Removed the encoder for the screencsv template. Now, special characters are 
rendering properly.
Attached the patch for review.

> Encoding issue while exporting CSV
> --
>
> Key: OFBIZ-10109
> URL: https://issues.apache.org/jira/browse/OFBIZ-10109
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>Assignee: Aman Agrawal
> Fix For: Trunk
>
> Attachments: OFBIZ-10109.patch
>
>
> While migrating widget.properties values in ThemeData.xml, "xml" encoder is 
> added for template "screencsv" which was not persent in the properties file. 
> By this, special character are not supported in CSV file.
> Steps to generate:
> 1. Go to  [Accounting 
> section|https://demo-trunk-ofbiz.apache.org:8443/accounting/control/main?externalLoginKey=EL3ee4435c-a117-4670-bc4b-c3f5d8b0c3f0].
> 2. Go to  [Organization GL 
> Settings|https://demo-trunk-ofbiz.apache.org:8443/accounting/control/ListCompanies].
> 3. Click on accounting in [companies 
> section|https://demo-trunk-ofbiz.apache.org:8443/accounting/control/PartyAccountsSummary].
> 4. Click on [Reports submenu 
> tab|https://demo-trunk-ofbiz.apache.org:8443/accounting/control/TrialBalance?organizationPartyId=Company].
> 5. Click on Inventory Valuation report.
> 6. Export report as CSV.
> This is committed under revision number r1806076.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-9493) Replace Masked Input Plugin with jQuery-Mask-Plugin.

2017-12-22 Thread Aditya Sharma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302213#comment-16302213
 ] 

Aditya Sharma edited comment on OFBIZ-9493 at 12/23/17 5:20 AM:


Replaced Masked Input Plugin with jQuery-Mask-Plugin 1.14.13

Verify:
Mask plugin is used with the date time picker.
Field1: date and time selection field & and Mask Field example in 
FormWidgetExamples
https://localhost:8443/example/control/FormWidgetExamples

I have changed the Default Translations for jQuery-Mask-Plugin from
"A" - Alphanumeric [A-Za-z0-9]
"0" - Numeric [0-9*]
"S" - Alphabets [A-Za-z]

to

"*" - Alphanumeric [A-Za-z0-9]
"9" - Numeric [0-9*]
"a" - Alphabets [A-Za-z]

according to the defaults in older Masked Input Plugin so that it doesn't break 
any previous code (though I have tested all the possible code occurrences & it 
works fine) as well as it makes more sense with these symbols used.



was (Author: aditya.sharma):
Replaced Masked Input Plugin with jQuery-Mask-Plugin 1.14.13

Verify:
Mask plugin is used with the date time picker.
Field1: date and time selection field & and Mask Field example in 
FormWidgetExamples
https://localhost:8443/example/control/FormWidgetExamples

I have changed the Default Translations for jQuery-Mask-Plugin from
A - Alphanumeric [A-Za-z0-9]
0 - Numeric [0-9*]
S - Alphabets [A-Za-z]

to

* - Alphanumeric [A-Za-z0-9]
9 - Numeric [0-9*]
a - Alphabets [A-Za-z]

according to the defaults in older Masked Input Plugin so that it doesn't break 
any previous code (though I have tested all the possible code occurrences & it 
works fine) as well as it makes more sense with these symbols used.


> Replace Masked Input Plugin with jQuery-Mask-Plugin.
> 
>
> Key: OFBIZ-9493
> URL: https://issues.apache.org/jira/browse/OFBIZ-9493
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-9493.patch, OFBIZ-9493_plugins.patch, 
> jQuery-Mask-Plugin.tar.gz
>
>
> Current plugin Masked Input  Plugin 
> (http://digitalbush.com/projects/masked-input-plugin/) can be replaced with 
> jQuery-Mask-Plugin (https://igorescobar.github.io/jQuery-Mask-Plugin/).
> * jQuery-Mask-Plugin has much better community support on GitHub while Masked 
> Input  Plugin is handled by Josh Bush on digitalbush.com. 
> * jQuery-Mask-Plugin has 135 releases while Masked Input Plugin has very few 
> releases yet.
> * Both the plugin has MIT license.
> Refer https://github.com/igorescobar/jQuery-Mask-Plugin for more features and 
> other information.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-10110) Update markup of Configure product page according to standard markup given by Bootstrap v4.0.0

2017-12-22 Thread Nitish Mishra (JIRA)
Nitish Mishra created OFBIZ-10110:
-

 Summary: Update markup of Configure product page according to 
standard markup given by Bootstrap v4.0.0
 Key: OFBIZ-10110
 URL: https://issues.apache.org/jira/browse/OFBIZ-10110
 Project: OFBiz
  Issue Type: Sub-task
  Components: ecommerce
Affects Versions: Trunk
Reporter: Nitish Mishra






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9493) Replace Masked Input Plugin with jQuery-Mask-Plugin.

2017-12-22 Thread Aditya Sharma (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9493:
-
Attachment: OFBIZ-9493.patch
OFBIZ-9493_plugins.patch
jQuery-Mask-Plugin.tar.gz

Replaced Masked Input Plugin with jQuery-Mask-Plugin 1.14.13

Verify:
Mask plugin is used with the date time picker.
Field1: date and time selection field & and Mask Field example in 
FormWidgetExamples
https://localhost:8443/example/control/FormWidgetExamples

I have changed the Default Translations for jQuery-Mask-Plugin from
A - Alphanumeric [A-Za-z0-9]
0 - Numeric [0-9*]
S - Alphabets [A-Za-z]

to

* - Alphanumeric [A-Za-z0-9]
9 - Numeric [0-9*]
a - Alphabets [A-Za-z]

according to the defaults in older Masked Input Plugin so that it doesn't break 
any previous code (though I have tested all the possible code occurrences & it 
works fine) as well as it makes more sense with these symbols used.


> Replace Masked Input Plugin with jQuery-Mask-Plugin.
> 
>
> Key: OFBIZ-9493
> URL: https://issues.apache.org/jira/browse/OFBIZ-9493
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-9493.patch, OFBIZ-9493_plugins.patch, 
> jQuery-Mask-Plugin.tar.gz
>
>
> Current plugin Masked Input  Plugin 
> (http://digitalbush.com/projects/masked-input-plugin/) can be replaced with 
> jQuery-Mask-Plugin (https://igorescobar.github.io/jQuery-Mask-Plugin/).
> * jQuery-Mask-Plugin has much better community support on GitHub while Masked 
> Input  Plugin is handled by Josh Bush on digitalbush.com. 
> * jQuery-Mask-Plugin has 135 releases while Masked Input Plugin has very few 
> releases yet.
> * Both the plugin has MIT license.
> Refer https://github.com/igorescobar/jQuery-Mask-Plugin for more features and 
> other information.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-10109) Encoding issue while exporting CSV

2017-12-22 Thread Aman Agrawal (JIRA)
Aman Agrawal created OFBIZ-10109:


 Summary: Encoding issue while exporting CSV
 Key: OFBIZ-10109
 URL: https://issues.apache.org/jira/browse/OFBIZ-10109
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Aman Agrawal
Assignee: Aman Agrawal
 Fix For: Trunk


While migrating widget.properties values in ThemeData.xml, "xml" encoder is 
added for template "screencsv" which was not persent in the properties file. By 
this, special character are not supported in CSV file.
Steps to generate:
1. Go to  [Accounting 
section|https://demo-trunk-ofbiz.apache.org:8443/accounting/control/main?externalLoginKey=EL3ee4435c-a117-4670-bc4b-c3f5d8b0c3f0].
2. Go to  [Organization GL 
Settings|https://demo-trunk-ofbiz.apache.org:8443/accounting/control/ListCompanies].
3. Click on accounting in [companies 
section|https://demo-trunk-ofbiz.apache.org:8443/accounting/control/PartyAccountsSummary].
4. Click on [Reports submenu 
tab|https://demo-trunk-ofbiz.apache.org:8443/accounting/control/TrialBalance?organizationPartyId=Company].
5. Click on Inventory Valuation report.
6. Export report as CSV.

This is committed under revision number r1806076.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9899) UI Issue with Account Limit at Find Billing Account(s)

2017-12-22 Thread Ankush Upadhyay (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302206#comment-16302206
 ] 

Ankush Upadhyay commented on OFBIZ-9899:


Thanks [~jacques.le.roux]

> UI Issue with Account Limit at Find Billing Account(s)
> --
>
> Key: OFBIZ-9899
> URL: https://issues.apache.org/jira/browse/OFBIZ-9899
> Project: OFBiz
>  Issue Type: Bug
> Environment: demo-trunk.ofbiz.apache.org
>Reporter: Aayush jain
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 16.11.04
>
> Attachments: Find_Billing_Account.png, OFBIZ-9899.patch
>
>
> Steps:
> 1. Open 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindBillingAccount
> 2. Navigate to Find Billing account
> 3. Check for Search Results
> Actual: At Account Limit section, symbol is been displayed
> Expected: Currency Symbols should be displayed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10108) Import file with data-file, add start-line to escape the header column line

2017-12-22 Thread Nicolas Malin (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-10108:
--
Attachment: OFBIZ-10108.patch

> Import file with data-file, add start-line to escape the header column line
> ---
>
> Key: OFBIZ-10108
> URL: https://issues.apache.org/jira/browse/OFBIZ-10108
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-10108.patch
>
>
> When you load a CSV file some time with a data-file definition, if it 
> contains some header column you can use the format attribute of you column.
> Example
> {code}
> ref;date
> 100;2017-10-10
> 200;2017-12-11
> {code}
> This definition failed
> {code}
>  delimiter=";">
> 
> 
>  position="2"/>
> 
> {code}
> You need to read the date as string and after convert it on your code to 
> escape the first line.
> To solve it I propose to add a new attribute start-line like this :
> {code}
>  *start-line="1"* delimiter=";">
> 
> 
>  position="2"/>
> 
> {code}
> I already implemented this on customer site with success



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-10108) Import file with data-file, add start-line to escape the header column line

2017-12-22 Thread Nicolas Malin (JIRA)
Nicolas Malin created OFBIZ-10108:
-

 Summary: Import file with data-file, add start-line to escape the 
header column line
 Key: OFBIZ-10108
 URL: https://issues.apache.org/jira/browse/OFBIZ-10108
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Nicolas Malin
Assignee: Nicolas Malin
Priority: Minor


When you load a CSV file some time with a data-file definition, if it contains 
some header column you can use the format attribute of you column.

Example
{code}
ref;date
100;2017-10-10
200;2017-12-11
{code}

This definition failed
{code}





{code}
You need to read the date as string and after convert it on your code to escape 
the first line.

To solve it I propose to add a new attribute start-line like this :
{code}





{code}
I already implemented this on customer site with success



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9536) IN CSV export file from record add a new attribut to select the EOL return type

2017-12-22 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9536:
---
Summary: IN CSV export file from record add a new attribut to select the 
EOL return type  (was: IN CSV export file from record add a new attribut to 
select the cariage return type)

> IN CSV export file from record add a new attribut to select the EOL return 
> type
> ---
>
> Key: OFBIZ-9536
> URL: https://issues.apache.org/jira/browse/OFBIZ-9536
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Assignee: Michael Brohl
> Attachments: ModelRecord.patch
>
>
> During the generation of a file of the type CSV via a record, it is not 
> possible to choose the type for the end of line. It is systematically of the 
> type " CR ". This patch has for objective to make possible the choice between 
> "CR" and CRLF " by the addition of an new attribute " carriageReturnType " in 
> the record tag. The value by default is "CR".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9536) IN CSV export file from record add a new attribut to select the EOL type

2017-12-22 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9536:
---
Summary: IN CSV export file from record add a new attribut to select the 
EOL type  (was: IN CSV export file from record add a new attribut to select the 
EOL return type)

> IN CSV export file from record add a new attribut to select the EOL type
> 
>
> Key: OFBIZ-9536
> URL: https://issues.apache.org/jira/browse/OFBIZ-9536
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Assignee: Michael Brohl
> Attachments: ModelRecord.patch
>
>
> During the generation of a file of the type CSV via a record, it is not 
> possible to choose the type for the end of line. It is systematically of the 
> type " CR ". This patch has for objective to make possible the choice between 
> "CR" and CRLF " by the addition of an new attribute " carriageReturnType " in 
> the record tag. The value by default is "CR".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9536) IN CSV export file from record add a new attribut to select the cariage return type

2017-12-22 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9536:
---
Summary: IN CSV export file from record add a new attribut to select the 
cariage return type  (was: IN CSV export file from record add a new attribut to 
select the caraige return type)

> IN CSV export file from record add a new attribut to select the cariage 
> return type
> ---
>
> Key: OFBIZ-9536
> URL: https://issues.apache.org/jira/browse/OFBIZ-9536
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Assignee: Michael Brohl
> Attachments: ModelRecord.patch
>
>
> During the generation of a file of the type CSV via a record, it is not 
> possible to choose the type for the end of line. It is systematically of the 
> type " CR ". This patch has for objective to make possible the choice between 
> "CR" and CRLF " by the addition of an new attribute " carriageReturnType " in 
> the record tag. The value by default is "CR".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9536) IN CSV export file from record add a new attribut to select the caraige return type

2017-12-22 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301538#comment-16301538
 ] 

Jacques Le Roux commented on OFBIZ-9536:


+1
Indeed just a bit of formatting for
bq. +if("CRLF".equals(modelRecord.getCarriageReturnType())){
Pierre you should use a formatter ;) like the one recommended at 
https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions ;)

> IN CSV export file from record add a new attribut to select the caraige 
> return type
> ---
>
> Key: OFBIZ-9536
> URL: https://issues.apache.org/jira/browse/OFBIZ-9536
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Assignee: Michael Brohl
> Attachments: ModelRecord.patch
>
>
> During the generation of a file of the type CSV via a record, it is not 
> possible to choose the type for the end of line. It is systematically of the 
> type " CR ". This patch has for objective to make possible the choice between 
> "CR" and CRLF " by the addition of an new attribute " carriageReturnType " in 
> the record tag. The value by default is "CR".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10014) Error while adding the product to the order

2017-12-22 Thread Julian Leichert (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Leichert updated OFBIZ-10014:

Attachment: (was: 
OFBIZ-10014_org.apache.ofbiz.product.price.PriceServices.patch  )

> Error while adding the product to the order 
> 
>
> Key: OFBIZ-10014
> URL: https://issues.apache.org/jira/browse/OFBIZ-10014
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Garima jain
>Assignee: Michael Brohl
> Attachments: 
> OFBIZ-10014_org.apache.ofbiz.product.price.PriceServices_fix.patch, order.png
>
>
> Steps to Generate the Issue.
> 1. Navigate to[ 
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry]
> 2. Click on Quick LookUp button and select a product (cap,dvd) and click on 
> 'Add To Order' button.
> Actual: Error occurred
> Expected: The product should be added to the order.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10014) Error while adding the product to the order

2017-12-22 Thread Julian Leichert (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Leichert updated OFBIZ-10014:

Attachment: 
OFBIZ-10014_org.apache.ofbiz.product.price.PriceServices_fix.patch

> Error while adding the product to the order 
> 
>
> Key: OFBIZ-10014
> URL: https://issues.apache.org/jira/browse/OFBIZ-10014
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Garima jain
>Assignee: Michael Brohl
> Attachments: 
> OFBIZ-10014_org.apache.ofbiz.product.price.PriceServices_fix.patch, order.png
>
>
> Steps to Generate the Issue.
> 1. Navigate to[ 
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry]
> 2. Click on Quick LookUp button and select a product (cap,dvd) and click on 
> 'Add To Order' button.
> Actual: Error occurred
> Expected: The product should be added to the order.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10014) Error while adding the product to the order

2017-12-22 Thread Julian Leichert (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Leichert updated OFBIZ-10014:

Attachment: OFBIZ-10014_org.apache.ofbiz.product.price.PriceServices.patch  

The bug occurs when you try to add a product to the shoppingcart and the 
currencyUomId does not match the currencyUomId of the cart. 
In _calculateProductPrice()_ the cart default currency was always used as the 
currency of the product, so the converting logic would never be executed. This 
patch resolves this issue.

While fixing this bug i stumbled upon another cause, but i don't know if this 
behaviour is planned.
 * If product does not have an Purchase_price, no validProductPrice is found

So my question is, should the different priceProductPurposes be added to the 
logic?

Further if the currencies don't match and they should be converted, the 
property convertProductPriceCurrency in catalog must be set to true

{code:java}
// Convert the value to the price currency, if required
if ("true".equals(EntityUtilProperties.getPropertyValue("catalog", 
"convertProductPriceCurrency",
delegator))) 
{code}


> Error while adding the product to the order 
> 
>
> Key: OFBIZ-10014
> URL: https://issues.apache.org/jira/browse/OFBIZ-10014
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Garima jain
>Assignee: Michael Brohl
> Attachments: 
> OFBIZ-10014_org.apache.ofbiz.product.price.PriceServices.patch  , order.png
>
>
> Steps to Generate the Issue.
> 1. Navigate to[ 
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry]
> 2. Click on Quick LookUp button and select a product (cap,dvd) and click on 
> 'Add To Order' button.
> Actual: Error occurred
> Expected: The product should be added to the order.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-10059) The wiki FAQ needs a serious clean up

2017-12-22 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10059:
---

Assignee: Jacques Le Roux

> The wiki FAQ needs a serious clean up
> -
>
> Key: OFBIZ-10059
> URL: https://issues.apache.org/jira/browse/OFBIZ-10059
> Project: OFBiz
>  Issue Type: Task
>  Components: Confluence
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> A lot of things are deprecated there. Also Michael suggested to split the FAQ 
> which is really long, but that should be another task after the cleanup...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9536) IN CSV export file from record add a new attribut to select the caraige return type

2017-12-22 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301138#comment-16301138
 ] 

Michael Brohl commented on OFBIZ-9536:
--

Hi Nicolas, 

the code style looks good to me, maybe except the initialization of 
carriageReturnType with "" instead of null.
If you like you can commit it along with your other improvement, no problem.

> IN CSV export file from record add a new attribut to select the caraige 
> return type
> ---
>
> Key: OFBIZ-9536
> URL: https://issues.apache.org/jira/browse/OFBIZ-9536
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Assignee: Michael Brohl
> Attachments: ModelRecord.patch
>
>
> During the generation of a file of the type CSV via a record, it is not 
> possible to choose the type for the end of line. It is systematically of the 
> type " CR ". This patch has for objective to make possible the choice between 
> "CR" and CRLF " by the addition of an new attribute " carriageReturnType " in 
> the record tag. The value by default is "CR".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)