[jira] [Comment Edited] (OFBIZ-9759) Fiscal Gl type is reflecting twice in drop-down of Cost Centers.

2018-01-02 Thread Akash Jain (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309248#comment-16309248
 ] 

Akash Jain edited comment on OFBIZ-9759 at 1/3/18 7:51 AM:
---

Thanks Wei Zhang for reporting this issue. I verified it and reopen, will 
revert this changes soon.. and will commit further after proper fix.


was (Author: akash.jain):
Thanks Wei Zhang for reporting this issue. I verified it, will revert this 
changes soon.. and will commit further after proper fix.

> Fiscal Gl type is reflecting twice in drop-down of Cost Centers.
> 
>
> Key: OFBIZ-9759
> URL: https://issues.apache.org/jira/browse/OFBIZ-9759
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
> Environment: 
> https://ofbiz-trunk.hotwaxsystems.com/accounting/control/GlAccountBalanceByCostCenter?organizationPartyId=Company
>Reporter: Tejas Khanna
>Assignee: Akash Jain
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9759.patch
>
>
> Steps to reproduce:
> 1. Select Accounting from Applications.
> 2. Select Organization GL Settings from Accounting Manager.
> 3. Click on accounting.
> 4. Click on Reports
> 5. Select Cost Centers
> 6. Choose Fiscal Gl Type drop-down.
> Actual result: on selecting Gl Type from drop-down, selected Gl Type is 
> reflecting twice.
> Expected result: Selected value should come only once in drop-down after 
> report generation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-7034) Showing QRCodes in PDF

2018-01-02 Thread Shi Jinghai (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309229#comment-16309229
 ] 

Shi Jinghai commented on OFBIZ-7034:


Hi Jacques,

I gave up modifying barcode4j to implement the 2 functions, as 
org.krysalis.barcode4j.impl.qr.QRLogicImpl has to be changed completely.

Anyway, I think this issue can be closed.

Kind Regards,

> Showing QRCodes in PDF
> --
>
> Key: OFBIZ-7034
> URL: https://issues.apache.org/jira/browse/OFBIZ-7034
> Project: OFBiz
>  Issue Type: Bug
>  Components: example
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Murugeswari
>Assignee: Shi Jinghai
> Attachments: barcode4j-trunk-zxing3.3.1-jdk8.jar
>
>
> Hi Folks,
>   I have to generate a pdf which should have Barcode as well as QRCode so 
> I followed this one OFBIZ-4154.
>   In trunk version, I run with demo data and tried to create a PDF with 
> QRCode by using this link 
> https://localhost:8443/example/control/ExampleReportPdfBarcode?exampleId=EX01.
>   But it fails to render QRCode but BarCodes are rendered successfully. 
> In console I get following error.
> {code}
>  [java] 2016-05-04 12:29:34,677 |http-nio-8080-exec-5 |ControlServlet 
>|T| [[[qrcode(Domain:http://localhost)] Request Done- 
> total:0.245,since last([qrcode(Domain:ht...):0.245]]
>  [java] 2016-05-04 12:29:34,686 |ttp-nio-8443-exec-17 |FOUserAgent
>|E| Image not available. URI: 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20.
>  Reason: org.apache.xmlgraphics.image.loader.ImageException: The file format 
> is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  (See position 43:308)
>  [java] org.apache.xmlgraphics.image.loader.ImageException: The file 
> format is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.preloadImage(ImageManager.java:181)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.cache.ImageCache.needImageInfo(ImageCache.java:128)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.getImageInfo(ImageManager.java:123)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.fop.fo.flow.ExternalGraphic.bind(ExternalGraphic.java:81) 
> [fop-2.0.jar:?]
>  [java]   at org.apache.fop.fo.FObj.processNode(FObj.java:129) 
> [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:291)
>  [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:179) 
> [fop-2.0.jar:?]
> {code}
> Same thing tested with Release15.12 here also it fails to render QRCode and 
> same exception was caught .



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-9759) Fiscal Gl type is reflecting twice in drop-down of Cost Centers.

2018-01-02 Thread Wei Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309208#comment-16309208
 ] 

Wei Zhang commented on OFBIZ-9759:
--

[~akash.jain] This fix dose not allow add a option with empty key, for example  

{code}



{code}

Is this a problem?

> Fiscal Gl type is reflecting twice in drop-down of Cost Centers.
> 
>
> Key: OFBIZ-9759
> URL: https://issues.apache.org/jira/browse/OFBIZ-9759
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
> Environment: 
> https://ofbiz-trunk.hotwaxsystems.com/accounting/control/GlAccountBalanceByCostCenter?organizationPartyId=Company
>Reporter: Tejas Khanna
>Assignee: Akash Jain
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9759.patch
>
>
> Steps to reproduce:
> 1. Select Accounting from Applications.
> 2. Select Organization GL Settings from Accounting Manager.
> 3. Click on accounting.
> 4. Click on Reports
> 5. Select Cost Centers
> 6. Choose Fiscal Gl Type drop-down.
> Actual result: on selecting Gl Type from drop-down, selected Gl Type is 
> reflecting twice.
> Expected result: Selected value should come only once in drop-down after 
> report generation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-10131) ID should be the abbreviation for identity in English

2018-01-02 Thread Jacques Le Roux (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10131:

Attachment: OFBIZ-10131.patch

Hi James, OK I got your point. You want to handle all cases that you did not 
change yet, notably those in, other languages and especially those which could 
arise in the future. It's OK with me.

Now what about the attached patch which replaces all labels ending with " Id" 
by " ID" ?

Anyway what would be your decision, please remember to close the issue when 
complete, thanks.

> ID should be the abbreviation for identity in English
> -
>
> Key: OFBIZ-10131
> URL: https://issues.apache.org/jira/browse/OFBIZ-10131
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10131.patch, OFBIZ-10131.patch
>
>
> This affects the display on the web pages. Not the naming of variables in the 
> codes.
> Will search the *Labels.xml files and replace the word 'Id' with 'ID'.
> Will also improve the logic for auto title so that labels generated for 
> variables like productTypeId will be 'Product Type ID' instead of 'Product 
> Type Id'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-10131) ID should be the abbreviation for identity in English

2018-01-02 Thread James Yong (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308793#comment-16308793
 ] 

James Yong commented on OFBIZ-10131:


The changes are now in trunk r1819906.

Thanks Jacques for the review.

> ID should be the abbreviation for identity in English
> -
>
> Key: OFBIZ-10131
> URL: https://issues.apache.org/jira/browse/OFBIZ-10131
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10131.patch
>
>
> This affects the display on the web pages. Not the naming of variables in the 
> codes.
> Will search the *Labels.xml files and replace the word 'Id' with 'ID'.
> Will also improve the logic for auto title so that labels generated for 
> variables like productTypeId will be 'Product Type ID' instead of 'Product 
> Type Id'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9464) Accounting quantity transfer should not be zero while transferring inventory from one facility to another

2018-01-02 Thread Jacopo Cappellato (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-9464:
-
Fix Version/s: (was: 16.11.04)

> Accounting quantity transfer should not be zero while transferring inventory 
> from one facility to another
> -
>
> Key: OFBIZ-9464
> URL: https://issues.apache.org/jira/browse/OFBIZ-9464
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Vaibhav Jain
>Assignee: Vaibhav Jain
>  Labels: inventory, stock, valuation
> Attachments: OFBIZ_9464.patch
>
>
> when we transfer inventory, the accountingQuantityTotal field of 
> _InventoryItem_ entity is always ZERO. There is no reflection of ATP/QOH in 
> accountingQuantityTotal.
> This will create following issues in the system.
> # Accounting quantity total will mismatch with the original quantity in the 
> facility which shows the wrong result when we calculate facility specific 
> inventory valuation.
> # Inventory reservation also throws an error in some specific case like when 
> AQT of respective product is zero in the specific facility from when 
> reservation happens.
> As we manage 5 different statuses of inventory transfer in OFBiz and 
> according to my current understanding these processes are associated with the 
> respective statuses, which are as show below
> Requested: As inventory transfer is requested for another facility. 
> a)ATP, QOH and AQT should decrease from the inventory item of From Facility 
> and QOH of To Facility should increase.
> b)ATP and AQT should be Zero in To Facility as inventory is not transferred 
> yet. But QOH should increase at To Facility because QOH shows the 
> xferquantity later. At the time of the completion of the transfer
> ATP = ATP + (QOH - ATP) (Adjustment in case of backorder)
> AQT = QOH
> b)AQT should not decrease because AQT is used for accounting purpose and as 
> of now quantity is still in From Facility as the transfer is not done yet. 
> which shows the xferQuantity later 
> Scheduled: As inventory transfer is Scheduled for another facility. ATP, QOH 
> and AQT should not affect in both From Facility and To Facility.
> En-route: As inventory is routed to reach at To Facility. Even in this case 
> ATP, QOH and AQT should not affect in both From Facility and To Facility.
> Complete: As inventory transfer is completed 
> a)ATP, QOH and AQT should not affect at From Facility. 
> b)QOH will be same but ATP and AQT should affect respectively
> ATP = ATP + (QOH - ATP)
> AQT = QOH
> Cancelled: As inventory transfer is cancelled and inventory item record is 
> already created  so 
> a) ATP, QOH and AQT should decrease from old inventory item and ATP, QOH and 
> AQT should increase in the newly created inventory item.
> Key points: 
> If the whole ATP and QOH is moved then new inventory item will not create. 
> Only Facility and location are changed for existing inventory item.
> Before Changes:-
> As I know there are following processes are associated with respective 
> statuses 
> **Note:   ATP-> Available to promiseQOH-> Quantity on handAQT-> 
> Accounting quantity total
> 1. Requested:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 2. Scheduled:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 3.En-Route:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 4.Complete:-
> If the partial quantity of any inventory item is transferred.
> ATP =Transferred quantity   QOH=Transferred quantity   AQT=0
> If the whole quantity is transferred then only facility id and location 
> will change no new inventory item record will create. 
> 5.Cancelled:-
> No new inventory item record will create. An inventory transfer record is 
> created with whole ATP/QOH in cancelled status.
> After Changes:-
> As shown above, accounting quantity transfer will not affect in transfer 
> inventory. After the following changes, records will be updated a shown below.
> 1. Requested:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 2. Scheduled:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 3.En-Route:-
> ATP =0QOH=Transferred quantity
>AQT=0
> 4.Complete:-
> If the partial quantity of any inventory item is transferred.
> ATP =Transferred quantity   QOH=Transferred quantity   
> AQT=Transferred quantity
> If the whole quantity is transferred then only facility id and location 
> will change no new inventory item record will create. 
> 5.Cancelled:-
>

[jira] [Updated] (OFBIZ-5701) Bug SQL Count Distinct command in GenericDAO.java

2018-01-02 Thread Jacopo Cappellato (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-5701:
-
Fix Version/s: (was: 16.11.04)
   (was: Release Branch 15.12)
   (was: Release Branch 14.12)
   (was: Release Branch 13.07)

> Bug SQL Count Distinct command in GenericDAO.java 
> --
>
> Key: OFBIZ-5701
> URL: https://issues.apache.org/jira/browse/OFBIZ-5701
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: kieuanhvu
> Attachments: GenericDAO.java.patch, GenericDAO.java.patch, 
> SQLDistinctGenericDAO.diff, SQLDistinctGenericDAO.diff
>
>
> I have encounter the problem is: How can ofbiz framework count distinct for 
> all selected fields in query function of delegator? Although 
> EntityFindOptions.setDistinct(true) and the selected fields are all field, 
> the ofbiz framework always count distinct follow only one field.
> I have resolved problem as my attact file



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9966) Secure the login.secret_key_string

2018-01-02 Thread Jacopo Cappellato (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-9966:
-
Fix Version/s: (was: 16.11.04)

> Secure the login.secret_key_string
> --
>
> Key: OFBIZ-9966
> URL: https://issues.apache.org/jira/browse/OFBIZ-9966
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> When OFBIZ-4983 was implemented I missed that we put the 
> login.secret_key_string as a property in security properties. This should not 
> have been because it eases attackers work.
> The recommended way is to have it as a private static final String that can 
> be changed just when compiling using sed and uuidgen. So then the key is 
> temporay and final and it gets quite harder for a possible attacker to use 
> this mean.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (OFBIZ-9971) Inventory transfer creates unnecessary record with 0

2018-01-02 Thread Jacopo Cappellato (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato resolved OFBIZ-9971.
--
Resolution: Fixed

I am marking this issue as resolved because from the comments it seems that the 
original issue has been fixed by the commit. Any additional issues can be 
reported on new tickets.

> Inventory transfer creates unnecessary record with 0
> 
>
> Key: OFBIZ-9971
> URL: https://issues.apache.org/jira/browse/OFBIZ-9971
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Suraj Khurana
>Assignee: Akash Jain
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9971.patch
>
>
> While using inventory transfer for a product having multiple inventory items, 
> it creates an unnecessary record with 0 transfer quantity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-10136) Update markup of Quick Checkout Page according to standard markup given by Bootstrap v4.0.0

2018-01-02 Thread Mayank Lambhate (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mayank Lambhate updated OFBIZ-10136:

Attachment: OFBIZ-10136.patch

> Update markup of Quick Checkout Page according to standard markup given by 
> Bootstrap v4.0.0
> ---
>
> Key: OFBIZ-10136
> URL: https://issues.apache.org/jira/browse/OFBIZ-10136
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Release Branch 16.11
>Reporter: Mayank Lambhate
> Attachments: OFBIZ-10136.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OFBIZ-10136) Update markup of Quick Checkout Page according to standard markup given by Bootstrap v4.0.0

2018-01-02 Thread Mayank Lambhate (JIRA) 
Mayank Lambhate created OFBIZ-10136:
---

 Summary: Update markup of Quick Checkout Page according to 
standard markup given by Bootstrap v4.0.0
 Key: OFBIZ-10136
 URL: https://issues.apache.org/jira/browse/OFBIZ-10136
 Project: OFBiz
  Issue Type: Sub-task
  Components: ecommerce
Affects Versions: Release Branch 16.11
Reporter: Mayank Lambhate






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (OFBIZ-10131) ID should be the abbreviation for identity in English

2018-01-02 Thread James Yong (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307597#comment-16307597
 ] 

James Yong edited comment on OFBIZ-10131 at 1/2/18 12:57 PM:
-

Hi Jacques,

English is the language to fallback on if labels cannot be found for 
non-English locale.
So the check for the English language is not used in ModelFormField.java.
IMHO, would be easier to add language-check for exceptions. 

Regards,
James



was (Author: jamesyong):
Hi Jacques,

English is the language to fallback on if labels cannot be found for 
non-English locale.
So the check for the English language is not used in ModelFormField.java.
IMHO, would be easier to add language-check for exceptional cases. 

Regards,
James


> ID should be the abbreviation for identity in English
> -
>
> Key: OFBIZ-10131
> URL: https://issues.apache.org/jira/browse/OFBIZ-10131
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-10131.patch
>
>
> This affects the display on the web pages. Not the naming of variables in the 
> codes.
> Will search the *Labels.xml files and replace the word 'Id' with 'ID'.
> Will also improve the logic for auto title so that labels generated for 
> variables like productTypeId will be 'Product Type ID' instead of 'Product 
> Type Id'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-7073) Add WebSocket support in OFBiz

2018-01-02 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307961#comment-16307961
 ] 

Jacques Le Roux commented on OFBIZ-7073:


Forgot to say that for testing OFBIZ-7467 can be used (no time atm)

> Add WebSocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-7073.patch, OFBIZ-7073.patch, 
> tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-7538) Add Wiki page for WebSocket usage

2018-01-02 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307958#comment-16307958
 ] 

Jacques Le Roux commented on OFBIZ-7538:


HI Amardeep, you got another chance ;) Else please close

> Add Wiki page for WebSocket usage
> -
>
> Key: OFBIZ-7538
> URL: https://issues.apache.org/jira/browse/OFBIZ-7538
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-7073) Add WebSocket support in OFBiz

2018-01-02 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307957#comment-16307957
 ] 

Jacques Le Roux commented on OFBIZ-7073:


This was my bad at OFBIZ-7776, it must have been done inadvertently :(

Fixed in
trunk r1819811
R17 r1819812
R16 r1819814

Though I'm pretty sure about the fix, I did not check it was the only this one. 
Please websocket users check and close if OK

> Add WebSocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-7073.patch, OFBIZ-7073.patch, 
> tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (OFBIZ-10132) Make the number of initially visible applications in main menu a properties

2018-01-02 Thread Jacques Le Roux (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10132.
---
Resolution: Implemented

Fixed in
trunk r1819800+1819805
R17.12 r1819806

I decided to backport to R17 because I think it's a pretty useful feature w/o 
risks

I also changed the related comment in French to English

> Make the number of initially visible applications in main menu a properties
> ---
>
> Key: OFBIZ-10132
> URL: https://issues.apache.org/jira/browse/OFBIZ-10132
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Release
>
>
> Currently the number of initially visible applications is hardcoded to 8 in 
> TopAppBar.ftl



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-10135) Update markup of OrderHistory page according to standard markup given by Bootstrap v4.0.0

2018-01-02 Thread Nitish Mishra (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitish Mishra updated OFBIZ-10135:
--
Attachment: OFBIZ-10135.patch

> Update markup of OrderHistory page according to standard markup given by 
> Bootstrap v4.0.0
> -
>
> Key: OFBIZ-10135
> URL: https://issues.apache.org/jira/browse/OFBIZ-10135
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Nitish Mishra
>Assignee: Nitish Mishra
> Attachments: OFBIZ-10135.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-10135) Update markup of OrderHistory page according to standard markup given by Bootstrap v4.0.0

2018-01-02 Thread Nitish Mishra (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitish Mishra updated OFBIZ-10135:
--
Attachment: (was: OFBIZ-10135.patch)

> Update markup of OrderHistory page according to standard markup given by 
> Bootstrap v4.0.0
> -
>
> Key: OFBIZ-10135
> URL: https://issues.apache.org/jira/browse/OFBIZ-10135
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Nitish Mishra
>Assignee: Nitish Mishra
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9506) OFBIZ-6964: Implementation to support replenishment planning through any inter-company facility

2018-01-02 Thread Yashwant Dhakad (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad updated OFBIZ-9506:
---
Attachment: (was: OFBIZ-9506.patch)

> OFBIZ-6964: Implementation to support replenishment planning through any 
> inter-company facility
> ---
>
> Key: OFBIZ-9506
> URL: https://issues.apache.org/jira/browse/OFBIZ-9506
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Reporter: Swapnil M Mane
>Assignee: Yashwant Dhakad
> Attachments: OFBIZ-9506.patch
>
>
> For support of replenishment planning through any inter-company facility, 
> This task is for the code implementation on the basis of design/information 
> shared in the ticket https://issues.apache.org/jira/browse/OFBIZ-7356.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9506) OFBIZ-6964: Implementation to support replenishment planning through any inter-company facility

2018-01-02 Thread Yashwant Dhakad (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad updated OFBIZ-9506:
---
Attachment: OFBIZ-9506.patch

> OFBIZ-6964: Implementation to support replenishment planning through any 
> inter-company facility
> ---
>
> Key: OFBIZ-9506
> URL: https://issues.apache.org/jira/browse/OFBIZ-9506
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Reporter: Swapnil M Mane
>Assignee: Yashwant Dhakad
> Attachments: OFBIZ-9506.patch
>
>
> For support of replenishment planning through any inter-company facility, 
> This task is for the code implementation on the basis of design/information 
> shared in the ticket https://issues.apache.org/jira/browse/OFBIZ-7356.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (OFBIZ-7467) WebSocket Example - Push Notifications

2018-01-02 Thread Jacques Le Roux (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-7467:


I reopen because of the issue mentionned in OFBIZ-7073

> WebSocket Example - Push Notifications
> --
>
> Key: OFBIZ-7467
> URL: https://issues.apache.org/jira/browse/OFBIZ-7467
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: 16.11.01
>
> Attachments: OFBIZ-7467.patch, OFBIZ-7483-Screen-Shot.png
>
>
> This is a ticket for adding working example (in example application) of 
> WebSocket support that has been done in OFBIZ-7073



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (OFBIZ-7073) Add WebSocket support in OFBiz

2018-01-02 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307841#comment-16307841
 ] 

Jacques Le Roux edited comment on OFBIZ-7073 at 1/2/18 10:25 AM:
-

I reopen I know why [websocket no longer 
works|http://markmail.org/message/2i7mumndgsvnitas].

In FilterJars class there is a call to read webSocket from catalina.properties. 
This worked but for a reason now the catalina.properties file is not found 
(lcation not resolved) and put in propertiesNotFound variable. So websocket is 
always sets to false. I'll check why...


was (Author: jacques.le.roux):
I reopen I know why websocket no longer works.

In FilterJars class there is a call to read webSocket from catalina.properties. 
This worked but for a reason now the catalina.properties file is not found 
(lcation not resolved) and put in propertiesNotFound variable. So websocket is 
always sets to false. I'll check why...

> Add WebSocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-7073.patch, OFBIZ-7073.patch, 
> tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (OFBIZ-7538) Add Wiki page for WebSocket usage

2018-01-02 Thread Jacques Le Roux (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-7538:


I reopen in relation with OFBIZ-7073

> Add Wiki page for WebSocket usage
> -
>
> Key: OFBIZ-7538
> URL: https://issues.apache.org/jira/browse/OFBIZ-7538
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-9981) Handle service response effectively

2018-01-02 Thread Suraj Khurana (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307843#comment-16307843
 ] 

Suraj Khurana commented on OFBIZ-9981:
--

Hi [~jacques.le.roux],

Thank you so much for committing changes.

I agree with you and we can use the pattern you are suggesting. +1 for it.
I also reviewed the changes after you commit and nothing was found critical or 
major.

Please let me know in case of any other help required in reviewing or testing 
these changes.

> Handle service response effectively
> ---
>
> Key: OFBIZ-9981
> URL: https://issues.apache.org/jira/browse/OFBIZ-9981
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-9981-MAR-SECEXT-WE.patch, 
> OFBIZ-9981-content.patch, OFBIZ-9981-manufacturing.patch, 
> OFBIZ-9981-order.patch, OFBIZ-9981-party.patch, OFBIZ-9981-plugins.patch, 
> OFBIZ-9981-product.patch, OFBIZ-9981.patch
>
>
> [As per discussion on Dev ML|http://markmail.org/message/dfriai337uxlx5mo]: 
> ==
> Every service calling from java/groovy must handle errors by service util 
> methods such as isError, reutrnError etc. and similarly in case of XML 
>  executed successfully.
> Apart from this, one suggestion is to include *Debug.logError* in 
> *_ServiceUtil.returnProblem_* so that in case of any error occurred and 
> handled, it will always be logged on the console.
> ==



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-7034) Showing QRCodes in PDF

2018-01-02 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307782#comment-16307782
 ] 

Jacques Le Roux commented on OFBIZ-7034:


Thanks JInghai,

I had no ideas about that

> Showing QRCodes in PDF
> --
>
> Key: OFBIZ-7034
> URL: https://issues.apache.org/jira/browse/OFBIZ-7034
> Project: OFBiz
>  Issue Type: Bug
>  Components: example
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Murugeswari
>Assignee: Shi Jinghai
> Attachments: barcode4j-trunk-zxing3.3.1-jdk8.jar
>
>
> Hi Folks,
>   I have to generate a pdf which should have Barcode as well as QRCode so 
> I followed this one OFBIZ-4154.
>   In trunk version, I run with demo data and tried to create a PDF with 
> QRCode by using this link 
> https://localhost:8443/example/control/ExampleReportPdfBarcode?exampleId=EX01.
>   But it fails to render QRCode but BarCodes are rendered successfully. 
> In console I get following error.
> {code}
>  [java] 2016-05-04 12:29:34,677 |http-nio-8080-exec-5 |ControlServlet 
>|T| [[[qrcode(Domain:http://localhost)] Request Done- 
> total:0.245,since last([qrcode(Domain:ht...):0.245]]
>  [java] 2016-05-04 12:29:34,686 |ttp-nio-8443-exec-17 |FOUserAgent
>|E| Image not available. URI: 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20.
>  Reason: org.apache.xmlgraphics.image.loader.ImageException: The file format 
> is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  (See position 43:308)
>  [java] org.apache.xmlgraphics.image.loader.ImageException: The file 
> format is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.preloadImage(ImageManager.java:181)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.cache.ImageCache.needImageInfo(ImageCache.java:128)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.getImageInfo(ImageManager.java:123)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.fop.fo.flow.ExternalGraphic.bind(ExternalGraphic.java:81) 
> [fop-2.0.jar:?]
>  [java]   at org.apache.fop.fo.FObj.processNode(FObj.java:129) 
> [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:291)
>  [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:179) 
> [fop-2.0.jar:?]
> {code}
> Same thing tested with Release15.12 here also it fails to render QRCode and 
> same exception was caught .



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-10135) Update markup of OrderHistory page according to standard markup given by Bootstrap v4.0.0

2018-01-02 Thread Nitish Mishra (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitish Mishra updated OFBIZ-10135:
--
Attachment: OFBIZ-10135.patch

Attaching the patch which contains the markup improvement of Order History page.

> Update markup of OrderHistory page according to standard markup given by 
> Bootstrap v4.0.0
> -
>
> Key: OFBIZ-10135
> URL: https://issues.apache.org/jira/browse/OFBIZ-10135
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Nitish Mishra
>Assignee: Nitish Mishra
> Attachments: OFBIZ-10135.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (OFBIZ-10133) streaming large content cause out of memory exception.

2018-01-02 Thread Jacques Le Roux (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307779#comment-16307779
 ] 

Jacques Le Roux commented on OFBIZ-10133:
-

Hi Michael, Wai,

For BUFFERSIZE I guess because it's not a variable but a constant, so the 
uppercase rule applies. But if this rule applies for BUFFERSIZE it should be 
also used for buffer ;)

What is not clear to me is the comment:
bq. // same as the default buffer size; change as needed
This maybe needs a clarification. Maybe a TODO with a reference to this issue 
(OFBIZ-10133 is enough)

> streaming large content cause out of memory exception.
> --
>
> Key: OFBIZ-10133
> URL: https://issues.apache.org/jira/browse/OFBIZ-10133
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Wai
> Attachments: OFBIZ-10133.patch, OFBIZ-10133.patch
>
>
> When ofbiz streams a large content (eg. video file), get out of memory 
> exception.
> console output...
> 2018-01-01 05:01:03,933 |jsse-nio-8443-exec-2 |MycoReqMapHandlerBase 
> |E| Java heap space
> java.lang.OutOfMemoryError: Java heap space
> at 
> org.apache.commons.io.output.ByteArrayOutputStream.needNewBuffer(ByteArrayOutputStream.java:127)
>  ~[commons-io-2.5.jar:2.5]
> at 
> org.apache.commons.io.output.ByteArrayOutputStream.write(ByteArrayOutputStream.java:158)
>  ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2147) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:2102) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2123) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:2078) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:721) 
> ~[commons-io-2.5.jar:2.5]
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (OFBIZ-10135) Update markup of OrderHistory page according to standard markup given by Bootstrap v4.0.0

2018-01-02 Thread Nitish Mishra (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitish Mishra reassigned OFBIZ-10135:
-

Assignee: Nitish Mishra

> Update markup of OrderHistory page according to standard markup given by 
> Bootstrap v4.0.0
> -
>
> Key: OFBIZ-10135
> URL: https://issues.apache.org/jira/browse/OFBIZ-10135
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Nitish Mishra
>Assignee: Nitish Mishra
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OFBIZ-10135) Update markup of OrderHistory page according to standard markup given by Bootstrap v4.0.0

2018-01-02 Thread Nitish Mishra (JIRA) 
Nitish Mishra created OFBIZ-10135:
-

 Summary: Update markup of OrderHistory page according to standard 
markup given by Bootstrap v4.0.0
 Key: OFBIZ-10135
 URL: https://issues.apache.org/jira/browse/OFBIZ-10135
 Project: OFBiz
  Issue Type: Sub-task
  Components: ecommerce
Affects Versions: Trunk
Reporter: Nitish Mishra






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-10134) [Refactoring] Package org.apache.ofbiz.product.category

2018-01-02 Thread Dennis Balkir (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10134:
--
Attachment: 
OFBIZ-10134_org.apache.ofbiz.product.category.CatalogUrlDirective_refactoring.patch

OFBIZ-10134_org.apache.ofbiz.product.category.CatalogUrlFilter_refactoring.patch

OFBIZ-10134_org.apache.ofbiz.product.category.CatalogUrlServlet_refactoring.patch

OFBIZ-10134_org.apache.ofbiz.product.category.CategoryContentWrapper_refactoring.patch

OFBIZ-10134_org.apache.ofbiz.product.category.CategoryServices_refactoring.patch

OFBIZ-10134_org.apache.ofbiz.product.category.CategoryWorker_refactoring.patch

OFBIZ-10134_org.apache.ofbiz.product.category.SeoCatalogUrlServlet_refactoring.patch

OFBIZ-10134_org.apache.ofbiz.product.category.SeoConfigUtil_refactoring.patch

OFBIZ-10134_org.apache.ofbiz.product.category.SeoContextFilter_refactoring.patch

OFBIZ-10134_org.apache.ofbiz.product.category.SeoControlServlet_refactoring.patch

I deleted the method {{CategoryWorker.buildCountCondition}}, because it was 
never used and for this dead code.

> [Refactoring] Package org.apache.ofbiz.product.category
> ---
>
> Key: OFBIZ-10134
> URL: https://issues.apache.org/jira/browse/OFBIZ-10134
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Fix For: Upcoming Release
>
> Attachments: 
> OFBIZ-10134_org.apache.ofbiz.product.category.CatalogUrlDirective_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.CatalogUrlFilter_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.CatalogUrlServlet_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.CategoryContentWrapper_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.CategoryServices_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.CategoryWorker_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.SeoCatalogUrlServlet_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.SeoConfigUtil_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.SeoContextFilter_refactoring.patch,
>  
> OFBIZ-10134_org.apache.ofbiz.product.category.SeoControlServlet_refactoring.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OFBIZ-10134) [Refactoring] Package org.apache.ofbiz.product.category

2018-01-02 Thread Dennis Balkir (JIRA) 
Dennis Balkir created OFBIZ-10134:
-

 Summary: [Refactoring] Package org.apache.ofbiz.product.category
 Key: OFBIZ-10134
 URL: https://issues.apache.org/jira/browse/OFBIZ-10134
 Project: OFBiz
  Issue Type: Sub-task
  Components: product
Affects Versions: Trunk
Reporter: Dennis Balkir
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9506) OFBIZ-6964: Implementation to support replenishment planning through any inter-company facility

2018-01-02 Thread Yashwant Dhakad (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad updated OFBIZ-9506:
---
Attachment: OFBIZ-9506.patch

> OFBIZ-6964: Implementation to support replenishment planning through any 
> inter-company facility
> ---
>
> Key: OFBIZ-9506
> URL: https://issues.apache.org/jira/browse/OFBIZ-9506
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Reporter: Swapnil M Mane
>Assignee: Yashwant Dhakad
> Attachments: OFBIZ-9506.patch
>
>
> For support of replenishment planning through any inter-company facility, 
> This task is for the code implementation on the basis of design/information 
> shared in the ticket https://issues.apache.org/jira/browse/OFBIZ-7356.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (OFBIZ-9506) OFBIZ-6964: Implementation to support replenishment planning through any inter-company facility

2018-01-02 Thread Yashwant Dhakad (JIRA) 

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad updated OFBIZ-9506:
---
Attachment: (was: OFBIZ-9506.patch)

> OFBIZ-6964: Implementation to support replenishment planning through any 
> inter-company facility
> ---
>
> Key: OFBIZ-9506
> URL: https://issues.apache.org/jira/browse/OFBIZ-9506
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Reporter: Swapnil M Mane
>Assignee: Yashwant Dhakad
> Attachments: OFBIZ-9506.patch
>
>
> For support of replenishment planning through any inter-company facility, 
> This task is for the code implementation on the basis of design/information 
> shared in the ticket https://issues.apache.org/jira/browse/OFBIZ-7356.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)