[jira] [Commented] (OFBIZ-10142) Trailing fraction are not entertained by formatCurrency method of UtilFormatOut

2018-01-03 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310938#comment-16310938
 ] 

Deepak Dixit commented on OFBIZ-10142:
--

This has been committed at 
ofbiz framework trunk at r#1820038 and
ofbiz framework 17.12 at r#1820039

Thanks Suraj Khurana for your contribution. 

> Trailing fraction are not entertained by formatCurrency  method of 
> UtilFormatOut
> 
>
> Key: OFBIZ-10142
> URL: https://issues.apache.org/jira/browse/OFBIZ-10142
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, 17.12.01
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
> Attachments: OFBIZ-10142.patch
>
>
> <@ofbizCurrency amount=15.00 rounding=2 isoCode=USD/>
> Expected output: $15.00
> Actual output: $15
> There was a bug in icu4j:60.1 and it has bee fixed in latest 
> release(icu4j:60.2). For more information:
> http://bugs.icu-project.org/trac/ticket/13492 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-10142) Trailing fraction are not entertained by formatCurrency method of UtilFormatOut

2018-01-03 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reassigned OFBIZ-10142:


Assignee: Deepak Dixit  (was: Suraj Khurana)

> Trailing fraction are not entertained by formatCurrency  method of 
> UtilFormatOut
> 
>
> Key: OFBIZ-10142
> URL: https://issues.apache.org/jira/browse/OFBIZ-10142
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, 17.12.01
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
> Attachments: OFBIZ-10142.patch
>
>
> <@ofbizCurrency amount=15.00 rounding=2 isoCode=USD/>
> Expected output: $15.00
> Actual output: $15
> There was a bug in icu4j:60.1 and it has bee fixed in latest 
> release(icu4j:60.2). For more information:
> http://bugs.icu-project.org/trac/ticket/13492 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-10142) Trailing fraction are not entertained by formatCurrency method of UtilFormatOut

2018-01-03 Thread Suraj Khurana (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10142:
-

Assignee: Suraj Khurana  (was: Deepak Dixit)

> Trailing fraction are not entertained by formatCurrency  method of 
> UtilFormatOut
> 
>
> Key: OFBIZ-10142
> URL: https://issues.apache.org/jira/browse/OFBIZ-10142
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, 17.12.01
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>
> <@ofbizCurrency amount=15.00 rounding=2 isoCode=USD/>
> Expected output: $15.00
> Actual output: $15
> There was a bug in icu4j:60.1 and it has bee fixed in latest 
> release(icu4j:60.2). For more information:
> http://bugs.icu-project.org/trac/ticket/13492 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7073) Add WebSocket support in OFBiz

2018-01-03 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310811#comment-16310811
 ] 

Deepak Dixit commented on OFBIZ-7073:
-

I think this is broken after ControlFilter related changes r#1761304,

> Add WebSocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7073.patch, OFBIZ-7073.patch, 
> tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-10133) streaming large content cause out of memory exception.

2018-01-03 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310796#comment-16310796
 ] 

Deepak Dixit commented on OFBIZ-10133:
--

Hi Wai,

I think we can make buffer size property driven instead of hard code,
like we can keep this in content.properties. default will be 512. 
It can be modified as per need. 

> streaming large content cause out of memory exception.
> --
>
> Key: OFBIZ-10133
> URL: https://issues.apache.org/jira/browse/OFBIZ-10133
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Wai
> Attachments: OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch
>
>
> When ofbiz streams a large content (eg. video file), get out of memory 
> exception.
> console output...
> 2018-01-01 05:01:03,933 |jsse-nio-8443-exec-2 |MycoReqMapHandlerBase 
> |E| Java heap space
> java.lang.OutOfMemoryError: Java heap space
> at 
> org.apache.commons.io.output.ByteArrayOutputStream.needNewBuffer(ByteArrayOutputStream.java:127)
>  ~[commons-io-2.5.jar:2.5]
> at 
> org.apache.commons.io.output.ByteArrayOutputStream.write(ByteArrayOutputStream.java:158)
>  ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2147) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:2102) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2123) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:2078) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:721) 
> ~[commons-io-2.5.jar:2.5]
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9905) Issue with Agreement under Accounting

2018-01-03 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310795#comment-16310795
 ] 

Rishi Solanki commented on OFBIZ-9905:
--

+1 [~jacques.le.roux] we should consider only Create or New.

> Issue with Agreement under Accounting
> -
>
> Key: OFBIZ-9905
> URL: https://issues.apache.org/jira/browse/OFBIZ-9905
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement
>Reporter: Aayush jain
>Assignee: sourabh jain
> Attachments: OFBIZ-9905.patch, UI_label .png
>
>
> Following issues found:
> 1. Create Agreement opens an edit agreement window
> 2. Able to Create Agreement without any detail (empty Agreement) 
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement
> 2. Navigate to Agreement section
> 3. Click on create Agreement
> 4. Click submit button
> Actual: Agreement id is generated for empty agreement and when create window 
> opens, it's redirection is wrong to edit window
> Expected: Proper redirection should be there (create agreement) and if an 
> agreement is created without any details its of no use.
> Note: Same Issue exist with following screens:
> 1. Billing Account 
> 2. Tax Authority 
> 3. Agreement 
> 4. Fixed Asset 
> 5. Vendor 
> 6. WebSite
> 7. Blog 
> 8. Employment
> 9. Employee Position 
> 10.Performance Review  
> 11.Job Requisition 
> 12. Party Resume



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-10133) streaming large content cause out of memory exception.

2018-01-03 Thread Wai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310774#comment-16310774
 ] 

Wai commented on OFBIZ-10133:
-

Jacques,Michael

Please ignore those comments.  They're legacy comments I forgot to remove.

> streaming large content cause out of memory exception.
> --
>
> Key: OFBIZ-10133
> URL: https://issues.apache.org/jira/browse/OFBIZ-10133
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Wai
> Attachments: OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch
>
>
> When ofbiz streams a large content (eg. video file), get out of memory 
> exception.
> console output...
> 2018-01-01 05:01:03,933 |jsse-nio-8443-exec-2 |MycoReqMapHandlerBase 
> |E| Java heap space
> java.lang.OutOfMemoryError: Java heap space
> at 
> org.apache.commons.io.output.ByteArrayOutputStream.needNewBuffer(ByteArrayOutputStream.java:127)
>  ~[commons-io-2.5.jar:2.5]
> at 
> org.apache.commons.io.output.ByteArrayOutputStream.write(ByteArrayOutputStream.java:158)
>  ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2147) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:2102) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2123) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:2078) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:721) 
> ~[commons-io-2.5.jar:2.5]
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-10133) streaming large content cause out of memory exception.

2018-01-03 Thread Wai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310777#comment-16310777
 ] 

Wai commented on OFBIZ-10133:
-

To reproduce the issue:

-get 500MB file. name it "testfile". place file into /runtime/tmp
-enter https://localhost:8443/webtools/control/entityImport
-login
-enter the following seed data, click "import test" button








-enter https://localhost:8443/partymgr/control/main
-login
-enter https://localhost:8443/partymgr/control/stream?contentId=TESTBLOB

-notice exception with java heap space





> streaming large content cause out of memory exception.
> --
>
> Key: OFBIZ-10133
> URL: https://issues.apache.org/jira/browse/OFBIZ-10133
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Wai
> Attachments: OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch
>
>
> When ofbiz streams a large content (eg. video file), get out of memory 
> exception.
> console output...
> 2018-01-01 05:01:03,933 |jsse-nio-8443-exec-2 |MycoReqMapHandlerBase 
> |E| Java heap space
> java.lang.OutOfMemoryError: Java heap space
> at 
> org.apache.commons.io.output.ByteArrayOutputStream.needNewBuffer(ByteArrayOutputStream.java:127)
>  ~[commons-io-2.5.jar:2.5]
> at 
> org.apache.commons.io.output.ByteArrayOutputStream.write(ByteArrayOutputStream.java:158)
>  ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2147) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:2102) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2123) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:2078) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:721) 
> ~[commons-io-2.5.jar:2.5]
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10133) streaming large content cause out of memory exception.

2018-01-03 Thread Wai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wai updated OFBIZ-10133:

Attachment: OFBIZ-10133.patch

> streaming large content cause out of memory exception.
> --
>
> Key: OFBIZ-10133
> URL: https://issues.apache.org/jira/browse/OFBIZ-10133
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Wai
> Attachments: OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch
>
>
> When ofbiz streams a large content (eg. video file), get out of memory 
> exception.
> console output...
> 2018-01-01 05:01:03,933 |jsse-nio-8443-exec-2 |MycoReqMapHandlerBase 
> |E| Java heap space
> java.lang.OutOfMemoryError: Java heap space
> at 
> org.apache.commons.io.output.ByteArrayOutputStream.needNewBuffer(ByteArrayOutputStream.java:127)
>  ~[commons-io-2.5.jar:2.5]
> at 
> org.apache.commons.io.output.ByteArrayOutputStream.write(ByteArrayOutputStream.java:158)
>  ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2147) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:2102) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2123) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.copy(IOUtils.java:2078) 
> ~[commons-io-2.5.jar:2.5]
> at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:721) 
> ~[commons-io-2.5.jar:2.5]
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10141) Add a VERSION file in root dir

2018-01-03 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10141:

Attachment: OFBIZ-10141.patch

Here is a patch I propose.

The info is only rendered when using the specific versionInfoFooter Gradle 
task. The usage of this task is mostly for support requests when asking the 
user for version and the VERSION file is not accessible. So we don't need to 
use a general.properties which would complicate things a bit as suggested by 
Michael's point 2.

When svnInfoFooter or gitInfoFooter is used the version info is removed.

I have not implemented Michael's point 1 but we need to add something about 
updating the VERSION file in 
https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz

Please complete if I missed something, thanks


> Add a VERSION file in root dir
> --
>
> Key: OFBIZ-10141
> URL: https://issues.apache.org/jira/browse/OFBIZ-10141
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10141.patch
>
>
> Following discussion at http://markmail.org/message/ut74mzptruubw4ty we have 
> decided to
> # have VERSION file at project root to store released version.
> # Render the version in the applications footer template as a HTML comment.
> Also [~mbrohl] suggested that 
> #  it can be automatically set by (custom) builds to be generated.
> #  It should be made configurable in general.properties to prevent to show it 
> if the user does not want this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-10141) Add a VERSION file in root dir

2018-01-03 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-10141:
---

 Summary: Add a VERSION file in root dir
 Key: OFBIZ-10141
 URL: https://issues.apache.org/jira/browse/OFBIZ-10141
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: 17.12.01


Following discussion at http://markmail.org/message/ut74mzptruubw4ty we have 
decided to
# have VERSION file at project root to store released version.
# Render the version in the applications footer template as a HTML comment.

Also [~mbrohl] suggested that 
#  it can be automatically set by (custom) builds to be generated.
#  It should be made configurable in general.properties to prevent to show it 
if the user does not want this.





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes

2018-01-03 Thread Sebb (JIRA)
Sebb created OFBIZ-10140:


 Summary: Please use SSL (https) for KEYS, sigs, hashes
 Key: OFBIZ-10140
 URL: https://issues.apache.org/jira/browse/OFBIZ-10140
 Project: OFBiz
  Issue Type: Bug
Reporter: Sebb


As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs.

Also the download page must have a link to the KEYS file, i.e.

https://www.apache.org/dist/ofbiz/KEYS



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7467) WebSocket Example - Push Notifications

2018-01-03 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309860#comment-16309860
 ] 

Jacques Le Roux commented on OFBIZ-7467:


I tested for OFBIZ-7073 and despite my change it still does not work (no screen 
shown when creatin a new example and webSocket=true). Not sure if it's a change 
in this feature or another issue with webSocket, so I keep here open

> WebSocket Example - Push Notifications
> --
>
> Key: OFBIZ-7467
> URL: https://issues.apache.org/jira/browse/OFBIZ-7467
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: 16.11.01
>
> Attachments: OFBIZ-7467.patch, OFBIZ-7483-Screen-Shot.png
>
>
> This is a ticket for adding working example (in example application) of 
> WebSocket support that has been done in OFBIZ-7073



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7073) Add WebSocket support in OFBiz

2018-01-03 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309858#comment-16309858
 ] 

Jacques Le Roux commented on OFBIZ-7073:


I tested and despite my change it still does not work (no screen shown when 
creatin a new example and webSocket=true)

> Add WebSocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7073.patch, OFBIZ-7073.patch, 
> tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar 
> in catalina lib and created one webapp for websocket and also added server 
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee 
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets 
> implementation need jar scanning enabled and it is currently disabled in 
> OFBiz. Below is the code snippet of disabling jar scan from 
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of 
> minutes (in my case, it took approx 8 minutes), so we don't want this much of 
> startup time for OFBiz.
>  
> I got the following document where I found the reason why websocket is not 
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include 
> disabling of jar scanning. 
> We can say disabling jar scanning is right approach because if we enable it 
> then scanner will scan all the jars loaded in OFBiz startup that we don't 
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup 
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of 
> jars only. For example: jars having websockets endpoints. I am attaching 
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only 
> it will be considered for jar scan. We can change jar name of our jars using 
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in 
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml 
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
> 
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" 
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains 
> "discoverable" word in it.
> This change will not increase server start up time more than couple of 
> seconds (in my case, it just two seconds). So scanning time totally depends 
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Reopened] (OFBIZ-10131) ID should be the abbreviation for identity in English

2018-01-03 Thread James Yong (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong reopened OFBIZ-10131:


Sorry I didn't see the new patch.

> ID should be the abbreviation for identity in English
> -
>
> Key: OFBIZ-10131
> URL: https://issues.apache.org/jira/browse/OFBIZ-10131
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10131.patch, OFBIZ-10131.patch
>
>
> This affects the display on the web pages. Not the naming of variables in the 
> codes.
> Will search the *Labels.xml files and replace the word 'Id' with 'ID'.
> Will also improve the logic for auto title so that labels generated for 
> variables like productTypeId will be 'Product Type ID' instead of 'Product 
> Type Id'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-10131) ID should be the abbreviation for identity in English

2018-01-03 Thread James Yong (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-10131.
--

> ID should be the abbreviation for identity in English
> -
>
> Key: OFBIZ-10131
> URL: https://issues.apache.org/jira/browse/OFBIZ-10131
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10131.patch, OFBIZ-10131.patch
>
>
> This affects the display on the web pages. Not the naming of variables in the 
> codes.
> Will search the *Labels.xml files and replace the word 'Id' with 'ID'.
> Will also improve the logic for auto title so that labels generated for 
> variables like productTypeId will be 'Product Type ID' instead of 'Product 
> Type Id'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-10131) ID should be the abbreviation for identity in English

2018-01-03 Thread James Yong (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309775#comment-16309775
 ] 

James Yong commented on OFBIZ-10131:


Hi Jacques,

What you mention is correct. To add on further..

On why I don’t check for English locale before the Id-to-ID substitution:
Assume current locale is Chinese and there is no translation for productTypeId. 
If I don’t check for English locale before substitution, the display will show 
‘Product Type ID’.
if I check for English locale before substitution, the display will show 
‘Product Type Id’  because current locale is Chinese and Id-to-ID substitution 
didn’t happens.

Only made changes to the labels with ‘en’ locale. Didn’t find any changes 
required for ‘en_XX’ locale. If other locales require the same change, I think 
is better done by those who understand the language.

Regards,
James

> ID should be the abbreviation for identity in English
> -
>
> Key: OFBIZ-10131
> URL: https://issues.apache.org/jira/browse/OFBIZ-10131
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10131.patch, OFBIZ-10131.patch
>
>
> This affects the display on the web pages. Not the naming of variables in the 
> codes.
> Will search the *Labels.xml files and replace the word 'Id' with 'ID'.
> Will also improve the logic for auto title so that labels generated for 
> variables like productTypeId will be 'Product Type ID' instead of 'Product 
> Type Id'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-7034) Showing QRCodes in PDF

2018-01-03 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7034.
--
Resolution: Incomplete

Thanks JInghai,

I agree, we don't have to OOTB support all things available outside, closing as 
incomplete

> Showing QRCodes in PDF
> --
>
> Key: OFBIZ-7034
> URL: https://issues.apache.org/jira/browse/OFBIZ-7034
> Project: OFBiz
>  Issue Type: Bug
>  Components: example
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Murugeswari
>Assignee: Shi Jinghai
> Attachments: barcode4j-trunk-zxing3.3.1-jdk8.jar
>
>
> Hi Folks,
>   I have to generate a pdf which should have Barcode as well as QRCode so 
> I followed this one OFBIZ-4154.
>   In trunk version, I run with demo data and tried to create a PDF with 
> QRCode by using this link 
> https://localhost:8443/example/control/ExampleReportPdfBarcode?exampleId=EX01.
>   But it fails to render QRCode but BarCodes are rendered successfully. 
> In console I get following error.
> {code}
>  [java] 2016-05-04 12:29:34,677 |http-nio-8080-exec-5 |ControlServlet 
>|T| [[[qrcode(Domain:http://localhost)] Request Done- 
> total:0.245,since last([qrcode(Domain:ht...):0.245]]
>  [java] 2016-05-04 12:29:34,686 |ttp-nio-8443-exec-17 |FOUserAgent
>|E| Image not available. URI: 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20.
>  Reason: org.apache.xmlgraphics.image.loader.ImageException: The file format 
> is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  (See position 43:308)
>  [java] org.apache.xmlgraphics.image.loader.ImageException: The file 
> format is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.preloadImage(ImageManager.java:181)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.cache.ImageCache.needImageInfo(ImageCache.java:128)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.getImageInfo(ImageManager.java:123)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.fop.fo.flow.ExternalGraphic.bind(ExternalGraphic.java:81) 
> [fop-2.0.jar:?]
>  [java]   at org.apache.fop.fo.FObj.processNode(FObj.java:129) 
> [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:291)
>  [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:179) 
> [fop-2.0.jar:?]
> {code}
> Same thing tested with Release15.12 here also it fails to render QRCode and 
> same exception was caught .



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10138) [Refactoring] Package org.apache.ofbiz.product.category.ftl

2018-01-03 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10138:

Labels: refactoring  (was: )

It's good to have the word refactoring (and alike) in title, we can also create 
a label, here is one

> [Refactoring] Package org.apache.ofbiz.product.category.ftl
> ---
>
> Key: OFBIZ-10138
> URL: https://issues.apache.org/jira/browse/OFBIZ-10138
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Julian Leichert
>Priority: Minor
>  Labels: refactoring
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-No_org.apache.ofbiz.product.category.ftl.CatalogAltUrlSeoTransform_refactoring.patch,
>  
> OFBIZ-No_org.apache.ofbiz.product.category.ftl.CatalogUrlSeoTransform_refactoring.patch,
>  
> OFBIZ-No_org.apache.ofbiz.product.category.ftl.OfbizCatalogAltUrlTransform_refactoring.patch,
>  
> OFBIZ-No_org.apache.ofbiz.product.category.ftl.OfbizCatalogUrlTransform_refactoring.patch,
>  
> OFBIZ-No_org.apache.ofbiz.product.category.ftl.SeoTransform_refactoring.patch,
>  
> OFBIZ-No_org.apache.ofbiz.product.category.ftl.UrlRegexpTransform_refactoring.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-10028) Update Geo information according to ISO notifications

2018-01-03 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309639#comment-16309639
 ] 

Jacques Le Roux commented on OFBIZ-10028:
-

Hi Kyra,

No, new data are welcome

> Update Geo information according to ISO notifications
> -
>
> Key: OFBIZ-10028
> URL: https://issues.apache.org/jira/browse/OFBIZ-10028
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10028_ISO_Geo_Info_Notification_CN.patch, 
> OFBIZ-10028_ISO_Geo_Info_Notification_DE.patch
>
>
> This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq, 
> extract!
> bq. If someone is interested, the China changes are a bit to heavy for me,
> Here are the changes
> {quote}
> Country codes updated
> CN  2017-11-23 /China/
> CY  2017-11-23 /Cyprus/
> DE  2017-11-23 /Germany/
> EC  2017-11-23 /Ecuador/
> HK  2017-11-23 /Hong Kong/
> HU  2017-11-23 /Hungary/
> ID  2017-11-23 /Indonesia/
> IS  2017-11-23 /Iceland/
> KP  2017-11-23 /Korea (the 
> Democratic People's Republic of)/
> LA  2017-11-23 /Lao 
> People's Democratic Republic (the)/
> MD  2017-11-23 /Moldova 
> (the Republic of)/
> MH  2017-11-23 /Marshall 
> Islands (the)/
> ML  2017-11-23 /Mali/
> MO  2017-11-23 /Macao/
> MX  2017-11-23 /Mexico/
> NR  2017-11-23 /Nauru/
> PA  2017-11-23 /Panama/
> PK  2017-11-23 /Pakistan/
> QA  2017-11-23 /Qatar/
> TG  2017-11-23 /Togo/
> TJ  2017-11-23 /Tajikistan/
> UG  2017-11-23 /Uganda/
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10139) New centralized API getProdCatalogCategoryId() in CategoryWorker.java

2018-01-03 Thread Kyra Pritzel-Hentley (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kyra Pritzel-Hentley updated OFBIZ-10139:
-
Attachment: OFBIZ-10139_centralized_API_getProdCatalogCategoryId.patch

> New centralized API getProdCatalogCategoryId() in CategoryWorker.java
> -
>
> Key: OFBIZ-10139
> URL: https://issues.apache.org/jira/browse/OFBIZ-10139
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Kyra Pritzel-Hentley
>Priority: Minor
> Attachments: 
> OFBIZ-10139_centralized_API_getProdCatalogCategoryId.patch
>
>
> A new centralized API getProdCatalogCategoryId to get first 
> prodCatalogCategoryId of a type should be put in place. The patch includes 
> the new method and refactoring of specific category type methods to use this 
> new method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-10139) New centralized API getProdCatalogCategoryId() in CategoryWorker.java

2018-01-03 Thread Kyra Pritzel-Hentley (JIRA)
Kyra Pritzel-Hentley created OFBIZ-10139:


 Summary: New centralized API getProdCatalogCategoryId() in 
CategoryWorker.java
 Key: OFBIZ-10139
 URL: https://issues.apache.org/jira/browse/OFBIZ-10139
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Kyra Pritzel-Hentley
Priority: Minor


A new centralized API getProdCatalogCategoryId to get first 
prodCatalogCategoryId of a type should be put in place. The patch includes the 
new method and refactoring of specific category type methods to use this new 
method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10137) Order : Communication between customer and product store

2018-01-03 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10137:

Description: 
We are working for a customer to add a communication management linked to 
orders between the customer and the product store.
It will use communication events and add a new communication screenlet at the 
bottom of the order screen of the back office.
We plan to commit modifications to the trunk.

If anybody have some suggestions about this point, don't hesitate to share, we 
will be pleased to fit to the community recommendations. 

The discussion started here: http://markmail.org/message/hq2zfmy3zyqefm6v

  was:
We are working for a customer to add a communication management linked to 
orders between the customer and the product store.
It will use communication events and add a new communication screenlet at the 
bottom of the order screen of the back office.
We plan to commit modifications to the trunk.

If anybody have some suggestions about this point, don't hesitate to share, we 
will be pleased to fit to the community recommendations. 


> Order : Communication between customer and product store
> 
>
> Key: OFBIZ-10137
> URL: https://issues.apache.org/jira/browse/OFBIZ-10137
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Minor
>
> We are working for a customer to add a communication management linked to 
> orders between the customer and the product store.
> It will use communication events and add a new communication screenlet at the 
> bottom of the order screen of the back office.
> We plan to commit modifications to the trunk.
> If anybody have some suggestions about this point, don't hesitate to share, 
> we will be pleased to fit to the community recommendations. 
> The discussion started here: http://markmail.org/message/hq2zfmy3zyqefm6v



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-10028) Update Geo information according to ISO notifications

2018-01-03 Thread Kyra Pritzel-Hentley (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309506#comment-16309506
 ] 

Kyra Pritzel-Hentley commented on OFBIZ-10028:
--

[~jacques.le.roux] Is it sensible to create new GeoData xml files if one of the 
countries listed in the description does not have one already? (for example 
there is no GeoData_HU.xml in the OFBiz Code)


> Update Geo information according to ISO notifications
> -
>
> Key: OFBIZ-10028
> URL: https://issues.apache.org/jira/browse/OFBIZ-10028
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10028_ISO_Geo_Info_Notification_CN.patch, 
> OFBIZ-10028_ISO_Geo_Info_Notification_DE.patch
>
>
> This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq, 
> extract!
> bq. If someone is interested, the China changes are a bit to heavy for me,
> Here are the changes
> {quote}
> Country codes updated
> CN  2017-11-23 /China/
> CY  2017-11-23 /Cyprus/
> DE  2017-11-23 /Germany/
> EC  2017-11-23 /Ecuador/
> HK  2017-11-23 /Hong Kong/
> HU  2017-11-23 /Hungary/
> ID  2017-11-23 /Indonesia/
> IS  2017-11-23 /Iceland/
> KP  2017-11-23 /Korea (the 
> Democratic People's Republic of)/
> LA  2017-11-23 /Lao 
> People's Democratic Republic (the)/
> MD  2017-11-23 /Moldova 
> (the Republic of)/
> MH  2017-11-23 /Marshall 
> Islands (the)/
> ML  2017-11-23 /Mali/
> MO  2017-11-23 /Macao/
> MX  2017-11-23 /Mexico/
> NR  2017-11-23 /Nauru/
> PA  2017-11-23 /Panama/
> PK  2017-11-23 /Pakistan/
> QA  2017-11-23 /Qatar/
> TG  2017-11-23 /Togo/
> TJ  2017-11-23 /Tajikistan/
> UG  2017-11-23 /Uganda/
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10028) Update Geo information according to ISO notifications

2018-01-03 Thread Kyra Pritzel-Hentley (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kyra Pritzel-Hentley updated OFBIZ-10028:
-
Attachment: OFBIZ-10028_ISO_Geo_Info_Notification_CN.patch

Changed the geoCode and geoID of Chinas Provinces and Municipalities. Changed 
the geoTypeId to "REGION" when on th ISO site it was called "special 
administrative region" or "autonomous region".

> Update Geo information according to ISO notifications
> -
>
> Key: OFBIZ-10028
> URL: https://issues.apache.org/jira/browse/OFBIZ-10028
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10028_ISO_Geo_Info_Notification_CN.patch, 
> OFBIZ-10028_ISO_Geo_Info_Notification_DE.patch
>
>
> This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq, 
> extract!
> bq. If someone is interested, the China changes are a bit to heavy for me,
> Here are the changes
> {quote}
> Country codes updated
> CN  2017-11-23 /China/
> CY  2017-11-23 /Cyprus/
> DE  2017-11-23 /Germany/
> EC  2017-11-23 /Ecuador/
> HK  2017-11-23 /Hong Kong/
> HU  2017-11-23 /Hungary/
> ID  2017-11-23 /Indonesia/
> IS  2017-11-23 /Iceland/
> KP  2017-11-23 /Korea (the 
> Democratic People's Republic of)/
> LA  2017-11-23 /Lao 
> People's Democratic Republic (the)/
> MD  2017-11-23 /Moldova 
> (the Republic of)/
> MH  2017-11-23 /Marshall 
> Islands (the)/
> ML  2017-11-23 /Mali/
> MO  2017-11-23 /Macao/
> MX  2017-11-23 /Mexico/
> NR  2017-11-23 /Nauru/
> PA  2017-11-23 /Panama/
> PK  2017-11-23 /Pakistan/
> QA  2017-11-23 /Qatar/
> TG  2017-11-23 /Togo/
> TJ  2017-11-23 /Tajikistan/
> UG  2017-11-23 /Uganda/
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Closed] (OFBIZ-9971) Inventory transfer creates unnecessary record with 0

2018-01-03 Thread Akash Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-9971.
-

Closing this ticket, thanks Suraj, Jacopo, Jacques!

> Inventory transfer creates unnecessary record with 0
> 
>
> Key: OFBIZ-9971
> URL: https://issues.apache.org/jira/browse/OFBIZ-9971
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Suraj Khurana
>Assignee: Akash Jain
> Fix For: 16.11.04
>
> Attachments: OFBIZ-9971.patch
>
>
> While using inventory transfer for a product having multiple inventory items, 
> it creates an unnecessary record with 0 transfer quantity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9759) Fiscal Gl type is reflecting twice in drop-down of Cost Centers.

2018-01-03 Thread Akash Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309459#comment-16309459
 ] 

Akash Jain commented on OFBIZ-9759:
---

Reverted changes at r#1819947

> Fiscal Gl type is reflecting twice in drop-down of Cost Centers.
> 
>
> Key: OFBIZ-9759
> URL: https://issues.apache.org/jira/browse/OFBIZ-9759
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
> Environment: 
> https://ofbiz-trunk.hotwaxsystems.com/accounting/control/GlAccountBalanceByCostCenter?organizationPartyId=Company
>Reporter: Tejas Khanna
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-9759.patch
>
>
> Steps to reproduce:
> 1. Select Accounting from Applications.
> 2. Select Organization GL Settings from Accounting Manager.
> 3. Click on accounting.
> 4. Click on Reports
> 5. Select Cost Centers
> 6. Choose Fiscal Gl Type drop-down.
> Actual result: on selecting Gl Type from drop-down, selected Gl Type is 
> reflecting twice.
> Expected result: Selected value should come only once in drop-down after 
> report generation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (OFBIZ-10028) Update Geo information according to ISO notifications

2018-01-03 Thread Kyra Pritzel-Hentley (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309360#comment-16309360
 ] 

Kyra Pritzel-Hentley edited comment on OFBIZ-10028 at 1/3/18 9:38 AM:
--

This patch updates the geo data according to the ISO changes for Germany.
One might consider adding a new geoTypeId "LAND" since Germany technically does 
not contain states. But thats a topic for another ticket.


was (Author: kyra pritzel-hentley):
This patch updates the geo data according to the ISO changes for Germany.

> Update Geo information according to ISO notifications
> -
>
> Key: OFBIZ-10028
> URL: https://issues.apache.org/jira/browse/OFBIZ-10028
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10028_ISO_Geo_Info_Notification_DE.patch
>
>
> This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq, 
> extract!
> bq. If someone is interested, the China changes are a bit to heavy for me,
> Here are the changes
> {quote}
> Country codes updated
> CN  2017-11-23 /China/
> CY  2017-11-23 /Cyprus/
> DE  2017-11-23 /Germany/
> EC  2017-11-23 /Ecuador/
> HK  2017-11-23 /Hong Kong/
> HU  2017-11-23 /Hungary/
> ID  2017-11-23 /Indonesia/
> IS  2017-11-23 /Iceland/
> KP  2017-11-23 /Korea (the 
> Democratic People's Republic of)/
> LA  2017-11-23 /Lao 
> People's Democratic Republic (the)/
> MD  2017-11-23 /Moldova 
> (the Republic of)/
> MH  2017-11-23 /Marshall 
> Islands (the)/
> ML  2017-11-23 /Mali/
> MO  2017-11-23 /Macao/
> MX  2017-11-23 /Mexico/
> NR  2017-11-23 /Nauru/
> PA  2017-11-23 /Panama/
> PK  2017-11-23 /Pakistan/
> QA  2017-11-23 /Qatar/
> TG  2017-11-23 /Togo/
> TJ  2017-11-23 /Tajikistan/
> UG  2017-11-23 /Uganda/
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10028) Update Geo information according to ISO notifications

2018-01-03 Thread Kyra Pritzel-Hentley (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kyra Pritzel-Hentley updated OFBIZ-10028:
-
Attachment: OFBIZ-10028_ISO_Geo_Info_Notification_DE.patch

This patch updates the geo data according to the ISO changes for Germany.

> Update Geo information according to ISO notifications
> -
>
> Key: OFBIZ-10028
> URL: https://issues.apache.org/jira/browse/OFBIZ-10028
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10028_ISO_Geo_Info_Notification_DE.patch
>
>
> This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq, 
> extract!
> bq. If someone is interested, the China changes are a bit to heavy for me,
> Here are the changes
> {quote}
> Country codes updated
> CN  2017-11-23 /China/
> CY  2017-11-23 /Cyprus/
> DE  2017-11-23 /Germany/
> EC  2017-11-23 /Ecuador/
> HK  2017-11-23 /Hong Kong/
> HU  2017-11-23 /Hungary/
> ID  2017-11-23 /Indonesia/
> IS  2017-11-23 /Iceland/
> KP  2017-11-23 /Korea (the 
> Democratic People's Republic of)/
> LA  2017-11-23 /Lao 
> People's Democratic Republic (the)/
> MD  2017-11-23 /Moldova 
> (the Republic of)/
> MH  2017-11-23 /Marshall 
> Islands (the)/
> ML  2017-11-23 /Mali/
> MO  2017-11-23 /Macao/
> MX  2017-11-23 /Mexico/
> NR  2017-11-23 /Nauru/
> PA  2017-11-23 /Panama/
> PK  2017-11-23 /Pakistan/
> QA  2017-11-23 /Qatar/
> TG  2017-11-23 /Togo/
> TJ  2017-11-23 /Tajikistan/
> UG  2017-11-23 /Uganda/
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-10138) [Refactoring] Package org.apache.ofbiz.product.category.ftl

2018-01-03 Thread Julian Leichert (JIRA)
Julian Leichert created OFBIZ-10138:
---

 Summary: [Refactoring] Package 
org.apache.ofbiz.product.category.ftl
 Key: OFBIZ-10138
 URL: https://issues.apache.org/jira/browse/OFBIZ-10138
 Project: OFBiz
  Issue Type: Sub-task
  Components: product
Affects Versions: Trunk
Reporter: Julian Leichert
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-10138) [Refactoring] Package org.apache.ofbiz.product.category.ftl

2018-01-03 Thread Julian Leichert (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Leichert updated OFBIZ-10138:

Attachment: 
OFBIZ-No_org.apache.ofbiz.product.category.ftl.CatalogAltUrlSeoTransform_refactoring.patch

OFBIZ-No_org.apache.ofbiz.product.category.ftl.CatalogUrlSeoTransform_refactoring.patch

OFBIZ-No_org.apache.ofbiz.product.category.ftl.OfbizCatalogAltUrlTransform_refactoring.patch

OFBIZ-No_org.apache.ofbiz.product.category.ftl.OfbizCatalogUrlTransform_refactoring.patch

OFBIZ-No_org.apache.ofbiz.product.category.ftl.SeoTransform_refactoring.patch

OFBIZ-No_org.apache.ofbiz.product.category.ftl.UrlRegexpTransform_refactoring.patch

> [Refactoring] Package org.apache.ofbiz.product.category.ftl
> ---
>
> Key: OFBIZ-10138
> URL: https://issues.apache.org/jira/browse/OFBIZ-10138
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Julian Leichert
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-No_org.apache.ofbiz.product.category.ftl.CatalogAltUrlSeoTransform_refactoring.patch,
>  
> OFBIZ-No_org.apache.ofbiz.product.category.ftl.CatalogUrlSeoTransform_refactoring.patch,
>  
> OFBIZ-No_org.apache.ofbiz.product.category.ftl.OfbizCatalogAltUrlTransform_refactoring.patch,
>  
> OFBIZ-No_org.apache.ofbiz.product.category.ftl.OfbizCatalogUrlTransform_refactoring.patch,
>  
> OFBIZ-No_org.apache.ofbiz.product.category.ftl.SeoTransform_refactoring.patch,
>  
> OFBIZ-No_org.apache.ofbiz.product.category.ftl.UrlRegexpTransform_refactoring.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-10137) Order : Communication between customer and product store

2018-01-03 Thread Julien NICOLAS (JIRA)
Julien NICOLAS created OFBIZ-10137:
--

 Summary: Order : Communication between customer and product store
 Key: OFBIZ-10137
 URL: https://issues.apache.org/jira/browse/OFBIZ-10137
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: Trunk
Reporter: Julien NICOLAS
Assignee: Julien NICOLAS
Priority: Minor


We are working for a customer to add a communication management linked to 
orders between the customer and the product store.
It will use communication events and add a new communication screenlet at the 
bottom of the order screen of the back office.
We plan to commit modifications to the trunk.

If anybody have some suggestions about this point, don't hesitate to share, we 
will be pleased to fit to the community recommendations. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9233) Enable a service to run by a specific service engine

2018-01-03 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309307#comment-16309307
 ] 

Shi Jinghai commented on OFBIZ-9233:


Thanks Nicolas!

Yes, I agree with you, the relation between service and pool can be defined in 
new files.

> Enable a service to run by a specific service engine
> 
>
> Key: OFBIZ-9233
> URL: https://issues.apache.org/jira/browse/OFBIZ-9233
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-9233-20170301.patch, OFBIZ-9233-20170413.patch, 
> OFBIZ-9233-MultiServiceEnginesEnv.png
>
>
> Currently, all of the services of OFBiz are run by the 'default' service 
> engine.
> In a project, we have to make a service run by different service engines 
> rather than the 'default' one, i.e. order services run by 'order' service 
> engine and 'orderpool', shipment services run by 'shipment' service engine 
> and 'shipmentpool'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9233) Enable a service to run by a specific service engine

2018-01-03 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309286#comment-16309286
 ] 

Nicolas Malin commented on OFBIZ-9233:
--

I review this patch and It's seems complicate to mixing service definition and 
executing plan.

I propose to thinking about an other way to do this with separate them. We can 
introduce an other model job plan definition that can be dedicate on each 
environment like this
{code}


   


   


{code}

The most advantage would be don't modify the service definition to introduce 
the execution plan.

> Enable a service to run by a specific service engine
> 
>
> Key: OFBIZ-9233
> URL: https://issues.apache.org/jira/browse/OFBIZ-9233
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-9233-20170301.patch, OFBIZ-9233-20170413.patch, 
> OFBIZ-9233-MultiServiceEnginesEnv.png
>
>
> Currently, all of the services of OFBiz are run by the 'default' service 
> engine.
> In a project, we have to make a service run by different service engines 
> rather than the 'default' one, i.e. order services run by 'order' service 
> engine and 'orderpool', shipment services run by 'shipment' service engine 
> and 'shipmentpool'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)