[jira] [Commented] (OFBIZ-10028) Update Geo information according to ISO notifications
[
https://issues.apache.org/jira/browse/OFBIZ-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314437#comment-16314437
]
Jacques Le Roux commented on OFBIZ-10028:
-
Thanks Kyra,
Your patch for Cyprus is committed at revision: 1820374 and Iceland at
revision: 1820375 (WIP for OFBIZ-10147)
> Update Geo information according to ISO notifications
> -
>
> Key: OFBIZ-10028
> URL: https://issues.apache.org/jira/browse/OFBIZ-10028
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10028_ISO_Geo_Info_Notification_CN.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_CY.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_CY.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_DE.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_EC.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_HU.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_ID.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_IS.patch
>
>
> This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq,
> extract!
> bq. If someone is interested, the China changes are a bit to heavy for me,
> Here are the changes
> {quote}
> Country codes updated
> CN 2017-11-23 /China/
> CY 2017-11-23 /Cyprus/
> DE 2017-11-23 /Germany/
> EC 2017-11-23 /Ecuador/
> HK 2017-11-23 /Hong Kong/
> HU 2017-11-23 /Hungary/
> ID 2017-11-23 /Indonesia/
> IS 2017-11-23 /Iceland/
> KP 2017-11-23 /Korea (the
> Democratic People's Republic of)/
> LA 2017-11-23 /Lao
> People's Democratic Republic (the)/
> MD 2017-11-23 /Moldova
> (the Republic of)/
> MH 2017-11-23 /Marshall
> Islands (the)/
> ML 2017-11-23 /Mali/
> MO 2017-11-23 /Macao/
> MX 2017-11-23 /Mexico/
> NR 2017-11-23 /Nauru/
> PA 2017-11-23 /Panama/
> PK 2017-11-23 /Pakistan/
> QA 2017-11-23 /Qatar/
> TG 2017-11-23 /Togo/
> TJ 2017-11-23 /Tajikistan/
> UG 2017-11-23 /Uganda/
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-10147) Buildbot script refactoring to put in a R17 branch build
[ https://issues.apache.org/jira/browse/OFBIZ-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314424#comment-16314424 ] Jacques Le Roux commented on OFBIZ-10147: - This is a WIP, some code has been committed but not complete yet > Buildbot script refactoring to put in a R17 branch build > > > Key: OFBIZ-10147 > URL: https://issues.apache.org/jira/browse/OFBIZ-10147 > Project: OFBiz > Issue Type: Task > Components: BuildBot >Affects Versions: Trunk, 17.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > > Though I decided to let INFRA-15394 closed I found that the framework+plugins > build is not launched (as a dependence) after the framework build. > As we need the same pattern than the trunk for the R17 branch I will try to > fix this issue and then put in a R17 branch build > Then INFRA-15785 can be actionned -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314390#comment-16314390 ] Jacques Le Roux commented on OFBIZ-10140: - This is known and will be done in the future: https://s.apache.org/QXOF > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb >Assignee: Michael Brohl > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314225#comment-16314225 ] Sebb commented on OFBIZ-10140: -- Just noticed something else: *.sha is deprecated; the file should be called *.sha1, *.sha512 etc depending on the algorithm. > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb >Assignee: Michael Brohl > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313977#comment-16313977 ] Jacques Le Roux commented on OFBIZ-10140: - It's committed but not yet plublished: http://svn.apache.org/viewvc/ofbiz/site/template/page/download.tpl.php?r1=1820346=1820345=1820346 > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb >Assignee: Michael Brohl > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313940#comment-16313940 ] Sebb commented on OFBIZ-10140: -- It's not working for me; the sigs and hashes don't use https. This appears to be because the links don't include the protocol: [PGP] Do not default the protocol here. Also I could find no link to the KEYS file. > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb >Assignee: Michael Brohl > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313751#comment-16313751 ] Jacques Le Roux commented on OFBIZ-10140: - I tested, it worked, I closed. Did not see that KEYS was missing, sorry for the noise, was just trying to help :) > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb >Assignee: Michael Brohl > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10147) Buildbot script refactoring to put in a R17 branch build
[ https://issues.apache.org/jira/browse/OFBIZ-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10147: Description: Though I decided to let INFRA-15394 closed I found that the framework+plugins build is not launched (as a dependence) after the framework build. As we need the same pattern than the trunk for the R17 branch I will try to fix this issue and then put in a R17 branch build Then INFRA-15785 can be actionned was: Though I decided to let INFRA-15394 closed I found that the framework+plugins build is not launched (as a dependence) after the framework build. As we need the same pattern than the trunk for the R17 branch I will try to fix this issue and then put in a R17 branch build > Buildbot script refactoring to put in a R17 branch build > > > Key: OFBIZ-10147 > URL: https://issues.apache.org/jira/browse/OFBIZ-10147 > Project: OFBiz > Issue Type: Task > Components: BuildBot >Affects Versions: Trunk, 17.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > > Though I decided to let INFRA-15394 closed I found that the framework+plugins > build is not launched (as a dependence) after the framework build. > As we need the same pattern than the trunk for the R17 branch I will try to > fix this issue and then put in a R17 branch build > Then INFRA-15785 can be actionned -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313737#comment-16313737 ] Michael Brohl commented on OFBIZ-10140: --- Not sure why you are interfering here, Jacques. None of my changes, also not the https changes, were published until now. > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb >Assignee: Michael Brohl > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-10140: - Hi Michael, I reopen, we crossed on wire and your last change is not yet published > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb >Assignee: Michael Brohl > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10140. --- Resolution: Fixed Fix Version/s: (was: Trunk) Thanks Sebastian, Michael, It's OK now, checked with IE where I don't use "HTTPS Everywhere" => closing > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb >Assignee: Michael Brohl > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313710#comment-16313710 ] Michael Brohl commented on OFBIZ-10140: --- Ah, sorry, I was a bit too fast. Additionally added the link to the KEYS file and fixed a typo for the SHA512 link. I'll close when the changes are visible. Thanks, Michael > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb >Assignee: Michael Brohl > Fix For: Trunk > > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb reopened OFBIZ-10140: -- Thanks, however the website is not yet updated. Please only close the issue when the website has been republished. > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb >Assignee: Michael Brohl > Fix For: Trunk > > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10140. - Resolution: Fixed Fix Version/s: Trunk Thanks Sebb, this is fixed in r1820326. > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb >Assignee: Michael Brohl > Fix For: Trunk > > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10140: - Assignee: Michael Brohl > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb >Assignee: Michael Brohl > Fix For: Trunk > > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10140) Please use SSL (https) for KEYS, sigs, hashes
[ https://issues.apache.org/jira/browse/OFBIZ-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated OFBIZ-10140: - Environment: http://ofbiz.apache.org/download.html > Please use SSL (https) for KEYS, sigs, hashes > - > > Key: OFBIZ-10140 > URL: https://issues.apache.org/jira/browse/OFBIZ-10140 > Project: OFBiz > Issue Type: Bug > Environment: http://ofbiz.apache.org/download.html >Reporter: Sebb > > As the subject says: Please use https (SSL) for links to KEYS, hashes, sigs. > Also the download page must have a link to the KEYS file, i.e. > https://www.apache.org/dist/ofbiz/KEYS -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[
https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-10146:
--
Attachment: OFBIZ-10146.patch
> Removing of loadBestSellingCategory and all related methods in
> CategoryServices.xml
> ---
>
> Key: OFBIZ-10146
> URL: https://issues.apache.org/jira/browse/OFBIZ-10146
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10146.patch
>
>
> While doing some conversions from MiniLang to Groovy, I stumbled across these
> methods:
> {{loadBestSellingCategory}}
> {{RemoveProductFromBestSellCategory}}
> {{AddProductToBestSellCategory}}
> {{FindCategoryChild}}
> {{FindBestSellingProduct}}
> These are all in {{CategoryServices.xml}}.
> I started realizing, that the simple-method {{loadBestSellingCategory}}
> doesn't work right (there are some logical failures in it) and while fixing
> it,
> I searched for places where this is used, but couldn't find any.
> I started looking deeper into it and found that all of these methods are
> never used anywhere in OFBiz, neither are the services which are declared for
> this methods.
> This is why I propose to remove them; they have no real use, since they don't
> work properly, and also are never used.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
Dennis Balkir created OFBIZ-10146:
-
Summary: Removing of loadBestSellingCategory and all related
methods in CategoryServices.xml
Key: OFBIZ-10146
URL: https://issues.apache.org/jira/browse/OFBIZ-10146
Project: OFBiz
Issue Type: Improvement
Components: product
Affects Versions: Trunk
Reporter: Dennis Balkir
Priority: Minor
While doing some conversions from MiniLang to Groovy, I stumbled across these
methods:
{{loadBestSellingCategory}}
{{RemoveProductFromBestSellCategory}}
{{AddProductToBestSellCategory}}
{{FindCategoryChild}}
{{FindBestSellingProduct}}
These are all in {{CategoryServices.xml}}.
I started realizing, that the simple-method {{loadBestSellingCategory}} doesn't
work right (there are some logical failures in it) and while fixing it,
I searched for places where this is used, but couldn't find any.
I started looking deeper into it and found that all of these methods are never
used anywhere in OFBiz, neither are the services which are declared for this
methods.
This is why I propose to remove them; they have no real use, since they don't
work properly, and also are never used.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-10133) streaming large content cause out of memory exception.
[ https://issues.apache.org/jira/browse/OFBIZ-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312895#comment-16312895 ] Jacques Le Roux commented on OFBIZ-10133: - Yes good points Michael > streaming large content cause out of memory exception. > -- > > Key: OFBIZ-10133 > URL: https://issues.apache.org/jira/browse/OFBIZ-10133 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Wai > Attachments: OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, > OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch > > > When ofbiz streams a large content (eg. video file), get out of memory > exception. > console output... > 2018-01-01 05:01:03,933 |jsse-nio-8443-exec-2 |MycoReqMapHandlerBase > |E| Java heap space > java.lang.OutOfMemoryError: Java heap space > at > org.apache.commons.io.output.ByteArrayOutputStream.needNewBuffer(ByteArrayOutputStream.java:127) > ~[commons-io-2.5.jar:2.5] > at > org.apache.commons.io.output.ByteArrayOutputStream.write(ByteArrayOutputStream.java:158) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2147) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copy(IOUtils.java:2102) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2123) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copy(IOUtils.java:2078) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:721) > ~[commons-io-2.5.jar:2.5] > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-6858) Solr logging doesn't work
[
https://issues.apache.org/jira/browse/OFBIZ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312860#comment-16312860
]
Shi Jinghai commented on OFBIZ-6858:
I played this issue today.
OFBiz uses Log4J2 directly for logging, Solr uses SLF4J. According to the
document from SLF4J (https://www.slf4j.org/legacy.html), SLF4J can be bound to
Log4J. Log4J is end of life, Solr doesn't upgrade to Log4J2 until now (see
SOLR-7887 for details).
Here are the steps to make Solr log working in OFBiz trunk:
1. Comment out log4j-1.2-api and log4j-slf4j-impl in /build.gradle, as
delegating Solr' logging to Log4J2 wouldn't work.
{code:java}
//runtime 'org.apache.logging.log4j:log4j-1.2-api:2.10.0' // for external
jars using the old log4j1.2: routes logging to log4j 2
runtime 'org.apache.logging.log4j:log4j-core:2.10.0' // the implementation
of the log4j 2 API
runtime 'org.apache.logging.log4j:log4j-jul:2.10.0' // for external jars
using the java.util.logging: routes logging to log4j 2
//runtime 'org.apache.logging.log4j:log4j-slf4j-impl:2.10.0' // for
external jars using slf4j: routes logging to log4j 2
{code}
2. Add slf4j-api, slf4j-log4j12 and log4j in plugins/solr/build.gradle:
{code:java}
pluginLibsRuntime 'org.slf4j:slf4j-api:1.7.7'
pluginLibsRuntime 'org.slf4j:slf4j-log4j12:1.7.7'
pluginLibsRuntime 'log4j:log4j:1.2.17'
{code}
3. Add log4j.configuration to system properties in /build.gradle:
{code:java}
// java settings
def jvmArguments = ['-Xms128M', '-Xmx1024M',
'-Dlog4j.configuration=file:///D:/workspaces/OFBiz/ofbiz-framework-trunk/plugins/solr/config/log4j.properties']
{code}
4. Copy log4j.properties from Solr repository
(https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/server/resources/log4j.properties),
change solr.log to runtime/logs/solr
{code:java}
# rootLogger log level may be programmatically overridden by -Dsolr.log.level
solr.log=runtime/logs/solr
log4j.rootLogger=INFO, file, CONSOLE
# Console appender will be programmatically disabled when Solr is started with
option -Dsolr.log.muteconsole
log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender
log4j.appender.CONSOLE.layout=org.apache.log4j.EnhancedPatternLayout
log4j.appender.CONSOLE.layout.ConversionPattern=%d{-MM-dd HH:mm:ss.SSS}
%-5p (%t) [%X{collection} %X{shard} %X{replica} %X{core}] %c{1.} %m%n
#- size rotation with log cleanup.
log4j.appender.file=org.apache.log4j.RollingFileAppender
log4j.appender.file.MaxFileSize=4MB
log4j.appender.file.MaxBackupIndex=9
#- File to log to and log format
log4j.appender.file.File=${solr.log}/solr.log
log4j.appender.file.layout=org.apache.log4j.EnhancedPatternLayout
log4j.appender.file.layout.ConversionPattern=%d{-MM-dd HH:mm:ss.SSS} %-5p
(%t) [%X{collection} %X{shard} %X{replica} %X{core}] %c{1.} %m%n
# Adjust logging levels that should differ from root logger
log4j.logger.org.apache.zookeeper=WARN
log4j.logger.org.apache.hadoop=WARN
log4j.logger.org.eclipse.jetty=WARN
log4j.logger.org.eclipse.jetty.server.Server=INFO
log4j.logger.org.eclipse.jetty.server.ServerConnector=INFO
# set to INFO to enable infostream log messages
log4j.logger.org.apache.solr.update.LoggingInfoStream=OFF
{code}
5. Start OFBiz
6. Visit https://localhost:8443/solr/#/~logging and
https://localhost:8443/solr/#/~logging/level works as expected.
> Solr logging doesn't work
> -
>
> Key: OFBIZ-6858
> URL: https://issues.apache.org/jira/browse/OFBIZ-6858
> Project: OFBiz
> Issue Type: Bug
> Components: solr
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Shi Jinghai
> Attachments: Image2.png
>
>
> When looking at the logging screen in demo-trunk
> (https://demo-trunk-ofbiz.apache.org/solr/#/~logging) no logging results are
> shown. Nor does https://demo-trunk-ofbiz.apache.org/solr/#/~logging/level
> provide any insights.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-10133) streaming large content cause out of memory exception.
[ https://issues.apache.org/jira/browse/OFBIZ-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312850#comment-16312850 ] Michael Brohl commented on OFBIZ-10133: --- Mmmhh, the latest patch contains a lot of formatting changes and other bugfixes, so it's not easy to see the issue related changes. I see some other improvements that can be done , e.g. to check for diamond operators. Maybe better to split the patch into the core changes according to the issue and provide another patch for the formatting/refactoring on base of it and make two commits. Else the patch looks good to me. > streaming large content cause out of memory exception. > -- > > Key: OFBIZ-10133 > URL: https://issues.apache.org/jira/browse/OFBIZ-10133 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Wai > Attachments: OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, > OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch > > > When ofbiz streams a large content (eg. video file), get out of memory > exception. > console output... > 2018-01-01 05:01:03,933 |jsse-nio-8443-exec-2 |MycoReqMapHandlerBase > |E| Java heap space > java.lang.OutOfMemoryError: Java heap space > at > org.apache.commons.io.output.ByteArrayOutputStream.needNewBuffer(ByteArrayOutputStream.java:127) > ~[commons-io-2.5.jar:2.5] > at > org.apache.commons.io.output.ByteArrayOutputStream.write(ByteArrayOutputStream.java:158) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2147) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copy(IOUtils.java:2102) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2123) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copy(IOUtils.java:2078) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:721) > ~[commons-io-2.5.jar:2.5] > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10133) streaming large content cause out of memory exception.
[ https://issues.apache.org/jira/browse/OFBIZ-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312797#comment-16312797 ] Jacques Le Roux commented on OFBIZ-10133: - Thanks Wai, After our discussion on dev ML on the final for properties point, I'll apply your patch in fex days with these last change, except if someone has something else to say? > streaming large content cause out of memory exception. > -- > > Key: OFBIZ-10133 > URL: https://issues.apache.org/jira/browse/OFBIZ-10133 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Wai > Attachments: OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, > OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch > > > When ofbiz streams a large content (eg. video file), get out of memory > exception. > console output... > 2018-01-01 05:01:03,933 |jsse-nio-8443-exec-2 |MycoReqMapHandlerBase > |E| Java heap space > java.lang.OutOfMemoryError: Java heap space > at > org.apache.commons.io.output.ByteArrayOutputStream.needNewBuffer(ByteArrayOutputStream.java:127) > ~[commons-io-2.5.jar:2.5] > at > org.apache.commons.io.output.ByteArrayOutputStream.write(ByteArrayOutputStream.java:158) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2147) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copy(IOUtils.java:2102) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2123) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copy(IOUtils.java:2078) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:721) > ~[commons-io-2.5.jar:2.5] > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-10133) streaming large content cause out of memory exception.
[ https://issues.apache.org/jira/browse/OFBIZ-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312797#comment-16312797 ] Jacques Le Roux edited comment on OFBIZ-10133 at 1/5/18 9:53 AM: - Thanks Wai, After our discussion on dev ML on the final for properties point, I'll apply your patch in 3 days with these last change, except if someone has something else to say? was (Author: jacques.le.roux): Thanks Wai, After our discussion on dev ML on the final for properties point, I'll apply your patch in fex days with these last change, except if someone has something else to say? > streaming large content cause out of memory exception. > -- > > Key: OFBIZ-10133 > URL: https://issues.apache.org/jira/browse/OFBIZ-10133 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Wai > Attachments: OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, > OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch > > > When ofbiz streams a large content (eg. video file), get out of memory > exception. > console output... > 2018-01-01 05:01:03,933 |jsse-nio-8443-exec-2 |MycoReqMapHandlerBase > |E| Java heap space > java.lang.OutOfMemoryError: Java heap space > at > org.apache.commons.io.output.ByteArrayOutputStream.needNewBuffer(ByteArrayOutputStream.java:127) > ~[commons-io-2.5.jar:2.5] > at > org.apache.commons.io.output.ByteArrayOutputStream.write(ByteArrayOutputStream.java:158) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2147) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copy(IOUtils.java:2102) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2123) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copy(IOUtils.java:2078) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:721) > ~[commons-io-2.5.jar:2.5] > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10141) Add a VERSION file in root dir
[ https://issues.apache.org/jira/browse/OFBIZ-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312796#comment-16312796 ] Jacques Le Roux commented on OFBIZ-10141: - No hurry, please take your time. I'll appreciate all reviews BTW ;) > Add a VERSION file in root dir > -- > > Key: OFBIZ-10141 > URL: https://issues.apache.org/jira/browse/OFBIZ-10141 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01 > > Attachments: OFBIZ-10141.patch > > > Following discussion at http://markmail.org/message/ut74mzptruubw4ty we have > decided to > # have VERSION file at project root to store released version. > # Render the version in the applications footer template as a HTML comment. > Also [~mbrohl] suggested that > # it can be automatically set by (custom) builds to be generated. > # It should be made configurable in general.properties to prevent to show it > if the user does not want this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
