[jira] [Assigned] (OFBIZ-10135) Update markup of OrderHistory page according to standard markup given by Bootstrap v4.0.0
[ https://issues.apache.org/jira/browse/OFBIZ-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-10135: Assignee: Deepak Dixit (was: Nitish Mishra) > Update markup of OrderHistory page according to standard markup given by > Bootstrap v4.0.0 > - > > Key: OFBIZ-10135 > URL: https://issues.apache.org/jira/browse/OFBIZ-10135 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit > Attachments: OFBIZ-10135.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10117) Improvement in Header and footer of ecommerce page and removed custom ecommain.css
[ https://issues.apache.org/jira/browse/OFBIZ-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10117. Resolution: Done Fix Version/s: 17.12.01 > Improvement in Header and footer of ecommerce page and removed custom > ecommain.css > -- > > Key: OFBIZ-10117 > URL: https://issues.apache.org/jira/browse/OFBIZ-10117 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Reporter: Parakh Maheshwari >Assignee: Deepak Dixit > Fix For: 17.12.01 > > Attachments: OFBIZ-10117-Improvement.patch, OFBIZ-10117.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10117) Improvement in Header and footer of ecommerce page and removed custom ecommain.css
[ https://issues.apache.org/jira/browse/OFBIZ-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325011#comment-16325011 ] Deepak Dixit commented on OFBIZ-10117: -- Thanks Parakh and Mayank for your contribution. This has been committed at ofbiz plugins trunk at r#1821045 and backported to release17.12 plugins at r#1821046 > Improvement in Header and footer of ecommerce page and removed custom > ecommain.css > -- > > Key: OFBIZ-10117 > URL: https://issues.apache.org/jira/browse/OFBIZ-10117 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Reporter: Parakh Maheshwari >Assignee: Deepak Dixit > Fix For: 17.12.01 > > Attachments: OFBIZ-10117-Improvement.patch, OFBIZ-10117.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10090) Update markup of Messages page according to standard markup given by Bootstrap v4.0.s
[ https://issues.apache.org/jira/browse/OFBIZ-10090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10090. Resolution: Done > Update markup of Messages page according to standard markup given by > Bootstrap v4.0.s > - > > Key: OFBIZ-10090 > URL: https://issues.apache.org/jira/browse/OFBIZ-10090 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit > Fix For: 17.12.01 > > Attachments: OFBIZ-10090-Improvement.patch, OFBIZ-10090.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10090) Update markup of Messages page according to standard markup given by Bootstrap v4.0.s
[ https://issues.apache.org/jira/browse/OFBIZ-10090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325009#comment-16325009 ] Deepak Dixit commented on OFBIZ-10090: -- Thanks Nitish Mishra for your contribution. Your patch has been committed at ofbiz plugins trunk at r#1821044 I am not backporting this to 17.12 as its improvement in already updated page. > Update markup of Messages page according to standard markup given by > Bootstrap v4.0.s > - > > Key: OFBIZ-10090 > URL: https://issues.apache.org/jira/browse/OFBIZ-10090 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit > Fix For: 17.12.01 > > Attachments: OFBIZ-10090-Improvement.patch, OFBIZ-10090.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-10090) Update markup of Messages page according to standard markup given by Bootstrap v4.0.s
[ https://issues.apache.org/jira/browse/OFBIZ-10090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-10090: Assignee: Deepak Dixit (was: Nitish Mishra) > Update markup of Messages page according to standard markup given by > Bootstrap v4.0.s > - > > Key: OFBIZ-10090 > URL: https://issues.apache.org/jira/browse/OFBIZ-10090 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit > Fix For: 17.12.01 > > Attachments: OFBIZ-10090-Improvement.patch, OFBIZ-10090.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-10133) streaming large content cause out of memory exception.
[ https://issues.apache.org/jira/browse/OFBIZ-10133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10133: --- Assignee: Jacques Le Roux > streaming large content cause out of memory exception. > -- > > Key: OFBIZ-10133 > URL: https://issues.apache.org/jira/browse/OFBIZ-10133 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Wai >Assignee: Jacques Le Roux > Attachments: OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, > OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, OFBIZ-10133.patch, > OFBIZ-10133.patch > > > When ofbiz streams a large content (eg. video file), get out of memory > exception. > console output... > 2018-01-01 05:01:03,933 |jsse-nio-8443-exec-2 |MycoReqMapHandlerBase > |E| Java heap space > java.lang.OutOfMemoryError: Java heap space > at > org.apache.commons.io.output.ByteArrayOutputStream.needNewBuffer(ByteArrayOutputStream.java:127) > ~[commons-io-2.5.jar:2.5] > at > org.apache.commons.io.output.ByteArrayOutputStream.write(ByteArrayOutputStream.java:158) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2147) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copy(IOUtils.java:2102) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:2123) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.copy(IOUtils.java:2078) > ~[commons-io-2.5.jar:2.5] > at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:721) > ~[commons-io-2.5.jar:2.5] > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324498#comment-16324498 ] Jacques Le Roux edited comment on OFBIZ-10113 at 1/12/18 8:54 PM: -- At r1821028+1821032 , I reverted from r1821001 some unrelated files (pending changes) that inadvertently slipped in. was (Author: jacques.le.roux): At r1821028, I reverted from r1821001 some unrelated files (pending changes) that inadvertently slipped in. > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Fix For: Upcoming Branch > > Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, > select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10131) ID should be the abbreviation for identity in English
[ https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324509#comment-16324509 ] Jacques Le Roux commented on OFBIZ-10131: - Completed again at revision: 1821029 > ID should be the abbreviation for identity in English > - > > Key: OFBIZ-10131 > URL: https://issues.apache.org/jira/browse/OFBIZ-10131 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10131-plugins.patch, OFBIZ-10131.patch, > OFBIZ-10131.patch > > > This affects the display on the web pages. Not the naming of variables in the > codes. > Will search the *Labels.xml files and replace the word 'Id' with 'ID'. > Will also improve the logic for auto title so that labels generated for > variables like productTypeId will be 'Product Type ID' instead of 'Product > Type Id'. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324498#comment-16324498 ] Jacques Le Roux commented on OFBIZ-10113: - At r1821028, I reverted from r1821001 some unrelated files (pending changes) that inadvertently slipped in. > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Fix For: Upcoming Branch > > Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, > select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-7611) Track userlogin for status change
[ https://issues.apache.org/jira/browse/OFBIZ-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324423#comment-16324423 ] Nicolas Malin commented on OFBIZ-7611: -- I didn't see why we can authorize to delete a EntityStatus because it's important for the history so it's completely intentional :) . If you want delete these entities for maintenance reason, it's probably to create a dedicate service for the specific case. > Track userlogin for status change > - > > Key: OFBIZ-7611 > URL: https://issues.apache.org/jira/browse/OFBIZ-7611 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Nicolas Malin > Attachments: OFBIZ-7611.patch, OFBIZ-7611.patch > > > Currently in OFBiz, 'changedByUserLoginId' field is missing from status > entities (like: ShipmentStatus). Using this field we can maintain the history > for each status change made by user. > Update all respective service and events to ensure this field gets updated. > Here is the list of entities with missing this field. > 1. BudgetStatus > 2. ContactListCommStatus > 3. CustRequestStatus > 4. ExampleStatus > 5. FinAccountStatus > 6. InventoryItemStatus > 7. InvoiceStatus > 8. PartyStatus > 9. RequirementStatus > 10. ShipmentStatus -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9539) [FB] Package org.apache.ofbiz.accounting.thirdparty.paypal
[ https://issues.apache.org/jira/browse/OFBIZ-9539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324394#comment-16324394 ] Michael Brohl commented on OFBIZ-9539: -- No, not yet. > [FB] Package org.apache.ofbiz.accounting.thirdparty.paypal > -- > > Key: OFBIZ-9539 > URL: https://issues.apache.org/jira/browse/OFBIZ-9539 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Kyra Pritzel-Hentley >Assignee: Michael Brohl >Priority: Minor > Fix For: 17.12.01 > > Attachments: OFBIZ-9539.patch, > OFBIZ-9539_org.apache.ofbiz.accounting.thirdparty.paypal_bugfixes.patch > > > PayPalEvents.java:236, DM_DEFAULT_ENCODING > * Dm: Found reliance on default encoding in > org.apache.ofbiz.accounting.thirdparty.paypal.PayPalEvents.payPalIPN(HttpServletRequest, > HttpServletResponse): new java.io.PrintWriter(OutputStream) > Found a call to a method which will perform a byte to String (or String to > byte) conversion, and will assume that the default platform encoding is > suitable. This will cause the application behaviour to vary between > platforms. Use an alternative API and specify a charset name or Charset > object explicitly. > PayPalEvents.java:240, OS_OPEN_STREAM_EXCEPTION_PATH > * OS: > org.apache.ofbiz.accounting.thirdparty.paypal.PayPalEvents.payPalIPN(HttpServletRequest, > HttpServletResponse) may fail to close stream on exception > The method creates an IO stream object, does not assign it to any fields, > pass it to other methods, or return it, and does not appear to close it on > all possible exception paths out of the method. This may result in a file > descriptor leak. It is generally a good idea to use a finally block to > ensure that streams are closed. > PayPalEvents.java:240, DM_DEFAULT_ENCODING > * Dm: Found reliance on default encoding in > org.apache.ofbiz.accounting.thirdparty.paypal.PayPalEvents.payPalIPN(HttpServletRequest, > HttpServletResponse): new java.io.InputStreamReader(InputStream) > Found a call to a method which will perform a byte to String (or String to > byte) conversion, and will assume that the default platform encoding is > suitable. This will cause the application behaviour to vary between > platforms. Use an alternative API and specify a charset name or Charset > object explicitly. > PayPalEvents.java:343, 393 RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT > * Return value of method without side effect is ignored > This code calls a method and ignores the return value. However our analysis > shows that the method (including its implementations in subclasses if any) > does not produce any effect other than return value. Thus this call can be > removed. > PayPalEvents.java:493, NP_NULL_ON_SOME_PATH > * NP: Possible null pointer dereference of results in > org.apache.ofbiz.accounting.thirdparty.paypal.PayPalEvents.setPaymentPreference(LocalDispatcher, > GenericValue, GenericValue, HttpServletRequest) > There is a branch of statement that, if executed, guarantees that a null > value will be dereferenced, which would generate a NullPointerException when > the code is executed. Of course, the problem might be that the branch or > statement is infeasible and that the null pointer exception can't ever be > executed; deciding that is beyond the ability of FindBugs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9539) [FB] Package org.apache.ofbiz.accounting.thirdparty.paypal
[ https://issues.apache.org/jira/browse/OFBIZ-9539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324355#comment-16324355 ] Jacques Le Roux commented on OFBIZ-9539: Hi Michael, Has a Jira being created for that? > [FB] Package org.apache.ofbiz.accounting.thirdparty.paypal > -- > > Key: OFBIZ-9539 > URL: https://issues.apache.org/jira/browse/OFBIZ-9539 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Kyra Pritzel-Hentley >Assignee: Michael Brohl >Priority: Minor > Fix For: 17.12.01 > > Attachments: OFBIZ-9539.patch, > OFBIZ-9539_org.apache.ofbiz.accounting.thirdparty.paypal_bugfixes.patch > > > PayPalEvents.java:236, DM_DEFAULT_ENCODING > * Dm: Found reliance on default encoding in > org.apache.ofbiz.accounting.thirdparty.paypal.PayPalEvents.payPalIPN(HttpServletRequest, > HttpServletResponse): new java.io.PrintWriter(OutputStream) > Found a call to a method which will perform a byte to String (or String to > byte) conversion, and will assume that the default platform encoding is > suitable. This will cause the application behaviour to vary between > platforms. Use an alternative API and specify a charset name or Charset > object explicitly. > PayPalEvents.java:240, OS_OPEN_STREAM_EXCEPTION_PATH > * OS: > org.apache.ofbiz.accounting.thirdparty.paypal.PayPalEvents.payPalIPN(HttpServletRequest, > HttpServletResponse) may fail to close stream on exception > The method creates an IO stream object, does not assign it to any fields, > pass it to other methods, or return it, and does not appear to close it on > all possible exception paths out of the method. This may result in a file > descriptor leak. It is generally a good idea to use a finally block to > ensure that streams are closed. > PayPalEvents.java:240, DM_DEFAULT_ENCODING > * Dm: Found reliance on default encoding in > org.apache.ofbiz.accounting.thirdparty.paypal.PayPalEvents.payPalIPN(HttpServletRequest, > HttpServletResponse): new java.io.InputStreamReader(InputStream) > Found a call to a method which will perform a byte to String (or String to > byte) conversion, and will assume that the default platform encoding is > suitable. This will cause the application behaviour to vary between > platforms. Use an alternative API and specify a charset name or Charset > object explicitly. > PayPalEvents.java:343, 393 RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT > * Return value of method without side effect is ignored > This code calls a method and ignores the return value. However our analysis > shows that the method (including its implementations in subclasses if any) > does not produce any effect other than return value. Thus this call can be > removed. > PayPalEvents.java:493, NP_NULL_ON_SOME_PATH > * NP: Possible null pointer dereference of results in > org.apache.ofbiz.accounting.thirdparty.paypal.PayPalEvents.setPaymentPreference(LocalDispatcher, > GenericValue, GenericValue, HttpServletRequest) > There is a branch of statement that, if executed, guarantees that a null > value will be dereferenced, which would generate a NullPointerException when > the code is executed. Of course, the problem might be that the branch or > statement is infeasible and that the null pointer exception can't ever be > executed; deciding that is beyond the ability of FindBugs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10154) pagination errors in "KeywordSearch.ftl" and "ProductSearchSession.java"
[ https://issues.apache.org/jira/browse/OFBIZ-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10154. --- Resolution: Fixed Fix Version/s: 16.11.05 17.12.01 Thanks Karsten for the detailled explanations! Your patch is in trunk r1821012 R17.12 r1821013 R16.1 r1821014 > pagination errors in "KeywordSearch.ftl" and "ProductSearchSession.java" > > > Key: OFBIZ-10154 > URL: https://issues.apache.org/jira/browse/OFBIZ-10154 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Karsten Tymann >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01, 16.11.05 > > Attachments: OFBIZ-10154-pagination-keywordsearch.patch > > > *pagination errors in keywordsearch in the Order->OrderEntry->Search-Screen* > With this patch I propose a fix for two bugs in the current OfBiz state. > 1. The pagination for the "Order Entry" Search in the "Order" component > has an error on the underlying FreemarkerTemplate. The .ftl displays all > potential pages, plus one. > For example, if you have 19 results with a ViewSize of 10, you should see > 2 pages, but in fact, 3 potential pages are shown. > This is a bug in the calculation of the pages on the .ftl. > The patch fixes the calculation by handling the variable "ListSize" as what it > is: the size of the list. There should be no subtraction for the listSize > provided by > the "KeywordSearch.groovy". > Note that this also adapts the file "KeywordSearch.ftl" to the equivalent > pagination > .ftl "CategoryDetail.ftl". In the patching process I also changed the > "TagSearch.ftl" to adapt to the correct calculation of pagination. > 2. The pagination for "KeywordSearch" triggers a completely new search if you > search for an order, change the > page, and then press the "Previous page" button. > This occurs because the method "processSearchParameters" in > "ProductSearchSession" > is called from the Groovy-Script of the Result-Screen > (check "KeywordSearch.groovy") > as well as from the method "checkDoKeywordOverride" which is triggered by > the Form-Submit-Search-Request "keywordsearch" (see controller.xml). > The additional call results in a new Search since the parameter > "clearSearchString" > is not send on the second occasion. Therefore one call should be eliminated. > I chose to remove the method call from within "checkDoKeywordOverride" > since it is unique to the component and is only triggered by this exact event. > "KeywordSearch.groovy", in multiple components, always triggers the > "ProductSearchSession.processSearchParameters(parameters, request)" > another call is just not needed. > Additionally I also removed the block of rechecking the set View and Index > size which > serves no purpose. Again, this block of actions is also not needed in similar > java classes such as "WorkEffortSearchSession.java". > To recreate the bug go to > Order->OrderEntry-> Search in the catalog for "g" -> check the amount of > shown pages and press "Next" -> press "back" -> note how many results you now > have, from 19 to 35 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10012) Alert message : "Developer: for lookups to work you must provide a form name!" appears when try to select contentId from Lookup
[ https://issues.apache.org/jira/browse/OFBIZ-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324255#comment-16324255 ] Dennis Balkir commented on OFBIZ-10012: --- Hi [~jacques.le.roux] and [~deepak.dixit], I was doing some testing and noticed, that this is still present. I reverted all my changes, to check if this is an error caused by me, but it still happened. The steps I took were: 1. Go to Catalog 2. klick on Categories 3. klick on find (just without typing anything, that will do it) 4. select one category (I tested this for the first two, 211 & CATALOG1, to make sure it's not one's categories exclusive behaviour) 5. select Content 6. in the small screen "Add Content to Category", klick on the button for "Content ID" (the button to look for a content id) 7. the lookup-form pops up, but also the mentioned "warning"-field, also it appears 4x in a row I don't think, that this is what it should do there, since this is simply the trunk I tested this with, I think there should be no missing form-names? > Alert message : "Developer: for lookups to work you must provide a form > name!" appears when try to select contentId from Lookup > --- > > Key: OFBIZ-10012 > URL: https://issues.apache.org/jira/browse/OFBIZ-10012 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Sonal Patwari >Assignee: Deepak Dixit > Attachments: ContentSearchOptionsAlertShowing (1).png > > > Steps to reproduce: > 1. Go to [Content > Component|https://demo-trunk.ofbiz.apache.org/content/control/main] > 2. Click on Content from > [submenu|https://demo-trunk.ofbiz.apache.org/content/control/findContent]. > 3. Click on the Advanced Search button > [https://demo-trunk.ofbiz.apache.org/content/control/ContentSearchOptions]. > 4. Provide Content Id. > 5. User should be able to see the alert message. > 6. For reference screenshot is attached. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9873) Create a PoC for a documentation system for OFBiz based on Asciidoc
[
https://issues.apache.org/jira/browse/OFBIZ-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324200#comment-16324200
]
Taher Alkhateeb edited comment on OFBIZ-9873 at 1/12/18 4:51 PM:
-
Added a with a very simple implementation to discuss on the community ML.
To test this patch do the following:
- apply the patch
- temporarily rename themes/common to something else (too long to explain now)
- pick any component you like, and inside it create the directory
src/docs/asciidoc
- Inside this new directory create a file that ends with adoc extension (e.g.
test.adoc)
- run the task ./gradlew publishDocumentation
- Observe in build/docs/asciidoc//html5/test.html
was (Author: taher):
Added a with a very simple implementation to discuss on the community ML.
To test this patch do the following:
- apply the patch
- temporarily rename themes/common to something else (too long to explain now)
- pick any component you like, and inside it create the directory
src/docs/asciidoc
- Inside this new directory create a file that ends with adoc extension (e.g.
test.adoc)
- run the task ./gradlew publishDocumentation
- Observe in build/docs/asciidoc/${component-name}/html5/test.html
> Create a PoC for a documentation system for OFBiz based on Asciidoc
> ---
>
> Key: OFBIZ-9873
> URL: https://issues.apache.org/jira/browse/OFBIZ-9873
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-9873.patch
>
>
> In reference to the [discussion
> thread|https://lists.apache.org/thread.html/8cc03b7b8733512244129ddae9e0cc1fb2a28e3e250aba1c8cf678f8@%3Cdev.ofbiz.apache.org%3E]
> this is an attempt to create a PoC for OFBiz documentation system based on
> Asciidoc. The main assumptions for the design of this system are:
> - The documentation language to use is Asciidoc
> - The documentation tool is Asciidoctor
> - Publishing happens through Gradle using the asciidoctor gradle plugin (not
> the OFBiz framework or anything else).
> - The only place where we write documentation is inside the code base
> - Every component contains its own documentation
> - General documentation goes to either a standalone directory or a generic
> component like common or base
> - As much as possible, documentation files are small and focused on one
> topic. And then other longer documents are constructed from these snippets of
> documentation.
> - We publish to all formats including PDF for users, or HTML for embedded
> help and wiki pages. So OFBiz does not parse docbook for its help system,
> instead it just renders generated HTML.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9873) Create a PoC for a documentation system for OFBiz based on Asciidoc
[
https://issues.apache.org/jira/browse/OFBIZ-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324200#comment-16324200
]
Taher Alkhateeb edited comment on OFBIZ-9873 at 1/12/18 4:50 PM:
-
Added a with a very simple implementation to discuss on the community ML.
To test this patch do the following:
- apply the patch
- temporarily rename themes/common to something else (too long to explain now)
- pick any component you like, and inside it create the directory
src/docs/asciidoc
- Inside this new directory create a file that ends with adoc extension (e.g.
test.adoc)
- run the task ./gradlew publishDocumentation
- Observe in build/docs/asciidoc/${component-name}/html5/test.html
was (Author: taher):
Added a with a very simple implementation to discuss on the community ML.
To test this patch do the following:
- apply the patch
- temporarily rename themes/common to something else (too long to explain now)
- pick any component you like, and inside it create the directory
src/docs/asciidoc
- Inside this new directory create a file that ends with adoc extension (e.g.
test.adoc)
- run the task ./gradlew publishDocumentation
- Observe in build/docs/${component-name}/html5/test.html
> Create a PoC for a documentation system for OFBiz based on Asciidoc
> ---
>
> Key: OFBIZ-9873
> URL: https://issues.apache.org/jira/browse/OFBIZ-9873
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-9873.patch
>
>
> In reference to the [discussion
> thread|https://lists.apache.org/thread.html/8cc03b7b8733512244129ddae9e0cc1fb2a28e3e250aba1c8cf678f8@%3Cdev.ofbiz.apache.org%3E]
> this is an attempt to create a PoC for OFBiz documentation system based on
> Asciidoc. The main assumptions for the design of this system are:
> - The documentation language to use is Asciidoc
> - The documentation tool is Asciidoctor
> - Publishing happens through Gradle using the asciidoctor gradle plugin (not
> the OFBiz framework or anything else).
> - The only place where we write documentation is inside the code base
> - Every component contains its own documentation
> - General documentation goes to either a standalone directory or a generic
> component like common or base
> - As much as possible, documentation files are small and focused on one
> topic. And then other longer documents are constructed from these snippets of
> documentation.
> - We publish to all formats including PDF for users, or HTML for embedded
> help and wiki pages. So OFBiz does not parse docbook for its help system,
> instead it just renders generated HTML.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-9873) Create a PoC for a documentation system for OFBiz based on Asciidoc
[
https://issues.apache.org/jira/browse/OFBIZ-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Taher Alkhateeb updated OFBIZ-9873:
---
Attachment: OFBIZ-9873.patch
Added a with a very simple implementation to discuss on the community ML.
To test this patch do the following:
- apply the patch
- temporarily rename themes/common to something else (too long to explain now)
- pick any component you like, and inside it create the directory
src/docs/asciidoc
- Inside this new directory create a file that ends with adoc extension (e.g.
test.adoc)
- run the task ./gradlew publishDocumentation
- Observe in build/docs/${component-name}/html5/test.html
> Create a PoC for a documentation system for OFBiz based on Asciidoc
> ---
>
> Key: OFBIZ-9873
> URL: https://issues.apache.org/jira/browse/OFBIZ-9873
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-9873.patch
>
>
> In reference to the [discussion
> thread|https://lists.apache.org/thread.html/8cc03b7b8733512244129ddae9e0cc1fb2a28e3e250aba1c8cf678f8@%3Cdev.ofbiz.apache.org%3E]
> this is an attempt to create a PoC for OFBiz documentation system based on
> Asciidoc. The main assumptions for the design of this system are:
> - The documentation language to use is Asciidoc
> - The documentation tool is Asciidoctor
> - Publishing happens through Gradle using the asciidoctor gradle plugin (not
> the OFBiz framework or anything else).
> - The only place where we write documentation is inside the code base
> - Every component contains its own documentation
> - General documentation goes to either a standalone directory or a generic
> component like common or base
> - As much as possible, documentation files are small and focused on one
> topic. And then other longer documents are constructed from these snippets of
> documentation.
> - We publish to all formats including PDF for users, or HTML for embedded
> help and wiki pages. So OFBiz does not parse docbook for its help system,
> instead it just renders generated HTML.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (OFBIZ-10154) pagination errors in "KeywordSearch.ftl" and "ProductSearchSession.java"
[ https://issues.apache.org/jira/browse/OFBIZ-10154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10154: --- Assignee: Jacques Le Roux > pagination errors in "KeywordSearch.ftl" and "ProductSearchSession.java" > > > Key: OFBIZ-10154 > URL: https://issues.apache.org/jira/browse/OFBIZ-10154 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Karsten Tymann >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10154-pagination-keywordsearch.patch > > > *pagination errors in keywordsearch in the Order->OrderEntry->Search-Screen* > With this patch I propose a fix for two bugs in the current OfBiz state. > 1. The pagination for the "Order Entry" Search in the "Order" component > has an error on the underlying FreemarkerTemplate. The .ftl displays all > potential pages, plus one. > For example, if you have 19 results with a ViewSize of 10, you should see > 2 pages, but in fact, 3 potential pages are shown. > This is a bug in the calculation of the pages on the .ftl. > The patch fixes the calculation by handling the variable "ListSize" as what it > is: the size of the list. There should be no subtraction for the listSize > provided by > the "KeywordSearch.groovy". > Note that this also adapts the file "KeywordSearch.ftl" to the equivalent > pagination > .ftl "CategoryDetail.ftl". In the patching process I also changed the > "TagSearch.ftl" to adapt to the correct calculation of pagination. > 2. The pagination for "KeywordSearch" triggers a completely new search if you > search for an order, change the > page, and then press the "Previous page" button. > This occurs because the method "processSearchParameters" in > "ProductSearchSession" > is called from the Groovy-Script of the Result-Screen > (check "KeywordSearch.groovy") > as well as from the method "checkDoKeywordOverride" which is triggered by > the Form-Submit-Search-Request "keywordsearch" (see controller.xml). > The additional call results in a new Search since the parameter > "clearSearchString" > is not send on the second occasion. Therefore one call should be eliminated. > I chose to remove the method call from within "checkDoKeywordOverride" > since it is unique to the component and is only triggered by this exact event. > "KeywordSearch.groovy", in multiple components, always triggers the > "ProductSearchSession.processSearchParameters(parameters, request)" > another call is just not needed. > Additionally I also removed the block of rechecking the set View and Index > size which > serves no purpose. Again, this block of actions is also not needed in similar > java classes such as "WorkEffortSearchSession.java". > To recreate the bug go to > Order->OrderEntry-> Search in the catalog for "g" -> check the amount of > shown pages and press "Next" -> press "back" -> note how many results you now > have, from 19 to 35 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10113. --- Resolution: Implemented Fix Version/s: Upcoming Branch Thanks Aditya, Your patches and the plugin are in at revision: 1821001 > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Fix For: Upcoming Branch > > Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, > select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10113: --- Assignee: Jacques Le Roux (was: Aditya Sharma) > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, > select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (OFBIZ-10156) Fix issues related to images paths
[
https://issues.apache.org/jira/browse/OFBIZ-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reopened OFBIZ-10156:
-
Reopen: To be cheked again after reverting at OFBIZ-10128
> Fix issues related to images paths
> --
>
> Key: OFBIZ-10156
> URL: https://issues.apache.org/jira/browse/OFBIZ-10156
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> While working on OFBIZ-10128 I stumbled upon this issue found on trunk demo
> {code}
> 2018-01-11 09:30:28,159 |ajp-nio-8009-exec-4 |FOUserAgent
> |E| Image not found. URI:
> /example/control/qrcode;jsessionid=6E1C4C1E84C4C96F370B89A44201DEEC.jvm1?message=Example%201=bmp=UTF-8=true=20=20.
> (See position 47:77)
> 2018-01-11 09:30:29,183 |ajp-nio-8009-exec-4 |FOUserAgent
> |E| Image not found. URI:
> /example/control/qrcode;jsessionid=6E1C4C1E84C4C96F370B89A44201DEEC.jvm1?message=Example%201=bmp=UTF-8=true=20=20.
> (No context info available)
> 2018-01-11 09:35:08,370 |ajp-nio-8009-exec-8 |FOUserAgent
> |E| Image not found. URI: /images/ofbiz_logo.png. (See position 37:54)
> 2018-01-11 09:35:08,603 |ajp-nio-8009-exec-8 |FOUserAgent
> |E| Image not found. URI: /images/ofbiz_logo.png. (No context info available)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-10128) Clean images, among them logos, in all locations used
[
https://issues.apache.org/jira/browse/OFBIZ-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324028#comment-16324028
]
Jacques Le Roux commented on OFBIZ-10128:
-
I fixed my previous commits, there is no themes webapp so no URL at
{{/themes/common/webapp/images/ofbiz_logo.png}} It's only
{{images/ofbiz_logo.png}}.
Done at r1820978+1820980+1820982. It's also wrong in R17 so I reverted r1820867
at r1820993 but made things consistent at r1820995
> Clean images, among them logos, in all locations used
> -
>
> Key: OFBIZ-10128
> URL: https://issues.apache.org/jira/browse/OFBIZ-10128
> Project: OFBiz
> Issue Type: Task
>Reporter: Jacques Le Roux
>Priority: Minor
>
> This is a copy of what [I said in dev
> ML|http://markmail.org/message/ubx6he4z22vtat3r]
> bq. It would be great if we could use the same logo everywhere and get rid of
> old version at least in svn trunk It's a mess in general with images. There
> are 3 locations: svn repo, main site and wiki. We should link as much as
> possible from our svn repo. I even wonder if we should not ALWAYS link to it,
> even from the main site!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9972) Find an alternative suitable syntax for OFBiz rule tasks in gradle
[ https://issues.apache.org/jira/browse/OFBIZ-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324018#comment-16324018 ] Taher Alkhateeb commented on OFBIZ-9972: Useful links for ideas: - https://stackoverflow.com/questions/11696521/how-to-pass-arguments-from-command-line-to-gradle - https://stackoverflow.com/questions/27604283/gradle-task-pass-arguments-to-java-application - https://issues.gradle.org/browse/GRADLE-1804 > Find an alternative suitable syntax for OFBiz rule tasks in gradle > -- > > Key: OFBIZ-9972 > URL: https://issues.apache.org/jira/browse/OFBIZ-9972 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb > > In testing OFBiz with a new version of gradle, I identified a potential > problem. The rule based tasks such as "ofbiz --test" will not work in > versions 5 and above. The exact error message that I received is: > The task name 'ofbiz --test' contains at least one of the following > characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is > scheduled to be removed in Gradle 5.0. > In other words, spaces are not allowed. We need to find an alternative > solution. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9832) Provide ability for OFBiz to publish plugins to Nexus maven repository
[ https://issues.apache.org/jira/browse/OFBIZ-9832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-9832: --- Affects Version/s: (was: 17.12.01) Upcoming Branch > Provide ability for OFBiz to publish plugins to Nexus maven repository > -- > > Key: OFBIZ-9832 > URL: https://issues.apache.org/jira/browse/OFBIZ-9832 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Priority: Minor > > This JIRA has reference to the > [discussion|http://markmail.org/message/bjvqu23ofwzuk57y] in the community > regarding separating plugins into a separate project. > I have requested from Infra the creation of a maven repository for OFBiz in > INFRA-13924 which they accomplished very quickly. > Now we need to upgrade the plugin manager in build.gradle to provide the > ability to publish all plugins to this remote maven repository. > I am not sure, but this might be a good chance to remove all plugin > management logic from build.gradle and perhaps move it into a gradle-plugin > or another gradle file to reduce the size of build.gradle -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-9873) Create a PoC for a documentation system for OFBiz based on Asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-9873: --- Affects Version/s: (was: 17.12.01) Upcoming Branch > Create a PoC for a documentation system for OFBiz based on Asciidoc > --- > > Key: OFBIZ-9873 > URL: https://issues.apache.org/jira/browse/OFBIZ-9873 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > > In reference to the [discussion > thread|https://lists.apache.org/thread.html/8cc03b7b8733512244129ddae9e0cc1fb2a28e3e250aba1c8cf678f8@%3Cdev.ofbiz.apache.org%3E] > this is an attempt to create a PoC for OFBiz documentation system based on > Asciidoc. The main assumptions for the design of this system are: > - The documentation language to use is Asciidoc > - The documentation tool is Asciidoctor > - Publishing happens through Gradle using the asciidoctor gradle plugin (not > the OFBiz framework or anything else). > - The only place where we write documentation is inside the code base > - Every component contains its own documentation > - General documentation goes to either a standalone directory or a generic > component like common or base > - As much as possible, documentation files are small and focused on one > topic. And then other longer documents are constructed from these snippets of > documentation. > - We publish to all formats including PDF for users, or HTML for embedded > help and wiki pages. So OFBiz does not parse docbook for its help system, > instead it just renders generated HTML. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-10128) Clean images, among them logos, in all locations used
[ https://issues.apache.org/jira/browse/OFBIZ-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323892#comment-16323892 ] Jacques Le Roux commented on OFBIZ-10128: - OK this is partially wrong. I'll review all ASAP and fix issues. > Clean images, among them logos, in all locations used > - > > Key: OFBIZ-10128 > URL: https://issues.apache.org/jira/browse/OFBIZ-10128 > Project: OFBiz > Issue Type: Task >Reporter: Jacques Le Roux >Priority: Minor > > This is a copy of what [I said in dev > ML|http://markmail.org/message/ubx6he4z22vtat3r] > bq. It would be great if we could use the same logo everywhere and get rid of > old version at least in svn trunk It's a mess in general with images. There > are 3 locations: svn repo, main site and wiki. We should link as much as > possible from our svn repo. I even wonder if we should not ALWAYS link to it, > even from the main site! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-9383) Birt plugin depends on example plugin
[ https://issues.apache.org/jira/browse/OFBIZ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9383. -- Resolution: Fixed At revision in trunk 1820973 I simply duplicated examples data in birt component. There are cases where duplication is the simplest solution even at the cost of possible divergence in the future (not a problem for the birt component, so it's OK) Backported in R17 at revision: 1820975 I backported Taher's last change at 1820962 in R17 at r1820975 > Birt plugin depends on example plugin > -- > > Key: OFBIZ-9383 > URL: https://issues.apache.org/jira/browse/OFBIZ-9383 > Project: OFBiz > Issue Type: Bug > Components: birt >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Jacques Le Roux > Fix For: 17.12.01 > > > The BIRT demo data for flexible reports depends on the Example entity from > the Example plugin. > We should either provide BIRT's own example data with example reports OR > setup a gradle dependency on the example plugin so that everything is in > place. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (OFBIZ-10159) Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
[
https://issues.apache.org/jira/browse/OFBIZ-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-10159.
---
Resolution: Fixed
Fix Version/s: 16.11.05
17.12.01
Thanks Dennis,
Your patch is in
trunk r1820966
R17.12 r1820967
R16.11 r1820968
> Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
> -
>
> Key: OFBIZ-10159
> URL: https://issues.apache.org/jira/browse/OFBIZ-10159
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01, 16.11.05
>
> Attachments: 10159.patch
>
>
> The method {{findOne()}} which is set in the
> {{OfbizDslDescriptorForEclipse.dsld}} is wrong, since there is no
> implementation for this method, which only has a {{String}} and a {{List}} as
> parameters. I changed it to the correct method, so it can be used within
> groovy properly, also I put an implementation in the GroovyBaseScriptFile
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (OFBIZ-10159) Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
[
https://issues.apache.org/jira/browse/OFBIZ-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-10159:
---
Assignee: Jacques Le Roux
> Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
> -
>
> Key: OFBIZ-10159
> URL: https://issues.apache.org/jira/browse/OFBIZ-10159
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: 10159.patch
>
>
> The method {{findOne()}} which is set in the
> {{OfbizDslDescriptorForEclipse.dsld}} is wrong, since there is no
> implementation for this method, which only has a {{String}} and a {{List}} as
> parameters. I changed it to the correct method, so it can be used within
> groovy properly, also I put an implementation in the GroovyBaseScriptFile
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9383) Birt plugin depends on example plugin
[ https://issues.apache.org/jira/browse/OFBIZ-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323820#comment-16323820 ] Taher Alkhateeb commented on OFBIZ-9383: Reverted in r1820962 the code which caused issues in installing the BIRT component. Between the two solutions that Michael suggested, I think the cleaner one is to "provide BIRT's own example data with example reports". I think maybe If BIRT is going to depend on something then it should be a core component, not another plugin. Less dependencies means less state, less wiring, and less complexity > Birt plugin depends on example plugin > -- > > Key: OFBIZ-9383 > URL: https://issues.apache.org/jira/browse/OFBIZ-9383 > Project: OFBiz > Issue Type: Bug > Components: birt >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Jacques Le Roux > Fix For: 17.12.01 > > > The BIRT demo data for flexible reports depends on the Example entity from > the Example plugin. > We should either provide BIRT's own example data with example reports OR > setup a gradle dependency on the example plugin so that everything is in > place. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OFBIZ-10159) Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
[
https://issues.apache.org/jira/browse/OFBIZ-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-10159:
--
Description: The method {{findOne()}} which is set in the
{{OfbizDslDescriptorForEclipse.dsld}} is wrong, since there is no
implementation for this method, which only has a {{String}} and a {{List}} as
parameters. I changed it to the correct method, so it can be used within groovy
properly, also I put an implementation in the GroovyBaseScriptFile (was: The
method {{findOne()}} which is set in the {{OfbizDslDescriptorForEclipse.dsld}}
is wrong, since there is no implementation for this method, which only has a
{{String}} and a {{List}} as parameters. I changed it to the correct method, so
it can be used within groovy properly)
> Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
> -
>
> Key: OFBIZ-10159
> URL: https://issues.apache.org/jira/browse/OFBIZ-10159
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: 10159.patch
>
>
> The method {{findOne()}} which is set in the
> {{OfbizDslDescriptorForEclipse.dsld}} is wrong, since there is no
> implementation for this method, which only has a {{String}} and a {{List}} as
> parameters. I changed it to the correct method, so it can be used within
> groovy properly, also I put an implementation in the GroovyBaseScriptFile
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OFBIZ-10159) Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
[
https://issues.apache.org/jira/browse/OFBIZ-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-10159:
--
Attachment: 10159.patch
> Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
> -
>
> Key: OFBIZ-10159
> URL: https://issues.apache.org/jira/browse/OFBIZ-10159
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: 10159.patch
>
>
> The method {{findOne()}} which is set in the
> {{OfbizDslDescriptorForEclipse.dsld}} is wrong, since there is no
> implementation for this method, which only has a {{String}} and a {{List}} as
> parameters. I changed it to the correct method, so it can be used within
> groovy properly
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (OFBIZ-10156) Fix issues related to images paths
[
https://issues.apache.org/jira/browse/OFBIZ-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-10156.
---
Resolution: Fixed
Fix Version/s: 17.12.01
I confirm it's OK, closing
> Fix issues related to images paths
> --
>
> Key: OFBIZ-10156
> URL: https://issues.apache.org/jira/browse/OFBIZ-10156
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
>
> While working on OFBIZ-10128 I stumbled upon this issue found on trunk demo
> {code}
> 2018-01-11 09:30:28,159 |ajp-nio-8009-exec-4 |FOUserAgent
> |E| Image not found. URI:
> /example/control/qrcode;jsessionid=6E1C4C1E84C4C96F370B89A44201DEEC.jvm1?message=Example%201=bmp=UTF-8=true=20=20.
> (See position 47:77)
> 2018-01-11 09:30:29,183 |ajp-nio-8009-exec-4 |FOUserAgent
> |E| Image not found. URI:
> /example/control/qrcode;jsessionid=6E1C4C1E84C4C96F370B89A44201DEEC.jvm1?message=Example%201=bmp=UTF-8=true=20=20.
> (No context info available)
> 2018-01-11 09:35:08,370 |ajp-nio-8009-exec-8 |FOUserAgent
> |E| Image not found. URI: /images/ofbiz_logo.png. (See position 37:54)
> 2018-01-11 09:35:08,603 |ajp-nio-8009-exec-8 |FOUserAgent
> |E| Image not found. URI: /images/ofbiz_logo.png. (No context info available)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-10128) Clean images, among them logos, in all locations used
[ https://issues.apache.org/jira/browse/OFBIZ-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323810#comment-16323810 ] Jacques Le Roux commented on OFBIZ-10128: - Completed at revision 1820961 , for logo in trunk theme which completes r1820862 I don't close yet because I want to clean and make things consistent more... later... > Clean images, among them logos, in all locations used > - > > Key: OFBIZ-10128 > URL: https://issues.apache.org/jira/browse/OFBIZ-10128 > Project: OFBiz > Issue Type: Task >Reporter: Jacques Le Roux >Priority: Minor > > This is a copy of what [I said in dev > ML|http://markmail.org/message/ubx6he4z22vtat3r] > bq. It would be great if we could use the same logo everywhere and get rid of > old version at least in svn trunk It's a mess in general with images. There > are 3 locations: svn repo, main site and wiki. We should link as much as > possible from our svn repo. I even wonder if we should not ALWAYS link to it, > even from the main site! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OFBIZ-10159) Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
Dennis Balkir created OFBIZ-10159:
-
Summary: Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
Key: OFBIZ-10159
URL: https://issues.apache.org/jira/browse/OFBIZ-10159
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Trunk
Reporter: Dennis Balkir
Priority: Minor
The method {{findOne()}} which is set in the
{{OfbizDslDescriptorForEclipse.dsld}} is wrong, since there is no
implementation for this method, which only has a {{String}} and a {{List}} as
parameters. I changed it to the correct method, so it can be used within groovy
properly
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Closed] (OFBIZ-10158) Find Employee Position does not allow "don't care" for boolean fields
[ https://issues.apache.org/jira/browse/OFBIZ-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10158. --- Resolution: Fixed Fix Version/s: (was: Trunk) 16.11.05 17.12.01 Hi Paul, Since this is a bug, we need to backport the fix in release branches. I did it for you at R17.12 r1820956 R16.11 r1820957 Also we don't put trunk in "Fix versions/s" field, that's explained at https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-ManageJIRA%27sissues Thanks > Find Employee Position does not allow "don't care" for boolean fields > - > > Key: OFBIZ-10158 > URL: https://issues.apache.org/jira/browse/OFBIZ-10158 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Minor > Fix For: 17.12.01, 16.11.05 > > Attachments: OFBIZ-10158_FindEmplPosition_booleans.patch > > > In the demo app, go to > https://demo-stable.ofbiz.apache.org/humanres/control/FindEmplPositions, > click on New Employee Position, and toggle one of the four flags, e.g. set > Temporary Flag to N. > Now on the Find screen, there is no way to find all employee positions: it > insists on a Yes or No for the flags. This patch allows a blank "don't care" > option. > Thanks to Larissa Zanoni at Blockfreight for discovering this issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Reopened] (OFBIZ-10158) Find Employee Position does not allow "don't care" for boolean fields
[ https://issues.apache.org/jira/browse/OFBIZ-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-10158: - > Find Employee Position does not allow "don't care" for boolean fields > - > > Key: OFBIZ-10158 > URL: https://issues.apache.org/jira/browse/OFBIZ-10158 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Trunk >Reporter: Paul Foxworthy >Assignee: Paul Foxworthy >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10158_FindEmplPosition_booleans.patch > > > In the demo app, go to > https://demo-stable.ofbiz.apache.org/humanres/control/FindEmplPositions, > click on New Employee Position, and toggle one of the four flags, e.g. set > Temporary Flag to N. > Now on the Find screen, there is no way to find all employee positions: it > insists on a Yes or No for the flags. This patch allows a blank "don't care" > option. > Thanks to Larissa Zanoni at Blockfreight for discovering this issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
