[jira] [Commented] (OFBIZ-9403) DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted (refactored) code from getMimeType(...) method
[ https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326808#comment-16326808 ] Deepak Dixit commented on OFBIZ-9403: - Thanks Martin, I think no need to pass default parameter in method. > DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted > (refactored) code from getMimeType(...) method > - > > Key: OFBIZ-9403 > URL: https://issues.apache.org/jira/browse/OFBIZ-9403 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk >Reporter: Martin Becker >Assignee: Deepak Dixit >Priority: Trivial > Attachments: OFBIZ-9403_DataResourceWorker-getMimeType.patch > > > The method DataResourceWorker.getMimeType(GenericValue) has been refactored > into two separate methods. The new additional method > getMimeTypeFromFileName(Delegator,Filename) solely focuses on getting the > MimeType from the file extension and is invoked by getMimeType(GenericValue) > if needed. getMimeType returns the type if possible via the data resource. > This results in cleaner code with the responsibility of both methods clearly > defined by the methods names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10137) Order : Communication between customer and product store
[ https://issues.apache.org/jira/browse/OFBIZ-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326732#comment-16326732 ] Shi Jinghai commented on OFBIZ-10137: - Hi Julien, I uploaded a screenshot of our CRM system based on OFBiz and Asterisk. Please ignore the English words as it's used in Chinese. There's a Service Direction Indicator to indicate a communication is IN or OUT. Kind Regards, > Order : Communication between customer and product store > > > Key: OFBIZ-10137 > URL: https://issues.apache.org/jira/browse/OFBIZ-10137 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Julien NICOLAS >Assignee: Julien NICOLAS >Priority: Minor > Attachments: ServiceDirectionIndicator.png > > > We are working for a customer to add a communication management linked to > orders between the customer and the product store. > It will use communication events and add a new communication screenlet at the > bottom of the order screen of the back office. > We plan to commit modifications to the trunk. > If anybody have some suggestions about this point, don't hesitate to share, > we will be pleased to fit to the community recommendations. > The discussion started here: http://markmail.org/message/hq2zfmy3zyqefm6v -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10137) Order : Communication between customer and product store
[ https://issues.apache.org/jira/browse/OFBIZ-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shi Jinghai updated OFBIZ-10137: Attachment: ServiceDirectionIndicator.png > Order : Communication between customer and product store > > > Key: OFBIZ-10137 > URL: https://issues.apache.org/jira/browse/OFBIZ-10137 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Julien NICOLAS >Assignee: Julien NICOLAS >Priority: Minor > Attachments: ServiceDirectionIndicator.png > > > We are working for a customer to add a communication management linked to > orders between the customer and the product store. > It will use communication events and add a new communication screenlet at the > bottom of the order screen of the back office. > We plan to commit modifications to the trunk. > If anybody have some suggestions about this point, don't hesitate to share, > we will be pleased to fit to the community recommendations. > The discussion started here: http://markmail.org/message/hq2zfmy3zyqefm6v -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7779) Update wiki Eclipse pages regarding Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326476#comment-16326476 ] Jacques Le Roux commented on OFBIZ-7779: "Pivotal EGradle IDE" is now my tool of choice > Update wiki Eclipse pages regarding Gradle > -- > > Key: OFBIZ-7779 > URL: https://issues.apache.org/jira/browse/OFBIZ-7779 > Project: OFBiz > Issue Type: Task > Components: Confluence >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 16.11.01 > > Attachments: Image 007.png, OFBIZ-7779.patch, OFBIZ-7779.patch, > compile.error, neon.error > > > I wanted to update the 2 wiki Eclipse pages regarding Gradle. But so far got > some issues in my environment (still Windows 7). > I use both Eclipse Luna and Mars (Mars at 98%). Luna does not support Gradle. > First I must say my Mars instance works perfectly, but for few months I'm > unable to update. I did not try yet to create another Mars instance because I > guess it will anyway screws its update mechanism later :/ > Mars comes with the embedded ["Gradle Buildship" > plugin|https://gradle.org/eclipse/], I have the 1.0.5 version from > 2015-09-22. I found this tuto > http://www.vogella.com/tutorials/EclipseGradle/article.html (with a 6/7 > clone/redundant section). > Few remarks: I see no Gradle context menu entrie, maybe due to my unability > to update Mars, so I'm unable to "add Gradle support to existing Eclipse > project ". So I created a Gradle "trunk" side project following , but, though > all work well in command line, in Eclipse building with Gradle does not work. > I always get (see compile.error) > Of course I tried (4th) to install Eclipse Neon, to no avail, so far the best > I got (at least I eventually got something) is in neon.error > I'll continue later... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10028) Update Geo information according to ISO notifications
[
https://issues.apache.org/jira/browse/OFBIZ-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326471#comment-16326471
]
Jacques Le Roux commented on OFBIZ-10028:
-
Moldova (the Republic of) is in
trunk r1821186
R17.12 r1821187
I backported in R17 because I need to trigger the build in Buildbot.
> Update Geo information according to ISO notifications
> -
>
> Key: OFBIZ-10028
> URL: https://issues.apache.org/jira/browse/OFBIZ-10028
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10028_ISO_Geo_Info_Notification_CN.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_CY.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_CY.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_DE.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_EC.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_HU.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_ID.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_IS.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_KP.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_LA.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_MD.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_MH.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_ML.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_MX.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_NR.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_PA.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_PK.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_QA.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_TG.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_TJ.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_UG.patch
>
>
> This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq,
> extract!
> bq. If someone is interested, the China changes are a bit to heavy for me,
> Here are the changes
> {quote}
> Country codes updated
> CN 2017-11-23 /China/
> CY 2017-11-23 /Cyprus/
> DE 2017-11-23 /Germany/
> EC 2017-11-23 /Ecuador/
> HK 2017-11-23 /Hong Kong/
> HU 2017-11-23 /Hungary/
> ID 2017-11-23 /Indonesia/
> IS 2017-11-23 /Iceland/
> KP 2017-11-23 /Korea (the
> Democratic People's Republic of)/
> LA 2017-11-23 /Lao
> People's Democratic Republic (the)/
> MD 2017-11-23 /Moldova
> (the Republic of)/
> MH 2017-11-23 /Marshall
> Islands (the)/
> ML 2017-11-23 /Mali/
> MO 2017-11-23 /Macao/
> MX 2017-11-23 /Mexico/
> NR 2017-11-23 /Nauru/
> PA 2017-11-23 /Panama/
> PK 2017-11-23 /Pakistan/
> QA 2017-11-23 /Qatar/
> TG 2017-11-23 /Togo/
> TJ 2017-11-23 /Tajikistan/
> UG 2017-11-23 /Uganda/
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10166) Update Solr/lucene to 7.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326457#comment-16326457 ] Jacques Le Roux commented on OFBIZ-10166: - Thanks Michael, I added a comment to remind committers about that in both Solr and Lucene build.gradle files > Update Solr/lucene to 7.2.1 > --- > > Key: OFBIZ-10166 > URL: https://issues.apache.org/jira/browse/OFBIZ-10166 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk > Environment: Update Solr/Lucene to 7.2.1 >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: 17.12.01 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10166) Update Solr/lucene to 7.2.1
[ https://issues.apache.org/jira/browse/OFBIZ-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10166. - Resolution: Implemented Fix Version/s: 17.12.01 Done at r1821176. Reminder: please make sure that you change the LUCENE_VERSION constant in SearchWorker.java to match with the dependency version. This was missed in the last update. > Update Solr/lucene to 7.2.1 > --- > > Key: OFBIZ-10166 > URL: https://issues.apache.org/jira/browse/OFBIZ-10166 > Project: OFBiz > Issue Type: Improvement > Components: lucene, solr >Affects Versions: Trunk > Environment: Update Solr/Lucene to 7.2.1 >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: 17.12.01 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10166) Update Solr/lucene to 7.2.1
Michael Brohl created OFBIZ-10166: - Summary: Update Solr/lucene to 7.2.1 Key: OFBIZ-10166 URL: https://issues.apache.org/jira/browse/OFBIZ-10166 Project: OFBiz Issue Type: Improvement Components: lucene, solr Affects Versions: Trunk Environment: Update Solr/Lucene to 7.2.1 Reporter: Michael Brohl Assignee: Michael Brohl -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10096) Error on updating sub content of CMS webSIte
[
https://issues.apache.org/jira/browse/OFBIZ-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-10096.
---
Resolution: Fixed
Fix Version/s: 17.12.01
> Error on updating sub content of CMS webSIte
>
>
> Key: OFBIZ-10096
> URL: https://issues.apache.org/jira/browse/OFBIZ-10096
> Project: OFBiz
> Issue Type: Bug
> Components: content
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10096.patch, screenshot-1.png
>
>
> Steps to reproduce:
> 1. Go to Content component
> https://demo-trunk.ofbiz.apache.org/content/control/main
> 2. Click on webSiteId link of any website with sub-content as webpage
> (https://demo-trunk.ofbiz.apache.org/content/control/EditWebSite?webSiteId=CmsSite)
> 3. Click on CMS from submenu
> (https://demo-trunk.ofbiz.apache.org/content/control/WebSiteCms?webSiteId=CmsSite)
> 4. From WebSIteNav, click on Cms Site Demo Home page
> Edit content in editor and click save button (available in editor)
> It gives error:
> {quote}
> The Following Errors Occurred:
> The following required parameter is missing: [IN]
> [updateContentAssoc.contentIdTo]
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10012) Alert message : "Developer: for lookups to work you must provide a form name!" appears when try to select contentId from Lookup
[ https://issues.apache.org/jira/browse/OFBIZ-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326363#comment-16326363 ] Jacques Le Roux commented on OFBIZ-10012: - Good news, thanks Aditya and Deepak > Alert message : "Developer: for lookups to work you must provide a form > name!" appears when try to select contentId from Lookup > --- > > Key: OFBIZ-10012 > URL: https://issues.apache.org/jira/browse/OFBIZ-10012 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Sonal Patwari >Assignee: Deepak Dixit >Priority: Blocker > Attachments: ContentSearchOptionsAlertShowing (1).png > > > Steps to reproduce: > 1. Go to [Content > Component|https://demo-trunk.ofbiz.apache.org/content/control/main] > 2. Click on Content from > [submenu|https://demo-trunk.ofbiz.apache.org/content/control/findContent]. > 3. Click on the Advanced Search button > [https://demo-trunk.ofbiz.apache.org/content/control/ContentSearchOptions]. > 4. Provide Content Id. > 5. User should be able to see the alert message. > 6. For reference screenshot is attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10096) Error on updating sub content of CMS webSIte
[
https://issues.apache.org/jira/browse/OFBIZ-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326296#comment-16326296
]
Aditya Sharma commented on OFBIZ-10096:
---
Thanks Jacques :) I am working on OFBIZ-10093 replacing the elrte plugin so if
the change is minor I will add a patch along with that only. So we can close it
for now.
> Error on updating sub content of CMS webSIte
>
>
> Key: OFBIZ-10096
> URL: https://issues.apache.org/jira/browse/OFBIZ-10096
> Project: OFBiz
> Issue Type: Bug
> Components: content
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-10096.patch, screenshot-1.png
>
>
> Steps to reproduce:
> 1. Go to Content component
> https://demo-trunk.ofbiz.apache.org/content/control/main
> 2. Click on webSiteId link of any website with sub-content as webpage
> (https://demo-trunk.ofbiz.apache.org/content/control/EditWebSite?webSiteId=CmsSite)
> 3. Click on CMS from submenu
> (https://demo-trunk.ofbiz.apache.org/content/control/WebSiteCms?webSiteId=CmsSite)
> 4. From WebSIteNav, click on Cms Site Demo Home page
> Edit content in editor and click save button (available in editor)
> It gives error:
> {quote}
> The Following Errors Occurred:
> The following required parameter is missing: [IN]
> [updateContentAssoc.contentIdTo]
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10012) Alert message : "Developer: for lookups to work you must provide a form name!" appears when try to select contentId from Lookup
[ https://issues.apache.org/jira/browse/OFBIZ-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326291#comment-16326291 ] Aditya Sharma commented on OFBIZ-10012: --- I had a discussion with [~deepak.dixit] regarding it, we will cover it under OFBIZ-9851. We are working on it and will provide patch asap. > Alert message : "Developer: for lookups to work you must provide a form > name!" appears when try to select contentId from Lookup > --- > > Key: OFBIZ-10012 > URL: https://issues.apache.org/jira/browse/OFBIZ-10012 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Sonal Patwari >Assignee: Deepak Dixit >Priority: Blocker > Attachments: ContentSearchOptionsAlertShowing (1).png > > > Steps to reproduce: > 1. Go to [Content > Component|https://demo-trunk.ofbiz.apache.org/content/control/main] > 2. Click on Content from > [submenu|https://demo-trunk.ofbiz.apache.org/content/control/findContent]. > 3. Click on the Advanced Search button > [https://demo-trunk.ofbiz.apache.org/content/control/ContentSearchOptions]. > 4. Provide Content Id. > 5. User should be able to see the alert message. > 6. For reference screenshot is attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326286#comment-16326286 ] Aditya Sharma edited comment on OFBIZ-10113 at 1/15/18 2:33 PM: Thanks Jacques :) I have created a new ticket OFBIZ-10165 and will cover it under OFBIZ-9465. I will add a detailed description when I will pick that. was (Author: aditya.sharma): Thanks Jacques :) I have created a new ticket OFBIZ-10165 and will cover it under OFBIZ-9465. > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, > select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326286#comment-16326286 ] Aditya Sharma commented on OFBIZ-10113: --- Thanks Jacques :) I have created a new ticket OFBIZ-10165 and will cover it under OFBIZ-9465. > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, > select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10165) Review and refactor implementation of select multiple
Aditya Sharma created OFBIZ-10165: - Summary: Review and refactor implementation of select multiple Key: OFBIZ-10165 URL: https://issues.apache.org/jira/browse/OFBIZ-10165 Project: OFBiz Issue Type: Sub-task Environment: The js code for select multiple needs to be reviewed and refactored. We can minimize code in SetMultipleSelectJsList.ftl and SetMultipleSelectJs.ftl and even prepare some generic code in ofbizutils.js. Reporter: Aditya Sharma Assignee: Aditya Sharma -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9403) DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted (refactored) code from getMimeType(...) method
[ https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326282#comment-16326282 ] Martin Becker commented on OFBIZ-9403: -- Hi Deepak, yes, you are right, (now) I would name it getMimeType, too. I had chosen getMimeTypeFromFileName inspired by getMimeTypeFromImageFileName in the same class, I think. The returning of the default mime-type octet-stream is because I did not want to change the behavior of the getMimeType method like it was before my refactoring, which actually returns this default if there is no mimeTypeId defined at the DataResource and therefore the method looks for a mimeType determined from filename (so it assumes it is a file and returns octet-stream if there is no special mimeType by file extension). Maybe we should add a default parameter to the method signatures to optionally give in a default mime type if the caller needs one. > DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted > (refactored) code from getMimeType(...) method > - > > Key: OFBIZ-9403 > URL: https://issues.apache.org/jira/browse/OFBIZ-9403 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk >Reporter: Martin Becker >Assignee: Deepak Dixit >Priority: Trivial > Attachments: OFBIZ-9403_DataResourceWorker-getMimeType.patch > > > The method DataResourceWorker.getMimeType(GenericValue) has been refactored > into two separate methods. The new additional method > getMimeTypeFromFileName(Delegator,Filename) solely focuses on getting the > MimeType from the file extension and is invoked by getMimeType(GenericValue) > if needed. getMimeType returns the type if possible via the data resource. > This results in cleaner code with the responsibility of both methods clearly > defined by the methods names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10028) Update Geo information according to ISO notifications
[
https://issues.apache.org/jira/browse/OFBIZ-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326191#comment-16326191
]
Jacques Le Roux commented on OFBIZ-10028:
-
Lao People's Democratic Republic (the) is in
trunk r1821144
R17.12 r1821149
> Update Geo information according to ISO notifications
> -
>
> Key: OFBIZ-10028
> URL: https://issues.apache.org/jira/browse/OFBIZ-10028
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10028_ISO_Geo_Info_Notification_CN.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_CY.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_CY.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_DE.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_EC.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_HU.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_ID.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_IS.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_KP.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_LA.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_MD.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_MH.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_ML.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_MX.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_NR.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_PA.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_PK.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_QA.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_TG.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_TJ.patch,
> OFBIZ-10028_ISO_Geo_Info_Notification_UG.patch
>
>
> This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq,
> extract!
> bq. If someone is interested, the China changes are a bit to heavy for me,
> Here are the changes
> {quote}
> Country codes updated
> CN 2017-11-23 /China/
> CY 2017-11-23 /Cyprus/
> DE 2017-11-23 /Germany/
> EC 2017-11-23 /Ecuador/
> HK 2017-11-23 /Hong Kong/
> HU 2017-11-23 /Hungary/
> ID 2017-11-23 /Indonesia/
> IS 2017-11-23 /Iceland/
> KP 2017-11-23 /Korea (the
> Democratic People's Republic of)/
> LA 2017-11-23 /Lao
> People's Democratic Republic (the)/
> MD 2017-11-23 /Moldova
> (the Republic of)/
> MH 2017-11-23 /Marshall
> Islands (the)/
> ML 2017-11-23 /Mali/
> MO 2017-11-23 /Macao/
> MX 2017-11-23 /Mexico/
> NR 2017-11-23 /Nauru/
> PA 2017-11-23 /Panama/
> PK 2017-11-23 /Pakistan/
> QA 2017-11-23 /Qatar/
> TG 2017-11-23 /Togo/
> TJ 2017-11-23 /Tajikistan/
> UG 2017-11-23 /Uganda/
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9708) Create missing services definitions in WorkEffortSimpleServices.xml
[ https://issues.apache.org/jira/browse/OFBIZ-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325712#comment-16325712 ] Jacques Le Roux edited comment on OFBIZ-9708 at 1/15/18 10:42 AM: -- Thanks Pawan, Your patch is in trunk at revision: 1821114 I finally did not create Junit tests for the new services was (Author: jacques.le.roux): Thanks Pawan, Your patch is in trunk at revision: 1821114 > Create missing services definitions in WorkEffortSimpleServices.xml > --- > > Key: OFBIZ-9708 > URL: https://issues.apache.org/jira/browse/OFBIZ-9708 > Project: OFBiz > Issue Type: Improvement >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-9708.patch > > > In WorkEffortSimpleServices.xml the service implementations from > updateWorkEffortContactMech to updateWorkEffortEmailAddress are missing > service definitions. > This was discussed at http://markmail.org/message/kgbpolz2daxfa5zx. Thanks to > Pawan Verma for reporting, everyone for the discussion and Scott for the > detailed argumentation which makes totally sense. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326057#comment-16326057 ] Jacques Le Roux commented on OFBIZ-10113: - Hi Aditya, You said bq. I have replaced the plugins though I feel the implementation of select multiple js code is to be reviewed & refactored. I will pick when I am done with all my current tasks if I get some consensus. I agree, a new task will be welcome, great work so far :) > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, > select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326015#comment-16326015 ] Jacques Le Roux commented on OFBIZ-10113: - At r1821121 I committed a change in FormWidgetExampleForms that was missing from r1821001 > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, > select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
