date:20180117


[ 
https://issues.apache.org/jira/browse/OFBIZ-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329340#comment-16329340
 ] 

Jacques Le Roux commented on OFBIZ-2842:


Thanks Michael, yes that seems faisable and there are good ideas explained in 
the above discussion.

> Add mocked unit test framework
> --
>
> Key: OFBIZ-2842
> URL: https://issues.apache.org/jira/browse/OFBIZ-2842
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Bob Morley
>Priority: Major
> Attachments: OFBIZ-2842.patch, mockito-all-1.8.0-rc2.jar
>
>
> Add the ability to create "true" unit tests -- ones that only test the 
> confines of the method itself and using mocking techniques and dependency 
> injection.  This focuses the unit test on the actual code in the method and 
> makes the assumption that other methods have been properly tested and will 
> work.  This does not suggest that there is not also value in unit tests that 
> test more of an integration between components (such as a test that will 
> actually invoke services using a the real dispatcher and manipulate entities 
> with the real delegator).
> The goal of this will be to make it easy and very quick to test java-based 
> methods (initial focus on services) along with not having to start an ofbiz 
> container creating a suite of very quick method focused unit tests.
> I have attached a first pass at some of the base classes and a sample of a 
> "mostly complete" unit test for the DateDimensionServices class (which has 
> one method).  Looking for feedback on this approach, potential for community 
> collaboration, and potential buy-in.  Some other things that are still to be 
> done --
> - more samples
> - integration into ant build
> - solution to the "static worker" issue
> - UtilResourceBundle solution (I have it partially commented out)
> - easy verification of service interface adherence (servicedef existance & 
> IN/OUT validation)
> - potential for GenericEntity get/set validation (verify entitydef adherence) 
> (may not want to do this)
> - investigate potential for mocked simple methods
> - ant driven code coverage metrics



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-2842) Add mocked unit test framework

2018-01-17 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329036#comment-16329036
 ] 

Michael Brohl commented on OFBIZ-2842:
--

+1 for keeping it open and adapt to the current codebase. It's not too 
complicated it seems.

> Add mocked unit test framework
> --
>
> Key: OFBIZ-2842
> URL: https://issues.apache.org/jira/browse/OFBIZ-2842
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Bob Morley
>Priority: Major
> Attachments: OFBIZ-2842.patch, mockito-all-1.8.0-rc2.jar
>
>
> Add the ability to create "true" unit tests -- ones that only test the 
> confines of the method itself and using mocking techniques and dependency 
> injection.  This focuses the unit test on the actual code in the method and 
> makes the assumption that other methods have been properly tested and will 
> work.  This does not suggest that there is not also value in unit tests that 
> test more of an integration between components (such as a test that will 
> actually invoke services using a the real dispatcher and manipulate entities 
> with the real delegator).
> The goal of this will be to make it easy and very quick to test java-based 
> methods (initial focus on services) along with not having to start an ofbiz 
> container creating a suite of very quick method focused unit tests.
> I have attached a first pass at some of the base classes and a sample of a 
> "mostly complete" unit test for the DateDimensionServices class (which has 
> one method).  Looking for feedback on this approach, potential for community 
> collaboration, and potential buy-in.  Some other things that are still to be 
> done --
> - more samples
> - integration into ant build
> - solution to the "static worker" issue
> - UtilResourceBundle solution (I have it partially commented out)
> - easy verification of service interface adherence (servicedef existance & 
> IN/OUT validation)
> - potential for GenericEntity get/set validation (verify entitydef adherence) 
> (may not want to do this)
> - investigate potential for mocked simple methods
> - ant driven code coverage metrics



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-2842) Add mocked unit test framework


[ 
https://issues.apache.org/jira/browse/OFBIZ-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329019#comment-16329019
 ] 

Jacques Le Roux commented on OFBIZ-2842:


Unfortunately this patch is deprecated, but the idea is interesting. Should we 
close or adapt and continue, opinions?

> Add mocked unit test framework
> --
>
> Key: OFBIZ-2842
> URL: https://issues.apache.org/jira/browse/OFBIZ-2842
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Bob Morley
>Priority: Major
> Attachments: OFBIZ-2842.patch, mockito-all-1.8.0-rc2.jar
>
>
> Add the ability to create "true" unit tests -- ones that only test the 
> confines of the method itself and using mocking techniques and dependency 
> injection.  This focuses the unit test on the actual code in the method and 
> makes the assumption that other methods have been properly tested and will 
> work.  This does not suggest that there is not also value in unit tests that 
> test more of an integration between components (such as a test that will 
> actually invoke services using a the real dispatcher and manipulate entities 
> with the real delegator).
> The goal of this will be to make it easy and very quick to test java-based 
> methods (initial focus on services) along with not having to start an ofbiz 
> container creating a suite of very quick method focused unit tests.
> I have attached a first pass at some of the base classes and a sample of a 
> "mostly complete" unit test for the DateDimensionServices class (which has 
> one method).  Looking for feedback on this approach, potential for community 
> collaboration, and potential buy-in.  Some other things that are still to be 
> done --
> - more samples
> - integration into ant build
> - solution to the "static worker" issue
> - UtilResourceBundle solution (I have it partially commented out)
> - easy verification of service interface adherence (servicedef existance & 
> IN/OUT validation)
> - potential for GenericEntity get/set validation (verify entitydef adherence) 
> (may not want to do this)
> - investigate potential for mocked simple methods
> - ant driven code coverage metrics



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (OFBIZ-3499) help requires content component


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-3499.
--
   Resolution: Not A Problem
 Assignee: Jacques Le Roux
Fix Version/s: Upcoming Branch

We can close, helplink.ftl is now in theme

I put Upcoming Branch in fix versions in such cases because it's hard to define 
something else

 

> help requires content component
> ---
>
> Key: OFBIZ-3499
> URL: https://issues.apache.org/jira/browse/OFBIZ-3499
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: chris snow
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Help requires content component - see 
> /framework/common/webcommon/includes/helplink.ftl
> {code}
> <#assign pageAvail = delegator.findByAnd("ContentAssoc", {"mapKey" : 
> helpTopic})/>
> {code}
> My view is that content component should become part of the core framework.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-9833) Token Based Authentication


[ 
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328955#comment-16328955
 ] 

Jacques Le Roux commented on OFBIZ-9833:


At r1821230 in trunk and r1821231 I fixed a bug in 
ContextFilter.doFilter().getHeader() wrapper the name returned was hardcoded to 
"Authorisation"

Thanks to Deepak for report

> Token Based Authentication
> --
>
> Key: OFBIZ-9833
> URL: https://issues.apache.org/jira/browse/OFBIZ-9833
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: JSON Web Tokens.pdf, 
> OFBIZ-9833-external-server-test-example.patch, 
> OFBIZ-9833-external-server-test-example.patch, 
> OFBIZ-9833-external-server.patch, OFBIZ-9833-external-server.patch, 
> OFBIZ-9833-external-server.patch, Token Based Authentication in Apache 
> OfBiz.pdf, Token Based Authentication.pdf, rfc7519.pdf
>
>
> Here is dev list discussion for token based authentication work:
> http://markmail.org/message/vyskeh2wujqpkbwg



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10164) Splitter Widget

2018-01-17 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328926#comment-16328926
 ] 

Taher Alkhateeb commented on OFBIZ-10164:
-

Hello James,

Great work! may I ask why you chose the sizes format as a bracketed comma 
separated list (and how is it parsed)? And why do you have the parent id 
specified when it should be automatically implied from the structure?

> Splitter Widget
> ---
>
> Key: OFBIZ-10164
> URL: https://issues.apache.org/jira/browse/OFBIZ-10164
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10164.patch, horizontal.png, vertical.png
>
>
> A new splitter widget that will use a tag named 'splitter'.
> This splitter tag has the following attributes:
> a. sizes = [25, 75] where the containers within will be splitted with a ratio 
> of 25% and 75%
> b. parentId which is the ID of the parent container
> c. direction = vertical or horizonal (default)
> The splitter tag can only contains container(s) as immediate child.
> Using the library from http://nathancahill.github.io/Split.js/ which is 
> licensed under MIT license.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-3499) help requires content component


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-3499:
---
Description: 
Help requires content component - see 
/framework/common/webcommon/includes/helplink.ftl
{code}
<#assign pageAvail = delegator.findByAnd("ContentAssoc", {"mapKey" : 
helpTopic})/>
{code}

My view is that content component should become part of the core framework.

  was:
Help requires content component - see 
/framework/common/webcommon/includes/helplink.ftl

  <#assign pageAvail = delegator.findByAnd("ContentAssoc", {"mapKey" : 
helpTopic})/>

My view is that content component should become part of the core framework.


> help requires content component
> ---
>
> Key: OFBIZ-3499
> URL: https://issues.apache.org/jira/browse/OFBIZ-3499
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: chris snow
>Priority: Major
>
> Help requires content component - see 
> /framework/common/webcommon/includes/helplink.ftl
> {code}
> <#assign pageAvail = delegator.findByAnd("ContentAssoc", {"mapKey" : 
> helpTopic})/>
> {code}
> My view is that content component should become part of the core framework.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-3505) Data model to have Content and Party applications not dependant on other applications


[ 
https://issues.apache.org/jira/browse/OFBIZ-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328910#comment-16328910
 ] 

Jacques Le Roux commented on OFBIZ-3505:


Hi, I propose to close this issue after the move of data model

If nobody is against will do so in a week...


> Data model to have Content and Party applications not dependant on other 
> applications
> -
>
> Key: OFBIZ-3505
> URL: https://issues.apache.org/jira/browse/OFBIZ-3505
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Bruno Busco
>Priority: Minor
> Attachments: ofbiz_core.patch, party_to_agreement_entity_move.patch
>
>
> The patch attached is the work I did to try to have the Content and Party 
> applications not dependent on the other applications.
> The patch only changes the data model and not the application code also so 
> applying the patch results in a not working OFBiz.
> The purpose of the patch is to describe the solution I found to remove the 
> mentioned dependencies and, if agreed, could be the base to change the code 
> accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (OFBIZ-10113) Replace Asm select plugin with Select2.


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10113.
---
Resolution: Fixed

Thansk Aditya,

Your patch is in trunk at revision: 1821356  


> Replace Asm select plugin with Select2.
> ---
>
> Key: OFBIZ-10113
> URL: https://issues.apache.org/jira/browse/OFBIZ-10113
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10113.patch, OFBIZ-10113.patch, OFBIZ-10113.patch, 
> OFBIZ-10113_plugins.patch, select2.tar.gz
>
>
> Current Asm Select Plugin 
> (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced 
> with Select2 (https://select2.org/).
> * Select2 has much better community support on GitHub with 386 contributors 
> while Asm Select Plugin is handled by Ryan Cramer on 
> http://www.ryancramer.com/.
> * Select2 has 37 releases while Asm select has very few releases yet.
> * Both the plugin has MIT license.
> Refer https://select2.org/ and  https://github.com/select2/select2 for more 
> features and other information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (OFBIZ-9169) Make xssi prefix configurable


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9169.
--
Resolution: Fixed

Indeed Michael,

I must have been abused again by my (ab)use of svn changelists (ie I put 
general.properties in a changelist for another reason, forgot about it and then 
missed it, the last part is weird though)

I completed in 
trunk r1821386
R17.12 r1821387

> Make xssi prefix configurable
> -
>
> Key: OFBIZ-9169
> URL: https://issues.apache.org/jira/browse/OFBIZ-9169
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Chris Howe
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: xssiPrefix.patch
>
>
> In OFBIZ-5409 a prefix was added for GET ajax requests.  
> It would be beneficial if the prefix could be configured instead of hard coded



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (OFBIZ-9169) Make xssi prefix configurable


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9169:
--

Assignee: Jacques Le Roux  (was: Michael Brohl)

> Make xssi prefix configurable
> -
>
> Key: OFBIZ-9169
> URL: https://issues.apache.org/jira/browse/OFBIZ-9169
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Chris Howe
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: xssiPrefix.patch
>
>
> In OFBIZ-5409 a prefix was added for GET ajax requests.  
> It would be beneficial if the prefix could be configured instead of hard coded



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10113) Replace Asm select plugin with Select2.


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-10113:
--
Attachment: OFBIZ-10113.patch

> Replace Asm select plugin with Select2.
> ---
>
> Key: OFBIZ-10113
> URL: https://issues.apache.org/jira/browse/OFBIZ-10113
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10113.patch, OFBIZ-10113.patch, OFBIZ-10113.patch, 
> OFBIZ-10113_plugins.patch, select2.tar.gz
>
>
> Current Asm Select Plugin 
> (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced 
> with Select2 (https://select2.org/).
> * Select2 has much better community support on GitHub with 386 contributors 
> while Asm Select Plugin is handled by Ryan Cramer on 
> http://www.ryancramer.com/.
> * Select2 has 37 releases while Asm select has very few releases yet.
> * Both the plugin has MIT license.
> Refer https://select2.org/ and  https://github.com/select2/select2 for more 
> features and other information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10113) Replace Asm select plugin with Select2.


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-10113:
--
Attachment: (was: OFBIZ-10113.patch)

> Replace Asm select plugin with Select2.
> ---
>
> Key: OFBIZ-10113
> URL: https://issues.apache.org/jira/browse/OFBIZ-10113
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10113.patch, OFBIZ-10113.patch, OFBIZ-10113.patch, 
> OFBIZ-10113_plugins.patch, select2.tar.gz
>
>
> Current Asm Select Plugin 
> (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced 
> with Select2 (https://select2.org/).
> * Select2 has much better community support on GitHub with 386 contributors 
> while Asm Select Plugin is handled by Ryan Cramer on 
> http://www.ryancramer.com/.
> * Select2 has 37 releases while Asm select has very few releases yet.
> * Both the plugin has MIT license.
> Refer https://select2.org/ and  https://github.com/select2/select2 for more 
> features and other information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OFBIZ-10113) Replace Asm select plugin with Select2.


[ 
https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328795#comment-16328795
 ] 

Aditya Sharma edited comment on OFBIZ-10113 at 1/17/18 1:59 PM:


Ohh Yes!. Thanks Jacques :).   I should have even read the comment properly.

There is one more instance that should be updated.

Added another patch for 
themes/common/template/includes/SetMultipleSelectJsList.ftl file.


was (Author: aditya.sharma):
Ohh Yes!. Thanks Jacques  !/jira/images/icons/emoticons/smile.png!   I should 
have even read the comment properly.

There is one more instance that should be updated.

Added another patch for 
themes/common/template/includes/SetMultipleSelectJsList.ftl file.

> Replace Asm select plugin with Select2.
> ---
>
> Key: OFBIZ-10113
> URL: https://issues.apache.org/jira/browse/OFBIZ-10113
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10113.patch, OFBIZ-10113.patch, OFBIZ-10113.patch, 
> OFBIZ-10113_plugins.patch, select2.tar.gz
>
>
> Current Asm Select Plugin 
> (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced 
> with Select2 (https://select2.org/).
> * Select2 has much better community support on GitHub with 386 contributors 
> while Asm Select Plugin is handled by Ryan Cramer on 
> http://www.ryancramer.com/.
> * Select2 has 37 releases while Asm select has very few releases yet.
> * Both the plugin has MIT license.
> Refer https://select2.org/ and  https://github.com/select2/select2 for more 
> features and other information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10113) Replace Asm select plugin with Select2.


[ 
https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328795#comment-16328795
 ] 

Aditya Sharma commented on OFBIZ-10113:
---

Ohh Yes!. Thanks Jacques  !/jira/images/icons/emoticons/smile.png!   I should 
have even read the comment properly.

There is one more instance that should be updated.

Added another patch for 
themes/common/template/includes/SetMultipleSelectJsList.ftl file.

> Replace Asm select plugin with Select2.
> ---
>
> Key: OFBIZ-10113
> URL: https://issues.apache.org/jira/browse/OFBIZ-10113
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10113.patch, OFBIZ-10113.patch, OFBIZ-10113.patch, 
> OFBIZ-10113_plugins.patch, select2.tar.gz
>
>
> Current Asm Select Plugin 
> (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced 
> with Select2 (https://select2.org/).
> * Select2 has much better community support on GitHub with 386 contributors 
> while Asm Select Plugin is handled by Ryan Cramer on 
> http://www.ryancramer.com/.
> * Select2 has 37 releases while Asm select has very few releases yet.
> * Both the plugin has MIT license.
> Refer https://select2.org/ and  https://github.com/select2/select2 for more 
> features and other information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10113) Replace Asm select plugin with Select2.


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-10113:
--
Attachment: OFBIZ-10113.patch

> Replace Asm select plugin with Select2.
> ---
>
> Key: OFBIZ-10113
> URL: https://issues.apache.org/jira/browse/OFBIZ-10113
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10113.patch, OFBIZ-10113.patch, OFBIZ-10113.patch, 
> OFBIZ-10113_plugins.patch, select2.tar.gz
>
>
> Current Asm Select Plugin 
> (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced 
> with Select2 (https://select2.org/).
> * Select2 has much better community support on GitHub with 386 contributors 
> while Asm Select Plugin is handled by Ryan Cramer on 
> http://www.ryancramer.com/.
> * Select2 has 37 releases while Asm select has very few releases yet.
> * Both the plugin has MIT license.
> Refer https://select2.org/ and  https://github.com/select2/select2 for more 
> features and other information.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10168) Allow shutdown in Gradle without building the project

[
https://issues.apache.org/jira/browse/OFBIZ-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Karsten Tymann updated OFBIZ-10168:
---
Description:
*Allow to shutdown OFBiz server in Gradle without rebuilding the project*

This patch for the build.gradle allows to shutdown a running OFBiz instance
without
rebuilding the Java project. It allows for the shorter command
{code:java}
./gradlew ofbizShutdown{code}
as well as for the already known command
{code:java}
./gradlew "ofbiz --shutdown".{code}
Therefore there are no changes on the already known script calls with the
addition
of the new shorter way "ofbizShutdown".

"ofbizShutdown" can also be called with the portoffset parameter, passed via
{code:java}
./gradlew ofbizShutdown -Pportoffset=5000{code}
More information later.

The reason for the patch is that a rebuilding of the project just for shutting
the running instance down serves no purpose.
In order to run ofbiz in the background it is already compiled and therefore
usable
for shutting it down.
Additionally it also makes sense to be able to shutdown ofbiz even if the
current
changes are not compiling. Thus the shutdown does not depend on a compiling
project.

Furthermore I have changed the task definition in the method
*createOfbizCommandTask*
since it contains a very confusing syntax. For less experienced users one might
think that the task dependsOn the build as well as the input *taskName-task*.
I changed it so that the task name is the first parameter so that it becomes
more clear how the task is called and on what it depends.

Aside from the patch I want to suggest changes on the passing of the arguments
for
future development: The passing of arguments such as "--help" or "--shutdown"
is not the
intended way of using gradle, atleast not in the form we are doing it.

In my opinion there are 3 accepted Gradle ways of passing arguments:
1. via -D -> sets a system property of the JVM
2. via -P -> sets a project property
3. via writing custom tasks that implement the @Option annotation,
enabling to pass arguments in the "--option=value" syntax

While I can see that *1.* and *2.* can be tedious to implement the reading of
potential arguments, I still consider it as important to implement it in either
way.
OFBiz should not be unique in the sense of executing Gradle scripts and
passing parameters
so the work depends on us to be as close to the Gradle-Style as possible.
Technically
it is easy to do, again, its just a little tedious.
Another possibility would be to implement *3.* since it is similar to what we
want to achieve.
The command line options can be implemented in Gradle although it is an
internal feature.
This means that the feature is not intended for the public, although it is
considered to be
made for public use since 2013 by the Gradle developers.
It allows for a great syntax of passing options to the execution of a single
task:
{code:java}
./gradlew exampleTask --optionName optionvalue{code}
We can achieve such a syntax by defining a custom task:
{code:java}
import org.gradle.api.internal.tasks.options.Option

task exampleTask(type: exampleTask)

class exampleTask extends DefaultTask {
@Option(option = "optionName",
description = "Pass a parameter",
order = 1)
Object optionName

@TaskAction
void do() {
println optionName
}
}
{code}
Ultimately this is the way one would wish to pass task specific options. Since
Gradle is using it internal, I would consider to use it as well.

was:
*Allow to shutdown OFBiz server in Gradle without rebuilding the project*

"ofbizShutdown" can also be called with the portoffset parameter, passed via
{code:java}
./gradlew ofbizShutdown -Pportoffset=5000{code}
More information later.

[jira] [Updated] (OFBIZ-10168) Allow shutdown in Gradle without building the project


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karsten Tymann updated OFBIZ-10168:
---
Attachment: OFBIZ-10168_shutdown_without_build.patch

> Allow shutdown in Gradle without building the project
> -
>
> Key: OFBIZ-10168
> URL: https://issues.apache.org/jira/browse/OFBIZ-10168
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Karsten Tymann
>Priority: Minor
> Attachments: OFBIZ-10168_shutdown_without_build.patch
>
>
> *Allow to shutdown OFBiz server in Gradle without rebuilding the project*
> This patch for the build.gradle allows to shutdown a running OFBiz instance 
> without
>  rebuilding the Java project. It allows for the shorter command
> {code:java}
> ./gradlew ofbizShutdown{code}
> as well as for the already known command
> {code:java}
> ./gradlew "ofbiz --shutdown".{code}
> Therefore there are no changes on the already known script calls with the 
> addition
>  of the new shorter way "ofbizShutdown".
> "ofbizShutdown" can also be called with the portoffset parameter, passed via
> {code:java}
> ./gradlew ofbizShutdown -Pportoffset=5000{code}
> More information later.
> The reason for the patch is that a rebuilding of the project just for 
> shutting the running instance down serves no purpose.
>  In order to run ofbiz in the background it is already compiled and therefore 
> usable
>  for shutting it down.
>  Additionally it also makes sense to be able to shutdown ofbiz even if the 
> current
>  changes are not compiling. Thus the shutdown does not depend on a compiling 
> project.
> Furthermore I have changed the task definition in the method 
> *createOfbizCommandTask*
>  since it contains a very confusing syntax. For less experienced users one 
> might
>  think that the task dependsOn the build as well as the input *taskName-task*.
>  I changed it so that the task name is the first parameter so that it becomes
>  more clear how the task is called and on what it depends.
>  
> 
> Aside from the patch I want to suggest changes on the passing of the 
> arguments for
>  future development: The passing of arguments such as "--help" or 
> "--shutdown" is not the
>  intended way of using gradle, atleast not in the form we are doing it.
> In my opinion there are 3 accepted Gradle ways of passing arguments:
>  1. via -D -> sets a system property of the JVM
>  2. via -P -> sets a project property
>  3. via writing custom tasks that implement the @Option annotation,
>  enabling to pass arguments in the "--option=value" syntax
> While I can see that *1.* and *2.* can be tedious to implement the reading of 
> potential arguments, I still consider it as important to implement it in 
> either way.
>  OFBiz should not be unique in the sense of executing Gradle scripts and 
> passing parameters
>  so the work depends on us to be as close to the Gradle-Style as possible. 
> Technically
>  it is easy to do, again, its just a little tedious.
>  Another possibility would be to implement *3.* since it is similar to what 
> we want to achieve.
>  The command line options can be implemented in Gradle although it is an 
> internal feature.
>  This means that the feature is not intended for the public, although it is 
> considered to be
>  made for public use since 2013 by the Gradle developers.
>  It allows for a great syntax of passing options to the execution of a single 
> task:
> {code:java}
> ./gradlew exampleTask --optionName optionvalue{code}
> We can achieve such a syntax by defining a custom task:
> {code:java}
> import org.gradle.api.internal.tasks.options.Option
> task exampleTask(type: GenerateVersionFile)
> class exampleTask extends DefaultTask {
>     @Option(option = "optionName",
>     description = "Pass a parameter",
>     order = 1)
>     Object optionName
>     @TaskAction
>     void do() {
>   println optionName
>     }
> }
> {code}
> Ultimately this is the way one would wish to pass task specific options. Since
>  Gradle is using it internal, I would consider to use it as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10168) Allow shutdown in Gradle without building the project

[
https://issues.apache.org/jira/browse/OFBIZ-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Karsten Tymann updated OFBIZ-10168:
---
Description:
*Allow to shutdown OFBiz server in Gradle without rebuilding the project*

"ofbizShutdown" can also be called with the portoffset parameter, passed via
{code:java}
./gradlew ofbizShutdown -Pportoffset=5000{code}
More information later.

task exampleTask(type: GenerateVersionFile)

class exampleTask extends DefaultTask {
@Option(option = "optionName",
description = "Pass a parameter",
order = 1)
Object optionName

@TaskAction
void do() {
println optionName
}
}
{code}
Ultimately this is the way one would wish to pass task specific options. Since
Gradle is using it internal, I would consider to use it as well.

was:
*Allow to shutdown OFBiz server in Gradle without rebuilding the project*

This patch for the build.gradle allows to shutdown a running OFBiz instance
without
rebuilding the Java project. It allows for the shorter command

__
{code:java}
./gradlew ofbizShutdown{code}
__

as well as for the already known command

__
{code:java}
./gradlew "ofbiz --shutdown".{code}
__

Therefore there are no changes on the already known script calls with the
addition
of the new shorter way "ofbizShutdown".

"ofbizShutdown" can also be called with the portoffset parameter, passed via
{code:java}
./gradlew ofbizShutdown -Pportoffset=5000{code}

More information later.

Furthermore I have changed the task definition in the method
*createOfbizCommandTask*
since it contains a very confusing syntax. For less experienced users one might
think that the task

[jira] [Created] (OFBIZ-10168) Allow shutdown in Gradle without building the project

Karsten Tymann created OFBIZ-10168:
--

 Summary: Allow shutdown in Gradle without building the project
 Key: OFBIZ-10168
 URL: https://issues.apache.org/jira/browse/OFBIZ-10168
 Project: OFBiz
  Issue Type: Improvement
  Components: Gradle
Affects Versions: Trunk
Reporter: Karsten Tymann


*Allow to shutdown OFBiz server in Gradle without rebuilding the project*

This patch for the build.gradle allows to shutdown a running OFBiz instance 
without
rebuilding the Java project. It allows for the shorter command

__
{code:java}
./gradlew ofbizShutdown{code}
__

as well as for the already known command

__
{code:java}
./gradlew "ofbiz --shutdown".{code}
__

Therefore there are no changes on the already known script calls with the 
addition
of the new shorter way "ofbizShutdown".

"ofbizShutdown" can also be called with the portoffset parameter, passed via
{code:java}
./gradlew ofbizShutdown -Pportoffset=5000{code}

More information later.

The reason for the patch is that a rebuilding of the project just for shutting 
the running instance down serves no purpose.
In order to run ofbiz in the background it is already compiled and therefore 
usable
for shutting it down.
Additionally it also makes sense to be able to shutdown ofbiz even if the 
current
changes are not compiling. Thus the shutdown does not depend on a compiling 
project.

Furthermore I have changed the task definition in the method 
*createOfbizCommandTask*
since it contains a very confusing syntax. For less experienced users one might
think that the task dependsOn the build as well as the input *taskName-task*.
I changed it so that the task name is the first parameter so that it becomes
more clear how the task is called and on what it depends.

 




Aside from the patch I want to suggest changes on the passing of the arguments 
for
future development: The passing of arguments such as "--help" or "--shutdown" 
is not the
intended way of using gradle, atleast not in the form we are doing it.

In my opinion there are 3 accepted Gradle ways of passing arguments:
1. via -D -> sets a system property of the JVM
2. via -P -> sets a project property
3. via writing custom tasks that implement the @Option annotation,
enabling to pass arguments in the "--option=value" syntax

While I can see that *1.* and *2.* can be tedious to implement the reading of 
potential arguments, I still consider it as important to implement it in either 
way.
OFBiz should not be unique in the sense of executing Gradle scripts and passing 
parameters
so the work depends on us to be as close to the Gradle-Style as possible. 
Technically
it is easy to do, again, its just a little tedious.
Another possibility would be to implement *3.* since it is similar to what we 
want to achieve.
The command line options can be implemented in Gradle although it is an 
internal feature.
This means that the feature is not intended for the public, although it is 
considered to be
made for public use since 2013 by the Gradle developers.
It allows for a great syntax of passing options to the execution of a single 
task:


{code:java}
./gradlew exampleTask --optionName optionvalue{code}


We can achieve such a syntax by defining a custom task:


{code:java}
import org.gradle.api.internal.tasks.options.Option

task exampleTask(type: GenerateVersionFile)

class exampleTask extends DefaultTask {
    @Option(option = "optionName",
    description = "Pass a parameter",
    order = 1)
    Object optionName

    @TaskAction
    void do() {
  println optionName
    }
}
{code}

Ultimately this is the way one would wish to pass task specific options. Since
Gradle is using it internal, I would consider to use it as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OFBIZ-10122) Not able to add the requirement,broken screen with the error message in workeffort component

2018-01-17 Thread Rubia Elza Joshep (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rubia Elza Joshep updated OFBIZ-10122:
--
Fix Version/s: 16.11.05

> Not able to add the requirement,broken screen with the error message in 
> workeffort component
> 
>
> Key: OFBIZ-10122
> URL: https://issues.apache.org/jira/browse/OFBIZ-10122
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Reporter: Rubia Elza Joshep
>Assignee: Yogesh Naroliya
>Priority: Major
> Fix For: 16.11.05
>
> Attachments: screenshot-1.png
>
>
> Steps to regenerate:
> 1) Open URL https://demo-trunk.ofbiz.apache.org/sfa/control/Events
> 2) Click on the event created.
> 3) To add the requirements of events, click on the "Requirements" button.
> 4) Add the existing requirement Id or add a new requirement. Click on Save.
> Actual: Not able to add the requirement. Broken screen with the error message.
> Note: Refer the screenshot attached. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (OFBIZ-6946) Remove ftl dependency in order on ecommerce


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6946.
--
   Resolution: Done
Fix Version/s: Upcoming Branch

Thanks Pierre for report,

I simply removed the commented out lines, no need for a patch. There are still 
a lot of other dependencies in the order component on the  ecommerce 
component...

> Remove ftl dependency in order on ecommerce
> ---
>
> Key: OFBIZ-6946
> URL: https://issues.apache.org/jira/browse/OFBIZ-6946
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6946-order-template-location.patch
>
>
> Currently there are dependencies in the order component on the ecommerce 
> component.
> Order management should work without the ecommerce component.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10122) Not able to add the requirement,broken screen with the error message in workeffort component

2018-01-17 Thread Yogesh Naroliya (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328652#comment-16328652
 ] 

Yogesh Naroliya commented on OFBIZ-10122:
-

[~rubia.joseph] Thanks for reporting the issue. I have successfully replicated 
the issue. Also started working on it, will provide the patch soon to fix the 
reported issue.

> Not able to add the requirement,broken screen with the error message in 
> workeffort component
> 
>
> Key: OFBIZ-10122
> URL: https://issues.apache.org/jira/browse/OFBIZ-10122
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Reporter: Rubia Elza Joshep
>Assignee: Yogesh Naroliya
>Priority: Major
> Attachments: screenshot-1.png
>
>
> Steps to regenerate:
> 1) Open URL https://demo-trunk.ofbiz.apache.org/sfa/control/Events
> 2) Click on the event created.
> 3) To add the requirements of events, click on the "Requirements" button.
> 4) Add the existing requirement Id or add a new requirement. Click on Save.
> Actual: Not able to add the requirement. Broken screen with the error message.
> Note: Refer the screenshot attached. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (OFBIZ-10122) Not able to add the requirement,broken screen with the error message in workeffort component

2018-01-17 Thread Yogesh Naroliya (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yogesh Naroliya reassigned OFBIZ-10122:
---

Assignee: Yogesh Naroliya

> Not able to add the requirement,broken screen with the error message in 
> workeffort component
> 
>
> Key: OFBIZ-10122
> URL: https://issues.apache.org/jira/browse/OFBIZ-10122
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Reporter: Rubia Elza Joshep
>Assignee: Yogesh Naroliya
>Priority: Major
> Attachments: screenshot-1.png
>
>
> Steps to regenerate:
> 1) Open URL https://demo-trunk.ofbiz.apache.org/sfa/control/Events
> 2) Click on the event created.
> 3) To add the requirements of events, click on the "Requirements" button.
> 4) Add the existing requirement Id or add a new requirement. Click on Save.
> Actual: Not able to add the requirement. Broken screen with the error message.
> Note: Refer the screenshot attached. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Reopened] (OFBIZ-9169) Make xssi prefix configurable

2018-01-17 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reopened OFBIZ-9169:
--

This patch was not fully committed it seems. There is only the change in 
CommonEvents.java but not the additional entry in general.properties.

We'll provide a patch for it.

> Make xssi prefix configurable
> -
>
> Key: OFBIZ-9169
> URL: https://issues.apache.org/jira/browse/OFBIZ-9169
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Chris Howe
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: xssiPrefix.patch
>
>
> In OFBIZ-5409 a prefix was added for GET ajax requests.  
> It would be beneficial if the prefix could be configured instead of hard coded



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10113) Replace Asm select plugin with Select2.