[jira] [Commented] (OFBIZ-10164) Splitter Widget

2018-01-20 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1628#comment-1628
 ] 

Taher Alkhateeb commented on OFBIZ-10164:
-

Okay so I see based on your feedback a number of problems. This is making the 
widget system too tightly coupled to HTML (just like we discussed in rhe email 
thread).  The dependence of a widget on a javascript library and hard wiring of 
logic is removing the neutrality of the widget system.

I recommend revisiting the whole design and approaching it in a platform 
independe t way.

> Splitter Widget
> ---
>
> Key: OFBIZ-10164
> URL: https://issues.apache.org/jira/browse/OFBIZ-10164
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10164.patch, horizontal.png, vertical.png
>
>
> A new splitter widget that will use a tag named 'splitter'.
> This splitter tag has the following attributes:
> a. sizes = [25, 75] where the containers within will be splitted with a ratio 
> of 25% and 75%
> b. parentId which is the ID of the parent container
> c. direction = vertical or horizonal (default)
> The splitter tag can only contains container(s) as immediate child.
> Using the library from http://nathancahill.github.io/Split.js/ which is 
> licensed under MIT license.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10038) In Rainbow theme the navigation banner is not high enough

2018-01-20 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10038:

Issue Type: Sub-task  (was: Improvement)
Parent: OFBIZ-6881

> In Rainbow theme the navigation banner is not high enough
> -
>
> Key: OFBIZ-10038
> URL: https://issues.apache.org/jira/browse/OFBIZ-10038
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: Image 004.png, Image 005.png, Image 006.png
>
>
> During my test for OFBIZ-9978 I found this trivial UI issue in lookups. It's 
> unrelated with changes for OFBIZ-9978 because it's reproductible on trunk 
> demo today !Image 005.png! 
> 
> But is OK in stable !Image 004.png!. 
> 
> It's ok with other themes on trunk demo today, at least Tomahawk !Image 
> 006.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9866) Rainbow theme: if you set the Arab language it's difficult to get back to another language

2018-01-20 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9866:
---
Issue Type: Sub-task  (was: Bug)
Parent: OFBIZ-6881

> Rainbow theme: if you set the Arab language it's difficult to get back to 
> another language
> --
>
> Key: OFBIZ-9866
> URL: https://issues.apache.org/jira/browse/OFBIZ-9866
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> If,using the Rainbow theme, you set the Arab language it's difficult to get 
> back to another language.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9866) Rainbow theme: if you set the Arab language it's difficult to get back to another language

2018-01-20 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333183#comment-16333183
 ] 

Jacques Le Roux commented on OFBIZ-9866:


About the flag missing there are a lot others. I guess we miss these flags...

> Rainbow theme: if you set the Arab language it's difficult to get back to 
> another language
> --
>
> Key: OFBIZ-9866
> URL: https://issues.apache.org/jira/browse/OFBIZ-9866
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> If,using the Rainbow theme, you set the Arab language it's difficult to get 
> back to another language.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10035) Accounting AP and Accounting AR should be removed from Rainbow Top Menu

2018-01-20 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10035:

Issue Type: Sub-task  (was: Bug)
Parent: OFBIZ-6881

> Accounting AP and Accounting AR should be removed from Rainbow Top Menu
> ---
>
> Key: OFBIZ-10035
> URL: https://issues.apache.org/jira/browse/OFBIZ-10035
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the top menu in the Rainbow theme shows"
> Accounting
> Accounting - AP
> Accounting - AR
> AP and AR are sub-functions of Accounting and should not be shown. Like we 
> don't show SalesOrder and PurchaseOrder sub-functions, or IncomingGoods and 
> OutgoingGoods functions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10174) With Rainbow theme, a scrollbar appears at bottom where it's not needed

2018-01-20 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10174:

Issue Type: Sub-task  (was: Improvement)
Parent: OFBIZ-6881

> With Rainbow theme, a scrollbar appears at bottom where it's not needed
> ---
>
> Key: OFBIZ-10174
> URL: https://issues.apache.org/jira/browse/OFBIZ-10174
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Jacques Le Roux
>Priority: Minor
>
> With Rainbow theme, even in large screens, a scrollbar appears at bottom 
> where it's useless.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

2018-01-20 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333180#comment-16333180
 ] 

Jacques Le Roux commented on OFBIZ-5157:


Hi Dennis,

I had a quick look. Adding
{code:xml}
Index: ShoppingListServices.xml
===
--- ShoppingListServices.xml(revision 1821740)
+++ ShoppingListServices.xml(working copy)
@@ -236,7 +236,7 @@
 
 

-
+
 
 
 
@@ -257,7 +257,7 @@
 
 
 
-
+
 
 
 
{code}

is not enough. You get this error
{code}
  at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112]
2018-01-20 13:51:31,782 |jsse-nio-8443-exec-6 |ShoppingListEvents
|E| null
org.apache.ofbiz.service.ServiceAuthException: User authorization is required 
for this service: createShoppingList
{code}

I let you discover the the whole log error. Jira now limits the number of chars 
in comments and also don't limit the size of the code block shown in visual 
mode, some find it better, I don't.

Actually it comes from the authorisation in checkShoppingListSecurity and 
checkShoppingListItemSecurity. So to work you need to tweak this part, this 
works
{code:xml}
Index: servicedef/services_shoppinglist.xml
===
--- servicedef/services_shoppinglist.xml(revision 1821740)
+++ servicedef/services_shoppinglist.xml(working copy)
@@ -33,7 +33,7 @@
 
 Create a shopping list entity
-
+
 
 
 
@@ -120,7 +120,7 @@
 
 Create a shopping list item
-
+
 
 
 
{code}
But is of course not what we want ;) I did not digg deeper...

> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch, 
> OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting 
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following 
> security error occures:
> {code}
>  [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [ 
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en) 
> created in 0.031s with 4 properties
>  [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
>  [java]  exception report 
> --
>  [java] [TransactionUtil.setRollbackOnly] Calling transaction 
> setRollbackOnly; this stack trace shows where this is happening:
>  [java] Exception: java.lang.Exception
>  [java] Message: Error in simple-method [Create a ShoppingList Item 
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
>  [java]  stack trace 
> ---
>  [java] java.lang.Exception: Error in simple-method [Create a 
> ShoppingList Item 
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
>  [java] 
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
>  [java] 
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
>  [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
>  [java] 
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
>  [java] 
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
>  [java] 
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
>  [java] 
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
>  [java] 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
>  [java] 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
>  [java] 
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
>  [java] 
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
>  [java] 
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
>  [java] 
> 

[jira] [Comment Edited] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

2018-01-20 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333180#comment-16333180
 ] 

Jacques Le Roux edited comment on OFBIZ-5157 at 1/20/18 1:37 PM:
-

Hi Dennis,

I had a quick look. Adding
{code:xml}
Index: ShoppingListServices.xml
===
--- ShoppingListServices.xml(revision 1821740)
+++ ShoppingListServices.xml(working copy)
@@ -236,7 +236,7 @@
 
 

-
+
 
 
 
@@ -257,7 +257,7 @@
 
 
 
-
+
 
 
 
{code}

is not enough. You get this error
{code}
  at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112]
2018-01-20 13:51:31,782 |jsse-nio-8443-exec-6 |ShoppingListEvents
|E| null
org.apache.ofbiz.service.ServiceAuthException: User authorization is required 
for this service: createShoppingList
{code}

I let you discover the whole log error. Jira now limits the number of chars in 
comments and also don't limit the size of the code block shown in visual mode, 
some find it better, I don't.

Actually it comes from the authorisation in checkShoppingListSecurity and 
checkShoppingListItemSecurity. So to work you need to tweak this part, this 
works
{code:xml}
Index: servicedef/services_shoppinglist.xml
===
--- servicedef/services_shoppinglist.xml(revision 1821740)
+++ servicedef/services_shoppinglist.xml(working copy)
@@ -33,7 +33,7 @@
 
 Create a shopping list entity
-
+
 
 
 
@@ -120,7 +120,7 @@
 
 Create a shopping list item
-
+
 
 
 
{code}
But is of course not what we want ;) I did not digg deeper...


was (Author: jacques.le.roux):
Hi Dennis,

I had a quick look. Adding
{code:xml}
Index: ShoppingListServices.xml
===
--- ShoppingListServices.xml(revision 1821740)
+++ ShoppingListServices.xml(working copy)
@@ -236,7 +236,7 @@
 
 

-
+
 
 
 
@@ -257,7 +257,7 @@
 
 
 
-
+
 
 
 
{code}

is not enough. You get this error
{code}
  at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112]
2018-01-20 13:51:31,782 |jsse-nio-8443-exec-6 |ShoppingListEvents
|E| null
org.apache.ofbiz.service.ServiceAuthException: User authorization is required 
for this service: createShoppingList
{code}

I let you discover the the whole log error. Jira now limits the number of chars 
in comments and also don't limit the size of the code block shown in visual 
mode, some find it better, I don't.

Actually it comes from the authorisation in checkShoppingListSecurity and 
checkShoppingListItemSecurity. So to work you need to tweak this part, this 
works
{code:xml}
Index: servicedef/services_shoppinglist.xml
===
--- servicedef/services_shoppinglist.xml(revision 1821740)
+++ servicedef/services_shoppinglist.xml(working copy)
@@ -33,7 +33,7 @@
 
 Create a shopping list entity
-
+
 
 
 
@@ -120,7 +120,7 @@
 
 Create a shopping list item
-
+
 
 
 
{code}
But is of course not what we want ;) I did not digg deeper...

> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch, 
> OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting 
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following 
> security error occures:
> {code}
>  [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [ 
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en) 
> created in 0.031s with 4 properties
>  [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
>  [java]  exception report 
> --
>  [java] [TransactionUtil.setRollbackOnly] Calling transaction 
> setRollbackOnly; this stack trace shows where this is happening:
>  [java] Exception: java.lang.Exception
>