[jira] [Updated] (OFBIZ-10177) Fixe a bug in avatar.ftl when the last name does not exist

2018-01-22 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10177:

Summary: Fixe a bug in avatar.ftl when the last name does not exist  (was: 
Fixe a but in avatar.ftl when the last name does not exist)

> Fixe a bug in avatar.ftl when the last name does not exist
> --
>
> Key: OFBIZ-10177
> URL: https://issues.apache.org/jira/browse/OFBIZ-10177
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Trunk, 17.12.01, 16.11.05
>Reporter: Jacques Le Roux
>Priority: Trivial
> Fix For: 17.12.01, 16.11.05
>
> Attachments: OFBIZ-10177.patch
>
>
> I propose this patch: both 1st and last name must be present else it's 
> confusing and better to show the username
> Withough comments in a week, I'll commit



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10177) Fixe a but in avatar.ftl when the last name does not exist

2018-01-22 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10177:

Attachment: OFBIZ-10177.patch

> Fixe a but in avatar.ftl when the last name does not exist
> --
>
> Key: OFBIZ-10177
> URL: https://issues.apache.org/jira/browse/OFBIZ-10177
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: themes
>Affects Versions: Trunk, 17.12.01, 16.11.05
>Reporter: Jacques Le Roux
>Priority: Trivial
> Fix For: 17.12.01, 16.11.05
>
> Attachments: OFBIZ-10177.patch
>
>
> I propose this patch: both 1st and last name must be present else it's 
> confusing and better to show the username
> Withough comments in a week, I'll commit



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10177) Fixe a but in avatar.ftl when the last name does not exist

2018-01-22 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-10177:
---

 Summary: Fixe a but in avatar.ftl when the last name does not exist
 Key: OFBIZ-10177
 URL: https://issues.apache.org/jira/browse/OFBIZ-10177
 Project: OFBiz
  Issue Type: Sub-task
  Components: themes
Affects Versions: Trunk, 17.12.01, 16.11.05
Reporter: Jacques Le Roux
 Fix For: 17.12.01, 16.11.05


I propose this patch: both 1st and last name must be present else it's 
confusing and better to show the username

Withough comments in a week, I'll commit



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-4931) Proposal to remove catalog's "Template Path Prefix" and "Content Path Prefix"

2018-01-22 Thread Wai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334295#comment-16334295
 ] 

Wai edited comment on OFBIZ-4931 at 1/22/18 2:14 PM:
-

It's been awhile since I logged this one. What do you mean by "...it's useful 
in the standard context...".  What is a standard context?  Things work fine as 
long as you don't enter any value for this field. But you'll get an exception 
if you do. Which implies that this field is useless.

 From a multitenant perspective, a tenant should not have to know that a 
resource belongs to another tenant. It assumes that all resources belong to 
itself.


was (Author: wt):
It's been awhile since I logged this one. What do you mean by "...it's useful 
in the standard context...".  What is a standard context?  Things work fine as 
long as you don't enter any value for this field. But you'll get an exception 
if you do. Which implies that this field is useless.

 

> Proposal to remove catalog's "Template Path Prefix" and "Content Path Prefix"
> -
>
> Key: OFBIZ-4931
> URL: https://issues.apache.org/jira/browse/OFBIZ-4931
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Wai
>Priority: Major
> Attachments: OFBIZ-4931.patch
>
>
> In reference to the posting, 
> http://ofbiz.135035.n4.nabble.com/Proposal-to-remove-catalog-s-quot-Template-Path-Prefix-quot-field-from-user-interface-td4633296.html
> http://demo-trunk.ofbiz.apache.org/catalog/control/EditProdCatalog?prodCatalogId=DemoCatalog
> It seems that the code blindly prepends the "Template Path Prefix" value to 
> the category's "Detail Screen" field resulting in a file path format that 
> would cause an exception.
> Hence, if a catalog's "Template Path Prefix" is "zzz" and a category's 
> "Detail Screen" is "somedetailscreen", the resulting screen that ofbiz looks 
> for is "/zzzsomedetailscreen".  Which ofbiz would not be able to locate based 
> on the format of the screen location.  Hence, cause an exception.
> If a catalog's "Template Path Prefix" is "zzz" and a category's "Detail 
> Screen" is 
> "component://ecommerce/widget/CatalogScreens.xml#somedetailscreen", the 
> resulting screen that ofbiz looks for is 
> "/zzzcomponent://ecommerce/widget/CatalogScreens.xml#somedetailscreen".  
> Which ofbiz would not be able to located due to the improper format. Hence 
> cause an exception.
> Since this code never worked since 2006 when it was first placed into the svn 
> repository.  I don't think anyone has made use of it since.
> Regarding a catalog's "Content Path Prefix" field, it also exhibits the same 
> flaw. That of blindly prepending this field.  This field is generally used to 
> specify the product images to be shown in the ecommerce component.
> When this field is empty, the generated image url in ecommerce is shown below 
> (note that it is using "image" webapp context):
> /images/products/ENCHILADAS/small.png
> If you were to specify "/zzz" for "Content Path Prefix", the resulting url 
> for the generated image tag is shown below (note that it is using "zzz" 
> webapp context):
> /zzz/images/products/ENCHILADAS/small.png
> As you can see.  "Content Path Prefix" specifies a "zzz" webapp context with 
> a subdirectory "image".  I doubt this was the intent of the field.  The 
> question is, where exactly are you supposed to place this field value? 
> I propose to remove the catalog's "Template Path Prefix" field from the 
> catalog's user interface and assoc code to reduce the confusion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4931) Proposal to remove catalog's "Template Path Prefix" and "Content Path Prefix"

2018-01-22 Thread Wai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334295#comment-16334295
 ] 

Wai commented on OFBIZ-4931:


It's been awhile since I logged this one. What do you mean by "...it's useful 
in the standard context...".  What is a standard context?  Things work fine as 
long as you don't enter any value for this field. But you'll get an exception 
if you do. Which implies that this field is useless.

 

> Proposal to remove catalog's "Template Path Prefix" and "Content Path Prefix"
> -
>
> Key: OFBIZ-4931
> URL: https://issues.apache.org/jira/browse/OFBIZ-4931
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Wai
>Priority: Major
> Attachments: OFBIZ-4931.patch
>
>
> In reference to the posting, 
> http://ofbiz.135035.n4.nabble.com/Proposal-to-remove-catalog-s-quot-Template-Path-Prefix-quot-field-from-user-interface-td4633296.html
> http://demo-trunk.ofbiz.apache.org/catalog/control/EditProdCatalog?prodCatalogId=DemoCatalog
> It seems that the code blindly prepends the "Template Path Prefix" value to 
> the category's "Detail Screen" field resulting in a file path format that 
> would cause an exception.
> Hence, if a catalog's "Template Path Prefix" is "zzz" and a category's 
> "Detail Screen" is "somedetailscreen", the resulting screen that ofbiz looks 
> for is "/zzzsomedetailscreen".  Which ofbiz would not be able to locate based 
> on the format of the screen location.  Hence, cause an exception.
> If a catalog's "Template Path Prefix" is "zzz" and a category's "Detail 
> Screen" is 
> "component://ecommerce/widget/CatalogScreens.xml#somedetailscreen", the 
> resulting screen that ofbiz looks for is 
> "/zzzcomponent://ecommerce/widget/CatalogScreens.xml#somedetailscreen".  
> Which ofbiz would not be able to located due to the improper format. Hence 
> cause an exception.
> Since this code never worked since 2006 when it was first placed into the svn 
> repository.  I don't think anyone has made use of it since.
> Regarding a catalog's "Content Path Prefix" field, it also exhibits the same 
> flaw. That of blindly prepending this field.  This field is generally used to 
> specify the product images to be shown in the ecommerce component.
> When this field is empty, the generated image url in ecommerce is shown below 
> (note that it is using "image" webapp context):
> /images/products/ENCHILADAS/small.png
> If you were to specify "/zzz" for "Content Path Prefix", the resulting url 
> for the generated image tag is shown below (note that it is using "zzz" 
> webapp context):
> /zzz/images/products/ENCHILADAS/small.png
> As you can see.  "Content Path Prefix" specifies a "zzz" webapp context with 
> a subdirectory "image".  I doubt this was the intent of the field.  The 
> question is, where exactly are you supposed to place this field value? 
> I propose to remove the catalog's "Template Path Prefix" field from the 
> catalog's user interface and assoc code to reduce the confusion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10176) Add an option "All" to show entities of all groups

2018-01-22 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10176:

Affects Version/s: 17.12.01
Fix Version/s: 17.12.01

Thanks Deepak,

I added the version to fix, I checked R16 is OK

> Add an option "All" to show entities of all groups
> --
>
> Key: OFBIZ-10176
> URL: https://issues.apache.org/jira/browse/OFBIZ-10176
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: 17.12.01
>Reporter: Vaibhav Jain
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: Image 003.png
>
>
> Steps to regenerate:
>  # Click on Entity Engine tab of Webtools.
>  # By default entities of all the groups are listed down.
>  # If we apply a filter then entities are listed according to the group.
>  # We don't have an option "All" to list entities of all groups.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10176) Add an option "All" to show entities of all groups

2018-01-22 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334077#comment-16334077
 ] 

Deepak Dixit commented on OFBIZ-10176:
--

Hi Jacques,

Its working on trunk but missing in release17.12,

> Add an option "All" to show entities of all groups
> --
>
> Key: OFBIZ-10176
> URL: https://issues.apache.org/jira/browse/OFBIZ-10176
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Vaibhav Jain
>Priority: Minor
> Attachments: Image 003.png
>
>
> Steps to regenerate:
>  # Click on Entity Engine tab of Webtools.
>  # By default entities of all the groups are listed down.
>  # If we apply a filter then entities are listed according to the group.
>  # We don't have an option "All" to list entities of all groups.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10164) Splitter Widget

2018-01-22 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334028#comment-16334028
 ] 

Jacques Le Roux commented on OFBIZ-10164:
-

Hi James,

I did not review, nor tested, nor anything: could the "custom CSS for the 
Commons Widget" not be defined in a new style.css in common-theme? We could 
then also have common themes css definitions in this file. Not sure it makes 
much sense, just thinking.

> Splitter Widget
> ---
>
> Key: OFBIZ-10164
> URL: https://issues.apache.org/jira/browse/OFBIZ-10164
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, horizontal.png, 
> vertical.png
>
>
> A new splitter widget that will use a tag named 'splitter'.
> This splitter tag has the following attributes:
> a. sizes = [25, 75] where the containers within will be splitted with a ratio 
> of 25% and 75%
> b. parentId which is the ID of the parent container
> c. direction = vertical or horizonal (default)
> The splitter tag can only contains container(s) as immediate child.
> Using the library from http://nathancahill.github.io/Split.js/ which is 
> licensed under MIT license.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10176) Add an option "All" to show entities of all groups

2018-01-22 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334018#comment-16334018
 ] 

Jacques Le Roux commented on OFBIZ-10176:
-

Hi Vaibhav,

I see it in !Image 003.png! 
So what's the problem? If you have entered a name simply remove the name, 
because filtering on the name blocks filtering less ("All" for instance)

If it's OK with you please close as "Not a Problem", thanks.

> Add an option "All" to show entities of all groups
> --
>
> Key: OFBIZ-10176
> URL: https://issues.apache.org/jira/browse/OFBIZ-10176
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Vaibhav Jain
>Priority: Minor
> Attachments: Image 003.png
>
>
> Steps to regenerate:
>  # Click on Entity Engine tab of Webtools.
>  # By default entities of all the groups are listed down.
>  # If we apply a filter then entities are listed according to the group.
>  # We don't have an option "All" to list entities of all groups.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10176) Add an option "All" to show entities of all groups

2018-01-22 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10176:

Attachment: Image 003.png

> Add an option "All" to show entities of all groups
> --
>
> Key: OFBIZ-10176
> URL: https://issues.apache.org/jira/browse/OFBIZ-10176
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Vaibhav Jain
>Priority: Minor
> Attachments: Image 003.png
>
>
> Steps to regenerate:
>  # Click on Entity Engine tab of Webtools.
>  # By default entities of all the groups are listed down.
>  # If we apply a filter then entities are listed according to the group.
>  # We don't have an option "All" to list entities of all groups.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

2018-01-22 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334013#comment-16334013
 ] 

Jacques Le Roux commented on OFBIZ-5157:


This thread is related http://markmail.org/message/3clskx6ixat3hriu

> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch, 
> OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting 
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following 
> security error occures:
> {code}
>  [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [ 
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en) 
> created in 0.031s with 4 properties
>  [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
>  [java]  exception report 
> --
>  [java] [TransactionUtil.setRollbackOnly] Calling transaction 
> setRollbackOnly; this stack trace shows where this is happening:
>  [java] Exception: java.lang.Exception
>  [java] Message: Error in simple-method [Create a ShoppingList Item 
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
>  [java]  stack trace 
> ---
>  [java] java.lang.Exception: Error in simple-method [Create a 
> ShoppingList Item 
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
>  [java] 
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
>  [java] 
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
>  [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
>  [java] 
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
>  [java] 
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
>  [java] 
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
>  [java] 
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
>  [java] 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
>  [java] 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
>  [java] 
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
>  [java] 
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
>  [java] 
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
>  [java] 
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
>  [java] 
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
>  [java] 
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
>  [java] 
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
>  [java] 
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
>  [java] 
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)