[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339489#comment-16339489 ] Dennis Balkir commented on OFBIZ-10031: --- Hey [~soledad], I applied your suggested changes to this file and deleted the "login-rewquired tag?" comment, since this question was answered in the mailing-list by you and [~jacques.le.roux]. Thanks for that! I hope this makes the file a bit better and if there still is something to do please tell me so I can make the needed changes > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339489#comment-16339489 ] Dennis Balkir edited comment on OFBIZ-10031 at 1/25/18 4:49 PM: Hey [~soledad], I applied your suggested changes to this file and deleted the "login-rewquired tag?" comment, since this question was answered in the mailing-list by you and [~jacques.le.roux]. Thanks for that! I hope this makes the file a bit better and if there still is something to do please tell me so I can make the needed changes PS: I left the old patch, if I made any mistakes, so it is possible to look at the unaltered version was (Author: dennis balkir): Hey [~soledad], I applied your suggested changes to this file and deleted the "login-rewquired tag?" comment, since this question was answered in the mailing-list by you and [~jacques.le.roux]. Thanks for that! I hope this makes the file a bit better and if there still is something to do please tell me so I can make the needed changes > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10031: -- Attachment: OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7467) WebSocket Example - Push Notifications
[ https://issues.apache.org/jira/browse/OFBIZ-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339211#comment-16339211 ] Jacques Le Roux commented on OFBIZ-7467: Thanks Deepak! > WebSocket Example - Push Notifications > -- > > Key: OFBIZ-7467 > URL: https://issues.apache.org/jira/browse/OFBIZ-7467 > Project: OFBiz > Issue Type: Sub-task > Components: example >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Jacques Le Roux >Priority: Major > Fix For: 16.11.01, 17.12.01 > > Attachments: OFBIZ-7467.patch, OFBIZ-7483-Screen-Shot.png > > > This is a ticket for adding working example (in example application) of > WebSocket support that has been done in OFBIZ-7073 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7073) Add WebSocket support in OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339210#comment-16339210
]
Jacques Le Roux commented on OFBIZ-7073:
Thanks Deepak!
> Add WebSocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7073.patch, OFBIZ-7073.patch,
> tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar
> in catalina lib and created one webapp for websocket and also added server
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets
> implementation need jar scanning enabled and it is currently disabled in
> OFBiz. Below is the code snippet of disabling jar scan from
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of
> minutes (in my case, it took approx 8 minutes), so we don't want this much of
> startup time for OFBiz.
>
> I got the following document where I found the reason why websocket is not
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include
> disabling of jar scanning.
> We can say disabling jar scanning is right approach because if we enable it
> then scanner will scan all the jars loaded in OFBiz startup that we don't
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of
> jars only. For example: jars having websockets endpoints. I am attaching
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only
> it will be considered for jar scan. We can change jar name of our jars using
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
>
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar"
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains
> "discoverable" word in it.
> This change will not increase server start up time more than couple of
> seconds (in my case, it just two seconds). So scanning time totally depends
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339088#comment-16339088 ] Taher Alkhateeb commented on OFBIZ-10164: - Hi James, So I applied the patch and I'm not sure how to test it, can you give me an example context / screen of applying the splitter to observe the effect? Also, the patch needs an update (my fault) because of renaming common to common-theme > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, horizontal.png, > vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10119) Update markup of Shopping Lists page according to standard markup given by Bootstrap v4.0.0
[ https://issues.apache.org/jira/browse/OFBIZ-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parakh Maheshwari updated OFBIZ-10119: -- Attachment: OFBIZ-10119.patch > Update markup of Shopping Lists page according to standard markup given by > Bootstrap v4.0.0 > --- > > Key: OFBIZ-10119 > URL: https://issues.apache.org/jira/browse/OFBIZ-10119 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Reporter: Parakh Maheshwari >Assignee: Parakh Maheshwari >Priority: Major > Attachments: OFBIZ-10119.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10119) Update markup of Shopping Lists page according to standard markup given by Bootstrap v4.0.0
[ https://issues.apache.org/jira/browse/OFBIZ-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parakh Maheshwari updated OFBIZ-10119: -- Attachment: (was: OFBIZ-10119.patch) > Update markup of Shopping Lists page according to standard markup given by > Bootstrap v4.0.0 > --- > > Key: OFBIZ-10119 > URL: https://issues.apache.org/jira/browse/OFBIZ-10119 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Reporter: Parakh Maheshwari >Assignee: Parakh Maheshwari >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-7467) WebSocket Example - Push Notifications
[ https://issues.apache.org/jira/browse/OFBIZ-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-7467. --- Resolution: Fixed Fix Version/s: 17.12.01 > WebSocket Example - Push Notifications > -- > > Key: OFBIZ-7467 > URL: https://issues.apache.org/jira/browse/OFBIZ-7467 > Project: OFBiz > Issue Type: Sub-task > Components: example >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.01 > > Attachments: OFBIZ-7467.patch, OFBIZ-7483-Screen-Shot.png > > > This is a ticket for adding working example (in example application) of > WebSocket support that has been done in OFBIZ-7073 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7467) WebSocket Example - Push Notifications
[ https://issues.apache.org/jira/browse/OFBIZ-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338988#comment-16338988 ] Deepak Dixit commented on OFBIZ-7467: - This is working fine, OFBIZ-10167 fix this issue. > WebSocket Example - Push Notifications > -- > > Key: OFBIZ-7467 > URL: https://issues.apache.org/jira/browse/OFBIZ-7467 > Project: OFBiz > Issue Type: Sub-task > Components: example >Affects Versions: Trunk >Reporter: Amardeep Singh Jhajj >Assignee: Jacques Le Roux >Priority: Major > Fix For: 16.11.01, 17.12.01 > > Attachments: OFBIZ-7467.patch, OFBIZ-7483-Screen-Shot.png > > > This is a ticket for adding working example (in example application) of > WebSocket support that has been done in OFBIZ-7073 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-7073) Add WebSocket support in OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit closed OFBIZ-7073.
---
> Add WebSocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7073.patch, OFBIZ-7073.patch,
> tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar
> in catalina lib and created one webapp for websocket and also added server
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets
> implementation need jar scanning enabled and it is currently disabled in
> OFBiz. Below is the code snippet of disabling jar scan from
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of
> minutes (in my case, it took approx 8 minutes), so we don't want this much of
> startup time for OFBiz.
>
> I got the following document where I found the reason why websocket is not
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include
> disabling of jar scanning.
> We can say disabling jar scanning is right approach because if we enable it
> then scanner will scan all the jars loaded in OFBiz startup that we don't
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of
> jars only. For example: jars having websockets endpoints. I am attaching
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only
> it will be considered for jar scan. We can change jar name of our jars using
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
>
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar"
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains
> "discoverable" word in it.
> This change will not increase server start up time more than couple of
> seconds (in my case, it just two seconds). So scanning time totally depends
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OFBIZ-7073) Add WebSocket support in OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit resolved OFBIZ-7073.
-
Resolution: Fixed
> Add WebSocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7073.patch, OFBIZ-7073.patch,
> tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar
> in catalina lib and created one webapp for websocket and also added server
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets
> implementation need jar scanning enabled and it is currently disabled in
> OFBiz. Below is the code snippet of disabling jar scan from
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of
> minutes (in my case, it took approx 8 minutes), so we don't want this much of
> startup time for OFBiz.
>
> I got the following document where I found the reason why websocket is not
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include
> disabling of jar scanning.
> We can say disabling jar scanning is right approach because if we enable it
> then scanner will scan all the jars loaded in OFBiz startup that we don't
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of
> jars only. For example: jars having websockets endpoints. I am attaching
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only
> it will be considered for jar scan. We can change jar name of our jars using
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
>
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar"
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains
> "discoverable" word in it.
> This change will not increase server start up time more than couple of
> seconds (in my case, it just two seconds). So scanning time totally depends
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7073) Add WebSocket support in OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338982#comment-16338982
]
Deepak Dixit commented on OFBIZ-7073:
-
Hi Jacques,
I think we can close this ticket as its working now,
The fix done in OFBIZ-10167 fixed the issue.
> Add WebSocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7073.patch, OFBIZ-7073.patch,
> tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar
> in catalina lib and created one webapp for websocket and also added server
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets
> implementation need jar scanning enabled and it is currently disabled in
> OFBiz. Below is the code snippet of disabling jar scan from
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of
> minutes (in my case, it took approx 8 minutes), so we don't want this much of
> startup time for OFBiz.
>
> I got the following document where I found the reason why websocket is not
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include
> disabling of jar scanning.
> We can say disabling jar scanning is right approach because if we enable it
> then scanner will scan all the jars loaded in OFBiz startup that we don't
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of
> jars only. For example: jars having websockets endpoints. I am attaching
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only
> it will be considered for jar scan. We can change jar name of our jars using
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
>
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar"
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains
> "discoverable" word in it.
> This change will not increase server start up time more than couple of
> seconds (in my case, it just two seconds). So scanning time totally depends
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-7073) Add WebSocket support in OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit reassigned OFBIZ-7073:
---
Assignee: Deepak Dixit (was: Jacques Le Roux)
> Add WebSocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7073.patch, OFBIZ-7073.patch,
> tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar
> in catalina lib and created one webapp for websocket and also added server
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets
> implementation need jar scanning enabled and it is currently disabled in
> OFBiz. Below is the code snippet of disabling jar scan from
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of
> minutes (in my case, it took approx 8 minutes), so we don't want this much of
> startup time for OFBiz.
>
> I got the following document where I found the reason why websocket is not
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include
> disabling of jar scanning.
> We can say disabling jar scanning is right approach because if we enable it
> then scanner will scan all the jars loaded in OFBiz startup that we don't
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of
> jars only. For example: jars having websockets endpoints. I am attaching
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only
> it will be considered for jar scan. We can change jar name of our jars using
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
>
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar"
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains
> "discoverable" word in it.
> This change will not increase server start up time more than couple of
> seconds (in my case, it just two seconds). So scanning time totally depends
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-7073) Add WebSocket support in OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338964#comment-16338964
]
Pallavi Goyal edited comment on OFBIZ-7073 at 1/25/18 9:19 AM:
---
I tested the WebSocket working on latest code and it is working fine. I think
it's fixed in some recent fixes. We can close this ticket now.
was (Author: pallavi.goyal):
I tested the websocket working on latest code and the it is working fine. I
think it's fixed in some recent fixes. We can close this ticket now.
> Add WebSocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7073.patch, OFBIZ-7073.patch,
> tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar
> in catalina lib and created one webapp for websocket and also added server
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets
> implementation need jar scanning enabled and it is currently disabled in
> OFBiz. Below is the code snippet of disabling jar scan from
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of
> minutes (in my case, it took approx 8 minutes), so we don't want this much of
> startup time for OFBiz.
>
> I got the following document where I found the reason why websocket is not
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include
> disabling of jar scanning.
> We can say disabling jar scanning is right approach because if we enable it
> then scanner will scan all the jars loaded in OFBiz startup that we don't
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of
> jars only. For example: jars having websockets endpoints. I am attaching
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only
> it will be considered for jar scan. We can change jar name of our jars using
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
>
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar"
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains
> "discoverable" word in it.
> This change will not increase server start up time more than couple of
> seconds (in my case, it just two seconds). So scanning time totally depends
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7073) Add WebSocket support in OFBiz
[
https://issues.apache.org/jira/browse/OFBIZ-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338964#comment-16338964
]
Pallavi Goyal commented on OFBIZ-7073:
--
I tested the websocket working on latest code and the it is working fine. I
think it's fixed in some recent fixes. We can close this ticket now.
> Add WebSocket support in OFBiz
> --
>
> Key: OFBIZ-7073
> URL: https://issues.apache.org/jira/browse/OFBIZ-7073
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7073.patch, OFBIZ-7073.patch,
> tomcat-embed-websocket-8.0.33.jar
>
>
> I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar
> in catalina lib and created one webapp for websocket and also added server
> endpoint class.
> It didn't work. After that, I tried the same thing with plain j2ee
> application with embedded tomcat. It worked there.
> I researched on above issue in OFBiz and got the reason. Websockets
> implementation need jar scanning enabled and it is currently disabled in
> OFBiz. Below is the code snippet of disabling jar scan from
> CatalinaContainer.java:
> {code}
> JarScanner jarScanner = context.getJarScanner();
> if (jarScanner instanceof StandardJarScanner) {
> StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
> standardJarScanner.setScanClassPath(false);
> }
> {code}
> Jar scanning enabling increase OFBiz server startup time upto couples of
> minutes (in my case, it took approx 8 minutes), so we don't want this much of
> startup time for OFBiz.
>
> I got the following document where I found the reason why websocket is not
> working if scanning disabled.
> https://wiki.apache.org/tomcat/HowTo/FasterStartUp
> Here tips are given to decrease the startup time. This tips also include
> disabling of jar scanning.
> We can say disabling jar scanning is right approach because if we enable it
> then scanner will scan all the jars loaded in OFBiz startup that we don't
> want.
> But, If we want websockets working then we have to enable jar scanning.
> For enabling jar scanning, we need below code:
> {code}
> standardJarScanner.setScanClassPath(true); // Will increase server startup
> time.
> {code}
> Solution: We can add filter on jar scanning. It will allow only some kind of
> jars only. For example: jars having websockets endpoints. I am attaching
> patch for the same here.
> I added filter like if jar name string contains "discoverable" word then only
> it will be considered for jar scan. We can change jar name of our jars using
> build.xml to make it discoverable for jar scanning.
> For example: I have added my websocket endpoint class in
> "specialpurpose/ecommerce/src" and changed the "name" property in build.xml
> of ecommerce component from "ofbiz-ecommerce"
> to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:
> {code}
>
> {code}
> This change will create the jar with name "ofbiz-ecommerce-discoverable.jar"
> in "ecommerce/build/lib/".
> Now created jar will be scanned in jar scanner as its name contains
> "discoverable" word in it.
> This change will not increase server start up time more than couple of
> seconds (in my case, it just two seconds). So scanning time totally depends
> on the list of jars scanned.
> Conclusion: We can use websocket support with the help of jar filters.
> I am also attaching the version 8.0.33 tomcat-embed-websocket.jar.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
