[jira] [Comment Edited] (OFBIZ-10186) Configure official document templates for an organizational party
[ https://issues.apache.org/jira/browse/OFBIZ-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342731#comment-16342731 ] Jacques Le Roux edited comment on OFBIZ-10186 at 1/28/18 8:51 PM: -- Hi Nicolas, I have not reviewed the patch yet, but that sounds like a good idea (y) was (Author: jacques.le.roux): I have not reviewed the patch yet, but that sounds like a good idea (y) > Configure official document templates for an organizational party > - > > Key: OFBIZ-10186 > URL: https://issues.apache.org/jira/browse/OFBIZ-10186 > Project: OFBiz > Issue Type: New Feature > Components: accounting >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Labels: invoice, organization, template > Attachments: OFBIZ-10186.patch, Sélection_134.png, Sélection_135.png > > > For an organizational party, add possibility to give the specific template to > use for official document like invoice and order. > The first step is adding mechanism to indicate what template to use for a > party, for that : > * add CustomScreen entity (like CustomMethod) to prepare and organize your > screen by theme > * add PartyPrefDocTypeTpl as association entity between an organizational > party, a document type and a custom screen > For use case, I create a new invoice template for oriented on EU format (in > process) with VAT directly display on invoice item. > Related mailing list thread : > https://lists.apache.org/thread.html/4a5244e6d022564414e4f4a5676f72288d4000913ec2afa7e4af5e1a@%3Cdev.ofbiz.apache.org%3E > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10186) Configure official document templates for an organizational party
[ https://issues.apache.org/jira/browse/OFBIZ-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342731#comment-16342731 ] Jacques Le Roux commented on OFBIZ-10186: - I have not reviewed the patch yet, but that sounds like a good idea (y) > Configure official document templates for an organizational party > - > > Key: OFBIZ-10186 > URL: https://issues.apache.org/jira/browse/OFBIZ-10186 > Project: OFBiz > Issue Type: New Feature > Components: accounting >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Labels: invoice, organization, template > Attachments: OFBIZ-10186.patch, Sélection_134.png, Sélection_135.png > > > For an organizational party, add possibility to give the specific template to > use for official document like invoice and order. > The first step is adding mechanism to indicate what template to use for a > party, for that : > * add CustomScreen entity (like CustomMethod) to prepare and organize your > screen by theme > * add PartyPrefDocTypeTpl as association entity between an organizational > party, a document type and a custom screen > For use case, I create a new invoice template for oriented on EU format (in > process) with VAT directly display on invoice item. > Related mailing list thread : > https://lists.apache.org/thread.html/4a5244e6d022564414e4f4a5676f72288d4000913ec2afa7e4af5e1a@%3Cdev.ofbiz.apache.org%3E > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10186) Configure official document templates for an organizational party
[ https://issues.apache.org/jira/browse/OFBIZ-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-10186: -- Attachment: Sélection_134.png Sélection_135.png > Configure official document templates for an organizational party > - > > Key: OFBIZ-10186 > URL: https://issues.apache.org/jira/browse/OFBIZ-10186 > Project: OFBiz > Issue Type: New Feature > Components: accounting >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Labels: invoice, organization, template > Attachments: Sélection_134.png, Sélection_135.png > > > For an organizational party, add possibility to give the specific template to > use for official document like invoice and order. > The first step is adding mechanism to indicate what template to use for a > party, for that : > * add CustomScreen entity (like CustomMethod) to prepare and organize your > screen by theme > * add PartyPrefDocTypeTpl as association entity between an organizational > party, a document type and a custom screen > For use case, I create a new invoice template for oriented on EU format (in > process) with VAT directly display on invoice item. > Related mailing list thread : > https://lists.apache.org/thread.html/4a5244e6d022564414e4f4a5676f72288d4000913ec2afa7e4af5e1a@%3Cdev.ofbiz.apache.org%3E > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10186) Configure official document templates for an organizational party
Nicolas Malin created OFBIZ-10186: - Summary: Configure official document templates for an organizational party Key: OFBIZ-10186 URL: https://issues.apache.org/jira/browse/OFBIZ-10186 Project: OFBiz Issue Type: New Feature Components: accounting Reporter: Nicolas Malin Assignee: Nicolas Malin For an organizational party, add possibility to give the specific template to use for official document like invoice and order. The first step is adding mechanism to indicate what template to use for a party, for that : * add CustomScreen entity (like CustomMethod) to prepare and organize your screen by theme * add PartyPrefDocTypeTpl as association entity between an organizational party, a document type and a custom screen For use case, I create a new invoice template for oriented on EU format (in process) with VAT directly display on invoice item. Related mailing list thread : https://lists.apache.org/thread.html/4a5244e6d022564414e4f4a5676f72288d4000913ec2afa7e4af5e1a@%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342611#comment-16342611 ] Taher Alkhateeb commented on OFBIZ-10164: - Thank you for the clarification. Now I understand exactly what is done. Thank you for your efforts, dedication and explanation. The idea is nice, but I see a few problems with the implementation. Essentially, you created a splitter tag specifically designed to accommodate a jquery plugin and you've incorporated it into the common theme. The problems with this design are as follows: * First, there is HTML related stuff in the widget (CommonScreens). It could be done with less verbosity perhaps? * Second, the idea of a tag existing to serve specifically and be logically tied to a jquery plugin is going against the philosophy of the widget system being an independent layer from the actual view. * You've added a tag that does not create a new structure (just add the splitter library behavior). As far as structure of the page is concerned, it is the same structure and achieved with CSS. I would suggest that less is more. It makes more sense to make the changes purely in the common theme, and link up the CSS from the styles to the actual library without touching the core or with minimal modifications. We discussed this in the community before, and the reason we created the common-theme is to completely remove "web" related stuff from the widget system and core framework. So my recommendation is to re-design with minimal or no change to the core. Alternatively, if you like to make this a full solution, then we can design a full splitter (vertical and horizontal) system and replace completely any old CSS styles relating to splitting with this new tag architecture. However, this might require community consensus because it would probably break some existing implementations. The reason for my suggestion is to reduce user confusion. There should be preferably only one way to structure a page. If we have multiple ways then we are adding complexity and confusing the users of the system. > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. > Update on 20180128: > 1) The patch comes with an example where you can view the splitter at > https://localhost:8443/catalog/control/main > 2) No need to add square brackets when defining sizes. > 3) parentId attribute is removed, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-10164: --- Description: A new splitter widget that will use a tag named 'splitter'. This splitter tag has the following attributes: a. sizes = [25, 75] where the containers within will be splitted with a ratio of 25% and 75% b. parentId which is the ID of the parent container c. direction = vertical or horizonal (default) The splitter tag can only contains container(s) as immediate child. Using the library from http://nathancahill.github.io/Split.js/ which is licensed under MIT license. Update on 20180128: 1) The patch comes with an example where you can view the splitter at https://localhost:8443/catalog/control/main 2) No need to add square brackets when defining sizes. 3) parentId attribute is removed, was: A new splitter widget that will use a tag named 'splitter'. This splitter tag has the following attributes: a. sizes = [25, 75] where the containers within will be splitted with a ratio of 25% and 75% b. parentId which is the ID of the parent container c. direction = vertical or horizonal (default) The splitter tag can only contains container(s) as immediate child. Using the library from http://nathancahill.github.io/Split.js/ which is licensed under MIT license. > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. > Update on 20180128: > 1) The patch comes with an example where you can view the splitter at > https://localhost:8443/catalog/control/main > 2) No need to add square brackets when defining sizes. > 3) parentId attribute is removed, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342602#comment-16342602 ] James Yong commented on OFBIZ-10164: Hi Taher, Sorry for not being clear. Can you try https://localhost:8443/catalog/control/main ? Regards, James > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342599#comment-16342599 ] Taher Alkhateeb commented on OFBIZ-10164: - Hi James, I cannot observe the effect of using the splitter, this is just wrapping a few decorators. Perhaps a sample screen to observe exactly what's going on would help? > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342579#comment-16342579 ] James Yong commented on OFBIZ-10164: Uploaded a 3rd version of the patch with the following improvements: 1. Improved CSS definition for each theme Hi Jacques, The splitter's common css definition is moved to the respective theme’s style.css. Hi Taher, I have migrate the patch to the new common-theme folder. Can refer to the CommonScreens.xml file for an example on its usage. If you know of other suitable location for the splitter(s), I can work on it to provide further examples. Thanks. > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-10164: --- Attachment: OFBIZ-10164.patch > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-10164: --- Attachment: OFBIZ-10161.patch > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, horizontal.png, > vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-10164: --- Attachment: (was: OFBIZ-10161.patch) > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, horizontal.png, > vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
