[jira] [Resolved] (OFBIZ-10183) Error on My Portal > Request Overview Page

2018-01-29 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki resolved OFBIZ-10183.
---
   Resolution: Fixed
Fix Version/s: Release Branch 16.11
   Upcoming Branch

[~yogesh.naroliya]: Your patch has been committed in revisions trunk- 1822512, 
17.12- 1822513 and 16.11- 1822515. Thanks for your contribution.

Thanks [~upadhyay.ratnesh] for reporting the issue.

> Error on My Portal > Request Overview Page
> --
>
> Key: OFBIZ-10183
> URL: https://issues.apache.org/jira/browse/OFBIZ-10183
> Project: OFBiz
>  Issue Type: Bug
>  Components: projectmgr
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch, Release Branch 16.11
>
> Attachments: OFBIZ-10183-REL16.11.patch, OFBIZ-10183-Trunk.patch, 
> OFBIZ-10183.png
>
>
> While browsing through my portal app, I noticed this issue. Here are the 
> steps to replicate the issue.
>  # Go to My Portal > My Comms.
>  # Click upon any customer request Id link to navigate on Request Overview 
> page.
> Following error appeared on overview page as soon as user lands on this page.
> {code:java}
> Error
>  rendering included template at location 
> [component://projectmgr/webapp/projectmgr/request/OverViewRequestItems.ftl]:
>  freemarker.template.TemplateNotFoundException: Template not found for 
> name 
> "component://projectmgr/webapp/projectmgr/request/OverViewRequestItems.ftl".
>  The name was interpreted by this TemplateLoader: 
> MultiTemplateLoader(loader1 = 
> org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@49711524,
>  loader2 = StringTemplateLoader(Map { })).
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10183) Error on My Portal > Request Overview Page

2018-01-29 Thread Rishi Solanki (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki closed OFBIZ-10183.
-

> Error on My Portal > Request Overview Page
> --
>
> Key: OFBIZ-10183
> URL: https://issues.apache.org/jira/browse/OFBIZ-10183
> Project: OFBiz
>  Issue Type: Bug
>  Components: projectmgr
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Release Branch 16.11, Upcoming Branch
>
> Attachments: OFBIZ-10183-REL16.11.patch, OFBIZ-10183-Trunk.patch, 
> OFBIZ-10183.png
>
>
> While browsing through my portal app, I noticed this issue. Here are the 
> steps to replicate the issue.
>  # Go to My Portal > My Comms.
>  # Click upon any customer request Id link to navigate on Request Overview 
> page.
> Following error appeared on overview page as soon as user lands on this page.
> {code:java}
> Error
>  rendering included template at location 
> [component://projectmgr/webapp/projectmgr/request/OverViewRequestItems.ftl]:
>  freemarker.template.TemplateNotFoundException: Template not found for 
> name 
> "component://projectmgr/webapp/projectmgr/request/OverViewRequestItems.ftl".
>  The name was interpreted by this TemplateLoader: 
> MultiTemplateLoader(loader1 = 
> org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@49711524,
>  loader2 = StringTemplateLoader(Map { })).
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10164) Splitter Widget

2018-01-29 Thread James Yong (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343459#comment-16343459
 ] 

James Yong commented on OFBIZ-10164:


Much appreciate the various feedbacks. 

The plan is to create splitter tag to aid in adding splitter(s) like those seen 
at https://nathancahill.github.io/Split.js/.
Having a fixed header & footer is one common requirement I have seen on the use 
of splitter, and made some effort to achieve that in the example at 
CommonScreens.xml.
As a result more changes is done than what a splitter should be doing.

The splitter can and should do more than just an horizontal split, and hope to 
explore more scenarios 1st. Hopefully I can standardise on the required CSS for 
the various possible splits. That said I am also fine with removing the 
splitter tag altogether if doing entirely in the theme make better sense. Maybe 
will explore these, next weekend.

If you got more time with the applied patch, can you look into the usability 
aspects of having fixed header and footer. 
Thinking if we can allow developer to turn on or off the fixed header / footer 
via a property.  Maybe another JIRA issue for this...

> Splitter Widget
> ---
>
> Key: OFBIZ-10164
> URL: https://issues.apache.org/jira/browse/OFBIZ-10164
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, 
> horizontal.png, vertical.png
>
>
> A new splitter widget that will use a tag named 'splitter'.
> This splitter tag has the following attributes:
> a. sizes = [25, 75] where the containers within will be splitted with a ratio 
> of 25% and 75%
> b. parentId which is the ID of the parent container
> c. direction = vertical or horizonal (default)
> The splitter tag can only contains container(s) as immediate child.
> Using the library from http://nathancahill.github.io/Split.js/ which is 
> licensed under MIT license.
> Update on 20180128:
> 1) The patch comes with an example where you can view the splitter at 
> https://localhost:8443/catalog/control/main
> 2) No need to add square brackets when defining sizes.
> 3) parentId attribute is removed,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10164) Splitter Widget

2018-01-29 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343391#comment-16343391
 ] 

Jacques Le Roux commented on OFBIZ-10164:
-

BTW I'm not sure it's related (did not review yet), but I was the one who 
introduced the drop down and asm select mechanisms (there are examples in 
FormWidgetExampleScreens.xml). The asmselect jQuery plugin was recently 
replaced by the Select2 plugin with OFBIZ-10113. There Aditya, who did most of 
the work, rightly suggested to refactor the asm select mechanism and created 
OFBIZ-10165 for that. I wonder if we could not get to an even better solution 
to avoid and replace the drop down and asm select mechanisms and ultimately 
rely on require.js to better organise things, OFBIZ-9976 was created for that. 
Please bear with me, I'll get back to review and see if this comment makes 
sense in this context...


> Splitter Widget
> ---
>
> Key: OFBIZ-10164
> URL: https://issues.apache.org/jira/browse/OFBIZ-10164
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, 
> horizontal.png, vertical.png
>
>
> A new splitter widget that will use a tag named 'splitter'.
> This splitter tag has the following attributes:
> a. sizes = [25, 75] where the containers within will be splitted with a ratio 
> of 25% and 75%
> b. parentId which is the ID of the parent container
> c. direction = vertical or horizonal (default)
> The splitter tag can only contains container(s) as immediate child.
> Using the library from http://nathancahill.github.io/Split.js/ which is 
> licensed under MIT license.
> Update on 20180128:
> 1) The patch comes with an example where you can view the splitter at 
> https://localhost:8443/catalog/control/main
> 2) No need to add square brackets when defining sizes.
> 3) parentId attribute is removed,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10164) Splitter Widget

2018-01-29 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343351#comment-16343351
 ] 

Jacques Le Roux commented on OFBIZ-10164:
-

>From the peanuts gallery, I like this idea:
bq. Alternatively, if you like to make this a full solution, then we can design 
a full splitter (vertical and horizontal) system and replace completely any old 
CSS styles relating to splitting with this new tag architecture. However, this 
might require community consensus because it would probably break some existing 
implementations.
Please don't take it too seriously, I did not get a chance yet to get deeper in 
this issue, so just my 2cts...


> Splitter Widget
> ---
>
> Key: OFBIZ-10164
> URL: https://issues.apache.org/jira/browse/OFBIZ-10164
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, 
> horizontal.png, vertical.png
>
>
> A new splitter widget that will use a tag named 'splitter'.
> This splitter tag has the following attributes:
> a. sizes = [25, 75] where the containers within will be splitted with a ratio 
> of 25% and 75%
> b. parentId which is the ID of the parent container
> c. direction = vertical or horizonal (default)
> The splitter tag can only contains container(s) as immediate child.
> Using the library from http://nathancahill.github.io/Split.js/ which is 
> licensed under MIT license.
> Update on 20180128:
> 1) The patch comes with an example where you can view the splitter at 
> https://localhost:8443/catalog/control/main
> 2) No need to add square brackets when defining sizes.
> 3) parentId attribute is removed,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)