[jira] [Closed] (OFBIZ-9780) [FB] org.apache.ofbiz.product.catalog
[ https://issues.apache.org/jira/browse/OFBIZ-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-9780. > [FB] org.apache.ofbiz.product.catalog > - > > Key: OFBIZ-9780 > URL: https://issues.apache.org/jira/browse/OFBIZ-9780 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Minor > > CatalogWorker.java:103, BC_UNCONFIRMED_CAST > - BC: Unchecked/unconfirmed cast from javax.servlet.ServletRequest to > javax.servlet.http.HttpServletRequest in > org.apache.ofbiz.product.catalog.CatalogWorker.getPartyCatalogs(ServletRequest) > This cast is unchecked, and not all instances of the type casted from can be > cast to the type it is being cast to. Check that your program logic ensures > that this cast will not fail. > CatalogWorker.java:158, BC_UNCONFIRMED_CAST > - BC: Unchecked/unconfirmed cast from javax.servlet.ServletRequest to > javax.servlet.http.HttpServletRequest in > org.apache.ofbiz.product.catalog.CatalogWorker.getCurrentCatalogId(ServletRequest) > This cast is unchecked, and not all instances of the type casted from can be > cast to the type it is being cast to. Check that your program logic ensures > that this cast will not fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10015) Unable to create inventory item label
[ https://issues.apache.org/jira/browse/OFBIZ-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375666#comment-16375666 ] Michael Brohl commented on OFBIZ-10015: --- Backported in 16.11 r1825263 > Unable to create inventory item label > - > > Key: OFBIZ-10015 > URL: https://issues.apache.org/jira/browse/OFBIZ-10015 > Project: OFBiz > Issue Type: Bug >Reporter: Priya Sharma >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01 > > Attachments: Screenshot from 2017-11-25 15-03-57.png > > > 1) Navigate to > [https://demo-trunk.ofbiz.apache.org/facility/control/createInventoryItemLabel] > 2) Try to create a new record. > 3) No value is shown in the drop-down for the inventory item label type field. > thus an exception is thrown by the service. > Info: There is no data in the InventoryItemLabelType entity, I believe that > is the cause of this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10015) Unable to create inventory item label
[ https://issues.apache.org/jira/browse/OFBIZ-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10015. - Resolution: Fixed Fix Version/s: (was: Trunk) 17.12.01 This is fixed in r1825262. > Unable to create inventory item label > - > > Key: OFBIZ-10015 > URL: https://issues.apache.org/jira/browse/OFBIZ-10015 > Project: OFBiz > Issue Type: Bug >Reporter: Priya Sharma >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01 > > Attachments: Screenshot from 2017-11-25 15-03-57.png > > > 1) Navigate to > [https://demo-trunk.ofbiz.apache.org/facility/control/createInventoryItemLabel] > 2) Try to create a new record. > 3) No value is shown in the drop-down for the inventory item label type field. > thus an exception is thrown by the service. > Info: There is no data in the InventoryItemLabelType entity, I believe that > is the cause of this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms
[ https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375634#comment-16375634 ] Michael Brohl commented on OFBIZ-10221: --- Thanks Julian, the current patches are in trunk r1825261. I leave this issue open for more to come ;) > Improve layout and structure of forms > - > > Key: OFBIZ-10221 > URL: https://issues.apache.org/jira/browse/OFBIZ-10221 > Project: OFBiz > Issue Type: Improvement >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-10221_webtools.entity.ArtifactInfo.patch, > OFBIZ-10221_webtools.entity.CheckDb.patch, > OFBIZ-10221_webtools.entity.EntityExportAll.patch, > OFBIZ-10221_webtools.entity.EntityImport.patch, > OFBIZ-10221_webtools.entity.EntityImportDir.patch, > OFBIZ-10221_webtools.entity.EntityImportReaders.patch, > OFBIZ-10221_webtools.entity.FetchLogs.patch, > OFBIZ-10221_webtools.entity.ViewDataFile.patch, > OFBIZ-10221_webtools.entity.XmlDsDump.patch > > > While working at a Theme, i discovered that the forms differ in their style > and structure. > I propose a standard form-structure, so that further styling and look is > coherent. > I.e. class definitions ( class="basic-form") are often missing, input-fields > vary in size and the layout does not follow a standard structure. > As mentioned in > [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E] > I have attached an example patch, which modifies a form defined in FreeMarker > to conform it to the forms defined in any *Forms.xml. > Often those forms within FreeMarker templates differ from most other forms in > Ofbiz, > I propose a refactoring of these FreeMarker forms, to equalize all forms. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms
[ https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375627#comment-16375627 ] Michael Brohl commented on OFBIZ-10221: --- Thanks [~soledad], yes, our focus is on a consistent layout for easier theme layouts so we only improved the status quo instead of changing the used technology. I'm going to commit the first changes. > Improve layout and structure of forms > - > > Key: OFBIZ-10221 > URL: https://issues.apache.org/jira/browse/OFBIZ-10221 > Project: OFBiz > Issue Type: Improvement >Reporter: Julian Leichert >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-10221_webtools.entity.ArtifactInfo.patch, > OFBIZ-10221_webtools.entity.CheckDb.patch, > OFBIZ-10221_webtools.entity.EntityExportAll.patch, > OFBIZ-10221_webtools.entity.EntityImport.patch, > OFBIZ-10221_webtools.entity.EntityImportDir.patch, > OFBIZ-10221_webtools.entity.EntityImportReaders.patch, > OFBIZ-10221_webtools.entity.FetchLogs.patch, > OFBIZ-10221_webtools.entity.ViewDataFile.patch, > OFBIZ-10221_webtools.entity.XmlDsDump.patch > > > While working at a Theme, i discovered that the forms differ in their style > and structure. > I propose a standard form-structure, so that further styling and look is > coherent. > I.e. class definitions ( class="basic-form") are often missing, input-fields > vary in size and the layout does not follow a standard structure. > As mentioned in > [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E] > I have attached an example patch, which modifies a form defined in FreeMarker > to conform it to the forms defined in any *Forms.xml. > Often those forms within FreeMarker templates differ from most other forms in > Ofbiz, > I propose a refactoring of these FreeMarker forms, to equalize all forms. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10141) Add a VERSION file in root dir
[ https://issues.apache.org/jira/browse/OFBIZ-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375619#comment-16375619 ] Michael Brohl commented on OFBIZ-10141: --- Any thoughts on the patches provided? > Add a VERSION file in root dir > -- > > Key: OFBIZ-10141 > URL: https://issues.apache.org/jira/browse/OFBIZ-10141 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10141.patch, > OFBIZ-10141_Add_VERSION_file_simpler_solution.patch > > > Following discussion at http://markmail.org/message/ut74mzptruubw4ty we have > decided to > # have VERSION file at project root to store released version. > # Render the version in the applications footer template as a HTML comment. > Also [~mbrohl] suggested that > # it can be automatically set by (custom) builds to be generated. > # It should be made configurable in general.properties to prevent to show it > if the user does not want this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10121) Incorrect Party profile view redirection in SFA due to missing roleType
[ https://issues.apache.org/jira/browse/OFBIZ-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar closed OFBIZ-10121. Resolution: Fixed Fix Version/s: 16.11.05 17.12.01 Committed changes in trunk at rev: 1825233 in 17.12 at rev: 1825234 in 16.111 at rev: 1825235 Thanks Ankit Joshi for your contribution. > Incorrect Party profile view redirection in SFA due to missing roleType > --- > > Key: OFBIZ-10121 > URL: https://issues.apache.org/jira/browse/OFBIZ-10121 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Arun Patidar >Priority: Major > Fix For: 17.12.01, 16.11.05 > > Attachments: OFBIZ-10121.patch, OFBIZ-10121.patch, OFBIZ-10121.patch > > > Currently, a single screen is using in SFA to view the profile of parties > like Account, Lead, Contact, and Account-Lead on the basis of their roles. It > requires roleTypeId to pass as a request parameter on each action initiates > from the profile to render the details on the profile correctly after > completing the request. > *Issue:* Various actions on the profile screen does not include roleTypeId as > a request parameter. It results in redirecting to the empty profile screen > after completing the request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-9761: --- Assignee: Amit Gadaley (was: Arun Patidar) > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Labels: backport-needed > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10121) Incorrect Party profile view redirection in SFA due to missing roleType
[ https://issues.apache.org/jira/browse/OFBIZ-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi updated OFBIZ-10121: Attachment: OFBIZ-10121.patch > Incorrect Party profile view redirection in SFA due to missing roleType > --- > > Key: OFBIZ-10121 > URL: https://issues.apache.org/jira/browse/OFBIZ-10121 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Arun Patidar >Priority: Major > Attachments: OFBIZ-10121.patch, OFBIZ-10121.patch, OFBIZ-10121.patch > > > Currently, a single screen is using in SFA to view the profile of parties > like Account, Lead, Contact, and Account-Lead on the basis of their roles. It > requires roleTypeId to pass as a request parameter on each action initiates > from the profile to render the details on the profile correctly after > completing the request. > *Issue:* Various actions on the profile screen does not include roleTypeId as > a request parameter. It results in redirecting to the empty profile screen > after completing the request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10208) Error on Add Item to Shopping List Screen
[
https://issues.apache.org/jira/browse/OFBIZ-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki closed OFBIZ-10208.
-
> Error on Add Item to Shopping List Screen
> -
>
> Key: OFBIZ-10208
> URL: https://issues.apache.org/jira/browse/OFBIZ-10208
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: 16.11.04
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Release Branch 16.11
>
> Attachments: OFBIZ-10208-EditShoppingListScreen-Fixed.png,
> OFBIZ-10208-R16.11.patch
>
>
> While working on 16.11 branch, I noticed error when I try to add an item into
> shopping cart. Here are the steps to replicate the issue:
> # Go to Party Manager.
> # Select customer to navigate over profile page.
> # Click upon Shopping Lists tab.
> # Create new shopping list, if no one is persist.
> # Add an item to existing/new shopping list.
> As soon as you click to add on item you will see following error in list item
> and quick add to shopping list sections.
> {code:java}
> The following has evaluated to null or missing: ==> renderNextPrev [in
> template "component://common/template/includes/HtmlTemplate.ftl" at line
> 66, column 5] Tip: If the failing expression is known to be
> legally refer to something that's sometimes null or missing, either
> specify a default value like myOptionalVar!myDefault, or use <#if
> myOptionalVar??>when-present<#else>when-missing. (These only
> cover the last step of the expression; to cover the whole expression,
> use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
> FTL stack trace ("~" means nesting-related): - Failed at:
> @renderNextPrev paginateStyle, pagina... [in template
> "component://common/template/includes/HtmlTemplate.ftl" in macro
> "nextPrev" at line 66, column 3] - Reached through: @nextPrev
> commonUrl=commonUrl ajaxEna... [in template
> "component://party/template/party/EditShoppingList.ftl" at line 187,
> column 9]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OFBIZ-10208) Error on Add Item to Shopping List Screen
[
https://issues.apache.org/jira/browse/OFBIZ-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki resolved OFBIZ-10208.
---
Resolution: Fixed
Fix Version/s: Release Branch 16.11
> Error on Add Item to Shopping List Screen
> -
>
> Key: OFBIZ-10208
> URL: https://issues.apache.org/jira/browse/OFBIZ-10208
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: 16.11.04
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Release Branch 16.11
>
> Attachments: OFBIZ-10208-EditShoppingListScreen-Fixed.png,
> OFBIZ-10208-R16.11.patch
>
>
> While working on 16.11 branch, I noticed error when I try to add an item into
> shopping cart. Here are the steps to replicate the issue:
> # Go to Party Manager.
> # Select customer to navigate over profile page.
> # Click upon Shopping Lists tab.
> # Create new shopping list, if no one is persist.
> # Add an item to existing/new shopping list.
> As soon as you click to add on item you will see following error in list item
> and quick add to shopping list sections.
> {code:java}
> The following has evaluated to null or missing: ==> renderNextPrev [in
> template "component://common/template/includes/HtmlTemplate.ftl" at line
> 66, column 5] Tip: If the failing expression is known to be
> legally refer to something that's sometimes null or missing, either
> specify a default value like myOptionalVar!myDefault, or use <#if
> myOptionalVar??>when-present<#else>when-missing. (These only
> cover the last step of the expression; to cover the whole expression,
> use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
> FTL stack trace ("~" means nesting-related): - Failed at:
> @renderNextPrev paginateStyle, pagina... [in template
> "component://common/template/includes/HtmlTemplate.ftl" in macro
> "nextPrev" at line 66, column 3] - Reached through: @nextPrev
> commonUrl=commonUrl ajaxEna... [in template
> "component://party/template/party/EditShoppingList.ftl" at line 187,
> column 9]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10208) Error on Add Item to Shopping List Screen
[
https://issues.apache.org/jira/browse/OFBIZ-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375532#comment-16375532
]
Rishi Solanki commented on OFBIZ-10208:
---
Thanks Yogesh for providing fix for the issue and Ratnesh for reporting.
Your patch has been committed in R16.11 at revision 1825223.
> Error on Add Item to Shopping List Screen
> -
>
> Key: OFBIZ-10208
> URL: https://issues.apache.org/jira/browse/OFBIZ-10208
> Project: OFBiz
> Issue Type: Bug
> Components: party
>Affects Versions: 16.11.04
>Reporter: Ratnesh Upadhyay
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10208-EditShoppingListScreen-Fixed.png,
> OFBIZ-10208-R16.11.patch
>
>
> While working on 16.11 branch, I noticed error when I try to add an item into
> shopping cart. Here are the steps to replicate the issue:
> # Go to Party Manager.
> # Select customer to navigate over profile page.
> # Click upon Shopping Lists tab.
> # Create new shopping list, if no one is persist.
> # Add an item to existing/new shopping list.
> As soon as you click to add on item you will see following error in list item
> and quick add to shopping list sections.
> {code:java}
> The following has evaluated to null or missing: ==> renderNextPrev [in
> template "component://common/template/includes/HtmlTemplate.ftl" at line
> 66, column 5] Tip: If the failing expression is known to be
> legally refer to something that's sometimes null or missing, either
> specify a default value like myOptionalVar!myDefault, or use <#if
> myOptionalVar??>when-present<#else>when-missing. (These only
> cover the last step of the expression; to cover the whole expression,
> use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
> FTL stack trace ("~" means nesting-related): - Failed at:
> @renderNextPrev paginateStyle, pagina... [in template
> "component://common/template/includes/HtmlTemplate.ftl" in macro
> "nextPrev" at line 66, column 3] - Reached through: @nextPrev
> commonUrl=commonUrl ajaxEna... [in template
> "component://party/template/party/EditShoppingList.ftl" at line 187,
> column 9]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10239) Improve GeneralLedgerServices to set transaction date as payment's effective date
[ https://issues.apache.org/jira/browse/OFBIZ-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aishwary Shrivastava updated OFBIZ-10239: - Attachment: OFBIZ-10239.patch > Improve GeneralLedgerServices to set transaction date as payment's effective > date > - > > Key: OFBIZ-10239 > URL: https://issues.apache.org/jira/browse/OFBIZ-10239 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Aishwary Shrivastava >Assignee: Aishwary Shrivastava >Priority: Minor > Attachments: OFBIZ-10239.patch > > > Improved createAcctgTransAndEntriesForPaymentApplication and > createAcctgTransAndEntriesForOutgoingPayment services to Set transaction date > as payment's effective date. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375521#comment-16375521 ] Arun Patidar commented on OFBIZ-9761: - Committed changes in trunk at rev: 1825216 in 17.12 at rev: 1825217 There are some conflicts while applying the patch on 16.11 so will commit in 16.11 after resolving conflicts. Thanks [~amit.gadaley] for your contribution and [~mbrohl] for reviewing and suggestions. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Labels: backport-needed > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-9761: Labels: backport-needed (was: ) > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Labels: backport-needed > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10121) Incorrect Party profile view redirection in SFA due to missing roleType
[ https://issues.apache.org/jira/browse/OFBIZ-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi updated OFBIZ-10121: Attachment: OFBIZ-10121.patch > Incorrect Party profile view redirection in SFA due to missing roleType > --- > > Key: OFBIZ-10121 > URL: https://issues.apache.org/jira/browse/OFBIZ-10121 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Ankit Joshi >Priority: Major > Attachments: OFBIZ-10121.patch, OFBIZ-10121.patch > > > Currently, a single screen is using in SFA to view the profile of parties > like Account, Lead, Contact, and Account-Lead on the basis of their roles. It > requires roleTypeId to pass as a request parameter on each action initiates > from the profile to render the details on the profile correctly after > completing the request. > *Issue:* Various actions on the profile screen does not include roleTypeId as > a request parameter. It results in redirecting to the empty profile screen > after completing the request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10238) Last 3 Months Sales Report not Working
Aayush jain created OFBIZ-10238: --- Summary: Last 3 Months Sales Report not Working Key: OFBIZ-10238 URL: https://issues.apache.org/jira/browse/OFBIZ-10238 Project: OFBiz Issue Type: Bug Environment: demo-trunk.ofbiz.apache.org/ Reporter: Aayush jain Attachments: screencapture-demo-trunk-ofbiz-apache-org-ordermgr-control-Last3MonthsSalesReport-pdf-1519472089670.png Steps: # Open URL [https://demo-trunk.ofbiz.apache.org/ordermgr/control/OrderPurchaseReportOptions] # Navigate to Last 3 Months Sales Report # Click on Run Button Actual: No data found, displaying an Empty Report Kindly refer attachment for the same. Thanks! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10237) The leads which are converted is displayed on the Find lead page.
[ https://issues.apache.org/jira/browse/OFBIZ-10237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rubia Elza Joshep reassigned OFBIZ-10237: - Assignee: Pradeep Choudhary > The leads which are converted is displayed on the Find lead page. > - > > Key: OFBIZ-10237 > URL: https://issues.apache.org/jira/browse/OFBIZ-10237 > Project: OFBiz > Issue Type: Bug >Reporter: Rubia Elza Joshep >Assignee: Pradeep Choudhary >Priority: Major > > Steps to regenerate: > 1) Open URL > [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads|http://example.com/] > 2) Create a lead. Check for the lead in Find lead page. > 3) Convert the lead by clicking on "Create Lead" button. The lead is > successfully converted to contact/ Account. > Actual: The lead which is converted is displayed on the Find lead page. > Expected: Since the lead is converted to contact/Account it should not be > displayed on the Find lead page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10237) The leads which are converted is displayed on the Find lead page.
Rubia Elza Joshep created OFBIZ-10237: - Summary: The leads which are converted is displayed on the Find lead page. Key: OFBIZ-10237 URL: https://issues.apache.org/jira/browse/OFBIZ-10237 Project: OFBiz Issue Type: Bug Reporter: Rubia Elza Joshep Steps to regenerate: 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads|http://example.com/] 2) Create a lead. Check for the lead in Find lead page. 3) Convert the lead by clicking on "Create Lead" button. The lead is successfully converted to contact/ Account. Actual: The lead which is converted is displayed on the Find lead page. Expected: Since the lead is converted to contact/Account it should not be displayed on the Find lead page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375508#comment-16375508 ] Michael Brohl commented on OFBIZ-9761: -- Thanks for the link and your efforts. I have no obections at the moment, please go ahead. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375506#comment-16375506 ] Arun Patidar commented on OFBIZ-9761: - Hi [~mbrohl] , JCB checks looks good to me as per details in document - [https://www.regular-expressions.info/creditcard.html] For now, I am committing changes. Please let me know if you have any suggestions here. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9584) LabelManager doesn't search .js files
[ https://issues.apache.org/jira/browse/OFBIZ-9584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-9584: Affects Version/s: Trunk > LabelManager doesn't search .js files > - > > Key: OFBIZ-9584 > URL: https://issues.apache.org/jira/browse/OFBIZ-9584 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk, 17.12.01 >Reporter: Suraj Khurana >Priority: Minor > > There are around 50 matches of uilabels in js files as well. They are not > included in the label manager search and hence ignored in every action of it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9856) Add rat exclude files to excludes those files that does not need license header
[
https://issues.apache.org/jira/browse/OFBIZ-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375494#comment-16375494
]
Deepak Dixit commented on OFBIZ-9856:
-
I think now we can close this issue
> Add rat exclude files to excludes those files that does not need license
> header
>
>
> Key: OFBIZ-9856
> URL: https://issues.apache.org/jira/browse/OFBIZ-9856
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Deepak Dixit
>Priority: Major
>
> As recently we added Apache Rat in Buildbot, Rat audits software
> distributions, with a special interest in headers.
> Here is the Rat report for ofbiz
> https://ci.apache.org/projects/ofbiz/rat-output.html
> In this reports there are several files that does not need license header
> like *.svg etc.
> Rat provide a way to exclude files while auditing
> http://creadur.apache.org/rat/apache-rat/
> {quote}
> It is common to use the Rat with the Maven or Ant plugins and specify a
> series of files to exclude (such as a README or version control files). If
> you are using the Rat application instead of a plugin you can specify a
> series of regex excludes in a file and specify that with the -E option.
> {quote}
> We can add .rat-excludes.txt files at ofbiz root for this purpose.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-7598: Assignee: Suraj Khurana (was: Mridul Pathak) > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9851) Replace Inline js with External js in renderLookupField macro
[ https://issues.apache.org/jira/browse/OFBIZ-9851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-9851: --- Assignee: Deepak Dixit > Replace Inline js with External js in renderLookupField macro > - > > Key: OFBIZ-9851 > URL: https://issues.apache.org/jira/browse/OFBIZ-9851 > Project: OFBiz > Issue Type: Sub-task >Reporter: Aditya Sharma >Assignee: Deepak Dixit >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10012) Alert message : "Developer: for lookups to work you must provide a form name!" appears when try to select contentId from Lookup
[ https://issues.apache.org/jira/browse/OFBIZ-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10012. Resolution: Fixed Fix Version/s: 17.12.01 > Alert message : "Developer: for lookups to work you must provide a form > name!" appears when try to select contentId from Lookup > --- > > Key: OFBIZ-10012 > URL: https://issues.apache.org/jira/browse/OFBIZ-10012 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk >Reporter: Sonal Patwari >Assignee: Deepak Dixit >Priority: Blocker > Fix For: 17.12.01 > > Attachments: ContentSearchOptionsAlertShowing (1).png, > OFBIZ-10012.patch, OFBIZ-10012_plugins.patch > > > Steps to reproduce: > 1. Go to [Content > Component|https://demo-trunk.ofbiz.apache.org/content/control/main] > 2. Click on Content from > [submenu|https://demo-trunk.ofbiz.apache.org/content/control/findContent]. > 3. Click on the Advanced Search button > [https://demo-trunk.ofbiz.apache.org/content/control/ContentSearchOptions]. > 4. Provide Content Id. > 5. User should be able to see the alert message. > 6. For reference screenshot is attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10012) Alert message : "Developer: for lookups to work you must provide a form name!" appears when try to select contentId from Lookup
[
https://issues.apache.org/jira/browse/OFBIZ-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375486#comment-16375486
]
Deepak Dixit commented on OFBIZ-10012:
--
Thanks Sonal for reporting the issue
Thanks Aditya Sharma for providing the patch.
This has been committed at
ofbiz framework trunk at r#{color:#22}1825205, 1825211{color}
ofbiz plugins trunk at r#1825208
ofbiz framework R17.12 at r#{color:#22}1825210,1825212{color}
Plugins changes are only improvement so not backporitng to release17.12
> Alert message : "Developer: for lookups to work you must provide a form
> name!" appears when try to select contentId from Lookup
> ---
>
> Key: OFBIZ-10012
> URL: https://issues.apache.org/jira/browse/OFBIZ-10012
> Project: OFBiz
> Issue Type: Bug
> Components: content
>Affects Versions: Trunk
>Reporter: Sonal Patwari
>Assignee: Deepak Dixit
>Priority: Blocker
> Attachments: ContentSearchOptionsAlertShowing (1).png,
> OFBIZ-10012.patch, OFBIZ-10012_plugins.patch
>
>
> Steps to reproduce:
> 1. Go to [Content
> Component|https://demo-trunk.ofbiz.apache.org/content/control/main]
> 2. Click on Content from
> [submenu|https://demo-trunk.ofbiz.apache.org/content/control/findContent].
> 3. Click on the Advanced Search button
> [https://demo-trunk.ofbiz.apache.org/content/control/ContentSearchOptions].
> 4. Provide Content Id.
> 5. User should be able to see the alert message.
> 6. For reference screenshot is attached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-7738) OFBIZ-7471: Improve all the service level error messages for missing required field for workeffort component
[ https://issues.apache.org/jira/browse/OFBIZ-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar closed OFBIZ-7738. --- Resolution: Fixed Fix Version/s: Upcoming Branch Committed in trunk at revision 1825209 Thanks Ratnesh Upadhyay and Dhaval Wagela for your contribution. > OFBIZ-7471: Improve all the service level error messages for missing required > field for workeffort component > > > Key: OFBIZ-7738 > URL: https://issues.apache.org/jira/browse/OFBIZ-7738 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Arun Patidar >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7738.patch, OFBIZ-7738.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375475#comment-16375475 ] Michael Brohl commented on OFBIZ-9761: -- Thanks [~amit.gadaley], technically this looks good to me now. Just noticed that the JCB checks significantly changed in the patch (first4digs), is this correct, also for older credit cards? > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-9761: Attachment: (was: OFBIZ-9761.patch) > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375473#comment-16375473 ] Amit Gadaley commented on OFBIZ-9761: - Updated the patch. Thanks, [~mbrohl] and [~arunpati] for the guidance. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-9761: Attachment: OFBIZ-9761.patch > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7738) OFBIZ-7471: Improve all the service level error messages for missing required field for workeffort component
[ https://issues.apache.org/jira/browse/OFBIZ-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhaval Wagela updated OFBIZ-7738: - Attachment: OFBIZ-7738.patch > OFBIZ-7471: Improve all the service level error messages for missing required > field for workeffort component > > > Key: OFBIZ-7738 > URL: https://issues.apache.org/jira/browse/OFBIZ-7738 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7738.patch, OFBIZ-7738.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10236) UI Issue with Status ID at Parties page
[ https://issues.apache.org/jira/browse/OFBIZ-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aayush jain updated OFBIZ-10236: Summary: UI Issue with Status ID at Parties page (was: UI with Status ID at Parties page) > UI Issue with Status ID at Parties page > --- > > Key: OFBIZ-10236 > URL: https://issues.apache.org/jira/browse/OFBIZ-10236 > Project: OFBiz > Issue Type: Bug > Components: party > Environment: https://demo-trunk.ofbiz.apache.org >Reporter: Aayush jain >Priority: Trivial > Attachments: Enabled.png > > > Steps: > # Open URL > [https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?partyId=BLOGUSER_GUEST] > # Navigate to Status Id drop-down > # Check for Enabled > Actual: Displaying Enabled twice in drop-down section, Kindly refer > attachment for same. Thanks! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10236) UI with Status ID at Parties page
Aayush jain created OFBIZ-10236: --- Summary: UI with Status ID at Parties page Key: OFBIZ-10236 URL: https://issues.apache.org/jira/browse/OFBIZ-10236 Project: OFBiz Issue Type: Bug Components: party Environment: https://demo-trunk.ofbiz.apache.org Reporter: Aayush jain Attachments: Enabled.png Steps: # Open URL [https://demo-trunk.ofbiz.apache.org/partymgr/control/editperson?partyId=BLOGUSER_GUEST] # Navigate to Status Id drop-down # Check for Enabled Actual: Displaying Enabled twice in drop-down section, Kindly refer attachment for same. Thanks! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10121) Incorrect Party profile view redirection in SFA due to missing roleType
[ https://issues.apache.org/jira/browse/OFBIZ-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375444#comment-16375444 ] Ankit Joshi commented on OFBIZ-10121: - Added a patch with separate screens to view profile for SFA parties which include Account, Lead, Contact, Account_Lead. Now, any action initiated from the profile would not require roleTypeId as a parameter to view the details properly after completing the request. > Incorrect Party profile view redirection in SFA due to missing roleType > --- > > Key: OFBIZ-10121 > URL: https://issues.apache.org/jira/browse/OFBIZ-10121 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Ankit Joshi >Priority: Major > Attachments: OFBIZ-10121.patch > > > Currently, a single screen is using in SFA to view the profile of parties > like Account, Lead, Contact, and Account-Lead on the basis of their roles. It > requires roleTypeId to pass as a request parameter on each action initiates > from the profile to render the details on the profile correctly after > completing the request. > *Issue:* Various actions on the profile screen does not include roleTypeId as > a request parameter. It results in redirecting to the empty profile screen > after completing the request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10121) Incorrect Party profile view redirection in SFA due to missing roleType
[ https://issues.apache.org/jira/browse/OFBIZ-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi updated OFBIZ-10121: Attachment: OFBIZ-10121.patch > Incorrect Party profile view redirection in SFA due to missing roleType > --- > > Key: OFBIZ-10121 > URL: https://issues.apache.org/jira/browse/OFBIZ-10121 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Ankit Joshi >Priority: Major > Attachments: OFBIZ-10121.patch > > > Currently, a single screen is using in SFA to view the profile of parties > like Account, Lead, Contact, and Account-Lead on the basis of their roles. It > requires roleTypeId to pass as a request parameter on each action initiates > from the profile to render the details on the profile correctly after > completing the request. > *Issue:* Various actions on the profile screen does not include roleTypeId as > a request parameter. It results in redirecting to the empty profile screen > after completing the request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-9761: Attachment: (was: OFBIZ-9761.patch) > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-9761: --- Assignee: Arun Patidar (was: Amit Gadaley) > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Arun Patidar >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9898) Incorrect succes mesage after creating customer
[ https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375429#comment-16375429 ] Anushi Gupta commented on OFBIZ-9898: - Attached patch for the issue. > Incorrect succes mesage after creating customer > --- > > Key: OFBIZ-9898 > URL: https://issues.apache.org/jira/browse/OFBIZ-9898 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Anushi Gupta >Assignee: Anushi Gupta >Priority: Major > Attachments: OFBIZ-9898.patch > > > Steps to regenerate > 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main > 2) Go to party component. > 2) Click on Create new customer. > 3) Fill in the mandatory fields and click on save button. > Actual : > 'ProductStoreRole created successfully' message is displayed after successful > creation of customer. > Expected : > 'Customer created successfully' message should be displayed after successful > creation of customer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375437#comment-16375437 ] Michael Brohl commented on OFBIZ-9761: -- Hi [~amit.gadaley], the new patch still contains the pattern .equals() instead of .equals(). Can you please fix this? > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gadaley updated OFBIZ-9761: Attachment: OFBIZ-9761.patch > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375435#comment-16375435 ] Amit Gadaley commented on OFBIZ-9761: - Updated the patch. Thanks, [~mbrohl] and [~arunpati] for the guidance. > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Amit Gadaley >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10235) Update org.ofbiz package to org.apache.ofbiz in some missing entity def
[ https://issues.apache.org/jira/browse/OFBIZ-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-10235: - Affects Version/s: Trunk > Update org.ofbiz package to org.apache.ofbiz in some missing entity def > > > Key: OFBIZ-10235 > URL: https://issues.apache.org/jira/browse/OFBIZ-10235 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk, 16.11.04 >Reporter: Arun Patidar >Assignee: Arun Patidar >Priority: Major > Fix For: 17.12.01, 16.11.05 > > > Observed that there are still some org.ofbiz package used in entity > defination. Replace org.ofbiz with org.apache.ofbiz package in missing cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9898) Incorrect succes mesage after creating customer
[ https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anushi Gupta updated OFBIZ-9898: Attachment: OFBIZ-9898.patch > Incorrect succes mesage after creating customer > --- > > Key: OFBIZ-9898 > URL: https://issues.apache.org/jira/browse/OFBIZ-9898 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Anushi Gupta >Assignee: Anushi Gupta >Priority: Major > Attachments: OFBIZ-9898.patch > > > Steps to regenerate > 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main > 2) Go to party component. > 2) Click on Create new customer. > 3) Fill in the mandatory fields and click on save button. > Actual : > 'ProductStoreRole created successfully' message is displayed after successful > creation of customer. > Expected : > 'Customer created successfully' message should be displayed after successful > creation of customer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7738) OFBIZ-7471: Improve all the service level error messages for missing required field for workeffort component
[ https://issues.apache.org/jira/browse/OFBIZ-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-7738: Affects Version/s: Trunk > OFBIZ-7471: Improve all the service level error messages for missing required > field for workeffort component > > > Key: OFBIZ-7738 > URL: https://issues.apache.org/jira/browse/OFBIZ-7738 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Affects Versions: Trunk, 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7738.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-7738) OFBIZ-7471: Improve all the service level error messages for missing required field for workeffort component
[ https://issues.apache.org/jira/browse/OFBIZ-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-7738: --- Assignee: Arun Patidar (was: Ashish Vijaywargiya) > OFBIZ-7471: Improve all the service level error messages for missing required > field for workeffort component > > > Key: OFBIZ-7738 > URL: https://issues.apache.org/jira/browse/OFBIZ-7738 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Affects Versions: 16.11.01 >Reporter: Ratnesh Upadhyay >Assignee: Arun Patidar >Priority: Minor > Attachments: OFBIZ-7738.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9898) Incorrect succes mesage after creating customer
[ https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anushi Gupta reassigned OFBIZ-9898: --- Assignee: Anushi Gupta > Incorrect succes mesage after creating customer > --- > > Key: OFBIZ-9898 > URL: https://issues.apache.org/jira/browse/OFBIZ-9898 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Anushi Gupta >Assignee: Anushi Gupta >Priority: Major > > Steps to regenerate > 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main > 2) Go to party component. > 2) Click on Create new customer. > 3) Fill in the mandatory fields and click on save button. > Actual : > 'ProductStoreRole created successfully' message is displayed after successful > creation of customer. > Expected : > 'Customer created successfully' message should be displayed after successful > creation of customer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9998) Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity
[ https://issues.apache.org/jira/browse/OFBIZ-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayushi Rathod reassigned OFBIZ-9998: Assignee: Ayushi Rathod > Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity > > > Key: OFBIZ-9998 > URL: https://issues.apache.org/jira/browse/OFBIZ-9998 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Vaibhav Jain >Assignee: Ayushi Rathod >Priority: Major > > As per the discussion int respective mail thread > [http://ofbiz.markmail.org/message/i2wk2anzrhacbltq?q=%5BPROPOSAL%5D+Extend+returnId+and+shipmentId+in+FinAccountTrans+entity] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9998) Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity
[ https://issues.apache.org/jira/browse/OFBIZ-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayushi Rathod reassigned OFBIZ-9998: Assignee: (was: Ayushi Rathod) > Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity > > > Key: OFBIZ-9998 > URL: https://issues.apache.org/jira/browse/OFBIZ-9998 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Vaibhav Jain >Priority: Major > > As per the discussion int respective mail thread > [http://ofbiz.markmail.org/message/i2wk2anzrhacbltq?q=%5BPROPOSAL%5D+Extend+returnId+and+shipmentId+in+FinAccountTrans+entity] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9998) Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity
[ https://issues.apache.org/jira/browse/OFBIZ-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayushi Rathod closed OFBIZ-9998. Resolution: Fixed > Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity > > > Key: OFBIZ-9998 > URL: https://issues.apache.org/jira/browse/OFBIZ-9998 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Vaibhav Jain >Priority: Major > > As per the discussion int respective mail thread > [http://ofbiz.markmail.org/message/i2wk2anzrhacbltq?q=%5BPROPOSAL%5D+Extend+returnId+and+shipmentId+in+FinAccountTrans+entity] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-9998) Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity
[ https://issues.apache.org/jira/browse/OFBIZ-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayushi Rathod reopened OFBIZ-9998: -- > Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity > > > Key: OFBIZ-9998 > URL: https://issues.apache.org/jira/browse/OFBIZ-9998 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Vaibhav Jain >Priority: Major > > As per the discussion int respective mail thread > [http://ofbiz.markmail.org/message/i2wk2anzrhacbltq?q=%5BPROPOSAL%5D+Extend+returnId+and+shipmentId+in+FinAccountTrans+entity] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10235) Update org.ofbiz package to org.apache.ofbiz in some missing entity def
[ https://issues.apache.org/jira/browse/OFBIZ-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-10235: - Affects Version/s: 16.11.04 > Update org.ofbiz package to org.apache.ofbiz in some missing entity def > > > Key: OFBIZ-10235 > URL: https://issues.apache.org/jira/browse/OFBIZ-10235 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk, 16.11.04 >Reporter: Arun Patidar >Assignee: Arun Patidar >Priority: Major > Fix For: 17.12.01, 16.11.05 > > > Observed that there are still some org.ofbiz package used in entity > defination. Replace org.ofbiz with org.apache.ofbiz package in missing cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10235) Update org.ofbiz package to org.apache.ofbiz in some missing entity def
[ https://issues.apache.org/jira/browse/OFBIZ-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar closed OFBIZ-10235. Resolution: Fixed Fix Version/s: 16.11.05 17.12.01 Committed in trunk at revision 1825199 in 17.12 at rev: 1825200 in 16.11 at rev: 1825201 > Update org.ofbiz package to org.apache.ofbiz in some missing entity def > > > Key: OFBIZ-10235 > URL: https://issues.apache.org/jira/browse/OFBIZ-10235 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Arun Patidar >Assignee: Arun Patidar >Priority: Major > Fix For: 17.12.01, 16.11.05 > > > Observed that there are still some org.ofbiz package used in entity > defination. Replace org.ofbiz with org.apache.ofbiz package in missing cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-9969) In 'ValidateMethod.java', when we don't pass any className from xml files. default value 'org.apache.ofbiz.base.util.UtilValidate' should be set for className.
[ https://issues.apache.org/jira/browse/OFBIZ-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit resolved OFBIZ-9969. - Resolution: Done > In 'ValidateMethod.java', when we don't pass any className from xml files. > default value 'org.apache.ofbiz.base.util.UtilValidate' should be set for > className. > --- > > Key: OFBIZ-9969 > URL: https://issues.apache.org/jira/browse/OFBIZ-9969 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Sonal Patwari >Assignee: Deepak Dixit >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-9969.patch, OFBIZ-9969.patch > > > *Actual:* In 'ValidateMethod.java', If we have not passed any className from > the xml files.Then, className is set to null and throws an error of > 'Validation Method not found'. > *Expected:* A default value 'org.apache.ofbiz.base.util.UtilValidate' should > be assigned to the className. > As reference: Visit 'ValidateMethodCondition.java' and there, 'className' is > set with a default value 'org.apache.ofbiz.base.util.UtilValidate'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9969) In 'ValidateMethod.java', when we don't pass any className from xml files. default value 'org.apache.ofbiz.base.util.UtilValidate' should be set for className.
[ https://issues.apache.org/jira/browse/OFBIZ-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-9969: Fix Version/s: (was: 17.12.01) Upcoming Branch > In 'ValidateMethod.java', when we don't pass any className from xml files. > default value 'org.apache.ofbiz.base.util.UtilValidate' should be set for > className. > --- > > Key: OFBIZ-9969 > URL: https://issues.apache.org/jira/browse/OFBIZ-9969 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Sonal Patwari >Assignee: Deepak Dixit >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-9969.patch, OFBIZ-9969.patch > > > *Actual:* In 'ValidateMethod.java', If we have not passed any className from > the xml files.Then, className is set to null and throws an error of > 'Validation Method not found'. > *Expected:* A default value 'org.apache.ofbiz.base.util.UtilValidate' should > be assigned to the className. > As reference: Visit 'ValidateMethodCondition.java' and there, 'className' is > set with a default value 'org.apache.ofbiz.base.util.UtilValidate'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9969) In 'ValidateMethod.java', when we don't pass any className from xml files. default value 'org.apache.ofbiz.base.util.UtilValidate' should be set for className.
[
https://issues.apache.org/jira/browse/OFBIZ-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375412#comment-16375412
]
Deepak Dixit commented on OFBIZ-9969:
-
Thanks Suraj and Sonal for your contribution.
This has been committed at ofbiz framework trunk at
r#{color:#22}1825197{color}
> In 'ValidateMethod.java', when we don't pass any className from xml files.
> default value 'org.apache.ofbiz.base.util.UtilValidate' should be set for
> className.
> ---
>
> Key: OFBIZ-9969
> URL: https://issues.apache.org/jira/browse/OFBIZ-9969
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Sonal Patwari
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9969.patch, OFBIZ-9969.patch
>
>
> *Actual:* In 'ValidateMethod.java', If we have not passed any className from
> the xml files.Then, className is set to null and throws an error of
> 'Validation Method not found'.
> *Expected:* A default value 'org.apache.ofbiz.base.util.UtilValidate' should
> be assigned to the className.
> As reference: Visit 'ValidateMethodCondition.java' and there, 'className' is
> set with a default value 'org.apache.ofbiz.base.util.UtilValidate'.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9998) Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity
[ https://issues.apache.org/jira/browse/OFBIZ-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayushi Rathod reassigned OFBIZ-9998: Assignee: (was: Ayushi Rathod) > Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity > > > Key: OFBIZ-9998 > URL: https://issues.apache.org/jira/browse/OFBIZ-9998 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Vaibhav Jain >Priority: Major > > As per the discussion int respective mail thread > [http://ofbiz.markmail.org/message/i2wk2anzrhacbltq?q=%5BPROPOSAL%5D+Extend+returnId+and+shipmentId+in+FinAccountTrans+entity] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9998) Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity
[ https://issues.apache.org/jira/browse/OFBIZ-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayushi Rathod reassigned OFBIZ-9998: Assignee: Ayushi Rathod > Remove paymentId, orderId and orderItemSeqId from finAccountTrans entity > > > Key: OFBIZ-9998 > URL: https://issues.apache.org/jira/browse/OFBIZ-9998 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Vaibhav Jain >Assignee: Ayushi Rathod >Priority: Major > > As per the discussion int respective mail thread > [http://ofbiz.markmail.org/message/i2wk2anzrhacbltq?q=%5BPROPOSAL%5D+Extend+returnId+and+shipmentId+in+FinAccountTrans+entity] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10235) Update org.ofbiz package to org.apache.ofbiz in some missing entity def
[ https://issues.apache.org/jira/browse/OFBIZ-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar reassigned OFBIZ-10235: Assignee: Arun Patidar > Update org.ofbiz package to org.apache.ofbiz in some missing entity def > > > Key: OFBIZ-10235 > URL: https://issues.apache.org/jira/browse/OFBIZ-10235 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Arun Patidar >Assignee: Arun Patidar >Priority: Major > > Observed that there are still some org.ofbiz package used in entity > defination. Replace org.ofbiz with org.apache.ofbiz package in missing cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10235) Update org.ofbiz package to org.apache.ofbiz in some missing entity def
Arun Patidar created OFBIZ-10235: Summary: Update org.ofbiz package to org.apache.ofbiz in some missing entity def Key: OFBIZ-10235 URL: https://issues.apache.org/jira/browse/OFBIZ-10235 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Reporter: Arun Patidar Observed that there are still some org.ofbiz package used in entity defination. Replace org.ofbiz with org.apache.ofbiz package in missing cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9833) Token Based Authentication
[ https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375398#comment-16375398 ] Deepak Dixit commented on OFBIZ-9833: - Added a patch that we can used for generic way. Added JWTManager class with following method: - getAuthenticationToken: It validate credential using userLogin service and if user is valid it will call createJwt method to generate token. - validateToken: validate token, verify jwt signature, expiration time if token valid it will return the custom claims from jwt token * createJwt: It will create jwtToken, we can pass expireTime else it will use 30 min as default timeout. Added new filter TokenFilter.java that will check if request has Bearer header * it will validate and if token is valid it will get user login associated with it and put it in session and send control to request handler for further action. * If token validation failed (request has token but validation falied) it will return error * If request does not contains Bearer header then it will do noting simply return success. Token can be used for various purpose along with authentication. As it can be used for email links, anon user order view etc. So added generic way to createJwt token for various use scenario. > Token Based Authentication > -- > > Key: OFBIZ-9833 > URL: https://issues.apache.org/jira/browse/OFBIZ-9833 > Project: OFBiz > Issue Type: New Feature > Components: framework >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Attachments: JSON Web Tokens.pdf, OFBIZ-9833-JWTManager.patch, > OFBIZ-9833-external-server-test-example.patch, > OFBIZ-9833-external-server-test-example.patch, > OFBIZ-9833-external-server.patch, OFBIZ-9833-external-server.patch, > OFBIZ-9833-external-server.patch, Token Based Authentication in Apache > OfBiz.pdf, Token Based Authentication.pdf, rfc7519.pdf > > > Here is dev list discussion for token based authentication work: > http://markmail.org/message/vyskeh2wujqpkbwg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9521) User should be notified with success message on add to cart action in ecommerce component
[ https://issues.apache.org/jira/browse/OFBIZ-9521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lalit Dashora reassigned OFBIZ-9521: Assignee: Lalit Dashora > User should be notified with success message on add to cart action in > ecommerce component > - > > Key: OFBIZ-9521 > URL: https://issues.apache.org/jira/browse/OFBIZ-9521 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Lalit Dashora >Priority: Trivial > > Steps to regenerate: > 1. Go to Ecommerce component > (https://demo-trunk.ofbiz.apache.org/ecommerce/control/main). > 2. Click Add To Cart for any product. > No success message on successful action. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10232) Survey response data lost on loadCartFromOrder service
[ https://issues.apache.org/jira/browse/OFBIZ-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-10232: - Affects Version/s: Release Branch 16.11 > Survey response data lost on loadCartFromOrder service > -- > > Key: OFBIZ-10232 > URL: https://issues.apache.org/jira/browse/OFBIZ-10232 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Suraj Khurana >Assignee: Arun Patidar >Priority: Major > Fix For: 17.12.01, 16.11.05 > > Attachments: OFBIZ-10232.patch > > > When quotes are being converted to orders it appears that we are losing the > survey data that is provided in the Quote. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10232) Survey response data lost on loadCartFromOrder service
[ https://issues.apache.org/jira/browse/OFBIZ-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar closed OFBIZ-10232. Resolution: Fixed Fix Version/s: 16.11.05 17.12.01 Committed changes in the trunk at rev: 1825192. at 16.11 at rev: 1825194 and at 17.122 at rev: 1825193. Thanks Mr. Khurana for your contribution. > Survey response data lost on loadCartFromOrder service > -- > > Key: OFBIZ-10232 > URL: https://issues.apache.org/jira/browse/OFBIZ-10232 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Suraj Khurana >Assignee: Arun Patidar >Priority: Major > Fix For: 17.12.01, 16.11.05 > > Attachments: OFBIZ-10232.patch > > > When quotes are being converted to orders it appears that we are losing the > survey data that is provided in the Quote. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9833) Token Based Authentication
[ https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-9833: Attachment: OFBIZ-9833-JWTManager.patch > Token Based Authentication > -- > > Key: OFBIZ-9833 > URL: https://issues.apache.org/jira/browse/OFBIZ-9833 > Project: OFBiz > Issue Type: New Feature > Components: framework >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Attachments: JSON Web Tokens.pdf, OFBIZ-9833-JWTManager.patch, > OFBIZ-9833-external-server-test-example.patch, > OFBIZ-9833-external-server-test-example.patch, > OFBIZ-9833-external-server.patch, OFBIZ-9833-external-server.patch, > OFBIZ-9833-external-server.patch, Token Based Authentication in Apache > OfBiz.pdf, Token Based Authentication.pdf, rfc7519.pdf > > > Here is dev list discussion for token based authentication work: > http://markmail.org/message/vyskeh2wujqpkbwg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
