[jira] [Commented] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items
[ https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413396#comment-16413396 ] Suraj Khurana commented on OFBIZ-10301: --- Here is the patch with proper fix. Also, removed setting of redundant orderName on cart. > loadCartFromOrder changes order date even when updating order items > --- > > Key: OFBIZ-10301 > URL: https://issues.apache.org/jira/browse/OFBIZ-10301 > Project: OFBiz > Issue Type: Bug >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10301.patch > > > It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is > true other wise it should set orderDate from existing orderHeader. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10301) loadCartFromOrder changes order date even when updating order items
[ https://issues.apache.org/jira/browse/OFBIZ-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-10301: -- Attachment: OFBIZ-10301.patch > loadCartFromOrder changes order date even when updating order items > --- > > Key: OFBIZ-10301 > URL: https://issues.apache.org/jira/browse/OFBIZ-10301 > Project: OFBiz > Issue Type: Bug >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10301.patch > > > It should only set orderDate as nowTimeStamp only if createAsNewOrder flag is > true other wise it should set orderDate from existing orderHeader. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6882) Extend the PostalAddress entity with additional elements
[ https://issues.apache.org/jira/browse/OFBIZ-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413347#comment-16413347 ] Paul Foxworthy commented on OFBIZ-6882: --- Hi all, The Universal Postal Union has a project to standardise exchange of postal addresses, UPU S42. ([http://www.upu.int/uploads/tx_sbdownloader/sheetAddressingS42InternationalAddressingStandardsFactSheetEn.pdf).] The name, in English, for the number component is "street number" or "street no" for short. Google geocoding uses "street_number" ([https://developers.google.com/maps/documentation/javascript/geocoding#GeocodingAddressTypes).] > Extend the PostalAddress entity with additional elements > > > Key: OFBIZ-6882 > URL: https://issues.apache.org/jira/browse/OFBIZ-6882 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: 3rdParty, Shipment, integration > Fix For: 16.11.01 > > Attachments: OFBIZ-6882-party-PostalAddress.patch > > > Various modern day 3rd party delivery solutions (e.g. PostNL in The > Netherlands) require that elements are delivered separately, so that > addresses can be checked more easily. > Current definition of the PostalAddress doesn't have separation of: > * street name > * house number > * house number addition or extension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6882) Extend the PostalAddress entity with additional elements
[ https://issues.apache.org/jira/browse/OFBIZ-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413283#comment-16413283 ] Scott Gray commented on OFBIZ-6882: --- I'm surprised you went with houseNumber [~jacques.le.roux] What if the address is for an office or a warehouse? Even with review and doubts from others on some of these fields you still went ahead without question or even engaging in the discussion. The houseNumber name is poorly chosen, and Pierre provided no justification for the municipalityGeoId field. This wasn't good committer behavior. > Extend the PostalAddress entity with additional elements > > > Key: OFBIZ-6882 > URL: https://issues.apache.org/jira/browse/OFBIZ-6882 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: 3rdParty, Shipment, integration > Fix For: 16.11.01 > > Attachments: OFBIZ-6882-party-PostalAddress.patch > > > Various modern day 3rd party delivery solutions (e.g. PostNL in The > Netherlands) require that elements are delivered separately, so that > addresses can be checked more easily. > Current definition of the PostalAddress doesn't have separation of: > * street name > * house number > * house number addition or extension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
