[jira] [Commented] (OFBIZ-10428) Don't guess the system file separator
[
https://issues.apache.org/jira/browse/OFBIZ-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518642#comment-16518642
]
Jacques Le Roux commented on OFBIZ-10428:
-
Actually there are 2 quirks in your patches.
# In case of Windows we need to escape "\" so adding {code}"\\"{code} before
fileSep is required
# In is not a replacement for contains but is based on isCase so we can't use
it reliably for that purpose, see
http://docs.groovy-lang.org/latest/html/groovy-jdk/java/lang/Class.html and
https://stackoverflow.com/questions/2068298/how-does-the-groovy-in-operator-work
For instance
{{def isWindows =
System.getProperty('os.name').toLowerCase().contains("windows")}} works but not
{code}
//String os = System.getProperty('os.name').toLowerCase()
def os = System.getProperty('os.name').toLowerCase()
//def isWindows = 'windows' in os
def isWindows = "windows" in os
{code}
using String or def, simple or double quote. Did you not confuse with Kotlin:
https://medium.com/@agrawalsuneet/in-operator-in-kotlin-bbf0b6131718 ?
I fixed the #1 quirk in revision: 1833957 using contains instead of in. I must
say it's late and I'm tired so I maybe missed something. In any cases I prefer
to delay working on OFBIZ-10430 for tonight ;)
> Don't guess the system file separator
> -
>
> Key: OFBIZ-10428
> URL: https://issues.apache.org/jira/browse/OFBIZ-10428
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10428_Don_t-guess-the-system-file-separator.patch
>
>
> The JVM already knows the file separator of the current system when running
> gradle so use that value instead of guessing from the operating system
> property.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10428) Don't guess the system file separator
[ https://issues.apache.org/jira/browse/OFBIZ-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10428. --- Resolution: Implemented > Don't guess the system file separator > - > > Key: OFBIZ-10428 > URL: https://issues.apache.org/jira/browse/OFBIZ-10428 > Project: OFBiz > Issue Type: Improvement >Reporter: Mathieu Lirzin >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10428_Don_t-guess-the-system-file-separator.patch > > > The JVM already knows the file separator of the current system when running > gradle so use that value instead of guessing from the operating system > property. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10428) Don't guess the system file separator
[ https://issues.apache.org/jira/browse/OFBIZ-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518603#comment-16518603 ] Mathieu Lirzin commented on OFBIZ-10428: Thanks Jacques, can you tell me more about this quirk? > Don't guess the system file separator > - > > Key: OFBIZ-10428 > URL: https://issues.apache.org/jira/browse/OFBIZ-10428 > Project: OFBiz > Issue Type: Improvement >Reporter: Mathieu Lirzin >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10428_Don_t-guess-the-system-file-separator.patch > > > The JVM already knows the file separator of the current system when running > gradle so use that value instead of guessing from the operating system > property. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10429) Use functional programming in build script
[ https://issues.apache.org/jira/browse/OFBIZ-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518600#comment-16518600 ] Mathieu Lirzin commented on OFBIZ-10429: Thanks Jacques > Use functional programming in build script > -- > > Key: OFBIZ-10429 > URL: https://issues.apache.org/jira/browse/OFBIZ-10429 > Project: OFBiz > Issue Type: Improvement >Reporter: Mathieu Lirzin >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-10429-Use-findAll-instead-of-getTasksMatchingRegex.patch, > OFBIZ-10429-Use-stream-processing-in-subprojectExists.patch, > OFBIZ-10429-Use-stream-processing-in-taskExistsInproject.patch > > > No functional change, the idea is to have more declarative code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-10428) Don't guess the system file separator
[ https://issues.apache.org/jira/browse/OFBIZ-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-10428: - I need to fix a small quirk in Windows here > Don't guess the system file separator > - > > Key: OFBIZ-10428 > URL: https://issues.apache.org/jira/browse/OFBIZ-10428 > Project: OFBiz > Issue Type: Improvement >Reporter: Mathieu Lirzin >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10428_Don_t-guess-the-system-file-separator.patch > > > The JVM already knows the file separator of the current system when running > gradle so use that value instead of guessing from the operating system > property. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518592#comment-16518592
]
Mathieu Lirzin commented on OFBIZ-10438:
Hello Shi,
Having a {{method}} attribute has the advantage or requiring minimal changes in
the XML grammar even if it can involve some redundancy. I have included a set
of patches implementing the support of alternative HTTP methods and the
dispatch to the request-map with the corresponding {{method}} attribute.
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Priority: Minor
> Attachments:
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch,
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch,
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch,
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10438:
---
Attachment:
OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch
OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch
OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch
OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Priority: Minor
> Attachments:
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch,
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch,
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch,
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10429) Use functional programming in build script
[ https://issues.apache.org/jira/browse/OFBIZ-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10429. --- Resolution: Implemented Fix Version/s: (was: Trunk) Upcoming Branch Thanks Mathieu, Your patches are in trunk at revision: 1833951 Please don't use tabs in patches, thanks. Also we use "Upcoming Version" in "Fix Version/s" field not "trunk", see why at https://s.apache.org/owBz > Use functional programming in build script > -- > > Key: OFBIZ-10429 > URL: https://issues.apache.org/jira/browse/OFBIZ-10429 > Project: OFBiz > Issue Type: Improvement >Reporter: Mathieu Lirzin >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-10429-Use-findAll-instead-of-getTasksMatchingRegex.patch, > OFBIZ-10429-Use-stream-processing-in-subprojectExists.patch, > OFBIZ-10429-Use-stream-processing-in-taskExistsInproject.patch > > > No functional change, the idea is to have more declarative code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10428) Don't guess the system file separator
[ https://issues.apache.org/jira/browse/OFBIZ-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10428. --- Resolution: Implemented Fix Version/s: (was: Trunk) Upcoming Branch Thanks Mathieu, Your patch is in trunk at revision: 1833949 > Don't guess the system file separator > - > > Key: OFBIZ-10428 > URL: https://issues.apache.org/jira/browse/OFBIZ-10428 > Project: OFBiz > Issue Type: Improvement >Reporter: Mathieu Lirzin >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10428_Don_t-guess-the-system-file-separator.patch > > > The JVM already knows the file separator of the current system when running > gradle so use that value instead of guessing from the operating system > property. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10123) Tomcat SSO in Cluster
[ https://issues.apache.org/jira/browse/OFBIZ-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518181#comment-16518181 ] James Yong commented on OFBIZ-10123: A patch is made for the trunk. Before testing: 1) Make sure to uncomment the following property at framework/catalina/ofbiz-component.xml: 2) Set the following properties at security.properties security.login.tomcat.sso=true security.login.externalLoginKey.enabled=false 3) Use an external database like postgresql 4) Open 1 terminal and start OFBiz using ./gradlew ofbiz Open another terminal and start OFBiz with ./gradlew "ofbiz --start --portoffset 1" 6) Access https://localhost:8443/catalog/control/main follow by https://localhost:18443/catalog/control/main > Tomcat SSO in Cluster > - > > Key: OFBIZ-10123 > URL: https://issues.apache.org/jira/browse/OFBIZ-10123 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Labels: Cluster, Login > Fix For: 17.12.01 > > Attachments: OFBIZ-10123.patch > > > Add Tomcat SSO support in clustered environment using ClusterSingleSignOn as > discussed in OFBIZ-10047. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10123) Tomcat SSO in Cluster
[ https://issues.apache.org/jira/browse/OFBIZ-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-10123: --- Attachment: OFBIZ-10123.patch > Tomcat SSO in Cluster > - > > Key: OFBIZ-10123 > URL: https://issues.apache.org/jira/browse/OFBIZ-10123 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Labels: Cluster, Login > Fix For: 17.12.01 > > Attachments: OFBIZ-10123.patch > > > Add Tomcat SSO support in clustered environment using ClusterSingleSignOn as > discussed in OFBIZ-10047. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10123) Tomcat SSO in Cluster
[ https://issues.apache.org/jira/browse/OFBIZ-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong reassigned OFBIZ-10123: -- Assignee: James Yong > Tomcat SSO in Cluster > - > > Key: OFBIZ-10123 > URL: https://issues.apache.org/jira/browse/OFBIZ-10123 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Labels: Cluster, Login > Fix For: 17.12.01 > > > Add Tomcat SSO support in clustered environment using ClusterSingleSignOn as > discussed in OFBIZ-10047. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shi Jinghai updated OFBIZ-10438:
Description:
As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no matter
what request it is.
I like Mathieu's comment on adding a method attribute to the request-map
element, it's almost the same as we implemented in our openapi:
{code:java}
{code}
The difference is that we DON'T support method list expression:
{code:java}
...
{code}
was:
As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no matter
what request it is.
I like Mathieu's comment on adding a method attribute to the request-map
element, it's almost the same as we implemented in our openapi:
The difference is that we DON'T support method list expression:
...
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Priority: Minor
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
Shi Jinghai created OFBIZ-10438: --- Summary: Add method attribute to request-map to controll a uri can be called GET or POST only Key: OFBIZ-10438 URL: https://issues.apache.org/jira/browse/OFBIZ-10438 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Shi Jinghai As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no matter what request it is. I like Mathieu's comment on adding a method attribute to the request-map element, it's almost the same as we implemented in our openapi: The difference is that we DON'T support method list expression: ... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
