[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524609#comment-16524609 ] Shi Jinghai commented on OFBIZ-10438: - Hi Mathieu, Your new patches are in rev. 1834465. I tested them and all 3 cases listed above are OK. And method="" and method="all" are OK. I insist to support method="" as according to the xsd, it's allowed and should be parsed as method="all". I'm happy you returned to doGet/doPost, I guess you read this tomcat document (the service method tortured me for a while) https://tomcat.apache.org/tomcat-5.5-doc/servletapi/javax/servlet/http/HttpServlet.html {code:java} ... There's almost no reason to override the service method. service handles standard HTTP requests by dispatching them to the handler methods for each HTTP request type (the doXXX methods listed above). ...{code} I have to say, you're very sensitive and smart. My last beg, could you remove the java.util.Optional(since JDK 1.8) to make the patches can be backported to OFBiz 14.07? Kind Regards, > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch, > OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch, > OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524442#comment-16524442 ] Shi Jinghai commented on OFBIZ-10438: - Thank you Mathieu! Let me test your new patches now. > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch, > OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch, > OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10443) Remove org.apache.tomcat.util.net.secure_protocol_version from json output
[ https://issues.apache.org/jira/browse/OFBIZ-10443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524441#comment-16524441 ] Shi Jinghai commented on OFBIZ-10443: - Hi Jacques, Thanks for your reviewing. No, it's not a security issue. > Remove org.apache.tomcat.util.net.secure_protocol_version from json output > -- > > Key: OFBIZ-10443 > URL: https://issues.apache.org/jira/browse/OFBIZ-10443 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-10443-CommonEvents-20180626.patch > > > Visit [https://localhost:8443/example/control/createExampleAjax,] in the > output json, the > org.apache.tomcat.util.net.secure_protocol_version is unnecessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524296#comment-16524296 ] Mathieu Lirzin commented on OFBIZ-10438: Here are two patches for the refactoring ([^OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch], [^OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch]) A few comments: - I reverted the use of the {{service}} method since you prefer to narrow to only {{GET}} and {{POST}} methods. - {{resolveURI}} has been splitted to separate the resolution of the uri and the resolution of method - {{resolveURI}} now integrates the logic regarding the override view uri. - I have used a new exception type to handle the special error handling for method not supported however I am not sure about the strategy unconditionally not using the default error page - I have removed the stream based implementation of {{resolveMethod}} which was a bit tricky to understand. - I have adapted the error message to not include the supported method (but not the translation). The reason is that IMO the {{OPTIONS}} method should be used for getting that information instead. - I am not sure we should support both "all" and "" to refer to the whole set of methods. it would be simpler to have only one choice. I don't have any preference. It is possible that I overlooked some of the tests you described above, so tell me if that's the case. > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch, > OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch, > OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch, > OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch, > OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0001-Improved-Parse-controller-config-in-one-place.patch) > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0002-Improved-Split-resolveURI-in-two-methods.patch) > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: OFBIZ-10438_0001-Improved-Parse-controller-config-in-one-place.patch OFBIZ-10438_0002-Improved-Split-resolveURI-in-two-methods.patch > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0001-Improved-Parse-controller-config-in-one-place.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0002-Improved-Split-resolveURI-in-two-methods.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10355) Define generic types in `ProductStoreEvents`
[ https://issues.apache.org/jira/browse/OFBIZ-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10355. --- > Define generic types in `ProductStoreEvents` > > > Key: OFBIZ-10355 > URL: https://issues.apache.org/jira/browse/OFBIZ-10355 > Project: OFBiz > Issue Type: Improvement >Reporter: Mathieu Lirzin >Assignee: Arun Patidar >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > 0001-improved-Define-generic-types-in-ProductStoreEvents.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10443) Remove org.apache.tomcat.util.net.secure_protocol_version from json output
[ https://issues.apache.org/jira/browse/OFBIZ-10443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523612#comment-16523612 ] Jacques Le Roux commented on OFBIZ-10443: - Hi Jinghai, I understand you don't want this attribute in the json response, but it's not related to a security issue, right? Else please link this issue to OFBIZ-5409, thanks. > Remove org.apache.tomcat.util.net.secure_protocol_version from json output > -- > > Key: OFBIZ-10443 > URL: https://issues.apache.org/jira/browse/OFBIZ-10443 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-10443-CommonEvents-20180626.patch > > > Visit [https://localhost:8443/example/control/createExampleAjax,] in the > output json, the > org.apache.tomcat.util.net.secure_protocol_version is unnecessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10444) Investigate how to possibly use CSS Grid Layout
Jacques Le Roux created OFBIZ-10444: --- Summary: Investigate how to possibly use CSS Grid Layout Key: OFBIZ-10444 URL: https://issues.apache.org/jira/browse/OFBIZ-10444 Project: OFBiz Issue Type: New Feature Components: ALL APPLICATIONS Affects Versions: Trunk Reporter: Jacques Le Roux Fix For: Upcoming Branch After reading [https://alistapart.com/article/cult-of-the-complex], I suggested [here|https://markmail.org/message/lz2i4qtdr7yqu3gj] we could consider using CSS Grid Layout everywhere in OFBiz instead of js frameworks, including [Bootstrap|https://www.google.fr/search?q=compare+Bootstrap+to+%22CSS+Grid+Layout%22=UTF-8]. Quoting myself: {quote}Depending the less possible on frameworks seems a good idea to me, and the "CSS Grid Layout" seems simple enough to be a viable replacement. Who knows when Bootstrap will be out of date... {quote} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523370#comment-16523370 ] Shi Jinghai commented on OFBIZ-10438: - Hi Jacques, Thanks! Sure, I'll start a thread after Mathieu submit the refactoring patch. > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523359#comment-16523359 ] Jacques Le Roux edited comment on OFBIZ-10438 at 6/26/18 7:51 AM: -- Hi Jinghai, Backporting an improvement needs to be discussed on the dev ML first, thanks. At least a major improvement like this one, but anyway that's the rule ;) was (Author: jacques.le.roux): Hi Jinghai, Backporting an improvement needs to be discussed on the dev ML first, thanks. > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523359#comment-16523359 ] Jacques Le Roux commented on OFBIZ-10438: - Hi Jinghai, Backporting an improvement needs to be discussed on the dev ML first, thanks. > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523353#comment-16523353 ] Mathieu Lirzin edited comment on OFBIZ-10438 at 6/26/18 7:39 AM: - Ok makes more sense. I was confused by “backporting to JDK ≥ 1.8” which I guess should have been “backporting to JDK < 1.8”. was (Author: mthl): Ok make more sense. I was confuse by “backporting to JDK ≥ 1.8” which I guess should have been “backporting to JDK < 1.8”. > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523353#comment-16523353 ] Mathieu Lirzin commented on OFBIZ-10438: Ok make more sense. I was confuse by “backporting to JDK ≥ 1.8” which I guess should have been “backporting to JDK < 1.8”. > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523334#comment-16523334 ] Shi Jinghai commented on OFBIZ-10438: - On the refactoring, YES please. On the backport, simple, the java.util.stream interfaces are supported since JDK 1.8, so the implement can be merged into OFBiz 16.11 and 17.12. That's what I mean. :) Kind Regards, > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523318#comment-16523318 ] Mathieu Lirzin commented on OFBIZ-10438: Great, thanks for working on it! If that's OK with you, I would like to do some refactoring before closing this issue. The reason is that AIUI {{resolveURI}} and {{matchRequestMethod}} responsibilities overlap a bit. ;-) {quote}I'll backport it to other versions JDK >= 1.8{quote} What do you mean? > Add method attribute to request-map to controll a uri can be called GET or > POST only > > > Key: OFBIZ-10438 > URL: https://issues.apache.org/jira/browse/OFBIZ-10438 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: > OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, > OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, > OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, > OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch > > > As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no > matter what request it is. > I like Mathieu's comment on adding a method attribute to the request-map > element, it's almost the same as we implemented in our openapi: > > {code:java} > > > > > > > {code} > The difference is that we DON'T support method list expression: > {code:java} > ... > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)