[jira] [Updated] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’
[
https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10450:
---
Attachment:
OFBIZ-10450_Improved-Extract-verification-of-certificates-in-Req.patch
> Extract verification of certificates in ‘RequestHandler’
>
>
> Key: OFBIZ-10450
> URL: https://issues.apache.org/jira/browse/OFBIZ-10450
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10450_Improved-Extract-verification-of-certificates-in-Req.patch
>
>
> No functional change. Reduce the size of {{RequestHandler::doRequest}}
> method. Add some tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’
Mathieu Lirzin created OFBIZ-10450:
--
Summary: Extract verification of certificates in ‘RequestHandler’
Key: OFBIZ-10450
URL: https://issues.apache.org/jira/browse/OFBIZ-10450
Project: OFBiz
Issue Type: Improvement
Components: base
Reporter: Mathieu Lirzin
Fix For: Upcoming Branch
No functional change. Reduce the size of {{RequestHandler::doRequest}} method.
Add some tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10449) Refactor ControlFilter
[ https://issues.apache.org/jira/browse/OFBIZ-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10449: --- Attachment: OFBIZ-10449_Improved-Refactor-ControlFilter.patch > Refactor ControlFilter > -- > > Key: OFBIZ-10449 > URL: https://issues.apache.org/jira/browse/OFBIZ-10449 > Project: OFBiz > Issue Type: Improvement > Components: base >Reporter: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10449_Improved-Refactor-ControlFilter.patch > > > The code has been decomposed in smaller documented methods. The tests has > been improved to cover more cases. No functional change -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10449) Refactor ControlFilter
Mathieu Lirzin created OFBIZ-10449: -- Summary: Refactor ControlFilter Key: OFBIZ-10449 URL: https://issues.apache.org/jira/browse/OFBIZ-10449 Project: OFBiz Issue Type: Improvement Components: base Reporter: Mathieu Lirzin Fix For: Upcoming Branch The code has been decomposed in smaller documented methods. The tests has been improved to cover more cases. No functional change -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10448) Remove useless logging levels checks in ControlServlet
[ https://issues.apache.org/jira/browse/OFBIZ-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10448: --- Attachment: OFBIZ-10448_Improved-Remove-useless-logging-levels-checks.patch > Remove useless logging levels checks in ControlServlet > -- > > Key: OFBIZ-10448 > URL: https://issues.apache.org/jira/browse/OFBIZ-10448 > Project: OFBiz > Issue Type: Improvement > Components: base >Reporter: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-10448_Improved-Remove-useless-logging-levels-checks.patch > > > Those checks are already done inside the Debug module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10448) Remove useless logging levels checks in ControlServlet
Mathieu Lirzin created OFBIZ-10448: -- Summary: Remove useless logging levels checks in ControlServlet Key: OFBIZ-10448 URL: https://issues.apache.org/jira/browse/OFBIZ-10448 Project: OFBiz Issue Type: Improvement Components: base Reporter: Mathieu Lirzin Fix For: Upcoming Branch Those checks are already done inside the Debug module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10447) Remove useless ControlServlet code
[ https://issues.apache.org/jira/browse/OFBIZ-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10447: --- Attachment: OFBIZ-10447_Improved-Remove-useless-ControlServlet-code.patch > Remove useless ControlServlet code > -- > > Key: OFBIZ-10447 > URL: https://issues.apache.org/jira/browse/OFBIZ-10447 > Project: OFBiz > Issue Type: Improvement > Components: base >Reporter: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-10447_Improved-Remove-useless-ControlServlet-code.patch > > > It seems better to remove some code and rely on method/contrustor dispatch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10447) Remove useless ControlServlet code
Mathieu Lirzin created OFBIZ-10447: -- Summary: Remove useless ControlServlet code Key: OFBIZ-10447 URL: https://issues.apache.org/jira/browse/OFBIZ-10447 Project: OFBiz Issue Type: Improvement Components: base Reporter: Mathieu Lirzin Fix For: Upcoming Branch It seems better to remove some code and rely on method/contrustor dispatch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10446) Override ‘GenericServlet::init’ instead of ‘Servlet::init’
[
https://issues.apache.org/jira/browse/OFBIZ-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10446:
---
Attachment:
OFBIZ-10446_Improved-Override-GenericServlet-init-instead-of-Ser.patch
> Override ‘GenericServlet::init’ instead of ‘Servlet::init’
> --
>
> Key: OFBIZ-10446
> URL: https://issues.apache.org/jira/browse/OFBIZ-10446
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10446_Improved-Override-GenericServlet-init-instead-of-Ser.patch
>
>
> This is done to remove the manual call to {{super}} which is done in
> {{GenericServlet}} instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10446) Override ‘GenericServlet::init’ instead of ‘Servlet::init’
Mathieu Lirzin created OFBIZ-10446:
--
Summary: Override ‘GenericServlet::init’ instead of ‘Servlet::init’
Key: OFBIZ-10446
URL: https://issues.apache.org/jira/browse/OFBIZ-10446
Project: OFBiz
Issue Type: Improvement
Components: base
Reporter: Mathieu Lirzin
Fix For: Upcoming Branch
This is done to remove the manual call to {{super}} which is done in
{{GenericServlet}} instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10445) Inline ‘ControlServlet::getRequestHandler’ method
[
https://issues.apache.org/jira/browse/OFBIZ-10445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10445:
---
Attachment:
OFBIZ-10445-Improved-Inline-ControlServlet-getRequestHandler-met.patch
> Inline ‘ControlServlet::getRequestHandler’ method
> -
>
> Key: OFBIZ-10445
> URL: https://issues.apache.org/jira/browse/OFBIZ-10445
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10445-Improved-Inline-ControlServlet-getRequestHandler-met.patch
>
>
> There was only two local callers of this trivial method, so remove it.Rename
> {{requestHandler}} in {{doGet}} local variable to {{handler}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10443) Remove org.apache.tomcat.util.net.secure_protocol_version from json output
[ https://issues.apache.org/jira/browse/OFBIZ-10443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524898#comment-16524898 ] Jacques Le Roux commented on OFBIZ-10443: - +1 to commit > Remove org.apache.tomcat.util.net.secure_protocol_version from json output > -- > > Key: OFBIZ-10443 > URL: https://issues.apache.org/jira/browse/OFBIZ-10443 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Attachments: OFBIZ-10443-CommonEvents-20180626.patch > > > Visit [https://localhost:8443/example/control/createExampleAjax,] in the > output json, the > org.apache.tomcat.util.net.secure_protocol_version is unnecessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524843#comment-16524843
]
Mathieu Lirzin commented on OFBIZ-10438:
[~shi.jinghai] I agree :-)
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments:
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch,
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch,
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch,
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch,
> OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524833#comment-16524833
]
Shi Jinghai commented on OFBIZ-10438:
-
Thank you Nicolas!
If Mathieu agree, let's stop here, I'm very happy what Mathieu has done. Great.
Let's discuss whether this improvement is acceptable, whether it would be
backported to stable branches in devML.
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments:
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch,
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch,
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch,
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch,
> OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524831#comment-16524831
]
Mathieu Lirzin commented on OFBIZ-10438:
{quote}And method="" and method="all" are OK. I insist to support method="" as
according to the xsd, it's allowed and should be parsed as method="all"
{quote}
Would it be OK with you to only support {{method=""}}?
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments:
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch,
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch,
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch,
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch,
> OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
