[jira] [Updated] (OFBIZ-10245) File transfer management with communicationEvent and new contactMech FTP_ADDRESS
[
https://issues.apache.org/jira/browse/OFBIZ-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-10245:
-
Attachment: (was: OFBIZ-10245.patch)
> File transfer management with communicationEvent and new contactMech
> FTP_ADDRESS
>
>
> Key: OFBIZ-10245
> URL: https://issues.apache.org/jira/browse/OFBIZ-10245
> Project: OFBiz
> Issue Type: Improvement
> Components: content, party
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10245-update-fileds.patch, OFBIZ-10245.patch
>
>
> This Jira introduce a new way to manage file transfer in OFBiz.
> Inspired by mailing communication event management, a new
> communicationEventTypeId is created ('FILE_TRANSFER_COMM').
> Such commEvent with classics :
> partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job
> (like sendEmailDated), to send associated contents to a configured
> FTP/SFTP/FTPS server. If failure happens, it is catched and stored in
> communicationEvent, waiting for a new try.
> For this purpose :
> # A new contactMechTypeId is introduced (FtpAddress), with its corresponding
> table. This contactMech store needed information for basic user/password
> authentication (server url and protocol, port, username, password, etc.)
> # A new service sendFileTransferDated (wip) that will look for pending file
> transfer and call following service.
> # A new service sendCommEventAsFtp that take a selected commEvent, check its
> structure and manage its status after trying the associated content file
> transfers
> # A new service sendContentToFtp, that take a content and transfer it to a
> given FtpAddress
> # A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural
> content file transfer, creating children communicationEvent to follow each
> content transfer separately (only for several content transfers).
> # A new Interface FtpClientInterface, with the 3 implementations of FTP,
> FTPS (To be Done), SFTP clients to manage Ftp connection and transfer
> # A new property file to enable and manage redirection for testing purpose
> With this implementation, creating a communicationEvent, with a FtpAddress
> contactMechIdTo, and sendFileTransferDated job planned :
> * The file is transfered to the ftp : communication event status set to
> COM_COMPLETE
> * Error occured : communication event status set to COM_BOUNCED with error
> message on communicationEvent note
> The POC is working nicely for our customer, i adapted and tested it on trunk
> here :
> https://labs.nereide.fr/10031/Communautaire/compare/trunk...SendCommEventToFtp
> (some more job to be done, but in a working state)
> I can provide the current patch on demand but i will propose more polished
> work in some days.
> Looking forward reading you !
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10245) File transfer management with communicationEvent and new contactMech FTP_ADDRESS
[
https://issues.apache.org/jira/browse/OFBIZ-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-10245:
-
Attachment: OFBIZ-10245-update-fileds.patch
> File transfer management with communicationEvent and new contactMech
> FTP_ADDRESS
>
>
> Key: OFBIZ-10245
> URL: https://issues.apache.org/jira/browse/OFBIZ-10245
> Project: OFBiz
> Issue Type: Improvement
> Components: content, party
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10245-update-fileds.patch, OFBIZ-10245.patch
>
>
> This Jira introduce a new way to manage file transfer in OFBiz.
> Inspired by mailing communication event management, a new
> communicationEventTypeId is created ('FILE_TRANSFER_COMM').
> Such commEvent with classics :
> partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job
> (like sendEmailDated), to send associated contents to a configured
> FTP/SFTP/FTPS server. If failure happens, it is catched and stored in
> communicationEvent, waiting for a new try.
> For this purpose :
> # A new contactMechTypeId is introduced (FtpAddress), with its corresponding
> table. This contactMech store needed information for basic user/password
> authentication (server url and protocol, port, username, password, etc.)
> # A new service sendFileTransferDated (wip) that will look for pending file
> transfer and call following service.
> # A new service sendCommEventAsFtp that take a selected commEvent, check its
> structure and manage its status after trying the associated content file
> transfers
> # A new service sendContentToFtp, that take a content and transfer it to a
> given FtpAddress
> # A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural
> content file transfer, creating children communicationEvent to follow each
> content transfer separately (only for several content transfers).
> # A new Interface FtpClientInterface, with the 3 implementations of FTP,
> FTPS (To be Done), SFTP clients to manage Ftp connection and transfer
> # A new property file to enable and manage redirection for testing purpose
> With this implementation, creating a communicationEvent, with a FtpAddress
> contactMechIdTo, and sendFileTransferDated job planned :
> * The file is transfered to the ftp : communication event status set to
> COM_COMPLETE
> * Error occured : communication event status set to COM_BOUNCED with error
> message on communicationEvent note
> The POC is working nicely for our customer, i adapted and tested it on trunk
> here :
> https://labs.nereide.fr/10031/Communautaire/compare/trunk...SendCommEventToFtp
> (some more job to be done, but in a working state)
> I can provide the current patch on demand but i will propose more polished
> work in some days.
> Looking forward reading you !
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10245) File transfer management with communicationEvent and new contactMech FTP_ADDRESS
[
https://issues.apache.org/jira/browse/OFBIZ-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544065#comment-16544065
]
Deepak Dixit commented on OFBIZ-10245:
--
Attached patch with following changes
- Renamed password field to ftpPassword
- Rename path field to filePath
Also updated all occurrences of these words.
> File transfer management with communicationEvent and new contactMech
> FTP_ADDRESS
>
>
> Key: OFBIZ-10245
> URL: https://issues.apache.org/jira/browse/OFBIZ-10245
> Project: OFBiz
> Issue Type: Improvement
> Components: content, party
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10245-update-fileds.patch, OFBIZ-10245.patch
>
>
> This Jira introduce a new way to manage file transfer in OFBiz.
> Inspired by mailing communication event management, a new
> communicationEventTypeId is created ('FILE_TRANSFER_COMM').
> Such commEvent with classics :
> partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job
> (like sendEmailDated), to send associated contents to a configured
> FTP/SFTP/FTPS server. If failure happens, it is catched and stored in
> communicationEvent, waiting for a new try.
> For this purpose :
> # A new contactMechTypeId is introduced (FtpAddress), with its corresponding
> table. This contactMech store needed information for basic user/password
> authentication (server url and protocol, port, username, password, etc.)
> # A new service sendFileTransferDated (wip) that will look for pending file
> transfer and call following service.
> # A new service sendCommEventAsFtp that take a selected commEvent, check its
> structure and manage its status after trying the associated content file
> transfers
> # A new service sendContentToFtp, that take a content and transfer it to a
> given FtpAddress
> # A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural
> content file transfer, creating children communicationEvent to follow each
> content transfer separately (only for several content transfers).
> # A new Interface FtpClientInterface, with the 3 implementations of FTP,
> FTPS (To be Done), SFTP clients to manage Ftp connection and transfer
> # A new property file to enable and manage redirection for testing purpose
> With this implementation, creating a communicationEvent, with a FtpAddress
> contactMechIdTo, and sendFileTransferDated job planned :
> * The file is transfered to the ftp : communication event status set to
> COM_COMPLETE
> * Error occured : communication event status set to COM_BOUNCED with error
> message on communicationEvent note
> The POC is working nicely for our customer, i adapted and tested it on trunk
> here :
> https://labs.nereide.fr/10031/Communautaire/compare/trunk...SendCommEventToFtp
> (some more job to be done, but in a working state)
> I can provide the current patch on demand but i will propose more polished
> work in some days.
> Looking forward reading you !
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10245) File transfer management with communicationEvent and new contactMech FTP_ADDRESS
[
https://issues.apache.org/jira/browse/OFBIZ-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-10245:
-
Attachment: OFBIZ-10245.patch
> File transfer management with communicationEvent and new contactMech
> FTP_ADDRESS
>
>
> Key: OFBIZ-10245
> URL: https://issues.apache.org/jira/browse/OFBIZ-10245
> Project: OFBiz
> Issue Type: Improvement
> Components: content, party
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10245.patch, OFBIZ-10245.patch
>
>
> This Jira introduce a new way to manage file transfer in OFBiz.
> Inspired by mailing communication event management, a new
> communicationEventTypeId is created ('FILE_TRANSFER_COMM').
> Such commEvent with classics :
> partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job
> (like sendEmailDated), to send associated contents to a configured
> FTP/SFTP/FTPS server. If failure happens, it is catched and stored in
> communicationEvent, waiting for a new try.
> For this purpose :
> # A new contactMechTypeId is introduced (FtpAddress), with its corresponding
> table. This contactMech store needed information for basic user/password
> authentication (server url and protocol, port, username, password, etc.)
> # A new service sendFileTransferDated (wip) that will look for pending file
> transfer and call following service.
> # A new service sendCommEventAsFtp that take a selected commEvent, check its
> structure and manage its status after trying the associated content file
> transfers
> # A new service sendContentToFtp, that take a content and transfer it to a
> given FtpAddress
> # A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural
> content file transfer, creating children communicationEvent to follow each
> content transfer separately (only for several content transfers).
> # A new Interface FtpClientInterface, with the 3 implementations of FTP,
> FTPS (To be Done), SFTP clients to manage Ftp connection and transfer
> # A new property file to enable and manage redirection for testing purpose
> With this implementation, creating a communicationEvent, with a FtpAddress
> contactMechIdTo, and sendFileTransferDated job planned :
> * The file is transfered to the ftp : communication event status set to
> COM_COMPLETE
> * Error occured : communication event status set to COM_BOUNCED with error
> message on communicationEvent note
> The POC is working nicely for our customer, i adapted and tested it on trunk
> here :
> https://labs.nereide.fr/10031/Communautaire/compare/trunk...SendCommEventToFtp
> (some more job to be done, but in a working state)
> I can provide the current patch on demand but i will propose more polished
> work in some days.
> Looking forward reading you !
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10396) All party contact mech should be deleted before creating new one
[ https://issues.apache.org/jira/browse/OFBIZ-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544027#comment-16544027 ] Suraj Khurana commented on OFBIZ-10396: --- Thanks everyone for your inputs. Committed it under rev #1835871. As these are service level functional changes, we can back port to older to release. > All party contact mech should be deleted before creating new one > > > Key: OFBIZ-10396 > URL: https://issues.apache.org/jira/browse/OFBIZ-10396 > Project: OFBiz > Issue Type: Improvement >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10396.patch > > > Currently, everywhere in code base, before creating new party contact mech > record, we use > deletePartyContactMechPurposeIfExists service to delete old records. But, > problem is > All previous records should also gets deleted before creating new party > contact mech purpose for a specific purpose type. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10396) All party contact mech should be deleted before creating new one
[ https://issues.apache.org/jira/browse/OFBIZ-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544027#comment-16544027 ] Suraj Khurana edited comment on OFBIZ-10396 at 7/14/18 5:38 AM: Thanks everyone for your inputs. Committed it under rev #1835871. As these are service level functional changes, we can back port to older releases. was (Author: suraj.khurana): Thanks everyone for your inputs. Committed it under rev #1835871. As these are service level functional changes, we can back port to older to release. > All party contact mech should be deleted before creating new one > > > Key: OFBIZ-10396 > URL: https://issues.apache.org/jira/browse/OFBIZ-10396 > Project: OFBiz > Issue Type: Improvement >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10396.patch > > > Currently, everywhere in code base, before creating new party contact mech > record, we use > deletePartyContactMechPurposeIfExists service to delete old records. But, > problem is > All previous records should also gets deleted before creating new party > contact mech purpose for a specific purpose type. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-10245) File transfer management with communicationEvent and new contactMech FTP_ADDRESS
[
https://issues.apache.org/jira/browse/OFBIZ-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit reopened OFBIZ-10245:
--
Found following reserved word related warning on the console for FtpAddress
entity.
{code}
|W| [FieldNameRW] Column name PASSWORD of entity FtpAddress is a reserved word.
2018-07-14 10:57:36,734 |delegator-startup-1 |GenericDelegator
|W| [FieldNameRW] Column name PATH of entity FtpAddress is a reserved word.
{code}
I prefer to reopen instead creating new ticket, as it's closed recently
> File transfer management with communicationEvent and new contactMech
> FTP_ADDRESS
>
>
> Key: OFBIZ-10245
> URL: https://issues.apache.org/jira/browse/OFBIZ-10245
> Project: OFBiz
> Issue Type: Improvement
> Components: content, party
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10245.patch
>
>
> This Jira introduce a new way to manage file transfer in OFBiz.
> Inspired by mailing communication event management, a new
> communicationEventTypeId is created ('FILE_TRANSFER_COMM').
> Such commEvent with classics :
> partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job
> (like sendEmailDated), to send associated contents to a configured
> FTP/SFTP/FTPS server. If failure happens, it is catched and stored in
> communicationEvent, waiting for a new try.
> For this purpose :
> # A new contactMechTypeId is introduced (FtpAddress), with its corresponding
> table. This contactMech store needed information for basic user/password
> authentication (server url and protocol, port, username, password, etc.)
> # A new service sendFileTransferDated (wip) that will look for pending file
> transfer and call following service.
> # A new service sendCommEventAsFtp that take a selected commEvent, check its
> structure and manage its status after trying the associated content file
> transfers
> # A new service sendContentToFtp, that take a content and transfer it to a
> given FtpAddress
> # A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural
> content file transfer, creating children communicationEvent to follow each
> content transfer separately (only for several content transfers).
> # A new Interface FtpClientInterface, with the 3 implementations of FTP,
> FTPS (To be Done), SFTP clients to manage Ftp connection and transfer
> # A new property file to enable and manage redirection for testing purpose
> With this implementation, creating a communicationEvent, with a FtpAddress
> contactMechIdTo, and sendFileTransferDated job planned :
> * The file is transfered to the ftp : communication event status set to
> COM_COMPLETE
> * Error occured : communication event status set to COM_BOUNCED with error
> message on communicationEvent note
> The POC is working nicely for our customer, i adapted and tested it on trunk
> here :
> https://labs.nereide.fr/10031/Communautaire/compare/trunk...SendCommEventToFtp
> (some more job to be done, but in a working state)
> I can provide the current patch on demand but i will propose more polished
> work in some days.
> Looking forward reading you !
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10245) File transfer management with communicationEvent and new contactMech FTP_ADDRESS
[
https://issues.apache.org/jira/browse/OFBIZ-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-10245:
-
Fix Version/s: Upcoming Branch
> File transfer management with communicationEvent and new contactMech
> FTP_ADDRESS
>
>
> Key: OFBIZ-10245
> URL: https://issues.apache.org/jira/browse/OFBIZ-10245
> Project: OFBiz
> Issue Type: Improvement
> Components: content, party
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10245.patch
>
>
> This Jira introduce a new way to manage file transfer in OFBiz.
> Inspired by mailing communication event management, a new
> communicationEventTypeId is created ('FILE_TRANSFER_COMM').
> Such commEvent with classics :
> partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job
> (like sendEmailDated), to send associated contents to a configured
> FTP/SFTP/FTPS server. If failure happens, it is catched and stored in
> communicationEvent, waiting for a new try.
> For this purpose :
> # A new contactMechTypeId is introduced (FtpAddress), with its corresponding
> table. This contactMech store needed information for basic user/password
> authentication (server url and protocol, port, username, password, etc.)
> # A new service sendFileTransferDated (wip) that will look for pending file
> transfer and call following service.
> # A new service sendCommEventAsFtp that take a selected commEvent, check its
> structure and manage its status after trying the associated content file
> transfers
> # A new service sendContentToFtp, that take a content and transfer it to a
> given FtpAddress
> # A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural
> content file transfer, creating children communicationEvent to follow each
> content transfer separately (only for several content transfers).
> # A new Interface FtpClientInterface, with the 3 implementations of FTP,
> FTPS (To be Done), SFTP clients to manage Ftp connection and transfer
> # A new property file to enable and manage redirection for testing purpose
> With this implementation, creating a communicationEvent, with a FtpAddress
> contactMechIdTo, and sendFileTransferDated job planned :
> * The file is transfered to the ftp : communication event status set to
> COM_COMPLETE
> * Error occured : communication event status set to COM_BOUNCED with error
> message on communicationEvent note
> The POC is working nicely for our customer, i adapted and tested it on trunk
> here :
> https://labs.nereide.fr/10031/Communautaire/compare/trunk...SendCommEventToFtp
> (some more job to be done, but in a working state)
> I can provide the current patch on demand but i will propose more polished
> work in some days.
> Looking forward reading you !
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10391) Make accounting entry configurable
[ https://issues.apache.org/jira/browse/OFBIZ-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544020#comment-16544020 ] Deepak Dixit commented on OFBIZ-10391: -- Found console warning related to Invalid content was found starting with element 'field', Fixed at r#1835870. This was due to an invalid position on enableAccounting field in entity definition. > Make accounting entry configurable > -- > > Key: OFBIZ-10391 > URL: https://issues.apache.org/jira/browse/OFBIZ-10391 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aman Agrawal >Assignee: Arun Patidar >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10391.patch > > > In current flow, if we want to disable the accounting then we need to disable > the set of seca's. We don't have any configurable setting to disable > accounting. > We can manage this by adding a new field 'enableAccounting' in the > 'PartyAcctgPreference' entity. Accounting transaction entries will be > entertained accordingly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9514) Use well-formed IETF BCP 47 language tag for setVariant method.
[ https://issues.apache.org/jira/browse/OFBIZ-9514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradhan Yash Sharma closed OFBIZ-9514. -- Resolution: Later Closing this ticket for now as Locale for a specific region is not required. > Use well-formed IETF BCP 47 language tag for setVariant method. > - > > Key: OFBIZ-9514 > URL: https://issues.apache.org/jira/browse/OFBIZ-9514 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Reporter: Pradhan Yash Sharma >Priority: Major > > For Factory Method and LocaleBuilder class to work, we need to pass a > well-formed variant in setVariant method so that it can be transformed int > IETF BCP 47 language tag without losing information. > To do so we need to create Locale objects through rule set. Please reference > https://docs.oracle.com/javase/7/docs/api/java/util/Locale.Builder.html for > more details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9839) Using try-with-resources with JDBC objects
[ https://issues.apache.org/jira/browse/OFBIZ-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544012#comment-16544012 ] Pradhan Yash Sharma commented on OFBIZ-9839: Thank you, Jacques, for refactoring of other 4 methods I will create a Jira for the same. > Using try-with-resources with JDBC objects > -- > > Key: OFBIZ-9839 > URL: https://issues.apache.org/jira/browse/OFBIZ-9839 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-9839.patch, OFBIZ-9839.patch > > > Proposal to use try with resources for SQL objects like ResultSet and other > objects. SQL classes have AutoCloseable interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-7598. Resolution: Fixed This has been committed under rev #1835869 Thanks Jacques and Dennis for reporting this issue. > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-9827) Components loading twice while starting OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradhan Yash Sharma closed OFBIZ-9827. -- Resolution: Not A Problem The code is working fine hence closing this ticket. > Components loading twice while starting OFBiz > - > > Key: OFBIZ-9827 > URL: https://issues.apache.org/jira/browse/OFBIZ-9827 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12, > Release Branch 16.11 >Reporter: Pradhan Yash Sharma >Assignee: Pradhan Yash Sharma >Priority: Major > Attachments: logs.tar.gz > > > Components loading multiple times while OFBiz starts. > While CatalinaContainer loads webapps it creates the future task, which loads > more than once (depends on numbers of System cores and speed). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9827) Components loading twice while starting OFBiz
[ https://issues.apache.org/jira/browse/OFBIZ-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544005#comment-16544005 ] Pradhan Yash Sharma commented on OFBIZ-9827: Hello Jacques, Yes, I am closing this ticket. > Components loading twice while starting OFBiz > - > > Key: OFBIZ-9827 > URL: https://issues.apache.org/jira/browse/OFBIZ-9827 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12, > Release Branch 16.11 >Reporter: Pradhan Yash Sharma >Assignee: Pradhan Yash Sharma >Priority: Major > Attachments: logs.tar.gz > > > Components loading multiple times while OFBiz starts. > While CatalinaContainer loads webapps it creates the future task, which loads > more than once (depends on numbers of System cores and speed). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty
[ https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543620#comment-16543620 ] Jacques Le Roux commented on OFBIZ-7598: Hi Suraj, Will you commit? > Empty header row should not render if list to render in file is empty > - > > Key: OFBIZ-7598 > URL: https://issues.apache.org/jira/browse/OFBIZ-7598 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: Image 002.png, OFBIZ-7598.patch, OFBIZ-7598.patch, > OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png > > > If list inside form doesn't contain data, then header row should not render > from better UI perspective and proper message should be shown to user. > Please refer screenshot for details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-9164) Refactor ContentWorkerInterface methods signatures
[ https://issues.apache.org/jira/browse/OFBIZ-9164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-9164: Thanks Dennis, I'll have a look ASAP > Refactor ContentWorkerInterface methods signatures > -- > > Key: OFBIZ-9164 > URL: https://issues.apache.org/jira/browse/OFBIZ-9164 > Project: OFBiz > Issue Type: Sub-task > Components: content, framework, lucene, order, party, product, > workeffort >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01 > > Attachments: OFBIZ-9164 DataResourceWorker.java.patch, > OFBIZ-9164.patch > > > While working on OFBIZ-6919 which was built on R13.07 I stumbled upon an > issue due to r1652852 where Adrian improved the cacheKey in > FormFactory.getFormFromLocation() by adding a delegator reference (Tenants). > Actually I'm not even sure it was done at r1652852 because Adrian did not > maintain the FormFactory svn history. > Anyway, to make a long story short I had to introduce a DispatchContext > parameter when calling FormFactory.readFormDocument() when the code from > R13.07 only passed a null. > This had an impact in the hierarchy tree because > FormFactory.readFormDocument() was called in DataResourceWorker class, where > the new code was called from renderDataResourceAsText(). So I instead of only > passing a Delegator I decided to pass only a LocalDispatcher parameter in > renderDataResourceAsText(), since we can get the Delegator from the > LocalDispatcher. Doing so it had an impact on the renderDataResourceAsText > hierarchy tree ending in DataResourceWorkerInterface and all related. > I finally decided to apply the same ["Change Method Signature" refactoring > pattern|http://refactoring.com/catalog/addParameter.html] to all cases > related to ContentWorkerInterface. No need to pass a delegator when you have > LocalDispatcher! > Here I attach a patch for review, I'll commit in few days -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9164) Refactor ContentWorkerInterface methods signatures
[
https://issues.apache.org/jira/browse/OFBIZ-9164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542996#comment-16542996
]
Dennis Balkir commented on OFBIZ-9164:
--
Hi [~jacques.le.roux],
I found a mistake, which results in an Nullpointer.
If you go here: https://demo-trunk.ofbiz.apache.org/catalog/control/main then
open the lookup on the left for category id, click the first category (20111)
and then click on search, you will be prompted with this:
{{java.lang.IllegalArgumentException: Error running script at location
[component://product/groovyScripts/catalog/find/KeywordSearch.groovy]:
java.lang.NullPointerException}}
This is the result of the changes you made here, to be specific in
{{CategoryContentWrapper}} and {{ContentWorker}}.
The following code is the problem:
{code:java}
getProductCategoryContentAsText(null, productCategory, prodCatContentTypeId,
locale, mimeTypeId, delegator, dispatcher, outWriter, false);}}
{code}
This gives {{null}} as the value for the dispatcher, which is then used here
inside of {{getProductCategoryContentAsText}}:
{code:java}
ContentWorker.renderContentAsText(dispatcher,
categoryContent.getString("contentId"), outWriter, inContext, locale,
mimeTypeId, null, null, cache);
{code}
The problem is, that the method {{renderContentAsText}} as a result of your
changes uses the dispatcher to get the delegator:
{code:java}
public static void renderContentAsText(LocalDispatcher dispatcher, String
contentId, Appendable out, Map templateContext,
Locale locale, String mimeTypeId, String partyId, String
roleTypeId, boolean cache) throws GeneralException, IOException {
Delegator delegator = dispatcher.getDelegator();
GenericValue content = ContentWorker.findContentForRendering(delegator,
contentId, locale, partyId, roleTypeId, cache);
ContentWorker.renderContentAsText(dispatcher, content, out,
templateContext, locale, mimeTypeId, cache, null);
}
{code}
Because the dispatcher is a given {{null}} value at this point, this results in
a nullpointer.
> Refactor ContentWorkerInterface methods signatures
> --
>
> Key: OFBIZ-9164
> URL: https://issues.apache.org/jira/browse/OFBIZ-9164
> Project: OFBiz
> Issue Type: Sub-task
> Components: content, framework, lucene, order, party, product,
> workeffort
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9164 DataResourceWorker.java.patch,
> OFBIZ-9164.patch
>
>
> While working on OFBIZ-6919 which was built on R13.07 I stumbled upon an
> issue due to r1652852 where Adrian improved the cacheKey in
> FormFactory.getFormFromLocation() by adding a delegator reference (Tenants).
> Actually I'm not even sure it was done at r1652852 because Adrian did not
> maintain the FormFactory svn history.
> Anyway, to make a long story short I had to introduce a DispatchContext
> parameter when calling FormFactory.readFormDocument() when the code from
> R13.07 only passed a null.
> This had an impact in the hierarchy tree because
> FormFactory.readFormDocument() was called in DataResourceWorker class, where
> the new code was called from renderDataResourceAsText(). So I instead of only
> passing a Delegator I decided to pass only a LocalDispatcher parameter in
> renderDataResourceAsText(), since we can get the Delegator from the
> LocalDispatcher. Doing so it had an impact on the renderDataResourceAsText
> hierarchy tree ending in DataResourceWorkerInterface and all related.
> I finally decided to apply the same ["Change Method Signature" refactoring
> pattern|http://refactoring.com/catalog/addParameter.html] to all cases
> related to ContentWorkerInterface. No need to pass a delegator when you have
> LocalDispatcher!
> Here I attach a patch for review, I'll commit in few days
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’
[
https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542832#comment-16542832
]
Mathieu Lirzin commented on OFBIZ-10450:
I have updated
[^OFBIZ-10450_Extract-verification-of-certificates-in-RequestHandl.patch] to
use a line max length of 120 characters, and to add some description on top of
each tests.
> Extract verification of certificates in ‘RequestHandler’
>
>
> Key: OFBIZ-10450
> URL: https://issues.apache.org/jira/browse/OFBIZ-10450
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10450_Extract-verification-of-certificates-in-RequestHandl.patch
>
>
> No functional change. Reduce the size of {{RequestHandler::doRequest}}
> method. Add some tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’
[
https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10450:
---
Attachment:
OFBIZ-10450_Extract-verification-of-certificates-in-RequestHandl.patch
> Extract verification of certificates in ‘RequestHandler’
>
>
> Key: OFBIZ-10450
> URL: https://issues.apache.org/jira/browse/OFBIZ-10450
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10450_Extract-verification-of-certificates-in-RequestHandl.patch
>
>
> No functional change. Reduce the size of {{RequestHandler::doRequest}}
> method. Add some tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’
[
https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10450:
---
Attachment: (was:
OFBIZ-10450_Improved-Extract-verification-of-certificates-in-Req.patch)
> Extract verification of certificates in ‘RequestHandler’
>
>
> Key: OFBIZ-10450
> URL: https://issues.apache.org/jira/browse/OFBIZ-10450
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10450_Extract-verification-of-certificates-in-RequestHandl.patch
>
>
> No functional change. Reduce the size of {{RequestHandler::doRequest}}
> method. Add some tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10476) Fix / Remove Compdoc?
Dennis Balkir created OFBIZ-10476: - Summary: Fix / Remove Compdoc? Key: OFBIZ-10476 URL: https://issues.apache.org/jira/browse/OFBIZ-10476 Project: OFBiz Issue Type: Bug Components: content Reporter: Dennis Balkir While creating a theme and looking for not correctly styled elements I came across "some" not functional links and buttons in Compdoc. This module seems not to be finished or working properly, because most of the times, the buttons inside the appbar produce errors or just empty pages. Even when searching for existing elements and then clicking on them to examine or edit them will mostly create an error (example: go to compdoc, search for template child, click edit on some random found element -> error). Sometimes the menu which is included inside the appbar, mostly the menu called "tree", need the contentId for the buttons to work. Including this menu while creating a new entry will result in every button not working and throwing an error, except the edit button, which will produce a completely empty page. Those things appear all over the module, trying some button or clicking some link resulted in an error screen more than it resulted in something actually working. This should either be fixed or removed, if this doesn't has a real purpose at all. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10475) Missing Import in CmsEditAddPrep.groovy
[
https://issues.apache.org/jira/browse/OFBIZ-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Balkir updated OFBIZ-10475:
--
Attachment:
OFBIZ-10475_applications.content.groovyScripts.cms.CmsEditAddPrep.patch
> Missing Import in CmsEditAddPrep.groovy
> ---
>
> Key: OFBIZ-10475
> URL: https://issues.apache.org/jira/browse/OFBIZ-10475
> Project: OFBiz
> Issue Type: Bug
> Components: content
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments:
> OFBIZ-10475_applications.content.groovyScripts.cms.CmsEditAddPrep.patch
>
>
> When going to Content > CMS and then clicking one of the items that are shown
> in the table, most of the times an error will show up.
> This is because, there is an missing import of {{UtilFormatOut}} in
> {{CmsEditAddPrep.groovy}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10475) Missing Import in CmsEditAddPrep.groovy
[
https://issues.apache.org/jira/browse/OFBIZ-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542766#comment-16542766
]
Dennis Balkir commented on OFBIZ-10475:
---
I added the import and provided a patch for it. This seems to fix the problem.
> Missing Import in CmsEditAddPrep.groovy
> ---
>
> Key: OFBIZ-10475
> URL: https://issues.apache.org/jira/browse/OFBIZ-10475
> Project: OFBiz
> Issue Type: Bug
> Components: content
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments:
> OFBIZ-10475_applications.content.groovyScripts.cms.CmsEditAddPrep.patch
>
>
> When going to Content > CMS and then clicking one of the items that are shown
> in the table, most of the times an error will show up.
> This is because, there is an missing import of {{UtilFormatOut}} in
> {{CmsEditAddPrep.groovy}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10474) Remove duplicated code when running login/logout events
[
https://issues.apache.org/jira/browse/OFBIZ-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10474:
---
Attachment: OFBIZ-10474-duplicated-code-when-running-events.patch
> Remove duplicated code when running login/logout events
> ---
>
> Key: OFBIZ-10474
> URL: https://issues.apache.org/jira/browse/OFBIZ-10474
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10474-duplicated-code-when-running-events.patch
>
>
> In an effort of refactoring the {{RequestHandler}} class. I have factored
> the code from {{runAfterLoginEvents}} and {{runBeforeLogoutEvents}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10474) Remove duplicated code when running login/logout events
Mathieu Lirzin created OFBIZ-10474:
--
Summary: Remove duplicated code when running login/logout events
Key: OFBIZ-10474
URL: https://issues.apache.org/jira/browse/OFBIZ-10474
Project: OFBiz
Issue Type: Improvement
Reporter: Mathieu Lirzin
Fix For: Upcoming Branch
In an effort of refactoring the {{RequestHandler}} class. I have factored the
code from {{runAfterLoginEvents}} and {{runBeforeLogoutEvents}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10475) Missing Import in CmsEditAddPrep.groovy
Dennis Balkir created OFBIZ-10475:
-
Summary: Missing Import in CmsEditAddPrep.groovy
Key: OFBIZ-10475
URL: https://issues.apache.org/jira/browse/OFBIZ-10475
Project: OFBiz
Issue Type: Bug
Components: content
Reporter: Dennis Balkir
When going to Content > CMS and then clicking one of the items that are shown
in the table, most of the times an error will show up.
This is because, there is an missing import of {{UtilFormatOut}} in
{{CmsEditAddPrep.groovy}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-2364) Competitors & Partners - Sales Force Automation component
[ https://issues.apache.org/jira/browse/OFBIZ-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542732#comment-16542732 ] Jacques Le Roux commented on OFBIZ-2364: Hi Dennis, I don't want to answer for Vikas, but it seems more a dead feature to me. > Competitors & Partners - Sales Force Automation component > - > > Key: OFBIZ-2364 > URL: https://issues.apache.org/jira/browse/OFBIZ-2364 > Project: OFBiz > Issue Type: New Feature > Components: marketing >Affects Versions: Trunk > Environment: Mac OS X >Reporter: Vikas Mayur >Priority: Minor > Attachments: SFA Competitors & Partners.patch > > > Competitors and Partners will be parties (generally PartyGroup) and are > related to other items including Accounts, Opportunities, and so on. > The screens for Competitor would include: Competitor Home, Accounts, > Opportunities. > The screens for Partner would include: Partner Home, Accounts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-2364) Competitors & Partners - Sales Force Automation component
[ https://issues.apache.org/jira/browse/OFBIZ-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=12754609#comment-12754609 ] Jacques Le Roux edited comment on OFBIZ-2364 at 7/13/18 8:56 AM: - Hi, Is this work related to https://cwiki.apache.org/confluence/download/attachments/6553964/IfCrmPlanEstimate.pdf?version=1=1204645789000=v2 For instance I don't see SalesOpportunityCompetitor entity and nothing about ths screens suggested in the document : * The screens for Competitor would include: Competitor Home, Accounts, Opportunities. * The screens for Partner would include: Partner Home, Accounts. On the other hand,I agree that there is not much about partner and competitor in this document as, at this time, this part was considered as a lower priority. So I think this work is of value even if it's not totally related with what was planned in this document. Also please use permission services in CompetitorPartnerServices.xml (with relevant permission group data to be created). That's all for the moment, thanks! was (Author: jacques.le.roux): Hi, Is this work related to http://docs.ofbiz.org/download/attachments/4008/IfCrmPlanEstimate.pdf?version=1 ? For instance I don't see SalesOpportunityCompetitor entity and nothing about ths screens suggested in the document : * The screens for Competitor would include: Competitor Home, Accounts, Opportunities. * The screens for Partner would include: Partner Home, Accounts. On the other hand,I agree that there is not much about partner and competitor in this document as, at this time, this part was considered as a lower priority. So I think this work is of value even if it's not totally related with what was planned in this document. Also please use permission services in CompetitorPartnerServices.xml (with relevant permission group data to be created). That's all for the moment, thanks! > Competitors & Partners - Sales Force Automation component > - > > Key: OFBIZ-2364 > URL: https://issues.apache.org/jira/browse/OFBIZ-2364 > Project: OFBiz > Issue Type: New Feature > Components: marketing >Affects Versions: Trunk > Environment: Mac OS X >Reporter: Vikas Mayur >Priority: Minor > Attachments: SFA Competitors & Partners.patch > > > Competitors and Partners will be parties (generally PartyGroup) and are > related to other items including Accounts, Opportunities, and so on. > The screens for Competitor would include: Competitor Home, Accounts, > Opportunities. > The screens for Partner would include: Partner Home, Accounts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-2364) Competitors & Partners - Sales Force Automation component
[ https://issues.apache.org/jira/browse/OFBIZ-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542707#comment-16542707 ] Dennis Balkir commented on OFBIZ-2364: -- Hi [~jacques.le.roux], since you were the last person commented on this, I will address this to you :) Do you, or anyone else, knows the current status of this? I just noticed, that the in the SFAAppbar there is a menu-point called "Competitors & Partners", which is labeled disabled and has no proper link in it. Is this still in development, or is this a dead feature? > Competitors & Partners - Sales Force Automation component > - > > Key: OFBIZ-2364 > URL: https://issues.apache.org/jira/browse/OFBIZ-2364 > Project: OFBiz > Issue Type: New Feature > Components: marketing >Affects Versions: Trunk > Environment: Mac OS X >Reporter: Vikas Mayur >Priority: Minor > Attachments: SFA Competitors & Partners.patch > > > Competitors and Partners will be parties (generally PartyGroup) and are > related to other items including Accounts, Opportunities, and so on. > The screens for Competitor would include: Competitor Home, Accounts, > Opportunities. > The screens for Partner would include: Partner Home, Accounts. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
