[jira] [Assigned] (OFBIZ-7709) Party Search doesn't consider Billing Address and Shipping Address checkbox in WebPos
[ https://issues.apache.org/jira/browse/OFBIZ-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-7709: Assignee: Suraj Khurana (was: Mridul Pathak) > Party Search doesn't consider Billing Address and Shipping Address checkbox > in WebPos > -- > > Key: OFBIZ-7709 > URL: https://issues.apache.org/jira/browse/OFBIZ-7709 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: Trunk >Reporter: Vishal Chhabria >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7709.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-7719) Not able to select Virtual Product in WebPos
[ https://issues.apache.org/jira/browse/OFBIZ-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-7719. > Not able to select Virtual Product in WebPos > > > Key: OFBIZ-7719 > URL: https://issues.apache.org/jira/browse/OFBIZ-7719 > Project: OFBiz > Issue Type: Bug > Components: webpos >Reporter: Vishal Chhabria >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7719.patch > > > Following JS error occurs on selecting virtual product in WebPos: > Uncaught TypeError: jQuery(...).update is not a function -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7719) Not able to select Virtual Product in WebPos
[ https://issues.apache.org/jira/browse/OFBIZ-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577061#comment-16577061 ] Suraj Khurana commented on OFBIZ-7719: -- This has been back-ported on release16.11 at rev #1837843. > Not able to select Virtual Product in WebPos > > > Key: OFBIZ-7719 > URL: https://issues.apache.org/jira/browse/OFBIZ-7719 > Project: OFBiz > Issue Type: Bug > Components: webpos >Reporter: Vishal Chhabria >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7719.patch > > > Following JS error occurs on selecting virtual product in WebPos: > Uncaught TypeError: jQuery(...).update is not a function -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10514) Refactoring ContactMechWorker.get[Entity]ContactMechValueMaps
[
https://issues.apache.org/jira/browse/OFBIZ-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576859#comment-16576859
]
Nicolas Malin commented on OFBIZ-10514:
---
Optimisation example on ContactMechWorker.getPartyContactMechValueMaps
[^OFBIZ-10514.patch]
I will continue to analyse if this introduce no regression and I continue on
others entities
> Refactoring ContactMechWorker.get[Entity]ContactMechValueMaps
> -
>
> Key: OFBIZ-10514
> URL: https://issues.apache.org/jira/browse/OFBIZ-10514
> Project: OFBiz
> Issue Type: Improvement
> Components: party
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-10514.patch
>
>
> ContactMechWorker.get[Entity]ContactMechValueMaps are old historic functions
> that resolve all contact mech context related to an Entity (Party, Facility,
> Order, WorkEffort).
> The problem that they create too many db call during their execution that
> decrease OFBiz performance when the contactMech history grow.
> On customer site I realized a new adaptation (oriented and not generic at
> all) and control the performance issue with a unit test :
> {code:java}
> public void testContactMechSearch() throws Exception {
> UtilTimer timer = new UtilTimer("test contactmech", true, true);
> timer.startTimer();
> List> cmwPostalAdress =
> ContactMechWorker.getPartyContactMechValueMaps(delegator, "10375", false,
> "POSTAL_ADDRESS");
> timer.timerString("PA cmw " + cmwPostalAdress.size());
> List> cmwTelecomNumber =
> ContactMechWorker.getPartyContactMechValueMaps(delegator, "10375", false,
> "TELECOM_NUMBER");
> timer.timerString("TN cmw " + cmwTelecomNumber.size());
> List> cmwEmail =
> ContactMechWorker.getPartyContactMechValueMaps(delegator, "10375", false,
> "EMAIL_ADDRESS");
> timer.timerString("E cmw " + cmwEmail.size());
> List> epwPostalAdress =
> CustomPartyWorker.getPartyContactMechValueMaps(delegator, "10375", false,
> "POSTAL_ADDRESS", null);
> timer.timerString("PA cpw " + epwPostalAdress.size());
> List> epwTelecomNumber =
> CustomPartyWorker.getPartyContactMechValueMaps(delegator, "10375", false,
> "TELECOM_NUMBER", null);
> timer.timerString("TN cpw " + epwTelecomNumber.size());
> List> epwEmail =
> CustomPartyWorker.getPartyContactMechValueMaps(delegator, "10375", false,
> "EMAIL_ADDRESS", null);
> timer.timerString("E cpw " + epwEmail.size());
> }
> {code}
> The partyId "10375" is linked with more tha 600 contactMechs on my local site
> db. And the test excecution give :
> {code:java}
> With ContactMechWorker
> [java] [[PA cmw 2- total:,since last(Begin):33.707]] - 'test
> contactmech'
> [java] [[TN cmw 2- total:,since last(PA cmw 2):33.837]] - 'test
> contactmech'
> [java] [[E cmw 1- total:1..,since last(TN cmw 2):33.115]] - 'test
> contactmech'
> With CustomPartyWorker
> [java] [[PA epw 2- total:...,since last(E cmw 1):0.53]] - 'test
> contactmech'
> [java] [[TN epw 2- total:...,since last(PA epw 2):0.588]] - 'test
> contactmech'
> [java] [[E epw 1- total:...,since last(TN epw 2):0.631]] - 'test
> contactmech'
> {code}
> total ~100s for ContactMechWorker and ~1.5s for CustomPartyWorker
> Difference come that CustomPartyWorker works on a view entity gathering the
> data and populating GenericValue with makeValue (using the data within the
> view) instead of creating new getRelated db access.
> I will implement this idea on generic context to improve these functions
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10514) Refactoring ContactMechWorker.get[Entity]ContactMechValueMaps
[
https://issues.apache.org/jira/browse/OFBIZ-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-10514:
--
Attachment: OFBIZ-10514.patch
> Refactoring ContactMechWorker.get[Entity]ContactMechValueMaps
> -
>
> Key: OFBIZ-10514
> URL: https://issues.apache.org/jira/browse/OFBIZ-10514
> Project: OFBiz
> Issue Type: Improvement
> Components: party
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-10514.patch
>
>
> ContactMechWorker.get[Entity]ContactMechValueMaps are old historic functions
> that resolve all contact mech context related to an Entity (Party, Facility,
> Order, WorkEffort).
> The problem that they create too many db call during their execution that
> decrease OFBiz performance when the contactMech history grow.
> On customer site I realized a new adaptation (oriented and not generic at
> all) and control the performance issue with a unit test :
> {code:java}
> public void testContactMechSearch() throws Exception {
> UtilTimer timer = new UtilTimer("test contactmech", true, true);
> timer.startTimer();
> List> cmwPostalAdress =
> ContactMechWorker.getPartyContactMechValueMaps(delegator, "10375", false,
> "POSTAL_ADDRESS");
> timer.timerString("PA cmw " + cmwPostalAdress.size());
> List> cmwTelecomNumber =
> ContactMechWorker.getPartyContactMechValueMaps(delegator, "10375", false,
> "TELECOM_NUMBER");
> timer.timerString("TN cmw " + cmwTelecomNumber.size());
> List> cmwEmail =
> ContactMechWorker.getPartyContactMechValueMaps(delegator, "10375", false,
> "EMAIL_ADDRESS");
> timer.timerString("E cmw " + cmwEmail.size());
> List> epwPostalAdress =
> CustomPartyWorker.getPartyContactMechValueMaps(delegator, "10375", false,
> "POSTAL_ADDRESS", null);
> timer.timerString("PA cpw " + epwPostalAdress.size());
> List> epwTelecomNumber =
> CustomPartyWorker.getPartyContactMechValueMaps(delegator, "10375", false,
> "TELECOM_NUMBER", null);
> timer.timerString("TN cpw " + epwTelecomNumber.size());
> List> epwEmail =
> CustomPartyWorker.getPartyContactMechValueMaps(delegator, "10375", false,
> "EMAIL_ADDRESS", null);
> timer.timerString("E cpw " + epwEmail.size());
> }
> {code}
> The partyId "10375" is linked with more tha 600 contactMechs on my local site
> db. And the test excecution give :
> {code:java}
> With ContactMechWorker
> [java] [[PA cmw 2- total:,since last(Begin):33.707]] - 'test
> contactmech'
> [java] [[TN cmw 2- total:,since last(PA cmw 2):33.837]] - 'test
> contactmech'
> [java] [[E cmw 1- total:1..,since last(TN cmw 2):33.115]] - 'test
> contactmech'
> With CustomPartyWorker
> [java] [[PA epw 2- total:...,since last(E cmw 1):0.53]] - 'test
> contactmech'
> [java] [[TN epw 2- total:...,since last(PA epw 2):0.588]] - 'test
> contactmech'
> [java] [[E epw 1- total:...,since last(TN epw 2):0.631]] - 'test
> contactmech'
> {code}
> total ~100s for ContactMechWorker and ~1.5s for CustomPartyWorker
> Difference come that CustomPartyWorker works on a view entity gathering the
> data and populating GenericValue with makeValue (using the data within the
> view) instead of creating new getRelated db access.
> I will implement this idea on generic context to improve these functions
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature
[
https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576774#comment-16576774
]
Gil Portenseigne commented on OFBIZ-10515:
--
Here is a patch providing the impersonate feature. You need also to copy the
png into ‘themes/common-theme/webapp/images/img/’
To test it :
* {{./gradlew loadAll ofbiz}} : to load seed and demo data
* Connect to partyMgr with admin/ofbiz
* Look for DemoEmployee party and go to his profile page
* Click on impersonate button :
!impersonateButton.png|width=998,height=269!
* Have Fun ! You can see that you have on the bottom right corner an icon
indicating you are impersonating, and there you can come back to your original
user.
!ImpersonationWidget.png|width=378,height=262!
This is a basic demo feature, we currently are using it for one of our
customer and find that very handy when a customer meet an issue. We can more
easily reproduce it, impersonating his login, without asking for the password.
> Impersonation of userLogin feature
> --
>
> Key: OFBIZ-10515
> URL: https://issues.apache.org/jira/browse/OFBIZ-10515
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: ImpersonationWidget.png, OFBIZ-10515.patch,
> impersonate-ico.png, impersonateButton.png
>
>
> This JIRA introduce a new feature that allow the impersonation of a login by
> an authorized user.
> This is implemeted with :·
> * A new service ‘userImpersonate’ that will check security, store
> impersonation in UserLoginHistory, and return the new session
> * Events ‘userImpersonate’ and ‘userDepersonate’ that will allow
> impersonation/depersonation action persisting current user session
> * A new modal widget in the common-theme that inform the user about
> ‘impersonation in process’ and offering a way to depersonate.
> * A new field in UserLoginHistory to store impersonation originator
> * A button in party viewprofile page to illustrate the feature
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: ImpersonationWidget.png > Impersonation of userLogin feature > -- > > Key: OFBIZ-10515 > URL: https://issues.apache.org/jira/browse/OFBIZ-10515 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: ImpersonationWidget.png, OFBIZ-10515.patch, > impersonate-ico.png, impersonateButton.png > > > This JIRA introduce a new feature that allow the impersonation of a login by > an authorized user. > This is implemeted with :· > * A new service ‘userImpersonate’ that will check security, store > impersonation in UserLoginHistory, and return the new session > * Events ‘userImpersonate’ and ‘userDepersonate’ that will allow > impersonation/depersonation action persisting current user session > * A new modal widget in the common-theme that inform the user about > ‘impersonation in process’ and offering a way to depersonate. > * A new field in UserLoginHistory to store impersonation originator > * A button in party viewprofile page to illustrate the feature -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: impersonateButton.png > Impersonation of userLogin feature > -- > > Key: OFBIZ-10515 > URL: https://issues.apache.org/jira/browse/OFBIZ-10515 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10515.patch, impersonate-ico.png, > impersonateButton.png > > > This JIRA introduce a new feature that allow the impersonation of a login by > an authorized user. > This is implemeted with :· > * A new service ‘userImpersonate’ that will check security, store > impersonation in UserLoginHistory, and return the new session > * Events ‘userImpersonate’ and ‘userDepersonate’ that will allow > impersonation/depersonation action persisting current user session > * A new modal widget in the common-theme that inform the user about > ‘impersonation in process’ and offering a way to depersonate. > * A new field in UserLoginHistory to store impersonation originator > * A button in party viewprofile page to illustrate the feature -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: impersonate-ico.png > Impersonation of userLogin feature > -- > > Key: OFBIZ-10515 > URL: https://issues.apache.org/jira/browse/OFBIZ-10515 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10515.patch, impersonate-ico.png > > > This JIRA introduce a new feature that allow the impersonation of a login by > an authorized user. > This is implemeted with :· > * A new service ‘userImpersonate’ that will check security, store > impersonation in UserLoginHistory, and return the new session > * Events ‘userImpersonate’ and ‘userDepersonate’ that will allow > impersonation/depersonation action persisting current user session > * A new modal widget in the common-theme that inform the user about > ‘impersonation in process’ and offering a way to depersonate. > * A new field in UserLoginHistory to store impersonation originator > * A button in party viewprofile page to illustrate the feature -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10515) Impersonation of userLogin feature
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10515: - Attachment: OFBIZ-10515.patch > Impersonation of userLogin feature > -- > > Key: OFBIZ-10515 > URL: https://issues.apache.org/jira/browse/OFBIZ-10515 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10515.patch > > > This JIRA introduce a new feature that allow the impersonation of a login by > an authorized user. > This is implemeted with :· > * A new service ‘userImpersonate’ that will check security, store > impersonation in UserLoginHistory, and return the new session > * Events ‘userImpersonate’ and ‘userDepersonate’ that will allow > impersonation/depersonation action persisting current user session > * A new modal widget in the common-theme that inform the user about > ‘impersonation in process’ and offering a way to depersonate. > * A new field in UserLoginHistory to store impersonation originator > * A button in party viewprofile page to illustrate the feature -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10516) Replace #assign with #local in all the ftl macros
[
https://issues.apache.org/jira/browse/OFBIZ-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576718#comment-16576718
]
Deepak Dixit edited comment on OFBIZ-10516 at 8/10/18 6:50 PM:
---
This has been done at ofbiz framework trunk at r#1837829 and r#1837830
was (Author: deepak.dixit):
This has been done at ofbiz framework trunk at r#{color:#22}1837829 and
r#1837830{color}
> Replace #assign with #local in all the ftl macros
> -
>
> Key: OFBIZ-10516
> URL: https://issues.apache.org/jira/browse/OFBIZ-10516
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> #assign is used to define global varialbes whereas #local is used as local
> variable in ftl macros.
> https://freemarker.apache.org/docs/dgui_misc_var.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10516) Replace #assign with #local in all the ftl macros
[ https://issues.apache.org/jira/browse/OFBIZ-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10516. Resolution: Done Fix Version/s: Upcoming Branch > Replace #assign with #local in all the ftl macros > - > > Key: OFBIZ-10516 > URL: https://issues.apache.org/jira/browse/OFBIZ-10516 > Project: OFBiz > Issue Type: Improvement >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > Fix For: Upcoming Branch > > > #assign is used to define global varialbes whereas #local is used as local > variable in ftl macros. > https://freemarker.apache.org/docs/dgui_misc_var.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10516) Replace #assign with #local in all the ftl macros
[
https://issues.apache.org/jira/browse/OFBIZ-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576718#comment-16576718
]
Deepak Dixit commented on OFBIZ-10516:
--
This has been done at ofbiz framework trunk at r#{color:#22}1837829 and
r#1837830{color}
> Replace #assign with #local in all the ftl macros
> -
>
> Key: OFBIZ-10516
> URL: https://issues.apache.org/jira/browse/OFBIZ-10516
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> #assign is used to define global varialbes whereas #local is used as local
> variable in ftl macros.
> https://freemarker.apache.org/docs/dgui_misc_var.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10516) Replace #assign with #local in all the ftl macros
Deepak Dixit created OFBIZ-10516: Summary: Replace #assign with #local in all the ftl macros Key: OFBIZ-10516 URL: https://issues.apache.org/jira/browse/OFBIZ-10516 Project: OFBiz Issue Type: Improvement Reporter: Deepak Dixit #assign is used to define global varialbes whereas #local is used as local variable in ftl macros. https://freemarker.apache.org/docs/dgui_misc_var.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10516) Replace #assign with #local in all the ftl macros
[ https://issues.apache.org/jira/browse/OFBIZ-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-10516: Assignee: Deepak Dixit > Replace #assign with #local in all the ftl macros > - > > Key: OFBIZ-10516 > URL: https://issues.apache.org/jira/browse/OFBIZ-10516 > Project: OFBiz > Issue Type: Improvement >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > > #assign is used to define global varialbes whereas #local is used as local > variable in ftl macros. > https://freemarker.apache.org/docs/dgui_misc_var.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10495) Rendering different HTML container types with ScreenRenderer
[
https://issues.apache.org/jira/browse/OFBIZ-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576698#comment-16576698
]
Deepak Dixit commented on OFBIZ-10495:
--
Updated widget-screen.xsd at ofbiz site at r#1837828
> Rendering different HTML container types with ScreenRenderer
>
>
> Key: OFBIZ-10495
> URL: https://issues.apache.org/jira/browse/OFBIZ-10495
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Dennis Balkir
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10495.patch, OFBIZ-10495_modular_container.patch
>
>
> This patch will add an type-parameter to the start and end render macros and
> methods of HTML containers.
> With this it is possible to not only use {{}} containers, but also use,
> for example, HTML5's {{}} .
> Simply by using
> {code:xml}
>
>
>
>
> {code}
> the renderer will render the container element as the given type.
> If type is left empty, it will always use it's fallback {{}}, and
> because of this no existing screen in OFBiz needs to be changed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10495) Rendering different HTML container types with ScreenRenderer
[
https://issues.apache.org/jira/browse/OFBIZ-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit closed OFBIZ-10495.
Resolution: Done
Fix Version/s: Upcoming Branch
Thanks Dennis Balkir for your contribution.
This has been committed at ofbiz framework trunk at r#1837827
> Rendering different HTML container types with ScreenRenderer
>
>
> Key: OFBIZ-10495
> URL: https://issues.apache.org/jira/browse/OFBIZ-10495
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Dennis Balkir
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10495.patch, OFBIZ-10495_modular_container.patch
>
>
> This patch will add an type-parameter to the start and end render macros and
> methods of HTML containers.
> With this it is possible to not only use {{}} containers, but also use,
> for example, HTML5's {{}} .
> Simply by using
> {code:xml}
>
>
>
>
> {code}
> the renderer will render the container element as the given type.
> If type is left empty, it will always use it's fallback {{}}, and
> because of this no existing screen in OFBiz needs to be changed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10495) Rendering different HTML container types with ScreenRenderer
[
https://issues.apache.org/jira/browse/OFBIZ-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit reassigned OFBIZ-10495:
Assignee: Deepak Dixit
> Rendering different HTML container types with ScreenRenderer
>
>
> Key: OFBIZ-10495
> URL: https://issues.apache.org/jira/browse/OFBIZ-10495
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Dennis Balkir
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-10495.patch, OFBIZ-10495_modular_container.patch
>
>
> This patch will add an type-parameter to the start and end render macros and
> methods of HTML containers.
> With this it is possible to not only use {{}} containers, but also use,
> for example, HTML5's {{}} .
> Simply by using
> {code:xml}
>
>
>
>
> {code}
> the renderer will render the container element as the given type.
> If type is left empty, it will always use it's fallback {{}}, and
> because of this no existing screen in OFBiz needs to be changed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-10511: - Fix Version/s: (was: Upcoming Branch) > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-10511-reproduceBug.patch, OFBIZ-10511.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10513) Change font Title
[ https://issues.apache.org/jira/browse/OFBIZ-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576463#comment-16576463 ] Julien NICOLAS commented on OFBIZ-10513: Thanks Marine ! :) > Change font Title > - > > Key: OFBIZ-10513 > URL: https://issues.apache.org/jira/browse/OFBIZ-10513 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Marine Desmarchelier >Assignee: Julien NICOLAS >Priority: Trivial > Fix For: Trunk > > Attachments: OFBIZ-10513.patch > > > OTF QuickSand font doesn't work with css code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10513) Change font Title
[ https://issues.apache.org/jira/browse/OFBIZ-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576434#comment-16576434 ] Jacques Le Roux edited comment on OFBIZ-10513 at 8/10/18 3:36 PM: -- Great news, "on ne fait pas d'omelette sans casser d'oeufs" ;) was (Author: jacques.le.roux): Great news, "on ne fait pas d'omelette sans cassé d'oeufs" ;) > Change font Title > - > > Key: OFBIZ-10513 > URL: https://issues.apache.org/jira/browse/OFBIZ-10513 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Marine Desmarchelier >Assignee: Julien NICOLAS >Priority: Trivial > Fix For: Trunk > > Attachments: OFBIZ-10513.patch > > > OTF QuickSand font doesn't work with css code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10513) Change font Title
[ https://issues.apache.org/jira/browse/OFBIZ-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marine Desmarchelier updated OFBIZ-10513: - Attachment: OFBIZ-10513.patch > Change font Title > - > > Key: OFBIZ-10513 > URL: https://issues.apache.org/jira/browse/OFBIZ-10513 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Marine Desmarchelier >Assignee: Julien NICOLAS >Priority: Trivial > Fix For: Trunk > > Attachments: OFBIZ-10513.patch > > > OTF QuickSand font doesn't work with css code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10513) Change font Title
[ https://issues.apache.org/jira/browse/OFBIZ-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576434#comment-16576434 ] Jacques Le Roux commented on OFBIZ-10513: - Great news, "on ne fait pas d'omelette sans cassé d'oeufs" ;) > Change font Title > - > > Key: OFBIZ-10513 > URL: https://issues.apache.org/jira/browse/OFBIZ-10513 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Marine Desmarchelier >Assignee: Julien NICOLAS >Priority: Trivial > Fix For: Trunk > > > OTF QuickSand font doesn't work with css code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10515) Impersonation of userLogin feature
Gil Portenseigne created OFBIZ-10515: Summary: Impersonation of userLogin feature Key: OFBIZ-10515 URL: https://issues.apache.org/jira/browse/OFBIZ-10515 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk Reporter: Gil Portenseigne Assignee: Gil Portenseigne Fix For: Upcoming Branch This JIRA introduce a new feature that allow the impersonation of a login by an authorized user. This is implemeted with :· * A new service ‘userImpersonate’ that will check security, store impersonation in UserLoginHistory, and return the new session * Events ‘userImpersonate’ and ‘userDepersonate’ that will allow impersonation/depersonation action persisting current user session * A new modal widget in the common-theme that inform the user about ‘impersonation in process’ and offering a way to depersonate. * A new field in UserLoginHistory to store impersonation originator * A button in party viewprofile page to illustrate the feature -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10514) Refactoring ContactMechWorker.get[Entity]ContactMechValueMaps
Nicolas Malin created OFBIZ-10514:
-
Summary: Refactoring
ContactMechWorker.get[Entity]ContactMechValueMaps
Key: OFBIZ-10514
URL: https://issues.apache.org/jira/browse/OFBIZ-10514
Project: OFBiz
Issue Type: Improvement
Components: party
Reporter: Nicolas Malin
Assignee: Nicolas Malin
ContactMechWorker.get[Entity]ContactMechValueMaps are old historic functions
that resolve all contact mech context related to an Entity (Party, Facility,
Order, WorkEffort).
The problem that they create too many db call during their execution that
decrease OFBiz performance when the contactMech history grow.
On customer site I realized a new adaptation (oriented and not generic at all)
and control the performance issue with a unit test :
{code:java}
public void testContactMechSearch() throws Exception {
UtilTimer timer = new UtilTimer("test contactmech", true, true);
timer.startTimer();
List> cmwPostalAdress =
ContactMechWorker.getPartyContactMechValueMaps(delegator, "10375", false,
"POSTAL_ADDRESS");
timer.timerString("PA cmw " + cmwPostalAdress.size());
List> cmwTelecomNumber =
ContactMechWorker.getPartyContactMechValueMaps(delegator, "10375", false,
"TELECOM_NUMBER");
timer.timerString("TN cmw " + cmwTelecomNumber.size());
List> cmwEmail =
ContactMechWorker.getPartyContactMechValueMaps(delegator, "10375", false,
"EMAIL_ADDRESS");
timer.timerString("E cmw " + cmwEmail.size());
List> epwPostalAdress =
CustomPartyWorker.getPartyContactMechValueMaps(delegator, "10375", false,
"POSTAL_ADDRESS", null);
timer.timerString("PA cpw " + epwPostalAdress.size());
List> epwTelecomNumber =
CustomPartyWorker.getPartyContactMechValueMaps(delegator, "10375", false,
"TELECOM_NUMBER", null);
timer.timerString("TN cpw " + epwTelecomNumber.size());
List> epwEmail =
CustomPartyWorker.getPartyContactMechValueMaps(delegator, "10375", false,
"EMAIL_ADDRESS", null);
timer.timerString("E cpw " + epwEmail.size());
}
{code}
The partyId "10375" is linked with more tha 600 contactMechs on my local site
db. And the test excecution give :
{code:java}
With ContactMechWorker
[java] [[PA cmw 2- total:,since last(Begin):33.707]] - 'test
contactmech'
[java] [[TN cmw 2- total:,since last(PA cmw 2):33.837]] - 'test
contactmech'
[java] [[E cmw 1- total:1..,since last(TN cmw 2):33.115]] - 'test
contactmech'
With CustomPartyWorker
[java] [[PA epw 2- total:...,since last(E cmw 1):0.53]] - 'test
contactmech'
[java] [[TN epw 2- total:...,since last(PA epw 2):0.588]] - 'test
contactmech'
[java] [[E epw 1- total:...,since last(TN epw 2):0.631]] - 'test
contactmech'
{code}
total ~100s for ContactMechWorker and ~1.5s for CustomPartyWorker
Difference come that CustomPartyWorker works on a view entity gathering the
data and populating GenericValue with makeValue (using the data within the
view) instead of creating new getRelated db access.
I will implement this idea on generic context to improve these functions
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7482) Deposit price support
[ https://issues.apache.org/jira/browse/OFBIZ-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576410#comment-16576410 ] Jacques Le Roux commented on OFBIZ-7482: Nice review, (forgot that as well) thanks Gil :) > Deposit price support > -- > > Key: OFBIZ-7482 > URL: https://issues.apache.org/jira/browse/OFBIZ-7482 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7482.patch > > > Business requirements: > In many business industry this is very common pattern that you need to pay > some amount as deposit for particular products. Such as when you purchase > wine or other bottle products, you need to pay some amount as deposit and > whenever you return back that bottle, that deposited amount will be refunded > to you. > Technical Details: > Create a new ProductPricePurpose as 'DEPOSIT' and for similar products we > will create product price record with productPriceTypeId as 'DEFAULT_PRICE' > and productPricePurposeId as 'DEPOSIT'. At the time of Order creation simply > create order adjustments for such products. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10513) Change font Title
[ https://issues.apache.org/jira/browse/OFBIZ-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576383#comment-16576383 ] Julien NICOLAS commented on OFBIZ-10513: Yes, marine work with us, now we have more power one the UI. She solved my mistake ^^ > Change font Title > - > > Key: OFBIZ-10513 > URL: https://issues.apache.org/jira/browse/OFBIZ-10513 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Marine Desmarchelier >Assignee: Julien NICOLAS >Priority: Trivial > Fix For: Trunk > > > OTF QuickSand font doesn't work with css code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10513) Change font Title
[ https://issues.apache.org/jira/browse/OFBIZ-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien NICOLAS reassigned OFBIZ-10513: -- Assignee: Julien NICOLAS > Change font Title > - > > Key: OFBIZ-10513 > URL: https://issues.apache.org/jira/browse/OFBIZ-10513 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Marine Desmarchelier >Assignee: Julien NICOLAS >Priority: Trivial > Fix For: Trunk > > > OTF QuickSand font doesn't work with css code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10513) Change font Title
[ https://issues.apache.org/jira/browse/OFBIZ-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576371#comment-16576371 ] Jacques Le Roux commented on OFBIZ-10513: - Thanks Marine, We already speak about that: https://markmail.org/message/ij6kgbaw53l7nu5j > Change font Title > - > > Key: OFBIZ-10513 > URL: https://issues.apache.org/jira/browse/OFBIZ-10513 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Marine Desmarchelier >Priority: Trivial > Fix For: Trunk > > > OTF QuickSand font doesn't work with css code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10512) Change order of parameters in runSyncIgnore
[
https://issues.apache.org/jira/browse/OFBIZ-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576364#comment-16576364
]
Jacques Le Roux commented on OFBIZ-10512:
-
+1
> Change order of parameters in runSyncIgnore
> ---
>
> Key: OFBIZ-10512
> URL: https://issues.apache.org/jira/browse/OFBIZ-10512
> Project: OFBiz
> Issue Type: Wish
>Reporter: Niklas Fallik
>Priority: Minor
>
> It is confusing that the order of the arguments passed to
> LocalDispatcher.runSyncIgnore() is not the same in all overloaded methods.
> cf.
> {code:java}
> void runSyncIgnore(String serviceName, Map context,
> int transactionTimeout, boolean requireNewTransaction) throws
> ServiceAuthException, ServiceValidationException, GenericServiceException;
> {code}
>
> {code:java}
> void runSyncIgnore(String serviceName, int transactionTimeout, boolean
> requireNewTransaction, Object... context) throws ServiceAuthException,
> ServiceValidationException, GenericServiceException; {code}
> cf.
> LocalDispatcher.java[101 + 102]
>
> The context parameter could be passed as second or as fourth argument, no
> matter if it is a Map or an Object.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10513) Change font Title
Marine Desmarchelier created OFBIZ-10513: Summary: Change font Title Key: OFBIZ-10513 URL: https://issues.apache.org/jira/browse/OFBIZ-10513 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Marine Desmarchelier Fix For: Trunk OTF QuickSand font doesn't work with css code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10368) Implement Depends on support for Component Loading.
[
https://issues.apache.org/jira/browse/OFBIZ-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576338#comment-16576338
]
Jacques Le Roux edited comment on OFBIZ-10368 at 8/10/18 2:23 PM:
--
Hi Yash,
This works well and I'm ready to commit. We just need to update
ofbiz-component.xsd
BTW ebaystore is not a good example, this plugin is disabled ;)
Though it also shows that you can't depend on a disabled component, so maybe a
good example for thorough tests actually :)
was (Author: jacques.le.roux):
Hi Yash,
This works well and I'm ready to commit. We just need to update
ofbiz-component.xsd
BTW ebaystore is not a good example, this plugin is disabled ;)
> Implement Depends on support for Component Loading.
> ---
>
> Key: OFBIZ-10368
> URL: https://issues.apache.org/jira/browse/OFBIZ-10368
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10368.patch
>
>
> Components are loaded in the order they are found (i.e. alphabetic or
> creation date). This can be altered. We have a pending feature support for
> ofbiz-component, for creating a series of dependency for component loading,
> before loading a particular component.
>
> Here we can define dependency for a component like Component ebaystore is
> dependent on Component ebay (even multiple dependencies for a single
> component is also supported). We can declare it in this fashion in
> ofbiz-component.xml file.
>
> {code:java}
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/ofbiz-component.xsd;>
> {code}
>
> Now we can declare dependency and if any anomaly is found loading of
> components will stop.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10368) Implement Depends on support for Component Loading.
[
https://issues.apache.org/jira/browse/OFBIZ-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576338#comment-16576338
]
Jacques Le Roux commented on OFBIZ-10368:
-
Hi Yash,
This works well and I'm ready to commit. We just need to update
ofbiz-component.xsd
BTW ebaystore is not a good example, this plugin is disabled ;)
> Implement Depends on support for Component Loading.
> ---
>
> Key: OFBIZ-10368
> URL: https://issues.apache.org/jira/browse/OFBIZ-10368
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10368.patch
>
>
> Components are loaded in the order they are found (i.e. alphabetic or
> creation date). This can be altered. We have a pending feature support for
> ofbiz-component, for creating a series of dependency for component loading,
> before loading a particular component.
>
> Here we can define dependency for a component like Component ebaystore is
> dependent on Component ebay (even multiple dependencies for a single
> component is also supported). We can declare it in this fashion in
> ofbiz-component.xml file.
>
> {code:java}
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/ofbiz-component.xsd;>
> {code}
>
> Now we can declare dependency and if any anomaly is found loading of
> components will stop.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne resolved OFBIZ-10511. -- Resolution: Fixed Fix Version/s: Upcoming Branch 17.12.01 Commited in trunk r1837806 and in 17.12 r1837807. Thanks [~deepak.dixit] and [~aditya.sharma] > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: 17.12.01, Upcoming Branch > > Attachments: OFBIZ-10511-reproduceBug.patch, OFBIZ-10511.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne closed OFBIZ-10511. > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Fix For: 17.12.01, Upcoming Branch > > Attachments: OFBIZ-10511-reproduceBug.patch, OFBIZ-10511.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7719) Not able to select Virtual Product in WebPos
[ https://issues.apache.org/jira/browse/OFBIZ-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576271#comment-16576271 ] Suraj Khurana commented on OFBIZ-7719: -- I will commit it on release16.11 as well and will close the issue. > Not able to select Virtual Product in WebPos > > > Key: OFBIZ-7719 > URL: https://issues.apache.org/jira/browse/OFBIZ-7719 > Project: OFBiz > Issue Type: Bug > Components: webpos >Reporter: Vishal Chhabria >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7719.patch > > > Following JS error occurs on selecting virtual product in WebPos: > Uncaught TypeError: jQuery(...).update is not a function -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576203#comment-16576203 ] Deepak Dixit commented on OFBIZ-10511: -- Thanks [~gil portenseigne] for review and confiming. Please feel free to commit it :) > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-reproduceBug.patch, OFBIZ-10511.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10511: - Attachment: (was: OFBIZ-10511-02-fixProposal.patch) > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-reproduceBug.patch, OFBIZ-10511.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576185#comment-16576185 ] Gil Portenseigne commented on OFBIZ-10511: -- It works, Thanks [~deepak.dixit], that is far more simple than my proposal :), since it is your patch will you commit it, or do you want me to do it ? > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-reproduceBug.patch, OFBIZ-10511.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576163#comment-16576163 ] Gil Portenseigne commented on OFBIZ-10511: -- Thanks [~deepak.dixit], i'm on it ! > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-02-fixProposal.patch, > OFBIZ-10511-reproduceBug.patch, OFBIZ-10511.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7482) Deposit price support
[ https://issues.apache.org/jira/browse/OFBIZ-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576157#comment-16576157 ] Suraj Khurana commented on OFBIZ-7482: -- Thanks [~gil portenseigne], This is an old patch and all your feedback makes perfect sense to me. I will surely update the patch before committing it. Thanks again for reviewing. :) > Deposit price support > -- > > Key: OFBIZ-7482 > URL: https://issues.apache.org/jira/browse/OFBIZ-7482 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7482.patch > > > Business requirements: > In many business industry this is very common pattern that you need to pay > some amount as deposit for particular products. Such as when you purchase > wine or other bottle products, you need to pay some amount as deposit and > whenever you return back that bottle, that deposited amount will be refunded > to you. > Technical Details: > Create a new ProductPricePurpose as 'DEPOSIT' and for similar products we > will create product price record with productPriceTypeId as 'DEFAULT_PRICE' > and productPricePurposeId as 'DEPOSIT'. At the time of Order creation simply > create order adjustments for such products. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576136#comment-16576136 ] Deepak Dixit edited comment on OFBIZ-10511 at 8/10/18 11:30 AM: [~gil portenseigne] could you please verify attached patch? The main issue was that single-quotes can't be used in json. It will give syntax error. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/JSON_bad_parse#Property_names_must_be_double-quoted_strings was (Author: deepak.dixit): [~gil portenseigne] could you please verify attached patch? The main issue was that single-quotes can't be used in json. It will not give syntax error. > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-02-fixProposal.patch, > OFBIZ-10511-reproduceBug.patch, OFBIZ-10511.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576136#comment-16576136 ] Deepak Dixit commented on OFBIZ-10511: -- [~gil portenseigne] could you please verify attached patch? The main issue was that single-quotes can't be used in json. It will not give syntax error. > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-02-fixProposal.patch, > OFBIZ-10511-reproduceBug.patch, OFBIZ-10511.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6858) Solr logging doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576135#comment-16576135 ] Jacques Le Roux commented on OFBIZ-6858: Thank you Jinghai, Shawn, and Pierre for report :) > Solr logging doesn't work > - > > Key: OFBIZ-6858 > URL: https://issues.apache.org/jira/browse/OFBIZ-6858 > Project: OFBiz > Issue Type: Bug > Components: solr >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Pierre Smits >Assignee: Shi Jinghai >Priority: Major > Attachments: Image2.png > > > When looking at the logging screen in demo-trunk > (https://demo-trunk-ofbiz.apache.org/solr/#/~logging) no logging results are > shown. Nor does https://demo-trunk-ofbiz.apache.org/solr/#/~logging/level > provide any insights. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-10511: - Attachment: OFBIZ-10511.patch > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-02-fixProposal.patch, > OFBIZ-10511-reproduceBug.patch, OFBIZ-10511.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10507) LoginServices.userLogin: Respond "fail" instead of "error" to avoid the (automatic service engine) logging of a stack trace on missing/invalid credentials
[ https://issues.apache.org/jira/browse/OFBIZ-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576101#comment-16576101 ] Michael Brohl commented on OFBIZ-10507: --- [~deepak.dixit], the problem I see with with the current logging is that it is logged as an error which leads to massive logging in productive high traffic systems. For debugging it should be fine to log at the INFO level but not ERROR. I think we should reduce the amount of ERRORS messages in the log to a reasonable amount. Wrong password entries should definetely not go to the logfile. > LoginServices.userLogin: Respond "fail" instead of "error" to avoid the > (automatic service engine) logging of a stack trace on missing/invalid > credentials > -- > > Key: OFBIZ-10507 > URL: https://issues.apache.org/jira/browse/OFBIZ-10507 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Attachments: > OFBIZ-10507_org.apache.ofbiz.common.login.LoginServices.patch > > > There are a lot of login-related entries in the logfile, that stem from user > related errors (like no or wrong password, user not found and so on). To > reduce this, the patch introduces a distinction between ERROR messages and > FAIL messages in the Service-Result. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576060#comment-16576060 ] Aditya Sharma commented on OFBIZ-10511: --- Thanks [~gil portenseigne] . I will look into it. > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-02-fixProposal.patch, > OFBIZ-10511-reproduceBug.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7482) Deposit price support
[
https://issues.apache.org/jira/browse/OFBIZ-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576014#comment-16576014
]
Gil Portenseigne commented on OFBIZ-7482:
-
Hello [~suraj.khurana],
I've no objections (not tested), but from a quick review i got just some
remarks about the form :
{code:java}
GenericValue depositAmount =
EntityQuery.use(delegator).from("ProductPrice").where(UtilMisc.toMap("productId",
this.getProductId(),"productPricePurposeId", "DEPOSIT", "productPriceTypeId",
"DEFAULT_PRICE")).cache(false).filterByDate(UtilDateTime.nowTimestamp(),
"fromDate", "thruDate").queryFirst(); {code}
You can simplify it using public EntityQuery where(Object...fields) method,
useCache is set to {{false}} by default, and you are using default date filter.
Resulting in :·
{code:java}
GenericValue depositAmount =
EntityQuery.use(delegator).from("ProductPrice").where("productId",
this.getProductId(),"productPricePurposeId", "DEPOSIT", "productPriceTypeId",
"DEFAULT_PRICE").filterByDate().queryFirst(); {code}
When testing GenericValue presence, UtilValidate is not needed, using if
(depositAmount != null) suffice.
I tend to avoid using Boolean if not needed (collection requirement), primitive
boolean is enough and avoid possible NPE.
Thanks for your work :) !
> Deposit price support
> --
>
> Key: OFBIZ-7482
> URL: https://issues.apache.org/jira/browse/OFBIZ-7482
> Project: OFBiz
> Issue Type: New Feature
> Components: product
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-7482.patch
>
>
> Business requirements:
> In many business industry this is very common pattern that you need to pay
> some amount as deposit for particular products. Such as when you purchase
> wine or other bottle products, you need to pay some amount as deposit and
> whenever you return back that bottle, that deposited amount will be refunded
> to you.
> Technical Details:
> Create a new ProductPricePurpose as 'DEPOSIT' and for similar products we
> will create product price record with productPriceTypeId as 'DEFAULT_PRICE'
> and productPricePurposeId as 'DEPOSIT'. At the time of Order creation simply
> create order adjustments for such products.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10512) Change order of parameters in runSyncIgnore
[
https://issues.apache.org/jira/browse/OFBIZ-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niklas Fallik updated OFBIZ-10512:
--
Priority: Minor (was: Major)
> Change order of parameters in runSyncIgnore
> ---
>
> Key: OFBIZ-10512
> URL: https://issues.apache.org/jira/browse/OFBIZ-10512
> Project: OFBiz
> Issue Type: Wish
>Reporter: Niklas Fallik
>Priority: Minor
>
> It is confusing that the order of the arguments passed to
> LocalDispatcher.runSyncIgnore() is not the same in all overloaded methods.
> {{cf.}}
> {{ void runSyncIgnore(String serviceName, Map
> context, int transactionTimeout, boolean requireNewTransaction) throws
> ServiceAuthException, ServiceValidationException, GenericServiceException;}}
> {{ void runSyncIgnore(String serviceName, int transactionTimeout, boolean
> requireNewTransaction, Object... context) throws ServiceAuthException,
> ServiceValidationException, GenericServiceException;}}
> {{ (ll. 101 + 102 in LocalDispatcher.java)}}
> The context parameter could be passed as second or as fourth argument, no
> matter if it is a Map or an Object.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10512) Change order of parameters in runSyncIgnore
[
https://issues.apache.org/jira/browse/OFBIZ-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niklas Fallik updated OFBIZ-10512:
--
Description:
It is confusing that the order of the arguments passed to
LocalDispatcher.runSyncIgnore() is not the same in all overloaded methods.
{{cf.}}
{{ void runSyncIgnore(String serviceName, Map
context, int transactionTimeout, boolean requireNewTransaction) throws
ServiceAuthException, ServiceValidationException, GenericServiceException;}}
{{ void runSyncIgnore(String serviceName, int transactionTimeout, boolean
requireNewTransaction, Object... context) throws ServiceAuthException,
ServiceValidationException, GenericServiceException;}}
{{ (ll. 101 + 102 in LocalDispatcher.java)}}
The context parameter could be passed as second or as fourth argument, no
matter if it is a Map or an Object.
was:
It is confusing that the order of the arguments passed to
LocalDispatcher.runSyncIgnore() is not the same in all overloaded methods.
cf.
void runSyncIgnore(String serviceName, Map context,
int transactionTimeout, boolean requireNewTransaction) throws
ServiceAuthException, ServiceValidationException, GenericServiceException;
void runSyncIgnore(String serviceName, int transactionTimeout, boolean
requireNewTransaction, Object... context) throws ServiceAuthException,
ServiceValidationException, GenericServiceException;
(ll. 101 + 102 in LocalDispatcher.java)
The context parameter could be passed as second or as fourth argument, no
matter if it is a Map or an Object.
> Change order of parameters in runSyncIgnore
> ---
>
> Key: OFBIZ-10512
> URL: https://issues.apache.org/jira/browse/OFBIZ-10512
> Project: OFBiz
> Issue Type: Wish
>Reporter: Niklas Fallik
>Priority: Major
>
> It is confusing that the order of the arguments passed to
> LocalDispatcher.runSyncIgnore() is not the same in all overloaded methods.
> {{cf.}}
> {{ void runSyncIgnore(String serviceName, Map
> context, int transactionTimeout, boolean requireNewTransaction) throws
> ServiceAuthException, ServiceValidationException, GenericServiceException;}}
> {{ void runSyncIgnore(String serviceName, int transactionTimeout, boolean
> requireNewTransaction, Object... context) throws ServiceAuthException,
> ServiceValidationException, GenericServiceException;}}
> {{ (ll. 101 + 102 in LocalDispatcher.java)}}
> The context parameter could be passed as second or as fourth argument, no
> matter if it is a Map or an Object.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10512) Change order of parameters in runSyncIgnore
[
https://issues.apache.org/jira/browse/OFBIZ-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niklas Fallik updated OFBIZ-10512:
--
Description:
It is confusing that the order of the arguments passed to
LocalDispatcher.runSyncIgnore() is not the same in all overloaded methods.
cf.
void runSyncIgnore(String serviceName, Map context,
int transactionTimeout, boolean requireNewTransaction) throws
ServiceAuthException, ServiceValidationException, GenericServiceException;
void runSyncIgnore(String serviceName, int transactionTimeout, boolean
requireNewTransaction, Object... context) throws ServiceAuthException,
ServiceValidationException, GenericServiceException;
(ll. 101 + 102 in LocalDispatcher.java)
The context parameter could be passed as second or as fourth argument, no
matter if it is a Map or an Object.
was:
It is confusing that the order of the arguments passed to
{{LocalDispatcher.runSyncIgnore()}} is not the same in all overloaded methods.
cf.
{{void runSyncIgnore(String serviceName, Map context,
int transactionTimeout, boolean requireNewTransaction) throws
ServiceAuthException, ServiceValidationException, GenericServiceException;
void runSyncIgnore(String serviceName, int transactionTimeout, boolean
requireNewTransaction, Object... context) throws ServiceAuthException,
ServiceValidationException, GenericServiceException;
(ll. 101 + 102 in LocalDispatcher.java)}}
The {{context}} parameter could be passed as second or as fourth argument, no
matter if it is a Map or an Object.
> Change order of parameters in runSyncIgnore
> ---
>
> Key: OFBIZ-10512
> URL: https://issues.apache.org/jira/browse/OFBIZ-10512
> Project: OFBiz
> Issue Type: Wish
>Reporter: Niklas Fallik
>Priority: Major
>
> It is confusing that the order of the arguments passed to
> LocalDispatcher.runSyncIgnore() is not the same in all overloaded methods.
> cf.
> void runSyncIgnore(String serviceName, Map context,
> int transactionTimeout, boolean requireNewTransaction) throws
> ServiceAuthException, ServiceValidationException, GenericServiceException;
> void runSyncIgnore(String serviceName, int transactionTimeout, boolean
> requireNewTransaction, Object... context) throws ServiceAuthException,
> ServiceValidationException, GenericServiceException;
> (ll. 101 + 102 in LocalDispatcher.java)
> The context parameter could be passed as second or as fourth argument, no
> matter if it is a Map or an Object.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10512) Change order of parameters in runSyncIgnore
[
https://issues.apache.org/jira/browse/OFBIZ-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niklas Fallik updated OFBIZ-10512:
--
Description:
It is confusing that the order of the arguments passed to
{{LocalDispatcher.runSyncIgnore()}} is not the same in all overloaded methods.
cf.
{{void runSyncIgnore(String serviceName, Map context,
int transactionTimeout, boolean requireNewTransaction) throws
ServiceAuthException, ServiceValidationException, GenericServiceException;
void runSyncIgnore(String serviceName, int transactionTimeout, boolean
requireNewTransaction, Object... context) throws ServiceAuthException,
ServiceValidationException, GenericServiceException;
(ll. 101 + 102 in LocalDispatcher.java)}}
The {{context}} parameter could be passed as second or as fourth argument, no
matter if it is a Map or an Object.
was:
It is confusing that the order of the arguments passed to
`LocalDispatcher.runSyncIgnore()` is not the same in all overloaded methods.
cf.
```
void runSyncIgnore(String serviceName, Map context,
int transactionTimeout, boolean requireNewTransaction) throws
ServiceAuthException, ServiceValidationException, GenericServiceException;
void runSyncIgnore(String serviceName, int transactionTimeout, boolean
requireNewTransaction, Object... context) throws ServiceAuthException,
ServiceValidationException, GenericServiceException;```
(ll. 101 + 102 in LocalDispatcher.java)
The `context` parameter could be passed as second or as fourth argument, no
matter if it is a Map or an Object.
> Change order of parameters in runSyncIgnore
> ---
>
> Key: OFBIZ-10512
> URL: https://issues.apache.org/jira/browse/OFBIZ-10512
> Project: OFBiz
> Issue Type: Wish
>Reporter: Niklas Fallik
>Priority: Major
>
> It is confusing that the order of the arguments passed to
> {{LocalDispatcher.runSyncIgnore()}} is not the same in all overloaded methods.
> cf.
> {{void runSyncIgnore(String serviceName, Map
> context, int transactionTimeout, boolean requireNewTransaction) throws
> ServiceAuthException, ServiceValidationException, GenericServiceException;
> void runSyncIgnore(String serviceName, int transactionTimeout, boolean
> requireNewTransaction, Object... context) throws ServiceAuthException,
> ServiceValidationException, GenericServiceException;
> (ll. 101 + 102 in LocalDispatcher.java)}}
> The {{context}} parameter could be passed as second or as fourth argument, no
> matter if it is a Map or an Object.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10512) Change order of parameters in runSyncIgnore
Niklas Fallik created OFBIZ-10512: - Summary: Change order of parameters in runSyncIgnore Key: OFBIZ-10512 URL: https://issues.apache.org/jira/browse/OFBIZ-10512 Project: OFBiz Issue Type: Wish Reporter: Niklas Fallik It is confusing that the order of the arguments passed to `LocalDispatcher.runSyncIgnore()` is not the same in all overloaded methods. cf. ``` void runSyncIgnore(String serviceName, Map context, int transactionTimeout, boolean requireNewTransaction) throws ServiceAuthException, ServiceValidationException, GenericServiceException; void runSyncIgnore(String serviceName, int transactionTimeout, boolean requireNewTransaction, Object... context) throws ServiceAuthException, ServiceValidationException, GenericServiceException;``` (ll. 101 + 102 in LocalDispatcher.java) The `context` parameter could be passed as second or as fourth argument, no matter if it is a Map or an Object. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575967#comment-16575967 ] Deepak Dixit commented on OFBIZ-10511: -- Thanks [~gil portenseigne] , I'll check and let you know :) > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-02-fixProposal.patch, > OFBIZ-10511-reproduceBug.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575964#comment-16575964 ] Deepak Dixit commented on OFBIZ-10511: -- Hi Gil, At OFBIZ-9846, inline script replaced with external js, So I think instead of adding inline script can we try another route? > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-02-fixProposal.patch, > OFBIZ-10511-reproduceBug.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575960#comment-16575960 ] Gil Portenseigne commented on OFBIZ-10511: -- This issue has been introduced in OFBIZ-9852, i will let time for review before commiting it, if [~aditya.sharma] or [~deepak.dixit] could take a look that would be great :) Thanks > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-02-fixProposal.patch, > OFBIZ-10511-reproduceBug.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575952#comment-16575952 ] Gil Portenseigne commented on OFBIZ-10511: -- To reproduce apply reproduceBug patch onto Example component, and see nothing happen (TestParam should appear in exampleName field). I propose a fix that will make it works. The fix store the parameter map into a JS variable during screen generation. Than that variable will be retrieved through OfbizUtil.js listener. Applying fixProposal patch should clear the issue. > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-02-fixProposal.patch, > OFBIZ-10511-reproduceBug.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10511: - Attachment: OFBIZ-10511-02-fixProposal.patch > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-02-fixProposal.patch, > OFBIZ-10511-reproduceBug.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10511) Use of layered-modal with parameter does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gil Portenseigne updated OFBIZ-10511: - Attachment: OFBIZ-10511-reproduceBug.patch > Use of layered-modal with parameter does not work > - > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12 >Reporter: Gil Portenseigne >Assignee: Gil Portenseigne >Priority: Major > Attachments: OFBIZ-10511-reproduceBug.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10511) Use of layered-modal with parameter does not work
Gil Portenseigne created OFBIZ-10511: Summary: Use of layered-modal with parameter does not work Key: OFBIZ-10511 URL: https://issues.apache.org/jira/browse/OFBIZ-10511 Project: OFBiz Issue Type: Bug Affects Versions: Trunk, Release Branch 17.12 Reporter: Gil Portenseigne Assignee: Gil Portenseigne When using layered-modal with a parameter, those param are not parsed by js when doing post request (the constructed map stay, and is send as one parameter with no value...). Though no parameter can be passed to the request. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7719) Not able to select Virtual Product in WebPos
[ https://issues.apache.org/jira/browse/OFBIZ-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-7719: - Summary: Not able to select Virtual Product in WebPos (was: Not able to select Vitrual Product in WebPos) > Not able to select Virtual Product in WebPos > > > Key: OFBIZ-7719 > URL: https://issues.apache.org/jira/browse/OFBIZ-7719 > Project: OFBiz > Issue Type: Bug > Components: webpos >Reporter: Vishal Chhabria >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7719.patch > > > Following JS error occurs on selecting virtual product in WebPos: > Uncaught TypeError: jQuery(...).update is not a function -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-7037) Have QRCodeServices.java use EntityUtilProperties
[ https://issues.apache.org/jira/browse/OFBIZ-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-7037: Assignee: Suraj Khurana (was: Mridul Pathak) > Have QRCodeServices.java use EntityUtilProperties > - > > Key: OFBIZ-7037 > URL: https://issues.apache.org/jira/browse/OFBIZ-7037 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7037.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7482) Deposit price support
[ https://issues.apache.org/jira/browse/OFBIZ-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575931#comment-16575931 ] Suraj Khurana commented on OFBIZ-7482: -- Hello team, I think anyone has no objection with this patch, so I will consider it as positive consensus and will proceed it in 2-3 days. Thanks!! > Deposit price support > -- > > Key: OFBIZ-7482 > URL: https://issues.apache.org/jira/browse/OFBIZ-7482 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Mridul Pathak >Priority: Major > Attachments: OFBIZ-7482.patch > > > Business requirements: > In many business industry this is very common pattern that you need to pay > some amount as deposit for particular products. Such as when you purchase > wine or other bottle products, you need to pay some amount as deposit and > whenever you return back that bottle, that deposited amount will be refunded > to you. > Technical Details: > Create a new ProductPricePurpose as 'DEPOSIT' and for similar products we > will create product price record with productPriceTypeId as 'DEFAULT_PRICE' > and productPricePurposeId as 'DEPOSIT'. At the time of Order creation simply > create order adjustments for such products. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-7482) Deposit price support
[ https://issues.apache.org/jira/browse/OFBIZ-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-7482: Assignee: Suraj Khurana (was: Mridul Pathak) > Deposit price support > -- > > Key: OFBIZ-7482 > URL: https://issues.apache.org/jira/browse/OFBIZ-7482 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7482.patch > > > Business requirements: > In many business industry this is very common pattern that you need to pay > some amount as deposit for particular products. Such as when you purchase > wine or other bottle products, you need to pay some amount as deposit and > whenever you return back that bottle, that deposited amount will be refunded > to you. > Technical Details: > Create a new ProductPricePurpose as 'DEPOSIT' and for similar products we > will create product price record with productPriceTypeId as 'DEFAULT_PRICE' > and productPricePurposeId as 'DEPOSIT'. At the time of Order creation simply > create order adjustments for such products. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-7719) Not able to select Vitrual Product in WebPos
[ https://issues.apache.org/jira/browse/OFBIZ-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-7719: Assignee: Suraj Khurana (was: Mridul Pathak) > Not able to select Vitrual Product in WebPos > > > Key: OFBIZ-7719 > URL: https://issues.apache.org/jira/browse/OFBIZ-7719 > Project: OFBiz > Issue Type: Bug > Components: webpos >Reporter: Vishal Chhabria >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-7719.patch > > > Following JS error occurs on selecting virtual product in WebPos: > Uncaught TypeError: jQuery(...).update is not a function -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-6858) Solr logging doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shi Jinghai closed OFBIZ-6858. -- Resolution: Fixed > Solr logging doesn't work > - > > Key: OFBIZ-6858 > URL: https://issues.apache.org/jira/browse/OFBIZ-6858 > Project: OFBiz > Issue Type: Bug > Components: solr >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Pierre Smits >Assignee: Shi Jinghai >Priority: Major > Attachments: Image2.png > > > When looking at the logging screen in demo-trunk > (https://demo-trunk-ofbiz.apache.org/solr/#/~logging) no logging results are > shown. Nor does https://demo-trunk-ofbiz.apache.org/solr/#/~logging/level > provide any insights. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6858) Solr logging doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575811#comment-16575811 ] Shi Jinghai commented on OFBIZ-6858: By changing lucene and solr version to 7.4.0, this issue is gone, both [https://localhost:8443/solr/#/~logging] and [https://localhost:8443/solr/#/~logging/level] work well, so I close this issue now. Thanks Shawn! Well done. > Solr logging doesn't work > - > > Key: OFBIZ-6858 > URL: https://issues.apache.org/jira/browse/OFBIZ-6858 > Project: OFBiz > Issue Type: Bug > Components: solr >Affects Versions: Trunk, Release Branch 15.12 >Reporter: Pierre Smits >Assignee: Shi Jinghai >Priority: Major > Attachments: Image2.png > > > When looking at the logging screen in demo-trunk > (https://demo-trunk-ofbiz.apache.org/solr/#/~logging) no logging results are > shown. Nor does https://demo-trunk-ofbiz.apache.org/solr/#/~logging/level > provide any insights. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
