[jira] [Comment Edited] (OFBIZ-9241) Removes ecommerce links from applications
[ https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325725#comment-16325725 ] Jacques Le Roux edited comment on OFBIZ-9241 at 8/20/18 5:01 PM: - Thinking about that, we can simply hide the button when the ecommerce component is not present. I don't know yet for the 95 other cases which should be handled in OFBIZ-9283, this is only for ecommerce. was (Author: jacques.le.roux): Thinking about that, we can simply hide the button when the ecommerce component is not present. I don't know yet for the 95 other cases. > Removes ecommerce links from applications > - > > Key: OFBIZ-9241 > URL: https://issues.apache.org/jira/browse/OFBIZ-9241 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-9241.patch > > > While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply > entrenched in some applications components. This can at least be tested with > product and catalog webapp. > # Get to catalog/control/EditProduct?productId=GZ-1000 > # Click on the "Product Page" button => ecommerce > There are much more cases (96 occurrences actually) but most of them are not > hard dependencies. > Since the ecommerce component is now a plugin, we need to remove all > ecommerce links from applications, I even wonder if this issue is really an > improvement or should not be now considered a bug... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9241) Removes ecommerce links from applications
[ https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586210#comment-16586210 ] Jacques Le Roux edited comment on OFBIZ-9241 at 8/20/18 4:58 PM: - I have begun to work on that, with the attached patch The same should be done for other plugins, ecommerce being by far the most prominent I don't expect as work with others. I have created OFBIZ-9283 for that was (Author: jacques.le.roux): I have begun to work on that, with the attached patch The same should be done for other plugins, ecommerce being by far the most prominent I don't expect as work with others. > Removes ecommerce links from applications > - > > Key: OFBIZ-9241 > URL: https://issues.apache.org/jira/browse/OFBIZ-9241 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-9241.patch > > > While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply > entrenched in some applications components. This can at least be tested with > product and catalog webapp. > # Get to catalog/control/EditProduct?productId=GZ-1000 > # Click on the "Product Page" button => ecommerce > There are much more cases (96 occurrences actually) but most of them are not > hard dependencies. > Since the ecommerce component is now a plugin, we need to remove all > ecommerce links from applications, I even wonder if this issue is really an > improvement or should not be now considered a bug... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9241) Removes ecommerce links from applications
[ https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586210#comment-16586210 ] Jacques Le Roux commented on OFBIZ-9241: I have begun to work on that, with the attached patch The same should be done for other plugins, ecommerce being by far the most prominent I don't expect as work with others. > Removes ecommerce links from applications > - > > Key: OFBIZ-9241 > URL: https://issues.apache.org/jira/browse/OFBIZ-9241 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-9241.patch > > > While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply > entrenched in some applications components. This can at least be tested with > product and catalog webapp. > # Get to catalog/control/EditProduct?productId=GZ-1000 > # Click on the "Product Page" button => ecommerce > There are much more cases (96 occurrences actually) but most of them are not > hard dependencies. > Since the ecommerce component is now a plugin, we need to remove all > ecommerce links from applications, I even wonder if this issue is really an > improvement or should not be now considered a bug... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9241) Removes ecommerce links from applications
[ https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9241: --- Attachment: OFBIZ-9241.patch > Removes ecommerce links from applications > - > > Key: OFBIZ-9241 > URL: https://issues.apache.org/jira/browse/OFBIZ-9241 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-9241.patch > > > While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply > entrenched in some applications components. This can at least be tested with > product and catalog webapp. > # Get to catalog/control/EditProduct?productId=GZ-1000 > # Click on the "Product Page" button => ecommerce > There are much more cases (96 occurrences actually) but most of them are not > hard dependencies. > Since the ecommerce component is now a plugin, we need to remove all > ecommerce links from applications, I even wonder if this issue is really an > improvement or should not be now considered a bug... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9241) Removes ecommerce links from applications
[
https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586208#comment-16586208
]
Jacques Le Roux commented on OFBIZ-9241:
To clarify, here is the complete list of ecommerce links in framework only
code. To simplify I removed those which are commented out or not code (in
README, etc.)
{noformat}
ofbiz-framework
applications
accounting
config
payment.properties (5 matches)
426: merchantReturnURL=https://localhost:8443/ecommerce/control/idealNotify
paymentTest.properties (2 matches)
82: merchantReturnURL=https://localhost:8443/ecommerce/control/idealNotify
commonext
minilang
setup
SetupEvents.xml
490:
content
webapp
content
WEB-INF
controller.xml (5 matches)
1 973:
1 974:
1 975:
1 976:
1 977:
datamodel
data
demo
ContentDemoData.xml
222: ... o="plugins/ecommerce/data/cutekid.jpg" isPublic="Y"
createdDate="2007-01-23 16:46:22.843" createdByUserLogin="bigal"
lastModifiedDate="2007-01-23 1 ...
OrderDemoData.xml (22 matches)
240: ... omponent://ecommerce/widget/Ema ...
omponent://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNoticePdf"
subject="OFBiz Demo - Order Confirmati ...
241: ...
omponent://ecommerce/widget/EmailOrderScreens.xml#OrderCompleteNotice"
subject="OFBiz Demo - Your Order Is Complete #${orderId}" fromAddress="ofbiz
...
242: ... omponent://ecommerce/widget/EmailOrderScreens.xml#BackorderNotice"
subject="OFBiz Demo - Backorder Notification #${orderId}"
fromAddress="ofbiztest ...
243: ... omponent://ecommerce/widget/EmailOrderScreens.xml#OrderChangeNotice"
subject="OFBiz Demo - Order Change Notification #${orderId}" fromAddress="ofbi
...
244: ... omponent://ecommerce/widget/EmailOrderScreens.xml#PaymentRetryNotice"
subject="OFBiz Demo - Order Payment Notification #${orderId}" fromAddress="of
...
245: ...
omponent://ecommerce/widget/EmailOrderScreens.xml#ShipmentCompleteNotice"
subject="OFBiz Demo - Shipment Complete Notification #${orderId}" fromAdd ...
247: ... omponent://ecommerce/widget/EmailReturnScreens.xml#ReturnAccept"
subject="OFBiz Demo - Return Accepted #${returnHeader.returnId}"
xslfoAttachScreen ...
248: ... omponent://ecommerce/widget/EmailReturnScreens.xml#ReturnComplete"
subject="OFBiz Demo - Return Completed #${returnHeader.returnId}"
xslfoAttachScr ...
249: ... omponent://ecommerce/widget/EmailReturnScreens.xml#ReturnCancel"
subject="OFBiz Demo - Return Cancelled #${returnHeader.returnId}"
xslfoAttachScree ...
251:
252:
254:
266: ...
omponent://ecommerce/widget/EmailContactListScreens.xml#ContactUsEmailNotification"
subject="Contact-us Information Notification" fromAddress="ofbi ...
268: ...
omponent://ecommerce/widget/EmailContactListScreens.xml#ContactListSubscribeEmail"
subject="Subscribe Contact List" fromAddress="ofbiztest@example. ...
269: ...
omponent://ecommerce/widget/EmailContactListScreens.xml#ContactListUnsubscribeVerifyEmail"
subject="Verify Unsubscribe Contact List" fromAddress="o ...
270: ...
omponent://ecommerce/widget/EmailContactListScreens.xml#ContactListUnsubscribeEmail"
subject="Unsubscribe Contact List" fromAddress="ofbiztest@exam ...
271:
308:
1 307:
1 317:
1 320:
seed
ContentSeedData.xml (6 matches)
1 663: ... Date="2004-01-16 01:24:06.522" lastModifiedDate="2004-01-16
19:20:58.891"
objectInfo="component://ecommerce/widget/blog/BlogTemplates.xml#FloatLeft"/>
1 664: ... Date="2004-01-16 01:24:06.522" lastModifiedDate="2004-01-16
19:20:58.891"
objectInfo="component://ecommerce/widget/blog/BlogTemplates.xml#TopCenter"/>
1 666: ... 2004-01-16 01:24:06.522" lastModifiedDate="2004-01-16 19:20:58.891"
objectInfo="component://ecommerce/widget/CommonScreens.xml#CommonEmptyDecorator"/>
1 667: ... "2004-01-16 01:24:06.522" lastModifiedDate="2004-01-16
19:20:58.891"
objectInfo="component://ecommerce/widget/CommonScreens.xml#CommonLeftDecorator"/>
1 668: ... 2004-01-16 01:24:06.522" lastModifiedDate="2004-01-16 19:20:58.891"
objectInfo="component://ecommerce/widget/CommonScreens.xml#CommonRightDecorator"/>
1 669: ... -01-16 01:24:06.522" lastModifiedDate="2004-01-16 19:20:58.891"
objectInfo="component://ecommerce/widget/CommonScreens.xml#CommonLeftRightDecorator"/>
order
template
order
EditOrderItems.ftl
108: ${uiLabelMap.OrderEcommerce}
OrderItems.ftl
91: ${uiLabelMap.OrderEcommerce}
testdef
data
OrderTestData.xml (2 matches)
30: ... omponent://ecommerce/widget/Ema ...
omponent://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNoticePdf"
subject="OFBiz Demo - Order Confirmati ...
product
config
ProductUiLabels.xml (7 matches)
16 529: Besipiel:
component://ecommerce/widget/CatalogScreens.xml#categorydetail
16 530: example:
component://ecommerce/widget/CatalogScreens.xml#categorydetail
16 531: esempio:
component://ecommerce/widget/CatalogScreens.xml#categorydetail
16 532: ?:
[jira] [Commented] (OFBIZ-10528) "Last system notes" are not shown in Rainbow themes
[ https://issues.apache.org/jira/browse/OFBIZ-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586002#comment-16586002 ] Jacques Le Roux commented on OFBIZ-10528: - Yes sorry, I should have given you a link https://demo-trunk.ofbiz.apache.org/myportal. I tend to think of it as granted and forget the difference between framework and plugins. I have been too long there I guess ;) Anyway great that you can handle that now :) > "Last system notes" are not shown in Rainbow themes > --- > > Key: OFBIZ-10528 > URL: https://issues.apache.org/jira/browse/OFBIZ-10528 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Trunk, 17.12.01, 16.11.05 >Reporter: Jacques Le Roux >Priority: Major > > See this [thread > |https://lists.apache.org/thread.html/65e478f1461a2126fe8ed8aa4704ea6cdc136fe3cc1eab6b43c4491f@%3Cdev.ofbiz.apache.org%3E] > for more > Please check that it also concerns R16.11 (I guess so it put in affected > versions) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10528) "Last system notes" are not shown in Rainbow themes
[ https://issues.apache.org/jira/browse/OFBIZ-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585924#comment-16585924 ] Julien NICOLAS commented on OFBIZ-10528: Thanks ! Gil and Nicolas help me as well to find the "My Portal" app available in plugins. I can work on it now :) > "Last system notes" are not shown in Rainbow themes > --- > > Key: OFBIZ-10528 > URL: https://issues.apache.org/jira/browse/OFBIZ-10528 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Trunk, 17.12.01, 16.11.05 >Reporter: Jacques Le Roux >Priority: Major > > See this [thread > |https://lists.apache.org/thread.html/65e478f1461a2126fe8ed8aa4704ea6cdc136fe3cc1eab6b43c4491f@%3Cdev.ofbiz.apache.org%3E] > for more > Please check that it also concerns R16.11 (I guess so it put in affected > versions) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10533) Seed data sequence bug regarding "MIDNIGHT_DAILY" TemporalExpression
[ https://issues.apache.org/jira/browse/OFBIZ-10533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Becker updated OFBIZ-10533: -- Attachment: OFBIZ-10533_TemporalExpression-MIDNIGHT_DAILY.patch > Seed data sequence bug regarding "MIDNIGHT_DAILY" TemporalExpression > > > Key: OFBIZ-10533 > URL: https://issues.apache.org/jira/browse/OFBIZ-10533 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Martin Becker >Priority: Minor > Attachments: OFBIZ-10533_TemporalExpression-MIDNIGHT_DAILY.patch > > > Module framework/service: > The TemporalExpression for "MIDNIGHT_DAILY" has to be loaded as seed data > instead of initial-seed data to be available for other seed-initial usages of > this TemporalExpression. > For example the "cleanSyncRemoveInfo" service is scheduled via seed-inital > data in EntityScheduledServices.xml using this TemporalExpression, which is > not available while initializing a fresh database because it is loaded as > initial-seed data from framework/services/data/SchedulesServices.xml after > EntityScheduledServices.xml. > So i moved this TemporalExpression to the other TemporalExpression seed data > in ServiceSeedData.xml. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10533) Seed data sequence bug regarding "MIDNIGHT_DAILY" TemporalExpression
Martin Becker created OFBIZ-10533: - Summary: Seed data sequence bug regarding "MIDNIGHT_DAILY" TemporalExpression Key: OFBIZ-10533 URL: https://issues.apache.org/jira/browse/OFBIZ-10533 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Martin Becker Module framework/service: The TemporalExpression for "MIDNIGHT_DAILY" has to be loaded as seed data instead of initial-seed data to be available for other seed-initial usages of this TemporalExpression. For example the "cleanSyncRemoveInfo" service is scheduled via seed-inital data in EntityScheduledServices.xml using this TemporalExpression, which is not available while initializing a fresh database because it is loaded as initial-seed data from framework/services/data/SchedulesServices.xml after EntityScheduledServices.xml. So i moved this TemporalExpression to the other TemporalExpression seed data in ServiceSeedData.xml. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10532) Default value flags not working for configurable and variant products at the time of order entry
Deepak Nigam created OFBIZ-10532: Summary: Default value flags not working for configurable and variant products at the time of order entry Key: OFBIZ-10532 URL: https://issues.apache.org/jira/browse/OFBIZ-10532 Project: OFBiz Issue Type: New Feature Components: order Affects Versions: Trunk Reporter: Deepak Nigam On adding configurable/variant products to the cart, default value flags i.e. 'Use as default desired delivery date for next entry' and 'Use as default comment for next entry' are not working. Flags are working fine for simple products. Below are the steps to regenerate the issue: 1) Log in to 'ordermgr' with credentials admin/ofbiz. 2) Click on the 'Order Entry' menu. 3) In the 'Sales Order' section enter the values and click on the 'Continue' link. 4) Leave the fields on the next page as it is and click on the 'Continue' link. 5) Select any configurable product (e.g. pizza) or variant (e.g. WG-9943) and enter quantity. 6) Enter the 'Desired Delivery Date' and click on the adjacent checkbox 'Use as default desired delivery date for next entry'. 7) Enter the 'Comment' and click on the adjacent checkbox 'Use as default comment for next entry'. 8) Click on the 'Add To Cart' button. You will be landed on the next screen for selecting the variant or configuring the product. 9) After configuration click on 'Add To Cart' button again. Item will be added to cart but the default values will not be available for the next entry. This feature is working fine for the simple products like Tiny Gizmo (Tiny Gizmo). Most probably values are not getting persisted on the second screen for variants and configurable products and it is causing the issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585808#comment-16585808
]
Taher Alkhateeb commented on OFBIZ-10438:
-
Hey guys, sorry, for some reason while typing on the keyboard I got assigned
the task, released myself.
First of all, thank you Mathieu for your work in resolving the issue. It is
perfectly normal to debug and fix issues as we go forward.
Anyway, since Mathieu is the one who made the fix, I'm assuming Shi is not
familiar with the code he committed (and neither am I). The reason could be
that we did not take our time in reviewing and confirming this code. Unless Shi
can explain and defend his earlier and current patch instead of relying on
Mathieu, I would recommend reviewing all the work that was done here properly.
I would like to think that a committer is responsible for his/her commits, and
not merely copying someone else's work.
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png,
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585803#comment-16585803
]
Mathieu Lirzin commented on OFBIZ-10438:
So I was able to reproduce the bug and fix it in
[^OFBIZ-10438_Fix-resolveURI.patch] . The problem was caused by a mistake in
the extraction of the overridden views logic from
{{org.apache.ofbiz.webapp.control.RequestHandler.doRequest(HttpServletRequest,
HttpServletResponse, String)}} . Since there are only a few usages of this
feature I didn't detect it earlier.
Can you confirm, it works properly on your side?
Thanks [~deepak.nigam] for the report.
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png,
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Taher Alkhateeb reassigned OFBIZ-10438:
---
Assignee: Taher Alkhateeb (was: Shi Jinghai)
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Taher Alkhateeb
>Priority: Minor
> Fix For: Trunk
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png,
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Taher Alkhateeb reassigned OFBIZ-10438:
---
Assignee: Shi Jinghai (was: Taher Alkhateeb)
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png,
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10438:
---
Attachment: (was: fix-resolveURI.patch)
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png,
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10438:
---
Attachment: OFBIZ-10438_Fix-resolveURI.patch
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png,
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10438:
---
Attachment: fix-resolveURI.patch
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> URL-Error-SelectShipping.png, URL-Error-additem.png, fix-resolveURI.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"
[ https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585741#comment-16585741 ] Michael Brohl commented on OFBIZ-4361: -- [~gpierre], we will describe the functionality along with the patch. Please give us some time to prepare everything . > Any ecommerce user has the ability to reset anothers password (including > admin) via "Forget Your Password" > -- > > Key: OFBIZ-4361 > URL: https://issues.apache.org/jira/browse/OFBIZ-4361 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 11.04, Trunk > Environment: Ubuntu and others >Reporter: mz4wheeler >Assignee: Michael Brohl >Priority: Major > Labels: security > Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, > OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch > > > Currently, any user (via ecommerce "Forget Your Password") has the ability to > reset another users password, including "admin" without permission. By > simply entering "admin" and clicking "Email Password", the following is > displayed. > The following occurred: > A new password has been created and sent to you. Please check your Email. > This now forces the user of the ERP to change their password. It is also > possible to generate a dictionary attack against ofbiz because there is no > capta code required. This is serious security risk. > This feature could be reduced to a certain sub-set of users, whose login name > is optionally in the format of an email address, and maybe require a capta > code to prevent dictionary attacks. > For example, limit the feature to role "Customer" of type "Person" which was > generated via an ecommerce transaction. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-5897) ContentServicesComplex.getAssocAndContentAndDataResourceMethod and its Cache method is not consitent.
[ https://issues.apache.org/jira/browse/OFBIZ-5897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Girish Vasmatkar reassigned OFBIZ-5897: --- Assignee: Girish Vasmatkar (was: Deepak Dixit) > ContentServicesComplex.getAssocAndContentAndDataResourceMethod and its Cache > method is not consitent. > - > > Key: OFBIZ-5897 > URL: https://issues.apache.org/jira/browse/OFBIZ-5897 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Release Branch 13.07, Trunk >Reporter: Deepak Dixit >Assignee: Girish Vasmatkar >Priority: Major > > ContentServicesComplex has two method > getAssocAndContentAndDataResourceMethod and > getAssocAndContentAndDataResourceCacheMethod, these method are not > consistent. Ideally both method should have to use same mechanism to fetch > the data, only difference should be Cache method should have to use > cache=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10528) "Last system notes" are not shown in Rainbow themes
[ https://issues.apache.org/jira/browse/OFBIZ-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585621#comment-16585621 ] Jacques Le Roux commented on OFBIZ-10528: - Hi Julien, Let me clarify: you can create them using the My Portal app. See the "Create Public Message" button. > "Last system notes" are not shown in Rainbow themes > --- > > Key: OFBIZ-10528 > URL: https://issues.apache.org/jira/browse/OFBIZ-10528 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Trunk, 17.12.01, 16.11.05 >Reporter: Jacques Le Roux >Priority: Major > > See this [thread > |https://lists.apache.org/thread.html/65e478f1461a2126fe8ed8aa4704ea6cdc136fe3cc1eab6b43c4491f@%3Cdev.ofbiz.apache.org%3E] > for more > Please check that it also concerns R16.11 (I guess so it put in affected > versions) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585561#comment-16585561
]
Mathieu Lirzin commented on OFBIZ-10438:
Hello [~deepak.nigam],
I am looking at the bug you have described.
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> URL-Error-SelectShipping.png, URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10508) Remove checks to store only 250 characters of URL in VisitHandler.getVisit() & ServerHitBin.saveHit()
[
https://issues.apache.org/jira/browse/OFBIZ-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585560#comment-16585560
]
Aditya Sharma commented on OFBIZ-10508:
---
Sure Jacques. Yes, I noticed that now :)
> Remove checks to store only 250 characters of URL in VisitHandler.getVisit()
> & ServerHitBin.saveHit()
> -
>
> Key: OFBIZ-10508
> URL: https://issues.apache.org/jira/browse/OFBIZ-10508
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Major
> Fix For: 17.12.01
>
>
> Found following checks to restrict "URL" fields for Visit and ServerHit
> entity:
> When storing ServerHit using ServerHitBin.saveHit() method
>
> {code:java}
> serverHit.set("requestUrl", fullRequestUrl.length() > 250 ?
> fullRequestUrl.substring(0, 250) : fullRequestUrl);
> String referrerUrl = request.getHeader("Referer") != null ?
> request.getHeader("Referer") : "";
> serverHit.set("referrerUrl", referrerUrl.length() > 250 ?
> referrerUrl.substring(0, 250) : referrerUrl);
> {code}
> When storing Visit using VisitHandler.getVisit() method
> {code:java}
> if (initialRequest != null) visit.set("initialRequest",
> initialRequest.length() > 250 ? initialRequest.substring(0, 250) :
> initialRequest);
> if (initialReferrer != null) visit.set("initialReferrer",
> initialReferrer.length() > 250 ? initialReferrer.substring(0, 250) :
> initialReferrer);
> {code}
> When the code was committed ( [https://markmail.org/message/fgatg5qyeaibxjxk]
> ) the "URL" field type had a size of 255 characters only which was later
> changed to 2000 characters ( [https://markmail.org/message/anfree2nkyk3imln]
> ).
> So, the above code logic to restrict no of characters can be removed now.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10508) Remove checks to store only 250 characters of URL in VisitHandler.getVisit() & ServerHitBin.saveHit()
[
https://issues.apache.org/jira/browse/OFBIZ-10508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-10508:
Fix Version/s: (was: Upcoming Branch)
HI Aditya, you don't need to add Upcoming Branch when you fix a pending
release, it's already implied that's explained at https://s.apache.org/YUNw
> Remove checks to store only 250 characters of URL in VisitHandler.getVisit()
> & ServerHitBin.saveHit()
> -
>
> Key: OFBIZ-10508
> URL: https://issues.apache.org/jira/browse/OFBIZ-10508
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Major
> Fix For: 17.12.01
>
>
> Found following checks to restrict "URL" fields for Visit and ServerHit
> entity:
> When storing ServerHit using ServerHitBin.saveHit() method
>
> {code:java}
> serverHit.set("requestUrl", fullRequestUrl.length() > 250 ?
> fullRequestUrl.substring(0, 250) : fullRequestUrl);
> String referrerUrl = request.getHeader("Referer") != null ?
> request.getHeader("Referer") : "";
> serverHit.set("referrerUrl", referrerUrl.length() > 250 ?
> referrerUrl.substring(0, 250) : referrerUrl);
> {code}
> When storing Visit using VisitHandler.getVisit() method
> {code:java}
> if (initialRequest != null) visit.set("initialRequest",
> initialRequest.length() > 250 ? initialRequest.substring(0, 250) :
> initialRequest);
> if (initialReferrer != null) visit.set("initialReferrer",
> initialReferrer.length() > 250 ? initialReferrer.substring(0, 250) :
> initialReferrer);
> {code}
> When the code was committed ( [https://markmail.org/message/fgatg5qyeaibxjxk]
> ) the "URL" field type had a size of 255 characters only which was later
> changed to 2000 characters ( [https://markmail.org/message/anfree2nkyk3imln]
> ).
> So, the above code logic to restrict no of characters can be removed now.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9241) Removes ecommerce links from applications
[ https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9241: -- Assignee: Jacques Le Roux > Removes ecommerce links from applications > - > > Key: OFBIZ-9241 > URL: https://issues.apache.org/jira/browse/OFBIZ-9241 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > > While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply > entrenched in some applications components. This can at least be tested with > product and catalog webapp. > # Get to catalog/control/EditProduct?productId=GZ-1000 > # Click on the "Product Page" button => ecommerce > There are much more cases (96 occurrences actually) but most of them are not > hard dependencies. > Since the ecommerce component is now a plugin, we need to remove all > ecommerce links from applications, I even wonder if this issue is really an > improvement or should not be now considered a bug... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585460#comment-16585460
]
Shi Jinghai commented on OFBIZ-10438:
-
Thank you Deepak!
I can reproduce the error now.
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> URL-Error-SelectShipping.png, URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
>
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
