[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

2018-08-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595958#comment-16595958
 ] 

Jacques Le Roux commented on OFBIZ-7598:


Hi Suraj, Gil,

Thank you for your last patches. I reviewed both (compared them actually) and I 
think this is ready to commit. I did not test again, I suppose it's OK. 

Gil, your idea of using the Flexible string expander this way is new (to me at 
least, no occurences OOTB either) and interesting.

> Empty header row should not render if list to render in file is empty
> -
>
> Key: OFBIZ-7598
> URL: https://issues.apache.org/jira/browse/OFBIZ-7598
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Image 002.png, OFBIZ-7598-final-proposal.patch, 
> OFBIZ-7598-final.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, 
> OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png, 
> OFBIZ-7598_improvement.patch, OFBIZ-7598_improvement.patch
>
>
> If list inside form doesn't contain data, then header row should not render 
> from better UI perspective and proper message should be shown to user.
> Please refer screenshot for details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9833) Token Based Authentication

2018-08-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595952#comment-16595952
 ] 

Jacques Le Roux commented on OFBIZ-9833:


Hi Nicolas,

Thanks for your review, which confirms mine but for the controller. I see this 
as a basic tool, so why do you want entries in the controller?

I like the idea of a temporary secret. I also put some suggestions at bottom of 
OFBIZ-10307 after Jacopo's feedback there. I think we should now discuss this 
on dev ML in order to centralise the discussion.



> Token Based Authentication
> --
>
> Key: OFBIZ-9833
> URL: https://issues.apache.org/jira/browse/OFBIZ-9833
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: JSON Web Tokens.pdf, OFBIZ-9833-JWTManager.patch, Token 
> Based Authentication in Apache OfBiz.pdf, Token Based Authentication.pdf, 
> rfc7519.pdf
>
>
> Here is dev list discussion for token based authentication work:
> http://markmail.org/message/vyskeh2wujqpkbwg



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10534) 'Reserve After Date' for order items

2018-08-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595950#comment-16595950
 ] 

Jacques Le Roux commented on OFBIZ-10534:
-

It looks good to me, I just wonder if we should not show the default "Reserve 
After Date" when creating the order, like we show the default "Ship 
After/Before Dates"

> 'Reserve After Date' for order items
> 
>
> Key: OFBIZ-10534
> URL: https://issues.apache.org/jira/browse/OFBIZ-10534
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order, product
>Reporter: Deepak Nigam
>Priority: Major
> Attachments: OFBiz-10534-reserve-after-date.patch, 
> OFBiz-10534-reserve-after-date.patch, ReserveAfterDate1.png, 
> ReserveAfterDate2.png, ReserveAfterDate3.png, ReserveAfterDate4.png
>
>
> While creating orders from the backend, we have the option to set parameters 
> like 'Ship After Date' and 'Ship Before Date' to manage the fulfilment cycle 
> more efficiently. Inventory gets reserved for the product based on a FIFO 
> basis. Sometimes the fulfilment time for the order is high and inventory 
> unnecessarily gets locked for some time period.
>  
> We can introduce a new parameter (at order item level) 'Reserve After Date' 
> which will indicate the date only after which reservation can happen. In this 
> way, we can manage the stock availability more efficiently.
>  
> This issue relates to OFBIZ-10518
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10542) Instructions for Configurable PC don't work

2018-08-28 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-10542:
---

 Summary: Instructions for Configurable PC don't work
 Key: OFBIZ-10542
 URL: https://issues.apache.org/jira/browse/OFBIZ-10542
 Project: OFBiz
  Issue Type: Bug
  Components: ecommerce
Affects Versions: 16.11.04, Trunk, Release Branch 17.12
Reporter: Jacques Le Roux


This concerns only R16, R17 and the trunk. The "Instructions" button was not 
present in R13. 

This kind of message shows:
Trunk:
Instructions
R16:
Instructions

The same exists for all configurable products, notably Gold Pizza



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10535) Configurable PC: adding or verifying does not work, maybe more issues...

2018-08-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10535.
---
   Resolution: Fixed
 Assignee: Jacques Le Roux
Fix Version/s: Upcoming Branch

This was broken by OFBIZ-10438, last patch from Mathieu fixed it

> Configurable PC: adding or verifying does not work, maybe more issues...
> 
>
> Key: OFBIZ-10535
> URL: https://issues.apache.org/jira/browse/OFBIZ-10535
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecomseo/product/Configurable-PC-PC001.html
> in both case you get a 404, same locally of course



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10438.
---
   Resolution: Fixed
Fix Version/s: (was: Trunk)
   Upcoming Branch

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch, 
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch, 
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch, 
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png, 
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595214#comment-16595214
 ] 

Jacques Le Roux commented on OFBIZ-10438:
-

Thanks Mathieu,

I confirm this issue is fixed with [^OFBIZ-10438_Fix-resolveURI.patch]. The 
problem was r1838081 prevented to serialise requests.

Like in ordermgr/control/updateCheckoutOptions/quickcheckout where 
updateCheckoutOptions and quickcheckout are serialised to update the check out 
after updateCheckoutOptions is done and then get back to the screen with 
quickcheckout.

CheckoutOptions.ftl is a good example of this usage.

I'm not sure if the best way to describe this feature is to say that the view 
is overridden as you comment in your patch. I would rather say that the views 
are serialised. But that's OK with me, it makes also sense, and I don't want to 
be nitpicky today :)

I committed at revision: 1839451  


> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: 
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch, 
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch, 
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch, 
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png, 
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-28 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10438:
---

Assignee: Jacques Le Roux  (was: Shi Jinghai)

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: 
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch, 
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch, 
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch, 
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png, 
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7037) Have QRCodeServices.java use EntityUtilProperties

2018-08-28 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594929#comment-16594929
 ] 

Suraj Khurana commented on OFBIZ-7037:
--

Thanks Deepak for your suggestions.

I have attached an updated patch. Can you please have a look into it.

> Have QRCodeServices.java use EntityUtilProperties
> -
>
> Key: OFBIZ-7037
> URL: https://issues.apache.org/jira/browse/OFBIZ-7037
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-7037.patch, OFBIZ-7037.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7037) Have QRCodeServices.java use EntityUtilProperties

2018-08-28 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7037:
-
Attachment: OFBIZ-7037.patch

> Have QRCodeServices.java use EntityUtilProperties
> -
>
> Key: OFBIZ-7037
> URL: https://issues.apache.org/jira/browse/OFBIZ-7037
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-7037.patch, OFBIZ-7037.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7037) Have QRCodeServices.java use EntityUtilProperties

2018-08-28 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7037:
-
Attachment: (was: OFBIZ-7037)

> Have QRCodeServices.java use EntityUtilProperties
> -
>
> Key: OFBIZ-7037
> URL: https://issues.apache.org/jira/browse/OFBIZ-7037
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-7037.patch, OFBIZ-7037.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7037) Have QRCodeServices.java use EntityUtilProperties

2018-08-28 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7037:
-
Attachment: OFBIZ-7037

> Have QRCodeServices.java use EntityUtilProperties
> -
>
> Key: OFBIZ-7037
> URL: https://issues.apache.org/jira/browse/OFBIZ-7037
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-7037.patch, OFBIZ-7037.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10541) Add a gradle task to compile less files in css and minify

2018-08-28 Thread Dennis Balkir (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594833#comment-16594833
 ] 

Dennis Balkir edited comment on OFBIZ-10541 at 8/28/18 11:07 AM:
-

Hi [~julien.nicolas],
the file "minify_gradle.patch" contains the gradle task which Michael Brohl 
mentioned.
We use this in the plug-in folder, but it can easily be extended to work with 
whole OFBiz. We had a discussion here, on how it should be used. That's the 
reason why this needs a list in form of a .txt file. In this file you have to 
specify the paths of the files you want to minify. This makes it possible to 
accurately define which files should be minified and which should be left out.

Unfortunately there is no mechanism to compile less or sass files in it, but 
this will compress css and js files to min.css and min.js.

Hope this helps


was (Author: dennis balkir):
Hi [~julien.nicolas],
this is the gradle task which Michael Brohl mentioned.
We use this in the plug-in folder, but it can easily be extended to work with 
whole OFBiz. We had a discussion here, on how it should be used. That's the 
reason why this needs a list in form of a .txt file. In this file you have to 
specify the paths of the files you want to minify. This makes it possible to 
accurately define which files should be minified and which should be left out.

Unfortunately there is no mechanism to compile less or sass files in it, but 
this will compress css and js files to min.css and min.js.

Hope this helps

> Add a gradle task to compile less files in css and minify
> -
>
> Key: OFBIZ-10541
> URL: https://issues.apache.org/jira/browse/OFBIZ-10541
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Trivial
> Attachments: minify_gradlew.patch
>
>
> For theme optimization, I would like to compile less files to css file.
> In this way, we can remove the js compilation script from theme.
> In the same times, I propose to minify and compress css files.
> For debugging, css files will not be compress nor minified.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10541) Add a gradle task to compile less files in css and minify

2018-08-28 Thread Dennis Balkir (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594833#comment-16594833
 ] 

Dennis Balkir commented on OFBIZ-10541:
---

Hi [~julien.nicolas],
this is the gradle task which Michael Brohl mentioned.
We use this in the plug-in folder, but it can easily be extended to work with 
whole OFBiz. We had a discussion here, on how it should be used. That's the 
reason why this needs a list in form of a .txt file. In this file you have to 
specify the paths of the files you want to minify. This makes it possible to 
accurately define which files should be minified and which should be left out.

Unfortunately there is no mechanism to compile less or sass files in it, but 
this will compress css and js files to min.css and min.js.

Hope this helps

> Add a gradle task to compile less files in css and minify
> -
>
> Key: OFBIZ-10541
> URL: https://issues.apache.org/jira/browse/OFBIZ-10541
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Trivial
> Attachments: minify_gradlew.patch
>
>
> For theme optimization, I would like to compile less files to css file.
> In this way, we can remove the js compilation script from theme.
> In the same times, I propose to minify and compress css files.
> For debugging, css files will not be compress nor minified.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10541) Add a gradle task to compile less files in css and minify

2018-08-28 Thread Dennis Balkir (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10541:
--
Attachment: minify_gradlew.patch

> Add a gradle task to compile less files in css and minify
> -
>
> Key: OFBIZ-10541
> URL: https://issues.apache.org/jira/browse/OFBIZ-10541
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Trivial
> Attachments: minify_gradlew.patch
>
>
> For theme optimization, I would like to compile less files to css file.
> In this way, we can remove the js compilation script from theme.
> In the same times, I propose to minify and compress css files.
> For debugging, css files will not be compress nor minified.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9833) Token Based Authentication

2018-08-28 Thread Nicolas Malin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594702#comment-16594702
 ] 

Nicolas Malin commented on OFBIZ-9833:
--

Hello,

I reviewed the path and this solution take a good way :)

I found just the token generation a little weak, maybe we can improve this part 
with a multiple key generation :
 * generate a key at the fly stored in database enable during the token life 
time
 * use the key on security properties or resolve it from java keystore
 * use the key stored on delegator definition in entityengine.xml
 * concat and hash them and use the result as encrypted key to generate the 
token

With this to success an attack you need to access to the server file and 
database continuously, otherwise if a secret key is corrupt all login will be 
corrupt

A last point, they missing the controller entries to use it

Thanks for this works !

> Token Based Authentication
> --
>
> Key: OFBIZ-9833
> URL: https://issues.apache.org/jira/browse/OFBIZ-9833
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: JSON Web Tokens.pdf, OFBIZ-9833-JWTManager.patch, Token 
> Based Authentication in Apache OfBiz.pdf, Token Based Authentication.pdf, 
> rfc7519.pdf
>
>
> Here is dev list discussion for token based authentication work:
> http://markmail.org/message/vyskeh2wujqpkbwg



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

2018-08-28 Thread Gil Portenseigne (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594686#comment-16594686
 ] 

Gil Portenseigne commented on OFBIZ-7598:
-

Hello [~suraj.khurana], 
There remains a Boolean in your patch. I'll propose you a last update to your 
patch too manage i18n. Using Flexible string expander, the message can be 
internationalized. 

Using default value in xsd simplify the java code beneath :) 

WDYT ? 



> Empty header row should not render if list to render in file is empty
> -
>
> Key: OFBIZ-7598
> URL: https://issues.apache.org/jira/browse/OFBIZ-7598
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Image 002.png, OFBIZ-7598-final-proposal.patch, 
> OFBIZ-7598-final.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, 
> OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png, 
> OFBIZ-7598_improvement.patch, OFBIZ-7598_improvement.patch
>
>
> If list inside form doesn't contain data, then header row should not render 
> from better UI perspective and proper message should be shown to user.
> Please refer screenshot for details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7598) Empty header row should not render if list to render in file is empty

2018-08-28 Thread Gil Portenseigne (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne updated OFBIZ-7598:

Attachment: OFBIZ-7598-final-proposal.patch

> Empty header row should not render if list to render in file is empty
> -
>
> Key: OFBIZ-7598
> URL: https://issues.apache.org/jira/browse/OFBIZ-7598
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Image 002.png, OFBIZ-7598-final-proposal.patch, 
> OFBIZ-7598-final.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.patch, 
> OFBIZ-7598.patch, OFBIZ-7598.patch, OFBIZ-7598.png, 
> OFBIZ-7598_improvement.patch, OFBIZ-7598_improvement.patch
>
>
> If list inside form doesn't contain data, then header row should not render 
> from better UI perspective and proper message should be shown to user.
> Please refer screenshot for details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10541) Add a gradle task to compile less files in css and minify

2018-08-28 Thread Julien NICOLAS (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594646#comment-16594646
 ] 

Julien NICOLAS commented on OFBIZ-10541:


Hi [~mbrohl],

Good news, I have to develop a solution because our current solution use Gulp 
instead of Gradle.

If you have it already done, and if you could share it \o/ \o/

Maybe you could attach a patch ?

Thanks !

> Add a gradle task to compile less files in css and minify
> -
>
> Key: OFBIZ-10541
> URL: https://issues.apache.org/jira/browse/OFBIZ-10541
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Trivial
>
> For theme optimization, I would like to compile less files to css file.
> In this way, we can remove the js compilation script from theme.
> In the same times, I propose to minify and compress css files.
> For debugging, css files will not be compress nor minified.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10541) Add a gradle task to compile less files in css and minify

2018-08-28 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594639#comment-16594639
 ] 

Michael Brohl commented on OFBIZ-10541:
---

Hi [~julien.nicolas],

we already have a productive solution for this which we can provide. Just to 
let you know in case you have to develop a solution.

> Add a gradle task to compile less files in css and minify
> -
>
> Key: OFBIZ-10541
> URL: https://issues.apache.org/jira/browse/OFBIZ-10541
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Trivial
>
> For theme optimization, I would like to compile less files to css file.
> In this way, we can remove the js compilation script from theme.
> In the same times, I propose to minify and compress css files.
> For debugging, css files will not be compress nor minified.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)