[jira] [Created] (OFBIZ-10577) New Feature: Inventory Cycle Count

2018-09-21 Thread Yashwant Dhakad (JIRA)
Yashwant Dhakad created OFBIZ-10577:
---

 Summary: New Feature: Inventory Cycle Count
 Key: OFBIZ-10577
 URL: https://issues.apache.org/jira/browse/OFBIZ-10577
 Project: OFBiz
  Issue Type: New Feature
Reporter: Yashwant Dhakad


*Here are the design notes for cycle count workflow:*

*Find Session Screen:* In this screen, we will show all the sessions created in 
the system with respect to the facility, locations, inventory count item, 
current status, and created date. We have a search field to filter the records 
on the basis of the facility, status.

*Find Pending Locations:* In this screen, we have a table listing all the 
pending locations whose countings are pending and we can create a session for 
them. All details regarding the pending locations are listed here with the 
location, next count date, last count date and days extended for the count, 
total inventory item and product for this location. We have facets for 
filtering the records on the basis of the facility, not scanned since and 
scheduled for next scan. Also, we have a global search at the top of the 
screen. In Pending Locations screen, we have a Create Session button. To create 
a session we can either select one or more records from the below list or 
create a new session by yourself.

In Create Session screen, the basic overview is shown in the "Overview" section 
and the items are listed in the "Items" section. We can create a new line item 
by clicking on the 'Add' button and we can also update the item quantity. After 
completing this, we can proceed with this session and mark it with 'Pending for 
Review' status from the 'Status' button at the top of the screen or we can 
simply 'Reject'. 'Reject' status button is available at the top of the screen.

*Find Review Screen:* In this screen, we have a table listing all the locations 
pending for the review. All the details regarding the review sessions are 
listed with the facility, locations and counted inventory item. We have facets 
for filtering records on the basis of the facility. By clicking any session we 
can go to its detail screen, where basic details regarding this session are 
listed in the 'Overview' section and items are listed in the 'Items' section. 
We can select any number of rows and mark them as 'Accept' or 'Reject'. When 
these items are marked as 'Accepted' then the variance is created and these are 
added in the Count Progress report. Only authorized persons can accept or 
reject the sessions and once the session is accepted it is marked as 
'Completed'.

*4. Count Progress Report:* In this screen, User can view the advanced counting 
related analytics with respect to all the 'Completed' status session from 
Reports Screen. We can filter the records on the basis of the facility and 
within the date range. We can also see the percentage of the total locations, 
inventory items counted and errors occurred during the process. Item variance 
details are listed in the below section in tabular form.

Following changes to the existing data model to support end to end counting 
process flow:

*New entities:*

*InventoryCount*
  inventoryCountId
  uploadedByUserLogin
  facilityId
  statusId@Mention someone by typing their name...
  createdDatetime
*InventoryCountItem*
  inventoryCountId
  inventoryCountItemSeqId
  inventoryItemId
  itemStatusId
  locationSeqId
  productId
  productIdentifier
  quantity
*InventoryCountVariance* 
  inventoryCountId
  inventoryCountItemSeqId
  inventoryItemId
  productId
  productIdentifier
  locationSeqId
  systemQuantityOnHand
  actualQuantityOnHand
  varianceQuantityOnHand
  totalCost
  actualCost
  costVariance
  actualValue
  totalValue
  valueVariance
  unitCost
*ProductCategoryFacilityLocation*
  facilityId
  locationSeqId
  productCategoryId
  fromDate
  thruDate
  isCountable
**

*Extended entity:*
*FacilityLocation*
  locked
  lastCountDate
  nextCountDate
*ProductCategory*
  isCountable

We will prevent following inbound and outbound transactions within the 
application if the location is locked for counting:
Inventory Transfer 
Issuance against Sales Order 
Sales Return receiving 
Inventory receive 
Issuance and return inventory in manufacturing Job
Kit breakup 
Update Location 
Physical Variance creation

The locked locations won’t have any bearing on the transactions that are 
affecting the only ATP of parts i.e. Reserving component for Jobs/Sales Orders 
etc. as they don’t affect QOH in any way.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10314) Multiple rows are getting created on updating Party details

2018-09-21 Thread Shikha Jaiswal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shikha Jaiswal reassigned OFBIZ-10314:
--

Assignee: (was: Shikha Jaiswal)

> Multiple rows are getting created on updating Party details
> ---
>
> Key: OFBIZ-10314
> URL: https://issues.apache.org/jira/browse/OFBIZ-10314
> Project: OFBiz
>  Issue Type: Bug
>  Components: webpos
> Environment: 
> [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
>  
>Reporter: Archana Asthana
>Priority: Major
> Attachments: EditPartydetails.png
>
>
> Steps to regenerate:
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Click Search Button to search Party
> In the opened modal, check the box of any customer
> Another model gets open to update the detail
> Enter the required detail/s and click update
> Multiple rows of the same customer are getting created in the Party search 
> Modal
> Image is attached for reference.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10314) Multiple rows are getting created on updating Party details

2018-09-21 Thread Shikha Jaiswal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shikha Jaiswal reassigned OFBIZ-10314:
--

Assignee: Shikha Jaiswal

> Multiple rows are getting created on updating Party details
> ---
>
> Key: OFBIZ-10314
> URL: https://issues.apache.org/jira/browse/OFBIZ-10314
> Project: OFBiz
>  Issue Type: Bug
>  Components: webpos
> Environment: 
> [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
>  
>Reporter: Archana Asthana
>Assignee: Shikha Jaiswal
>Priority: Major
> Attachments: EditPartydetails.png
>
>
> Steps to regenerate:
> Open [https://demo-trunk.ofbiz.apache.org/webpos/control/Login]
> Click Search Button to search Party
> In the opened modal, check the box of any customer
> Another model gets open to update the detail
> Enter the required detail/s and click update
> Multiple rows of the same customer are getting created in the Party search 
> Modal
> Image is attached for reference.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10555) User should not be able to place order with zero item quantity

2018-09-21 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10555.
-

> User should not be able to place order with zero item quantity
> --
>
> Key: OFBIZ-10555
> URL: https://issues.apache.org/jira/browse/OFBIZ-10555
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-10555.patch
>
>
> As per discussion on Dev ML:
> [https://markmail.org/thread/dqsyobtcrdomhy7o]
> Currently, user can add items to cart with zero quantity and place order, we 
> need to check cart before placing order and remove items with zero quantity 
> from it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7517) Checkbox and Radio buttons should get selected on clicking upon their labels.

2018-09-21 Thread Chandrashekhar Dhakad (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandrashekhar Dhakad reassigned OFBIZ-7517:


Assignee: Divesh Dutta  (was: Chandrashekhar Dhakad)

> Checkbox and Radio buttons should get selected on clicking upon their labels.
> -
>
> Key: OFBIZ-7517
> URL: https://issues.apache.org/jira/browse/OFBIZ-7517
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 16.11.01
>Reporter: Ratnesh Upadhyay
>Assignee: Divesh Dutta
>Priority: Major
>
> This is a placeholder ticket to change the interaction of check box and radio 
> button. We will create application wise sub task. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7517) Checkbox and Radio buttons should get selected on clicking upon their labels.

2018-09-21 Thread Chandrashekhar Dhakad (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandrashekhar Dhakad reassigned OFBIZ-7517:


Assignee: Chandrashekhar Dhakad  (was: Divesh Dutta)

> Checkbox and Radio buttons should get selected on clicking upon their labels.
> -
>
> Key: OFBIZ-7517
> URL: https://issues.apache.org/jira/browse/OFBIZ-7517
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 16.11.01
>Reporter: Ratnesh Upadhyay
>Assignee: Chandrashekhar Dhakad
>Priority: Major
>
> This is a placeholder ticket to change the interaction of check box and radio 
> button. We will create application wise sub task. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10465) Using "buttontext" styling for buttons inside the ListEntities table

2018-09-21 Thread Garima jain (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624499#comment-16624499
 ] 

Garima jain commented on OFBIZ-10465:
-

Verified the Attached patch, the changes look good.

> Using "buttontext" styling for buttons inside the ListEntities table
> 
>
> Key: OFBIZ-10465
> URL: https://issues.apache.org/jira/browse/OFBIZ-10465
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Dennis Balkir
>Assignee: Garima jain
>Priority: Minor
> Attachments: buttons1.png, buttons2.png, buttons3.png, buttons4.png, 
> listEntities_buttons.patch
>
>
> I think it would be a good idea, to use the "buttontext" styling for the 
> buttons inside the lines of the ListEntities table.
> This way the links will look like buttons, and it will be more obvious, that 
> these are single clickable elements.
> I added some screenshots for all themes with the buttons.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10496) Defective inventories are valuating in Inventory valuation report

2018-09-21 Thread Amit Gadaley (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley updated OFBIZ-10496:
-
Attachment: (was: OFBIZ-10496.patch)

> Defective inventories are valuating in Inventory valuation report 
> --
>
> Key: OFBIZ-10496
> URL: https://issues.apache.org/jira/browse/OFBIZ-10496
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Assignee: Amit Gadaley
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-10496.patch
>
>
> Inventory items with status 'INV_NS_DEFECTIVE' and 'INV_DEFECTIVE' are also 
> included in the inventory valuation report.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10496) Defective inventories are valuating in Inventory valuation report

2018-09-21 Thread Amit Gadaley (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley updated OFBIZ-10496:
-
Attachment: OFBIZ-10496.patch

> Defective inventories are valuating in Inventory valuation report 
> --
>
> Key: OFBIZ-10496
> URL: https://issues.apache.org/jira/browse/OFBIZ-10496
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Assignee: Amit Gadaley
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-10496.patch
>
>
> Inventory items with status 'INV_NS_DEFECTIVE' and 'INV_DEFECTIVE' are also 
> included in the inventory valuation report.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10570) Requirement is created for wrong facility

2018-09-21 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10570.
-

> Requirement is created for wrong facility
> -
>
> Key: OFBIZ-10570
> URL: https://issues.apache.org/jira/browse/OFBIZ-10570
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-10570.patch
>
>
> Design description:
> In service _createAutoRequirementsForOrder_ ProductStore.inventoryFacilityId 
> is directly used for creating requirement.
> Here, an order can have multiple ship group and each ship group can be 
> fulfilled from various facilities, so instead of creating requirement for 
> ProductStore.inventoryFacilityId, it should create requirement using 
> OrderItemShipGroup.facilityId. If not found, we can have an additional check 
> to use orderHeader.facilityId.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10570) Requirement is created for wrong facility

2018-09-21 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624475#comment-16624475
 ] 

Suraj Khurana commented on OFBIZ-10570:
---

Thanks Jacques,

This has been committed to trunk at rev #1841644.

> Requirement is created for wrong facility
> -
>
> Key: OFBIZ-10570
> URL: https://issues.apache.org/jira/browse/OFBIZ-10570
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-10570.patch
>
>
> Design description:
> In service _createAutoRequirementsForOrder_ ProductStore.inventoryFacilityId 
> is directly used for creating requirement.
> Here, an order can have multiple ship group and each ship group can be 
> fulfilled from various facilities, so instead of creating requirement for 
> ProductStore.inventoryFacilityId, it should create requirement using 
> OrderItemShipGroup.facilityId. If not found, we can have an additional check 
> to use orderHeader.facilityId.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9490) Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and formatting can be done, rather than system providing all ruleset support.

2018-09-21 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9490:
---

Assignee: Arun Patidar  (was: Pradhan Yash Sharma)

> Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and 
> formatting can be done, rather than system providing all ruleset support.
> --
>
> Key: OFBIZ-9490
> URL: https://issues.apache.org/jira/browse/OFBIZ-9490
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: 16.11.03
>Reporter: Pradhan Yash Sharma
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9490.patch, OFBIZ_9490.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9768) While converting the lead, it redirects to the Create Party Relationship in SFA component

2018-09-21 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-9768:


Assignee: Suraj Khurana  (was: Ujjawal Solanki)

> While converting the lead, it redirects to the Create Party Relationship in 
> SFA component
> -
>
> Key: OFBIZ-9768
> URL: https://issues.apache.org/jira/browse/OFBIZ-9768
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Rubia Elza Joshep
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> Steps to regenerate:
> 1) Open URL 
> https://demo-trunk.ofbiz.apache.org/sfa/control/viewprofile?roleTypeId=LEAD=10007
> 2) Click on Convert lead and select the related company and click on Add.
> 3) It redirects to the Create Party Relationship.
> Expected: It should redirect to the Lead conversion page since the company is 
> associated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-21 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-10518:
-
Attachment: OFBiz-10518.patch

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, CreateAllocationPlanEditMode-Step2.png, 
> EditAllocationPlan.png, FindAllocationPlan.png, OFBiz-10518.patch, 
> OFBiz-10518.patch, ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-7481) ProductFacility record must exist before creating inventoryItem for a facility

2018-09-21 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623280#comment-16623280
 ] 

Swapnil M Mane edited comment on OFBIZ-7481 at 9/21/18 8:43 AM:


Discussion related to this issue is also done on dev list 
[https://s.apache.org/3rFz]
Commenting here link, just for future references.


was (Author: swapnilmmane):
Discussion related to this issue is also done on dev list 
https://s.apache.org/3rFz
Committing here link, just for future references.

> ProductFacility record must exist before creating inventoryItem for a facility
> --
>
> Key: OFBIZ-7481
> URL: https://issues.apache.org/jira/browse/OFBIZ-7481
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: 14.12.01, 16.11.01, 15.12.01, 13.07.04
>Reporter: Suraj Khurana
>Assignee: Vaibhav Jain
>Priority: Major
>
> ProductFacility entity is used to decide that  a particular  product is 
> maintained in which facility. So, in case of receiving a product in a 
> facility or in case creating InventoryItem for a facility, the 
> ProductFacility record must exist. But in these cases, currently in OFBiz 
> inventoryItem gets created even if ProductFacility record doesn't exist.
> Proposed solution:
> 1) In receiveInventoryProduct service check and create ProductFacility record 
> if not exist.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7481) ProductFacility record must exist before creating inventoryItem for a facility

2018-09-21 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623280#comment-16623280
 ] 

Swapnil M Mane commented on OFBIZ-7481:
---

Discussion related to this issue is also done on dev list 
https://s.apache.org/3rFz
Committing here link, just for future references.

> ProductFacility record must exist before creating inventoryItem for a facility
> --
>
> Key: OFBIZ-7481
> URL: https://issues.apache.org/jira/browse/OFBIZ-7481
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: 14.12.01, 16.11.01, 15.12.01, 13.07.04
>Reporter: Suraj Khurana
>Assignee: Vaibhav Jain
>Priority: Major
>
> ProductFacility entity is used to decide that  a particular  product is 
> maintained in which facility. So, in case of receiving a product in a 
> facility or in case creating InventoryItem for a facility, the 
> ProductFacility record must exist. But in these cases, currently in OFBiz 
> inventoryItem gets created even if ProductFacility record doesn't exist.
> Proposed solution:
> 1) In receiveInventoryProduct service check and create ProductFacility record 
> if not exist.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2018-09-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623267#comment-16623267
 ] 

Jacques Le Roux commented on OFBIZ-7147:


Hi Vikas,

OK done, with some cleanup here

> Remove parentTypeId from InvoiceType data where InvoiceTypeId and 
> parentTypeId are equal
> 
>
> Key: OFBIZ-7147
> URL: https://issues.apache.org/jira/browse/OFBIZ-7147
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Arun Patidar
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7147.patch
>
>
> In InvoiceType data, we have invoiceTypeId value with same parentTypeId. 
> Please refer AccountingTypeData.xml.
>  invoiceTypeId="PURCHASE_INVOICE"  parentTypeId="PURCHASE_INVOICE"/>
>  invoiceTypeId="SALES_INVOICE" parentTypeId="SALES_INVOICE"/>
> Here, invoiceTypeId="PURCHASE_INVOICE"  has "PURCHASE_INVOICE" as its 
> parentTypeId. Same applies for invoiceTypeId="SALES_INVOICE" 
> This also causes issue of infinite loop with EntityTypeUtil.hasParentType() 
> method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2018-09-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313622#comment-15313622
 ] 

Jacques Le Roux edited comment on OFBIZ-7147 at 9/21/18 8:25 AM:
-

Backported in R13.07 at r1746670


was (Author: jacques.le.roux):
Backported in R13.07 at r1746459

> Remove parentTypeId from InvoiceType data where InvoiceTypeId and 
> parentTypeId are equal
> 
>
> Key: OFBIZ-7147
> URL: https://issues.apache.org/jira/browse/OFBIZ-7147
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Arun Patidar
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7147.patch
>
>
> In InvoiceType data, we have invoiceTypeId value with same parentTypeId. 
> Please refer AccountingTypeData.xml.
>  invoiceTypeId="PURCHASE_INVOICE"  parentTypeId="PURCHASE_INVOICE"/>
>  invoiceTypeId="SALES_INVOICE" parentTypeId="SALES_INVOICE"/>
> Here, invoiceTypeId="PURCHASE_INVOICE"  has "PURCHASE_INVOICE" as its 
> parentTypeId. Same applies for invoiceTypeId="SALES_INVOICE" 
> This also causes issue of infinite loop with EntityTypeUtil.hasParentType() 
> method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2018-09-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311731#comment-15311731
 ] 

Jacques Le Roux edited comment on OFBIZ-7147 at 9/21/18 8:15 AM:
-

Hi [~jacques.le.roux]

This should fix with the patch attached on ticket OFBIZ-7124. I am testing and 
committing that patch as well.


was (Author: arunpati):
Hi [~jacques.le.roux]

This should fix with the patch attached on ticket 
https://issues.apache.org/jira/browse/OFBIZ-7124. I am testing and committing 
that patch as well.

> Remove parentTypeId from InvoiceType data where InvoiceTypeId and 
> parentTypeId are equal
> 
>
> Key: OFBIZ-7147
> URL: https://issues.apache.org/jira/browse/OFBIZ-7147
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Arun Patidar
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 14.12.01, 15.12.01, 13.07.04
>
> Attachments: OFBIZ-7147.patch
>
>
> In InvoiceType data, we have invoiceTypeId value with same parentTypeId. 
> Please refer AccountingTypeData.xml.
>  invoiceTypeId="PURCHASE_INVOICE"  parentTypeId="PURCHASE_INVOICE"/>
>  invoiceTypeId="SALES_INVOICE" parentTypeId="SALES_INVOICE"/>
> Here, invoiceTypeId="PURCHASE_INVOICE"  has "PURCHASE_INVOICE" as its 
> parentTypeId. Same applies for invoiceTypeId="SALES_INVOICE" 
> This also causes issue of infinite loop with EntityTypeUtil.hasParentType() 
> method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10575) Move 'SecurityPermission' data to seed data files

2018-09-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622142#comment-16622142
 ] 

Jacques Le Roux edited comment on OFBIZ-10575 at 9/21/18 7:38 AM:
--

Hi Deepak, All,

Should not all security data be demo but seed? I noticed we have in plugins 
some other demodata files with SecurityPermission in.

And what about SecurityGroupPermission data? They are mixed in demo and seed 
data files, all over the place.

Maybe we need to discuss that on dev ML?


was (Author: jacques.le.roux):
Hi Deepak, All,

Should not all security data be demo but seed? I noticed we have in plugins 
some other demodata files with SecurityPermission in.

And what about SecurityGroupPermission data? They are mixed in demo and see 
data files, all over the place.

Maybe we need to discuss that on dev ML?

> Move 'SecurityPermission' data to seed data files
> -
>
> Key: OFBIZ-10575
> URL: https://issues.apache.org/jira/browse/OFBIZ-10575
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres, securityext
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Minor
>
> HumanresDemoData.xml file contains the following data:
>  permissionId="EMPLOYEE_VIEW"/>
> SecurityGroupDemoData.xml file contains the following data:
> 
>  
> Above mentioned data is seed data, so we should remove it from demo data 
> files and move it to seed data files.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)