[jira] [Updated] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

2018-11-10 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-10645:
--
Attachment: OFBIZ-10645.patch
OFBIZ-10645-alternate.patch

> Empty entity name should not be allowed in entity definition
> 
>
> Key: OFBIZ-10645
> URL: https://issues.apache.org/jira/browse/OFBIZ-10645
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: EntityMaintError.png, OFBIZ-10645-alternate.patch, 
> OFBIZ-10645.patch
>
>
> Present system allows empty name in entity definition due to which there 
> SQLException in console log and error on Entity Mantainence page.
> {code:java}
> 2018-11-10 14:43:45,522 |OFBiz-batch-3    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-1    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-2    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:44:06,198 |OFBiz-batch-2    |DatabaseUtil  
> |W| Entity [] has no table in the database
> 2018-11-10 14:44:06,243 |pool-3-thread-1  |DatabaseUtil  
> |E| SQL Exception while executing the following:
> CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP 
> TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP, 
> CREATED_TX_STAMP TIMESTAMP,  PRIMARY KEY (TEST_ID))
> Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at 
> line 1, column 21.
> java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1, 
> column 21.
>     at 
> org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677) 
> [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
>  [ofbiz.jar:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_66]
>     at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.derby.iapi.error.StandardException: Syntax error: 
> Encountered "(" at line 1, column 21.
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown
>  Source) ~[derby-10.14.1.0.jar:?]
>     at 
> 

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

2018-11-10 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682367#comment-16682367
 ] 

Aditya Sharma commented on OFBIZ-10645:
---

I am adding 2 solution patches:

Added check in buildEntity() method of ModelReader class to return null if the 
name is missing and handled it in getEntityCache() method.

Added check in EntityMaint.groovy to skip entity with entity name missing.
 # When entity-name and table-name both are empty, the entity will not be 
processed. In buildEntity(), UtilXml.checkEmpty() method was used which ensured 
that empty string is assigned to the entity name if it is null/empty. It must 
have been done intentionally to fulfil some use case.
 # When entity-name is empty, the entity will not be processed.

> Empty entity name should not be allowed in entity definition
> 
>
> Key: OFBIZ-10645
> URL: https://issues.apache.org/jira/browse/OFBIZ-10645
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: EntityMaintError.png, OFBIZ-10645-alternate.patch, 
> OFBIZ-10645.patch
>
>
> Present system allows empty name in entity definition due to which there 
> SQLException in console log and error on Entity Mantainence page.
> {code:java}
> 2018-11-10 14:43:45,522 |OFBiz-batch-3    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-1    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-2    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:44:06,198 |OFBiz-batch-2    |DatabaseUtil  
> |W| Entity [] has no table in the database
> 2018-11-10 14:44:06,243 |pool-3-thread-1  |DatabaseUtil  
> |E| SQL Exception while executing the following:
> CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP 
> TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP, 
> CREATED_TX_STAMP TIMESTAMP,  PRIMARY KEY (TEST_ID))
> Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at 
> line 1, column 21.
> java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1, 
> column 21.
>     at 
> org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677) 
> [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
>  [ofbiz.jar:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_66]
>     at 

[jira] [Commented] (OFBIZ-10402) Introduce ability to clear specific cache from cache maintenance

2018-11-10 Thread Rishi Solanki (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682354#comment-16682354
 ] 

Rishi Solanki commented on OFBIZ-10402:
---

Minor improvement in code done at revision 1846298. No functional changes, 
instead of complete util package import only import the specific classes 
required in the UtilCacheEvents class.

Thanks to [~aditya.sharma] for review ant feedback.

> Introduce ability to clear specific cache from cache maintenance
> 
>
> Key: OFBIZ-10402
> URL: https://issues.apache.org/jira/browse/OFBIZ-10402
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Rishi Solanki
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10402.jpg, OFBIZ-10402.patch, OFBIZ-10402.patch
>
>
> Currently, either you can clear all caches or you can clear specific cache 
> records from clear button.
> There should be checkbox pattern which enables user to select multiple caches 
> and some button on top like clear selected caches. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10643) Google reCAPTCHA in E-Commerce Application

2018-11-10 Thread Rishi Solanki (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682357#comment-16682357
 ] 

Rishi Solanki commented on OFBIZ-10643:
---

Thanks [~deepak.nigam] one more suggestion while making it configurable we 
should have default to disable and if business specifically wants this feature 
then she can enable it.

> Google reCAPTCHA in E-Commerce Application
> --
>
> Key: OFBIZ-10643
> URL: https://issues.apache.org/jira/browse/OFBIZ-10643
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
>
> Google reCAPTCHA is a security feature that protects websites forms from spam 
> entries while letting real people pass through with ease. It can be used for 
> login, registration, password recovery, comments, popular contact forms, etc.
> Users are required to confirm that they are not a robot before the form can 
> be submitted. It’s easy for people and hard for bots. 
>  
> For more information about Google reCAPTCHA, please visit 
> [here|https://developers.google.com/recaptcha/].
>  
> I think this feature will be useful for OFBiz e-commerce also.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10214) Update build.gradle to the latest dependencies

2018-11-10 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10214:

Attachment: OFBIZ-10214-test.patch

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10214
> URL: https://issues.apache.org/jira/browse/OFBIZ-10214
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10214-test.patch, report.txt
>
>
> I'll for now wait because of OFBIZ-10036 which concerns upgrading to Tomcat 9 
> and should be the most important part of the work



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10214) Update build.gradle to the latest dependencies

2018-11-10 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682330#comment-16682330
 ] 

Jacques Le Roux edited comment on OFBIZ-10214 at 11/10/18 11:16 AM:


I have attached  [^OFBIZ-10214.patch]  with the most possible updates. 4 
updates were not possible:
Tika 1.18 max
Poi 3.17 max
I did not update 
sshd-core
cas-server-core

The tests pass, I wait some feedback before committing...

Note: in   [^OFBIZ-10214-test.patch] "com.github.ben-manes" parts should not be 
committed, used only for testing...


was (Author: jacques.le.roux):
I have attached a patch with the most possible updates. 4 updates were not 
possible:
Tika 1.18 max
Poi 3.17 max
I did not update 
sshd-core
cas-server-core

The tests pass, I wait some feedback before committing...

Note: in   [^OFBIZ-10214-test.patch] "com.github.ben-manes" parts should not be 
committed, used only for testing...

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10214
> URL: https://issues.apache.org/jira/browse/OFBIZ-10214
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10214-test.patch, OFBIZ-10214.patch, report.txt
>
>
> I'll for now wait because of OFBIZ-10036 which concerns upgrading to Tomcat 9 
> and should be the most important part of the work



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10214) Update build.gradle to the latest dependencies

2018-11-10 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10214:

Attachment: OFBIZ-10214.patch

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10214
> URL: https://issues.apache.org/jira/browse/OFBIZ-10214
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10214-test.patch, OFBIZ-10214.patch, report.txt
>
>
> I'll for now wait because of OFBIZ-10036 which concerns upgrading to Tomcat 9 
> and should be the most important part of the work



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10214) Update build.gradle to the latest dependencies

2018-11-10 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682330#comment-16682330
 ] 

Jacques Le Roux edited comment on OFBIZ-10214 at 11/10/18 11:13 AM:


I have attached a patch with the most possible updates. 4 updates were not 
possible:
Tika 1.18 max
Poi 3.17 max
I did not update 
sshd-core
cas-server-core

The tests pass, I wait some feedback before committing...

Note: in   [^OFBIZ-10214-test.patch] "com.github.ben-manes" parts should not be 
committed, used only for testing...


was (Author: jacques.le.roux):
I have attached a patch with the most possible updates. 2 updates were not 
possible:
Tika 1.18 max
Poi 3.17 max

The tests pass, I wait some feedback before committing...

Note: in this patch the "com.github.ben-manes" parts should not be committed, 
used only for testing...

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10214
> URL: https://issues.apache.org/jira/browse/OFBIZ-10214
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10214-test.patch, report.txt
>
>
> I'll for now wait because of OFBIZ-10036 which concerns upgrading to Tomcat 9 
> and should be the most important part of the work



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10214) Update build.gradle to the latest dependencies

2018-11-10 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10214:

Attachment: (was: OFBIZ-10214.patch)

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10214
> URL: https://issues.apache.org/jira/browse/OFBIZ-10214
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10214-test.patch, report.txt
>
>
> I'll for now wait because of OFBIZ-10036 which concerns upgrading to Tomcat 9 
> and should be the most important part of the work



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10214) Update build.gradle to the latest dependencies

2018-11-10 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682330#comment-16682330
 ] 

Jacques Le Roux edited comment on OFBIZ-10214 at 11/10/18 11:01 AM:


I have attached a patch with the most possible updates. 2 updates were not 
possible:
Tika 1.18 max
Poi 3.17 max

The tests pass, I wait some feedback before committing...

Note: in this patch the "com.github.ben-manes" parts should not be committed, 
used only for testing...


was (Author: jacques.le.roux):
I have attached a patch with the most possible updates. 2 updates were not 
possible:
Tika 1.18 max
Poi 3.17 max

The tests pass, I wait some feedback before committing...

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10214
> URL: https://issues.apache.org/jira/browse/OFBIZ-10214
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10214.patch, report.txt
>
>
> I'll for now wait because of OFBIZ-10036 which concerns upgrading to Tomcat 9 
> and should be the most important part of the work



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

2018-11-10 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-10645:
--
Summary: Empty entity name should not be allowed in entity definition  
(was: Empty entity name should be allowed in entity definition)

> Empty entity name should not be allowed in entity definition
> 
>
> Key: OFBIZ-10645
> URL: https://issues.apache.org/jira/browse/OFBIZ-10645
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: EntityMaintError.png
>
>
> Present system allows empty name in entity definition due to which there 
> SQLException in console log and error on Entity Mantainence page.
> {code:java}
> 2018-11-10 14:43:45,522 |OFBiz-batch-3    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-1    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-2    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:44:06,198 |OFBiz-batch-2    |DatabaseUtil  
> |W| Entity [] has no table in the database
> 2018-11-10 14:44:06,243 |pool-3-thread-1  |DatabaseUtil  
> |E| SQL Exception while executing the following:
> CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP 
> TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP, 
> CREATED_TX_STAMP TIMESTAMP,  PRIMARY KEY (TEST_ID))
> Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at 
> line 1, column 21.
> java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1, 
> column 21.
>     at 
> org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677) 
> [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
>  [ofbiz.jar:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_66]
>     at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.derby.iapi.error.StandardException: Syntax error: 
> Encountered "(" at line 1, column 21.
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown
>  Source) ~[derby-10.14.1.0.jar:?]
>     at 
> 

[jira] [Commented] (OFBIZ-10645) Empty entity name should be allowed in entity definition

2018-11-10 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682336#comment-16682336
 ] 

Aditya Sharma commented on OFBIZ-10645:
---

Indeed [~jacques.le.roux] :) 

> Empty entity name should be allowed in entity definition
> 
>
> Key: OFBIZ-10645
> URL: https://issues.apache.org/jira/browse/OFBIZ-10645
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: EntityMaintError.png
>
>
> Present system allows empty name in entity definition due to which there 
> SQLException in console log and error on Entity Mantainence page.
> {code:java}
> 2018-11-10 14:43:45,522 |OFBiz-batch-3    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-1    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-2    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:44:06,198 |OFBiz-batch-2    |DatabaseUtil  
> |W| Entity [] has no table in the database
> 2018-11-10 14:44:06,243 |pool-3-thread-1  |DatabaseUtil  
> |E| SQL Exception while executing the following:
> CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP 
> TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP, 
> CREATED_TX_STAMP TIMESTAMP,  PRIMARY KEY (TEST_ID))
> Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at 
> line 1, column 21.
> java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1, 
> column 21.
>     at 
> org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677) 
> [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
>  [ofbiz.jar:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_66]
>     at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.derby.iapi.error.StandardException: Syntax error: 
> Encountered "(" at line 1, column 21.
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown
>  Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatement(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>  

[jira] [Commented] (OFBIZ-10645) m

2018-11-10 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682326#comment-16682326
 ] 

Jacques Le Roux commented on OFBIZ-10645:
-

Should the title not say "Empty entity name should NOT be allowed in entity 
definition" ?

> m
> -
>
> Key: OFBIZ-10645
> URL: https://issues.apache.org/jira/browse/OFBIZ-10645
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: EntityMaintError.png
>
>
> Present system allows empty name in entity definition due to which there 
> SQLException in console log and error on Entity Mantainence page.
> {code:java}
> 2018-11-10 14:43:45,522 |OFBiz-batch-3    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-1    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-2    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:44:06,198 |OFBiz-batch-2    |DatabaseUtil  
> |W| Entity [] has no table in the database
> 2018-11-10 14:44:06,243 |pool-3-thread-1  |DatabaseUtil  
> |E| SQL Exception while executing the following:
> CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP 
> TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP, 
> CREATED_TX_STAMP TIMESTAMP,  PRIMARY KEY (TEST_ID))
> Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at 
> line 1, column 21.
> java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1, 
> column 21.
>     at 
> org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677) 
> [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
>  [ofbiz.jar:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_66]
>     at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.derby.iapi.error.StandardException: Syntax error: 
> Encountered "(" at line 1, column 21.
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown
>  Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatement(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at 

[jira] [Updated] (OFBIZ-10214) Update build.gradle to the latest dependencies

2018-11-10 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10214:

Attachment: OFBIZ-10214.patch

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10214
> URL: https://issues.apache.org/jira/browse/OFBIZ-10214
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10214.patch, report.txt
>
>
> I'll for now wait because of OFBIZ-10036 which concerns upgrading to Tomcat 9 
> and should be the most important part of the work



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10645) Empty entity name should be allowed in entity definition

2018-11-10 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10645:

Summary: Empty entity name should be allowed in entity definition  (was: m)

> Empty entity name should be allowed in entity definition
> 
>
> Key: OFBIZ-10645
> URL: https://issues.apache.org/jira/browse/OFBIZ-10645
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: EntityMaintError.png
>
>
> Present system allows empty name in entity definition due to which there 
> SQLException in console log and error on Entity Mantainence page.
> {code:java}
> 2018-11-10 14:43:45,522 |OFBiz-batch-3    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-1    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-2    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:44:06,198 |OFBiz-batch-2    |DatabaseUtil  
> |W| Entity [] has no table in the database
> 2018-11-10 14:44:06,243 |pool-3-thread-1  |DatabaseUtil  
> |E| SQL Exception while executing the following:
> CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP 
> TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP, 
> CREATED_TX_STAMP TIMESTAMP,  PRIMARY KEY (TEST_ID))
> Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at 
> line 1, column 21.
> java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1, 
> column 21.
>     at 
> org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677) 
> [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
>  [ofbiz.jar:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_66]
>     at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.derby.iapi.error.StandardException: Syntax error: 
> Encountered "(" at line 1, column 21.
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown
>  Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatement(Unknown Source) 
> 

[jira] [Updated] (OFBIZ-10645) m

2018-11-10 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10645:

Summary: m  (was: Empty entity name should be allowed in entity definition)

> m
> -
>
> Key: OFBIZ-10645
> URL: https://issues.apache.org/jira/browse/OFBIZ-10645
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: EntityMaintError.png
>
>
> Present system allows empty name in entity definition due to which there 
> SQLException in console log and error on Entity Mantainence page.
> {code:java}
> 2018-11-10 14:43:45,522 |OFBiz-batch-3    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-1    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-2    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:44:06,198 |OFBiz-batch-2    |DatabaseUtil  
> |W| Entity [] has no table in the database
> 2018-11-10 14:44:06,243 |pool-3-thread-1  |DatabaseUtil  
> |E| SQL Exception while executing the following:
> CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP 
> TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP, 
> CREATED_TX_STAMP TIMESTAMP,  PRIMARY KEY (TEST_ID))
> Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at 
> line 1, column 21.
> java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1, 
> column 21.
>     at 
> org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677) 
> [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
>  [ofbiz.jar:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_66]
>     at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.derby.iapi.error.StandardException: Syntax error: 
> Encountered "(" at line 1, column 21.
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown
>  Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatement(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.sql.GenericStatement.prepMinion(Unknown 
> Source) 

[jira] [Updated] (OFBIZ-10645) Empty entity name should be allowed in entity definition

2018-11-10 Thread Ashish Kumar Pandey (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Kumar Pandey updated OFBIZ-10645:

Attachment: EntityMaintError.png

> Empty entity name should be allowed in entity definition
> 
>
> Key: OFBIZ-10645
> URL: https://issues.apache.org/jira/browse/OFBIZ-10645
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: EntityMaintError.png
>
>
> Present system allows empty name in entity definition due to which there 
> SQLException in console log and error on Entity Mantainence page.
> {code:java}
> 2018-11-10 14:43:45,522 |OFBiz-batch-3    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-1    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-2    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:44:06,198 |OFBiz-batch-2    |DatabaseUtil  
> |W| Entity [] has no table in the database
> 2018-11-10 14:44:06,243 |pool-3-thread-1  |DatabaseUtil  
> |E| SQL Exception while executing the following:
> CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP 
> TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP, 
> CREATED_TX_STAMP TIMESTAMP,  PRIMARY KEY (TEST_ID))
> Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at 
> line 1, column 21.
> java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1, 
> column 21.
>     at 
> org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677) 
> [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
>  [ofbiz.jar:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_66]
>     at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.derby.iapi.error.StandardException: Syntax error: 
> Encountered "(" at line 1, column 21.
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown
>  Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatement(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at 

[jira] [Comment Edited] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-10 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682297#comment-16682297
 ] 

Pierre Smits edited comment on OFBIZ-4160 at 11/10/18 9:36 AM:
---

The Nederlandse Belastingdienst states on their website regarding BTW 
requirements on the invoice:
 * the invoice must show the amount the company charges the customer to pay, 
without VAT,
 * the VAT rate (per product category),
 * the VAT amount (split per VAT rate).

How that is displayed in product pages and shopping carts in e-stores is up to 
the company, and I must say influenced by marketing purposes, pragmatism and 
historically influenced: 
 * if the (main) focus is B2C then - commonly - prices in product pages and 
shopping carts are shown including VAT, with some listing the VAT amount as 
well. This is inline with what is shown in B%M stores,
 * if the (main) focus is B2B then prices in product pages and shopping carts 
are shown excluding VAT, optionally listing the VAT amount (and rate).

As an example: see 
[https://www.amac.nl/apple-mac-mini-2-6ghz-dual-core-i5-8gb-1tb] offering a Mac 
Mini. This is a company with a main focus on B2C, but does B2B too. The product 
page shows the price including VAT (with no VAT amount listed). However the 
invoice will state:
 * On the product line for each product/service the unit price ex VAT, 
quantity, the VAT rate and the total amount ex VAT.
 * If shipping cost were involved this would be shown on a new product line 
stating the VAT rate and the calculated/charged amount.

And below the product lines, the following would be shown:
 * the sub total (ex VAT)
 * the total amounts per VAT rate
 * the grand total amount (amount to be paid by the customer).

Some e-stores offer a toggle mechanism to show prices including/excluding VAT. 
See 
[https://maxict.nl/apple-mini-26ghz-nettop-intel-core-i5-zilver-pc-p4604260.html]

I trust the above helps.


was (Author: pfm.smits):
The Nederlandse Belastingdienst states on their website regarding BTW 
requirements on the invoice:


 * the invoice must show the amount the company charges the customer to pay, 
without VAT,
 * the VAT rate (per product category),
 * the VAT amount (split per VAT rate).

How that is displayed in product pages and shopping carts in e-stores is up to 
the company, and I must say influenced by marketing purposes, pragmatism and 
historically influenced: 
 * if the (main) focus is B2C then - commonly - prices in product pages and 
shopping carts are shown including VAT, with some listing the VAT amount as 
well. This is inline with what is shown in B%M stores,
 * if the (main) focus is B2B then prices in product pages and shopping carts 
are shown excluding VAT, optionally listing the VAT amount (and rate).

As an example: see 
[https://www.amac.nl/apple-mac-mini-2-6ghz-dual-core-i5-8gb-1tb] offering a Mac 
Mini. This is a company (with a main focus on B2C, but does B2B too). The 
product page shows the price including VAT (with no VAT amount listed). However 
the invoice will state:
 * On the product line for each product/service the unit price ex VAT, 
quantity, the VAT rate and the total amount ex VAT.
 * If shipping cost were involved this would be shown on a new product line 
stating the VAT rate and the calculated/charged amount.

And below the product lines, the following would be shown:
 * the sub total (ex VAT)
 * the total amounts per VAT rate
 * the grand total amount (amount to be paid by the customer).

Some e-stores offer a toggle mechanism to show prices including/excluding VAT. 
See 
[https://maxict.nl/apple-mini-26ghz-nettop-intel-core-i5-zilver-pc-p4604260.html]

I trust the above helps.

> Tax not added for order shipping or promotion
> -
>
> Key: OFBIZ-4160
> URL: https://issues.apache.org/jira/browse/OFBIZ-4160
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
> Environment: rev 1065908
>Reporter: Paul Foxworthy
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: VAT, tax
> Attachments: OFBIZ-4160_shipping_tax.patch, 
> OFBIZ-4160_weighted_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is 
> made, the relevant tax rows from the TaxAuthorityRateProduct table are not 
> being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov, see 
> http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2018-11-10 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682297#comment-16682297
 ] 

Pierre Smits commented on OFBIZ-4160:
-

The Nederlandse Belastingdienst states on their website regarding BTW 
requirements on the invoice:


 * the invoice must show the amount the company charges the customer to pay, 
without VAT,
 * the VAT rate (per product category),
 * the VAT amount (split per VAT rate).

How that is displayed in product pages and shopping carts in e-stores is up to 
the company, and I must say influenced by marketing purposes, pragmatism and 
historically influenced: 
 * if the (main) focus is B2C then - commonly - prices in product pages and 
shopping carts are shown including VAT, with some listing the VAT amount as 
well. This is inline with what is shown in B%M stores,
 * if the (main) focus is B2B then prices in product pages and shopping carts 
are shown excluding VAT, optionally listing the VAT amount (and rate).

As an example: see 
[https://www.amac.nl/apple-mac-mini-2-6ghz-dual-core-i5-8gb-1tb] offering a Mac 
Mini. This is a company (with a main focus on B2C, but does B2B too). The 
product page shows the price including VAT (with no VAT amount listed). However 
the invoice will state:
 * On the product line for each product/service the unit price ex VAT, 
quantity, the VAT rate and the total amount ex VAT.
 * If shipping cost were involved this would be shown on a new product line 
stating the VAT rate and the calculated/charged amount.

And below the product lines, the following would be shown:
 * the sub total (ex VAT)
 * the total amounts per VAT rate
 * the grand total amount (amount to be paid by the customer).

Some e-stores offer a toggle mechanism to show prices including/excluding VAT. 
See 
[https://maxict.nl/apple-mini-26ghz-nettop-intel-core-i5-zilver-pc-p4604260.html]

I trust the above helps.

> Tax not added for order shipping or promotion
> -
>
> Key: OFBIZ-4160
> URL: https://issues.apache.org/jira/browse/OFBIZ-4160
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
> Environment: rev 1065908
>Reporter: Paul Foxworthy
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: VAT, tax
> Attachments: OFBIZ-4160_shipping_tax.patch, 
> OFBIZ-4160_weighted_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is 
> made, the relevant tax rows from the TaxAuthorityRateProduct table are not 
> being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov, see 
> http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10645) Empty entity name should be allowed in entity definition

2018-11-10 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682291#comment-16682291
 ] 

Aditya Sharma commented on OFBIZ-10645:
---

It needs to be handled in ModelReader.java as well as EntityMaint.groovy. I 
will soon provide the patch.

> Empty entity name should be allowed in entity definition
> 
>
> Key: OFBIZ-10645
> URL: https://issues.apache.org/jira/browse/OFBIZ-10645
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: EntityMaintError.png
>
>
> Present system allows empty name in entity definition due to which there 
> SQLException in console log and error on Entity Mantainence page.
> {code:java}
> 2018-11-10 14:43:45,522 |OFBiz-batch-3    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-1    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-2    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:44:06,198 |OFBiz-batch-2    |DatabaseUtil  
> |W| Entity [] has no table in the database
> 2018-11-10 14:44:06,243 |pool-3-thread-1  |DatabaseUtil  
> |E| SQL Exception while executing the following:
> CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP 
> TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP, 
> CREATED_TX_STAMP TIMESTAMP,  PRIMARY KEY (TEST_ID))
> Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at 
> line 1, column 21.
> java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1, 
> column 21.
>     at 
> org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677) 
> [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
>  [ofbiz.jar:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_66]
>     at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.derby.iapi.error.StandardException: Syntax error: 
> Encountered "(" at line 1, column 21.
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown
>  Source) ~[derby-10.14.1.0.jar:?]
>     at 
> 

[jira] [Created] (OFBIZ-10645) Empty entity name should be allowed in entity definition

2018-11-10 Thread Ashish Kumar Pandey (JIRA)
Ashish Kumar Pandey created OFBIZ-10645:
---

 Summary: Empty entity name should be allowed in entity definition
 Key: OFBIZ-10645
 URL: https://issues.apache.org/jira/browse/OFBIZ-10645
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Release Branch 16.11, Trunk, Release Branch 17.12
Reporter: Ashish Kumar Pandey


Present system allows empty name in entity definition due to which there 
SQLException in console log and error on Entity Mantainence page.
{code:java}
2018-11-10 14:43:45,522 |OFBiz-batch-3    |DatabaseUtil  
|I| Error getting primary key info from database with null tableName, will try 
other means: java.sql.SQLException: Table name can not be null
2018-11-10 14:43:45,522 |OFBiz-batch-1    |DatabaseUtil  
|I| Error getting primary key info from database with null tableName, will try 
other means: java.sql.SQLException: Table name can not be null
2018-11-10 14:43:45,522 |OFBiz-batch-2    |DatabaseUtil  
|I| Error getting primary key info from database with null tableName, will try 
other means: java.sql.SQLException: Table name can not be null
2018-11-10 14:44:06,198 |OFBiz-batch-2    |DatabaseUtil  
|W| Entity [] has no table in the database
2018-11-10 14:44:06,243 |pool-3-thread-1  |DatabaseUtil  
|E| SQL Exception while executing the following:
CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP 
TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP, 
CREATED_TX_STAMP TIMESTAMP,  PRIMARY KEY (TEST_ID))
Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at 
line 1, column 21.
java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1, 
column 21.
    at 
org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source) 
~[derby-10.14.1.0.jar:?]
    at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
    at 
org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
    at 
org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
    at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
    at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
    at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source) 
~[derby-10.14.1.0.jar:?]
    at org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
    at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
    at 
org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
 ~[commons-dbcp2-2.1.1.jar:2.1.1]
    at 
org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
 ~[commons-dbcp2-2.1.1.jar:2.1.1]
    at 
org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677) 
[ofbiz.jar:?]
    at 
org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
 [ofbiz.jar:?]
    at 
org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
 [ofbiz.jar:?]
    at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_66]
    at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
[?:1.8.0_66]
    at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
[?:1.8.0_66]
    at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
Caused by: org.apache.derby.iapi.error.StandardException: Syntax error: 
Encountered "(" at line 1, column 21.
    at org.apache.derby.iapi.error.StandardException.newException(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
    at org.apache.derby.iapi.error.StandardException.newException(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
    at 
org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown
 Source) ~[derby-10.14.1.0.jar:?]
    at org.apache.derby.impl.sql.compile.ParserImpl.parseStatement(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
    at org.apache.derby.impl.sql.GenericStatement.prepMinion(Unknown 
Source) ~[derby-10.14.1.0.jar:?]
    at org.apache.derby.impl.sql.GenericStatement.prepare(Unknown Source) 
~[derby-10.14.1.0.jar:?]
    at 
org.apache.derby.impl.sql.conn.GenericLanguageConnectionContext.prepareInternalStatement(Unknown
 Source) ~[derby-10.14.1.0.jar:?]
    ... 12 more
2018-11-10 14:44:06,259 |pool-3-thread-1  |DatabaseUtil  
|E| Could not create table [OFBIZ.]: SQL Exception while executing 

[jira] [Assigned] (OFBIZ-10645) Empty entity name should be allowed in entity definition

2018-11-10 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma reassigned OFBIZ-10645:
-

Assignee: Aditya Sharma

> Empty entity name should be allowed in entity definition
> 
>
> Key: OFBIZ-10645
> URL: https://issues.apache.org/jira/browse/OFBIZ-10645
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Aditya Sharma
>Priority: Trivial
>
> Present system allows empty name in entity definition due to which there 
> SQLException in console log and error on Entity Mantainence page.
> {code:java}
> 2018-11-10 14:43:45,522 |OFBiz-batch-3    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-1    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:43:45,522 |OFBiz-batch-2    |DatabaseUtil  
> |I| Error getting primary key info from database with null tableName, will 
> try other means: java.sql.SQLException: Table name can not be null
> 2018-11-10 14:44:06,198 |OFBiz-batch-2    |DatabaseUtil  
> |W| Entity [] has no table in the database
> 2018-11-10 14:44:06,243 |pool-3-thread-1  |DatabaseUtil  
> |E| SQL Exception while executing the following:
> CREATE TABLE OFBIZ. (TEST_ID VARCHAR(20) NOT NULL, LAST_UPDATED_STAMP 
> TIMESTAMP, LAST_UPDATED_TX_STAMP TIMESTAMP, CREATED_STAMP TIMESTAMP, 
> CREATED_TX_STAMP TIMESTAMP,  PRIMARY KEY (TEST_ID))
> Error was: java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at 
> line 1, column 21.
> java.sql.SQLSyntaxErrorException: Syntax error: Encountered "(" at line 1, 
> column 21.
>     at 
> org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.execute(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.jdbc.EmbedStatement.executeLargeUpdate(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.jdbc.EmbedStatement.executeUpdate(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.commons.dbcp2.DelegatingStatement.executeUpdate(DelegatingStatement.java:234)
>  ~[commons-dbcp2-2.1.1.jar:2.1.1]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil.createTable(DatabaseUtil.java:1677) 
> [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1516)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.entity.jdbc.DatabaseUtil$CreateTableCallable.call(DatabaseUtil.java:1502)
>  [ofbiz.jar:?]
>     at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [?:1.8.0_66]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [?:1.8.0_66]
>     at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.derby.iapi.error.StandardException: Syntax error: 
> Encountered "(" at line 1, column 21.
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.iapi.error.StandardException.newException(Unknown 
> Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatementOrSearchCondition(Unknown
>  Source) ~[derby-10.14.1.0.jar:?]
>     at 
> org.apache.derby.impl.sql.compile.ParserImpl.parseStatement(Unknown Source) 
> ~[derby-10.14.1.0.jar:?]
>     at org.apache.derby.impl.sql.GenericStatement.prepMinion(Unknown 
> Source) 

[jira] [Commented] (OFBIZ-10214) Update build.gradle to the latest dependencies

2018-11-10 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682289#comment-16682289
 ] 

Jacques Le Roux commented on OFBIZ-10214:
-

It's a real pain, I should not have started :D

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10214
> URL: https://issues.apache.org/jira/browse/OFBIZ-10214
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: report.txt
>
>
> I'll for now wait because of OFBIZ-10036 which concerns upgrading to Tomcat 9 
> and should be the most important part of the work



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9800) French translation of OFBiz website

2018-11-10 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682284#comment-16682284
 ] 

Deepak Dixit commented on OFBIZ-9800:
-

Here is the dev list thread

[https://s.apache.org/ybX2]

> French translation of OFBiz website
> ---
>
> Key: OFBIZ-9800
> URL: https://issues.apache.org/jira/browse/OFBIZ-9800
> Project: OFBiz
>  Issue Type: Improvement
>  Components: site
>Reporter: Olivier Heintz
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: website-fr.tar, website-fr.tar, website-fr.tar.gz, 
> website-fr.tar.gz, website-fr.tar.gz, website-fr.tar.gz, website-fr.tar.gz
>
>
> To evaluate the workload of translate all the ofbiz website page in french, 
> and so to maintain the translation when there are some modifications, I have 
> start to translate them.
> There are between 10 and 15 page to translate, and translate one is between 1 
> and 2 hours.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)