[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-11-26 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699977#comment-16699977
 ] 

Deepak Dixit commented on OFBIZ-5048:
-

I think we can backport this to R17.12 as well, as its missing code in Groovy 
handler. 

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, 
> OFBIZ-5048V2.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10580) Classification group filter not working on find party screen

2018-11-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699303#comment-16699303
 ] 

Jacques Le Roux commented on OFBIZ-10580:
-

It sounds good to me, but we also need to increase the width of the drop-down 
when no classification group exists. It seems not easy because it's a multiple 
(allow-multiple="true").

> Classification group filter not working on find party screen
> 
>
> Key: OFBIZ-10580
> URL: https://issues.apache.org/jira/browse/OFBIZ-10580
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Anushi Gupta
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10580.patch
>
>
> Steps to regenerate:
>  # Login to 
> partymgr([[https://demo-trunk.ofbiz.apache.org/partymgr/control/findparty])]
>  # Select classification group (if present, otherwise create new group) and 
> find party
> Actual :
> All parties are listed on searching
> Expected :
> Parties which are under the selected classification group should only be 
> listed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-11-26 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5048.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch

Thank you both for your patches,

Rohit, your patch is in trunk at revision: 1847478  


> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, 
> OFBIZ-5048V2.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10675) createGlReconciliation throws an error

2018-11-26 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-10675:


 Summary: createGlReconciliation throws an error
 Key: OFBIZ-10675
 URL: https://issues.apache.org/jira/browse/OFBIZ-10675
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits
 Attachments: Screen Shot 2018-11-26 at 15.49.38.png

See 
[https://demo-trunk.ofbiz.apache.org/accounting/control/createGlReconciliation]

 

When entering an amount and submitting the data an error is thrown. See 
attached image.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package

2018-11-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698855#comment-16698855
 ] 

Jacques Le Roux commented on OFBIZ-10655:
-

+1

> OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
> -
>
> Key: OFBIZ-10655
> URL: https://issues.apache.org/jira/browse/OFBIZ-10655
> Project: OFBiz
>  Issue Type: Bug
>  Components: pricat
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Shi Jinghai
>Priority: Major
> Attachments: OFBIZ-10655.patch
>
>
> Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package

2018-11-26 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698692#comment-16698692
 ] 

Shi Jinghai commented on OFBIZ-10655:
-

Hi Jacques,

Yeah, very strange, yesterday, I created the patch with eclipse subclipse 
plugin, I didn't test it locally before uploading.

I just tried to use TortoiseSVN to create a new patch, it's the same as the one 
here.

After applying the patch in my local environment, I have to remove the 
plugins/pricat/src/main/java/org/apache/poi/ manully.

> OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
> -
>
> Key: OFBIZ-10655
> URL: https://issues.apache.org/jira/browse/OFBIZ-10655
> Project: OFBiz
>  Issue Type: Bug
>  Components: pricat
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Shi Jinghai
>Priority: Major
> Attachments: OFBIZ-10655.patch
>
>
> Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-11-26 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-5048:
--

Assignee: Jacques Le Roux  (was: Rohit Koushal)

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, 
> OFBIZ-5048V2.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10673) Unable to add additional product images from catalog

2018-11-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698688#comment-16698688
 ] 

Jacques Le Roux commented on OFBIZ-10673:
-

Hi Rohit,

It was not broken by 
[r1817623|http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/image/ScaleImage.java?r1=1817623=1817622=1817623]
 for OFBIZ-9776 which actually fixed this line. So it was broken before (the 
history is hard to trace but it was at 
[r1081526|http://svn.apache.org/viewvc?view=revision=1081526]) and we 
should be sure that this line should be removed.

> Unable to add additional product images from catalog
> 
>
> Key: OFBIZ-10673
> URL: https://issues.apache.org/jira/browse/OFBIZ-10673
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-10673.patch, screenshot-1.png
>
>
> Unable to add additional product images from screen: Catalog > Products > 
> Content
> below is the screen for reference.
>  !screenshot-1.png! 
> Server logs:
> {code:java}
> 2018-11-24 18:40:52,454 |sse-nio-8443-exec-11 |CallService   
> |E| ERROR: Could not complete the Method to upload multiple Additional View 
> images for product 
> [file:/home/rohit/sandbox/ofbiz-framework/applications/product/minilang/product/product/ProductContentServices.xml#uploadProductAdditionalViewImages]
>  process [problem invoking the [addAdditionalViewForProduct] service with the 
> map named [addAdditionalViewForProductMap] containing 
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2018-11-24 
> 11:21:56.719(java.sql.Timestamp)][createdTxStamp,2018-11-24 
> 11:21:56.716(java.sql.Timestamp)][currentPassword,{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][externalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Calcutta(java.lang.String)][lastUpdatedStamp,2018-11-24
>  14:59:33.347(java.sql.Timestamp)][lastUpdatedTxStamp,2018-11-24 
> 14:59:33.291(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,0(java.lang.Long)][userLdapDn,null()][userLoginId,admin(java.lang.String)],
>  visualTheme=visual-theme-id:RAINBOWSTONE_SAPHIR, display-name: Rainbow Stone 
> - Sapphire, description: , screenshots: 
> [/rainbowstone/images/themeSaphir.png], productId=GZ-1000, 
> _uploadedFile_contentType=image/png, 
> timeZone=sun.util.calendar.ZoneInfo[id="Asia/Calcutta",offset=1980,dstSavings=0,useDaylight=false,transitions=6,lastRule=null],
>  locale=en_US, productContentTypeId=ADDITIONAL_IMAGE_1, 
> uploadedFile=java.nio.HeapByteBuffer[pos=0 lim=1174673 cap=1174673], 
> _uploadedFile_fileName=Screenshot from 2018-10-23 09:02:57.png}]: Service 
> [addAdditionalViewForProduct] target threw an unexpected exception (null)]
> org.apache.ofbiz.service.GenericServiceException: Service 
> [addAdditionalViewForProduct] target threw an unexpected exception (null)
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:115)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:415)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:103)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.method.callops.CallService.exec(CallService.java:217)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.method.ifops.IfNotEmpty.exec(IfNotEmpty.java:61) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSubOps(SimpleMethod.java:310) 
> [ofbiz.jar:?]
> at org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:457) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:293)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
>  [ofbiz.jar:?]
> at 
> 

[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-11-26 Thread Rohit Koushal (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698684#comment-16698684
 ] 

Rohit Koushal commented on OFBIZ-5048:
--

Thanks [~jacques.le.roux] ,

Attaching the revised patch by name OFBIZ-5048V2.patch

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, 
> OFBIZ-5048V2.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-11-26 Thread Rohit Koushal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Koushal updated OFBIZ-5048:
-
Attachment: OFBIZ-5048V2.patch

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, 
> OFBIZ-5048V2.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10674) Not able to delete organization unit

2018-11-26 Thread Jason Hao (JIRA)
Jason Hao created OFBIZ-10674:
-

 Summary: Not able to delete organization unit
 Key: OFBIZ-10674
 URL: https://issues.apache.org/jira/browse/OFBIZ-10674
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting, party
Affects Versions: 16.11.05
Reporter: Jason Hao


I tried to add new Organization by doing steps below:
 # create a party as organization unit
 # In Accouting-> AccountingOrgGlSettings add a new organization unit

 

But when I want to delete it, I found there is no means to delete either the 
party or the settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event

2018-11-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698647#comment-16698647
 ] 

Jacques Le Roux commented on OFBIZ-5048:


Hi Rohit,

Your patch looks good to me, but it can't be applied as is. It's in Git format, 
please provide a Svn format: "{{git diff --no-prefix}}" thanks

> Multi Part Input Parameters not Available in Groovy Event
> -
>
> Key: OFBIZ-5048
> URL: https://issues.apache.org/jira/browse/OFBIZ-5048
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Vikramjit Singh
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch
>
>
> If form is of type enctype="multipart/form-data" and we are handling it's 
> submission through Groovy Event then in the parameters Map Ofbiz does not set 
> the multipart input parameters from request parameters.
> The same are available when multipart form submission is handled through 
> service.
> The reason being the code that sets the multipart parameters in request 
> attribute is only available in ServiceEventHandler.java and in 
> GroovyEventHandler the multipart are never set. 
> So I have created a method getMultiPartParameterMap in the class 
> UtilHttp.java and put the common logic in that method so that when 
> getCombinedMap method is called from the GroovEventHandler the method also 
> call getMultiPartParameterMap and in the ServiceEventHandler I have written a 
> call for getMultiPartParameterMap method.
> I am attaching the Patch Kindly Verify the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-26 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-10457:
--
Description: 
In reference to the [proposal|https://markmail.org/message/pna6ce3mkssbhg36] 
sent on the developer list, this ticket will be used for tracking the work 
progress of the SMS gateway integration.

I have added design proposal for the SMS gateway integration to the wiki and 
can be accessed from here.

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614

  was:
In reference to the proposal sent on the developer list, this ticket will be 
used for tracking the work progress of the SMS gateway integration.

I have added design proposal for the SMS gateway integration to the wiki and 
can be accessed from here.

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614


> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, mobile-screenshot.jpeg, msg91.zip
>
>
> In reference to the [proposal|https://markmail.org/message/pna6ce3mkssbhg36] 
> sent on the developer list, this ticket will be used for tracking the work 
> progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package

2018-11-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698594#comment-16698594
 ] 

Jacques Le Roux commented on OFBIZ-10655:
-

HI Jinghai,

I see a redundancy in your patch (OFBizPricatUtil.java is removed 3 times) and 
when applied the previous path to it is not removed 
(plugins/pricat/src/main/java/org/apache/poi/xssf/usermodel). Apart that, it 
can be applied in Eclipse, it compiles and is OK with me, thanks.

> OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
> -
>
> Key: OFBIZ-10655
> URL: https://issues.apache.org/jira/browse/OFBIZ-10655
> Project: OFBiz
>  Issue Type: Bug
>  Components: pricat
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Shi Jinghai
>Priority: Major
> Attachments: OFBIZ-10655.patch
>
>
> Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)