[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708256#comment-16708256 ] Deepak Dixit commented on OFBIZ-10689: -- @param type Optional Java class name of type to convert to. A null or empty String will return the original object. > function parseBigDecimalForEntity is in wrong location > -- > > Key: OFBIZ-10689 > URL: https://issues.apache.org/jira/browse/OFBIZ-10689 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, > Release Branch 17.12 >Reporter: Pierre Smits >Priority: Major > > Currently the function 'parseBigDecimalForEntity' is located in > ProductEvents.java. > Given that this function applies to more than just products, this function > should be located in the framework stack. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708249#comment-16708249 ] Deepak Dixit commented on OFBIZ-10689: -- Hi Jacques, I think ObjectType.simpleTypeConvert supports the BigDecimal conversion, (Please refer ModelFormField.java:1552) There are lots of occurrences in code. ObjectType.simpleTypeConvert(retVal, "BigDecimal", null, null, locale, true); parseBigDecimalForEntity does not support the locale based conversion. > function parseBigDecimalForEntity is in wrong location > -- > > Key: OFBIZ-10689 > URL: https://issues.apache.org/jira/browse/OFBIZ-10689 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, > Release Branch 17.12 >Reporter: Pierre Smits >Priority: Major > > Currently the function 'parseBigDecimalForEntity' is located in > ProductEvents.java. > Given that this function applies to more than just products, this function > should be located in the framework stack. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location
[
https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708230#comment-16708230
]
Jacques Le Roux commented on OFBIZ-10689:
-
Hi Deepak,
Currently simpleTypeConvert does not support BigDecimal:
{quote}
* Converts the passed object to the named simple type. Supported types
* include: String, Boolean, Double, Float, Long, Integer, Date (java.sql.Date),
* Time, Timestamp, TimeZone;
{quote}
Also parseBigDecimalForEntity offers more than a simple conversion
{quote}
* Return nulls for empty strings, as the entity engine can deal with nulls.
This will provide blanks
* in fields where BigDecimal display. Blank meaning null, vs. 0 which means 0
{quote}
> function parseBigDecimalForEntity is in wrong location
> --
>
> Key: OFBIZ-10689
> URL: https://issues.apache.org/jira/browse/OFBIZ-10689
> Project: OFBiz
> Issue Type: Bug
> Components: framework, product
>Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11,
> Release Branch 17.12
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the function 'parseBigDecimalForEntity' is located in
> ProductEvents.java.
> Given that this function applies to more than just products, this function
> should be located in the framework stack.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708193#comment-16708193 ] Deepak Dixit commented on OFBIZ-10689: -- I think we can remove this method, and it woudl be good to use ObjectType.simpleTypeConvert method for parsing. > function parseBigDecimalForEntity is in wrong location > -- > > Key: OFBIZ-10689 > URL: https://issues.apache.org/jira/browse/OFBIZ-10689 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, > Release Branch 17.12 >Reporter: Pierre Smits >Priority: Major > > Currently the function 'parseBigDecimalForEntity' is located in > ProductEvents.java. > Given that this function applies to more than just products, this function > should be located in the framework stack. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-5403) Implement separate glAccounts per TaxAuthority-ProductCategory combination
[ https://issues.apache.org/jira/browse/OFBIZ-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707853#comment-16707853 ] Jacques Le Roux commented on OFBIZ-5403: Hi Pierre, No, cheers > Implement separate glAccounts per TaxAuthority-ProductCategory combination > -- > > Key: OFBIZ-5403 > URL: https://issues.apache.org/jira/browse/OFBIZ-5403 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: accounting, tax, transactions > > In current setup only 1 glAccount can be defined for each combination of > TaxGeo, TaxAuthority and Internal Organization. > However, it is common that multiple tax rates exist per TaxGeo (e.g. VAT > rates of 0, 6 and 21% for The Netherlands) and it also customary to report > separately for sales and purchasing per tax rate and audit registered tax > bookings vs sales and purchases per period. > As such implementing a glAccount per > TaxGeo-TaxAuth-IntOrganisation-ProductCategory, and upgrading applicable > transaction processing services would facilitate the above. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9972) Find an alternative suitable syntax for OFBiz rule tasks in gradle
[ https://issues.apache.org/jira/browse/OFBIZ-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707820#comment-16707820 ] Mathieu Lirzin commented on OFBIZ-9972: --- Thanks Taher. > Find an alternative suitable syntax for OFBiz rule tasks in gradle > -- > > Key: OFBIZ-9972 > URL: https://issues.apache.org/jira/browse/OFBIZ-9972 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-9972_Upgrade-to-Gradle-5.0.patch > > > In testing OFBiz with a new version of gradle, I identified a potential > problem. The rule based tasks such as "ofbiz --test" will not work in > versions 5 and above. The exact error message that I received is: > The task name 'ofbiz --test' contains at least one of the following > characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is > scheduled to be removed in Gradle 5.0. > In other words, spaces are not allowed. We need to find an alternative > solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-5403) Implement separate glAccounts per TaxAuthority-ProductCategory combination
[ https://issues.apache.org/jira/browse/OFBIZ-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707752#comment-16707752 ] Pierre Smits commented on OFBIZ-5403: - Hi [~jacques.le.roux], Are you still working this issue? Best regards, Pierre > Implement separate glAccounts per TaxAuthority-ProductCategory combination > -- > > Key: OFBIZ-5403 > URL: https://issues.apache.org/jira/browse/OFBIZ-5403 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Labels: accounting, tax, transactions > > In current setup only 1 glAccount can be defined for each combination of > TaxGeo, TaxAuthority and Internal Organization. > However, it is common that multiple tax rates exist per TaxGeo (e.g. VAT > rates of 0, 6 and 21% for The Netherlands) and it also customary to report > separately for sales and purchasing per tax rate and audit registered tax > bookings vs sales and purchases per period. > As such implementing a glAccount per > TaxGeo-TaxAuth-IntOrganisation-ProductCategory, and upgrading applicable > transaction processing services would facilitate the above. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10690) seca 'createFinAccountTrans' does not factor in statusId of finAccountTrans
Pierre Smits created OFBIZ-10690: Summary: seca 'createFinAccountTrans' does not factor in statusId of finAccountTrans Key: OFBIZ-10690 URL: https://issues.apache.org/jira/browse/OFBIZ-10690 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: Release Branch 16.11, Release Branch 15.12, Trunk, Release Branch 17.12 Reporter: Pierre Smits Correct implementation of the 'createFinAccountTrans' will execute the 'postFinAccountTransToGl' service without regard of the status of the FinAccountTrans. The 'postFinAccountTransToGl' should only be executed when the value of StatusId of the FinAccountTrans is set to 'FINACT_TRNS_APPROVED'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-6896) Financial Account Transactions can't be modified
[ https://issues.apache.org/jira/browse/OFBIZ-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-6896. --- Resolution: Duplicate OFBIZ-10686 > Financial Account Transactions can't be modified > > > Key: OFBIZ-6896 > URL: https://issues.apache.org/jira/browse/OFBIZ-6896 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > > When a financial transaction is incomplete, it should be possible to correct > the situation. However, this is not possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-7675) Investigate if we should turn Freemarker autoescaping on
[
https://issues.apache.org/jira/browse/OFBIZ-7675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707686#comment-16707686
]
Deepak Dixit edited comment on OFBIZ-7675 at 12/3/18 7:33 PM:
--
Attaching first draft for freemarker auto-escaping, its not a complete work
still need to do more testing and code modification.
In this patch set the HTML default output format and removed <#escape and
inline escaping.
We can also associate the output format with templates, here are the reference
for the same
[https://freemarker.apache.org/docs/pgui_config_outputformatsautoesc.html]
[https://freemarker.apache.org/docs/dgui_misc_autoescaping.html]
was (Author: deepak.dixit):
Attaching frist draft for freemarker auto-escaping, its not a complete work
still need to do more testing and code modification.
In this patch set the HTML default output format and removed <#escape and
inline escsping.
We can also associate the output format with templates, here are the reference
for the same
[https://freemarker.apache.org/docs/pgui_config_outputformatsautoesc.html]
[https://freemarker.apache.org/docs/dgui_misc_autoescaping.html]
> Investigate if we should turn Freemarker autoescaping on
>
>
> Key: OFBIZ-7675
> URL: https://issues.apache.org/jira/browse/OFBIZ-7675
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-7675-plugins.patch, OFBIZ-7675.patch
>
>
> At OFBIZ-7041 [~f...@14x.net] suggested that we turn Freemarker autoescaping
> on. Quoting him there:
> {quote}
> This new version of FreeMarker includes auto-escaping and output formats. The
> <#escape> directive has been deprecated. Notice the comment at the very end
> of this page:
> "FreeMarker automatically escapes all values printed ... if it's properly
> configured (that's the responsibility of the programmers; [see here
> how|http://freemarker.org/docs/pgui_config_outputformatsautoesc.html])."
> Would be good to turn autoescaping on, and set the configuration to match
> .ftl as HTML and .fo.ftl as XML.
> {quote}
> [~pfm.smits] asked
> {quote}
> If we are going down that path I guess we have to visit a lot of Freemarker
> template files, right?
> {quote}
> Here is my answer
> {quote}
> We don' t use any <#escape> directives in all OFBiz. We have a couple of
> <#noescape> which should be replaced by <#noautoesc>. So I agree we could set
> the Freemarker environement to auto-escaping, and test if it has not
> unexpected side-effects.
> Could be that this will fix or complicate the issue I crossed (at bottom) of
> OFBIZ-7041 and more recently at OFBIZ-7343, let's see...
> {quote}
> Reply
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-7675) Investigate if we should turn Freemarker autoescaping on
[
https://issues.apache.org/jira/browse/OFBIZ-7675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-7675:
Fix Version/s: (was: 17.12.01)
> Investigate if we should turn Freemarker autoescaping on
>
>
> Key: OFBIZ-7675
> URL: https://issues.apache.org/jira/browse/OFBIZ-7675
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-7675-plugins.patch, OFBIZ-7675.patch
>
>
> At OFBIZ-7041 [~f...@14x.net] suggested that we turn Freemarker autoescaping
> on. Quoting him there:
> {quote}
> This new version of FreeMarker includes auto-escaping and output formats. The
> <#escape> directive has been deprecated. Notice the comment at the very end
> of this page:
> "FreeMarker automatically escapes all values printed ... if it's properly
> configured (that's the responsibility of the programmers; [see here
> how|http://freemarker.org/docs/pgui_config_outputformatsautoesc.html])."
> Would be good to turn autoescaping on, and set the configuration to match
> .ftl as HTML and .fo.ftl as XML.
> {quote}
> [~pfm.smits] asked
> {quote}
> If we are going down that path I guess we have to visit a lot of Freemarker
> template files, right?
> {quote}
> Here is my answer
> {quote}
> We don' t use any <#escape> directives in all OFBiz. We have a couple of
> <#noescape> which should be replaced by <#noautoesc>. So I agree we could set
> the Freemarker environement to auto-escaping, and test if it has not
> unexpected side-effects.
> Could be that this will fix or complicate the issue I crossed (at bottom) of
> OFBIZ-7041 and more recently at OFBIZ-7343, let's see...
> {quote}
> Reply
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7675) Investigate if we should turn Freemarker autoescaping on
[
https://issues.apache.org/jira/browse/OFBIZ-7675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707686#comment-16707686
]
Deepak Dixit commented on OFBIZ-7675:
-
Attaching frist draft for freemarker auto-escaping, its not a complete work
still need to do more testing and code modification.
In this patch set the HTML default output format and removed <#escape and
inline escsping.
We can also associate the output format with templates, here are the reference
for the same
[https://freemarker.apache.org/docs/pgui_config_outputformatsautoesc.html]
[https://freemarker.apache.org/docs/dgui_misc_autoescaping.html]
> Investigate if we should turn Freemarker autoescaping on
>
>
> Key: OFBIZ-7675
> URL: https://issues.apache.org/jira/browse/OFBIZ-7675
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7675-plugins.patch, OFBIZ-7675.patch
>
>
> At OFBIZ-7041 [~f...@14x.net] suggested that we turn Freemarker autoescaping
> on. Quoting him there:
> {quote}
> This new version of FreeMarker includes auto-escaping and output formats. The
> <#escape> directive has been deprecated. Notice the comment at the very end
> of this page:
> "FreeMarker automatically escapes all values printed ... if it's properly
> configured (that's the responsibility of the programmers; [see here
> how|http://freemarker.org/docs/pgui_config_outputformatsautoesc.html])."
> Would be good to turn autoescaping on, and set the configuration to match
> .ftl as HTML and .fo.ftl as XML.
> {quote}
> [~pfm.smits] asked
> {quote}
> If we are going down that path I guess we have to visit a lot of Freemarker
> template files, right?
> {quote}
> Here is my answer
> {quote}
> We don' t use any <#escape> directives in all OFBiz. We have a couple of
> <#noescape> which should be replaced by <#noautoesc>. So I agree we could set
> the Freemarker environement to auto-escaping, and test if it has not
> unexpected side-effects.
> Could be that this will fix or complicate the issue I crossed (at bottom) of
> OFBIZ-7041 and more recently at OFBIZ-7343, let's see...
> {quote}
> Reply
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-7675) Investigate if we should turn Freemarker autoescaping on
[
https://issues.apache.org/jira/browse/OFBIZ-7675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit updated OFBIZ-7675:
Attachment: OFBIZ-7675.patch
OFBIZ-7675-plugins.patch
> Investigate if we should turn Freemarker autoescaping on
>
>
> Key: OFBIZ-7675
> URL: https://issues.apache.org/jira/browse/OFBIZ-7675
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7675-plugins.patch, OFBIZ-7675.patch
>
>
> At OFBIZ-7041 [~f...@14x.net] suggested that we turn Freemarker autoescaping
> on. Quoting him there:
> {quote}
> This new version of FreeMarker includes auto-escaping and output formats. The
> <#escape> directive has been deprecated. Notice the comment at the very end
> of this page:
> "FreeMarker automatically escapes all values printed ... if it's properly
> configured (that's the responsibility of the programmers; [see here
> how|http://freemarker.org/docs/pgui_config_outputformatsautoesc.html])."
> Would be good to turn autoescaping on, and set the configuration to match
> .ftl as HTML and .fo.ftl as XML.
> {quote}
> [~pfm.smits] asked
> {quote}
> If we are going down that path I guess we have to visit a lot of Freemarker
> template files, right?
> {quote}
> Here is my answer
> {quote}
> We don' t use any <#escape> directives in all OFBiz. We have a couple of
> <#noescape> which should be replaced by <#noautoesc>. So I agree we could set
> the Freemarker environement to auto-escaping, and test if it has not
> unexpected side-effects.
> Could be that this will fix or complicate the issue I crossed (at bottom) of
> OFBIZ-7041 and more recently at OFBIZ-7343, let's see...
> {quote}
> Reply
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10638) The ‘StartupLoader’ interface should be removed
[
https://issues.apache.org/jira/browse/OFBIZ-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707499#comment-16707499
]
Taher Alkhateeb commented on OFBIZ-10638:
-
Hi Mathieu,
Sorry for the delay on this. I will work on it soon. FYI if you want to push
things forward you can nudge me here and I'll get back to it.
> The ‘StartupLoader’ interface should be removed
> ---
>
> Key: OFBIZ-10638
> URL: https://issues.apache.org/jira/browse/OFBIZ-10638
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Taher Alkhateeb
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10638_0001-Remove-StartupLoader-interface.patch,
> OFBIZ-10638_0002-Remove-unnecessary-arguments-in-AdminServer.patch,
> OFBIZ-10638_0003-Refactor-StartupControlPanel.patch,
> OFBIZ-10638_0004-Refactor-ContainerLoader.patch
>
>
> OFBiz used to provide alternate Startup loaders. Nowadays only the container
> loaders is used. As suggested by Taher [on the dev mailing
> list|https://lists.apache.org/thread.html/f99d6f661eb8197df8eac6d8ba7db3fa9b7fe2569a4a24ef2fef5cae@%3Cdev.ofbiz.apache.org%3E],
> the {{StartupLoader}} interface should be removed and startup code using it
> should be adapted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-9972) Find an alternative suitable syntax for OFBiz rule tasks in gradle
[ https://issues.apache.org/jira/browse/OFBIZ-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb closed OFBIZ-9972. -- Resolution: Fixed Fix Version/s: Upcoming Branch > Find an alternative suitable syntax for OFBiz rule tasks in gradle > -- > > Key: OFBIZ-9972 > URL: https://issues.apache.org/jira/browse/OFBIZ-9972 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-9972_Upgrade-to-Gradle-5.0.patch > > > In testing OFBiz with a new version of gradle, I identified a potential > problem. The rule based tasks such as "ofbiz --test" will not work in > versions 5 and above. The exact error message that I received is: > The task name 'ofbiz --test' contains at least one of the following > characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is > scheduled to be removed in Gradle 5.0. > In other words, spaces are not allowed. We need to find an alternative > solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9972) Find an alternative suitable syntax for OFBiz rule tasks in gradle
[ https://issues.apache.org/jira/browse/OFBIZ-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707492#comment-16707492 ] Taher Alkhateeb commented on OFBIZ-9972: I recreated a more clean patch that sustains the Apache header comments and removes any unnecessary diffs. Implemented in r1848062. Thank you Mathieu for giving us the heads up. I hope this doesn't come to hunt us back in the future. > Find an alternative suitable syntax for OFBiz rule tasks in gradle > -- > > Key: OFBIZ-9972 > URL: https://issues.apache.org/jira/browse/OFBIZ-9972 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-9972_Upgrade-to-Gradle-5.0.patch > > > In testing OFBiz with a new version of gradle, I identified a potential > problem. The rule based tasks such as "ofbiz --test" will not work in > versions 5 and above. The exact error message that I received is: > The task name 'ofbiz --test' contains at least one of the following > characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is > scheduled to be removed in Gradle 5.0. > In other words, spaces are not allowed. We need to find an alternative > solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location
Pierre Smits created OFBIZ-10689: Summary: function parseBigDecimalForEntity is in wrong location Key: OFBIZ-10689 URL: https://issues.apache.org/jira/browse/OFBIZ-10689 Project: OFBiz Issue Type: Bug Components: framework, product Affects Versions: Release Branch 16.11, Release Branch 15.12, Trunk, Release Branch 17.12 Reporter: Pierre Smits Currently the function 'parseBigDecimalForEntity' is located in ProductEvents.java. Given that this function applies to more than just products, this function should be located in the framework stack. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Jugl updated OFBIZ-10688:
--
Attachment: OFBIZ-10688-HtmlFormMacroLibrary.patch
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Major
> Attachments: OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10688) textareas do not save data, when visual-editor is used
Benjamin Jugl created OFBIZ-10688:
-
Summary: textareas do not save data, when visual-editor is used
Key: OFBIZ-10688
URL: https://issues.apache.org/jira/browse/OFBIZ-10688
Project: OFBiz
Issue Type: Bug
Components: framework, themes
Affects Versions: Trunk
Reporter: Benjamin Jugl
Assignee: Benjamin Jugl
Can be reproduced by
# Log into the Frontend (ecommerce) as admin
# go to Browse Forums
# click any link ("Ask the Experts" was used for testing)
# Create "New Message"
# click "add"
Following Error occurs:
"ERROR: Could not complete the Post a new Content article Entry
[file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
process [problem invoking the [createTextContent] service with the map named
[...]"
Data is not stored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10687) createFinAccountTrans service set wrong statusId value
Pierre Smits created OFBIZ-10687: Summary: createFinAccountTrans service set wrong statusId value Key: OFBIZ-10687 URL: https://issues.apache.org/jira/browse/OFBIZ-10687 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: Release Branch 16.11, Release Branch 15.12, Trunk, Release Branch 17.12 Reporter: Pierre Smits When a FinAccountTrans record is created and the status of the record was not set, the triggered service 'createFinAccountTrans' sets the statusId of the record to be saved to value="FINACT_TRNS_APPROVED". This is wrong: the statusId of such a record should be: "FINACT_TRNS_CREATED" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10686) FinAccountTrans record can't be edited
Pierre Smits created OFBIZ-10686: Summary: FinAccountTrans record can't be edited Key: OFBIZ-10686 URL: https://issues.apache.org/jira/browse/OFBIZ-10686 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: Release Branch 16.11, Release Branch 15.12, Trunk, Release Branch 17.12 Environment: When a FinAccountTrans record is created and saved (via [1]) it should be possible to modify (some) elements. However this is not possible. The result of the create/save action leads to [2], and the FinAccountTrans record can only be cancelled. The user should be able to edit the FinAccountTrans when its StatusId = 'FINACT_TRNS_CREATED' [1] [https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccountTrans?finAccountId=ABN_CHECKING] [2] https://demo-trunk.ofbiz.apache.org/accounting/control/FindFinAccountTrans?finAccountId=ABN_CHECKING Reporter: Pierre Smits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
[ https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10655. --- Resolution: Fixed Fix Version/s: 17.12.01 Thanks Jinghai, I backported in R17 at r1848009. I fixed 2 small conflicts by hand in AbstractPricatParser and SamplePricatParser.java > OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package > - > > Key: OFBIZ-10655 > URL: https://issues.apache.org/jira/browse/OFBIZ-10655 > Project: OFBiz > Issue Type: Bug > Components: pricat >Affects Versions: Trunk, 17.12.01 >Reporter: Jacques Le Roux >Assignee: Shi Jinghai >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-10655.patch > > > Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-5303) Attic defunct 'iDeal' code
[ https://issues.apache.org/jira/browse/OFBIZ-5303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706809#comment-16706809 ] Jacques Le Roux commented on OFBIZ-5303: Hi Pierre, Sorry, what is missing? I thought we "jus"t needed to change DATAMODEL_CHANGES.md and wiki page. My question is will you handle it? Because it's assigned to you. Else someone else can take care, thanks. > Attic defunct 'iDeal' code > -- > > Key: OFBIZ-5303 > URL: https://issues.apache.org/jira/browse/OFBIZ-5303 > Project: OFBiz > Issue Type: Improvement > Components: accounting, ecommerce, order, product >Affects Versions: SlimDown, Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Fix For: Upcoming Branch > > > Currently we have multiple payment processors (e.g. worldpay and iDeal) > integrated in the Accounting component. > However, in order to reduce to basic functionality in the standard > applications/components and to be in sync with other solutions that use > third-party apps, these should be moved out of the basic applications. > Not only does that reduce maintenance on and resource consumption by the > basic applications, but it also gives end-users and implementers a choice > regarding the processor(s). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
