[jira] [Closed] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-5157.
--
Resolution: Fixed
Fix Version/s: (was: Trunk)
16.11.06
17.12.01
Fixed in
trunk r1848263
R17 r1848266
R16 r1848267
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release
> Branch 17.12
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 16.11.06, Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711084#comment-16711084
]
Jacques Le Roux commented on OFBIZ-5157:
Thanks Benjamin,
I had really hard time to reproduce. At one moment I thought it could be due to
a side effect of my recent changes with the autologin cookie (eg OFBIZ-10666).
Note: those cookies stay for one year or until you logout or use the "Not you"
link in the header. Even after manually clearing the cookie in the browser I
could not reproduce.
But my error was that I did no close my browser, FF in my case. All browsers
need you to close to really delete expired cookies. BTW here is some humour
about
that|https://www.theonion.com/after-checking-your-bank-account-remember-to-log-out-1819584860].
But FF is snarky because [it does not delete expired cookies immediately even
if you close FF|https://support.mozilla.org/fr/questions/983361]. So when you
quickly look at them in the browser they are still there. So I tried with IE,
Chrome and could still not reproduce (forgot to close the browsers again). I
finally remembered the funny story from Onion, et voilà, pfew :)
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release
> Branch 17.12
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04, Trunk
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
[jira] [Closed] (OFBIZ-9791) builds in git fail quickly
[ https://issues.apache.org/jira/browse/OFBIZ-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-9791. --- Resolution: Duplicate Fix Version/s: (was: Trunk) 17.12.01 > builds in git fail quickly > -- > > Key: OFBIZ-9791 > URL: https://issues.apache.org/jira/browse/OFBIZ-9791 > Project: OFBiz > Issue Type: Bug > Components: Gradle >Affects Versions: Trunk >Reporter: Adam Heath >Assignee: Mathieu Lirzin >Priority: Major > Fix For: 17.12.01 > > > Empty folders in git are not stored. Please make the build.gradle handle > missing folders. > The correct fix is to *NOT* store a README or something in the plugins/ > folder. > == > 10:43:01 -0500 adam@tooz(trunk):/srv/development/ofbiz/ofbiz-github$ > ./gradlew build > FAILURE: Build failed with an exception. > * Where: > Script '/srv/development/ofbiz/ofbiz-github/common.gradle' line: 37 > * What went wrong: > A problem occurred evaluating settings 'ofbiz'. > > /srv/development/ofbiz/ofbiz-github/plugins > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > BUILD FAILED > Total time: 0.415 secs > == -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-9791) builds in git fail quickly
[ https://issues.apache.org/jira/browse/OFBIZ-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reopened OFBIZ-9791: - > builds in git fail quickly > -- > > Key: OFBIZ-9791 > URL: https://issues.apache.org/jira/browse/OFBIZ-9791 > Project: OFBiz > Issue Type: Bug > Components: Gradle >Affects Versions: Trunk >Reporter: Adam Heath >Assignee: Mathieu Lirzin >Priority: Major > Fix For: Trunk > > > Empty folders in git are not stored. Please make the build.gradle handle > missing folders. > The correct fix is to *NOT* store a README or something in the plugins/ > folder. > == > 10:43:01 -0500 adam@tooz(trunk):/srv/development/ofbiz/ofbiz-github$ > ./gradlew build > FAILURE: Build failed with an exception. > * Where: > Script '/srv/development/ofbiz/ofbiz-github/common.gradle' line: 37 > * What went wrong: > A problem occurred evaluating settings 'ofbiz'. > > /srv/development/ofbiz/ofbiz-github/plugins > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > BUILD FAILED > Total time: 0.415 secs > == -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10424) After login shopping cart is cleared.
[ https://issues.apache.org/jira/browse/OFBIZ-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710426#comment-16710426 ] Jacques Le Roux commented on OFBIZ-10424: - Hi [~nk_smallbee], Please close this issue if you agree. I'll close it in a week if nothing happens, thanks > After login shopping cart is cleared. > - > > Key: OFBIZ-10424 > URL: https://issues.apache.org/jira/browse/OFBIZ-10424 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Jason Hao >Assignee: Deepak Nigam >Priority: Major > > Open ecommerce page, add some product to shopping cart, and click one page > checkout, login with admin/ofbiz, the it will display the Main page, and > shopping cart is cleared. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10694) Generating Asciidoc documentation fails
[
https://issues.apache.org/jira/browse/OFBIZ-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710410#comment-16710410
]
Jacques Le Roux edited comment on OFBIZ-10694 at 12/5/18 5:55 PM:
--
Thanks Mathieu,
We crossed on wire indeed. I'm not sure which solution we should pick, let's
discuss that in dev ML. Would you start the convo?
was (Author: jacques.le.roux):
Thanks Mathieu,
I'm not sure which solution we should pick, let's discuss that in dev ML. Would
you start the convo?
> Generating Asciidoc documentation fails
> ---
>
> Key: OFBIZ-10694
> URL: https://issues.apache.org/jira/browse/OFBIZ-10694
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10694.patch
>
>
> When trying tasks generateOfbizDocumentation or
> generateAllPluginsDocumentation I get
> {code:java}
> C:\projectsASF\ofbiz>gradlew generateOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
> at org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
> at
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
> at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
> at groovy.lang.Reference.(Reference.java:38)
> at
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions.
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load
> version 2.4.7
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
> at groovy.lang.GroovySystem.(GroovySystem.java:36)
> ... 5 more
> {code}
> [Some|https://github.com/gradle/gradle/issues/3698] suggest to
> bq. "add configurations.all { exclude module: 'groovy-all' } to the
> buildscript closure"
> It works but it's a workaround, so this Jira just to remember that it's
> temporary.
> I guess it's reated to updating to Gradle 5. Should I commit?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10694) Generating Asciidoc documentation fails
[
https://issues.apache.org/jira/browse/OFBIZ-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710410#comment-16710410
]
Jacques Le Roux commented on OFBIZ-10694:
-
Thanks Mathieu,
I'm not sure which solution we should pick, let's discuss that in dev ML. Would
you start the convo?
> Generating Asciidoc documentation fails
> ---
>
> Key: OFBIZ-10694
> URL: https://issues.apache.org/jira/browse/OFBIZ-10694
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10694.patch
>
>
> When trying tasks generateOfbizDocumentation or
> generateAllPluginsDocumentation I get
> {code:java}
> C:\projectsASF\ofbiz>gradlew generateOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
> at org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
> at
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
> at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
> at groovy.lang.Reference.(Reference.java:38)
> at
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions.
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load
> version 2.4.7
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
> at groovy.lang.GroovySystem.(GroovySystem.java:36)
> ... 5 more
> {code}
> [Some|https://github.com/gradle/gradle/issues/3698] suggest to
> bq. "add configurations.all { exclude module: 'groovy-all' } to the
> buildscript closure"
> It works but it's a workaround, so this Jira just to remember that it's
> temporary.
> I guess it's reated to updating to Gradle 5. Should I commit?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10695) Improve Gradle code
[
https://issues.apache.org/jira/browse/OFBIZ-10695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710390#comment-16710390
]
Mathieu Lirzin commented on OFBIZ-10695:
I have included a series of patches which are meant to be applied in order.
> Improve Gradle code
> ---
>
> Key: OFBIZ-10695
> URL: https://issues.apache.org/jira/browse/OFBIZ-10695
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10695_0001-Use-anyMatch-in-subprojectExists.patch,
> OFBIZ-10695_0002-Replace-iterateOverActiveComponents-with-activeCompo.patch,
> OFBIZ-10695_0003-Rewrite-getDirectoryInActiveComponentsIfExists.patch,
> OFBIZ-10695_0004-Rewrite-installAllPlugins.patch,
> OFBIZ-10695_0005-Use-findAll-in-installPlugin-and-generatePluginDocum.patch
>
>
> It would be nice to improve readability to use a more declarative style in
> Gradle code. Moreover the use of Stream avoids the use of callback based
> methods like what is done in {{iterateOverActiveComponents}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10695) Improve Gradle code
[
https://issues.apache.org/jira/browse/OFBIZ-10695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10695:
---
Attachment: OFBIZ-10695_0001-Use-anyMatch-in-subprojectExists.patch
OFBIZ-10695_0002-Replace-iterateOverActiveComponents-with-activeCompo.patch
OFBIZ-10695_0003-Rewrite-getDirectoryInActiveComponentsIfExists.patch
OFBIZ-10695_0004-Rewrite-installAllPlugins.patch
OFBIZ-10695_0005-Use-findAll-in-installPlugin-and-generatePluginDocum.patch
> Improve Gradle code
> ---
>
> Key: OFBIZ-10695
> URL: https://issues.apache.org/jira/browse/OFBIZ-10695
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10695_0001-Use-anyMatch-in-subprojectExists.patch,
> OFBIZ-10695_0002-Replace-iterateOverActiveComponents-with-activeCompo.patch,
> OFBIZ-10695_0003-Rewrite-getDirectoryInActiveComponentsIfExists.patch,
> OFBIZ-10695_0004-Rewrite-installAllPlugins.patch,
> OFBIZ-10695_0005-Use-findAll-in-installPlugin-and-generatePluginDocum.patch
>
>
> It would be nice to improve readability to use a more declarative style in
> Gradle code. Moreover the use of Stream avoids the use of callback based
> methods like what is done in {{iterateOverActiveComponents}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10695) Improve Gradle code
Mathieu Lirzin created OFBIZ-10695:
--
Summary: Improve Gradle code
Key: OFBIZ-10695
URL: https://issues.apache.org/jira/browse/OFBIZ-10695
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Mathieu Lirzin
Fix For: Upcoming Branch
It would be nice to improve readability to use a more declarative style in
Gradle code. Moreover the use of Stream avoids the use of callback based
methods like what is done in {{iterateOverActiveComponents}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OFBIZ-9791) builds in git fail quickly
[ https://issues.apache.org/jira/browse/OFBIZ-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin resolved OFBIZ-9791. --- Resolution: Fixed Assignee: Mathieu Lirzin Fix Version/s: Trunk > builds in git fail quickly > -- > > Key: OFBIZ-9791 > URL: https://issues.apache.org/jira/browse/OFBIZ-9791 > Project: OFBiz > Issue Type: Bug > Components: Gradle >Affects Versions: Trunk >Reporter: Adam Heath >Assignee: Mathieu Lirzin >Priority: Major > Fix For: Trunk > > > Empty folders in git are not stored. Please make the build.gradle handle > missing folders. > The correct fix is to *NOT* store a README or something in the plugins/ > folder. > == > 10:43:01 -0500 adam@tooz(trunk):/srv/development/ofbiz/ofbiz-github$ > ./gradlew build > FAILURE: Build failed with an exception. > * Where: > Script '/srv/development/ofbiz/ofbiz-github/common.gradle' line: 37 > * What went wrong: > A problem occurred evaluating settings 'ofbiz'. > > /srv/development/ofbiz/ofbiz-github/plugins > * Try: > Run with --stacktrace option to get the stack trace. Run with --info or > --debug option to get more log output. > BUILD FAILED > Total time: 0.415 secs > == -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9791) builds in git fail quickly
[
https://issues.apache.org/jira/browse/OFBIZ-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710360#comment-16710360
]
Mathieu Lirzin commented on OFBIZ-9791:
---
This has been fixed in revision 1787144 which is related to OFBIZ-9262 by
adding {{mkdir "${rootDir}/plugins"}} in {{common.gradle}}.
> builds in git fail quickly
> --
>
> Key: OFBIZ-9791
> URL: https://issues.apache.org/jira/browse/OFBIZ-9791
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Adam Heath
>Priority: Major
>
> Empty folders in git are not stored. Please make the build.gradle handle
> missing folders.
> The correct fix is to *NOT* store a README or something in the plugins/
> folder.
> ==
> 10:43:01 -0500 adam@tooz(trunk):/srv/development/ofbiz/ofbiz-github$
> ./gradlew build
> FAILURE: Build failed with an exception.
> * Where:
> Script '/srv/development/ofbiz/ofbiz-github/common.gradle' line: 37
> * What went wrong:
> A problem occurred evaluating settings 'ofbiz'.
> > /srv/development/ofbiz/ofbiz-github/plugins
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output.
> BUILD FAILED
> Total time: 0.415 secs
> ==
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10694) Generating Asciidoc documentation fails
[
https://issues.apache.org/jira/browse/OFBIZ-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710331#comment-16710331
]
Mathieu Lirzin commented on OFBIZ-10694:
Hello Jacques,
This report is the same as OFBIZ-10693. :)
> Generating Asciidoc documentation fails
> ---
>
> Key: OFBIZ-10694
> URL: https://issues.apache.org/jira/browse/OFBIZ-10694
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10694.patch
>
>
> When trying tasks generateOfbizDocumentation or
> generateAllPluginsDocumentation I get
> {code:java}
> C:\projectsASF\ofbiz>gradlew generateOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
> at org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
> at
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
> at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
> at groovy.lang.Reference.(Reference.java:38)
> at
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions.
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load
> version 2.4.7
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
> at groovy.lang.GroovySystem.(GroovySystem.java:36)
> ... 5 more
> {code}
> [Some|https://github.com/gradle/gradle/issues/3698] suggest to
> bq. "add configurations.all { exclude module: 'groovy-all' } to the
> buildscript closure"
> It works but it's a workaround, so this Jira just to remember that it's
> temporary.
> I guess it's reated to updating to Gradle 5. Should I commit?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10694) Generating Asciidoc documentation fails
[
https://issues.apache.org/jira/browse/OFBIZ-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-10694:
Attachment: OFBIZ-10694.patch
> Generating Asciidoc documentation fails
> ---
>
> Key: OFBIZ-10694
> URL: https://issues.apache.org/jira/browse/OFBIZ-10694
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10694.patch
>
>
> When trying tasks generateOfbizDocumentation or
> generateAllPluginsDocumentation I get
> {code:java}
> C:\projectsASF\ofbiz>gradlew generateOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
> at org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
> at
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
> at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
> at groovy.lang.Reference.(Reference.java:38)
> at
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions.
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load
> version 2.4.7
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
> at groovy.lang.GroovySystem.(GroovySystem.java:36)
> ... 5 more
> {code}
> [Some|https://github.com/gradle/gradle/issues/3698] suggest to
> bq. "add configurations.all { exclude module: 'groovy-all' } to the
> buildscript closure"
> It works but it's a workaround, so this Jira just to remember that it's
> temporary.
> I guess it's reated to updating to Gradle 5. Should I commit?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
[
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710321#comment-16710321
]
Mathieu Lirzin commented on OFBIZ-10693:
I have included
[^OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch] which
downgrades AsciiDoc Gradle Plugin 1.5.9.1 → 1.5.8.1 to fix the issue. To
explain why I tried to do that, I have deduced from the above stacktrace that
the {{org.asciidoctor.gradle.backported.AsciidoctorJavaExec}} class was causing
the issue and since it was introduced in 1.5.9 as stated in the comment at the
top of [its source file|
https://github.com/asciidoctor/asciidoctor-gradle-plugin/blob/development/src/main/groovy/org/asciidoctor/gradle/backported/AsciidoctorJavaExec.groovy]
I have tried the latest version before this release.
> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
>
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Attachments:
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
> at
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
> at
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
> at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
> at groovy.lang.Reference.(Reference.java:38)
> at
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions.
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load
> version 2.4.7
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
> at groovy.lang.GroovySystem.(GroovySystem.java:36)
> ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java''
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
[
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10693:
---
Attachment:
OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
>
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
> Attachments:
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
> at
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
> at
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
> at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
> at groovy.lang.Reference.(Reference.java:38)
> at
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions.
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load
> version 2.4.7
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
> at groovy.lang.GroovySystem.(GroovySystem.java:36)
> ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java''
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10694) Generating Asciidoc documentation fails
Jacques Le Roux created OFBIZ-10694:
---
Summary: Generating Asciidoc documentation fails
Key: OFBIZ-10694
URL: https://issues.apache.org/jira/browse/OFBIZ-10694
Project: OFBiz
Issue Type: Bug
Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Jacques Le Roux
When trying tasks generateOfbizDocumentation or generateAllPluginsDocumentation
I get
{code:java}
C:\projectsASF\ofbiz>gradlew generateOfbizDocumentation
> Task :generateOfbizDocumentation FAILED
Exception in thread "main" java.lang.ExceptionInInitializerError
at org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
at
groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
at groovy.lang.Reference.(Reference.java:38)
at
org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions.
Module [groovy-all is loaded in version 2.5.4 and you are trying to load
version 2.4.7
at
org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
at
org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
at
org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
at
org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
at
org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
at
org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
at
org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
at groovy.lang.GroovySystem.(GroovySystem.java:36)
... 5 more
{code}
[Some|https://github.com/gradle/gradle/issues/3698] suggest to
bq. "add configurations.all { exclude module: 'groovy-all' } to the buildscript
closure"
It works but it's a workaround, so this Jira just to remember that it's
temporary.
I guess it's reated to updating to Gradle 5. Should I commit?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10213) Update build.gradle to the latest dependencies
[
https://issues.apache.org/jira/browse/OFBIZ-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-10213:
Description:
We want to check from time to time if we need to update the dependencies.
It's easyly done with the [gradle-versions-plugin
|https://github.com/ben-manes/gradle-versions-plugin] which analyzes the
dependencies and checks if there are newer versions available.
Using this patch
{code}
Index: build.gradle
===
--- build.gradle(révision 1831078)
+++ build.gradle(copie de travail)
@@ -33,6 +33,7 @@
classpath 'org.asciidoctor:asciidoctorj-pdf:1.5.0-alpha.16'
// asciidoctorj-pdf bug workaround - override jruby. See OFBIZ-9873
classpath 'org.jruby:jruby-complete:9.1.13.0'
+classpath 'com.github.ben-manes:gradle-versions-plugin:0.20.0'
}
}
apply plugin: 'java'
@@ -40,6 +41,7 @@
apply plugin: 'maven-publish'
apply plugin: "at.bxm.svntools"
apply plugin: 'org.asciidoctor.convert'
+apply plugin: 'com.github.ben-manes.versions'
apply from: 'common.gradle'
{code}
And running the check with
{code:java}
./gradlew dependencyUpdates -Drevision=release
{code}
We get a list of dependencies to update. This is an umbrella task for action
tasks.
was:
We want to check from time to time if we need to update the dependencies.
It's easyly done with the [gradle-versions-plugin
|https://github.com/ben-manes/gradle-versions-plugin] which analyzes the
dependencies and checks if there are newer versions available.
Using this patch
{code}
Index: build.gradle
===
--- build.gradle(révision 1831078)
+++ build.gradle(copie de travail)
@@ -33,6 +33,7 @@
classpath 'org.asciidoctor:asciidoctorj-pdf:1.5.0-alpha.16'
// asciidoctorj-pdf bug workaround - override jruby. See OFBIZ-9873
classpath 'org.jruby:jruby-complete:9.1.13.0'
+classpath 'com.github.ben-manes:gradle-versions-plugin:0.17.0'
}
}
apply plugin: 'java'
@@ -40,6 +41,7 @@
apply plugin: 'maven-publish'
apply plugin: "at.bxm.svntools"
apply plugin: 'org.asciidoctor.convert'
+apply plugin: 'com.github.ben-manes.versions'
apply from: 'common.gradle'
{code}
And running the check with
{code:java}
./gradlew dependencyUpdates -Drevision=release
{code}
We get a list of dependencies to update. This is an umbrella task for action
tasks.
> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10213
> URL: https://issues.apache.org/jira/browse/OFBIZ-10213
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Trivial
>
> We want to check from time to time if we need to update the dependencies.
> It's easyly done with the [gradle-versions-plugin
> |https://github.com/ben-manes/gradle-versions-plugin] which analyzes the
> dependencies and checks if there are newer versions available.
> Using this patch
> {code}
> Index: build.gradle
> ===
> --- build.gradle(révision 1831078)
> +++ build.gradle(copie de travail)
> @@ -33,6 +33,7 @@
> classpath 'org.asciidoctor:asciidoctorj-pdf:1.5.0-alpha.16'
> // asciidoctorj-pdf bug workaround - override jruby. See OFBIZ-9873
> classpath 'org.jruby:jruby-complete:9.1.13.0'
> +classpath 'com.github.ben-manes:gradle-versions-plugin:0.20.0'
> }
> }
> apply plugin: 'java'
> @@ -40,6 +41,7 @@
> apply plugin: 'maven-publish'
> apply plugin: "at.bxm.svntools"
> apply plugin: 'org.asciidoctor.convert'
> +apply plugin: 'com.github.ben-manes.versions'
>
> apply from: 'common.gradle'
> {code}
> And running the check with
> {code:java}
> ./gradlew dependencyUpdates -Drevision=release
> {code}
> We get a list of dependencies to update. This is an umbrella task for action
> tasks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
[
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710245#comment-16710245
]
Mathieu Lirzin commented on OFBIZ-10693:
I am currently investigating this issue by trying to find a workaround to avoid
downgrading Gradle.
> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
>
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
> at
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
> at
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
> at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
> at groovy.lang.Reference.(Reference.java:38)
> at
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions.
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load
> version 2.4.7
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
> at groovy.lang.GroovySystem.(GroovySystem.java:36)
> ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java''
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
[
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-10693:
--
Assignee: Mathieu Lirzin
> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
>
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Major
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
> at
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
> at
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
> at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
> at groovy.lang.Reference.(Reference.java:38)
> at
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions.
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load
> version 2.4.7
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
> at groovy.lang.GroovySystem.(GroovySystem.java:36)
> ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java''
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
Mathieu Lirzin created OFBIZ-10693:
--
Summary: ‘./gradlew generateOfbizDocumentation’ fails with Gradle
5.0
Key: OFBIZ-10693
URL: https://issues.apache.org/jira/browse/OFBIZ-10693
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Mathieu Lirzin
We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew
generateOfbizDocumentation}} command fails with the following stacktrace
{code:java}
> Task :deleteOfbizDocumentation
> Task :generateOfbizDocumentation FAILED
Exception in thread "main" java.lang.ExceptionInInitializerError
at
org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
at
groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
at groovy.lang.Reference.(Reference.java:38)
at
org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions.
Module [groovy-all is loaded in version 2.5.4 and you are trying to load
version 2.4.7
at
org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
at
org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
at
org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
at
org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
at
org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
at
org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
at
org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
at groovy.lang.GroovySystem.(GroovySystem.java:36)
... 5 more
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':generateOfbizDocumentation'.
> Process 'command
> '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java''
> finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 1s
2 actionable tasks: 2 executed
{code}
It seems that the [AsciiDoctor Gradle
Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing
because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
I would be nice to work around this issue instead of downgrading Gradle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
[
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10693:
---
Issue Type: Bug (was: Improvement)
> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
>
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Major
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
> at
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
> at
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
> at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
> at groovy.lang.Reference.(Reference.java:38)
> at
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions.
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load
> version 2.4.7
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
> at
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
> at
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
> at groovy.lang.GroovySystem.(GroovySystem.java:36)
> ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java''
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710133#comment-16710133
]
Benjamin Jugl commented on OFBIZ-5157:
--
I think what Mirko wrote is a bit misleading. It can be reproduced by setting
the product_store field autoSaveCart to 'Y' (In Store 9000 for the demo-data).
Then the error occurs upon the first visit of the ecommerce-site, provided the
user is not logged in.
* First Visit: no userLogin
* ofbiz wants to autosave list
* saving list requires userLogin (forsecuritycheck)
* result: error
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release
> Branch 17.12
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04, Trunk
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10689: Attachment: (was: OFBIZ-10689-simpleTypeOrObjectConvert.patch) > function parseBigDecimalForEntity is in wrong location > -- > > Key: OFBIZ-10689 > URL: https://issues.apache.org/jira/browse/OFBIZ-10689 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, > Release Branch 17.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10689-rename.patch > > > Currently the function 'parseBigDecimalForEntity' is located in > ProductEvents.java. > Given that this function applies to more than just products, this function > should be located in the framework stack. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710113#comment-16710113 ] Jacques Le Roux commented on OFBIZ-10689: - I attached [^OFBIZ-10689-rename.patch] as a simple Javadoc renaming. I can also handle the complete method renaming if we want. > function parseBigDecimalForEntity is in wrong location > -- > > Key: OFBIZ-10689 > URL: https://issues.apache.org/jira/browse/OFBIZ-10689 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, > Release Branch 17.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10689-rename.patch > > > Currently the function 'parseBigDecimalForEntity' is located in > ProductEvents.java. > Given that this function applies to more than just products, this function > should be located in the framework stack. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710114#comment-16710114
]
Jacques Le Roux commented on OFBIZ-5157:
Thanks Benjamin,
I'm unable to reproduce the error on trunk demo (nor locally before applying
the patch). Could you please confirm the error still exists and how to
reproduce. I tried what Mirko wrote, so maybe I miss something?
BTW OFBIZ-10418, which I think is not related, is much more annoying.
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release
> Branch 17.12
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04, Trunk
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710113#comment-16710113 ] Jacques Le Roux edited comment on OFBIZ-10689 at 12/5/18 2:17 PM: -- I attached [^OFBIZ-10689-rename.patch] as a simple Javadoc renaming. I can also handle the complete method renaming if we want. Please review and let me know, thanks. was (Author: jacques.le.roux): I attached [^OFBIZ-10689-rename.patch] as a simple Javadoc renaming. I can also handle the complete method renaming if we want. > function parseBigDecimalForEntity is in wrong location > -- > > Key: OFBIZ-10689 > URL: https://issues.apache.org/jira/browse/OFBIZ-10689 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, > Release Branch 17.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10689-rename.patch > > > Currently the function 'parseBigDecimalForEntity' is located in > ProductEvents.java. > Given that this function applies to more than just products, this function > should be located in the framework stack. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10689: Attachment: OFBIZ-10689-rename.patch > function parseBigDecimalForEntity is in wrong location > -- > > Key: OFBIZ-10689 > URL: https://issues.apache.org/jira/browse/OFBIZ-10689 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, > Release Branch 17.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10689-rename.patch > > > Currently the function 'parseBigDecimalForEntity' is located in > ProductEvents.java. > Given that this function applies to more than just products, this function > should be located in the framework stack. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leila Mekika updated OFBIZ-10692:
-
Attachment: OFBIZ-10692-TEST.patch
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using \{run
> service} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
>
> [https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company]
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With OFBIZ-10692.patch update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leila Mekika updated OFBIZ-10692:
-
Attachment: (was: OFBIZ-10692-TEST.patch)
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using \{run
> service} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
>
> [https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company]
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With OFBIZ-10692.patch update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leila Mekika updated OFBIZ-10692:
-
Attachment: OFBIZ-10692-TEST.patch
OFBIZ-10692.patch
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using \{run
> service} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch 'OFBIZ-10692_test.patch' (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
>
> [https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company]
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With OFBIZ-10692.patch update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leila Mekika updated OFBIZ-10692:
-
Description:
Like discussed in thread :
[https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
This ticket try to improve the way that errors are rendered when using \{run
service} groovy DSL method.
To reproduce and test patch:
apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
createUomConversionDated service) and try to create a conversion rate with a
fromDate greater than the thruDate here:
[https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company]
You should then see the following error:
The Following Errors Occurred: Error calling event:
org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
(org.apache.ofbiz.service.ExecutionServiceException: Through date can't be same
or smaller than from date)
With OFBIZ-10692.patch update, the error must be displayed like:
The Following Errors Occurred: Through date can't be same or smaller than
from date
was:
Like discussed in thread :
[https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
This ticket try to improve the way that errors are rendered when using \{run
service} groovy DSL method.
To reproduce and test patch:
apply the attached patch 'OFBIZ-10692_test.patch' (it adds a control on
createUomConversionDated service) and try to create a conversion rate with a
fromDate greater than the thruDate here:
[https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company]
You should then see the following error:
The Following Errors Occurred: Error calling event:
org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
(org.apache.ofbiz.service.ExecutionServiceException: Through date can't be same
or smaller than from date)
With OFBIZ-10692.patch update, the error must be displayed like:
The Following Errors Occurred: Through date can't be same or smaller than
from date
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692-TEST.patch, OFBIZ-10692.patch
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using \{run
> service} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch [^OFBIZ-10692-TEST.patch] (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
>
> [https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company]
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With OFBIZ-10692.patch update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leila Mekika updated OFBIZ-10692:
-
Attachment: (was: OFBIZ-10692.patch)
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Priority: Minor
> Labels: patch
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using \{run
> service} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch 'OFBIZ-10692_test.patch' (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
>
> [https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company]
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With OFBIZ-10692.patch update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller
> than from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leila Mekika updated OFBIZ-10692:
-
Labels: patch (was: )
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Priority: Minor
> Labels: patch
> Attachments: OFBIZ-10692.patch
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using \{run
> service} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch 'OFBIZ-10692.patch' (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
> [https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company]
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With OFBIZ-10692.patch update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller than
> from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10689: --- Assignee: Jacques Le Roux > function parseBigDecimalForEntity is in wrong location > -- > > Key: OFBIZ-10689 > URL: https://issues.apache.org/jira/browse/OFBIZ-10689 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, > Release Branch 17.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10689-simpleTypeOrObjectConvert.patch > > > Currently the function 'parseBigDecimalForEntity' is located in > ProductEvents.java. > Given that this function applies to more than just products, this function > should be located in the framework stack. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-5157:
--
Assignee: Jacques Le Roux (was: Benjamin Jugl)
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release
> Branch 17.12
>Reporter: Mirko Vogelsmeier
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 12.04, Trunk
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709929#comment-16709929
]
Benjamin Jugl commented on OFBIZ-5157:
--
Yes, thank you. I was not sure how to handle this. When the feedback for this
patch is positive, I can provide backports for 16.11 and 17.12
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release
> Branch 17.12
>Reporter: Mirko Vogelsmeier
>Assignee: Benjamin Jugl
>Priority: Major
> Fix For: Release Branch 12.04, Trunk
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache
[ https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709916#comment-16709916 ] Mathieu Lirzin commented on OFBIZ-10579: Additionally given that this caching policy is far from trivial (and still fuzzy to me), I think it is important to add some tests to prove that the cases you considered are properly handle and that future refactoring don't overlook some of them. Ideally the tests should be unit tests, but if this too hard to extract dependencies and mock them, integration tests would be fine too. > Date filtered queries with caching should be restricted to cache > > > Key: OFBIZ-10579 > URL: https://issues.apache.org/jira/browse/OFBIZ-10579 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10579.patch, OFBIZ-10579.patch > > > As per discussion on Dev ML > https://markmail.org/thread/3qnkihmsyhly3lsg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache
[
https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709892#comment-16709892
]
Mathieu Lirzin commented on OFBIZ-10579:
Thanks [~suraj.khurana] for the explanation. Instead of warning that the wrong
thing was done, shouldn't we do the right thing meaning not putting the query
in the cache and letting the caller know with the return value of the {{put}}
method? The returned value could be {{null}} or {{Optional.empty()}} in the
"date filtering" case for example.
> Date filtered queries with caching should be restricted to cache
>
>
> Key: OFBIZ-10579
> URL: https://issues.apache.org/jira/browse/OFBIZ-10579
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10579.patch, OFBIZ-10579.patch
>
>
> As per discussion on Dev ML
> https://markmail.org/thread/3qnkihmsyhly3lsg
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-5157:
Affects Version/s: Release Branch 13.07
Release Branch 14.12
Release Branch 15.12
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release
> Branch 17.12
>Reporter: Mirko Vogelsmeier
>Assignee: Benjamin Jugl
>Priority: Major
> Fix For: Release Branch 12.04, Trunk
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Issue Comment Deleted] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-5157:
Comment: was deleted
(was: As this is a bug I presume that this has been existing since the
beginning. Should the 'Affects Version(s)' field not be set accordingly, and
not just to 'Trunk'?)
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04, Trunk, Release Branch 16.11,
> Release Branch 17.12
>Reporter: Mirko Vogelsmeier
>Assignee: Benjamin Jugl
>Priority: Major
> Fix For: Release Branch 12.04, Trunk
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709891#comment-16709891
]
Pierre Smits commented on OFBIZ-5157:
-
As this is a bug I presume that this has been existing since the beginning.
Should the 'Affects Version(s)' field not be set accordingly, and not just to
'Trunk'?
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04, Trunk, Release Branch 16.11,
> Release Branch 17.12
>Reporter: Mirko Vogelsmeier
>Assignee: Benjamin Jugl
>Priority: Major
> Fix For: Release Branch 12.04, Trunk
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709794#comment-16709794
]
Benjamin Jugl commented on OFBIZ-5157:
--
Provided Patch is for Trunk.
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04, Trunk, Release Branch 16.11,
> Release Branch 17.12
>Reporter: Mirko Vogelsmeier
>Assignee: Benjamin Jugl
>Priority: Major
> Fix For: Release Branch 12.04, Trunk
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Jugl updated OFBIZ-5157:
-
Affects Version/s: Release Branch 17.12
Trunk
Release Branch 16.11
Fix Version/s: Trunk
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04, Trunk, Release Branch 16.11,
> Release Branch 17.12
>Reporter: Mirko Vogelsmeier
>Assignee: Benjamin Jugl
>Priority: Major
> Fix For: Release Branch 12.04, Trunk
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Jugl reassigned OFBIZ-5157:
Assignee: Benjamin Jugl (was: Dennis Balkir)
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Benjamin Jugl
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Jugl updated OFBIZ-5157:
-
Attachment: OFBIZ-5157-ShoppingListEvents.patch
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Dennis Balkir
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous
[
https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709749#comment-16709749
]
Benjamin Jugl commented on OFBIZ-5157:
--
I had a look into this issue. Problem is, that the security-check needs a
userLogin. This is not available, when the autoSaveShoppingList wants to save
for the first time. Thus ecommerce throws the error-message on first load. I
fixed it by simply adding a condition to check for existing userLogin, every
time it is checked for auto-save.
> Error on createShoppingListItem when adding item to cart as anonymous
> -
>
> Key: OFBIZ-5157
> URL: https://issues.apache.org/jira/browse/OFBIZ-5157
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 12.04
>Reporter: Mirko Vogelsmeier
>Assignee: Dennis Balkir
>Priority: Major
> Fix For: Release Branch 12.04
>
> Attachments: OFBIZ-5157-CodeCleanup.patch,
> OFBIZ-5157-ShoppingListEvents.patch, OFBIZ-5157-ShoppingListServices.patch
>
>
> When we add items to cart as a non-logged in user (ProductStore setting
> autoSaveCart on 'Y') ofbiz adds that item to ShoppingList as well. Following
> security error occures:
> {code}
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> UtilProperties.java:1063:INFO ] ResourceBundle MiniLangErrorUiLabels (en)
> created in 0.031s with 4 properties
> [java] 2013-03-19 17:56:15,713 (http-bio-0.0.0.0-8080-exec-4) [
> TransactionUtil.java:379:WARN ]
> [java] exception report
> --
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Error in simple-method [Create a ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java] stack trace
> ---
> [java] java.lang.Exception: Error in simple-method [Create a
> ShoppingList Item
> [file:/D:/Workspace/ofbiz/applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml#createShoppingListItem]]:
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:379)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:320)
> [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:582)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:275)
> [java]
> org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:294)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
> [java]
> org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:390)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:225)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:163)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.addBulkFromCart(ShoppingListEvents.java:167)
> [java]
> org.ofbiz.order.shoppinglist.ShoppingListEvents.fillAutoSaveList(ShoppingListEvents.java:425)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.setQuantity(ShoppingCartItem.java:1059)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:578)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:359)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCart.addOrIncreaseItem(ShoppingCart.java:583)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartHelper.addToCart(ShoppingCartHelper.java:246)
> [java]
> org.ofbiz.order.shoppingcart.ShoppingCartEvents.addToCart(ShoppingCartEvents.java:586)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leila Mekika updated OFBIZ-10692:
-
Description:
Like discussed in thread :
[https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
This ticket try to improve the way that errors are rendered when using \{run
service} groovy DSL method.
To reproduce and test patch:
apply the attached patch 'OFBIZ-10692.patch' (it adds a control on
createUomConversionDated service) and try to create a conversion rate with a
fromDate greater than the thruDate here:
[https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company]
You should then see the following error:
The Following Errors Occurred: Error calling event:
org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
(org.apache.ofbiz.service.ExecutionServiceException: Through date can't be same
or smaller than from date)
With OFBIZ-10692.patch update, the error must be displayed like:
The Following Errors Occurred: Through date can't be same or smaller than
from date
was:
Like discussed in thread :
[https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
This ticket try to improve the way that errors are rendered when using \{run
service} groovy DSL method.
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Priority: Major
> Attachments: OFBIZ-10692.patch
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using \{run
> service} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch 'OFBIZ-10692.patch' (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
> [https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company]
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With OFBIZ-10692.patch update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller than
> from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leila Mekika updated OFBIZ-10692:
-
Attachment: OFBIZ-10692.patch
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Priority: Major
> Attachments: OFBIZ-10692.patch
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using \{run
> service} groovy DSL method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10692) Groovy DSL runService Exception Management
[
https://issues.apache.org/jira/browse/OFBIZ-10692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leila Mekika updated OFBIZ-10692:
-
Priority: Minor (was: Major)
> Groovy DSL runService Exception Management
> --
>
> Key: OFBIZ-10692
> URL: https://issues.apache.org/jira/browse/OFBIZ-10692
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Priority: Minor
> Attachments: OFBIZ-10692.patch
>
>
> Like discussed in thread :
> [https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
>
> This ticket try to improve the way that errors are rendered when using \{run
> service} groovy DSL method.
>
> To reproduce and test patch:
> apply the attached patch 'OFBIZ-10692.patch' (it adds a control on
> createUomConversionDated service) and try to create a conversion rate with a
> fromDate greater than the thruDate here:
> [https://localhost:8443/accounting/control/viewFXConversions?organizationPartyId=Company]
>
> You should then see the following error:
> The Following Errors Occurred: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (org.apache.ofbiz.service.ExecutionServiceException: Through date can't be
> same or smaller than from date)
>
> With OFBIZ-10692.patch update, the error must be displayed like:
> The Following Errors Occurred: Through date can't be same or smaller than
> from date
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10692) Groovy DSL runService Exception Management
Leila Mekika created OFBIZ-10692:
Summary: Groovy DSL runService Exception Management
Key: OFBIZ-10692
URL: https://issues.apache.org/jira/browse/OFBIZ-10692
Project: OFBiz
Issue Type: Improvement
Affects Versions: Trunk
Reporter: Leila Mekika
Like discussed in thread :
[https://lists.apache.org/thread.html/5a8e1caed0bcf29889c6b88ec1916947cf092d6f99d7dfe27cbef8c0@%3Cdev.ofbiz.apache.org%3E]
This ticket try to improve the way that errors are rendered when using \{run
service} groovy DSL method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
