[jira] [Assigned] (OFBIZ-10815) Added translations es and es-CL

2019-01-17 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-10815:
---

Assignee: Jacques Le Roux

> Added translations es and es-CL 
> 
>
> Key: OFBIZ-10815
> URL: https://issues.apache.org/jira/browse/OFBIZ-10815
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres, marketing, party
>Affects Versions: Trunk
>Reporter: Jonathan
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: humanres, marketing, party
> Fix For: Upcoming Branch
>
> Attachments: Translations_es_es-CL.patch
>
>
> Added translations es, es-CL in files:
>  * CommonUiLabels
>  * PartyUiLabels
>  * MarketingUiLabels
>  * HumanResUiLabels
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2019-01-17 Thread Priya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745813#comment-16745813
 ] 

Priya Sharma commented on OFBIZ-10536:
--

Thanks for the clarification Jacques, that really helped.

I will look for a proper fix and the root cause of the issue and get back to 
you.

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Priya Sharma
>Priority: Major
> Attachments: Image 002.png, OFBIZ-10536.patch, 
> OFBIZ-10536_16-11.patch, Screenshot from 2018-12-24 17-37-07.png
>
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2019-01-17 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745790#comment-16745790
 ] 

Aditya Sharma commented on OFBIZ-10725:
---

Verified and done for all the instances in classes under application at 
r1851602.

> Refactor boolean returns from methods
> -
>
> Key: OFBIZ-10725
> URL: https://issues.apache.org/jira/browse/OFBIZ-10725
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10815) Added translations es and es-CL

2019-01-17 Thread Jonathan (JIRA)
Jonathan created OFBIZ-10815:


 Summary: Added translations es and es-CL 
 Key: OFBIZ-10815
 URL: https://issues.apache.org/jira/browse/OFBIZ-10815
 Project: OFBiz
  Issue Type: Improvement
  Components: humanres, marketing, party
Affects Versions: Trunk
Reporter: Jonathan
 Fix For: Upcoming Branch
 Attachments: Translations_es_es-CL.patch

Added translations es, es-CL in files:
 * CommonUiLabels
 * PartyUiLabels
 * MarketingUiLabels
 * HumanResUiLabels

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10814) Error parsing JWT

2019-01-17 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745245#comment-16745245
 ] 

Michael Brohl commented on OFBIZ-10814:
---

Added a simple Postman [1] collection for easy testing.

[1] https://www.getpostman.com/

> Error parsing JWT
> -
>
> Key: OFBIZ-10814
> URL: https://issues.apache.org/jira/browse/OFBIZ-10814
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Priority: Major
> Attachments: Apache OFBiz JWT Test.postman_collection.json
>
>
> I have problems using the Authorization: Bearer header value for requests 
> towards OFBiz. OFBiz has problems parsing externally generated JSON Web 
> Tokens.
> I have generated them using both [1] and [2] using HS512 and the default 
> secret.
> The JWT check fails because of a parsing error:
> {noformat}
> 2019-01-17 16:48:36,233 |jsse-nio-8443-exec-7 |JavaEventHandler  
> |E| Problems Processing Event
> io.jsonwebtoken.MalformedJwtException: Unable to read JSON value: 
> �z��'G�#�$�uB"�&�r#�$�3S"
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.readValue(DefaultJwtParser.java:554) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:252) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:481) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.parseClaimsJws(DefaultJwtParser.java:541)
>  ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> org.apache.ofbiz.webapp.control.JWTManager.validateToken(JWTManager.java:124) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.jwtValidation(ExternalLoginKeysManager.java:292)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.checkJWTLogin(ExternalLoginKeysManager.java:196)
>  ~[ofbiz.jar:?]
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_152]
>     at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_152]
>     at 
> org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:86)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:774)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:407)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:208) 
> [ofbiz.jar:?]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
>     at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
> [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> 

[jira] [Updated] (OFBIZ-10814) Error parsing JWT

2019-01-17 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10814:
--
Attachment: Apache OFBiz JWT Test.postman_collection.json

> Error parsing JWT
> -
>
> Key: OFBIZ-10814
> URL: https://issues.apache.org/jira/browse/OFBIZ-10814
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Priority: Major
> Attachments: Apache OFBiz JWT Test.postman_collection.json
>
>
> I have problems using the Authorization: Bearer header value for requests 
> towards OFBiz. OFBiz has problems parsing externally generated JSON Web 
> Tokens.
> I have generated them using both [1] and [2] using HS512 and the default 
> secret.
> The JWT check fails because of a parsing error:
> {noformat}
> 2019-01-17 16:48:36,233 |jsse-nio-8443-exec-7 |JavaEventHandler  
> |E| Problems Processing Event
> io.jsonwebtoken.MalformedJwtException: Unable to read JSON value: 
> �z��'G�#�$�uB"�&�r#�$�3S"
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.readValue(DefaultJwtParser.java:554) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:252) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:481) 
> ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> io.jsonwebtoken.impl.DefaultJwtParser.parseClaimsJws(DefaultJwtParser.java:541)
>  ~[jjwt-0.9.1.jar:0.9.1]
>     at 
> org.apache.ofbiz.webapp.control.JWTManager.validateToken(JWTManager.java:124) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.jwtValidation(ExternalLoginKeysManager.java:292)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.checkJWTLogin(ExternalLoginKeysManager.java:196)
>  ~[ofbiz.jar:?]
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_152]
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_152]
>     at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_152]
>     at 
> org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:86)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:774)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:407)
>  [ofbiz.jar:?]
>     at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:208) 
> [ofbiz.jar:?]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
>     at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
>  [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
> [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [tomcat-catalina-9.0.13.jar:9.0.13]
>     at 
> 

[jira] [Created] (OFBIZ-10814) Error parsing JWT

2019-01-17 Thread Michael Brohl (JIRA)
Michael Brohl created OFBIZ-10814:
-

 Summary: Error parsing JWT
 Key: OFBIZ-10814
 URL: https://issues.apache.org/jira/browse/OFBIZ-10814
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Michael Brohl


I have problems using the Authorization: Bearer header value for requests 
towards OFBiz. OFBiz has problems parsing externally generated JSON Web Tokens.

I have generated them using both [1] and [2] using HS512 and the default secret.

The JWT check fails because of a parsing error:
{noformat}
2019-01-17 16:48:36,233 |jsse-nio-8443-exec-7 |JavaEventHandler  
|E| Problems Processing Event
io.jsonwebtoken.MalformedJwtException: Unable to read JSON value: 
�z��'G�#�$�uB"�&�r#�$�3S"
    at 
io.jsonwebtoken.impl.DefaultJwtParser.readValue(DefaultJwtParser.java:554) 
~[jjwt-0.9.1.jar:0.9.1]
    at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:252) 
~[jjwt-0.9.1.jar:0.9.1]
    at io.jsonwebtoken.impl.DefaultJwtParser.parse(DefaultJwtParser.java:481) 
~[jjwt-0.9.1.jar:0.9.1]
    at 
io.jsonwebtoken.impl.DefaultJwtParser.parseClaimsJws(DefaultJwtParser.java:541) 
~[jjwt-0.9.1.jar:0.9.1]
    at 
org.apache.ofbiz.webapp.control.JWTManager.validateToken(JWTManager.java:124) 
~[ofbiz.jar:?]
    at 
org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.jwtValidation(ExternalLoginKeysManager.java:292)
 ~[ofbiz.jar:?]
    at 
org.apache.ofbiz.webapp.control.ExternalLoginKeysManager.checkJWTLogin(ExternalLoginKeysManager.java:196)
 ~[ofbiz.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_152]
    at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:1.8.0_152]
    at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:1.8.0_152]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_152]
    at 
org.apache.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:86) 
[ofbiz.jar:?]
    at 
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:774)
 [ofbiz.jar:?]
    at 
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:407)
 [ofbiz.jar:?]
    at 
org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:208) 
[ofbiz.jar:?]
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
[javax.servlet-api-4.0.1.jar:4.0.1]
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
[javax.servlet-api-4.0.1.jar:4.0.1]
    at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
 [tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191) 
[ofbiz.jar:?]
    at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
 [tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156) 
[ofbiz.jar:?]
    at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
[javax.servlet-api-4.0.1.jar:4.0.1]
    at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
 [tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
 [tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
 [tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
 [tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
[tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
[tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
 [tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
 [tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) 
[tomcat-catalina-9.0.13.jar:9.0.13]
    at 
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408) 
[tomcat-coyote-9.0.13.jar:9.0.13]
    at 

[jira] [Commented] (OFBIZ-10784) Translations es-CL in AccountingUiLabels

2019-01-17 Thread Jonathan (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745099#comment-16745099
 ] 

Jonathan commented on OFBIZ-10784:
--

Excellent Jacques, I have more translations es and es-CL in other OFBiz 
components.
I am organizing and creating the new patch for this.
Thanks

> Translations es-CL in AccountingUiLabels
> 
>
> Key: OFBIZ-10784
> URL: https://issues.apache.org/jira/browse/OFBIZ-10784
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jonathan
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: accounting
> Fix For: Upcoming Branch
>
> Attachments: AccountingUiLabels_lastModified.patch, 
> AccountingUiLabels_modified.patch
>
>
> Added all translation es-CL  (Chile) in AccountingUiLAbels



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10784) Translations es-CL in AccountingUiLabels

2019-01-17 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745050#comment-16745050
 ] 

Jacques Le Roux commented on OFBIZ-10784:
-

Hi Jonathan,

Thanks for your new patch.You added some ("pure") Spanish labels and that 's 
good from a quick review I did (like a statistical survey).

I don't know Spanish so I don't know Chile Spanish. But from what I see it 
seems quite good to me. 

There was just a duplicated AccountingInvalidGlReconciliation label in SPanish 
(no Chile). I committed after removing the duplicate at revision: 1851529. I 
Let you check this duplicate.

> Translations es-CL in AccountingUiLabels
> 
>
> Key: OFBIZ-10784
> URL: https://issues.apache.org/jira/browse/OFBIZ-10784
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jonathan
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: accounting
> Attachments: AccountingUiLabels_lastModified.patch, 
> AccountingUiLabels_modified.patch
>
>
> Added all translation es-CL  (Chile) in AccountingUiLAbels



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10784) Translations es-CL in AccountingUiLabels

2019-01-17 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10784.
---
   Resolution: Implemented
Fix Version/s: Upcoming Branch

> Translations es-CL in AccountingUiLabels
> 
>
> Key: OFBIZ-10784
> URL: https://issues.apache.org/jira/browse/OFBIZ-10784
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Jonathan
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: accounting
> Fix For: Upcoming Branch
>
> Attachments: AccountingUiLabels_lastModified.patch, 
> AccountingUiLabels_modified.patch
>
>
> Added all translation es-CL  (Chile) in AccountingUiLAbels



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10536) Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box appears with no reason.

2019-01-17 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744894#comment-16744894
 ] 

Jacques Le Roux commented on OFBIZ-10536:
-

Hi Priya,

To be clear, by saying
{quote}it has worked during several years
{quote}
I mean it was used in places where it fits but not there for instance.

It could be related to OFBIZ-10099, but just a blind guess for now

> Giant Widget with variant explosion: a "Select Unit of Measure" dropdown box 
> appears with no reason.
> 
>
> Key: OFBIZ-10536
> URL: https://issues.apache.org/jira/browse/OFBIZ-10536
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Priya Sharma
>Priority: Major
> Attachments: Image 002.png, OFBIZ-10536.patch, 
> OFBIZ-10536_16-11.patch, Screenshot from 2018-12-24 17-37-07.png
>
>
> Try at 
> https://demo-trunk.ofbiz.apache.org/ecommerce/giant-widget-with-variant-explosion-WG-9943-p,
>  same locally of course
> R16 is also concerned (hence R17 I surmise)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4274) Implement a REST Servlet

2019-01-17 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744825#comment-16744825
 ] 

Michael Brohl commented on OFBIZ-4274:
--

I just think if we want to offer a solution to make OFBiz accessible through 
REST, we should take care of all related aspects using best practices. Proper 
authentication and security is a crucial part of it.

I don't think that we should leave the users alone with that.

That's a point we should take care of, which makes senses when we have the base 
solution up and running.

But I have the strong opinion that we should not commit anything RESTful to the 
codebase before we have the full solution incl. authentication.

> Implement a REST Servlet
> 
>
> Key: OFBIZ-4274
> URL: https://issues.apache.org/jira/browse/OFBIZ-4274
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Adrian Crum
>Priority: Major
>  Labels: REST
> Attachments: RestExampleSchema.xsd, RestXmlRepresentation.xml, 
> rest-conf.xml, swagger-pos-openapi.png
>
>
> Implement a REST servlet that will map REST requests to OFBiz services. 
> Details are in the comments.
> [here is the discussion which took place on the dev 
> ML|http://markmail.org/message/ai6q2fbksowaayn4]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4274) Implement a REST Servlet

2019-01-17 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744802#comment-16744802
 ] 

Jacques Le Roux commented on OFBIZ-4274:


Thanks for the point about revocation Mathieu. I agree, better keep what we 
have already and even maybe explore the \@remember annotation.

> Implement a REST Servlet
> 
>
> Key: OFBIZ-4274
> URL: https://issues.apache.org/jira/browse/OFBIZ-4274
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Adrian Crum
>Priority: Major
>  Labels: REST
> Attachments: RestExampleSchema.xsd, RestXmlRepresentation.xml, 
> rest-conf.xml, swagger-pos-openapi.png
>
>
> Implement a REST servlet that will map REST requests to OFBiz services. 
> Details are in the comments.
> [here is the discussion which took place on the dev 
> ML|http://markmail.org/message/ai6q2fbksowaayn4]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10165) Review and refactor implementation of select multiple

2019-01-17 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-10165:
--
Environment: (was: The js code for select multiple needs to be reviewed 
and refactored. We can minimize code in SetMultipleSelectJsList.ftl and 
SetMultipleSelectJs.ftl and even prepare some generic code in ofbizutils.js. )

> Review and refactor implementation of select multiple
> -
>
> Key: OFBIZ-10165
> URL: https://issues.apache.org/jira/browse/OFBIZ-10165
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10165) Review and refactor implementation of select multiple

2019-01-17 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-10165:
--
Description: The js code for select multiple needs to be reviewed and 
refactored. We can minimize code in SetMultipleSelectJsList.ftl and 
SetMultipleSelectJs.ftl and even prepare some generic code in ofbizutils.js. 

> Review and refactor implementation of select multiple
> -
>
> Key: OFBIZ-10165
> URL: https://issues.apache.org/jira/browse/OFBIZ-10165
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
>
> The js code for select multiple needs to be reviewed and refactored. We can 
> minimize code in SetMultipleSelectJsList.ftl and SetMultipleSelectJs.ftl and 
> even prepare some generic code in ofbizutils.js. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro

2019-01-17 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744794#comment-16744794
 ] 

Aditya Sharma commented on OFBIZ-9849:
--

Thanks [~dhaval.wagela] . I will commit soon.

> Replace Inline js with External js in renderDropDownField macro
> ---
>
> Key: OFBIZ-9849
> URL: https://issues.apache.org/jira/browse/OFBIZ-9849
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-9849.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro

2019-01-17 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma reassigned OFBIZ-9849:


Assignee: Aditya Sharma  (was: Dhaval Wagela)

> Replace Inline js with External js in renderDropDownField macro
> ---
>
> Key: OFBIZ-9849
> URL: https://issues.apache.org/jira/browse/OFBIZ-9849
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-9849.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9844) Replace Inline js with External js in renderTextField macro

2019-01-17 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma closed OFBIZ-9844.


> Replace Inline js with External js in renderTextField macro
> ---
>
> Key: OFBIZ-9844
> URL: https://issues.apache.org/jira/browse/OFBIZ-9844
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Fix For: 18.12.01
>
> Attachments: OFBIZ-9844.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9844) Replace Inline js with External js in renderTextField macro

2019-01-17 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744784#comment-16744784
 ] 

Aditya Sharma commented on OFBIZ-9844:
--

Done for trunk at R1851500 and R18.12 at 1851502

> Replace Inline js with External js in renderTextField macro
> ---
>
> Key: OFBIZ-9844
> URL: https://issues.apache.org/jira/browse/OFBIZ-9844
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-9844.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)