[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL
[
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782618#comment-16782618
]
Shi Jinghai commented on OFBIZ-10700:
-
Hi Mathieu,
You are absolutely right.
The only one pro I suggested is that I can see all plugins in plugins, and make
me easy to check whether any plugin should be upgraded.
Kind Regards,
> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method. See
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more
> details.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10829) Rewrite ‘ComponentConfig’ constructor
[
https://issues.apache.org/jira/browse/OFBIZ-10829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-10829:
--
Assignee: Mathieu Lirzin
> Rewrite ‘ComponentConfig’ constructor
> -
>
> Key: OFBIZ-10829
> URL: https://issues.apache.org/jira/browse/OFBIZ-10829
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10829_Rewrite-ComponentConfig-constructor.patch
>
>
> The {{ComponentConfig}} constructors contains a lot of duplicated code that
> can be factorized.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10821) More specific ‘FlexibleLocation#resolveLocation’ should be used when possible
[
https://issues.apache.org/jira/browse/OFBIZ-10821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-10821:
--
Assignee: Mathieu Lirzin
> More specific ‘FlexibleLocation#resolveLocation’ should be used when possible
> -
>
> Key: OFBIZ-10821
> URL: https://issues.apache.org/jira/browse/OFBIZ-10821
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Trivial
> Fix For: Trunk
>
> Attachments:
> OFBIZ-10821_Use-resolveLocation-with-the-appropriate-signature.patch
>
>
> The artifact info classes use the {{FlexibleLocation#resolveLocation(String,
> ClassLoader)}} method instead of the more specific
> {{FlexibleLocation#resolveLocation(String)}} one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10825) Disallow extension of the script helper bindings
[
https://issues.apache.org/jira/browse/OFBIZ-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-10825:
--
Assignee: Mathieu Lirzin
> Disallow extension of the script helper bindings
>
>
> Key: OFBIZ-10825
> URL: https://issues.apache.org/jira/browse/OFBIZ-10825
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Trunk
>
> Attachments:
> OFBIZ-10825_Disallow-extension-of-the-script-helper-bindings.patch
>
>
> {{ScriptHelper}} is a mechanism used to add some useful bindings to
> scripts. This feature has been introduced in revision 1299924 by
> Adrian Crum as part of an general effort of supporting the Generic
> Scripting Engine specified by JSR-223.
> Previously this mechanism was extensible, however it appears to be
> undesirable (nor used in practice) to extend the bindings available to
> services since the internal service implementations are highly coupled
> to those bindings. As a consequence the usage of the Abstract Factory
> pattern which was used for that purpose has been removed.
> The side effect of this change is that we have now simpler code.
> See Mailing List discussion:
> https://lists.apache.org/thread.html/b4b2b169638cd11960fd94e7770162f4b585299e9a1b5feeae9dc177@%3Cdev.ofbiz.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10820) ‘GroovyUtil#loadClass’ is not used
[
https://issues.apache.org/jira/browse/OFBIZ-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-10820:
--
Assignee: Mathieu Lirzin
> ‘GroovyUtil#loadClass’ is not used
> --
>
> Key: OFBIZ-10820
> URL: https://issues.apache.org/jira/browse/OFBIZ-10820
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Trivial
> Fix For: Trunk
>
> Attachments: OFBIZ-10820_Remove-unused-loadClass.patch
>
>
> Hello,
> The method {{GroovyUtil#loadClass}} is not used anywhere in the framework so
> we should get rid of it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10822) Rewrite of ‘GroovyUtil#parseClass’
[
https://issues.apache.org/jira/browse/OFBIZ-10822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-10822:
--
Assignee: Mathieu Lirzin
> Rewrite of ‘GroovyUtil#parseClass’
> --
>
> Key: OFBIZ-10822
> URL: https://issues.apache.org/jira/browse/OFBIZ-10822
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Trivial
> Fix For: Trunk
>
> Attachments: OFBIZ-10822_Rewrite-parseClass-method.patch
>
>
> The {{parseClass(InputStream in, String location)}} and
> {{parseClass(InputStream in, String location, GroovyClassLoader
> groovyClassLoader)}} methods from {{GroovyUtil}} should be private,
> documented, and arguably merged for better readability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10810) Improvements of ‘AbstractEngine#createLocationMap’
[
https://issues.apache.org/jira/browse/OFBIZ-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-10810:
--
Assignee: Mathieu Lirzin
> Improvements of ‘AbstractEngine#createLocationMap’
> --
>
> Key: OFBIZ-10810
> URL: https://issues.apache.org/jira/browse/OFBIZ-10810
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10810.patch
>
>
> The {{createLocationMap}} method lacks documentation and could use the
> {{forEach}} method instead of a for loop.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10809) Rewrite ‘AbstractEngine#getLocation’
[
https://issues.apache.org/jira/browse/OFBIZ-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-10809:
--
Assignee: Mathieu Lirzin
> Rewrite ‘AbstractEngine#getLocation’
>
>
> Key: OFBIZ-10809
> URL: https://issues.apache.org/jira/browse/OFBIZ-10809
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10809.patch
>
>
> The {{AbstractEngine#getLocation}} method lacks javadoc and could be
> rewritten with a simple expression.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10808) Inline ‘serviceInvoker’ method in Groovy engine
[
https://issues.apache.org/jira/browse/OFBIZ-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-10808:
--
Assignee: Mathieu Lirzin
> Inline ‘serviceInvoker’ method in Groovy engine
> ---
>
> Key: OFBIZ-10808
> URL: https://issues.apache.org/jira/browse/OFBIZ-10808
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10808.patch
>
>
> The {{runSync}} method of the Groovy engine is only passing its arguments to
> the {{serviceInvoker}} method which is private and used only by the
> {{runSync}} method. As a consequence it seems preferable to inline the
> {{serviceInvoker}} method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10807) Rewrite ‘GroovyUtil#runScriptAtLocation’
[ https://issues.apache.org/jira/browse/OFBIZ-10807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin reassigned OFBIZ-10807: -- Assignee: Mathieu Lirzin > Rewrite ‘GroovyUtil#runScriptAtLocation’ > > > Key: OFBIZ-10807 > URL: https://issues.apache.org/jira/browse/OFBIZ-10807 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: OFBIZ-10807.patch > > > The ‘GroovyUtil#runScriptAtLocation’ lacks a javadoc and could be rewritten > with a simple expression. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10806) Groovy Base script redundancy
[
https://issues.apache.org/jira/browse/OFBIZ-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-10806:
--
Assignee: Mathieu Lirzin
> Groovy Base script redundancy
> -
>
> Key: OFBIZ-10806
> URL: https://issues.apache.org/jira/browse/OFBIZ-10806
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10806.patch
>
>
> According to [Groovy
> documentation|http://docs.groovy-lang.org/latest/html/documentation/#_script_base_classes]
> the following construction:
> {code:java}
> CompilerConfiguration conf = new CompilerConfiguration();
> conf.setScriptBaseClass(scriptBaseClass);
> groovyClassLoader = new GroovyClassLoader(GroovyUtil.class.getClassLoader(),
> conf);
> {code}
> is equivalent to running the a script containing the {{@BaseScript}}
> annotation.
> In {{org.apache.ofbiz.base.util.GroovyUtil}} instead of choosing one
> solution, we are doing both. :-)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10723) Using a common dispatcher and delegator for integration tests
[ https://issues.apache.org/jira/browse/OFBIZ-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin reassigned OFBIZ-10723: -- Assignee: Mathieu Lirzin > Using a common dispatcher and delegator for integration tests > - > > Key: OFBIZ-10723 > URL: https://issues.apache.org/jira/browse/OFBIZ-10723 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-19723_Disallow-using-alternate-dispatcher-and-delegator-fo.patch > > > The way integration tests are currently run allows having a specific > dispatcher and delegator for each test. This would help in simplifying the > way integration tests are run to assume only one type of dispatcher and > delegator for every tests. > This change has been ”discussed” on the > [dev|https://lists.apache.org/thread.html/638e88265971cfb47ee03b87c6705206d8369c8d1d94fe8c8decfb74@%3Cdev.ofbiz.apache.org%3E] > and > [user|https://lists.apache.org/thread.html/e9516ac2d6c141d721bd77d593decd886fa4b2b835ba0b315bac21a3@%3Cuser.ofbiz.apache.org%3E] > mailing-lists. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL
[
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782434#comment-16782434
]
Mathieu Lirzin commented on OFBIZ-10700:
Hello [~shi.jinghai],
According to the [Gradle
doc|https://docs.gradle.org/current/userguide/plugins.html#sec:subprojects_plugins_dsl]
the change you are proposing is about separating the *resolution* and the
*application* of the {{org.owasp.dependencycheck}} which is useful in
multi-project builds where you want to apply a plugin only to a subset of
subprojects. I guess (without testing) that plugins *resolution* mean that the
plugin is downloaded which in our case would be better to avoid as long as the
{{enableOwasp}} property is not provided. As a consequence If this guess is
correct I would prefer to keep the {{plugins}} block inside the {{if}}
otherwise I will be fine with the version you are proposing. Please correct me
if I am making a wrong guess or missing some other obvious advantage of the
second form.
Thanks
> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method. See
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more
> details.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL
[
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782398#comment-16782398
]
Shi Jinghai commented on OFBIZ-10700:
-
Hi Mathieu,
Brilliant!
I suggest change
{code:java}
if (project.hasProperty('enableOwasp')) {
plugins {
id 'org.owasp.dependencycheck' version '3.0.2'
}
}{code}
to
{code:java}
plugins {
...
id "org.owasp.dependencycheck" version "3.0.2" apply false
}
if (project.hasProperty('enableOwasp')) {
apply plugin: 'org.owasp.dependencycheck'
}{code}
What do you think?
Kind Regards,
> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method. See
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more
> details.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10755) Use the fop.xconf.*.patches in each demo
[ https://issues.apache.org/jira/browse/OFBIZ-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782379#comment-16782379 ] Jacques Le Roux commented on OFBIZ-10755: - I have committed patches for content.url.prefix.secure/content.url.prefix.standard at revision: 1854640 > Use the fop.xconf.*.patches in each demo > > > Key: OFBIZ-10755 > URL: https://issues.apache.org/jira/browse/OFBIZ-10755 > Project: OFBiz > Issue Type: Improvement > Components: Demo >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > In demos we need to set the fop base as explained in > https://xmlgraphics.apache.org/fop/2.1/configuration.html > bq. base1 URL or directorySpecifies the base URL based on which > relative URL will be resolved. > bq. Relative URIs for [some] properties are evaluated relative to the base > URI of the configuration file. If the configuration is provided > programmatically, the base URI can be set with > FopFactory.setUserConfigBaseURI ; default is the current working directory. > The fop.xconf.*.patches are waiting to be applied on each demo -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10156) Fix issues related to images paths on demos
[
https://issues.apache.org/jira/browse/OFBIZ-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782378#comment-16782378
]
Jacques Le Roux commented on OFBIZ-10156:
-
Committed patches at revision: 1854640
> Fix issues related to images paths on demos
> ---
>
> Key: OFBIZ-10156
> URL: https://issues.apache.org/jira/browse/OFBIZ-10156
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> While working on OFBIZ-10128 I stumbled upon this issue found on trunk demo
> {code}
> 2018-01-11 09:35:08,370 |ajp-nio-8009-exec-8 |FOUserAgent
> |E| Image not found. URI: /images/ofbiz_logo.png. (See position 37:54)
> 2018-01-11 09:35:08,603 |ajp-nio-8009-exec-8 |FOUserAgent
> |E| Image not found. URI: /images/ofbiz_logo.png. (No context info available)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10156) Fix issues related to images paths on demos
[
https://issues.apache.org/jira/browse/OFBIZ-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-10156:
Summary: Fix issues related to images paths on demos (was: Fix issues
related to images paths)
> Fix issues related to images paths on demos
> ---
>
> Key: OFBIZ-10156
> URL: https://issues.apache.org/jira/browse/OFBIZ-10156
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> While working on OFBIZ-10128 I stumbled upon this issue found on trunk demo
> {code}
> 2018-01-11 09:35:08,370 |ajp-nio-8009-exec-8 |FOUserAgent
> |E| Image not found. URI: /images/ofbiz_logo.png. (See position 37:54)
> 2018-01-11 09:35:08,603 |ajp-nio-8009-exec-8 |FOUserAgent
> |E| Image not found. URI: /images/ofbiz_logo.png. (No context info available)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10700) Use the Gradle Plugin DSL
[
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-10700:
--
Assignee: Mathieu Lirzin
> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method. See
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more
> details.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
