[jira] [Commented] (OFBIZ-10872) Simplify ‘getJarManifestClasspathForCurrentOs’ method
[
https://issues.apache.org/jira/browse/OFBIZ-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799824#comment-16799824
]
Mathieu Lirzin commented on OFBIZ-10872:
If somebody working on window can confirm that
[^OFBIZ-10872_Rewrite-getJarManifestClasspathForCurrentOs.patch] does not
introduce any regression, that would be great.
> Simplify ‘getJarManifestClasspathForCurrentOs’ method
> -
>
> Key: OFBIZ-10872
> URL: https://issues.apache.org/jira/browse/OFBIZ-10872
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10872_Rewrite-getJarManifestClasspathForCurrentOs.patch
>
>
> pure refactoring for providing a more concise implementation of
> {{getJarManifestClasspathForCurrentOs}} which has been renamed
> {{getJarClasspath}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10872) Simplify ‘getJarManifestClasspathForCurrentOs’ method
[
https://issues.apache.org/jira/browse/OFBIZ-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-10872:
--
Assignee: Mathieu Lirzin
> Simplify ‘getJarManifestClasspathForCurrentOs’ method
> -
>
> Key: OFBIZ-10872
> URL: https://issues.apache.org/jira/browse/OFBIZ-10872
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10872_Rewrite-getJarManifestClasspathForCurrentOs.patch
>
>
> pure refactoring for providing a more concise implementation of
> {{getJarManifestClasspathForCurrentOs}} which has been renamed
> {{getJarClasspath}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10872) Simplify ‘getJarManifestClasspathForCurrentOs’ method
[
https://issues.apache.org/jira/browse/OFBIZ-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10872:
---
Description: pure refactoring for providing a more concise implementation
of {{getJarManifestClasspathForCurrentOs}} which has been renamed
{{getJarClasspath}} (was: pure refactoring for providing a more concise
implementation of {{getJarManifestClasspathForCurrentOs}} which has been
renamed {{getJarClassPath}})
> Simplify ‘getJarManifestClasspathForCurrentOs’ method
> -
>
> Key: OFBIZ-10872
> URL: https://issues.apache.org/jira/browse/OFBIZ-10872
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10872_Rewrite-getJarManifestClasspathForCurrentOs.patch
>
>
> pure refactoring for providing a more concise implementation of
> {{getJarManifestClasspathForCurrentOs}} which has been renamed
> {{getJarClasspath}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10872) Simplify ‘getJarManifestClasspathForCurrentOs’ method
[
https://issues.apache.org/jira/browse/OFBIZ-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-10872:
---
Attachment: OFBIZ-10872_Rewrite-getJarManifestClasspathForCurrentOs.patch
> Simplify ‘getJarManifestClasspathForCurrentOs’ method
> -
>
> Key: OFBIZ-10872
> URL: https://issues.apache.org/jira/browse/OFBIZ-10872
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10872_Rewrite-getJarManifestClasspathForCurrentOs.patch
>
>
> pure refactoring for providing a more concise implementation of
> {{getJarManifestClasspathForCurrentOs}} which has been renamed
> {{getJarClasspath}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10872) Simplify ‘getJarManifestClasspathForCurrentOs’ method
Mathieu Lirzin created OFBIZ-10872:
--
Summary: Simplify ‘getJarManifestClasspathForCurrentOs’ method
Key: OFBIZ-10872
URL: https://issues.apache.org/jira/browse/OFBIZ-10872
Project: OFBiz
Issue Type: Improvement
Affects Versions: Trunk
Reporter: Mathieu Lirzin
Fix For: Upcoming Branch
pure refactoring for providing a more concise implementation of
{{getJarManifestClasspathForCurrentOs}} which has been renamed
{{getJarClassPath}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10871) Do not use deprecated Gradle dependency types
[ https://issues.apache.org/jira/browse/OFBIZ-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin reassigned OFBIZ-10871: -- Assignee: Mathieu Lirzin > Do not use deprecated Gradle dependency types > - > > Key: OFBIZ-10871 > URL: https://issues.apache.org/jira/browse/OFBIZ-10871 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10871_Do-not-use-deprecated-dependency-types.patch > > > The ‘compile’, ‘testCompile’ and ‘runtime’ dependency types has been > superseded by ‘implementation’, ‘testImplementation’ and ‘runtimeOnly’ in > recent [Gradle > versions|https://docs.gradle.org/current/userguide/java_plugin.html#sec:java_plugin_and_dependency_management]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10871) Do not use deprecated Gradle dependency types
[ https://issues.apache.org/jira/browse/OFBIZ-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799817#comment-16799817 ] Mathieu Lirzin edited comment on OFBIZ-10871 at 3/23/19 9:59 PM: - Hopefully [^OFBIZ-10871_Do-not-use-deprecated-dependency-types.patch] is doing the right thing. I will wait a couple of days before applying if somebody has comments or corrections to make. was (Author: mthl): Hopefully [^OFBIZ-10871_Do-not-use-deprecated-dependency-types.patch] is doing the right thing. I will wait a couple of days before applying if somebody has comments or correction to make. > Do not use deprecated Gradle dependency types > - > > Key: OFBIZ-10871 > URL: https://issues.apache.org/jira/browse/OFBIZ-10871 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10871_Do-not-use-deprecated-dependency-types.patch > > > The ‘compile’, ‘testCompile’ and ‘runtime’ dependency types has been > superseded by ‘implementation’, ‘testImplementation’ and ‘runtimeOnly’ in > recent [Gradle > versions|https://docs.gradle.org/current/userguide/java_plugin.html#sec:java_plugin_and_dependency_management]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10871) Do not use deprecated Gradle dependency types
[ https://issues.apache.org/jira/browse/OFBIZ-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799817#comment-16799817 ] Mathieu Lirzin commented on OFBIZ-10871: Hopefully [^OFBIZ-10871_Do-not-use-deprecated-dependency-types.patch] is doing the right thing. I will wait a couple of days before applying if somebody has comments or correction to make. > Do not use deprecated Gradle dependency types > - > > Key: OFBIZ-10871 > URL: https://issues.apache.org/jira/browse/OFBIZ-10871 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10871_Do-not-use-deprecated-dependency-types.patch > > > The ‘compile’, ‘testCompile’ and ‘runtime’ dependency types has been > superseded by ‘implementation’, ‘testImplementation’ and ‘runtimeOnly’ in > recent [Gradle > versions|https://docs.gradle.org/current/userguide/java_plugin.html#sec:java_plugin_and_dependency_management]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10871) Do not use deprecated Gradle dependency types
[ https://issues.apache.org/jira/browse/OFBIZ-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10871: --- Attachment: OFBIZ-10871_Do-not-use-deprecated-dependency-types.patch > Do not use deprecated Gradle dependency types > - > > Key: OFBIZ-10871 > URL: https://issues.apache.org/jira/browse/OFBIZ-10871 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10871_Do-not-use-deprecated-dependency-types.patch > > > The ‘compile’, ‘testCompile’ and ‘runtime’ dependency types has been > superseded by ‘implementation’, ‘testImplementation’ and ‘runtimeOnly’ in > recent [Gradle > versions|https://docs.gradle.org/current/userguide/java_plugin.html#sec:java_plugin_and_dependency_management]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10871) Do not use deprecated Gradle dependency types
Mathieu Lirzin created OFBIZ-10871: -- Summary: Do not use deprecated Gradle dependency types Key: OFBIZ-10871 URL: https://issues.apache.org/jira/browse/OFBIZ-10871 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk Reporter: Mathieu Lirzin Fix For: Upcoming Branch The ‘compile’, ‘testCompile’ and ‘runtime’ dependency types has been superseded by ‘implementation’, ‘testImplementation’ and ‘runtimeOnly’ in recent [Gradle versions|https://docs.gradle.org/current/userguide/java_plugin.html#sec:java_plugin_and_dependency_management]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10866) Use the ‘application’ and ‘distribution’ plugins
[
https://issues.apache.org/jira/browse/OFBIZ-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799674#comment-16799674
]
Mathieu Lirzin commented on OFBIZ-10866:
Hello Taher,
The distribution feature is far more important to me than recommending the
{{run}} task since it empowers people deploying OFBiz in production. The main
reason I am giving up is that I don't want a discussion on syntax to block the
patch which is not about syntax.
{quote}Anyway, it seems what you are trying to achieve in this Jira is directly
affecting the user experience and the way people are used to controlling the
system. So perhaps a community discussion must precede any changes that happen
here because it seems to be a big change to me.
{quote}
I agree that a change in the command line UI would need a community discussion,
however I have other priorities. :)
{quote}Furthermore, Debugging is super important with all the possible values,
so ofbizDebug needs to be satisfied, the running task does not accommodate for
that if I'm not mistaken. So this needs to be something to look into.
{quote}
There is the {{--debug-jvm}} gradle option which already achieves the same
thing as {{ofbizDebug}} on {{trunk}} just try {{./gradlew ofbiz --debug-jvm}}.
The only thing that is not supported by Gradle OOTB is running OFBiz in the
background like {{ofbizBackground}}.
Thanks for your feedback.
> Use the ‘application’ and ‘distribution’ plugins
>
>
> Key: OFBIZ-10866
> URL: https://issues.apache.org/jira/browse/OFBIZ-10866
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10866_Use-the-application-and-distribution-plugin.patch
>
>
> Gradle provides some useful standard plugins for packaging applications via
> the ‘distribution’ and ‘application’ plugins.
> * The ‘distribution’ plugin [1] is providing a straightforward and easy way
> to distribute OFBiz with its dependencies which is convenient in a deployment
> context. This is achieved by the new ‘distTar’ and ‘distZip’ tasks.
> * The ‘application’ plugin [2] is complementing the ‘distribution’ plugin by
> adding both a robust shell script and a batch script inside the distribution
> archives to allow launching OFBiz easily.
> [1] https://docs.gradle.org/current/userguide/distribution_plugin.html
> [2] https://docs.gradle.org/current/userguide/application_plugin.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10866) Use the ‘application’ and ‘distribution’ plugins
[
https://issues.apache.org/jira/browse/OFBIZ-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799605#comment-16799605
]
Mathieu Lirzin edited comment on OFBIZ-10866 at 3/23/19 2:36 PM:
-
Thanks Jacques,
I will apply the reduced version of
[^OFBIZ-10866_Use-the-application-and-distribution-plugin.patch] and close
this ticket next monday since it seems that there is a consensus on that part.
I give up on proposing to change the documentation to recommend using the
{{run}} task over the {{ofbiz}} rule-based tasks. Regarding renaming the
{{gradle}} wrapper {{ofbiz}}, feel free to open a discussion on the ML if you
want to propose it to the community.
was (Author: mthl):
Thanks Jacques,
I will apply the reduced version of
[^OFBIZ-10866_Use-the-application-and-distribution-plugin.patch] and close
this ticket next monday since it seems that there is a consensus on that part.
I give up on proposing to change the documentation to recommend using the
{{run}} task over the{{ofbiz}} rule-based tasks. Regarding renaming the
{{gradle}} wrapper {{ofbiz}}, feel free to open a discussion on the ML if you
want to propose it to the community.
> Use the ‘application’ and ‘distribution’ plugins
>
>
> Key: OFBIZ-10866
> URL: https://issues.apache.org/jira/browse/OFBIZ-10866
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10866_Use-the-application-and-distribution-plugin.patch
>
>
> Gradle provides some useful standard plugins for packaging applications via
> the ‘distribution’ and ‘application’ plugins.
> * The ‘distribution’ plugin [1] is providing a straightforward and easy way
> to distribute OFBiz with its dependencies which is convenient in a deployment
> context. This is achieved by the new ‘distTar’ and ‘distZip’ tasks.
> * The ‘application’ plugin [2] is complementing the ‘distribution’ plugin by
> adding both a robust shell script and a batch script inside the distribution
> archives to allow launching OFBiz easily.
> [1] https://docs.gradle.org/current/userguide/distribution_plugin.html
> [2] https://docs.gradle.org/current/userguide/application_plugin.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10865) Allow prioritization of background jobs
[ https://issues.apache.org/jira/browse/OFBIZ-10865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799657#comment-16799657 ] Jacques Le Roux commented on OFBIZ-10865: - Ah forgot to mention one point I saw when reviewving: please Scott format in order to reduce lines length to max 120 chars, thanks. > Allow prioritization of background jobs > --- > > Key: OFBIZ-10865 > URL: https://issues.apache.org/jira/browse/OFBIZ-10865 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: Scott Gray >Assignee: Scott Gray >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10865.diff > > > As discussed on the dev list [1], allow Jobs to specify a priority and be > queued accordingly by the JobPoller so that important jobs can be prioritized > over normal jobs, and low priority jobs can be left until last. > This is a first pass implementation with just the main changes. We will > still need to allow the priority to be set in the JobManager and > LocalDispatcher's "schedule" methods before jobs generated at runtime can be > prioritized. IMO the existing schedule methods are a mess and need to be > converted into a builder pattern before adding any more job attributes. The > new priority field also needs to be added to the webtools UI wherever > appropriate. > Changes are as follows: > - Add a "priority" field to JobSandbox entity (numeric/Long) > - Add JobPriority constants class containing fields LOW (0), NORMAL (50) and > HIGH (100) > - Add getPriority method to the Job interface and implement methods for > AbstractJob (returns NORMAL), PersistedServiceJob (returns > JobSandbox.priority) and PurgeJob (returns LOW) > - Change the JobPoller executor's queue to use PriorityBlockingQueue > (unbounded) instead of LinkedBlockingQueue (bounded) > - Implement custom Comparator for the priority queue to sort by priority > descending and then runTime ascending > - Change the poll size per poll to be (queueSize() - queue.size) instead of > queue.remainingCapacity() due to the new queue being unbounded > - I've also opted to limit the database poll query to the poll size using > maxRows() because it seemed dangerous to me to use an unconstrained query on > this table > - Ensured recurring jobs receive the default (NORMAL) priority when being > rescheduled so that they're sorted correctly on the next time they show up in > the database poll > - Ensured jobs generated at runtime are given a default priority of NORMAL > [1] > https://lists.apache.org/thread.html/f9107f8ca9a17a2df731337fc3d9766ebad33467fea4393fb069552d@%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10866) Use the ‘application’ and ‘distribution’ plugins
[ https://issues.apache.org/jira/browse/OFBIZ-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799611#comment-16799611 ] Taher Alkhateeb commented on OFBIZ-10866: - Hi Mathieu, Don't give up too quickly :) Part of work of being in the community is convincing and discussing things. Anyway, it seems what you are trying to achieve in this Jira is directly affecting the user experience and the way people are used to controlling the system. So perhaps a community discussion must precede any changes that happen here because it seems to be a big change to me. With that being said, I have a comment regarding what you said about using the "generic" vs "specific" way like the rule-based tasks, Please remember that OFBiz is not standard in that sense. OFBiz does not deploy like a normal java web app (unfortunately) and so many things about the framework do not fall within standards. Furthermore, Debugging is super important with all the possible values, so ofbizDebug needs to be satisfied, the running task does not accommodate for that if I'm not mistaken. So this needs to be something to look into. Finally, I agree with you completely, a very confusing suggestion by Jacques to rename gradlew. That would be in effect hiding the fact that you are using a very known tool and it confuses the hell out of everyone. > Use the ‘application’ and ‘distribution’ plugins > > > Key: OFBIZ-10866 > URL: https://issues.apache.org/jira/browse/OFBIZ-10866 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-10866_Use-the-application-and-distribution-plugin.patch > > > Gradle provides some useful standard plugins for packaging applications via > the ‘distribution’ and ‘application’ plugins. > * The ‘distribution’ plugin [1] is providing a straightforward and easy way > to distribute OFBiz with its dependencies which is convenient in a deployment > context. This is achieved by the new ‘distTar’ and ‘distZip’ tasks. > * The ‘application’ plugin [2] is complementing the ‘distribution’ plugin by > adding both a robust shell script and a batch script inside the distribution > archives to allow launching OFBiz easily. > [1] https://docs.gradle.org/current/userguide/distribution_plugin.html > [2] https://docs.gradle.org/current/userguide/application_plugin.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799609#comment-16799609 ] Nicolas Malin commented on OFBIZ-10817: --- It's just for testing, will commit only the java source and commented properties > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[
https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799606#comment-16799606
]
Jacques Le Roux commented on OFBIZ-10817:
-
Hi Nicolas,
Are we sure we want to set {{widget.verbose=false}} as default? Is it necessary
or?
> Configure stackTrace displaying on ftl rendering
>
>
> Key: OFBIZ-10817
> URL: https://issues.apache.org/jira/browse/OFBIZ-10817
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch,
> OFBIZ-10817.patch, OFBIZ-10817.patch
>
>
> Currently when freemarker failed to execute a template, you have on end
> screen rendered all java stack trace generate.
> I propose to improve this to display the stack trace only when the property
> widget.verbose is true, no regression during development and when you switch
> to production site, in general your widget.verbose is false so end user
> haven't stack trace (that totally unused for them).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10866) Use the ‘application’ and ‘distribution’ plugins
[
https://issues.apache.org/jira/browse/OFBIZ-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799605#comment-16799605
]
Mathieu Lirzin commented on OFBIZ-10866:
Thanks Jacques,
I will apply the reduced version of
[^OFBIZ-10866_Use-the-application-and-distribution-plugin.patch] and close
this ticket next monday since it seems that there is a consensus on that part.
I give up on proposing to change the documentation to recommend using the
{{run}} task over the{{ofbiz}} rule-based tasks. Regarding renaming the
{{gradle}} wrapper {{ofbiz}}, feel free to open a discussion on the ML if you
want to propose it to the community.
> Use the ‘application’ and ‘distribution’ plugins
>
>
> Key: OFBIZ-10866
> URL: https://issues.apache.org/jira/browse/OFBIZ-10866
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10866_Use-the-application-and-distribution-plugin.patch
>
>
> Gradle provides some useful standard plugins for packaging applications via
> the ‘distribution’ and ‘application’ plugins.
> * The ‘distribution’ plugin [1] is providing a straightforward and easy way
> to distribute OFBiz with its dependencies which is convenient in a deployment
> context. This is achieved by the new ‘distTar’ and ‘distZip’ tasks.
> * The ‘application’ plugin [2] is complementing the ‘distribution’ plugin by
> adding both a robust shell script and a batch script inside the distribution
> archives to allow launching OFBiz easily.
> [1] https://docs.gradle.org/current/userguide/distribution_plugin.html
> [2] https://docs.gradle.org/current/userguide/application_plugin.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16799604#comment-16799604 ] Nicolas Malin commented on OFBIZ-10817: --- I will finish this issue :) Thanks for your message, I update the patch[^OFBIZ-10817.patch] with adding two properties : * widget.freemarker.template.verbose : if you want for the exception displaying * widget.freemarker.template.exception.message :if you want edit your stacktrace string replacement [~mthl] I agree it would be better to improve the design, currently I have no time to refund it (other priority issue :) ) and I prefer make a simple step to escape the bad case that you send an pdf order with twenty page of ftl stacktrace to the end user due to infra issue. [~mbrohl] I implement your idea, just by property and direct display configuration (no use flexible expander or context analysis) to start. I can't use EntityUtilProperties easly without delegator. So ... first operational step as goal. For your second suggest, I prefer to dedicate this part to log4j by production site configuration. > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
