[jira] [Commented] (OFBIZ-10922) Update build.gradle to the latest dependencies

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816657#comment-16816657
 ] 

Jacques Le Roux commented on OFBIZ-10922:
-

generateOfbizDocumentation  is OK now in trunk. I'll continue the work here 
later...

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10922
> URL: https://issues.apache.org/jira/browse/OFBIZ-10922
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10922.patch, OFBIZ-10922.patch, OFBIZ-10922.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10213) Update build.gradle to the latest dependencies

2019-04-12 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10213:

Attachment: OFBIZ-10213.patch

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10213
> URL: https://issues.apache.org/jira/browse/OFBIZ-10213
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Attachments: OFBIZ-10213.patch, OFBIZ-10213.patch, OFBIZ-10213.patch
>
>
> We want to check from time to time if we need to update the dependencies. 
> It's easily done with the [gradle-versions-plugin 
> |https://github.com/ben-manes/gradle-versions-plugin] which analyzes the 
> dependencies and checks if there are newer versions available.
> Running the check with
> {code:java}
> gradlew -PenableDependencyUpdates dependencyUpdates -Drevision=release
> {code}
> We get a list of dependencies to update. This is an umbrella task for action 
> tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10922) Update build.gradle to the latest dependencies

2019-04-12 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10922:

Attachment: OFBIZ-10922.patch

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10922
> URL: https://issues.apache.org/jira/browse/OFBIZ-10922
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10922.patch, OFBIZ-10922.patch, OFBIZ-10922.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816650#comment-16816650
 ] 

Jacques Le Roux edited comment on OFBIZ-10693 at 4/12/19 9:00 PM:
--

To simplify my work on OFBIZ-10213 and OFBIZ-10922 I committed the fix in trunk 
too at r1857433


was (Author: jacques.le.roux):
To simplify my work on OFBIZ-10214 and OFBIZ-10922 I committed the fix in trunk 
too at r1857433

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-10693:
-

To simplify my work on OFBIZ-10214 and OFBIZ-10922 I committed the fix in trunk 
too at r1857433

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10693.
---
   Resolution: Fixed
Fix Version/s: (was: 17.12.01)
   Upcoming Branch

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816641#comment-16816641
 ] 

Jacques Le Roux edited comment on OFBIZ-10693 at 4/12/19 8:56 PM:
--

BTW it works on trunk for both R17 and R18 but not locally. Weirdly Gradle 
downloads
bq. Download 
https://jcenter.bintray.com/org/asciidoctor/asciidoctorj/1.5.7/asciidoctorj-1.5.7.pom
and not the requested 
bq. classpath 'org.asciidoctor:asciidoctor-gradle-plugin:1.5.8.1' // Rather 
than using 1.5.9.2 see OFBIZ-10693
Anyway I don't need it locally as long as the trunk now definitely works :D 
(but I must say this plugin is a mess!)



was (Author: jacques.le.roux):
BTW it works on trunk for both R17 and R18 but not locally. Weirdly Gradle 
download
bq. Download 
https://jcenter.bintray.com/org/asciidoctor/asciidoctorj/1.5.7/asciidoctorj-1.5.7.pom
and not the requested 
bq. classpath 'org.asciidoctor:asciidoctor-gradle-plugin:1.5.8.1' // Rather 
than using 1.5.9.2 see OFBIZ-10693
Anyway I don't need it locally as long as the trunk now definitely works :D 
(but I must say this plugin is a mess!)


> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10693.
---
   Resolution: Fixed
Fix Version/s: (was: 18.12.01)

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-10693:
-

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816631#comment-16816631
 ] 

Jacques Le Roux commented on OFBIZ-10693:
-

I reverted at r1857432 and will not touch more here.

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816626#comment-16816626
 ] 

Jacques Le Roux commented on OFBIZ-10693:
-

Damned, it fails in Buildbot, this is a never ending situation :/

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816614#comment-16816614
 ] 

Jacques Le Roux commented on OFBIZ-10693:
-

Definitely fixed in R18 and R17 at revision 1857431. Actually I see no reasons 
now to not commit the OFBIZ-10922 patch and will do so now too.

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10922) Update build.gradle to the latest dependencies

2019-04-12 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10922:

Attachment: OFBIZ-10922.patch

> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10922
> URL: https://issues.apache.org/jira/browse/OFBIZ-10922
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10922.patch, OFBIZ-10922.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816608#comment-16816608
 ] 

Jacques Le Roux commented on OFBIZ-10693:
-

I close here and put the updated patch in OFBIZ-10922

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10693.
---
   Resolution: Fixed
Fix Version/s: 18.12.01

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816605#comment-16816605
 ] 

Jacques Le Roux commented on OFBIZ-10693:
-

Hi Mathieu,

bq. When you say that you updated “down” some revisions do you mean checking 
out the repository to the state of a previous revision or do you mean reverting 
the commits corresponding to the revisions you mentionned? In the second 
scenario, it is not that surprising that things works differently.

I simply did svn update successively to these revisions. That's the method I 
use to track bugs start with svn, most of the time with dichotomy, like 
git-bisect. I use that with svn before I knew git and bisect.

Anyway Jinghai is right, it's working with trunk HEAD and 2.0.0. Good news we 
can definetely close here and get ahead :) Thanks Jinghai

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816600#comment-16816600
 ] 

Jacques Le Roux edited comment on OFBIZ-10693 at 4/12/19 7:47 PM:
--

Same on Ubuntu (trunk HEAD)


was (Author: jacques.le.roux):
Same on Ubuntu

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816600#comment-16816600
 ] 

Jacques Le Roux commented on OFBIZ-10693:
-

Same on Ubuntu

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816537#comment-16816537
 ] 

Shi Jinghai commented on OFBIZ-10693:
-

I just tried to use 2.0.0 to ofbiz trunk in Fedora 29/openjdk 1.8.0_201-b09, it 
worked. Both 1.5.8.1 and 1.5.9.2 failed.

 
{code:java}
[workspace] $ /bin/sh -xe /tmp/jenkins2331645540419021206.sh
+ /usr/bin/java -version
openjdk version "1.8.0_201"
OpenJDK Runtime Environment (build 1.8.0_201-b09)
OpenJDK 64-Bit Server VM (build 25.201-b09, mixed mode)
+ /usr/bin/sed -i 's/id '\''org.asciidoctor.convert'\'' version 
'\''1.5.8.1'\''/id '\''org.asciidoctor.convert'\'' version '\''2.0.0'\''/g' 
build.gradle
+ /usr/bin/chmod +x gradlew
+ /usr/bin/sh gradlew generateOfbizDocumentation
Starting a Gradle Daemon (subsequent builds will be faster)

> Configure project :
You are using one or more deprecated Asciidoctor task or plugins. To help with 
migration run with --warnings=all

> Task :deleteOfbizDocumentation

> Task :generateOfbizDocumentation
四月 13, 2019 1:55:30 上午 
uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb parse
警告: ../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 
473: unterminated listing block
unterminated listing block :: 
../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc :: 
/var/lib/jenkins/jobs/OFBiz Document 
Generation/workspace/framework/minilang/docs/asciidoc//var/lib/jenkins/jobs/OFBiz
 Document 
Generation/workspace/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc:473
 (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:parse)
四月 13, 2019 1:55:30 上午 
uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb parse
警告: ../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 
511: unterminated listing block
unterminated listing block :: 
../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc :: 
/var/lib/jenkins/jobs/OFBiz Document 
Generation/workspace/framework/minilang/docs/asciidoc//var/lib/jenkins/jobs/OFBiz
 Document 
Generation/workspace/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc:511
 (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:parse)

四月 13, 2019 1:55:50 上午 
uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb parse_table
警告: ../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 
473: unterminated listing block
unterminated listing block :: 
../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc :: 
/var/lib/jenkins/jobs/OFBiz Document 
Generation/workspace/framework/minilang/docs/asciidoc//var/lib/jenkins/jobs/OFBiz
 Document 
Generation/workspace/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc:473
 (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:parse_table)
四月 13, 2019 1:55:50 上午 
uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb parse_table
警告: ../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 
511: unterminated listing block
unterminated listing block :: 
../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc :: 
/var/lib/jenkins/jobs/OFBiz Document 
Generation/workspace/framework/minilang/docs/asciidoc//var/lib/jenkins/jobs/OFBiz
 Document 
Generation/workspace/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc:511
 (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:parse_table)

BUILD SUCCESSFUL in 55s
2 actionable tasks: 2 executed

Finished: SUCCESS
{code}
 

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting 

[jira] [Commented] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816429#comment-16816429
 ] 

Mathieu Lirzin commented on OFBIZ-10693:


Hello Jacques,

When you say that you updated “down” some revisions do you mean checking out 
the repository to the state of a previous revision or do you mean reverting the 
commits corresponding to the revisions you mentionned? In the second scenario, 
it is not that surprising that things works differently.

On my system when resetting to revision 1848850, the 
{{generateOfbizDocumentation}} task succeeds.

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9369) Add order priority management on sale order creation

2019-04-12 Thread Nicolas Malin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-9369:


Assignee: Nicolas Malin

> Add order priority management on sale order creation
> 
>
> Key: OFBIZ-9369
> URL: https://issues.apache.org/jira/browse/OFBIZ-9369
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-9369.patch
>
>
> I made a patch to allow order priority setting when creating sale order.
> This add option on order first step creation an add it to the OrderHeader 
> during creation so that reservation SECA is triggered.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816247#comment-16816247
 ] 

Jacques Le Roux commented on OFBIZ-10693:
-

BTW it's on Windows 7, so maybe... I'll try in Ubuntu...

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. 
> Module [groovy-all is loaded in version 2.5.4 and you are trying to load 
> version 2.4.7
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:523)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
>   at 
> org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:55)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:124)
>   at 
> org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.(MetaClassRegistryImpl.java:85)
>   at groovy.lang.GroovySystem.(GroovySystem.java:36)
>   ... 5 more
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':generateOfbizDocumentation'.
> > Process 'command 
> > '/gnu/store/w41g4n182c7qxaaq77jyrgdqifzzpvsp-icedtea-3.7.0-jdk/bin/java'' 
> > finished with non-zero exit value 1
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1s
> 2 actionable tasks: 2 executed
> {code}
> It seems that the [AsciiDoctor Gradle 
> Plugin|https://asciidoctor.org/docs/asciidoctor-gradle-plugin/] is failing 
> because Groovy 2.5.4 is now used by Gradle instead of Groovy 2.4.7
> I would be nice to work around this issue instead of downgrading Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-10693:
-

Today I tried to generate the doc and got an error. I tried to update "down" 3 
times to:
r1855501
r1854534
r1848850

But even with the last (which was working last time) I got:

{noformat}
C:\projectsASF\ofbiz>gradlew --stacktrace generateOfbizDocumentation
> Task :generateOfbizDocumentation FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':generateOfbizDocumentation'.
> Error running Asciidoctor

* Try:
Run with --info or --debug option to get more log output. Run with --scan to 
get full insights.

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task 
':generateOfbizDocumentation'.
at 
org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:96)
at 
org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:65)
at 
org.gradle.api.internal.tasks.execution.ActionEventFiringTaskExecuter.execute(ActionEventFiringTaskExecuter.java:44)
at 
org.gradle.api.internal.tasks.execution.TimeoutTaskExecuter.execute(TimeoutTaskExecuter.java:53)
at 
org.gradle.api.internal.tasks.execution.SnapshotAfterExecutionTaskExecuter.execute(SnapshotAfterExecutionTaskExecuter.java:38)
at 
org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
at 
org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
at 
org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:49)
at 
org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:61)
at 
org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
at 
org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
at 
org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:44)
at 
org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
at 
org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:55)
at 
org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
at 
org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:35)
at 
org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.run(EventFiringTaskExecuter.java:49)
at 
org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:301)
at 
org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:293)
at 
org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:175)
at 
org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:91)
at 
org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31)
at 
org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:44)
at 
org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:43)
at 
org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:337)
at 
org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:325)
at 
org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:318)
at 
org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:304)
at 
org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker$1.execute(DefaultPlanExecutor.java:134)
at 
org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker$1.execute(DefaultPlanExecutor.java:129)
at 
org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:202)
at 
org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.executeNextNode(DefaultPlanExecutor.java:193)
at 

[jira] [Resolved] (OFBIZ-10875) Temporal expressions sometimes incorrectly calculate next occurrence

2019-04-12 Thread Scott Gray (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Gray resolved OFBIZ-10875.

   Resolution: Fixed
 Assignee: Scott Gray
Fix Version/s: Upcoming Branch

Fixed in r1857382

> Temporal expressions sometimes incorrectly calculate next occurrence
> 
>
> Key: OFBIZ-10875
> URL: https://issues.apache.org/jira/browse/OFBIZ-10875
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Reporter: Scott Gray
>Assignee: Scott Gray
>Priority: Major
> Fix For: Upcoming Branch
>
>
> I've noticed that temporal expressions that involve the last hour of a day 
> incorrectly calculate the next occurrence, effectively skipping the "real" 
> next occurrence and ending up on the one following that.
> This appears to occur because MinuteRange.next() does not check if the day 
> has been "bumped" (ExpressionContext.dayBumped) once it has finished 
> incrementing the calendar to find the next minute in the expression range.  
> It checks if the hour has been bumped but not day or month.
> The following expression can reproduce the issue:
> {code}
> Intersection [11PM_MON_FRI]:
>   MinuteRange [MINUTE_00], start = 00, end = 00
>   HourRange [HOUR_23], start = 23, end = 23
>   DayOfWeekRange [MON_TO_FRI], start = 2, end = 6
> {code}
> When next() is called using 2019-03-26 23:00:00.0
> the method will respond with 2019-03-28 23:00:00.0
> instead of the expected 2019-03-27 23:00:00.0
> Effectively means the above expression would provide every second weekday 
> instead of every weekday.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10875) Temporal expressions sometimes incorrectly calculate next occurrence

2019-04-12 Thread Scott Gray (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Gray closed OFBIZ-10875.
--

> Temporal expressions sometimes incorrectly calculate next occurrence
> 
>
> Key: OFBIZ-10875
> URL: https://issues.apache.org/jira/browse/OFBIZ-10875
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Reporter: Scott Gray
>Assignee: Scott Gray
>Priority: Major
> Fix For: Upcoming Branch
>
>
> I've noticed that temporal expressions that involve the last hour of a day 
> incorrectly calculate the next occurrence, effectively skipping the "real" 
> next occurrence and ending up on the one following that.
> This appears to occur because MinuteRange.next() does not check if the day 
> has been "bumped" (ExpressionContext.dayBumped) once it has finished 
> incrementing the calendar to find the next minute in the expression range.  
> It checks if the hour has been bumped but not day or month.
> The following expression can reproduce the issue:
> {code}
> Intersection [11PM_MON_FRI]:
>   MinuteRange [MINUTE_00], start = 00, end = 00
>   HourRange [HOUR_23], start = 23, end = 23
>   DayOfWeekRange [MON_TO_FRI], start = 2, end = 6
> {code}
> When next() is called using 2019-03-26 23:00:00.0
> the method will respond with 2019-03-28 23:00:00.0
> instead of the expected 2019-03-27 23:00:00.0
> Effectively means the above expression would provide every second weekday 
> instead of every weekday.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10837) Improve ObjectInputStream class

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816126#comment-16816126
 ] 

Jacques Le Roux commented on OFBIZ-10837:
-

I slightly improved things in
trunk r1857392  
R18 r1857393
R17 r1857394  
R16 r1857395  


> Improve ObjectInputStream class
> ---
>
> Key: OFBIZ-10837
> URL: https://issues.apache.org/jira/browse/OFBIZ-10837
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 16.11, Release Branch 17.12, Release 
> Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
>
> As reported by FindBugs and Sonar, it's troubling (a Bad practice in 
> Sonar[1], a code smell in Findbugs[2]) when extending to use the same name 
> than the extended Object.[3]
> [1] 
> [https://sbforge.org/sonar/rules/show/findbugs:NM_SAME_SIMPLE_NAME_AS_SUPERCLASS?layout=false]
>  [2] [https://logging.apache.org/log4j/log4j-2.2/log4j-jul/findbugs.html]
>  [3] Bug: The class name org.apache.ofbiz.base.util.ObjectInputStream shadows 
> the simple name of the superclass java.io.ObjectInputStream
> This class has a simple name that is identical to that of its superclass, 
> except that its superclass is in a different package (e.g., alpha.Foo extends 
> beta.Foo). This can be exceptionally confusing, create lots of situations in 
> which you have to look at import statements to resolve references and creates 
> many opportunities to accidentally define methods that do not override 
> methods in their superclasses.
> Rank: Troubling (14), confidence: High
>  Pattern: NM_SAME_SIMPLE_NAME_AS_SUPERCLASS
>  Type: Nm, Category: BAD_PRACTICE (Bad practice)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service

2019-04-12 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816091#comment-16816091
 ] 

Suraj Khurana commented on OFBIZ-9551:
--

Thanks Nicolas,

+1. Good to go. :) 

> Convert createMarketingCampaignRole service to entity-auto service
> --
>
> Key: OFBIZ-9551
> URL: https://issues.apache.org/jira/browse/OFBIZ-9551
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-9551-simple.patch, OFBIZ-9551.patch
>
>
> Currently, this service is having some permission related code at 
> CampaignServices.xml which is of no use and can be deleted, we can move that 
> code to a separate permission check service that can be used elsewhere as 
> well.
> Also, this pattern is currently used in other areas like Party etc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816088#comment-16816088
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

Documentation done for all supported versions (R16, R17, R18, trunk) at 
revision 1857381.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service

2019-04-12 Thread Nicolas Malin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816076#comment-16816076
 ] 

Nicolas Malin commented on OFBIZ-9551:
--

Agree with that :)

> Convert createMarketingCampaignRole service to entity-auto service
> --
>
> Key: OFBIZ-9551
> URL: https://issues.apache.org/jira/browse/OFBIZ-9551
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-9551-simple.patch, OFBIZ-9551.patch
>
>
> Currently, this service is having some permission related code at 
> CampaignServices.xml which is of no use and can be deleted, we can move that 
> code to a separate permission check service that can be used elsewhere as 
> well.
> Also, this pattern is currently used in other areas like Party etc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service

2019-04-12 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816067#comment-16816067
 ] 

Deepak Dixit edited comment on OFBIZ-9551 at 4/12/19 8:09 AM:
--

Patch looks good to me, One minor improvement can be done, we can use 
marketingPermissionService instead of required-permissions.
{code}

{code}
I'll commit patch with suggested changes. 


was (Author: deepak.dixit):
Patch looks good to me, One minor improment can be done, we can use 
marketingPermissionService instead required-permissions.



I'll commit patch with suggested changes. 

> Convert createMarketingCampaignRole service to entity-auto service
> --
>
> Key: OFBIZ-9551
> URL: https://issues.apache.org/jira/browse/OFBIZ-9551
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-9551-simple.patch, OFBIZ-9551.patch
>
>
> Currently, this service is having some permission related code at 
> CampaignServices.xml which is of no use and can be deleted, we can move that 
> code to a separate permission check service that can be used elsewhere as 
> well.
> Also, this pattern is currently used in other areas like Party etc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service

2019-04-12 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816067#comment-16816067
 ] 

Deepak Dixit commented on OFBIZ-9551:
-

Patch looks good to me, One minor improment can be done, we can use 
marketingPermissionService instead required-permissions.



I'll commit patch with suggested changes. 

> Convert createMarketingCampaignRole service to entity-auto service
> --
>
> Key: OFBIZ-9551
> URL: https://issues.apache.org/jira/browse/OFBIZ-9551
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-9551-simple.patch, OFBIZ-9551.patch
>
>
> Currently, this service is having some permission related code at 
> CampaignServices.xml which is of no use and can be deleted, we can move that 
> code to a separate permission check service that can be used elsewhere as 
> well.
> Also, this pattern is currently used in other areas like Party etc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service

2019-04-12 Thread Nicolas Malin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-9551:
-
Attachment: OFBIZ-9551-simple.patch

> Convert createMarketingCampaignRole service to entity-auto service
> --
>
> Key: OFBIZ-9551
> URL: https://issues.apache.org/jira/browse/OFBIZ-9551
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-9551-simple.patch, OFBIZ-9551.patch
>
>
> Currently, this service is having some permission related code at 
> CampaignServices.xml which is of no use and can be deleted, we can move that 
> code to a separate permission check service that can be used elsewhere as 
> well.
> Also, this pattern is currently used in other areas like Party etc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service

2019-04-12 Thread Nicolas Malin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816055#comment-16816055
 ] 

Nicolas Malin commented on OFBIZ-9551:
--

Hello,

I suggest to finish this task to return at the simple expression of CRUD and 
remove the control on userLogin.partyId == parameters.partyId

If we really want to keep it, it's useful to create a dedicate service for that 
like "addMeToCampaignMarketing"

[^OFBIZ-9551-simple.patch]

> Convert createMarketingCampaignRole service to entity-auto service
> --
>
> Key: OFBIZ-9551
> URL: https://issues.apache.org/jira/browse/OFBIZ-9551
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-9551-simple.patch, OFBIZ-9551.patch
>
>
> Currently, this service is having some permission related code at 
> CampaignServices.xml which is of no use and can be deleted, we can move that 
> code to a separate permission check service that can be used elsewhere as 
> well.
> Also, this pattern is currently used in other areas like Party etc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-5028) Add converter for StringWrapper

2019-04-12 Thread Nicolas Malin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-5028.

   Resolution: Fixed
Fix Version/s: Upcoming Branch

I detected the same case with StringBuffer, I commited added converter 
(StringWrapper and StringBuffer) on trunk at revision 1857371.

I didn't change the log because by defaut the system generate an exception
{code:java}
Converters.java:  
if (noConversions.contains(key)) {
throw new ClassNotFoundException("No converter found for " + key);
}{code}
 

> Add converter for StringWrapper
> ---
>
> Key: OFBIZ-5028
> URL: https://issues.apache.org/jira/browse/OFBIZ-5028
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Christoph Neuroth
>Assignee: Nicolas Malin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: StringWrapperConverter.patch
>
>
> Currently, ofbiz logs a WARNING every time it tries to output StringWrapper 
> objects. Attaching a patch which will prevent this by adding a converter.
> Example log message:
> {code}
> *** No converter found, converting from 
> org.ofbiz.base.util.StringUtil$StringWrapper to java.lang.String. Please 
> report this message to the developer community so a suitable converter can be 
> created. ***
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-5028) Add converter for StringWrapper

2019-04-12 Thread Nicolas Malin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-5028:


Assignee: Nicolas Malin  (was: Ashish Vijaywargiya)

> Add converter for StringWrapper
> ---
>
> Key: OFBIZ-5028
> URL: https://issues.apache.org/jira/browse/OFBIZ-5028
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Christoph Neuroth
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: StringWrapperConverter.patch
>
>
> Currently, ofbiz logs a WARNING every time it tries to output StringWrapper 
> objects. Attaching a patch which will prevent this by adding a converter.
> Example log message:
> {code}
> *** No converter found, converting from 
> org.ofbiz.base.util.StringUtil$StringWrapper to java.lang.String. Please 
> report this message to the developer community so a suitable converter can be 
> created. ***
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)