[jira] [Commented] (OFBIZ-10239) Improve GeneralLedgerServices to set AcctgTrans's transition date as payment's effective date
[
https://issues.apache.org/jira/browse/OFBIZ-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848335#comment-16848335
]
Paul Foxworthy commented on OFBIZ-10239:
Hi [~rishisolankii] and [~manna1234].
Which test is failing?
> Improve GeneralLedgerServices to set AcctgTrans's transition date as
> payment's effective date
> -
>
> Key: OFBIZ-10239
> URL: https://issues.apache.org/jira/browse/OFBIZ-10239
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Reporter: Aishwary Shrivastava
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-10239.patch,
> OFBIZ-10239_SetAccountingTransactionDates.patch
>
>
> Whenever user applies a payment, the {color:#008000}transactionDate
> {color}set on AcctgTransEntries is set by
> {color:#80}now-timestamp{color}, this can result in wrong accounting
> reports, if the payment was received earlier but applied later.
> For example, if someone receives a payment on 28 of Dec and applies the
> payment on 3rd of Jan, the yearly accounting reports will show that
> transaction in the new year, rather than in the previous year.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11067:
---
Fix Version/s: Upcoming Branch
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848293#comment-16848293
]
Mathieu Lirzin commented on OFBIZ-11067:
Committed patches 8 to 17 on trunk in revisions: r1860015 r1860016 r1860017
r1860018 r1860019 r1860020 r1860021 r1860022 r1860023 r1860024
The remaining classes to convert to unit test before closing this ticket are:
- FlexibleStringExpanderTests
- FlexibleMapAccessorTests
- UtilObjectTests
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11067:
---
Attachment: (was:
OFBIZ-11067_0018-Turn-TestJSONConverters-into-a-unit-test-cl.patch)
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11067:
---
Attachment: (was:
OFBIZ-11067_0017-Turn-TestBooleanConverters-into-a-unit-test.patch)
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11067:
---
Attachment:
OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch
OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11067:
---
Attachment: (was:
OFBIZ-11067_0016-Turn-FlexibleStringExpanderTests-into-a-uni.patch)
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0017-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0018-Turn-TestJSONConverters-into-a-unit-test-cl.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11067:
---
Attachment:
OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch
OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch
OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch
OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch
OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch
OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch
OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch
OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch
OFBIZ-11067_0016-Turn-FlexibleStringExpanderTests-into-a-uni.patch
OFBIZ-11067_0017-Turn-TestBooleanConverters-into-a-unit-test.patch
OFBIZ-11067_0018-Turn-TestJSONConverters-into-a-unit-test-cl.patch
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-FlexibleStringExpanderTests-into-a-uni.patch,
> OFBIZ-11067_0017-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0018-Turn-TestJSONConverters-into-a-unit-test-cl.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-8859) Unit test case for service - CreateReturnItemShipment
[ https://issues.apache.org/jira/browse/OFBIZ-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848251#comment-16848251 ] Suraj Khurana edited comment on OFBIZ-8859 at 5/25/19 4:46 PM: --- Slightly modified patch has been committed to Trunk at rev#1860005 was (Author: suraj.khurana): It has been committed to Trunk at rev#1860005 > Unit test case for service - CreateReturnItemShipment > - > > Key: OFBIZ-8859 > URL: https://issues.apache.org/jira/browse/OFBIZ-8859 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8859.patch, OFBIZ-8859.patch, OFBIZ-8859.patch > > > Unit test case for service - CreateReturnItemShipment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-8859) Unit test case for service - CreateReturnItemShipment
[ https://issues.apache.org/jira/browse/OFBIZ-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-8859. Thanks Avnindra Sharma for reporting the issue and Yogesh Naroliya for providing the patch. > Unit test case for service - CreateReturnItemShipment > - > > Key: OFBIZ-8859 > URL: https://issues.apache.org/jira/browse/OFBIZ-8859 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8859.patch, OFBIZ-8859.patch, OFBIZ-8859.patch > > > Unit test case for service - CreateReturnItemShipment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-8937) Unit test case for service - CheckCreateProductRequirementForFacility
[ https://issues.apache.org/jira/browse/OFBIZ-8937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-8937. Thanks Avnindra Sharma for reporting the issue and Anushi Gupta for providing the patch. > Unit test case for service - CheckCreateProductRequirementForFacility > - > > Key: OFBIZ-8937 > URL: https://issues.apache.org/jira/browse/OFBIZ-8937 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8937.patch, OFBIZ-8937.patch > > > Unit test case for service - CheckCreateProductRequirementForFacility -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment
[ https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848246#comment-16848246 ] Mathieu Lirzin commented on OFBIZ-8858: --- Hello [~suraj.khurana],I didn't notice any significant performance downside when using map literals in Groovy, but I don't have measurements to support this impression. :) > Unit test case for service - CreateReturnAndItemOrAdjustment > > > Key: OFBIZ-8858 > URL: https://issues.apache.org/jira/browse/OFBIZ-8858 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8858.patch, OFBIZ-8858.patch > > > Unit test case for service - CreateReturnAndItemOrAdjustment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment
[ https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848244#comment-16848244 ] Suraj Khurana edited comment on OFBIZ-8858 at 5/25/19 4:30 PM: --- Hi [~mthl], Thanks for your inputs. I have no issue with your suggestion (Done at rev#1860003), could you please elaborate does it have any major impact on performance side as well? Looking forward to your reply !! was (Author: suraj.khurana): Hi [~mthl], Thanks for your inputs. I have no issue with your suggestion, could you please elaborate does it have any major impact on performance side as well? Looking forward to your reply !! > Unit test case for service - CreateReturnAndItemOrAdjustment > > > Key: OFBIZ-8858 > URL: https://issues.apache.org/jira/browse/OFBIZ-8858 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8858.patch, OFBIZ-8858.patch > > > Unit test case for service - CreateReturnAndItemOrAdjustment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8853) Unit test case for service - CheckReturnComplete
[ https://issues.apache.org/jira/browse/OFBIZ-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848245#comment-16848245 ] Suraj Khurana commented on OFBIZ-8853: -- Done at rev#1860003 > Unit test case for service - CheckReturnComplete > > > Key: OFBIZ-8853 > URL: https://issues.apache.org/jira/browse/OFBIZ-8853 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-8853.patch, OFBIZ-8853.patch > > > Unit test case for service - CheckReturnComplete -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment
[ https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848244#comment-16848244 ] Suraj Khurana commented on OFBIZ-8858: -- Hi [~mthl], Thanks for your inputs. I have no issue with your suggestion, could you please elaborate does it have any major impact on performance side as well? Looking forward to your reply !! > Unit test case for service - CreateReturnAndItemOrAdjustment > > > Key: OFBIZ-8858 > URL: https://issues.apache.org/jira/browse/OFBIZ-8858 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8858.patch, OFBIZ-8858.patch > > > Unit test case for service - CreateReturnAndItemOrAdjustment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-8860) Unit test case for service - CreateReturnStatus
[ https://issues.apache.org/jira/browse/OFBIZ-8860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-8860: Assignee: Suraj Khurana (was: Yogesh Naroliya) > Unit test case for service - CreateReturnStatus > --- > > Key: OFBIZ-8860 > URL: https://issues.apache.org/jira/browse/OFBIZ-8860 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-8860.patch, OFBIZ-8860.patch > > > Unit test case for service - CreateReturnStatus -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-8852) Unit test case for service - CheckPaymentAmountForRefund
[ https://issues.apache.org/jira/browse/OFBIZ-8852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-8852. Thanks Avnindra Sharma for reporting the issue and Yogesh Naroliya for providing the patch. > Unit test case for service - CheckPaymentAmountForRefund > > > Key: OFBIZ-8852 > URL: https://issues.apache.org/jira/browse/OFBIZ-8852 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8852.patch, OFBIZ-8852.patch > > > Unit test case for service - CheckPaymentAmountForRefund -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8853) Unit test case for service - CheckReturnComplete
[ https://issues.apache.org/jira/browse/OFBIZ-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848238#comment-16848238 ] Mathieu Lirzin commented on OFBIZ-8853: --- Like what I said in OFBIZ-8858, I would recommend using more declarative style for the context map, meaning preferring map literals over imperative map mutation instructions. Thanks > Unit test case for service - CheckReturnComplete > > > Key: OFBIZ-8853 > URL: https://issues.apache.org/jira/browse/OFBIZ-8853 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-8853.patch, OFBIZ-8853.patch > > > Unit test case for service - CheckReturnComplete -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment
[
https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848233#comment-16848233
]
Mathieu Lirzin commented on OFBIZ-8858:
---
I would recommend rewriting the following imperative code
{code:groovy}
Map serviceCtx = [:]
serviceCtx.orderId = 'DEMO10090'
serviceCtx.returnId = '1009'
serviceCtx.userLogin =
EntityQuery.use(delegator).from('UserLogin').where('userLoginId',
'system').cache().queryOne()
{code}
in a more declarative way with map literals
{code:groovy}
Map serviceCtx = [
orderId: 'DEMO10090',
returnId: '1009',
userLogin:
EntityQuery.use(delegator).from('UserLogin').where('userLoginId',
'system').cache().queryOne()
]
{code}
Thanks
> Unit test case for service - CreateReturnAndItemOrAdjustment
>
>
> Key: OFBIZ-8858
> URL: https://issues.apache.org/jira/browse/OFBIZ-8858
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8858.patch, OFBIZ-8858.patch
>
>
> Unit test case for service - CreateReturnAndItemOrAdjustment
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-8853) Unit test case for service - CheckReturnComplete
[ https://issues.apache.org/jira/browse/OFBIZ-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-8853. Thanks Avnindra Sharma for reporting the issue and Yogesh Naroliya for providing the patch. > Unit test case for service - CheckReturnComplete > > > Key: OFBIZ-8853 > URL: https://issues.apache.org/jira/browse/OFBIZ-8853 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-8853.patch, OFBIZ-8853.patch > > > Unit test case for service - CheckReturnComplete -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment
[ https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-8858. Thanks Avnindra Sharma for reporting the issue and Yogesh Naroliya for providing the patch. > Unit test case for service - CreateReturnAndItemOrAdjustment > > > Key: OFBIZ-8858 > URL: https://issues.apache.org/jira/browse/OFBIZ-8858 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8858.patch, OFBIZ-8858.patch > > > Unit test case for service - CreateReturnAndItemOrAdjustment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-8809) Unit test case for service - quickReturnOrder
[ https://issues.apache.org/jira/browse/OFBIZ-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-8809. Thanks Avnindra Sharma for reporting the issue and Yogesh Naroliya for providing the patch. > Unit test case for service - quickReturnOrder > - > > Key: OFBIZ-8809 > URL: https://issues.apache.org/jira/browse/OFBIZ-8809 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8809.patch, OFBIZ-8809.patch > > > Unit test case for service - quickReturnOrder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-8809) Unit test case for service - quickReturnOrder
[ https://issues.apache.org/jira/browse/OFBIZ-8809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-8809: - Fix Version/s: Upcoming Branch > Unit test case for service - quickReturnOrder > - > > Key: OFBIZ-8809 > URL: https://issues.apache.org/jira/browse/OFBIZ-8809 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8809.patch, OFBIZ-8809.patch > > > Unit test case for service - quickReturnOrder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-1463) JUnit test case for various application components
[ https://issues.apache.org/jira/browse/OFBIZ-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-1463: - Sprint: Bug Crush Event - 21/2/2015, OFBiz Community Day (May 2019) (was: Bug Crush Event - 21/2/2015) > JUnit test case for various application components > -- > > Key: OFBIZ-1463 > URL: https://issues.apache.org/jira/browse/OFBIZ-1463 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Vikas Mayur >Priority: Minor > > This is an effort to create JUnit test suites for various bussiness processes > in Ofbiz. > It would be good to have such tests in place so that we can test Ofbiz on a > certain day. > These tests are in initial stage, so I would like community members to post > there comments so that we can move > ahead with them to make these test even better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-4975) updatePortletSeqDragDrop is not working in PortalPage management
[
https://issues.apache.org/jira/browse/OFBIZ-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-4975.
--
Resolution: Abandoned
> updatePortletSeqDragDrop is not working in PortalPage management
>
>
> Key: OFBIZ-4975
> URL: https://issues.apache.org/jira/browse/OFBIZ-4975
> Project: OFBiz
> Issue Type: Bug
> Components: myportal
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release
> Branch 15.12
>Reporter: Olivier Heintz
>Assignee: Erwan de FERRIERES
>Priority: Minor
> Attachments: OFBIZ-4975.patch
>
>
> When you try to change Portlet order in a PortalPage, most of the time it
> does'nt work.
> To show why, I start to change in minilang service, calculate attribute by a
> set
> {code}
>
>
>
>
> -
> -
> -
> -
> -
> -
> -
> -
> -
> -
> + from="newSequenceNo+increase" />
> +
>
>
>
>
> {code}
> the error was to not use a second field, the correct code should be
> {code}
>
>
>
>
>
>
>
>from="newSequenceNo+newValue" />
>
>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11064) Use Groovy Truth instead of UtilValidate Class in Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848223#comment-16848223
]
Jacques Le Roux commented on OFBIZ-11064:
-
Thanks Pawan,
Only spotted in [^OFBIZ-11064.patch]
{code:java}
- if (UtilValidate.isEmpty(webApps)) {
+ if (webApps) {
{code}
> Use Groovy Truth instead of UtilValidate Class in Groovy
>
>
> Key: OFBIZ-11064
> URL: https://issues.apache.org/jira/browse/OFBIZ-11064
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11064-plugins.patch, OFBIZ-11064.patch
>
>
> As we all know, Groovy is a powerful language with great built-in functions.
> Groovy Truth[1] is one of them, which is not used properly in our code base.
> We have used UtilValidate Class to validate arguments for Empty or NotEmpty,
> which can easily be done in groovy with built-in functionality.
>
> Current Code: if (UtilValidate.isNotEmpty(locations)) \{ ... }
>
> Groovy Built-in Code: if (locations) \{ ... }
>
> IMO, We should use this Groovy Truth feature instead of UtilValidate Class.
> Please let me know your thoughts on this. Thanks!
> [1] - [http://groovy-lang.org/semantics.html#Groovy-Truth]
>
> We need to careful for some points while we change this:
> Like:
> maxRetry = 0
> if (!maxRetry) {
> // Not set, use a default
> maxRetry = -1
> }
> Because groovy evaluates zero to be false, it wouldn't be possible to set
> maxRetry to zero. So it's best not to use groovy truth for null-checks on
> numbers in some cases.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848217#comment-16848217
]
Mathieu Lirzin commented on OFBIZ-11067:
When trying to convert {{FlexibleMapAccessorsTests}} class to unit test, the
{{testFlexibleMapAccessor}} test fails, I will investigate more later.
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11059) Runtime error exceptions at Leads page
[ https://issues.apache.org/jira/browse/OFBIZ-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848216#comment-16848216 ] Jacques Le Roux commented on OFBIZ-11059: - BTW Kumar, Most of the time, you don't need to provide patches for releases branches, we can automatically backport. Better wait that we ask you ;) > Runtime error exceptions at Leads page > -- > > Key: OFBIZ-11059 > URL: https://issues.apache.org/jira/browse/OFBIZ-11059 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads?all=false >Reporter: Sanjay Yadav >Assignee: Jacques Le Roux >Priority: Major > Labels: leads > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: LeadPageRuntimeException.png, > OFBIZ-11059-release17.12.patch, OFBIZ-11059-release18.12.patch, > OFBIZ-11059-trunk.patch > > > Step to recreate issue - > # Login to [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Application > SFA > # SFA > Lead Manager > # Leads > Click on All Leads button > Actual - Application throw Runtime error exception in My Leads section. > please refer attached snapshot. > Expected - Proper result should display. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-11059) Runtime error exceptions at Leads page
[ https://issues.apache.org/jira/browse/OFBIZ-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11059. --- Resolution: Fixed Fix Version/s: 18.12.01 16.11.06 17.12.01 Thanks you Guys, Fixed in trunk r1859981 (mind the gap, I was disturbed by https://www.youtube.com/watch?v=7U8CywwKMMI on radio. I kwew he is dead so was surprised, thanks to his wife, peace) R18 r1859985 R17 r1859986 R16 r1859987 > Runtime error exceptions at Leads page > -- > > Key: OFBIZ-11059 > URL: https://issues.apache.org/jira/browse/OFBIZ-11059 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads?all=false >Reporter: Sanjay Yadav >Assignee: Jacques Le Roux >Priority: Major > Labels: leads > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: LeadPageRuntimeException.png, > OFBIZ-11059-release17.12.patch, OFBIZ-11059-release18.12.patch, > OFBIZ-11059-trunk.patch > > > Step to recreate issue - > # Login to [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Application > SFA > # SFA > Lead Manager > # Leads > Click on All Leads button > Actual - Application throw Runtime error exception in My Leads section. > please refer attached snapshot. > Expected - Proper result should display. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848214#comment-16848214
]
Mathieu Lirzin commented on OFBIZ-11067:
{{UtilPropertiesTests}} is surprisingly slow meaning it takes around 30 second
to execute on my machine. If someone want to investigate the reason for this
slowness, please do.
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848213#comment-16848213
]
Mathieu Lirzin commented on OFBIZ-11067:
Committed patches 1 to 7 on trunk in revisions r1859975 r1859976 r1859977
r1859978 r1859979 r1859982 r1859984
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848209#comment-16848209 ] Jacques Le Roux commented on OFBIZ-10145: - Thanks Guys, What is [^init-gradle-wrapper.sh] (the one on top of the list today) for? It seems it should be for R17 but then RELEASE should not be 4.7 but 3.2.1 > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11059) Runtime error exceptions at Leads page
[ https://issues.apache.org/jira/browse/OFBIZ-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11059: --- Assignee: Jacques Le Roux (was: Kumar Rahul) > Runtime error exceptions at Leads page > -- > > Key: OFBIZ-11059 > URL: https://issues.apache.org/jira/browse/OFBIZ-11059 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads?all=false >Reporter: Sanjay Yadav >Assignee: Jacques Le Roux >Priority: Major > Labels: leads > Attachments: LeadPageRuntimeException.png, > OFBIZ-11059-release17.12.patch, OFBIZ-11059-release18.12.patch, > OFBIZ-11059-trunk.patch > > > Step to recreate issue - > # Login to [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Application > SFA > # SFA > Lead Manager > # Leads > Click on All Leads button > Actual - Application throw Runtime error exception in My Leads section. > please refer attached snapshot. > Expected - Proper result should display. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11056: Component/s: framework > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Samuel Trégouët >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-11056.patch > > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11056. --- Resolution: Fixed Fix Version/s: 18.12.01 17.12.01 Thanks Samuel, Your patch is in trun r1859972 R18 r1859973 R17 r1859974 Thanks Rohit for issue update > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Samuel Trégouët >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-11056.patch > > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11067:
---
Attachment:
OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch
OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch
OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch
OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch
OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch
OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch
OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7954) Add NLP function to parse text content
[ https://issues.apache.org/jira/browse/OFBIZ-7954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848205#comment-16848205 ] Pierre Smits commented on OFBIZ-7954: - I wonder if we should not bring the lucene and the solr component together. The both deliver same functionalities. > Add NLP function to parse text content > -- > > Key: OFBIZ-7954 > URL: https://issues.apache.org/jira/browse/OFBIZ-7954 > Project: OFBiz > Issue Type: Improvement > Components: solr >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Labels: NER, NLP > > NLP(Natural Language Processing) is an amazing tech can help us to improve > our beloved OFBiz. > NLP can be used to train your own model to parse product attributes and > understand what it is, before importing the product, or used as an online CRM > text robot to answer simple questions. > We will try to add a new nlp component, and we hope we can get some help from > the community. > AFAIK, two apache projects are working on NLP: > http://tika.apache.org/ > http://opennlp.apache.org/ > The Stanford NLP is used in tika: > http://nlp.stanford.edu/ > While implementing this component, we found an ebay paper on this topic is > very useful: > http://aclweb.org/anthology/D/D11/D11-1144.pdf > Kind Regards, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7954) Add NLP function to parse text content
[ https://issues.apache.org/jira/browse/OFBIZ-7954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shi Jinghai updated OFBIZ-7954: --- Component/s: solr Thank you Pierre! Yes, you're right. I just added solr in the component field. :) > Add NLP function to parse text content > -- > > Key: OFBIZ-7954 > URL: https://issues.apache.org/jira/browse/OFBIZ-7954 > Project: OFBiz > Issue Type: Improvement > Components: solr >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Labels: NER, NLP > > NLP(Natural Language Processing) is an amazing tech can help us to improve > our beloved OFBiz. > NLP can be used to train your own model to parse product attributes and > understand what it is, before importing the product, or used as an online CRM > text robot to answer simple questions. > We will try to add a new nlp component, and we hope we can get some help from > the community. > AFAIK, two apache projects are working on NLP: > http://tika.apache.org/ > http://opennlp.apache.org/ > The Stanford NLP is used in tika: > http://nlp.stanford.edu/ > While implementing this component, we found an ebay paper on this topic is > very useful: > http://aclweb.org/anthology/D/D11/D11-1144.pdf > Kind Regards, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11069) Add coalesce to aggregate-function of model view
Shi Jinghai created OFBIZ-11069:
---
Summary: Add coalesce to aggregate-function of model view
Key: OFBIZ-11069
URL: https://issues.apache.org/jira/browse/OFBIZ-11069
Project: OFBiz
Issue Type: Improvement
Components: framework
Reporter: Shi Jinghai
Fix For: Trunk
Attachments: ModelViewEntity-function-coalesce.patch
While in our IoT case, a product may have a sku product id as well as a
productId (product instance) by identified from unique id i.e. an EPC.
When building operation/inventory reports, to be compatible with previous
implement, I have to merge the sku product Id column into the productId column,
so comes the coalesce patch.
The usage example:
{code:java}
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to "safe"
[
https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848199#comment-16848199
]
Jacques Le Roux commented on OFBIZ-5254:
As mentionned by [~mthl] on dev ml the testCreateNewRequest was failing when
testing framework only. It was due to escaped single quotes in related data in
OrderTypeData.xml: {{subject="OFBiz - Your Request is received:
'${custRequestName}' #CR${custRequestId}"}}
This was a peculiar case that could be generalised to all escapable characters.
The general solution is to compare the original value with the filtered value
unescaped in UtilCodec::checkStringForHtmlSafe.
BTW, weirdly enough StringEscapeUtils::escapeHtml4 does not escape single quote.
Another weirdness is the test was passing with plugins data loaded. This is due
to duplicated demo data in scrumTypeData.xml (which is actually not only type
data, as ever the scrum component is a mess, that's not new and always wonder
if we should not get rid of it!)
Fixed in
trunk r1859968
R18 r1859969 (conflict in build.gradle handled by hand)
R17 r1859970 (conflict in build.gradle handled by hand)
R16 r1859971 (conflict in build.gradle handled by hand)
> Services allow arbitrary HTML for parameters with allow-html set to "safe"
> --
>
> Key: OFBIZ-5254
> URL: https://issues.apache.org/jira/browse/OFBIZ-5254
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Christoph Neuroth
>Assignee: Jacques Le Roux
>Priority: Critical
> Labels: security
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-5254.patch, OFBIZ-5254.patch, OFBIZ-5254.patch,
> OFBIZ-5254.patch, OFBIZ-5254.patch, OFBIZ-5254.patch, UtilCodec.java
>
>
> For any given service with allow-html=safe parameters, the parameter data is
> not properly validated. See Model.Service.java:588:
> {code}
>
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> {code}
> Looking at that method:
> {code}
> public static String checkStringForHtmlSafeOnly(String valueName, String
> value, List errorMessageList) {
> ValidationErrorList vel = new ValidationErrorList();
> value = defaultWebValidator.getValidSafeHTML(valueName, value,
> Integer.MAX_VALUE, true, vel);
> errorMessageList.addAll(UtilGenerics.checkList(vel.errors(),
> String.class));
> return value;
> }
> {code}
> you can see that it expects the defaultWebValidator.getValidSafeHTML would
> add all validation errors to the given ValidationErrorList, but if you look
> at the implementation of ESAPI that is not the case. First, consider the
> overloaded getValidSafeHTML that takes the ValidationErrorList:
> {code}public String getValidSafeHTML(String context, String input,
> int maxLength, boolean allowNull, ValidationErrorList errors) throws
> IntrusionException {
> try {
> return getValidSafeHTML(context, input, maxLength,
> allowNull);
> } catch (ValidationException e) {
> errors.addError(context, e);
> }
> return input;
> }
> {code}
> Then, step into that method to see that ValidationExceptions are only thrown
> for things like exceeding the maximum length - not for policy violations that
> can be "cleaned", such as tags that are not allowed by the policy:
> {code}
> AntiSamy as = new AntiSamy();
> CleanResults test = as.scan(input, antiSamyPolicy);
> List errors = test.getErrorMessages();
> if ( errors.size() > 0 ) {
> // just create new exception to get it logged
> and intrusion detected
> new ValidationException( "Invalid HTML input:
> context=" + context, "Invalid HTML input: context=" + context + ", errors=" +
> errors, context );
> }
> {code}
> I guess that is an expected, although maybe not clearly documented behavior
> of ESAPI: Non-cleanable violations throw the exception and therefore will
> fail the ofbiz service, while non-allowed tags are cleaned. However, if you
> consider ModelService:588 and following lines again:
> {code}
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> //(...)
> if (errorMessageList.size() > 0) {
> throw new ServiceValidationException(errorMessageList, this,
> mode);
> }
> {code}
> the cleaned return value is ignored. Therefore, you will see an
> "IntrusionDetection" in the logs, giving you a false sense of security but
>
[jira] [Commented] (OFBIZ-7954) Add NLP function to parse text content
[ https://issues.apache.org/jira/browse/OFBIZ-7954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848198#comment-16848198 ] Pierre Smits commented on OFBIZ-7954: - It seems to me that we're talking about a new feature. At least using new components (tika?) or enhancing the solr component. The ticket should reflect this better. > Add NLP function to parse text content > -- > > Key: OFBIZ-7954 > URL: https://issues.apache.org/jira/browse/OFBIZ-7954 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Labels: NER, NLP > > NLP(Natural Language Processing) is an amazing tech can help us to improve > our beloved OFBiz. > NLP can be used to train your own model to parse product attributes and > understand what it is, before importing the product, or used as an online CRM > text robot to answer simple questions. > We will try to add a new nlp component, and we hope we can get some help from > the community. > AFAIK, two apache projects are working on NLP: > http://tika.apache.org/ > http://opennlp.apache.org/ > The Stanford NLP is used in tika: > http://nlp.stanford.edu/ > While implementing this component, we found an ebay paper on this topic is > very useful: > http://aclweb.org/anthology/D/D11/D11-1144.pdf > Kind Regards, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10239) Improve GeneralLedgerServices to set AcctgTrans's transition date as payment's effective date
[
https://issues.apache.org/jira/browse/OFBIZ-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishi Solanki updated OFBIZ-10239:
--
Sprint: OFBiz Community Day (May 2019)
> Improve GeneralLedgerServices to set AcctgTrans's transition date as
> payment's effective date
> -
>
> Key: OFBIZ-10239
> URL: https://issues.apache.org/jira/browse/OFBIZ-10239
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Reporter: Aishwary Shrivastava
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-10239.patch,
> OFBIZ-10239_SetAccountingTransactionDates.patch
>
>
> Whenever user applies a payment, the {color:#008000}transactionDate
> {color}set on AcctgTransEntries is set by
> {color:#80}now-timestamp{color}, this can result in wrong accounting
> reports, if the payment was received earlier but applied later.
> For example, if someone receives a payment on 28 of Dec and applies the
> payment on 3rd of Jan, the yearly accounting reports will show that
> transaction in the new year, rather than in the previous year.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10239) Improve GeneralLedgerServices to set AcctgTrans's transition date as payment's effective date
[
https://issues.apache.org/jira/browse/OFBIZ-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848197#comment-16848197
]
Rishi Solanki commented on OFBIZ-10239:
---
[~paul_foxworthy] Sorry for delays in response.
[~manna1234] Can you please look into the test cases failed and follow the
Paul's comment to fix the issue facing after applying the patch. Thanks for
your effort.
> Improve GeneralLedgerServices to set AcctgTrans's transition date as
> payment's effective date
> -
>
> Key: OFBIZ-10239
> URL: https://issues.apache.org/jira/browse/OFBIZ-10239
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Reporter: Aishwary Shrivastava
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-10239.patch,
> OFBIZ-10239_SetAccountingTransactionDates.patch
>
>
> Whenever user applies a payment, the {color:#008000}transactionDate
> {color}set on AcctgTransEntries is set by
> {color:#80}now-timestamp{color}, this can result in wrong accounting
> reports, if the payment was received earlier but applied later.
> For example, if someone receives a payment on 28 of Dec and applies the
> payment on 3rd of Jan, the yearly accounting reports will show that
> transaction in the new year, rather than in the previous year.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-8861) Unit test case for service - GetReturnAmountByOrder
[ https://issues.apache.org/jira/browse/OFBIZ-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-8861: Assignee: Suraj Khurana (was: Yogesh Naroliya) > Unit test case for service - GetReturnAmountByOrder > --- > > Key: OFBIZ-8861 > URL: https://issues.apache.org/jira/browse/OFBIZ-8861 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-8861.patch, OFBIZ-8861.patch > > > Unit test case for service - GetReturnAmountByOrder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11056: Sprint: OFBiz Community Day (May 2019) > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Samuel Trégouët >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-11056.patch > > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11056: --- Assignee: Jacques Le Roux (was: Rohit Koushal) > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Samuel Trégouët >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-11056.patch > > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7954) Add NLP function to parse text content
[ https://issues.apache.org/jira/browse/OFBIZ-7954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848188#comment-16848188 ] Shi Jinghai commented on OFBIZ-7954: As solr supported OpenNLP/NER since version 7.3.0 which was released in April 2018, I'll try to open an example of auto filling a form from parsing a copy/pasted text paragraph. > Add NLP function to parse text content > -- > > Key: OFBIZ-7954 > URL: https://issues.apache.org/jira/browse/OFBIZ-7954 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Shi Jinghai >Assignee: Shi Jinghai >Priority: Minor > Labels: NER, NLP > > NLP(Natural Language Processing) is an amazing tech can help us to improve > our beloved OFBiz. > NLP can be used to train your own model to parse product attributes and > understand what it is, before importing the product, or used as an online CRM > text robot to answer simple questions. > We will try to add a new nlp component, and we hope we can get some help from > the community. > AFAIK, two apache projects are working on NLP: > http://tika.apache.org/ > http://opennlp.apache.org/ > The Stanford NLP is used in tika: > http://nlp.stanford.edu/ > While implementing this component, we found an ebay paper on this topic is > very useful: > http://aclweb.org/anthology/D/D11/D11-1144.pdf > Kind Regards, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11068) Error while CSR creates a return.
[ https://issues.apache.org/jira/browse/OFBIZ-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dikpal Kanungo updated OFBIZ-11068: --- Sprint: OFBiz Community Day (May 2019) > Error while CSR creates a return. > - > > Key: OFBIZ-11068 > URL: https://issues.apache.org/jira/browse/OFBIZ-11068 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Dikpal Kanungo >Priority: Major > Attachments: Create_Return_issue .png, Error Message.png > > > When a CSR creates a return of a product, an unexpected error is occurring > due 'To Party ID'. Please follow the below steps - > Navigate to the following instance - > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/createReturn] > Create a return with the following details > Return Header type id = From Customer > Status ID = Requested > From Party ID = 10009 (Aashish Sharma) > To Party ID = 10001 (Agile team) > Payment mode = COD > Click on the 'Submit' button more than one time. > > Findings - The Role type of 10001 (Agile team) is of Internal Organization. > > Please have a look at the attached screenshot. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11059) Runtime error exceptions at Leads page
[ https://issues.apache.org/jira/browse/OFBIZ-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848185#comment-16848185 ] Kumar Rahul commented on OFBIZ-11059: - I have uploaded the Patch files for the fix, Please have a look. > Runtime error exceptions at Leads page > -- > > Key: OFBIZ-11059 > URL: https://issues.apache.org/jira/browse/OFBIZ-11059 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads?all=false >Reporter: Sanjay Yadav >Assignee: Kumar Rahul >Priority: Major > Labels: leads > Attachments: LeadPageRuntimeException.png, > OFBIZ-11059-release17.12.patch, OFBIZ-11059-release18.12.patch, > OFBIZ-11059-trunk.patch > > > Step to recreate issue - > # Login to [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Application > SFA > # SFA > Lead Manager > # Leads > Click on All Leads button > Actual - Application throw Runtime error exception in My Leads section. > please refer attached snapshot. > Expected - Proper result should display. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11059) Runtime error exceptions at Leads page
[ https://issues.apache.org/jira/browse/OFBIZ-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kumar Rahul updated OFBIZ-11059: Attachment: OFBIZ-11059-release18.12.patch OFBIZ-11059-release17.12.patch OFBIZ-11059-trunk.patch > Runtime error exceptions at Leads page > -- > > Key: OFBIZ-11059 > URL: https://issues.apache.org/jira/browse/OFBIZ-11059 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads?all=false >Reporter: Sanjay Yadav >Assignee: Kumar Rahul >Priority: Major > Labels: leads > Attachments: LeadPageRuntimeException.png, > OFBIZ-11059-release17.12.patch, OFBIZ-11059-release18.12.patch, > OFBIZ-11059-trunk.patch > > > Step to recreate issue - > # Login to [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Application > SFA > # SFA > Lead Manager > # Leads > Click on All Leads button > Actual - Application throw Runtime error exception in My Leads section. > please refer attached snapshot. > Expected - Proper result should display. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10881) Order detail is not displayed properly in order history tab
[ https://issues.apache.org/jira/browse/OFBIZ-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Kumar Pandey closed OFBIZ-10881. --- Resolution: Cannot Reproduce > Order detail is not displayed properly in order history tab > --- > > Key: OFBIZ-10881 > URL: https://issues.apache.org/jira/browse/OFBIZ-10881 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Ashish Sharma >Assignee: Ashish Kumar Pandey >Priority: Trivial > Attachments: OFBIZ-10881.png > > > *Step to reproduce* > 1.Login with valid username and password. > 2.Navigate to ecommerce. > 3.Place a order. > 4.Navigate to order history and click on view link. > *Expected Result:* Order detail should be displayed properly. > *Actual Result:* Order detail data is not displayed properly. > *Screen print attached* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11068) Error while CSR creates a return.
Dikpal Kanungo created OFBIZ-11068: -- Summary: Error while CSR creates a return. Key: OFBIZ-11068 URL: https://issues.apache.org/jira/browse/OFBIZ-11068 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Dikpal Kanungo Attachments: Create_Return_issue .png, Error Message.png When a CSR creates a return of a product, an unexpected error is occurring due 'To Party ID'. Please follow the below steps - Navigate to the following instance - [https://demo-trunk.ofbiz.apache.org/ordermgr/control/createReturn] Create a return with the following details Return Header type id = From Customer Status ID = Requested >From Party ID = 10009 (Aashish Sharma) To Party ID = 10001 (Agile team) Payment mode = COD Click on the 'Submit' button more than one time. Findings - The Role type of 10001 (Agile team) is of Internal Organization. Please have a look at the attached screenshot. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-7595) Replace references of Entity Engine methods with EntityQUery methods in various Groovy and Java Files
[ https://issues.apache.org/jira/browse/OFBIZ-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjay Yadav closed OFBIZ-7595. --- Resolution: Cannot Reproduce > Replace references of Entity Engine methods with EntityQUery methods in > various Groovy and Java Files > - > > Key: OFBIZ-7595 > URL: https://issues.apache.org/jira/browse/OFBIZ-7595 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Sanjay Yadav >Assignee: Sanjay Yadav >Priority: Minor > > Replace references of Entity Engine methods with EntityQUery methods in > various Groovy and Java Files. > This is a parent task to remove references of Entity Engine methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7595) Replace references of Entity Engine methods with EntityQUery methods in various Groovy and Java Files
[ https://issues.apache.org/jira/browse/OFBIZ-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjay Yadav updated OFBIZ-7595: Sprint: OFBiz Community Day (May 2019) > Replace references of Entity Engine methods with EntityQUery methods in > various Groovy and Java Files > - > > Key: OFBIZ-7595 > URL: https://issues.apache.org/jira/browse/OFBIZ-7595 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Sanjay Yadav >Assignee: Sanjay Yadav >Priority: Minor > > Replace references of Entity Engine methods with EntityQUery methods in > various Groovy and Java Files. > This is a parent task to remove references of Entity Engine methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7595) Replace references of Entity Engine methods with EntityQUery methods in various Groovy and Java Files
[ https://issues.apache.org/jira/browse/OFBIZ-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848180#comment-16848180 ] Sanjay Yadav commented on OFBIZ-7595: - Thanks Yashwant. Hence, closing it. > Replace references of Entity Engine methods with EntityQUery methods in > various Groovy and Java Files > - > > Key: OFBIZ-7595 > URL: https://issues.apache.org/jira/browse/OFBIZ-7595 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Sanjay Yadav >Assignee: Sanjay Yadav >Priority: Minor > > Replace references of Entity Engine methods with EntityQUery methods in > various Groovy and Java Files. > This is a parent task to remove references of Entity Engine methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-7595) Replace references of Entity Engine methods with EntityQUery methods in various Groovy and Java Files
[ https://issues.apache.org/jira/browse/OFBIZ-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjay Yadav reassigned OFBIZ-7595: --- Assignee: Sanjay Yadav (was: Yashwant Dhakad) > Replace references of Entity Engine methods with EntityQUery methods in > various Groovy and Java Files > - > > Key: OFBIZ-7595 > URL: https://issues.apache.org/jira/browse/OFBIZ-7595 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Sanjay Yadav >Assignee: Sanjay Yadav >Priority: Minor > > Replace references of Entity Engine methods with EntityQUery methods in > various Groovy and Java Files. > This is a parent task to remove references of Entity Engine methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10239) Improve GeneralLedgerServices to set AcctgTrans's transition date as payment's effective date
[
https://issues.apache.org/jira/browse/OFBIZ-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848176#comment-16848176
]
Manish Gurnani commented on OFBIZ-10239:
I ran the test cases after applying the patch and got errors it seems that
cause of these errors is not applied patch because I also ran the cases without
applying the patch and still getting the same error so IMO there is bug in the
test cases itself.
> Improve GeneralLedgerServices to set AcctgTrans's transition date as
> payment's effective date
> -
>
> Key: OFBIZ-10239
> URL: https://issues.apache.org/jira/browse/OFBIZ-10239
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Reporter: Aishwary Shrivastava
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-10239.patch,
> OFBIZ-10239_SetAccountingTransactionDates.patch
>
>
> Whenever user applies a payment, the {color:#008000}transactionDate
> {color}set on AcctgTransEntries is set by
> {color:#80}now-timestamp{color}, this can result in wrong accounting
> reports, if the payment was received earlier but applied later.
> For example, if someone receives a payment on 28 of Dec and applies the
> payment on 3rd of Jan, the yearly accounting reports will show that
> transaction in the new year, rather than in the previous year.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10983) Unable to choose the catalog in storefront apart from demo catalog
[ https://issues.apache.org/jira/browse/OFBIZ-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sasikant Biswal reassigned OFBIZ-10983: --- Assignee: (was: Sasikant Biswal) > Unable to choose the catalog in storefront apart from demo catalog > -- > > Key: OFBIZ-10983 > URL: https://issues.apache.org/jira/browse/OFBIZ-10983 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Ashish Sharma >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10983.docx > > > *Step to reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce.[https://demo-trunk.ofbiz.apache.org/ecomseo] > 3. Select the catalog as eBay catalog in choose catalog dropdown. > *Actual Result*: After page refresh demo catalog is applied. > *Screen attached* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7595) Replace references of Entity Engine methods with EntityQUery methods in various Groovy and Java Files
[ https://issues.apache.org/jira/browse/OFBIZ-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848177#comment-16848177 ] Yashwant Dhakad commented on OFBIZ-7595: Hi [~sanjay.ya...@hotwaxsystems.com], I looked into code base and not found any reference for Entity Engine method and I thik all the methods replaced with Entity Query method. So we can can safely close this ticket. > Replace references of Entity Engine methods with EntityQUery methods in > various Groovy and Java Files > - > > Key: OFBIZ-7595 > URL: https://issues.apache.org/jira/browse/OFBIZ-7595 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Sanjay Yadav >Assignee: Yashwant Dhakad >Priority: Minor > > Replace references of Entity Engine methods with EntityQUery methods in > various Groovy and Java Files. > This is a parent task to remove references of Entity Engine methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-7595) Replace references of Entity Engine methods with EntityQUery methods in various Groovy and Java Files
[ https://issues.apache.org/jira/browse/OFBIZ-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yashwant Dhakad reassigned OFBIZ-7595: -- Assignee: Yashwant Dhakad (was: Sanjay Yadav) > Replace references of Entity Engine methods with EntityQUery methods in > various Groovy and Java Files > - > > Key: OFBIZ-7595 > URL: https://issues.apache.org/jira/browse/OFBIZ-7595 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Sanjay Yadav >Assignee: Yashwant Dhakad >Priority: Minor > > Replace references of Entity Engine methods with EntityQUery methods in > various Groovy and Java Files. > This is a parent task to remove references of Entity Engine methods. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8861) Unit test case for service - GetReturnAmountByOrder
[
https://issues.apache.org/jira/browse/OFBIZ-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848175#comment-16848175
]
Yogesh Naroliya commented on OFBIZ-8861:
Hello team,
I have updated patch for the unit test of *getReturnAmountByOrder* service from
XML to DSL.
Also verified the patch using the following command:
{code:java}
./gradlew "ofbiz --test component=order --test suitename=ordertests"
{code}
Please have a look and let me know in case of any concerns.
Thanks in advance !!
> Unit test case for service - GetReturnAmountByOrder
> ---
>
> Key: OFBIZ-8861
> URL: https://issues.apache.org/jira/browse/OFBIZ-8861
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Yogesh Naroliya
>Priority: Minor
> Attachments: OFBIZ-8861.patch, OFBIZ-8861.patch
>
>
> Unit test case for service - GetReturnAmountByOrder
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-8861) Unit test case for service - GetReturnAmountByOrder
[ https://issues.apache.org/jira/browse/OFBIZ-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya updated OFBIZ-8861: --- Attachment: OFBIZ-8861.patch > Unit test case for service - GetReturnAmountByOrder > --- > > Key: OFBIZ-8861 > URL: https://issues.apache.org/jira/browse/OFBIZ-8861 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Yogesh Naroliya >Priority: Minor > Attachments: OFBIZ-8861.patch, OFBIZ-8861.patch > > > Unit test case for service - GetReturnAmountByOrder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10891) Send me this every month link is not working in order items section.
[ https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Sharma updated OFBIZ-10891: -- Component/s: ecommerce > Send me this every month link is not working in order items section. > > > Key: OFBIZ-10891 > URL: https://issues.apache.org/jira/browse/OFBIZ-10891 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Ashish Sharma >Assignee: vivek singh bisen >Priority: Minor > Attachments: OFBIZ-10891.png > > > *Steps to Reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Place a order. > 4. Navigate to order history and click on view link. > 5. Click on link “send me this every month” in order items section. > *Actual Result:* Error message is displayed. > *Screen print attached* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10883) Picklist is in Input status even after order is completed
[ https://issues.apache.org/jira/browse/OFBIZ-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848174#comment-16848174 ] Pawan Verma commented on OFBIZ-10883: - I have reviewed the patch and approach looks good to me. I have a suggestion here, Can we use any view-entity for fetching picklist records, if there is no related view-entity we can create one with Picklist and PicklistBin? > Picklist is in Input status even after order is completed > - > > Key: OFBIZ-10883 > URL: https://issues.apache.org/jira/browse/OFBIZ-10883 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10883.patch, OrderStatus.jpg, PicklistStatus.jpg > > > Steps to regenerate: > 1. Open https://demo-stable.ofbiz.apache.org/ordermgr/control/main > 2. Create order > 3. Open > https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse > 4. Create Picking > 5. Click on Packing under the facility > 6. Enter order id and click on pack order > 7. Enter package detail and complete packaging > 8. Open > https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse > Actual: Picklist is in the input status > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10976) Unable to add product to cart when user enter detail in Tell-A-Friend link.
[ https://issues.apache.org/jira/browse/OFBIZ-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Sharma updated OFBIZ-10976: -- Component/s: ecommerce > Unable to add product to cart when user enter detail in Tell-A-Friend link. > --- > > Key: OFBIZ-10976 > URL: https://issues.apache.org/jira/browse/OFBIZ-10976 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Ashish Sharma >Assignee: Rohit Hukkeri >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10976.patch, OFBIZ-10976.png > > > *Step to reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Select a product and click on link Tell-A-Friend. > 4. Enter detail in Tell-A-Friend window. > 5. Click on link add to cart link. > *Actual Result:* Error message is displayed as "Tell a friend sorry". > *Screen print attached* > *Note - Email validation is not added in Tell-A-Friend window.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8860) Unit test case for service - CreateReturnStatus
[
https://issues.apache.org/jira/browse/OFBIZ-8860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848173#comment-16848173
]
Yogesh Naroliya commented on OFBIZ-8860:
Hello team,
I have updated patch for the unit test of *createReturnStatus* service from XML
to DSL.
Also verified the patch using the following command:
{code:java}
./gradlew "ofbiz --test component=order --test suitename=ordertests"
{code}
Please have a look and let me know in case of any concerns.
Thanks in advance !!
> Unit test case for service - CreateReturnStatus
> ---
>
> Key: OFBIZ-8860
> URL: https://issues.apache.org/jira/browse/OFBIZ-8860
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Yogesh Naroliya
>Priority: Minor
> Attachments: OFBIZ-8860.patch, OFBIZ-8860.patch
>
>
> Unit test case for service - CreateReturnStatus
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-8860) Unit test case for service - CreateReturnStatus
[ https://issues.apache.org/jira/browse/OFBIZ-8860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya updated OFBIZ-8860: --- Attachment: OFBIZ-8860.patch > Unit test case for service - CreateReturnStatus > --- > > Key: OFBIZ-8860 > URL: https://issues.apache.org/jira/browse/OFBIZ-8860 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Yogesh Naroliya >Priority: Minor > Attachments: OFBIZ-8860.patch, OFBIZ-8860.patch > > > Unit test case for service - CreateReturnStatus -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (OFBIZ-10976) Unable to add product to cart when user enter detail in Tell-A-Friend link.
[ https://issues.apache.org/jira/browse/OFBIZ-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri reopened OFBIZ-10976: --- > Unable to add product to cart when user enter detail in Tell-A-Friend link. > --- > > Key: OFBIZ-10976 > URL: https://issues.apache.org/jira/browse/OFBIZ-10976 > Project: OFBiz > Issue Type: Bug >Reporter: Ashish Sharma >Assignee: Rohit Hukkeri >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10976.patch, OFBIZ-10976.png > > > *Step to reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Select a product and click on link Tell-A-Friend. > 4. Enter detail in Tell-A-Friend window. > 5. Click on link add to cart link. > *Actual Result:* Error message is displayed as "Tell a friend sorry". > *Screen print attached* > *Note - Email validation is not added in Tell-A-Friend window.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-8859) Unit test case for service - CreateReturnItemShipment
[ https://issues.apache.org/jira/browse/OFBIZ-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-8859: Assignee: Suraj Khurana (was: Yogesh Naroliya) > Unit test case for service - CreateReturnItemShipment > - > > Key: OFBIZ-8859 > URL: https://issues.apache.org/jira/browse/OFBIZ-8859 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-8859.patch, OFBIZ-8859.patch, OFBIZ-8859.patch > > > Unit test case for service - CreateReturnItemShipment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-8859) Unit test case for service - CreateReturnItemShipment
[ https://issues.apache.org/jira/browse/OFBIZ-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya updated OFBIZ-8859: --- Attachment: OFBIZ-8859.patch > Unit test case for service - CreateReturnItemShipment > - > > Key: OFBIZ-8859 > URL: https://issues.apache.org/jira/browse/OFBIZ-8859 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Yogesh Naroliya >Priority: Minor > Attachments: OFBIZ-8859.patch, OFBIZ-8859.patch, OFBIZ-8859.patch > > > Unit test case for service - CreateReturnItemShipment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-8937) Unit test case for service - CheckCreateProductRequirementForFacility
[ https://issues.apache.org/jira/browse/OFBIZ-8937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-8937: Assignee: Suraj Khurana (was: Anushi Gupta) > Unit test case for service - CheckCreateProductRequirementForFacility > - > > Key: OFBIZ-8937 > URL: https://issues.apache.org/jira/browse/OFBIZ-8937 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-8937.patch, OFBIZ-8937.patch > > > Unit test case for service - CheckCreateProductRequirementForFacility -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11060) Unable to open Competitors and Partners page
[ https://issues.apache.org/jira/browse/OFBIZ-11060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjay Yadav updated OFBIZ-11060: - Description: Steps to recreate - # [https://demo-trunk.ofbiz.apache.org/sfa/control/main] admin/ofbiz # Go to Applications > SFA # Go to SFA Manager > click Competitors & Partners Actual - application doesn't move to next step Expected - Competitors and Partners page should open. was: Steps to recreate - # [https://demo-trunk.ofbiz.apache.org/sfa/control/main] admin/ofbiz # Go to Applications > SFA # Go to SFA Manager > click Competitors & Parteners Actual - application doesn't move to next step Expected - Competitors and Partners page should open. > Unable to open Competitors and Partners page > > > Key: OFBIZ-11060 > URL: https://issues.apache.org/jira/browse/OFBIZ-11060 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk >Reporter: Sanjay Yadav >Priority: Major > > Steps to recreate - > # [https://demo-trunk.ofbiz.apache.org/sfa/control/main] admin/ofbiz > # Go to Applications > SFA > # Go to SFA Manager > click Competitors & Partners > Actual - application doesn't move to next step > Expected - Competitors and Partners page should open. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10983) Unable to choose the catalog in storefront apart from demo catalog
[ https://issues.apache.org/jira/browse/OFBIZ-10983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sasikant Biswal updated OFBIZ-10983: Description: *Step to reproduce* 1. Login with valid username and password. 2. Navigate to ecommerce.[https://demo-trunk.ofbiz.apache.org/ecomseo] 3. Select the catalog as eBay catalog in choose catalog dropdown. *Actual Result*: After page refresh demo catalog is applied. *Screen attached* was: *Step to reproduce* 1. Login with valid username and password. 2. Navigate to ecommerce. 3. Select the catalog as eBay catalog in choose catalog dropdown. *Actual Result*: After page refresh demo catalog is applied. *Screen attached* > Unable to choose the catalog in storefront apart from demo catalog > -- > > Key: OFBIZ-10983 > URL: https://issues.apache.org/jira/browse/OFBIZ-10983 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Ashish Sharma >Assignee: Sasikant Biswal >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10983.docx > > > *Step to reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce.[https://demo-trunk.ofbiz.apache.org/ecomseo] > 3. Select the catalog as eBay catalog in choose catalog dropdown. > *Actual Result*: After page refresh demo catalog is applied. > *Screen attached* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8859) Unit test case for service - CreateReturnItemShipment
[
https://issues.apache.org/jira/browse/OFBIZ-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848172#comment-16848172
]
Yogesh Naroliya commented on OFBIZ-8859:
Hello team,
I have updated patch for the unit test of *CreateReturnItemShipment* service
from XML to DSL.
Also verified the patch using the following command:
{code:java}
./gradlew "ofbiz --test component=order --test suitename=ordertests"
{code}
Please have a look and let me know in case of any concerns.
Thanks in advance !!
> Unit test case for service - CreateReturnItemShipment
> -
>
> Key: OFBIZ-8859
> URL: https://issues.apache.org/jira/browse/OFBIZ-8859
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Yogesh Naroliya
>Priority: Minor
> Attachments: OFBIZ-8859.patch, OFBIZ-8859.patch
>
>
> Unit test case for service - CreateReturnItemShipment
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-8859) Unit test case for service - CreateReturnItemShipment
[ https://issues.apache.org/jira/browse/OFBIZ-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya updated OFBIZ-8859: --- Attachment: OFBIZ-8859.patch > Unit test case for service - CreateReturnItemShipment > - > > Key: OFBIZ-8859 > URL: https://issues.apache.org/jira/browse/OFBIZ-8859 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Yogesh Naroliya >Priority: Minor > Attachments: OFBIZ-8859.patch, OFBIZ-8859.patch > > > Unit test case for service - CreateReturnItemShipment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10976) Unable to add product to cart when user enter detail in Tell-A-Friend link.
[ https://issues.apache.org/jira/browse/OFBIZ-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848169#comment-16848169 ] Rohit Hukkeri edited comment on OFBIZ-10976 at 5/25/19 12:07 PM: - Attaching patch for the mentioned issue. As mentioned in the ticket description, I was able to regenerate issue successfully on latest trunk version.Explored around it. When we select a product , click on the Tell-A-Friend link and filling the details in the window we will get back to main page.Adding product to cart consists of the controller request which has a field save-last-view and it is set as true. Hence it was redirecting to the window which was showing the error message i.e response to details filled in Tell-A-Friend window. Removing this field has solved the issue. was (Author: rohit.hukkeri): Attaching patch for the mentioned issue. As mentioned in the ticket description, I was able to regenerate issue successfully on latest trunk version.Explored around it. When we select a product , click on the Tell-A-Friend link and filling the details in the window we will get back to main page.Adding product to cart consists of the controller request which has a field save-last-view and it is set as true. Hence it was redirecting to the window which was showing the error message i.e response to details filled in Tell-A-Friend window. Removing this field will solve the issue hence closing the ticket for now. > Unable to add product to cart when user enter detail in Tell-A-Friend link. > --- > > Key: OFBIZ-10976 > URL: https://issues.apache.org/jira/browse/OFBIZ-10976 > Project: OFBiz > Issue Type: Bug >Reporter: Ashish Sharma >Assignee: Rohit Hukkeri >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10976.patch, OFBIZ-10976.png > > > *Step to reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Select a product and click on link Tell-A-Friend. > 4. Enter detail in Tell-A-Friend window. > 5. Click on link add to cart link. > *Actual Result:* Error message is displayed as "Tell a friend sorry". > *Screen print attached* > *Note - Email validation is not added in Tell-A-Friend window.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10976) Unable to add product to cart when user enter detail in Tell-A-Friend link.
[ https://issues.apache.org/jira/browse/OFBIZ-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri updated OFBIZ-10976: -- Attachment: OFBIZ-10976.patch > Unable to add product to cart when user enter detail in Tell-A-Friend link. > --- > > Key: OFBIZ-10976 > URL: https://issues.apache.org/jira/browse/OFBIZ-10976 > Project: OFBiz > Issue Type: Bug >Reporter: Ashish Sharma >Assignee: Rohit Hukkeri >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10976.patch, OFBIZ-10976.png > > > *Step to reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Select a product and click on link Tell-A-Friend. > 4. Enter detail in Tell-A-Friend window. > 5. Click on link add to cart link. > *Actual Result:* Error message is displayed as "Tell a friend sorry". > *Screen print attached* > *Note - Email validation is not added in Tell-A-Friend window.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-10976) Unable to add product to cart when user enter detail in Tell-A-Friend link.
[ https://issues.apache.org/jira/browse/OFBIZ-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri resolved OFBIZ-10976. --- Resolution: Fixed Attaching patch for the mentioned issue. As mentioned in the ticket description, I was able to regenerate issue successfully on latest trunk version.Explored around it. When we select a product , click on the Tell-A-Friend link and filling the details in the window we will get back to main page.Adding product to cart consists of the controller request which has a field save-last-view and it is set as true. Hence it was redirecting to the window which was showing the error message i.e response to details filled in Tell-A-Friend window. Removing this field will solve the issue hence closing the ticket for now. > Unable to add product to cart when user enter detail in Tell-A-Friend link. > --- > > Key: OFBIZ-10976 > URL: https://issues.apache.org/jira/browse/OFBIZ-10976 > Project: OFBiz > Issue Type: Bug >Reporter: Ashish Sharma >Assignee: Rohit Hukkeri >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10976.png > > > *Step to reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Select a product and click on link Tell-A-Friend. > 4. Enter detail in Tell-A-Friend window. > 5. Click on link add to cart link. > *Actual Result:* Error message is displayed as "Tell a friend sorry". > *Screen print attached* > *Note - Email validation is not added in Tell-A-Friend window.* -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848168#comment-16848168 ] Rohit Koushal commented on OFBIZ-11056: --- OFBIZ-5048 was pushed in TRUNK and R17. So I have updated the affected versions accordingly over the ticket > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Samuel Trégouët >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-11056.patch > > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-11056: -- Attachment: OFBIZ-11056.patch > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Samuel Trégouët >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-11056.patch > > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-11056: -- Affects Version/s: Release Branch 18.12 Release Branch 17.12 Trunk > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Samuel Trégouët >Assignee: Rohit Koushal >Priority: Major > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848167#comment-16848167 ] Rohit Koushal commented on OFBIZ-11056: --- Thank you [~stregouet] for pointing us in the right direction. I am attaching the patch that rectifies the problem which gets introduce in OFBIZ-5048. > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug >Reporter: Samuel Trégouët >Assignee: Rohit Koushal >Priority: Major > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11059) Runtime error exceptions at Leads page
[ https://issues.apache.org/jira/browse/OFBIZ-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11059: - Labels: leads (was: ) > Runtime error exceptions at Leads page > -- > > Key: OFBIZ-11059 > URL: https://issues.apache.org/jira/browse/OFBIZ-11059 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads?all=false >Reporter: Sanjay Yadav >Assignee: Kumar Rahul >Priority: Major > Labels: leads > Attachments: LeadPageRuntimeException.png > > > Step to recreate issue - > # Login to [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Application > SFA > # SFA > Lead Manager > # Leads > Click on All Leads button > Actual - Application throw Runtime error exception in My Leads section. > please refer attached snapshot. > Expected - Proper result should display. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10883) Picklist is in Input status even after order is completed
[ https://issues.apache.org/jira/browse/OFBIZ-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-10883: Affects Version/s: (was: 16.11.04) Release Branch 16.11 > Picklist is in Input status even after order is completed > - > > Key: OFBIZ-10883 > URL: https://issues.apache.org/jira/browse/OFBIZ-10883 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10883.patch, OrderStatus.jpg, PicklistStatus.jpg > > > Steps to regenerate: > 1. Open https://demo-stable.ofbiz.apache.org/ordermgr/control/main > 2. Create order > 3. Open > https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse > 4. Create Picking > 5. Click on Packing under the facility > 6. Enter order id and click on pack order > 7. Enter package detail and complete packaging > 8. Open > https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse > Actual: Picklist is in the input status > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11062) Wrong page title displayed on contact us page of ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848157#comment-16848157 ] Swapnil M Mane commented on OFBIZ-11062: Thank you [~ayushirathod44] for your contribution. I see some console log and merge conflict in your patch, can you please fix it. Thanks! > Wrong page title displayed on contact us page of ecommerce > -- > > Key: OFBIZ-11062 > URL: https://issues.apache.org/jira/browse/OFBIZ-11062 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Arpit Mor >Priority: Minor > Attachments: Image1.png, OFBIZ-11062.patch > > > Steps to regenerate: > * Navigate to [https://demo-trunk.ofbiz.apache.org/ecomseo/] or > [https://demo-stable.ofbiz.apache.org/ecommerce/control/main] > * Click on Login > * Enter valid username and password > * Click on login button > * Click on Contact Us > Actual: Page title displays Login. Please refer attachment: Image1 > Expected: Page title should not display Login as the user is already logged > in. It should display somthing like Contact Us -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11059) Runtime error exceptions at Leads page
[ https://issues.apache.org/jira/browse/OFBIZ-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kumar Rahul updated OFBIZ-11059: Attachment: leadPageRunTImeEx.patch > Runtime error exceptions at Leads page > -- > > Key: OFBIZ-11059 > URL: https://issues.apache.org/jira/browse/OFBIZ-11059 > Project: OFBiz > Issue Type: Bug > Components: marketing >Affects Versions: Trunk > Environment: > https://demo-trunk.ofbiz.apache.org/sfa/control/FindLeads?all=false >Reporter: Sanjay Yadav >Assignee: Kumar Rahul >Priority: Major > Attachments: LeadPageRuntimeException.png > > > Step to recreate issue - > # Login to [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Application > SFA > # SFA > Lead Manager > # Leads > Click on All Leads button > Actual - Application throw Runtime error exception in My Leads section. > please refer attached snapshot. > Expected - Proper result should display. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11062) Wrong page title displayed on contact us page of ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayushi Rathod reassigned OFBIZ-11062: - Assignee: (was: Ayushi Rathod) > Wrong page title displayed on contact us page of ecommerce > -- > > Key: OFBIZ-11062 > URL: https://issues.apache.org/jira/browse/OFBIZ-11062 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Arpit Mor >Priority: Minor > Attachments: Image1.png, OFBIZ-11062.patch > > > Steps to regenerate: > * Navigate to [https://demo-trunk.ofbiz.apache.org/ecomseo/] or > [https://demo-stable.ofbiz.apache.org/ecommerce/control/main] > * Click on Login > * Enter valid username and password > * Click on login button > * Click on Contact Us > Actual: Page title displays Login. Please refer attachment: Image1 > Expected: Page title should not display Login as the user is already logged > in. It should display somthing like Contact Us -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11062) Wrong page title displayed on contact us page of ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayushi Rathod updated OFBIZ-11062: -- Attachment: OFBIZ-11062.patch > Wrong page title displayed on contact us page of ecommerce > -- > > Key: OFBIZ-11062 > URL: https://issues.apache.org/jira/browse/OFBIZ-11062 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Arpit Mor >Assignee: Ayushi Rathod >Priority: Minor > Attachments: Image1.png, OFBIZ-11062.patch > > > Steps to regenerate: > * Navigate to [https://demo-trunk.ofbiz.apache.org/ecomseo/] or > [https://demo-stable.ofbiz.apache.org/ecommerce/control/main] > * Click on Login > * Enter valid username and password > * Click on login button > * Click on Contact Us > Actual: Page title displays Login. Please refer attachment: Image1 > Expected: Page title should not display Login as the user is already logged > in. It should display somthing like Contact Us -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11062) Wrong page title displayed on contact us page of ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848153#comment-16848153 ] Ayushi Rathod commented on OFBIZ-11062: --- Thanks for reporting the issue [~arpit.mor]. I am successfully able to replicate the issue and the fix is provided under the patch [^OFBIZ-11062.patch]. > Wrong page title displayed on contact us page of ecommerce > -- > > Key: OFBIZ-11062 > URL: https://issues.apache.org/jira/browse/OFBIZ-11062 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Arpit Mor >Assignee: Ayushi Rathod >Priority: Minor > Attachments: Image1.png, OFBIZ-11062.patch > > > Steps to regenerate: > * Navigate to [https://demo-trunk.ofbiz.apache.org/ecomseo/] or > [https://demo-stable.ofbiz.apache.org/ecommerce/control/main] > * Click on Login > * Enter valid username and password > * Click on login button > * Click on Contact Us > Actual: Page title displays Login. Please refer attachment: Image1 > Expected: Page title should not display Login as the user is already logged > in. It should display somthing like Contact Us -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848150#comment-16848150 ] Aditi Patidar commented on OFBIZ-9901: -- Providing the patch to fix the issue. > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditi Patidar >Priority: Major > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditi Patidar updated OFBIZ-9901: - Attachment: OFBIZ-9901.patch > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditi Patidar >Priority: Major > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditi Patidar reassigned OFBIZ-9901: Assignee: Aditi Patidar > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditi Patidar >Priority: Major > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment
[ https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-8858: Assignee: Suraj Khurana (was: Yogesh Naroliya) > Unit test case for service - CreateReturnAndItemOrAdjustment > > > Key: OFBIZ-8858 > URL: https://issues.apache.org/jira/browse/OFBIZ-8858 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-8858.patch, OFBIZ-8858.patch > > > Unit test case for service - CreateReturnAndItemOrAdjustment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment
[
https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848144#comment-16848144
]
Yogesh Naroliya commented on OFBIZ-8858:
Hello team,
I have updated patch for the unit test of *CreateReturnAndItemOrAdjustment*
service from XML to DSL.
Also verified the patch using the following command:
{code:java}
./gradlew "ofbiz --test component=order --test suitename=ordertests"
{code}
Please have a look and let me know in case of any concerns.
Thanks in advance !!
> Unit test case for service - CreateReturnAndItemOrAdjustment
>
>
> Key: OFBIZ-8858
> URL: https://issues.apache.org/jira/browse/OFBIZ-8858
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Yogesh Naroliya
>Priority: Minor
> Attachments: OFBIZ-8858.patch, OFBIZ-8858.patch
>
>
> Unit test case for service - CreateReturnAndItemOrAdjustment
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment
[ https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya updated OFBIZ-8858: --- Attachment: OFBIZ-8858.patch > Unit test case for service - CreateReturnAndItemOrAdjustment > > > Key: OFBIZ-8858 > URL: https://issues.apache.org/jira/browse/OFBIZ-8858 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Yogesh Naroliya >Priority: Minor > Attachments: OFBIZ-8858.patch, OFBIZ-8858.patch > > > Unit test case for service - CreateReturnAndItemOrAdjustment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8937) Unit test case for service - CheckCreateProductRequirementForFacility
[ https://issues.apache.org/jira/browse/OFBIZ-8937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848140#comment-16848140 ] Anushi Gupta commented on OFBIZ-8937: - Hello team, I have updated patch for the unit test of CreateProductRequirementForFacility service from XML to DSL and also verified the same. > Unit test case for service - CheckCreateProductRequirementForFacility > - > > Key: OFBIZ-8937 > URL: https://issues.apache.org/jira/browse/OFBIZ-8937 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Anushi Gupta >Priority: Minor > Attachments: OFBIZ-8937.patch, OFBIZ-8937.patch > > > Unit test case for service - CheckCreateProductRequirementForFacility -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-8937) Unit test case for service - CheckCreateProductRequirementForFacility
[ https://issues.apache.org/jira/browse/OFBIZ-8937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anushi Gupta updated OFBIZ-8937: Attachment: OFBIZ-8937.patch > Unit test case for service - CheckCreateProductRequirementForFacility > - > > Key: OFBIZ-8937 > URL: https://issues.apache.org/jira/browse/OFBIZ-8937 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Anushi Gupta >Priority: Minor > Attachments: OFBIZ-8937.patch, OFBIZ-8937.patch > > > Unit test case for service - CheckCreateProductRequirementForFacility -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-8860) Unit test case for service - CreateReturnStatus
[ https://issues.apache.org/jira/browse/OFBIZ-8860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya reassigned OFBIZ-8860: -- Assignee: Yogesh Naroliya > Unit test case for service - CreateReturnStatus > --- > > Key: OFBIZ-8860 > URL: https://issues.apache.org/jira/browse/OFBIZ-8860 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Yogesh Naroliya >Priority: Minor > Attachments: OFBIZ-8860.patch > > > Unit test case for service - CreateReturnStatus -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-8859) Unit test case for service - CreateReturnItemShipment
[ https://issues.apache.org/jira/browse/OFBIZ-8859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya reassigned OFBIZ-8859: -- Assignee: Yogesh Naroliya > Unit test case for service - CreateReturnItemShipment > - > > Key: OFBIZ-8859 > URL: https://issues.apache.org/jira/browse/OFBIZ-8859 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Yogesh Naroliya >Priority: Minor > Attachments: OFBIZ-8859.patch > > > Unit test case for service - CreateReturnItemShipment -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-8861) Unit test case for service - GetReturnAmountByOrder
[ https://issues.apache.org/jira/browse/OFBIZ-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yogesh Naroliya reassigned OFBIZ-8861: -- Assignee: Yogesh Naroliya > Unit test case for service - GetReturnAmountByOrder > --- > > Key: OFBIZ-8861 > URL: https://issues.apache.org/jira/browse/OFBIZ-8861 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Yogesh Naroliya >Priority: Minor > Attachments: OFBIZ-8861.patch > > > Unit test case for service - GetReturnAmountByOrder -- This message was sent by Atlassian JIRA (v7.6.3#76005)
