[jira] [Updated] (OFBIZ-11124) Allow to create single file if both directory and filename is provided by user

2019-06-24 Thread Jayansh Shinde (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayansh Shinde updated OFBIZ-11124:
---
Attachment: OFBIZ-11124.patch

> Allow to create single file if both directory and filename is provided by user
> --
>
> Key: OFBIZ-11124
> URL: https://issues.apache.org/jira/browse/OFBIZ-11124
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-11124.patch, 
> OFBiz-Web-Tools-XML-Data-Export_BothFilenameAndDir.png
>
>
> As reported by Jacques
> "Actually the path is missing in line 191 (same for XML, line 190) for 
> Windows to work:
> {{writer = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new 
> FileOutputStream(outpath + "/" + filename), "UTF-8")))}}
> I also think it should be used for *nix OS, else the file is always written 
> at OFBiz root"
>  
> If user provided file name and output directory in that case the entity xml 
> files are generated at both locations.
> As in attached image we have files created at both locations, i.e. at root we 
> have test.xml and in user provided output directory we have multiple files 
> with _[entityname]_.xml. 
> The expected change would be if user provided both output directory and 
> filename then file should be created in given directory with given filename.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11124) Allow to create single file if both directory and filename is provided by user

2019-06-24 Thread Jayansh Shinde (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayansh Shinde updated OFBIZ-11124:
---
Description: 
As reported by Jacques

"Actually the path is missing in line 191 (same for XML, line 190) for Windows 
to work:

{{writer = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new 
FileOutputStream(outpath + "/" + filename), "UTF-8")))}}

I also think it should be used for *nix OS, else the file is always written at 
OFBiz root"

 

If user provided file name and output directory in that case the entity xml 
files are generated at both locations.

As in attached image we have files created at both locations, i.e. at root we 
have test.xml and in user provided output directory we have multiple files with 
_[entityname]_.xml. 

The expected change would be if user provided both output directory and 
filename then file should be created in given directory with given filename.

 

  was:
As reported by Jacques

"Actually the path is missing in line 191 (same for XML, line 190) for Windows 
to work:

{{writer = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new 
FileOutputStream(outpath + "/" + filename), "UTF-8")))}}

I also think it should be used for *nix OS, else the file is always written at 
OFBiz root"

 

If user provided file name and output directory in that case the entity xml 
files are generated at both locations

!OFBiz-Web-Tools-XML-Data-Export_BothFilenameAndDir.png!

 

 

In this case we have files created at both locations, i.e. at root we have 
test.xml and in user provided output directory we have multiple files with 
_[entityname]_.xml. 

The expected change would be if user provided both output directory and 
filename then file should be created in given directory with given filename.

 


> Allow to create single file if both directory and filename is provided by user
> --
>
> Key: OFBIZ-11124
> URL: https://issues.apache.org/jira/browse/OFBIZ-11124
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBiz-Web-Tools-XML-Data-Export_BothFilenameAndDir.png
>
>
> As reported by Jacques
> "Actually the path is missing in line 191 (same for XML, line 190) for 
> Windows to work:
> {{writer = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new 
> FileOutputStream(outpath + "/" + filename), "UTF-8")))}}
> I also think it should be used for *nix OS, else the file is always written 
> at OFBiz root"
>  
> If user provided file name and output directory in that case the entity xml 
> files are generated at both locations.
> As in attached image we have files created at both locations, i.e. at root we 
> have test.xml and in user provided output directory we have multiple files 
> with _[entityname]_.xml. 
> The expected change would be if user provided both output directory and 
> filename then file should be created in given directory with given filename.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11125) No proper error message displayed if user misses to select entities

2019-06-24 Thread Jayansh Shinde (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayansh Shinde updated OFBIZ-11125:
---
Description: No Proper error message is displayed if user misses to select 
entities from the list, and throw error message as shown in attached image  
(was: No Proper error message is displayed if user misses to select entities 
from the list:

 

!OFBiz-Web-Tools-XML-Data-Export_no_proper_error_msg.png!)

> No proper error message displayed if user misses to select entities 
> 
>
> Key: OFBIZ-11125
> URL: https://issues.apache.org/jira/browse/OFBIZ-11125
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Reporter: Jayansh Shinde
>Priority: Major
> Attachments: OFBiz-Web-Tools-XML-Data-Export_no_proper_error_msg.png
>
>
> No Proper error message is displayed if user misses to select entities from 
> the list, and throw error message as shown in attached image



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jayansh Shinde (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871964#comment-16871964
 ] 

Jayansh Shinde commented on OFBIZ-10966:


I found one more bug, created one more ticket here:

https://issues.apache.org/jira/browse/OFBIZ-11125 

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_24062019.patch, 
> OFBiz-Web-Tools-JSON-Data-Export-All.png, 
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11125) No proper error message displayed if user misses to select entities

2019-06-24 Thread Jayansh Shinde (JIRA)
Jayansh Shinde created OFBIZ-11125:
--

 Summary: No proper error message displayed if user misses to 
select entities 
 Key: OFBIZ-11125
 URL: https://issues.apache.org/jira/browse/OFBIZ-11125
 Project: OFBiz
  Issue Type: Bug
  Components: framework/webtools
Reporter: Jayansh Shinde
 Attachments: OFBiz-Web-Tools-XML-Data-Export_no_proper_error_msg.png

No Proper error message is displayed if user misses to select entities from the 
list:

 

!OFBiz-Web-Tools-XML-Data-Export_no_proper_error_msg.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jayansh Shinde (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871963#comment-16871963
 ] 

Jayansh Shinde commented on OFBIZ-10966:


Hi Jacques

I created ticket for xml issue as per your suggestion. I have fixed same with 
json, I will upload patch by this week for xml as well.

https://issues.apache.org/jira/browse/OFBIZ-11124

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_24062019.patch, 
> OFBiz-Web-Tools-JSON-Data-Export-All.png, 
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11124) Allow to create single file if both directory and filename is provided by user

2019-06-24 Thread Jayansh Shinde (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayansh Shinde updated OFBIZ-11124:
---
Description: 
As reported by Jacques

"Actually the path is missing in line 191 (same for XML, line 190) for Windows 
to work:

{{writer = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new 
FileOutputStream(outpath + "/" + filename), "UTF-8")))}}

I also think it should be used for *nix OS, else the file is always written at 
OFBiz root"

 

If user provided file name and output directory in that case the entity xml 
files are generated at both locations

!OFBiz-Web-Tools-XML-Data-Export_BothFilenameAndDir.png!

 

 

In this case we have files created at both locations, i.e. at root we have 
test.xml and in user provided output directory we have multiple files with 
_[entityname]_.xml. 

The expected change would be if user provided both output directory and 
filename then file should be created in given directory with given filename.

 

  was:
As reported by Jacques

"Actually the path is missing in line 191 (same for XML, line 190) for Windows 
to work:

{{writer = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new 
FileOutputStream(outpath + "/" + filename), "UTF-8")))}}

I also think it should be used for *nix OS, else the file is always written at 
OFBiz root"

 

If user provided only file name and output directory in that case the entity 
xml files are generated at both locations

!OFBiz-Web-Tools-XML-Data-Export_BothFilenameAndDir.png!

 

 

In this case we have files created at both locations, i.e. at root we have 
test.xml and in user provided output directory we have multiple files with 
_[entityname]_.xml. 

The expected change would be if user provided both output directory and 
filename then file should be created in given directory with given filename.

 


> Allow to create single file if both directory and filename is provided by user
> --
>
> Key: OFBIZ-11124
> URL: https://issues.apache.org/jira/browse/OFBIZ-11124
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBiz-Web-Tools-XML-Data-Export_BothFilenameAndDir.png
>
>
> As reported by Jacques
> "Actually the path is missing in line 191 (same for XML, line 190) for 
> Windows to work:
> {{writer = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new 
> FileOutputStream(outpath + "/" + filename), "UTF-8")))}}
> I also think it should be used for *nix OS, else the file is always written 
> at OFBiz root"
>  
> If user provided file name and output directory in that case the entity xml 
> files are generated at both locations
> !OFBiz-Web-Tools-XML-Data-Export_BothFilenameAndDir.png!
>  
>  
> In this case we have files created at both locations, i.e. at root we have 
> test.xml and in user provided output directory we have multiple files with 
> _[entityname]_.xml. 
> The expected change would be if user provided both output directory and 
> filename then file should be created in given directory with given filename.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11124) Allow to create single file if both directory and filename is provided by user

2019-06-24 Thread Jayansh Shinde (JIRA)
Jayansh Shinde created OFBIZ-11124:
--

 Summary: Allow to create single file if both directory and 
filename is provided by user
 Key: OFBIZ-11124
 URL: https://issues.apache.org/jira/browse/OFBIZ-11124
 Project: OFBiz
  Issue Type: Improvement
  Components: framework/webtools
Reporter: Jayansh Shinde
Assignee: Jayansh Shinde
 Attachments: OFBiz-Web-Tools-XML-Data-Export_BothFilenameAndDir.png

As reported by Jacques

"Actually the path is missing in line 191 (same for XML, line 190) for Windows 
to work:

{{writer = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new 
FileOutputStream(outpath + "/" + filename), "UTF-8")))}}

I also think it should be used for *nix OS, else the file is always written at 
OFBiz root"

 

If user provided only file name and output directory in that case the entity 
xml files are generated at both locations

!OFBiz-Web-Tools-XML-Data-Export_BothFilenameAndDir.png!

 

 

In this case we have files created at both locations, i.e. at root we have 
test.xml and in user provided output directory we have multiple files with 
_[entityname]_.xml. 

The expected change would be if user provided both output directory and 
filename then file should be created in given directory with given filename.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jayansh Shinde (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayansh Shinde updated OFBIZ-10966:
---
Attachment: (was: OFBIZ-10966_24062019.patch)

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_24062019.patch, 
> OFBiz-Web-Tools-JSON-Data-Export-All.png, 
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jayansh Shinde (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayansh Shinde updated OFBIZ-10966:
---
Attachment: OFBIZ-10966_24062019.patch

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_24062019.patch, 
> OFBiz-Web-Tools-JSON-Data-Export-All.png, 
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance

2019-06-24 Thread bd2019us (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871823#comment-16871823
 ] 

bd2019us commented on OFBIZ-10934:
--

Apologies for the extreme delay, other projects temporarily diverted my 
attention away from this.

[~jacques.le.roux], when you refer to *Math#random,* you mean already existing 
*Math#random* instances which are left unchanged?

In the meantime, is there any other action that is needed from me?

 

 

> Performance Increase: Using replace() instead of replaceAll() when a regex is 
> not used increases performance
> 
>
> Key: OFBIZ-10934
> URL: https://issues.apache.org/jira/browse/OFBIZ-10934
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: bd2019us
>Priority: Trivial
>  Labels: pull-request-available
> Attachments: OFBIZ-10934.patch, OFBIZ10934-MORE.patch, affected_files
>
>
> Affected files:
> # framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
> # 
> framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
> # 
> framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java
> # framework/base/src/main/java/org/apache/ofbiz/base/util/KeyStoreUtil.java 
> When replaceAll() is utilized and no regex is used, replaceAll() can be 
> replaced with replace() for better performance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871209#comment-16871209
 ] 

Jacques Le Roux edited comment on OFBIZ-10966 at 6/24/19 5:28 PM:
--

Hi Jacques,

I am attaching new patch, this includes Import from Directory and Export All 
entities as well. 

But there is know bug in parsing, I working on same. This is regarding 
special/escape charters in JSON, entities like ElectronicText has html text and 
it has character like new line, tab, quote etc, which are giving me issue 
during import. 

I also removed bigger image and put smaller one ;).

I will open new Jira ticket tomorrow.

Thanks again!! 

[^OFBIZ-10966_24062019.patch]


was (Author: jayansh):
Hi Jacques,

I am attaching new patch, this includes Import from Directory and Export All 
entities as well. 

But there is know bug in parsing, I working on same. This is regarding 
special/escape charters in JSON, entities like ElectronicText has html text and 
it has character like new line, tab, quote etc, which are giving me issue 
during import. 

I also removed bigger image and put smaller one ;).

I will open new Jira ticket tomorrow.

Thanks again!! 

[^OFBIZ-10966_24062019.patch]

 

 

 

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_24062019.patch, 
> OFBiz-Web-Tools-JSON-Data-Export-All.png, 
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jayansh Shinde (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871209#comment-16871209
 ] 

Jayansh Shinde edited comment on OFBIZ-10966 at 6/24/19 1:42 PM:
-

Hi Jacques,

I am attaching new patch, this includes Import from Directory and Export All 
entities as well. 

But there is know bug in parsing, I working on same. This is regarding 
special/escape charters in JSON, entities like ElectronicText has html text and 
it has character like new line, tab, quote etc, which are giving me issue 
during import. 

I also removed bigger image and put smaller one ;).

I will open new Jira ticket tomorrow.

Thanks again!! 

[^OFBIZ-10966_24062019.patch]

 

 

 


was (Author: jayansh):
Hi Jacques,

I am attaching new patch, this also include Import from Directory and Export 
All entities as well. 

But there is know bug in parsing, I working on same. This is regarding 
special/escape charters in JSON, entities like ElectronicText has html text and 
it has character like new line, tab, quote etc, which are giving me issue 
during import.

I also removed bigger image and put smaller one ;).

I will open new Jira ticket tomorrow.

Thanks again!! 

[^OFBIZ-10966_24062019.patch]

 

 

 

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_24062019.patch, 
> OFBiz-Web-Tools-JSON-Data-Export-All.png, 
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jayansh Shinde (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayansh Shinde updated OFBIZ-10966:
---
Attachment: OFBiz-Web-Tools-JSON-Data-Import-Dir.png

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_24062019.patch, 
> OFBiz-Web-Tools-JSON-Data-Export-All.png, 
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jayansh Shinde (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayansh Shinde updated OFBIZ-10966:
---
Attachment: OFBiz-Web-Tools-JSON-Data-Export-All.png
exportJson.png

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_24062019.patch, 
> OFBiz-Web-Tools-JSON-Data-Export-All.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jayansh Shinde (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayansh Shinde updated OFBIZ-10966:
---
Attachment: OFBIZ-10966_24062019.patch

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_24062019.patch, 
> importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jayansh Shinde (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871209#comment-16871209
 ] 

Jayansh Shinde commented on OFBIZ-10966:


Hi Jacques,

I am attaching new patch, this also include Import from Directory and Export 
All entities as well. 

But there is know bug in parsing, I working on same. This is regarding 
special/escape charters in JSON, entities like ElectronicText has html text and 
it has character like new line, tab, quote etc, which are giving me issue 
during import.

I also removed bigger image and put smaller one ;).

I will open new Jira ticket tomorrow.

Thanks again!! 

[^OFBIZ-10966_24062019.patch]

 

 

 

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_24062019.patch, 
> importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jayansh Shinde (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayansh Shinde updated OFBIZ-10966:
---
Attachment: (was: exportJson.png)

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-11060) Unable to open Competitors and Partners page

2019-06-24 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-11060.
---

> Unable to open Competitors and Partners page
> 
>
> Key: OFBIZ-11060
> URL: https://issues.apache.org/jira/browse/OFBIZ-11060
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Sanjay Yadav
>Assignee: Pawan Verma
>Priority: Major
>
> Steps to recreate -
>  # [https://demo-trunk.ofbiz.apache.org/sfa/control/main]  admin/ofbiz
>  # Go to Applications > SFA
>  # Go to SFA Manager > click Competitors & Partners
> Actual - application doesn't move to next step
> Expected - Competitors and Partners page should open.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-11060) Unable to open Competitors and Partners page

2019-06-24 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma resolved OFBIZ-11060.
-
Resolution: Duplicate

Hello [~sanjay.ya...@hotwaxsystems.com], All,

This ticket is a duplicate of 
[OFBIZ-10823|https://issues.apache.org/jira/browse/OFBIZ-10823]. Closing this 
one. Thanks!

> Unable to open Competitors and Partners page
> 
>
> Key: OFBIZ-11060
> URL: https://issues.apache.org/jira/browse/OFBIZ-11060
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Sanjay Yadav
>Assignee: Pawan Verma
>Priority: Major
>
> Steps to recreate -
>  # [https://demo-trunk.ofbiz.apache.org/sfa/control/main]  admin/ofbiz
>  # Go to Applications > SFA
>  # Go to SFA Manager > click Competitors & Partners
> Actual - application doesn't move to next step
> Expected - Competitors and Partners page should open.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11060) Unable to open Competitors and Partners page

2019-06-24 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11060:
---

Assignee: Pawan Verma

> Unable to open Competitors and Partners page
> 
>
> Key: OFBIZ-11060
> URL: https://issues.apache.org/jira/browse/OFBIZ-11060
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Sanjay Yadav
>Assignee: Pawan Verma
>Priority: Major
>
> Steps to recreate -
>  # [https://demo-trunk.ofbiz.apache.org/sfa/control/main]  admin/ofbiz
>  # Go to Applications > SFA
>  # Go to SFA Manager > click Competitors & Partners
> Actual - application doesn't move to next step
> Expected - Competitors and Partners page should open.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10585) Production run not created for marketing package auto type product if component inventory is not available

2019-06-24 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-10585:
---

Assignee: Pawan Verma  (was: Ankush Upadhyay)

> Production run not created for marketing package auto type product if 
> component inventory is not available
> --
>
> Key: OFBIZ-10585
> URL: https://issues.apache.org/jira/browse/OFBIZ-10585
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Yashwant Dhakad
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10585.patch
>
>
> When we create an order for marketing package auto, the system checks the 
> component inventory and if found then it creates the production run job and 
> produce marketing package inventory, but if component quantity not available 
> then it does not create the job. So if we don't have an inventory item of 
> component then production run should be created with created status.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10539) Issue with opening a page via bookmark when the user is logged out

2019-06-24 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-10539:
---

Assignee: Pawan Verma  (was: Ritesh Kumar)

> Issue with opening a page via bookmark when the user is logged out
> --
>
> Key: OFBIZ-10539
> URL: https://issues.apache.org/jira/browse/OFBIZ-10539
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, Release Branch 17.12
>Reporter: Ritesh Kumar
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10539.patch
>
>
> Please refer to the discussions on 
> [dev-mailing-list|https://markmail.org/message/zbdjmghgqldxbnbu]
> There are issues with opening a bookmarked page when the user is logged out. 
> Steps to generate: 
> (Please refer 
> [Demo-trunk|https://demo-trunk.ofbiz.apache.org/webtools/control/main])
> 1. Open this link, 
> [FindWorkEffort|https://demo-trunk.ofbiz.apache.org/workeffort/control/FindWorkEffort].
>  Find Work Effort screen will be rendered.
> 2. Inspect and change the form method to "GET".
> 3. Apply any of the two statuses (say, Cancelled and Declined). Click on Find.
> 4. Records will be fetched according to the applied filters. 
> 5. Check the URL. Cancelled and Declined statuses must be there in the URL.
> 6. Bookmark this page and log out.
> 7. Now, open the bookmark.
> 8. The login page will be rendered. Check the URL here. It will be the same 
> as it was when the page was being bookmarked.
> 9. Type in the credentials and log in.
> 10. The result may be different. Check the URL. One of the statuses is gone. 
> Following are the issues: 
> The bug here is (supposing the GET method is used)
> 1. On opening the bookmark, the page is rendered with double encoding (if the 
> value had a space character initially, the space character was already 
> encoded into '+' in the URL and when this bookmark is opened, this '+' is 
> again encoded). This particular issue cannot be generated from the 
> above-mentioned steps but it exists. 
> 2. Suppose the bookmarked URL had multiple values from the same filter (say, 
> Cancelled and Declined status), it renders with just one of the statutes 
> applied. It is because the request handler prepares a Map of parameters from 
> the query string and as is the property of Map to replace the old value if a 
> new value is being added with the same key (in this example, first Cancelled 
> status is put in this Map and then Declined), only Declined status is put in 
> this Map. 
> What happens is that the request handler prepares a map of query parameters 
> from the query string and this map is used to create a redirect target.  This 
> redirect target (at this instance having both the above-mentioned issues) is 
> called upon to render the requested page.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10538) Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity

2019-06-24 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-10538:
---

Assignee: Pawan Verma  (was: Amit Gadaley)

> Promised Datetime & Current Promised Date values not getting updated in 
> OISGIR Entity
> -
>
> Key: OFBIZ-10538
> URL: https://issues.apache.org/jira/browse/OFBIZ-10538
> Project: OFBiz
>  Issue Type: Bug
>  Components: order, product
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10538.patch
>
>
> While creating the sales order from the backend, if we set the 'Ship Before 
> Date' it will be stored in OrderItemShipGroup.shipByDate field and same will 
> be propagated to OrderItemShipGrpInvRes.promisedDateTime and 
> OrderItemShipGrpInvRes.currentPromisedDate fields.
>   
>  On updating the 'Ship Before Date' from the order view page later, the 
> promisedDateTime and currentPromisedDate get updated in OrderItemShipGroup 
> entity but remains the same in OrderItemShipGroupInvRes entity. 
>   
>  As OrderItemShipGrpInvRes.promisedDateTime & 
> OrderItemShipGrpInvRes.currentPromisedDate are being used in many services 
> like 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity', 
> 'reserveProductInventory' etc., we should also update these on updating the 
> 'Ship Before Date' from the order overview page. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871164#comment-16871164
 ] 

Jacques Le Roux edited comment on OFBIZ-10145 at 6/24/19 12:50 PM:
---

[^gradlew.bat.patch] is the last and simplest solution corresponding to my last 
proposition. It answers to Swapnil's concern about Gradle updates on trunk.

I'll wait a community agreement before writing a wiki page explaining what to 
do when updating Gradle. If we agree I'll also update the [release management 
page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz].
 We need to create entries in 
[https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper] for each 
new release branch, and to update the trunk one when we upgrade Gradle.


was (Author: jacques.le.roux):
 [^gradlew.bat.patch] is the last and simplest solution corresponding to my 
last proposition. It answers to Swapnil's concern about Gradle updates on 
trunk. 

I'll wait a community agreement before writing a wiki page explaining what to 
do when updating Gradle. If we agree I'll also update the [release management 
page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz].
 We need to create entries in 
https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each 
new release branch, and to update the trunk one when we upgrade Gradle.

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, 
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-24 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10145:

Attachment: gradlew.bat.patch

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, 
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871164#comment-16871164
 ] 

Jacques Le Roux edited comment on OFBIZ-10145 at 6/24/19 12:49 PM:
---

 [^gradlew.bat.patch] is the last and simplest solution corresponding to my 
last proposition. It answers to Swapnil's concern about Gradle updates on 
trunk. 

I'll wait a community agreement before writing a wiki page explaining what to 
do when updating Gradle. If we agree I'll also update the [release management 
page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz].
 We need to create entries in 
https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each 
new release branch, and to update the trunk one when we upgrade Gradle.


was (Author: jacques.le.roux):
 [^gradlew.bat.patch]  is the last and simplest solution corresponding to my 
last proposition. It answers to Swapnil's concern about Gradle updates on 
trunk. 

I'll wait a community agreement before writing a wiki page explaining what to 
do when updating Gradle. If we agree I'll also update the [release management 
page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz].
 We need to create entries in 
https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each 
new release branch, and to update the trunk one when we upgrade Gradle.

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-24 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10145:

Attachment: gradlew.bat.patch

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10796) Check run payment(A/P) transactions not getting available for reconciliation

2019-06-24 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-10796:
---

Assignee: Pawan Verma  (was: Chinmay Patidar)

> Check run payment(A/P) transactions not getting available for reconciliation
> 
>
> Key: OFBIZ-10796
> URL: https://issues.apache.org/jira/browse/OFBIZ-10796
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, 17.12.01, 16.11.05, 18.12.01
>Reporter: Chinmay Patidar
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10796.patch
>
>
> Check run payment group transactions don't get available for Financial 
> Account reconciliation. Though the financial account balance gets updated 
> during the A/P check run process, the system must allow the user with an 
> additional step of reconciling the transactions.
> Steps to regenerate:
>  # Create a Check Run type payment group by issuing checks for an invoice/ 
> the invoices from the following screen: 
> [https://demo-trunk.ofbiz.apache.org/ap/control/FindPurchaseInvoices]
>  # (Additional Note)The balance of the financial account gets updated as soon 
> as the payment group is created.
>  # Visit to the "Find Transaction" screen of the company from which the check 
> run was created.
>  # Set 'Gl Reconciliation ID' field to value 'Not Assigned' and find the 
> transaction. The newly created Financial account transaction won't be 
> available to assign to a reconciliation.
> The cause of this is that the financial account transaction doesn't get 
> created in the 'Created' status and has an 'Approved' status. An approved 
> status financial transaction directly updates the financial account balance 
> and thus don't appear in the list of the transactions to be reconciled. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10823) Removing "Competitors & Partners" and "Documents" from SFA

2019-06-24 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-10823:
---

Assignee: Pawan Verma

> Removing "Competitors & Partners" and "Documents" from SFA
> --
>
> Key: OFBIZ-10823
> URL: https://issues.apache.org/jira/browse/OFBIZ-10823
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10823_SfaMenus.patch
>
>
> There are two dead menu items, namely "Competitors & Partners" and 
> "Documents", which can be found in Sales Force Automation (SFA).
> Some years ago, some people started development for this feature, as seen 
> here OFBIZ-2364, but it was never finished.
> After some quick research, it seemed like nothing got patched into OFBiz 
> either.
> I asked via the developer mailinglist, if there were any objections against 
> removing the menu items and since there were no complains, I will provide a 
> patch in here to remove them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871164#comment-16871164
 ] 

Jacques Le Roux edited comment on OFBIZ-10145 at 6/24/19 12:42 PM:
---

 [^gradlew.bat.patch]  is the last and simplest solution corresponding to my 
last proposition. It answers to Swapnil's concern about Gradle updates on 
trunk. 

I'll wait a community agreement before writing a wiki page explaining what to 
do when updating Gradle. If we agree I'll also update the [release management 
page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz].
 We need to create entries in 
https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each 
new release branch, and to update the trunk one when we upgrade Gradle.


was (Author: jacques.le.roux):
 [^gradlew.bat.patch]  is the last and simplest solution corresponding to my 
last proposition. It answers to Swapnil's concern about Gradle updates on 
trunk. 

I'll wait a community agreement before writing a wiki page explaining what to 
do when updating Gradle. If we agree I'll also update the [release management 
page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz].
 We need to create entries in 
https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each 
new release branch and to update the trunk one.

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871164#comment-16871164
 ] 

Jacques Le Roux commented on OFBIZ-10145:
-

 [^gradlew.bat.patch]  is the last and simplest solution corresponding to my 
last proposition. It answers to Swapnil's concern about Gradle updates on 
trunk. 

I'll wait a community agreement before writing a wiki page explaining what to 
do when updating Gradle. If we agree I'll also update the [release management 
page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz].
 We need to create entries in 
https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each 
new release branch.

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10841) findGlAccountReconciliation(s) providing not associated glAccounts

2019-06-24 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-10841:
---

Assignee: Pawan Verma  (was: Ulrich Heidfeld)

> findGlAccountReconciliation(s) providing not associated glAccounts
> --
>
> Key: OFBIZ-10841
> URL: https://issues.apache.org/jira/browse/OFBIZ-10841
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Ulrich Heidfeld
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10841_GlFroms.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> By using the drop down menu in 
> [findGlAccountReconciliation|https://demo-stable.ofbiz.apache.org/accounting/control/findGlAccountReconciliation?organizationPartyId=Company]
>  and 
> [findGlAccountReconciliations|https://demo-stable.ofbiz.apache.org/accounting/control/findGlAccountReconciliations?organizationPartyId=Company]
>  you are able to select any account of GlAccounts. So it doesn't matter which 
> account is associated to the company. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871164#comment-16871164
 ] 

Jacques Le Roux edited comment on OFBIZ-10145 at 6/24/19 12:41 PM:
---

 [^gradlew.bat.patch]  is the last and simplest solution corresponding to my 
last proposition. It answers to Swapnil's concern about Gradle updates on 
trunk. 

I'll wait a community agreement before writing a wiki page explaining what to 
do when updating Gradle. If we agree I'll also update the [release management 
page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz].
 We need to create entries in 
https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each 
new release branch and to update the trunk one.


was (Author: jacques.le.roux):
 [^gradlew.bat.patch]  is the last and simplest solution corresponding to my 
last proposition. It answers to Swapnil's concern about Gradle updates on 
trunk. 

I'll wait a community agreement before writing a wiki page explaining what to 
do when updating Gradle. If we agree I'll also update the [release management 
page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz].
 We need to create entries in 
https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each 
new release branch.

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2019-06-24 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-10879:
---

Assignee: Pawan Verma  (was: Ulrich Heidfeld)

> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-24 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10145:

Attachment: gradlew.bat.patch

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10975) Improve the buttons on edit credit card page

2019-06-24 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-10975:
---

Assignee: Pawan Verma  (was: Sourabh Punyani)

> Improve the buttons on edit credit card page
> 
>
> Key: OFBIZ-10975
> URL: https://issues.apache.org/jira/browse/OFBIZ-10975
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Padmavati Rawat
>Assignee: Pawan Verma
>Priority: Major
> Attachments: Buttonissue.png, OFBIZ-10975.patch
>
>
> Steps:
> 1. Visit the demo-trunk.ofbiz.apache.org/ecommerce.
> 2. Login to the system.
> 3. Add Credit card details for the customer on the customer profile page.
> 4. Check the Go Back and Save button after adding the credit card details.
> Actual:
> Go Back and Save button display twice on the header of the page, after adding 
> the credit card for the customer.
> Expected:
> The buttons should not be displayed twice after adding the credit card 
> details.
> Please refer screenshot;



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871059#comment-16871059
 ] 

Jacques Le Roux commented on OFBIZ-10966:
-

Hi Jayansh,

bq. we can use File.separator instead of "/"
Sure, was just a quick example ;) Actually "/" was also working in WIndows 7...

I have removed an almost duplicate comment of yours (the older, I checked by 
comparison) and the 2 images it was too much, I can still refer to them ;)

bq. Let me know can I fix this in XML data export as well,  or should create 
separate ticket for same.
Right, I tnink a new Jira fits, better not mix too much things indeed

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870752#comment-16870752
 ] 

Jacques Le Roux edited comment on OFBIZ-10966 at 6/24/19 10:41 AM:
---

Hi Jacques,

This is my mistake, I should have uploaded screenshots, what's included in this 
patch, currently we have only 2 pages Import Json and Export Json as we have 
for xml, I will try to complete "JSON Data Export All" and "JSON Data Import 
Dir" by this week. what else is missing, do you thing its worth adding "JSON 
Data Import Readers".

I am on ubuntu, I will check this on windows today. There we can use 
File.separator instead of slach or antislash to avoid platform specific issues.


was (Author: jayansh):
Hi Jacques,

This is my mistake, I should have uploaded screenshots, what's included in this 
patch, currently we have only 2 pages Import Json and Export Json as we have 
for xml, I will try to complete "JSON Data Export All" and "JSON Data Import 
Dir" by this week. what else is missing, do you thing its worth adding "JSON 
Data Import Readers".

I am on ubuntu, I will check this on windows today. There we can use 
File.separator instead of "/" or "\\" to avoid platform specific issues.

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870752#comment-16870752
 ] 

Jacques Le Roux edited comment on OFBIZ-10966 at 6/24/19 10:38 AM:
---

Hi Jacques,

This is my mistake, I should have uploaded screenshots, what's included in this 
patch, currently we have only 2 pages Import Json and Export Json as we have 
for xml, I will try to complete "JSON Data Export All" and "JSON Data Import 
Dir" by this week. what else is missing, do you thing its worth adding "JSON 
Data Import Readers".

I am on ubuntu, I will check this on windows today. There we can use 
File.separator instead of "/" or "\\" to avoid platform specific issues.


was (Author: jayansh):
Hi Jacques,

This is my mistake, I should have uploaded screenshots, what's included in this 
patch, currently we have only 2 pages Import Json and Export Json as we have 
for xml, I will try to complete "JSON Data Export All" and "JSON Data Import 
Dir" by this week. what else is missing, do you thing its worth adding "JSON 
Data Import Readers".

I am on ubuntu, I will check this on windows today. There we can use 
File.separator instead of "/" or "\\" to avoid platform specific issues. 
!importJson.png!

 

!exportJson.png!

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Issue Comment Deleted] (OFBIZ-10966) JSON entity data import and export utility

2019-06-24 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10966:

Comment: was deleted

(was: Agreed with you

_"Actually the path is missing in line 191 (same for XML, line 190) for Windows 
to work:_

_{{writer = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new 
FileOutputStream(outpath + "/" + filename), "UTF-8")))}}_

_I also think it should be used for *nix OS, else the file is always written at 
OFBiz root"_

Currently we put full path in filename to get it work otherwise its created at 
OFBiz root. 

I will put support for this:

_filename_ is name with _Output directory =_ generate it in Ouput directory 
with given name.

Let me know can I fix this in XML data export as well,  or should create 
separate ticket for same.

 )

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10858) Last Categories section is blank

2019-06-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871050#comment-16871050
 ] 

Jacques Le Roux commented on OFBIZ-10858:
-

Thanks Priya,

Your trunk patch is in
trunk r1861986
R18 r1861987
R17 r1861988

The stable one is in at r1861989


> Last Categories section is blank 
> -
>
> Key: OFBIZ-10858
> URL: https://issues.apache.org/jira/browse/OFBIZ-10858
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 16.11.05
>Reporter: Rashi Dhagat
>Assignee: Priya Sharma
>Priority: Major
> Attachments: LastCategories1.jpg, LastCategoriesRefreshed.jpg, 
> LastCategories_1strow.jpg, OFBIZ-10858-1.patch, OFBIZ-10858-stable.patch, 
> OFBIZ-10858.patch
>
>
> Issue 1:
> 1. Open [https://demo-trunk.ofbiz.apache.org/ecomseo]
> 2. Click on a category from the Categories section
> 3. Refresh the page
> *Actual:*
> 1. Last Categories is blank
> 2. If we refresh the page then only the search category visible with the last 
> row blank with a bullet.
> Issue 1:
> 1. Open [https://demo-trunk.ofbiz.apache.org/ecomseo]
> 2. Click on a category from the Categories section
> 3. Again, open the [https://demo-trunk.ofbiz.apache.org/ecomseo] in the new 
> tab
> *Actual:* 1st row is blank with searched categories



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10858) Last Categories section is blank

2019-06-24 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10858.
---
   Resolution: Fixed
Fix Version/s: 18.12.01
   16.11.06
   17.12.01

> Last Categories section is blank 
> -
>
> Key: OFBIZ-10858
> URL: https://issues.apache.org/jira/browse/OFBIZ-10858
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 16.11.05
>Reporter: Rashi Dhagat
>Assignee: Priya Sharma
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: LastCategories1.jpg, LastCategoriesRefreshed.jpg, 
> LastCategories_1strow.jpg, OFBIZ-10858-1.patch, OFBIZ-10858-stable.patch, 
> OFBIZ-10858.patch
>
>
> Issue 1:
> 1. Open [https://demo-trunk.ofbiz.apache.org/ecomseo]
> 2. Click on a category from the Categories section
> 3. Refresh the page
> *Actual:*
> 1. Last Categories is blank
> 2. If we refresh the page then only the search category visible with the last 
> row blank with a bullet.
> Issue 1:
> 1. Open [https://demo-trunk.ofbiz.apache.org/ecomseo]
> 2. Click on a category from the Categories section
> 3. Again, open the [https://demo-trunk.ofbiz.apache.org/ecomseo] in the new 
> tab
> *Actual:* 1st row is blank with searched categories



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9522) User should be notified with success message on creating shopping list in ecommerce component

2019-06-24 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-9522:

Affects Version/s: Release Branch 18.12
   Release Branch 17.12
   Trunk
   Release Branch 16.11

> User should be notified with success message on creating shopping list in 
> ecommerce component
> -
>
> Key: OFBIZ-9522
> URL: https://issues.apache.org/jira/browse/OFBIZ-9522
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: OFBIZ-9522.patch
>
>
> Steps to regenerate:
> 1. Login to Ecommerce component 
> (https://demo-trunk.ofbiz.apache.org/ecommerce/control/main).
> 2. Go to 
> Shoppinglists.(https://localhost:8443/ecommerce/control/editShoppingList).
> 3. Click on Create new.
> 4. Fill all required fields and Click Save button
> No success message on the successful action.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9329) User should be notified with success message on successful completion of any action

2019-06-24 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-9329:

Affects Version/s: Release Branch 18.12
   Release Branch 17.12
   Trunk

> User should be notified with success message on successful completion of any 
> action
> ---
>
> Key: OFBIZ-9329
> URL: https://issues.apache.org/jira/browse/OFBIZ-9329
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
>
> On performing any action, user should be notified with the success message if 
> the action has been performed successfully.
> Listing actions with no alert messages delivered on success and will be 
> creating sub-tickets for the same.
> Ecommerce:
> 1. Subscribe to Newsletter: OFBIZ-9320
> 2. Add to Cart: OFBIZ-9521
> 3. Create/Update Shopping List: OFBIZ-9522
> 4. Last Categories > Clear: 
> Order Manager:
> 1. Update Quote: OFBIZ-9519
> 2. remove Quote Role:
> 3. Send Report by Mail from View Quote: OFBIZ-9321
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11013) Scrum parties don't have partyTypeId set

2019-06-24 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11013:
---

Assignee: Pawan Verma  (was: Pierre Smits)

> Scrum parties don't have partyTypeId set
> 
>
> Key: OFBIZ-11013
> URL: https://issues.apache.org/jira/browse/OFBIZ-11013
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, Release Branch 16.11, Release Branch 17.12, Release 
> Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
>  Labels: data
> Attachments: OFBIZ-11013-Scrum.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9522) User should be notified with success message on creating shopping list in ecommerce component

2019-06-24 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-9522:

Component/s: (was: ALL COMPONENTS)
 ecommerce

> User should be notified with success message on creating shopping list in 
> ecommerce component
> -
>
> Key: OFBIZ-9522
> URL: https://issues.apache.org/jira/browse/OFBIZ-9522
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: OFBIZ-9522.patch
>
>
> Steps to regenerate:
> 1. Login to Ecommerce component 
> (https://demo-trunk.ofbiz.apache.org/ecommerce/control/main).
> 2. Go to 
> Shoppinglists.(https://localhost:8443/ecommerce/control/editShoppingList).
> 3. Click on Create new.
> 4. Fill all required fields and Click Save button
> No success message on the successful action.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9533) User should be notified with success message on MRP run in manufacturing component

2019-06-24 Thread Prachi Shastri (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870947#comment-16870947
 ] 

Prachi Shastri commented on OFBIZ-9533:
---

I have tested the patch and it is working as expected.

> User should be notified with success message on MRP run in manufacturing 
> component
> --
>
> Key: OFBIZ-9533
> URL: https://issues.apache.org/jira/browse/OFBIZ-9533
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Aditya Sharma
>Assignee: Humera Khan
>Priority: Trivial
> Attachments: OFBIZ-9533-trunk.patch, OFBIZ-9533.patch
>
>
> Steps to regenerate:
> 1. Go to Manufacturing component 
> (https://demo-trunk.ofbiz.apache.org/manufacturing/control/main)
> 2. Click on Mrp sub menu 
> (https://demo-trunk.ofbiz.apache.org/manufacturing/control/FindInventoryEventPlan)
> 3. Click on Run Mrp 
> button.(https://demo-trunk.ofbiz.apache.org/manufacturing/control/RunMrp)
> 4. Select Facility/Facility Group and Click Submit button.
> On success, the user should be notified with success message like "Mrp run is 
> scheduled".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number

2019-06-24 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870862#comment-16870862
 ] 

Pawan Verma commented on OFBIZ-0:
-

I think, we should be able to generate this issue in Trunk and other branches 
also. We should also check it once and if this exists please update the Affects 
Version/s.

> Able to add phone no. as contact type without adding number
> ---
>
> Key: OFBIZ-0
> URL: https://issues.apache.org/jira/browse/OFBIZ-0
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Rashi Dhagat
>Priority: Major
> Attachments: OFBIZ-0.patch
>
>
> Steps to regenerate:
>  # Open url 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile]
>  # Click on "Create new" in Contact Information section
>  # Select phone no as contact type
>  # Click on Create
>  # Click on Save
> Actual: Able to add phone no as contact type without adding no.
> Expected: Error message should be displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11110) Able to add phone no. as contact type without adding number

2019-06-24 Thread Pradeep Choudhary (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-0:
--
Attachment: OFBIZ-0.patch

> Able to add phone no. as contact type without adding number
> ---
>
> Key: OFBIZ-0
> URL: https://issues.apache.org/jira/browse/OFBIZ-0
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Rashi Dhagat
>Priority: Major
> Attachments: OFBIZ-0.patch
>
>
> Steps to regenerate:
>  # Open url 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile]
>  # Click on "Create new" in Contact Information section
>  # Select phone no as contact type
>  # Click on Create
>  # Click on Save
> Actual: Able to add phone no as contact type without adding no.
> Expected: Error message should be displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11110) Able to add phone no. as contact type without adding number

2019-06-24 Thread Pradeep Choudhary (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-0:
--
Attachment: (was: HC-0.patch)

> Able to add phone no. as contact type without adding number
> ---
>
> Key: OFBIZ-0
> URL: https://issues.apache.org/jira/browse/OFBIZ-0
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Rashi Dhagat
>Priority: Major
> Attachments: OFBIZ-0.patch
>
>
> Steps to regenerate:
>  # Open url 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile]
>  # Click on "Create new" in Contact Information section
>  # Select phone no as contact type
>  # Click on Create
>  # Click on Save
> Actual: Able to add phone no as contact type without adding no.
> Expected: Error message should be displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10581) While registering for new customer, In phone numbers section input type is not defined.

2019-06-24 Thread Rohit Hukkeri (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870855#comment-16870855
 ] 

Rohit Hukkeri commented on OFBIZ-10581:
---

Hello Jacques,

Indeed we can refer to numbers through letters.Thanks for useful links for the 
same and for closing the ticket.

kind regards,

Rohit Hukkeri

> While registering for new customer, In phone numbers section input type is 
> not defined. 
> 
>
> Key: OFBIZ-10581
> URL: https://issues.apache.org/jira/browse/OFBIZ-10581
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Rajat Temaniya
>Priority: Major
> Attachments: Screen Shot 2018-09-22 at 4.13.40 PM.png
>
>
> Follow the process to find this issue:
> 1) Go to this link [ 
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/newcustomer] ].
>  2) Fill the required information about user.
>  3) Go to the phone number section in the input box it must be type 
> restricted now it is taking string and number both.
>    Improvement required: Input type, Length or placeholder 
> Issue:- Right now its taking any type without verifying.
> Please find attachment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)