[jira] [Commented] (OFBIZ-7113) Refactoring permission model call
[ https://issues.apache.org/jira/browse/OFBIZ-7113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918800#comment-16918800 ] Jacques Le Roux commented on OFBIZ-7113: Actually it was not complete, but I can review once committed ;) > Refactoring permission model call > - > > Key: OFBIZ-7113 > URL: https://issues.apache.org/jira/browse/OFBIZ-7113 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-7113.patch, OFBIZ-7113.patch, OFBIZ-7113.patch > > > With the subject on mailing list "Permission service not on the same > transaction" : http://markmail.org/message/34vxi4ntmbj7vzcr > I started the improvement but the java code need to be clean and refactoring. > I share my first draft patch, but need more works. I realize : > * unified call evalPermission > * move all related field for permission service on ModelService to > ModelPermission > * Remove deprecated code > * start labelized error message > * add new attributes on permission model : required-new-transaction and > return-error-on-failure -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (OFBIZ-10966) JSON entity data import and export utility
[
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jayansh Shinde updated OFBIZ-10966:
---
Attachment: OFBiz-10966.patch
> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Reporter: Jayansh Shinde
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10966_27062019.patch, OFBiz-10966.patch,
> OFBiz-Web-Tools-JSON-Data-Export-All.png,
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
> Nowadays JSON is widely used in industry, we can have support for JSON
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
>
> {code}
> {code:java}
> {“Party”:
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>
> *Import Design*
> The import service will perform following operations:
> 1.) Validate the input JSON data (I am in process of exploring the way for
> this)
> 2.) On successful validation, convert JSON to OFBiz's entity model
> (GenericValue)
> 3.) The GenericValue will be inserted in database by some handler class for
> e.g we can write JsonDataHandler, it will convert given JSON to
> List, and finally write it to database (Similar pattern is used
> in XML import).
>
> *Export Design*
> Based on existing XML pattern the writeXmlText method of GenericEntity class
> write the exported data in XML format.
> In the similar way, we can implement writeJsonText to export data in JSON
> format.
> Please free feel to share your thought.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (OFBIZ-10966) JSON entity data import and export utility
[
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jayansh Shinde updated OFBIZ-10966:
---
Attachment: (was: OFBiz-10966.patch)
> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Reporter: Jayansh Shinde
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10966_27062019.patch, OFBiz-10966.patch,
> OFBiz-Web-Tools-JSON-Data-Export-All.png,
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
> Nowadays JSON is widely used in industry, we can have support for JSON
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
>
> {code}
> {code:java}
> {“Party”:
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>
> *Import Design*
> The import service will perform following operations:
> 1.) Validate the input JSON data (I am in process of exploring the way for
> this)
> 2.) On successful validation, convert JSON to OFBiz's entity model
> (GenericValue)
> 3.) The GenericValue will be inserted in database by some handler class for
> e.g we can write JsonDataHandler, it will convert given JSON to
> List, and finally write it to database (Similar pattern is used
> in XML import).
>
> *Export Design*
> Based on existing XML pattern the writeXmlText method of GenericEntity class
> write the exported data in XML format.
> In the similar way, we can implement writeJsonText to export data in JSON
> format.
> Please free feel to share your thought.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (OFBIZ-10966) JSON entity data import and export utility
[
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918369#comment-16918369
]
Jayansh Shinde edited comment on OFBIZ-10966 at 8/29/19 9:33 AM:
-
Hi Mathieu,
Please review patch I uploaded.
In this patch:[^OFBiz-10966.patch]
Simplified source code for easy understanding.
Added test cases as requested.
Added missing java doc.
Please let me know if you see anything missing.
Thanks,
Jay
was (Author: jayansh):
Hi Mathieu,
Please review patch I uploaded.
In this patch:
Simplified source code for easy understanding.
Added test cases as requested.
Added missing java doc.
Please let me know if you see anything missing.
Thanks,
Jay
> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Reporter: Jayansh Shinde
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10966_27062019.patch, OFBiz-10966.patch,
> OFBiz-Web-Tools-JSON-Data-Export-All.png,
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
> Nowadays JSON is widely used in industry, we can have support for JSON
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
>
> {code}
> {code:java}
> {“Party”:
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>
> *Import Design*
> The import service will perform following operations:
> 1.) Validate the input JSON data (I am in process of exploring the way for
> this)
> 2.) On successful validation, convert JSON to OFBiz's entity model
> (GenericValue)
> 3.) The GenericValue will be inserted in database by some handler class for
> e.g we can write JsonDataHandler, it will convert given JSON to
> List, and finally write it to database (Similar pattern is used
> in XML import).
>
> *Export Design*
> Based on existing XML pattern the writeXmlText method of GenericEntity class
> write the exported data in XML format.
> In the similar way, we can implement writeJsonText to export data in JSON
> format.
> Please free feel to share your thought.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (OFBIZ-10966) JSON entity data import and export utility
[
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918369#comment-16918369
]
Jayansh Shinde edited comment on OFBIZ-10966 at 8/29/19 9:32 AM:
-
Hi Mathieu,
Please review patch I uploaded.
In this
patch:https://issues.apache.org/jira/secure/attachment/12978859/OFBiz-10966.patch
Simplified source code for easy understanding.
Added test cases as requested.
Added missing java doc.
Please let me know if you see anything missing.
Thanks,
Jay
was (Author: jayansh):
Hi Mathieu,
Please review patch I uploaded.
In this patch:
Simplified source code for easy understanding.
Added test cases as requested.
Added missing java doc.
Please let me know if you see anything missing.
Thanks,
Jay
> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Reporter: Jayansh Shinde
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_27062019.patch,
> OFBiz-10966.patch, OFBiz-Web-Tools-JSON-Data-Export-All.png,
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
> Nowadays JSON is widely used in industry, we can have support for JSON
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
>
> {code}
> {code:java}
> {“Party”:
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>
> *Import Design*
> The import service will perform following operations:
> 1.) Validate the input JSON data (I am in process of exploring the way for
> this)
> 2.) On successful validation, convert JSON to OFBiz's entity model
> (GenericValue)
> 3.) The GenericValue will be inserted in database by some handler class for
> e.g we can write JsonDataHandler, it will convert given JSON to
> List, and finally write it to database (Similar pattern is used
> in XML import).
>
> *Export Design*
> Based on existing XML pattern the writeXmlText method of GenericEntity class
> write the exported data in XML format.
> In the similar way, we can implement writeJsonText to export data in JSON
> format.
> Please free feel to share your thought.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (OFBIZ-10966) JSON entity data import and export utility
[
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918369#comment-16918369
]
Jayansh Shinde edited comment on OFBIZ-10966 at 8/29/19 9:32 AM:
-
Hi Mathieu,
Please review patch I uploaded.
In this patch:
Simplified source code for easy understanding.
Added test cases as requested.
Added missing java doc.
Please let me know if you see anything missing.
Thanks,
Jay
was (Author: jayansh):
Hi Mathieu,
Please review patch I uploaded.
In this
patch:https://issues.apache.org/jira/secure/attachment/12978859/OFBiz-10966.patch
Simplified source code for easy understanding.
Added test cases as requested.
Added missing java doc.
Please let me know if you see anything missing.
Thanks,
Jay
> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Reporter: Jayansh Shinde
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_27062019.patch,
> OFBiz-10966.patch, OFBiz-Web-Tools-JSON-Data-Export-All.png,
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
> Nowadays JSON is widely used in industry, we can have support for JSON
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
>
> {code}
> {code:java}
> {“Party”:
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>
> *Import Design*
> The import service will perform following operations:
> 1.) Validate the input JSON data (I am in process of exploring the way for
> this)
> 2.) On successful validation, convert JSON to OFBiz's entity model
> (GenericValue)
> 3.) The GenericValue will be inserted in database by some handler class for
> e.g we can write JsonDataHandler, it will convert given JSON to
> List, and finally write it to database (Similar pattern is used
> in XML import).
>
> *Export Design*
> Based on existing XML pattern the writeXmlText method of GenericEntity class
> write the exported data in XML format.
> In the similar way, we can implement writeJsonText to export data in JSON
> format.
> Please free feel to share your thought.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (OFBIZ-10966) JSON entity data import and export utility
[
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918369#comment-16918369
]
Jayansh Shinde edited comment on OFBIZ-10966 at 8/29/19 7:57 AM:
-
Hi Mathieu,
Please review patch I uploaded.
In this patch:
Simplified source code for easy understanding.
Added test cases as requested.
Added missing java doc.
Please let me know if you see anything missing.
Thanks,
Jay
was (Author: jayansh):
Hi Mathieu,
Please review patch I uploaded.
In this patch:
Supplified source code for easy understanding.
Added test cases as requested.
Added missing java doc.
Please let me know if you see anything missing.
Thanks,
Jay
> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Reporter: Jayansh Shinde
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_27062019.patch,
> OFBiz-10966.patch, OFBiz-Web-Tools-JSON-Data-Export-All.png,
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
> Nowadays JSON is widely used in industry, we can have support for JSON
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
>
> {code}
> {code:java}
> {“Party”:
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>
> *Import Design*
> The import service will perform following operations:
> 1.) Validate the input JSON data (I am in process of exploring the way for
> this)
> 2.) On successful validation, convert JSON to OFBiz's entity model
> (GenericValue)
> 3.) The GenericValue will be inserted in database by some handler class for
> e.g we can write JsonDataHandler, it will convert given JSON to
> List, and finally write it to database (Similar pattern is used
> in XML import).
>
> *Export Design*
> Based on existing XML pattern the writeXmlText method of GenericEntity class
> write the exported data in XML format.
> In the similar way, we can implement writeJsonText to export data in JSON
> format.
> Please free feel to share your thought.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (OFBIZ-10966) JSON entity data import and export utility
[
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jayansh Shinde updated OFBIZ-10966:
---
Attachment: OFBiz-10966.patch
> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Reporter: Jayansh Shinde
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_27062019.patch,
> OFBiz-10966.patch, OFBiz-Web-Tools-JSON-Data-Export-All.png,
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
> Nowadays JSON is widely used in industry, we can have support for JSON
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
>
> {code}
> {code:java}
> {“Party”:
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>
> *Import Design*
> The import service will perform following operations:
> 1.) Validate the input JSON data (I am in process of exploring the way for
> this)
> 2.) On successful validation, convert JSON to OFBiz's entity model
> (GenericValue)
> 3.) The GenericValue will be inserted in database by some handler class for
> e.g we can write JsonDataHandler, it will convert given JSON to
> List, and finally write it to database (Similar pattern is used
> in XML import).
>
> *Export Design*
> Based on existing XML pattern the writeXmlText method of GenericEntity class
> write the exported data in XML format.
> In the similar way, we can implement writeJsonText to export data in JSON
> format.
> Please free feel to share your thought.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (OFBIZ-10966) JSON entity data import and export utility
[
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jayansh Shinde updated OFBIZ-10966:
---
Attachment: OFBiz-10966.patch
> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Reporter: Jayansh Shinde
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10966.patch, OFBIZ-10966_27062019.patch,
> OFBiz-10966.patch, OFBiz-Web-Tools-JSON-Data-Export-All.png,
> OFBiz-Web-Tools-JSON-Data-Import-Dir.png, exportJson.png, importJson.png
>
>
> Currently, we support import/export entity data in XML format.
> Nowadays JSON is widely used in industry, we can have support for JSON
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
>
> {code}
> {code:java}
> {“Party”:
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>
> *Import Design*
> The import service will perform following operations:
> 1.) Validate the input JSON data (I am in process of exploring the way for
> this)
> 2.) On successful validation, convert JSON to OFBiz's entity model
> (GenericValue)
> 3.) The GenericValue will be inserted in database by some handler class for
> e.g we can write JsonDataHandler, it will convert given JSON to
> List, and finally write it to database (Similar pattern is used
> in XML import).
>
> *Export Design*
> Based on existing XML pattern the writeXmlText method of GenericEntity class
> write the exported data in XML format.
> In the similar way, we can implement writeJsonText to export data in JSON
> format.
> Please free feel to share your thought.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (OFBIZ-10729) Add subscribe email on website mailing list page
[ https://issues.apache.org/jira/browse/OFBIZ-10729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918316#comment-16918316 ] Aditya Sharma commented on OFBIZ-10729: --- Thanks [~swapnilmmane] :) +1 for making it the main steps. As of Alternative steps in the midsection, I am fine with both the case either to keep or remove. if we keep it, it will be an addon and if we remove it, we have already improved the main steps so not as big concern. > Add subscribe email on website mailing list page > > > Key: OFBIZ-10729 > URL: https://issues.apache.org/jira/browse/OFBIZ-10729 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Deepak Dixit >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-10729-Alt.patch, OFBIZ-10729.patch, > OFBIZ-10729.patch, SubscribeMailingList-Mid.png, > SubscribeMailingList-Top-Alt.png, SubscribeMailingList-bottom.png, > SubscribeMailingList.png, SubscribeMailingList.png, > SubscribeMailingListAlt-1.png, SubscribeMailingListAlt-2.png > > > As per current implementation, we have a link of lists.apache.org for > subscribing mailing list, > When a user visited lists.apache.org website it has the option to subscribe, > this tries to open email client, if no email client setup on a user machine, > so its difficult to subscribe. > We can add an alternate option as well along with lists.apache.org link. A > simple text with subscribe email address. -- This message was sent by Atlassian Jira (v8.3.2#803003)
