[jira] [Closed] (OFBIZ-11296) Use 'depends-on' everywhere
[ https://issues.apache.org/jira/browse/OFBIZ-11296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin closed OFBIZ-11296. -- Resolution: Resolved Commited in eeabe69813a1d9f42911dec70a912574046ef49b > Use 'depends-on' everywhere > --- > > Key: OFBIZ-11296 > URL: https://issues.apache.org/jira/browse/OFBIZ-11296 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11296_0001-Improved-Use-depends-on-attribute-instead-of-compone.patch > > > We currently have two ways to define component loading order. Either > by using ‘depends-on’ attribute in “component-config.xml” or by adding > a “component-load.xml” file at the root of a component directory. > “depends-on” is more flexible because it handles partial ordering when > “component-load.xml” defines a total order which is not necessarily > meaningful, so it is better to rely only “depends-on”. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11296) Use 'depends-on' everywhere
[ https://issues.apache.org/jira/browse/OFBIZ-11296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11296: --- Attachment: OFBIZ-11296_0001-Improved-Use-depends-on-attribute-instead-of-compone.patch > Use 'depends-on' everywhere > --- > > Key: OFBIZ-11296 > URL: https://issues.apache.org/jira/browse/OFBIZ-11296 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11296_0001-Improved-Use-depends-on-attribute-instead-of-compone.patch > > > We currently have two ways to define component loading order. Either > by using ‘depends-on’ attribute in “component-config.xml” or by adding > a “component-load.xml” file at the root of a component directory. > “depends-on” is more flexible because it handles partial ordering when > “component-load.xml” defines a total order which is not necessarily > meaningful, so it is better to rely only “depends-on”. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11275) bug in depends-on in ofbiz-component.xml
[
https://issues.apache.org/jira/browse/OFBIZ-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11275:
---
Fix Version/s: (was: Trunk)
Upcoming Branch
> bug in depends-on in ofbiz-component.xml
>
>
> Key: OFBIZ-11275
> URL: https://issues.apache.org/jira/browse/OFBIZ-11275
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, 18.12.01
>Reporter: Samuel Trégouët
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments:
> 0001-Implemented-Show-dependency-resolution-algorithm-pro.patch,
> 0002-Implemented-Add-a-generic-directed-graph-utilitary-c.patch,
> 0003-Fixed-Remove-dependency-management-from-ComponentCon.patch,
> 0004-Fixed-graphSpec-should-be-a-LinkedHashMap-to-preserv.patch
>
>
> when using `depends-on` tag in obfiz-component.xml one should expect ofbiz to
> load component (and in particular container listed in ofbiz-component.xml) in
> particular order.
> I mean if component `accounting` has this line in its ofbiz-component.xml
> {noformat}
> {noformat}
> ofbiz should load order component first and then accounting. This is not the
> case. Only classpath is modified according to depends-on declaration (and
> this is not really a usefull/used feature but we'll see this in another issue
> ;) )
> So here are patches to fix this issue. First one is only a test (which is
> skipped to allow ./gradlew test to be ok, so if one need to be convinced one
> should comment Ignore annotation) to illustrate issue, the two others are
> actual fixes
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11296) Use 'depends-on' everywhere
Mathieu Lirzin created OFBIZ-11296: -- Summary: Use 'depends-on' everywhere Key: OFBIZ-11296 URL: https://issues.apache.org/jira/browse/OFBIZ-11296 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Mathieu Lirzin Assignee: Mathieu Lirzin Fix For: Upcoming Branch We currently have two ways to define component loading order. Either by using ‘depends-on’ attribute in “component-config.xml” or by adding a “component-load.xml” file at the root of a component directory. “depends-on” is more flexible because it handles partial ordering when “component-load.xml” defines a total order which is not necessarily meaningful, so it is better to rely only “depends-on”. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11275) bug in depends-on in ofbiz-component.xml
[
https://issues.apache.org/jira/browse/OFBIZ-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin closed OFBIZ-11275.
--
Resolution: Fixed
Applied with an extra XXX comment to describe why we need a linkedhashmap.
Thanks [~stregouet] for the fix.
> bug in depends-on in ofbiz-component.xml
>
>
> Key: OFBIZ-11275
> URL: https://issues.apache.org/jira/browse/OFBIZ-11275
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, 18.12.01
>Reporter: Samuel Trégouët
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Trunk
>
> Attachments:
> 0001-Implemented-Show-dependency-resolution-algorithm-pro.patch,
> 0002-Implemented-Add-a-generic-directed-graph-utilitary-c.patch,
> 0003-Fixed-Remove-dependency-management-from-ComponentCon.patch,
> 0004-Fixed-graphSpec-should-be-a-LinkedHashMap-to-preserv.patch
>
>
> when using `depends-on` tag in obfiz-component.xml one should expect ofbiz to
> load component (and in particular container listed in ofbiz-component.xml) in
> particular order.
> I mean if component `accounting` has this line in its ofbiz-component.xml
> {noformat}
> {noformat}
> ofbiz should load order component first and then accounting. This is not the
> case. Only classpath is modified according to depends-on declaration (and
> this is not really a usefull/used feature but we'll see this in another issue
> ;) )
> So here are patches to fix this issue. First one is only a test (which is
> skipped to allow ./gradlew test to be ok, so if one need to be convinced one
> should comment Ignore annotation) to illustrate issue, the two others are
> actual fixes
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.
[
https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981552#comment-16981552
]
Samuel Trégouët commented on OFBIZ-6993:
I run against this issue all the morning, any chance to get rid of it ?
> Cannot find the declaration of element 'web-app' in version 3.0 files.
> --
>
> Key: OFBIZ-6993
> URL: https://issues.apache.org/jira/browse/OFBIZ-6993
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk, Release Branch 15.12
> Environment: Been seeing the error below in the logs. Strangely,
> I've not been able to catch the exception in a debugger, but was able to
> isolate it to the definition of the web-app with version 3.0. The error
> disapears when you change the definition from
> {code:xml}
>
> {code}
> to this:
> {code:xml}
> xmlns="http://java.sun.com/xml/ns/javaee;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd;>
> {code}
> I only tested on 15.12 and Trunk, but it probably affects any release running
> Tomcat 7.0.48 or higher. Here is the error:
> {noformat}
> [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester
> error
> [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot
> find the declaration of element 'web-app'.
> [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24;
> cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
> [java] at
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown
> Source)
> [java] at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown
> Source)
> [java] at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> Source)
> [java] at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> Source)
> [java] at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> Source)
> [java] at
> org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown
> Source)
> [java] at
> org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
> [java] at
> org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
> Source)
> [java] at
> org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
> Source)
> [java] at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
> Source)
> [java] at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
> Source)
> [java] at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
> Source)
> [java] at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
> Source)
> [java] at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
> [java] at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown
> Source)
> [java] at
> org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
> [java] at
> org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
> [java] at
> org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
> [java] at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
> [java] at
> org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
> [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [java] at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [java] at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [java] at java.lang.reflect.Method.invoke(Method.java:498)
> [java] at
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
> [java] at
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
> [java] at freemarker.core.MethodCall._eval(MethodCall.java:62)
> [java] at freemarker.core.Expression.eval(Expression.java:78)
> [java] at freemarker.core.Assignment.accept(Assignment.java:70)
> [java] at freemarker.core.Environment.visit(Environment.java:312)
> [java] at freemarker.core.MixedContent.accept(MixedContent.java:62)
> [java] at
> freemarker.core.Environment.visitByHiddingParent(Environment.java:333)
> [java] at
> freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.java:148)
> [java] at
> freemarker.core.Environment.visitIteratorBlock(Environment.java:559)
> [java] at freemarker.core.IteratorBlock.accept(IteratorBlock.java:67)
> [java]
[jira] [Commented] (OFBIZ-11275) bug in depends-on in ofbiz-component.xml
[
https://issues.apache.org/jira/browse/OFBIZ-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981520#comment-16981520
]
Samuel Trégouët commented on OFBIZ-11275:
-
just added a new patch
(0004-Fixed-graphSpec-should-be-a-LinkedHashMap-to-preserv.patch) to fix
previous error
> bug in depends-on in ofbiz-component.xml
>
>
> Key: OFBIZ-11275
> URL: https://issues.apache.org/jira/browse/OFBIZ-11275
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, 18.12.01
>Reporter: Samuel Trégouët
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Trunk
>
> Attachments:
> 0001-Implemented-Show-dependency-resolution-algorithm-pro.patch,
> 0002-Implemented-Add-a-generic-directed-graph-utilitary-c.patch,
> 0003-Fixed-Remove-dependency-management-from-ComponentCon.patch,
> 0004-Fixed-graphSpec-should-be-a-LinkedHashMap-to-preserv.patch
>
>
> when using `depends-on` tag in obfiz-component.xml one should expect ofbiz to
> load component (and in particular container listed in ofbiz-component.xml) in
> particular order.
> I mean if component `accounting` has this line in its ofbiz-component.xml
> {noformat}
> {noformat}
> ofbiz should load order component first and then accounting. This is not the
> case. Only classpath is modified according to depends-on declaration (and
> this is not really a usefull/used feature but we'll see this in another issue
> ;) )
> So here are patches to fix this issue. First one is only a test (which is
> skipped to allow ./gradlew test to be ok, so if one need to be convinced one
> should comment Ignore annotation) to illustrate issue, the two others are
> actual fixes
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11275) bug in depends-on in ofbiz-component.xml
[
https://issues.apache.org/jira/browse/OFBIZ-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samuel Trégouët updated OFBIZ-11275:
Attachment: 0004-Fixed-graphSpec-should-be-a-LinkedHashMap-to-preserv.patch
> bug in depends-on in ofbiz-component.xml
>
>
> Key: OFBIZ-11275
> URL: https://issues.apache.org/jira/browse/OFBIZ-11275
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, 18.12.01
>Reporter: Samuel Trégouët
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Trunk
>
> Attachments:
> 0001-Implemented-Show-dependency-resolution-algorithm-pro.patch,
> 0002-Implemented-Add-a-generic-directed-graph-utilitary-c.patch,
> 0003-Fixed-Remove-dependency-management-from-ComponentCon.patch,
> 0004-Fixed-graphSpec-should-be-a-LinkedHashMap-to-preserv.patch
>
>
> when using `depends-on` tag in obfiz-component.xml one should expect ofbiz to
> load component (and in particular container listed in ofbiz-component.xml) in
> particular order.
> I mean if component `accounting` has this line in its ofbiz-component.xml
> {noformat}
> {noformat}
> ofbiz should load order component first and then accounting. This is not the
> case. Only classpath is modified according to depends-on declaration (and
> this is not really a usefull/used feature but we'll see this in another issue
> ;) )
> So here are patches to fix this issue. First one is only a test (which is
> skipped to allow ./gradlew test to be ok, so if one need to be convinced one
> should comment Ignore annotation) to illustrate issue, the two others are
> actual fixes
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11283) Number problem cancelling order item
[ https://issues.apache.org/jira/browse/OFBIZ-11283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981509#comment-16981509 ] Ankush Upadhyay commented on OFBIZ-11283: - Thanks [~jleroux] > Number problem cancelling order item > > > Key: OFBIZ-11283 > URL: https://issues.apache.org/jira/browse/OFBIZ-11283 > Project: OFBiz > Issue Type: Bug >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-11283.patch > > > If an order item has a quantity greater then 1000, cancelling the order item > via the order form in backend does not work. > In the Demo (trunk) environment: the quantity of 1200 to cancel is displayed > as "1,200" in the quantity input field. > --> an error is displayed > On my local installation I use a different locale and it is displayed as > "1.200". > --> interprets the dot as a comma and the quantity of 1,2 is cancelled > To reproduce: go to ofbiz Demo > Create Order: Order Mgt --> Order Entry --> Sales Order (Customer: > DemoCustomer) --> ProductId: GZ-2644, Quantity 1200 --> Finalize order > > On order: Edit Items --> click checkbox next to quantity -->cancel selected > items > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11283) Number problem cancelling order item
[ https://issues.apache.org/jira/browse/OFBIZ-11283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11283. --- Fix Version/s: 18.12.01 17.12.01 Resolution: Fixed Thank you guys, Ankush, your slightly enhanced patch is in trunk 3d555f5765e75fc600432dd3f1878c293c669fae R18 7bef57652d441cedf3c68e3cb8811aa0e273e53a R17 9e8db09466e04f9da9ab22c258e7e0d1c6c6fffb I have applied the same in ReceiveInventory.ftl > Number problem cancelling order item > > > Key: OFBIZ-11283 > URL: https://issues.apache.org/jira/browse/OFBIZ-11283 > Project: OFBiz > Issue Type: Bug >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-11283.patch > > > If an order item has a quantity greater then 1000, cancelling the order item > via the order form in backend does not work. > In the Demo (trunk) environment: the quantity of 1200 to cancel is displayed > as "1,200" in the quantity input field. > --> an error is displayed > On my local installation I use a different locale and it is displayed as > "1.200". > --> interprets the dot as a comma and the quantity of 1,2 is cancelled > To reproduce: go to ofbiz Demo > Create Order: Order Mgt --> Order Entry --> Sales Order (Customer: > DemoCustomer) --> ProductId: GZ-2644, Quantity 1200 --> Finalize order > > On order: Edit Items --> click checkbox next to quantity -->cancel selected > items > -- This message was sent by Atlassian Jira (v8.3.4#803005)
