[jira] [Commented] (OFBIZ-11312) DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks
[ https://issues.apache.org/jira/browse/OFBIZ-11312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045219#comment-17045219 ] ASF subversion and git services commented on OFBIZ-11312: - Commit 4697bf5faa7672152e9d59f49456ebb03a950645 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4697bf5 ] Fixed: DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks (OFBIZ-11312) The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using a List> object. This does not work properly as it runs into connection-locks. When debugging the error does not occur. I assume that the slower pace of debugging prevents the error. Thanks: Benjamin Jugl > DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to > connection-locks > -- > > Key: OFBIZ-11312 > URL: https://issues.apache.org/jira/browse/OFBIZ-11312 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11312_getColumnInfo_connection_locks_001.patch > > > The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using > a List> object. This does not work properly > as it runs into connection-locks. When debugging the error does not occur. I > assume that the slower pace of debugging prevents the error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11312) DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks
[ https://issues.apache.org/jira/browse/OFBIZ-11312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045218#comment-17045218 ] ASF subversion and git services commented on OFBIZ-11312: - Commit d2128ffeaa4a9f5e242ad236a34bb34e3a591941 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d2128ff ] Fixed: DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks (OFBIZ-11312) The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using a List> object. This does not work properly as it runs into connection-locks. When debugging the error does not occur. I assume that the slower pace of debugging prevents the error. Thanks: Benjamin Jugl # Conflicts: # framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java > DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to > connection-locks > -- > > Key: OFBIZ-11312 > URL: https://issues.apache.org/jira/browse/OFBIZ-11312 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11312_getColumnInfo_connection_locks_001.patch > > > The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using > a List> object. This does not work properly > as it runs into connection-locks. When debugging the error does not occur. I > assume that the slower pace of debugging prevents the error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11312) DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks
[ https://issues.apache.org/jira/browse/OFBIZ-11312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045217#comment-17045217 ] ASF subversion and git services commented on OFBIZ-11312: - Commit 87c0907f88a3a30487112c9392820f193dce285b in ofbiz-framework's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=87c0907 ] Fixed: DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks (OFBIZ-11312) The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using a List> object. This does not work properly as it runs into connection-locks. When debugging the error does not occur. I assume that the slower pace of debugging prevents the error. jleroux: backport conflict handled by hand Thanks: Benjamin Jugl > DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to > connection-locks > -- > > Key: OFBIZ-11312 > URL: https://issues.apache.org/jira/browse/OFBIZ-11312 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11312_getColumnInfo_connection_locks_001.patch > > > The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using > a List> object. This does not work properly > as it runs into connection-locks. When debugging the error does not occur. I > assume that the slower pace of debugging prevents the error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11417) "Check/Update Database" does not work
[
https://issues.apache.org/jira/browse/OFBIZ-11417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11417.
---
Assignee: Jacques Le Roux
Resolution: Duplicate
> "Check/Update Database" does not work
> --
>
> Key: OFBIZ-11417
> URL: https://issues.apache.org/jira/browse/OFBIZ-11417
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk
> Environment: Trunk demo and local
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> The error in log is confuse:
> {noformat}
> 2020-02-25 13:11:00,082 |7.0.0.1-8009-exec-10 |ControlServlet
> |T| [[[webtools::view (Domain:https://demo-trunk.ofbiz.apache.org)] Request
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-02-25 13:11:00,084 |7.0.0.1-8009-exec-10 |RequestHandler
> |I| Rendering View [checkdb]. Hidden sessionId by default.
> 2020-02-25 13:11:00,085 |7.0.0.1-8009-exec-10 |ServiceDispatcher
> |T| Sync service [webtools/getUserPreferenceGroup] finished in [1]
> milliseconds
> 2020-02-25 13:11:00,090 |7.0.0.1-8009-exec-10 |ScreenFactory
> |I| Got 20 screens in 0.005s from:
> file:/home/ofbizDemo/trunk/framework/webtools/widget/EntityScreens.xml
> 2020-02-25 13:11:00,239 |7.0.0.1-8009-exec-10 |ScreenFactory
> |I| Got 26 screens in 0.004s from:
> file:/home/ofbizDemo/trunk/framework/common/widget/CommonScreens.xml
> 2020-02-25 13:11:00,363 |7.0.0.1-8009-exec-10 |ScreenFactory
> |I| Got 25 screens in 0.005s from:
> file:/home/ofbizDemo/trunk/themes/common-theme/widget/CommonScreens.xml
> 2020-02-25 13:11:00,372 |7.0.0.1-8009-exec-10 |ModelService
> |I| Set default value [SECURITY] for parameter [primaryPermission]
> 2020-02-25 13:11:00,372 |7.0.0.1-8009-exec-10 |Log
> |I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This
> simple-method-call is deprecated! Please use a service-call of
> genericBasePermissionCheck instead.
> 2020-02-25 13:11:00,438 |7.0.0.1-8009-exec-10 |ServiceDispatcher
> |T| Sync service [webtools/genericBasePermissionCheck] finished in [65]
> milliseconds
> 2020-02-25 13:11:00,438 |7.0.0.1-8009-exec-10 |ServiceDispatcher
> |T| Sync service [webtools/securityPermissionCheck] finished in [67]
> milliseconds
> 2020-02-25 13:11:00,452 |7.0.0.1-8009-exec-10 |ServerHitBin
> |I| Visit delegatorName=default, ServerHitBin delegatorName=default
> 2020-02-25 13:11:00,453 |7.0.0.1-8009-exec-10 |ControlServlet
> |T| [[[webtools::view (Domain:https://demo-trunk.ofbiz.apache.org)] Request
> Done- total:0.371,since last([webtools::view (...):0.371]]
> 2020-02-25 13:11:02,708 |27.0.0.1-8009-exec-1 |ControlServlet
> |T| [[[webtools::view (Domain:https://demo-trunk.ofbiz.apache.org)] Request
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-02-25 13:11:02,709 |27.0.0.1-8009-exec-1 |RequestHandler
> |W| You should check if this request is really a problem or a false alarm:
> https://demo-trunk.ofbiz.apache.org/webtools/control/view/images/masthead.gif
> 2020-02-25 13:11:02,709 |27.0.0.1-8009-exec-1 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [view]; this request does not exist or cannot be called directly.
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:252)
> ~[main/:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:232)
> [main/:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:96)
> [main/:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:634)
> [tomcat-servlet-api-9.0.31.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
> [tomcat-servlet-api-9.0.31.jar:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-9.0.31.jar:9.0.31]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.31.jar:9.0.31]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
> [tomcat-embed-websocket-9.0.27.jar:9.0.27]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.31.jar:9.0.31]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.31.jar:9.0.31]
> at
>
[jira] [Assigned] (OFBIZ-11312) DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks
[ https://issues.apache.org/jira/browse/OFBIZ-11312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11312: --- Assignee: Jacques Le Roux (was: Benjamin Jugl) > DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to > connection-locks > -- > > Key: OFBIZ-11312 > URL: https://issues.apache.org/jira/browse/OFBIZ-11312 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11312_getColumnInfo_connection_locks_001.patch > > > The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using > a List> object. This does not work properly > as it runs into connection-locks. When debugging the error does not occur. I > assume that the slower pace of debugging prevents the error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11244) Remove the user login security question
[ https://issues.apache.org/jira/browse/OFBIZ-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-11244: -- Affects Version/s: (was: Release Branch 18.12) (was: Release Branch 17.12) (was: Release Branch 16.11) > Remove the user login security question > --- > > Key: OFBIZ-11244 > URL: https://issues.apache.org/jira/browse/OFBIZ-11244 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, framework, party >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-11244-framework.patch, OFBIZ-11244-plugins.patch > > > After our discussion in dev ML at > https://markmail.org/message/2dhc4al4adwgvl7z we will remove this feature. > This [~paulfoxworthy]'s remark is notably important: > bq. Security is only as good as its weakest link ( > https://www.schneier.com/essays/archives/2005/02/the_curse_of_the_sec.html) , > and security questions can be a real weakness. Any organisation using OFBiz > that really hates passwords could look at security keys from Yubico or the > like. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11306) POC for CSRF Token
[
https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045150#comment-17045150
]
Jacques Le Roux commented on OFBIZ-11306:
-
Hi James,
Easy stuff, it was just a matter of replacing in header.ftl files:
{code}
{code}
by
{code}
<#assign csrfDefenseStrategy =
Static["org.apache.ofbiz.entity.util.EntityUtilProperties"].getPropertyValue("security",
"csrf.defense.strategy", delegator)>
<#if csrfDefenseStrategy !=
"org.apache.ofbiz.security.NoCsrfDefenseStrategy">
{code}
I'll proceed with the fork and let you know when to clone
> POC for CSRF Token
> --
>
> Key: OFBIZ-11306
> URL: https://issues.apache.org/jira/browse/OFBIZ-11306
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Labels: CSRF
> Fix For: Upcoming Branch
>
> Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java,
> CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch,
> OFBIZ-11306-alternative merged with James's.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-v2.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch,
> OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch,
> OFBIZ-11306_Plugins.patch, partyTokenMap.webtools.txt
>
>
> CRSF tokens are generated using SecureRandom class (maybe later a JWT with a
> "time out").
> They are stored in the user sessions (for AJAX calls and unauthenticated HTTP
> calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during
> POST request.
> # In *controllers* a new csrf-token attribute is added to the security tag to
> exempt or force CSRF token check.
> # In *Widget Forms* a hidden token field is auto-generated.
> # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the
> change. Using <@ofbizUrl> macro to generate the CSRF token means there is no
> need to manually add the CSRF token field to each form in the ftl files. It
> will save time for users doing custom implementation and maintenance. While
> there is CSRF token in the form URL, the token is invalidated during form
> submission. So it's uniqueand harmless even though the CSRF token of the form
> submission is shown in the browser address bar.
> # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added
> through OfbizUtil.js (itself called at start in decorators and such)
> # The html metadata is storing the csrf token used by JQuery AJAX. This token
> will not change to another value after it is consumed
> # Csrf tokens for the user are removed from the UtilCache when the user logs
> out or session invalidated.
> The general rule are as follows:
> * RequestMap configured with 'get' method will be exempted from CSRF token
> check.
> * RequestMap configured with 'post' or 'all' method will be subjected to CSRF
> token check. (Note there are discussions that RequestMap with ‘all’ method
> should also not be subjected to CSRF token check. This will be done after
> ensuring a separate uri is used when posting changes.)
> * "main" request URIs are exempted from CSRF token check.
> * Setting csrf-token to false or true on the Request Map will override the
> general rules above.
> To Discuss:
> * Invalidate authenticated user session when CSRF token check fails.
> * Configure the general rules in a Service method (which will be run inside
> the constructor of RequestMap class) when determining the final
> securityCsrfToken value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11396) replaceFirst sensible to variable pattern
[
https://issues.apache.org/jira/browse/OFBIZ-11396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-11396:
--
Fix Version/s: (was: 17.12.02)
17.12.01
> replaceFirst sensible to variable pattern
> -
>
> Key: OFBIZ-11396
> URL: https://issues.apache.org/jira/browse/OFBIZ-11396
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools, solr
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.01
>
>
> When using variable pattern with replaceFirst you may cross issues if the
> pattern contains specific tokens. For instance on Windows with the path
> "C:\projectsASF\Git\ofbiz-framework/" you have inside the token "\p" [which
> has a special meaning|https://www.regular-expressions.info/unicode.html].
> I stumbled upon this issue on Windows while using webtools/control/entityref:
> {noformat}
> Caused by: java.util.regex.PatternSyntaxException: Unknown character property
> name {r} near index 4
> C:\projectsASF\Git\ofbiz-framework/
> ^
> at java.util.regex.Pattern.error(Pattern.java:1957) ~[?:1.8.0_202]
> at java.util.regex.Pattern.charPropertyNodeFor(Pattern.java:2783)
> ~[?:1.8.0_202]
> at java.util.regex.Pattern.family(Pattern.java:2738) ~[?:1.8.0_202]
> at java.util.regex.Pattern.sequence(Pattern.java:2078) ~[?:1.8.0_202]
> at java.util.regex.Pattern.expr(Pattern.java:1998) ~[?:1.8.0_202]
> at java.util.regex.Pattern.compile(Pattern.java:1698) ~[?:1.8.0_202]
> at java.util.regex.Pattern.(Pattern.java:1351) ~[?:1.8.0_202]
> at java.util.regex.Pattern.compile(Pattern.java:1028) ~[?:1.8.0_202]
> at java.lang.String.replaceFirst(String.java:2178) ~[?:1.8.0_202]
> at
> org.apache.ofbiz.webtools.WebToolsServices.getEntityRefData(WebToolsServices.java:770)
> ~[main/:?]
> {noformat}
> The simplest solution is to replace replaceFirst by StringUtils.replaceOnce.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11410) Agreement Item can't be removed.
[
https://issues.apache.org/jira/browse/OFBIZ-11410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-11410:
--
Fix Version/s: (was: 17.12.02)
17.12.01
> Agreement Item can't be removed.
>
>
> Key: OFBIZ-11410
> URL: https://issues.apache.org/jira/browse/OFBIZ-11410
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: 16.11.07, Release Branch 18.12, 17.12.01, Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Labels: agreement(s)
> Fix For: 18.12.01, 17.12.01
>
>
> When trying to remove an agreement item following error is returned:
> {code:java}
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException:
> Service invocation error (The following required parameter is missing: [OUT]
> [removeAgreementItem.agreementId]The following required parameter is missing:
> [OUT] [removeAgreementItem.agreementItemSeqId])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11346) Provide a FileItem entry in UtilHttp.getMultiPartParameterMap
[ https://issues.apache.org/jira/browse/OFBIZ-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-11346: -- Fix Version/s: (was: 17.12.02) 17.12.01 > Provide a FileItem entry in UtilHttp.getMultiPartParameterMap > - > > Key: OFBIZ-11346 > URL: https://issues.apache.org/jira/browse/OFBIZ-11346 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: 18.12.01, 17.12.01 > > Attachments: OFBIZ-11346.patch > > > In OFBIZ-5048 I proposed to change the file item entry from ByteBuffer to > FileItem for easier access to the file temporarily stored on the server. This > broke existing functionality and was reverted by me today. > I now propose to add a FileItem entry to the multipart map to allow direct > acces to the file item and remain compatible with the services using this > functionality. > A patch will follow. > I also propose to backport this to the 17.12/18.12 branches to provide the > functionality which was reverted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-9658) Issue while redirecting to Request Detail Screen from View Communication Event
[ https://issues.apache.org/jira/browse/OFBIZ-9658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-9658: - Fix Version/s: (was: 17.12.02) 17.12.01 > Issue while redirecting to Request Detail Screen from View Communication Event > -- > > Key: OFBIZ-9658 > URL: https://issues.apache.org/jira/browse/OFBIZ-9658 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Ankit Joshi >Assignee: Akash Jain >Priority: Major > Fix For: 18.12.01, 17.12.01 > > Attachments: OFBIZ-9658.patch > > > Steps to regenerate - > 1) Go to Party menu and select Communication tab. > 2) Search Communication Event with eventId = DEMO-COM-BACKLOG-1 > 3) Try to redirect to Customer Request Detail screen available in Customer > Request List segment. > Error: It is giving Request does not exist error while redirecting to the > Request detail page. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10837) Improve ObjectInputStream class (CVE-2019-0189)
[
https://issues.apache.org/jira/browse/OFBIZ-10837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-10837:
--
Fix Version/s: (was: 17.12.02)
17.12.01
> Improve ObjectInputStream class (CVE-2019-0189)
> ---
>
> Key: OFBIZ-10837
> URL: https://issues.apache.org/jira/browse/OFBIZ-10837
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release
> Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 16.11.06, 18.12.01, 17.12.01
>
>
> As reported by FindBugs and Sonar, it's troubling (a Bad practice in
> Sonar[1], a code smell in Findbugs[2]) when extending to use the same name
> than the extended Object.[3]
> [1]
> [https://sbforge.org/sonar/rules/show/findbugs:NM_SAME_SIMPLE_NAME_AS_SUPERCLASS?layout=false]
> [2] [https://logging.apache.org/log4j/log4j-2.2/log4j-jul/findbugs.html]
> [3] Bug: The class name org.apache.ofbiz.base.util.ObjectInputStream shadows
> the simple name of the superclass java.io.ObjectInputStream
> This class has a simple name that is identical to that of its superclass,
> except that its superclass is in a different package (e.g., alpha.Foo extends
> beta.Foo). This can be exceptionally confusing, create lots of situations in
> which you have to look at import statements to resolve references and creates
> many opportunities to accidentally define methods that do not override
> methods in their superclasses.
> Rank: Troubling (14), confidence: High
> Pattern: NM_SAME_SIMPLE_NAME_AS_SUPERCLASS
> Type: Nm, Category: BAD_PRACTICE (Bad practice)
> {color:#de350b}2019/09/12: Initiallty this description was intentionnaly done
> to somehow hide a security issue (CVE-2019-0189) while allowing to fix the
> bug.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-10753) Improve error message page to support Theming
[
https://issues.apache.org/jira/browse/OFBIZ-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-10753:
--
Fix Version/s: (was: 17.12.02)
17.12.01
> Improve error message page to support Theming
> -
>
> Key: OFBIZ-10753
> URL: https://issues.apache.org/jira/browse/OFBIZ-10753
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Fix For: 18.12.01, 17.12.01
>
> Attachments: OFBIZ-10753.patch, Sélection_224.png
>
>
> Currently when OFBiz raise an error, we use a jsp page to display it.
> On common-controler.xml :
> {code:java}
> /error/error.jsp{code}
> This method isn't support by the theming. I propose two improvements :
> * use FlexibleLocation to resolve the error page :
> {code:java}
> component://common/webcommon/error/error.ftl{code}
> * improve theme to support the error message page
> {code:java}
>encoder="html" compress="false">
>location="component://common-theme/template/macro/HtmlScreenMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlFormMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlTreeMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl"/>
> + location="component://common-theme/template/ErrorPage.ftl"/>
> {code}
> By the way you can define your error page by the theme in first step and we
> would use the rendering type in future to display the error no only in html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-7610) Product Price set based on 'Purchase Price Agreement' isn't honoured while same is used during ordering
[ https://issues.apache.org/jira/browse/OFBIZ-7610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-7610: - Fix Version/s: (was: 17.12.02) 17.12.01 > Product Price set based on 'Purchase Price Agreement' isn't honoured while > same is used during ordering > --- > > Key: OFBIZ-7610 > URL: https://issues.apache.org/jira/browse/OFBIZ-7610 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Swapnil Shah >Assignee: Suraj Khurana >Priority: Major > Fix For: 18.12.01, 17.12.01 > > Attachments: OFBIZ-7610.patch, SA_1.png, SA_2.png, SA_3.png, > SA_4.png, SA_5.png > > > Once any Purchase Agreement is created with supplier for certain products at > pre-determined price, its get successfully transformed into SupplierProduct. > But at the time of Purchase order creation is same agreement is enforced then > agreement prices for products are ignored while setting the price on cart and > eventually on order itself. > Please refer to attached screenshot for reference. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11419) hr-glossary.adoc: line 22: id assigned to block already in use: ANNUAL_REVENUE
Michael Brohl created OFBIZ-11419:
-
Summary: hr-glossary.adoc: line 22: id assigned to block already
in use: ANNUAL_REVENUE
Key: OFBIZ-11419
URL: https://issues.apache.org/jira/browse/OFBIZ-11419
Project: OFBiz
Issue Type: Bug
Components: humanres
Affects Versions: Trunk
Reporter: Michael Brohl
Assignee: Olivier Heintz
Hi [~holivier] ,
after merging all documentation into trunk and fixing a bug, the following
warnings occur:
{code:java}
> Task :generateOfbizDocumentation
Feb 25, 2020 10:42:35 PM
uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb next_section
WARNUNG:
../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc: line
22: id assigned to block already in use: ANNUAL_REVENUE
id assigned to block already in use: ANNUAL_REVENUE ::
../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc ::
/Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include//Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc:22
(uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:next_section)
Feb 25, 2020 10:42:39 PM
uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/document.rb parse
WARNUNG:
../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc: line
22: id assigned to block already in use: ANNUAL_REVENUE
id assigned to block already in use: ANNUAL_REVENUE ::
../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc ::
/Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include//Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc:22
(uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/document.rb:parse)
{code}
I guess it is because ANNUAL_REVENUE is used in both acc-glossary.adoc and
hr-glossary.adoc.
Can you please check? Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11384) Content overview documentation migration to asciidoc format
[ https://issues.apache.org/jira/browse/OFBIZ-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-11384. - Fix Version/s: Upcoming Branch Assignee: Michael Brohl Resolution: Implemented Thanks and Kudos for your documentation work, [~holivier] ! > Content overview documentation migration to asciidoc format > --- > > Key: OFBIZ-11384 > URL: https://issues.apache.org/jira/browse/OFBIZ-11384 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Michael Brohl >Priority: Minor > Labels: documentation > Fix For: Upcoming Branch > > Time Spent: 20m > Remaining Estimate: 0h > > Migration from docbook format to asciidoc format and add a include in > user-manual to the content file -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11072) Have a service to load records in the customer dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11072: - Summary: Have a service to load records in the customer dimension (was: Have a seca to load records in the customer dimension) > Have a service to load records in the customer dimension > > > Key: OFBIZ-11072 > URL: https://issues.apache.org/jira/browse/OFBIZ-11072 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Release Branch 18.12, Release Branch 17.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CustomerDimension, birt, customer, dimension, dwh, > initialisation, service > Attachments: OFBIZ-11072-CustomerDimService.diff > > > for dwh initialisation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11384) Content overview documentation migration to asciidoc format
[ https://issues.apache.org/jira/browse/OFBIZ-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044910#comment-17044910 ] ASF subversion and git services commented on OFBIZ-11384: - Commit a88129294d9f196c59eb3892ea7fe134a239439a in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a881292 ] Documented: Content overview doc file migration in asciidoc format (OFBIZ-11384) the new file content.adoc is call (via include) from user-manual.adoc content_IT is migrated too even if there is only 2 lines in it ! > Content overview documentation migration to asciidoc format > --- > > Key: OFBIZ-11384 > URL: https://issues.apache.org/jira/browse/OFBIZ-11384 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 20m > Remaining Estimate: 0h > > Migration from docbook format to asciidoc format and add a include in > user-manual to the content file -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10946) Have a seca to load records in the CustomerDimension
[ https://issues.apache.org/jira/browse/OFBIZ-10946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10946: - Summary: Have a seca to load records in the CustomerDimension (was: Have a service to load records in the CustomerDimension) > Have a seca to load records in the CustomerDimension > > > Key: OFBIZ-10946 > URL: https://issues.apache.org/jira/browse/OFBIZ-10946 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CustomerDimension, birt, customer, dimension, dwh > > Depending on OFBIZ-10944. > The service must be invoked when a party gets the 'Customer' role. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11072) Have a seca to load records in the customer dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11072: - Summary: Have a seca to load records in the customer dimension (was: Have a sea to load records in the customer dimension) > Have a seca to load records in the customer dimension > - > > Key: OFBIZ-11072 > URL: https://issues.apache.org/jira/browse/OFBIZ-11072 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Release Branch 18.12, Release Branch 17.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CustomerDimension, birt, customer, dimension, dwh, > initialisation, service > Attachments: OFBIZ-11072-CustomerDimService.diff > > > for dwh initialisation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11072) Have a service to load records in the customer dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reopened OFBIZ-11072: -- Reopening. As this is not a duplicate of OFBIZ-10946. Will adjust subject and description. > Have a service to load records in the customer dimension > > > Key: OFBIZ-11072 > URL: https://issues.apache.org/jira/browse/OFBIZ-11072 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Release Branch 18.12, Release Branch 17.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CustomerDimension, birt, customer, dimension, dwh, > initialisation, service > Attachments: OFBIZ-11072-CustomerDimService.diff > > > for dwh initialisation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11072) Have a sea to load records in the customer dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11072: - Summary: Have a sea to load records in the customer dimension (was: Have a service to load records in the customer dimension) > Have a sea to load records in the customer dimension > > > Key: OFBIZ-11072 > URL: https://issues.apache.org/jira/browse/OFBIZ-11072 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Release Branch 18.12, Release Branch 17.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CustomerDimension, birt, customer, dimension, dwh, > initialisation, service > Attachments: OFBIZ-11072-CustomerDimService.diff > > > for dwh initialisation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10946) Have a service to load records in the CustomerDimension
[ https://issues.apache.org/jira/browse/OFBIZ-10946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10946: - Attachment: (was: OFBIZ-10946-BI.patch) > Have a service to load records in the CustomerDimension > --- > > Key: OFBIZ-10946 > URL: https://issues.apache.org/jira/browse/OFBIZ-10946 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CustomerDimension, birt, customer, dimension, dwh > > Depending on OFBIZ-10944. > The service must be invoked when a party gets the 'Customer' role. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10296) Add Document Content: acc-financial-accounts.adoc
[
https://issues.apache.org/jira/browse/OFBIZ-10296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-10296.
-
Fix Version/s: (was: 18.12.01)
Upcoming Branch
Assignee: Michael Brohl
Resolution: Implemented
{code:java}
commit 0340b17575e81a98d2d13156ca64db4a0f6cae89
Author: holivier
AuthorDate: Mon Feb 3 19:46:18 2020 +0100
Documented: Financial Account Help Docbook file migration to asciidoc
format
(OFBIZ-10296)
All the new files are now included in the Financial Account
documentation presentation, at the end in a sub-chapter Financial
Account management in User Interface.
{code}
> Add Document Content: acc-financial-accounts.adoc
> -
>
> Key: OFBIZ-10296
> URL: https://issues.apache.org/jira/browse/OFBIZ-10296
> Project: OFBiz
> Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> FinAccount-Help-Docbook-file-migration-to-asciidoc_diff.patch,
> OFBIZ-10296.patch
>
>
> Add content for acc-financial-accounts.adoc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
[
https://issues.apache.org/jira/browse/OFBIZ-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-10290.
-
Fix Version/s: (was: 18.12.01)
Upcoming Branch
Assignee: Michael Brohl
Resolution: Implemented
{code:java}
commit a40a23583b2f835e4b9947f6670fc71813f4bd0c
Author: holivier
AuthorDate: Wed Jan 29 19:16:07 2020 +0100
Documented: Agreement Help Docbook file migration to asciidoc format
(OFBIZ-10290)
All the new files are now included in the Agreement documentation
presentation, at the end in a sub-chapter Agreement management in User
Interface.
{code}
> Add Document Content: acc-agreements.adoc
> -
>
> Key: OFBIZ-10290
> URL: https://issues.apache.org/jira/browse/OFBIZ-10290
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
>Reporter: Sharan Foga
>Assignee: Michael Brohl
>Priority: Minor
> Labels: accounting, asciidoc, documentation
> Fix For: Upcoming Branch
>
> Attachments:
> 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo.patch,
> 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo_diff.patch
>
>
> Add content for acc-agreements.doc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-10295) Add Document Content: acc-payment-gateway.adoc
[
https://issues.apache.org/jira/browse/OFBIZ-10295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-10295.
-
Fix Version/s: Upcoming Branch
Assignee: Michael Brohl
Resolution: Implemented
{code:java}
commit 63d1df79b8fb529c65d44c7ccac56632f2442287
Author: holivier
AuthorDate: Wed Feb 12 17:51:56 2020 +0100
Documented: Payment-gateway Docbook files migration to asciidoc format
(OFBIZ-10294)
All the help files associated to it are called via include in the main
document.
Merge (and call included) all helps about payment-gatway-config and
payment-gateway-transaction in this file{code}
> Add Document Content: acc-payment-gateway.adoc
> --
>
> Key: OFBIZ-10295
> URL: https://issues.apache.org/jira/browse/OFBIZ-10295
> Project: OFBiz
> Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> Payment-gateway-Help-Docbook-file-migration-to-asciidoc_diff.patch
>
>
> Add content acc-payment-gateway.adoc
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-10293) Add Document Content: acc-billing-accounts.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10293. - Fix Version/s: Upcoming Branch Assignee: Michael Brohl Resolution: Implemented Thanks [~holivier] ! > Add Document Content: acc-billing-accounts.adoc > --- > > Key: OFBIZ-10293 > URL: https://issues.apache.org/jira/browse/OFBIZ-10293 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > billing-account-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content acc-billing-accounts.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10291) Add Document Content: acc-tax-authorities.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10291. - Fix Version/s: Upcoming Branch Assignee: Michael Brohl Resolution: Implemented Thanks [~holivier] ! > Add Document Content: acc-tax-authorities.adoc > -- > > Key: OFBIZ-10291 > URL: https://issues.apache.org/jira/browse/OFBIZ-10291 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Labels: documentation > Fix For: Upcoming Branch > > Attachments: > tax-authorities-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content for acc-tax-authorities.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10288) Move Accounting Guide into OFBiz Asciidoc Framework
[ https://issues.apache.org/jira/browse/OFBIZ-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10288. - Resolution: Implemented Thanks [~holivier] ! > Move Accounting Guide into OFBiz Asciidoc Framework > --- > > Key: OFBIZ-10288 > URL: https://issues.apache.org/jira/browse/OFBIZ-10288 > Project: OFBiz > Issue Type: Task > Components: accounting >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > Attachments: > OFBIZ-10288-Help-Docbook-file-migration-to-asciidoc_diff.patch > > Time Spent: 20m > Remaining Estimate: 0h > > This is a general umbrella task for the creation and migration of all > accounting related information and documentation into the OFBiz asciidoc > documentation framework. > Subtasks will be created for each area where documentation needs to be > created. An initial list is as follows: > # accounting.adoc (already created - may create an issue to track any > additional work_ > # acc-intro.adoc > # acc-agreements.adoc > # acc-tax-authorities.adoc > # acc-invoices.adoc > # acc-billing-accounts.adoc > # acc-payments.adoc > # acc-payment-gateway.adoc > # acc-financial-accounts.adoc > # acc-global-settings.adoc > # acc-glossary.adoc > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10288) Move Accounting Guide into OFBiz Asciidoc Framework
[ https://issues.apache.org/jira/browse/OFBIZ-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10288: - Assignee: Michael Brohl > Move Accounting Guide into OFBiz Asciidoc Framework > --- > > Key: OFBIZ-10288 > URL: https://issues.apache.org/jira/browse/OFBIZ-10288 > Project: OFBiz > Issue Type: Task > Components: accounting >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > Attachments: > OFBIZ-10288-Help-Docbook-file-migration-to-asciidoc_diff.patch > > Time Spent: 20m > Remaining Estimate: 0h > > This is a general umbrella task for the creation and migration of all > accounting related information and documentation into the OFBiz asciidoc > documentation framework. > Subtasks will be created for each area where documentation needs to be > created. An initial list is as follows: > # accounting.adoc (already created - may create an issue to track any > additional work_ > # acc-intro.adoc > # acc-agreements.adoc > # acc-tax-authorities.adoc > # acc-invoices.adoc > # acc-billing-accounts.adoc > # acc-payments.adoc > # acc-payment-gateway.adoc > # acc-financial-accounts.adoc > # acc-global-settings.adoc > # acc-glossary.adoc > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11352) add Document Content acc-organizations-gl-settings
[ https://issues.apache.org/jira/browse/OFBIZ-11352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-11352. - Fix Version/s: Upcoming Branch Assignee: Michael Brohl Resolution: Implemented Thanks [~holivier] ! > add Document Content acc-organizations-gl-settings > -- > > Key: OFBIZ-11352 > URL: https://issues.apache.org/jira/browse/OFBIZ-11352 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Olivier Heintz >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > organization-gl-setting-Help-Docbook-file-migration-to-asciidoc_diff.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10626) Add Document Content: acc-glossary.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10626. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks [~vaibhav.jain] and [~holivier] ! > Add Document Content: acc-glossary.adoc > --- > > Key: OFBIZ-10626 > URL: https://issues.apache.org/jira/browse/OFBIZ-10626 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Vaibhav Jain >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10626.patch > > > Add content for acc-glossary.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10626) Add Document Content: acc-glossary.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10626: - Assignee: Michael Brohl (was: Vaibhav Jain) > Add Document Content: acc-glossary.adoc > --- > > Key: OFBIZ-10626 > URL: https://issues.apache.org/jira/browse/OFBIZ-10626 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Vaibhav Jain >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-10626.patch > > > Add content for acc-glossary.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10292) Add Document Content: acc-invoices.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10292. - Fix Version/s: Upcoming Branch Resolution: Implemented > Add Document Content: acc-invoices.adoc > --- > > Key: OFBIZ-10292 > URL: https://issues.apache.org/jira/browse/OFBIZ-10292 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > Attachments: > Invoice-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content for acc-invoices.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10292) Add Document Content: acc-invoices.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10292: - Assignee: Michael Brohl > Add Document Content: acc-invoices.adoc > --- > > Key: OFBIZ-10292 > URL: https://issues.apache.org/jira/browse/OFBIZ-10292 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Major > Attachments: > Invoice-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content for acc-invoices.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10297) Add Document Content: acc-global-settings.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10297. - Resolution: Implemented > Add Document Content: acc-global-settings.adoc > -- > > Key: OFBIZ-10297 > URL: https://issues.apache.org/jira/browse/OFBIZ-10297 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > Attachments: > GlobalGlSetting-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content for acc-global-settings.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10297) Add Document Content: acc-global-settings.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10297: - Assignee: Michael Brohl > Add Document Content: acc-global-settings.adoc > -- > > Key: OFBIZ-10297 > URL: https://issues.apache.org/jira/browse/OFBIZ-10297 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > Attachments: > GlobalGlSetting-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content for acc-global-settings.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10294) Add Document Content: acc-payments.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10294. - Fix Version/s: Upcoming Branch Resolution: Implemented > Add Document Content: acc-payments.adoc > --- > > Key: OFBIZ-10294 > URL: https://issues.apache.org/jira/browse/OFBIZ-10294 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > Payments-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content acc-payments.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10288) Move Accounting Guide into OFBiz Asciidoc Framework
[ https://issues.apache.org/jira/browse/OFBIZ-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10288: -- Sprint: OFBiz Community Day (Feb 2020) > Move Accounting Guide into OFBiz Asciidoc Framework > --- > > Key: OFBIZ-10288 > URL: https://issues.apache.org/jira/browse/OFBIZ-10288 > Project: OFBiz > Issue Type: Task > Components: accounting >Reporter: Sharan Foga >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > Attachments: > OFBIZ-10288-Help-Docbook-file-migration-to-asciidoc_diff.patch > > Time Spent: 20m > Remaining Estimate: 0h > > This is a general umbrella task for the creation and migration of all > accounting related information and documentation into the OFBiz asciidoc > documentation framework. > Subtasks will be created for each area where documentation needs to be > created. An initial list is as follows: > # accounting.adoc (already created - may create an issue to track any > additional work_ > # acc-intro.adoc > # acc-agreements.adoc > # acc-tax-authorities.adoc > # acc-invoices.adoc > # acc-billing-accounts.adoc > # acc-payments.adoc > # acc-payment-gateway.adoc > # acc-financial-accounts.adoc > # acc-global-settings.adoc > # acc-glossary.adoc > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10294) Add Document Content: acc-payments.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10294: - Assignee: Michael Brohl > Add Document Content: acc-payments.adoc > --- > > Key: OFBIZ-10294 > URL: https://issues.apache.org/jira/browse/OFBIZ-10294 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Attachments: > Payments-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content acc-payments.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10288) Move Accounting Guide into OFBiz Asciidoc Framework
[ https://issues.apache.org/jira/browse/OFBIZ-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044879#comment-17044879 ] ASF subversion and git services commented on OFBIZ-10288: - Commit 615f9c9fba5a2d2060edafb764427ed88ae91f61 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=615f9c9 ] Documented: remove empty help files in Accounting (OFBIZ-10288) > Move Accounting Guide into OFBiz Asciidoc Framework > --- > > Key: OFBIZ-10288 > URL: https://issues.apache.org/jira/browse/OFBIZ-10288 > Project: OFBiz > Issue Type: Task > Components: accounting >Reporter: Sharan Foga >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > Attachments: > OFBIZ-10288-Help-Docbook-file-migration-to-asciidoc_diff.patch > > Time Spent: 20m > Remaining Estimate: 0h > > This is a general umbrella task for the creation and migration of all > accounting related information and documentation into the OFBiz asciidoc > documentation framework. > Subtasks will be created for each area where documentation needs to be > created. An initial list is as follows: > # accounting.adoc (already created - may create an issue to track any > additional work_ > # acc-intro.adoc > # acc-agreements.adoc > # acc-tax-authorities.adoc > # acc-invoices.adoc > # acc-billing-accounts.adoc > # acc-payments.adoc > # acc-payment-gateway.adoc > # acc-financial-accounts.adoc > # acc-global-settings.adoc > # acc-glossary.adoc > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10626) Add Document Content: acc-glossary.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044880#comment-17044880 ] ASF subversion and git services commented on OFBIZ-10626: - Commit 42df37be00ce077080a4d9bf903cf70cc268184e in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=42df37b ] Documented: Add Accounting Glossary in Accounting documentation (OFBIZ-10626) Thank to Vaibhav Jain for this added > Add Document Content: acc-glossary.adoc > --- > > Key: OFBIZ-10626 > URL: https://issues.apache.org/jira/browse/OFBIZ-10626 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Vaibhav Jain >Assignee: Vaibhav Jain >Priority: Major > Attachments: OFBIZ-10626.patch > > > Add content for acc-glossary.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10293) Add Document Content: acc-billing-accounts.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044875#comment-17044875 ] ASF subversion and git services commented on OFBIZ-10293: - Commit 0f937ead194bf024379ade52b3af9c0b41c5e52c in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0f937ea ] Documented: Billing Account Docbook files migration to asciidoc format (OFBIZ-10293) All the help files associated to it are called via include in the main document > Add Document Content: acc-billing-accounts.adoc > --- > > Key: OFBIZ-10293 > URL: https://issues.apache.org/jira/browse/OFBIZ-10293 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Priority: Minor > Attachments: > billing-account-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content acc-billing-accounts.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11363) Setup Docbook files migration to asciidoc format
[ https://issues.apache.org/jira/browse/OFBIZ-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-11363: - Assignee: Michael Brohl > Setup Docbook files migration to asciidoc format > > > Key: OFBIZ-11363 > URL: https://issues.apache.org/jira/browse/OFBIZ-11363 > Project: OFBiz > Issue Type: Improvement > Components: commonext >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Michael Brohl >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate all setup files in docbook format to asciidoc format > For each part which the content should be review add a note with the tag TO > CHECK -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10289) Add Document Content: acc-intro.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044878#comment-17044878 ] ASF subversion and git services commented on OFBIZ-10289: - Commit 7e3268e849b48fe7de559ad98d769d4f2eb6a043 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7e3268e ] Documented: Add help for main accounting screen at the end of intro (OFBIZ-10289) > Add Document Content: acc-intro.adoc > > > Key: OFBIZ-10289 > URL: https://issues.apache.org/jira/browse/OFBIZ-10289 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Upcoming Branch >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Labels: accounting, asciidoc, documentation > > Add document content acc-intro.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11352) add Document Content acc-organizations-gl-settings
[ https://issues.apache.org/jira/browse/OFBIZ-11352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044877#comment-17044877 ] ASF subversion and git services commented on OFBIZ-11352: - Commit 3e2e71aced36be44cede2dcb57c6113870c05c7b in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3e2e71a ] Documented: Organization-Gl-Settings Docbook files migration to asciidoc format (OFBIZ-11352) All the help files associated to it are called via include in the main document > add Document Content acc-organizations-gl-settings > -- > > Key: OFBIZ-11352 > URL: https://issues.apache.org/jira/browse/OFBIZ-11352 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Olivier Heintz >Priority: Minor > Attachments: > organization-gl-setting-Help-Docbook-file-migration-to-asciidoc_diff.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10291) Add Document Content: acc-tax-authorities.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044876#comment-17044876 ] ASF subversion and git services commented on OFBIZ-10291: - Commit fad7ad0272690940695ee1f2ac00fee4d8ab7c54 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fad7ad0 ] Documented: Tax-AUthorities Docbook files migration to asciidoc format (OFBIZ-10291) All the help files associated to it are called via include in the main document > Add Document Content: acc-tax-authorities.adoc > -- > > Key: OFBIZ-10291 > URL: https://issues.apache.org/jira/browse/OFBIZ-10291 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Sharan Foga >Priority: Minor > Labels: documentation > Attachments: > tax-authorities-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content for acc-tax-authorities.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10292) Add Document Content: acc-invoices.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044872#comment-17044872 ] ASF subversion and git services commented on OFBIZ-10292: - Commit 47353fcdcb33fcbf9e2686a6802e39ff73ee6225 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=47353fc ] Documented: Invoice Docbook files migration to asciidoc format (OFBIZ-10292) All the help files associated to it are called via include in the main document > Add Document Content: acc-invoices.adoc > --- > > Key: OFBIZ-10292 > URL: https://issues.apache.org/jira/browse/OFBIZ-10292 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Priority: Major > Attachments: > Invoice-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content for acc-invoices.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10297) Add Document Content: acc-global-settings.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044871#comment-17044871 ] ASF subversion and git services commented on OFBIZ-10297: - Commit 2cd22bbcc6b8aefd902322905191524ebd959cfc in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2cd22bb ] Documented: Global GL Setting Help Docbook file migration to asciidoc format (OFBIZ-10297) All the new files are now included in the Global Gl Setting documentation presentation, each of the three Help file are included in the concerning sub-chapter. > Add Document Content: acc-global-settings.adoc > -- > > Key: OFBIZ-10297 > URL: https://issues.apache.org/jira/browse/OFBIZ-10297 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > Attachments: > GlobalGlSetting-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content for acc-global-settings.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10294) Add Document Content: acc-payments.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044873#comment-17044873 ] ASF subversion and git services commented on OFBIZ-10294: - Commit 508c5aaf9204b2643b78b2510c21e245b1a4668d in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=508c5aa ] Documented: Payments Docbook files migration to asciidoc format (OFBIZ-10294) All the help files associated to it are called via include in the main document > Add Document Content: acc-payments.adoc > --- > > Key: OFBIZ-10294 > URL: https://issues.apache.org/jira/browse/OFBIZ-10294 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Priority: Minor > Attachments: > Payments-Help-Docbook-file-migration-to-asciidoc_diff.patch > > > Add content acc-payments.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11363) Setup Docbook files migration to asciidoc format
[ https://issues.apache.org/jira/browse/OFBIZ-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044856#comment-17044856 ] ASF subversion and git services commented on OFBIZ-11363: - Commit 3ebb9f6bbc1aaa6b9cd9798ae2bed13f1b5eb926 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3ebb9f6 ] Documented: All setup help file in docbook format migration to asciidoc format (OFBIZ-11363) ofbiz-setup.adoc included all setup files and user-documentation.adoc include ofbiz-setup > Setup Docbook files migration to asciidoc format > > > Key: OFBIZ-11363 > URL: https://issues.apache.org/jira/browse/OFBIZ-11363 > Project: OFBiz > Issue Type: Improvement > Components: commonext >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate all setup files in docbook format to asciidoc format > For each part which the content should be review add a note with the tag TO > CHECK -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11363) Setup Docbook files migration to asciidoc format
[ https://issues.apache.org/jira/browse/OFBIZ-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-11363. - Resolution: Implemented Thanks Olivier! > Setup Docbook files migration to asciidoc format > > > Key: OFBIZ-11363 > URL: https://issues.apache.org/jira/browse/OFBIZ-11363 > Project: OFBiz > Issue Type: Improvement > Components: commonext >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate all setup files in docbook format to asciidoc format > For each part which the content should be review add a note with the tag TO > CHECK -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11415) Backport - Using FlexibleStringExpander in form widget field's parameter names
[ https://issues.apache.org/jira/browse/OFBIZ-11415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford updated OFBIZ-11415: --- Description: Request for backport of OFBIZ-11330 to release18.12. To allow a single form to be included on a screen multiple times, and for a collective submission from those forms to be handled by a service, it is necessary to ensure each form input can be rendered with a unique name. The name attribute of the rendered HTML form input is rendered according to the parameterName of a field in the form widget. To allow generation of unique field parameterNames we can use the FlexibleStringExpander type. PR: [https://github.com/apache/ofbiz-framework/pull/31] Improvement initially raised on dev mailing list - [https://lists.apache.org/thread.html/r20cf244d32587768e83a78d4f69d1ef1cd064b093c0e6a8e6caa74c4%40%3Cdev.ofbiz.apache.org%3E] was: Request for backport of OFBIZ-11330 to release18.10. To allow a single form to be included on a screen multiple times, and for a collective submission from those forms to be handled by a service, it is necessary to ensure each form input can be rendered with a unique name. The name attribute of the rendered HTML form input is rendered according to the parameterName of a field in the form widget. To allow generation of unique field parameterNames we can use the FlexibleStringExpander type. PR: [https://github.com/apache/ofbiz-framework/pull/31] Improvement initially raised on dev mailing list - [https://lists.apache.org/thread.html/r20cf244d32587768e83a78d4f69d1ef1cd064b093c0e6a8e6caa74c4%40%3Cdev.ofbiz.apache.org%3E] > Backport - Using FlexibleStringExpander in form widget field's parameter names > -- > > Key: OFBIZ-11415 > URL: https://issues.apache.org/jira/browse/OFBIZ-11415 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Priority: Major > Labels: backport-needed > Fix For: Upcoming Branch > > Time Spent: 10m > Remaining Estimate: 0h > > Request for backport of OFBIZ-11330 to release18.12. > To allow a single form to be included on a screen multiple times, and for a > collective submission from those forms to be handled by a service, it is > necessary to ensure each form input can be rendered with a unique name. > The name attribute of the rendered HTML form input is rendered according to > the parameterName of a field in the form widget. > To allow generation of unique field parameterNames we can use the > FlexibleStringExpander type. > > PR: [https://github.com/apache/ofbiz-framework/pull/31] > > Improvement initially raised on dev mailing list - > [https://lists.apache.org/thread.html/r20cf244d32587768e83a78d4f69d1ef1cd064b093c0e6a8e6caa74c4%40%3Cdev.ofbiz.apache.org%3E] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11418) Use FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044854#comment-17044854 ] Daniel Watford commented on OFBIZ-11418: If committers decide to apply OFBIZ-11415 which is to backport new functionality to release18.12 then this ticket should probably be backported too. > Use FlexibleStringExpander in form widget lookup field field target parameters > -- > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10955) field type Integer is missing in definitions
[ https://issues.apache.org/jira/browse/OFBIZ-10955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10955. - Fix Version/s: Upcoming Branch Resolution: Implemented > field type Integer is missing in definitions > > > Key: OFBIZ-10955 > URL: https://issues.apache.org/jira/browse/OFBIZ-10955 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: 16.11.07, 17.12.01, Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > Time Spent: 20m > Remaining Estimate: 0h > > The field type for integer values is missing in definitions for various RDBMS > variants -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10955) field type Integer is missing in definitions
[ https://issues.apache.org/jira/browse/OFBIZ-10955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044846#comment-17044846 ] ASF subversion and git services commented on OFBIZ-10955: - Commit b55279101b9ac9ef18ad49b2b409086db20b7315 in ofbiz-framework's branch refs/heads/trunk from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b552791 ] Merge pull request #29 from PierreSmits/OFBIZ-10955-FieldType Improved: field type Integer is missing in definitions. (OFBIZ-10955) Thanks Pierre Smits for the contribution. > field type Integer is missing in definitions > > > Key: OFBIZ-10955 > URL: https://issues.apache.org/jira/browse/OFBIZ-10955 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: 16.11.07, 17.12.01, Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The field type for integer values is missing in definitions for various RDBMS > variants -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10955) field type Integer is missing in definitions
[ https://issues.apache.org/jira/browse/OFBIZ-10955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044845#comment-17044845 ] ASF subversion and git services commented on OFBIZ-10955: - Commit 75ed0c48ee37b642399fbe31eabc6ad8f61fb0f7 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=75ed0c4 ] Fixed: Field Type definitions (OFBIZ-10955) Adding missing field type definition for Apache Derby, MySQL, PostgreSQL > field type Integer is missing in definitions > > > Key: OFBIZ-10955 > URL: https://issues.apache.org/jira/browse/OFBIZ-10955 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: 16.11.07, 17.12.01, Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The field type for integer values is missing in definitions for various RDBMS > variants -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10955) field type Integer is missing in definitions
[ https://issues.apache.org/jira/browse/OFBIZ-10955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044847#comment-17044847 ] ASF subversion and git services commented on OFBIZ-10955: - Commit b55279101b9ac9ef18ad49b2b409086db20b7315 in ofbiz-framework's branch refs/heads/trunk from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b552791 ] Merge pull request #29 from PierreSmits/OFBIZ-10955-FieldType Improved: field type Integer is missing in definitions. (OFBIZ-10955) Thanks Pierre Smits for the contribution. > field type Integer is missing in definitions > > > Key: OFBIZ-10955 > URL: https://issues.apache.org/jira/browse/OFBIZ-10955 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: 16.11.07, 17.12.01, Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The field type for integer values is missing in definitions for various RDBMS > variants -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11418) Use FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044842#comment-17044842 ] Daniel Watford commented on OFBIZ-11418: PR created: [https://github.com/apache/ofbiz-framework/pull/32] > Use FlexibleStringExpander in form widget lookup field field target parameters > -- > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11418) Use FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford updated OFBIZ-11418: --- Issue Type: Improvement (was: Bug) > Use FlexibleStringExpander in form widget lookup field field target parameters > -- > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Major > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11046) add a HR Data model chapter
[ https://issues.apache.org/jira/browse/OFBIZ-11046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044839#comment-17044839 ] Michael Brohl commented on OFBIZ-11046: --- [~holivier] how do these patches relate to the latest commits / PR? Can you please review and edit the patches to match the latest trunk state? Thank you. > add a HR Data model chapter > --- > > Key: OFBIZ-11046 > URL: https://issues.apache.org/jira/browse/OFBIZ-11046 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: humanres > Fix For: Trunk > > Attachments: EmplPosition.png, EmplPositionDetail.png, > Employment.png, EmploymentApp.png, OFBIZ_11046_humanres.adoc.patch, > PartyHumanRes.png, PerfReview.png, ability.png, hr-data-model.adoc > > > Add some UML diagram about main HR entities. > Each diagram contain not all associated entities but only one important to > have a first understanding about the main entity of the diagram. > In the doc, each diagram is associated with some link to others diagram to > easily naviguate. > This chapter could be included in hr-documentation just before hr-glossary -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11039) add a chapter "About this documentation"
[ https://issues.apache.org/jira/browse/OFBIZ-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044837#comment-17044837 ] Michael Brohl commented on OFBIZ-11039: --- [~holivier] how do these patches relate to the latest commits / PR? Can you please review and edit the patches to match the latest trunk state? Thank you. > add a chapter "About this documentation" > > > Key: OFBIZ-11039 > URL: https://issues.apache.org/jira/browse/OFBIZ-11039 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Fix For: Trunk > > Attachments: Employee_Main_Screen.png, > HR-Employee_Submenu_Rainbow_Stone.png, HR-Employee_Submenu_Tomahawk.png, > HR_Application_Submenu_Rainbow_Stone.png, > HR_Application_Submenu_Tomahawk.png, hr-about-doc.adoc > > > This chapter present the main OFBiz GUI rules with some screenshot and link > between tutorial and video of "Scenario GUI Test" > Currently it's in HR, but when other application will be done it can be > generalize and go to User Manual introduction. > The file hr-about-doc.adoc associated with this task is included via a > include:: line in the humanres.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11027) HR Doc, Associated a scenario UI test for each process
[ https://issues.apache.org/jira/browse/OFBIZ-11027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044834#comment-17044834 ] Michael Brohl commented on OFBIZ-11027: --- [~holivier] how do these patches relate to the latest commits / PR? > HR Doc, Associated a scenario UI test for each process > -- > > Key: OFBIZ-11027 > URL: https://issues.apache.org/jira/browse/OFBIZ-11027 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: Documentation, humanres, tutorial > Attachments: OFBIZ-11027_hr-intro.adoc.patch, > hr-tuto-define-company-organization.adoc, hr-tuto-employment-and-salary.adoc > > > I propose that in HR documentation, each process is described via a scenario > explained like a tutorial. > To realize the tutorial, and to have more quality, I propose to create a UI > Test for each process. > In these tests, some user messages are added and a video recording is in > place when it run, so result is usable as a tutorial > With this method to create tutorial we are sure it are up to date and it > works ! > Currently a tutorial / test exist for process "Organization, Job Position and > Definition" and it run ona daily base on Apache OFBiz trunk demo. > A second one exist for process "Employee Salary and Benefits Administration" > but for runing some modification /enhancement are needed, so currenlty it not > run on Apache OFBiz trunk demo. > Result video are readeable > https://video.ploud.fr/video-channels/ofbizextra_tutorial/videos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11026) HR Doc drive by process
[ https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044831#comment-17044831 ] Michael Brohl commented on OFBIZ-11026: --- Hi [~holivier] , I am unsure about the state of this issue, can you shed some light on it? Thanks. > HR Doc drive by process > --- > > Key: OFBIZ-11026 > URL: https://issues.apache.org/jira/browse/OFBIZ-11026 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Michael Brohl >Priority: Major > Labels: Documentation, humanres > Attachments: OFBIZ-11026_hr-intro.adoc.patch, > OFBIZ-11026_humanres.adoc.patch, > OFBIZ-11026_humanres.adoc_with_hr-about-doc.patch > > > Currently HR doc main chapters are on core HR object, I propose to group them > in a chapter and having a chapter by process in the same level bot group in > the HR Process. > Each process is described via a scenario explained like a tutorial, and each > time a core object is used, a link is done to its chapter. > To help review : doc with these modifications are available at > [https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources] > and Apache OFBiz standard (without modifications) is available too at > https://ofbizadoc.ofbizextra.org/html5/user-manual-std.html#_human_resources > current HR TOC > -- > 3.2. Human Resources > 3.2.1. About Human Resources > 3.2.2. Human Resources Processes > 3.2.3. Employee Positions > 3.2.4. Employees > 3.2.5. Employments > 3.2.6. Performance Review > 3.2.7. Qualifications > 3.2.8. Recruitment > 3.2.9. Skills > 3.2.10. Resumes > 3.2.11. Training > 3.2.12. Leave > 3.2.13. Security > 3.2.14. Global HR Settings > 3.2.15. Glossary > Proposed HR TOC > > 4. Human Resources > 4.1. About this documentation > 4.2. About Human Resources > 4.3. HR Processes > 4.3.1. Organization, Job Position and Definition > 4.3.2. Recruitment, Candidate Selection and Hiring > 4.3.3. Employee Training and Development > 4.3.4. Performance Management and Employee Evaluation > 4.3.5. Employee Salary and Benefits Administration > 4.4. HR core object > 4.4.1. Employee Positions > 4.4.2. Employees > 4.4.3. Employments > 4.4.4. Performance Review > 4.4.5. Qualifications > 4.4.6. Recruitment > 4.4.7. Skills > 4.4.8. Resumes > 4.4.9. Training > 4.4.10. Leave > 4.4.11. Security > 4.5. Global HR Settings > 4.5.1. Skills Types > 4.6. HR Data model > 4.6.1. Employee Position > 4.6.2. Employment > 4.6.3. Qualification, Skill, Review > 4.6.4. HR App intra-application integration > 4.7. Glossary -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11026) HR Doc drive by process
[ https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-11026: - Assignee: Michael Brohl > HR Doc drive by process > --- > > Key: OFBIZ-11026 > URL: https://issues.apache.org/jira/browse/OFBIZ-11026 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Michael Brohl >Priority: Major > Labels: Documentation, humanres > Attachments: OFBIZ-11026_hr-intro.adoc.patch, > OFBIZ-11026_humanres.adoc.patch, > OFBIZ-11026_humanres.adoc_with_hr-about-doc.patch > > > Currently HR doc main chapters are on core HR object, I propose to group them > in a chapter and having a chapter by process in the same level bot group in > the HR Process. > Each process is described via a scenario explained like a tutorial, and each > time a core object is used, a link is done to its chapter. > To help review : doc with these modifications are available at > [https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources] > and Apache OFBiz standard (without modifications) is available too at > https://ofbizadoc.ofbizextra.org/html5/user-manual-std.html#_human_resources > current HR TOC > -- > 3.2. Human Resources > 3.2.1. About Human Resources > 3.2.2. Human Resources Processes > 3.2.3. Employee Positions > 3.2.4. Employees > 3.2.5. Employments > 3.2.6. Performance Review > 3.2.7. Qualifications > 3.2.8. Recruitment > 3.2.9. Skills > 3.2.10. Resumes > 3.2.11. Training > 3.2.12. Leave > 3.2.13. Security > 3.2.14. Global HR Settings > 3.2.15. Glossary > Proposed HR TOC > > 4. Human Resources > 4.1. About this documentation > 4.2. About Human Resources > 4.3. HR Processes > 4.3.1. Organization, Job Position and Definition > 4.3.2. Recruitment, Candidate Selection and Hiring > 4.3.3. Employee Training and Development > 4.3.4. Performance Management and Employee Evaluation > 4.3.5. Employee Salary and Benefits Administration > 4.4. HR core object > 4.4.1. Employee Positions > 4.4.2. Employees > 4.4.3. Employments > 4.4.4. Performance Review > 4.4.5. Qualifications > 4.4.6. Recruitment > 4.4.7. Skills > 4.4.8. Resumes > 4.4.9. Training > 4.4.10. Leave > 4.4.11. Security > 4.5. Global HR Settings > 4.5.1. Skills Types > 4.6. HR Data model > 4.6.1. Employee Position > 4.6.2. Employment > 4.6.3. Qualification, Skill, Review > 4.6.4. HR App intra-application integration > 4.7. Glossary -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10271) Add Document Content: hr-global-settings.adoc
[
https://issues.apache.org/jira/browse/OFBIZ-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-10271.
-
Resolution: Implemented
Closing with commit
{code:java}
commit 13abd8298cd4f0b993d88809e577f076b55bf298
Author: holivier
AuthorDate: Tue Feb 25 11:51:29 2020 +0100
Documented : just remove trailing space
(OFBIZ-10251)
{code}
> Add Document Content: hr-global-settings.adoc
> -
>
> Key: OFBIZ-10271
> URL: https://issues.apache.org/jira/browse/OFBIZ-10271
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Upcoming Branch
>Reporter: Sharan Foga
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: hr-global-settings.adoc, hr-global-settings.adoc
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide
> and other human resources asciidoc file, write or organise the content for
> the hr-global-ettings.adoc file.
> A copy of the existing file will be attached. Please write document content
> for hr-global-settings.adoc by updating the template then re-attach the
> updated document to this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10271) Add Document Content: hr-global-settings.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10271: - Assignee: Michael Brohl (was: Sharan Foga) > Add Document Content: hr-global-settings.adoc > - > > Key: OFBIZ-10271 > URL: https://issues.apache.org/jira/browse/OFBIZ-10271 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Upcoming Branch >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Attachments: hr-global-settings.adoc, hr-global-settings.adoc > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the hr-global-ettings.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-global-settings.adoc by updating the template then re-attach the > updated document to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11418) Use FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford updated OFBIZ-11418: --- Summary: Use FlexibleStringExpander in form widget lookup field field target parameters (was: Using FlexibleStringExpander in form widget lookup field field target parameters) > Use FlexibleStringExpander in form widget lookup field field target parameters > -- > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Major > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10255) Add Document Content: humanres.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044827#comment-17044827 ] Michael Brohl commented on OFBIZ-10255: --- Hi [~sharan], [~holivier] , do you think we can close this Jira with the latest changes from Olivier? > Add Document Content: humanres.adoc > --- > > Key: OFBIZ-10255 > URL: https://issues.apache.org/jira/browse/OFBIZ-10255 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Attachments: OFBIZ-10255.patch, humanres.adoc, humanres.adoc.patch > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the humanres.adoc file. > An copy of the existing file will be attached. > Please update the template and re-attach it. > NOTE: This document might not be able to be completed until other sections > for Human Resources are done. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10256) Add Document Content: hr-intro.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10256. - Resolution: Implemented > Add Document Content: hr-intro.adoc > --- > > Key: OFBIZ-10256 > URL: https://issues.apache.org/jira/browse/OFBIZ-10256 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Olivier Heintz >Priority: Minor > Attachments: OFBizMainScreen.png, hr-intro.adoc, hr-intro.adoc, > hr-intro.patch > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the hr-intro.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-intro.adoc by updating the template then re-attach the updated > document to this issue. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10256) Add Document Content: hr-intro.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044814#comment-17044814 ] ASF subversion and git services commented on OFBIZ-10256: - Commit 8d80909c9022a7240c721398f4acb697c338dd86 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8d80909 ] Documented : Migrate Help to asciidoc and include in hr-intro.adoc (OFBIZ-10256) remove all related Help file in docbook format > Add Document Content: hr-intro.adoc > --- > > Key: OFBIZ-10256 > URL: https://issues.apache.org/jira/browse/OFBIZ-10256 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Olivier Heintz >Priority: Minor > Attachments: OFBizMainScreen.png, hr-intro.adoc, hr-intro.adoc, > hr-intro.patch > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the hr-intro.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-intro.adoc by updating the template then re-attach the updated > document to this issue. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10261) Add Document Content: hr-employments.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044816#comment-17044816 ] ASF subversion and git services commented on OFBIZ-10261: - Commit 3d4d999e6ae57c4810594474624ebf5010c16834 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3d4d999 ] Documented : Migrate Employment Help to asciidoc and include in hr-employment.adoc (OFBIZ-10261) Included all Help about Employment screen in a dedicated sub-chapter "Employment management in UI" Related Help file in docbook format is deleted > Add Document Content: hr-employments.adoc > - > > Key: OFBIZ-10261 > URL: https://issues.apache.org/jira/browse/OFBIZ-10261 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Fix For: 18.12.01 > > Attachments: hr-employments.adoc > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the hr-employments.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-employments.adoc by updating the template then re-attach the updated > document to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10251) Move Human Resources Guide into OFBiz Asciidoc Framework
[ https://issues.apache.org/jira/browse/OFBIZ-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044819#comment-17044819 ] ASF subversion and git services commented on OFBIZ-10251: - Commit 13abd8298cd4f0b993d88809e577f076b55bf298 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=13abd82 ] Documented : just remove trailing space (OFBIZ-10251) > Move Human Resources Guide into OFBiz Asciidoc Framework > > > Key: OFBIZ-10251 > URL: https://issues.apache.org/jira/browse/OFBIZ-10251 > Project: OFBiz > Issue Type: Task >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Labels: asciidoc, documentation, humanres > Attachments: introduction.patch > > Time Spent: 20m > Remaining Estimate: 0h > > This is a general umbrella issue for managing the creation and migration of > all OFBiz related Human Resources documentation into the OFBiz code base. > Subtasks will be created for each of the documents that need to be created. > Also created as a sub task will the task to create empty documents for each > of the sub-files in the list > An initial list is as follows: > # human-resources.adoc > # human-resources-intro.adoc > # employee-evaluations.adoc > # human-resources-glossary.adoc > # employee-positions.adoc > # employees.adoc > # employments.adoc > # performance-review.adoc > # positions.adoc > # qualifications.adoc > # recruitment.adoc > # skiils.adoc > # resumes.adoc > # training.adoc > # leave.adoc > # human-resources-security.adoc > # human-resources-global-settings.adoc > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10259) Add Document Content: hr-employee-positions.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044817#comment-17044817 ] ASF subversion and git services commented on OFBIZ-10259: - Commit 97d15cbcb0aa3b91129f9c67e9f2ca74f8517133 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=97d15cb ] Documented : Migrate Employee-position Help to asciidoc and include in hr-employee-positions.adoc (OFBIZ-10259) Included all Help about Employee-position screen in a dedicated sub-chapter "Employee Position management in UI" Related Help file in docbook format is deleted > Add Document Content: hr-employee-positions.adoc > > > Key: OFBIZ-10259 > URL: https://issues.apache.org/jira/browse/OFBIZ-10259 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Labels: asciidoc, documentation, humanres > Fix For: 18.12.01 > > Attachments: HELP_HR_EditEmplPosition.adoc, > HELP_HR_EmplPositionView.adoc, HELP_HR_FindEmplPositions.adoc, > HELP_HR_ListEmplPositions.adoc, hr-employee-positions.adoc > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the hr-employee-positions.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-employee-positions.adoc by updating the template then re-attach the > updated document to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10260) Add Document Content: hr-employees.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044815#comment-17044815 ] ASF subversion and git services commented on OFBIZ-10260: - Commit eddb5a7b4166de08e5c3c97a532a37bed9978391 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=eddb5a7 ] Documented : Migrate Employee Help to asciidoc and include in hr-employees.adoc (OFBIZ-10260) Included all Help about Employee screen in a dedicated sub-chapter "Employee management in UI" Related Help file in docbook format is deleted > Add Document Content: hr-employees.adoc > --- > > Key: OFBIZ-10260 > URL: https://issues.apache.org/jira/browse/OFBIZ-10260 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Fix For: 18.12.01 > > Attachments: hr-employees.adoc > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc files, write or organise the content for > the hr-employees.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-employees.adoc by updating the template then re-attach the updated > document to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10268) Add Document Content: hr-training.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044818#comment-17044818 ] ASF subversion and git services commented on OFBIZ-10268: - Commit f0e4db047d22c8946c30b4b26b0329b9217c5947 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f0e4db0 ] Documented : Migrate Training Howto Help to asciidoc and include in hr-training.adoc (OFBIZ-10268) Included the Howto as a sub-chapter File in docbook format is deleted > Add Document Content: hr-training.adoc > -- > > Key: OFBIZ-10268 > URL: https://issues.apache.org/jira/browse/OFBIZ-10268 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Attachments: OFBIZ-10268.patch, hr-training.adoc, hr-training.adoc > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the hr-training.adoc file. > A copy of the existing file will be attached. Please write document content > for hr-training.adoc by updating the template then re-attach the updated > document to this issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11413) Convert AccountServices.xml from mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-11413: - Assignee: Wiebke Pätzold > Convert AccountServices.xml from mini lang to groovy > > > Key: OFBIZ-11413 > URL: https://issues.apache.org/jira/browse/OFBIZ-11413 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Reporter: Wiebke Pätzold >Assignee: Wiebke Pätzold >Priority: Minor > > Migration of the AccountServices.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10955) field type Integer is missing in definitions
[ https://issues.apache.org/jira/browse/OFBIZ-10955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044808#comment-17044808 ] Michael Brohl commented on OFBIZ-10955: --- Please amend the commit message for the PR to "Improved: ..." instead of "Fixed: ...", thanks. > field type Integer is missing in definitions > > > Key: OFBIZ-10955 > URL: https://issues.apache.org/jira/browse/OFBIZ-10955 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: 16.11.07, 17.12.01, Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The field type for integer values is missing in definitions for various RDBMS > variants -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10298) Fluent API Bug in getFieldList()
[
https://issues.apache.org/jira/browse/OFBIZ-10298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-10298.
-
Fix Version/s: 17.12.01
18.12.01
Resolution: Fixed
> Fluent API Bug in getFieldList()
>
>
> Key: OFBIZ-10298
> URL: https://issues.apache.org/jira/browse/OFBIZ-10298
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: 18.12.01, 17.12.01
>
> Attachments: OFBIZ-10298_fluent_API_Bug.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_distinct_to_primitive.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_getFieldList_Fix.patch
>
>
> In EntityQuery the method getFieldList() uses the class variable {{distinct}}
> to decide if the list of genericValues should be stored in a set to eliminate
> duplicate values. This variable is set by the function distinct() and
> normally it should only be used for the sql statement. But here the flag gets
> mistreated since, if the list of values was ordered because of orderBy(), the
> order of values gets lost by putting them into a set. To summarize, the
> following statement:
> {{orderBy("...").dinstinct().getFieldLlist("...");}}
> does not produce an ordered list.
> Replacing the HashSet by a LinkedHashSet fixes this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10298) Fluent API Bug in getFieldList()
[
https://issues.apache.org/jira/browse/OFBIZ-10298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044800#comment-17044800
]
ASF subversion and git services commented on OFBIZ-10298:
-
Commit 8afb711ef31751e36cc6155dd6bbaf21cacb6f3e in ofbiz-framework's branch
refs/heads/trunk from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8afb711 ]
Fixed: Fluent API Bug in getFieldList().
(OFBIZ-10298)
Thanks Benjamin Jugl for reporting and providing the patch.
> Fluent API Bug in getFieldList()
>
>
> Key: OFBIZ-10298
> URL: https://issues.apache.org/jira/browse/OFBIZ-10298
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10298_fluent_API_Bug.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_distinct_to_primitive.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_getFieldList_Fix.patch
>
>
> In EntityQuery the method getFieldList() uses the class variable {{distinct}}
> to decide if the list of genericValues should be stored in a set to eliminate
> duplicate values. This variable is set by the function distinct() and
> normally it should only be used for the sql statement. But here the flag gets
> mistreated since, if the list of values was ordered because of orderBy(), the
> order of values gets lost by putting them into a set. To summarize, the
> following statement:
> {{orderBy("...").dinstinct().getFieldLlist("...");}}
> does not produce an ordered list.
> Replacing the HashSet by a LinkedHashSet fixes this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10298) Fluent API Bug in getFieldList()
[
https://issues.apache.org/jira/browse/OFBIZ-10298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044803#comment-17044803
]
ASF subversion and git services commented on OFBIZ-10298:
-
Commit 651231d04116ef029a59375798d33e97031b15c3 in ofbiz-framework's branch
refs/heads/release17.12 from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=651231d ]
Fixed: Fluent API Bug in getFieldList().
(OFBIZ-10298)
Thanks Benjamin Jugl for reporting and providing the patch.
> Fluent API Bug in getFieldList()
>
>
> Key: OFBIZ-10298
> URL: https://issues.apache.org/jira/browse/OFBIZ-10298
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10298_fluent_API_Bug.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_distinct_to_primitive.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_getFieldList_Fix.patch
>
>
> In EntityQuery the method getFieldList() uses the class variable {{distinct}}
> to decide if the list of genericValues should be stored in a set to eliminate
> duplicate values. This variable is set by the function distinct() and
> normally it should only be used for the sql statement. But here the flag gets
> mistreated since, if the list of values was ordered because of orderBy(), the
> order of values gets lost by putting them into a set. To summarize, the
> following statement:
> {{orderBy("...").dinstinct().getFieldLlist("...");}}
> does not produce an ordered list.
> Replacing the HashSet by a LinkedHashSet fixes this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10298) Fluent API Bug in getFieldList()
[
https://issues.apache.org/jira/browse/OFBIZ-10298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044801#comment-17044801
]
ASF subversion and git services commented on OFBIZ-10298:
-
Commit f4d96deeca183f321bb285a4c4eb11ad052e7120 in ofbiz-framework's branch
refs/heads/release18.12 from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f4d96de ]
Fixed: Fluent API Bug in getFieldList().
(OFBIZ-10298)
Thanks Benjamin Jugl for reporting and providing the patch.
> Fluent API Bug in getFieldList()
>
>
> Key: OFBIZ-10298
> URL: https://issues.apache.org/jira/browse/OFBIZ-10298
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10298_fluent_API_Bug.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_distinct_to_primitive.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_getFieldList_Fix.patch
>
>
> In EntityQuery the method getFieldList() uses the class variable {{distinct}}
> to decide if the list of genericValues should be stored in a set to eliminate
> duplicate values. This variable is set by the function distinct() and
> normally it should only be used for the sql statement. But here the flag gets
> mistreated since, if the list of values was ordered because of orderBy(), the
> order of values gets lost by putting them into a set. To summarize, the
> following statement:
> {{orderBy("...").dinstinct().getFieldLlist("...");}}
> does not produce an ordered list.
> Replacing the HashSet by a LinkedHashSet fixes this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-10298) Fluent API Bug in getFieldList()
[
https://issues.apache.org/jira/browse/OFBIZ-10298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-10298:
--
Attachment: OFBIZ-10298_fluent_API_Bug.patch
> Fluent API Bug in getFieldList()
>
>
> Key: OFBIZ-10298
> URL: https://issues.apache.org/jira/browse/OFBIZ-10298
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10298_fluent_API_Bug.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_distinct_to_primitive.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_getFieldList_Fix.patch
>
>
> In EntityQuery the method getFieldList() uses the class variable {{distinct}}
> to decide if the list of genericValues should be stored in a set to eliminate
> duplicate values. This variable is set by the function distinct() and
> normally it should only be used for the sql statement. But here the flag gets
> mistreated since, if the list of values was ordered because of orderBy(), the
> order of values gets lost by putting them into a set. To summarize, the
> following statement:
> {{orderBy("...").dinstinct().getFieldLlist("...");}}
> does not produce an ordered list.
> Replacing the HashSet by a LinkedHashSet fixes this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-10157) Performance optimization for entities in xml data export
[ https://issues.apache.org/jira/browse/OFBIZ-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10157. - Fix Version/s: Upcoming Branch Resolution: Implemented > Performance optimization for entities in xml data export > > > Key: OFBIZ-10157 > URL: https://issues.apache.org/jira/browse/OFBIZ-10157 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: Kyra Pritzel-Hentley >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10157_XmlDsDump_performance_optimization.patch, > OFBIZ-10157_XmlDsDump_performance_optimization.patch > > > Suggested changes for XmlDsDump.groovy by [~mbecker]: > - set parameter _distinct_ for new EntityFindOptions to false > - when accessing values with delegator._find_() remove any sorting from > parameters > These changes allow and/or speed up export of large tables (e.g. for db > migration) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10157) Performance optimization for entities in xml data export
[ https://issues.apache.org/jira/browse/OFBIZ-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044775#comment-17044775 ] ASF subversion and git services commented on OFBIZ-10157: - Commit 74db8bde12ef853882b3fb5941d812dfd52f3d9f in ofbiz-framework's branch refs/heads/trunk from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=74db8bd ] Improved: Performance optimization for entities in xml data export. (OFBIZ-10157) Thanks Kyra Pritzel-Hentley for reporting and providing the patch. > Performance optimization for entities in xml data export > > > Key: OFBIZ-10157 > URL: https://issues.apache.org/jira/browse/OFBIZ-10157 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: Kyra Pritzel-Hentley >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-10157_XmlDsDump_performance_optimization.patch, > OFBIZ-10157_XmlDsDump_performance_optimization.patch > > > Suggested changes for XmlDsDump.groovy by [~mbecker]: > - set parameter _distinct_ for new EntityFindOptions to false > - when accessing values with delegator._find_() remove any sorting from > parameters > These changes allow and/or speed up export of large tables (e.g. for db > migration) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11306) POC for CSRF Token
[
https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044776#comment-17044776
]
Jacques Le Roux commented on OFBIZ-11306:
-
I just tested
csrf.defense.strategy=org.apache.ofbiz.security.NoCsrfDefenseStrategy and got
this issue:
{noformat}
2020-02-25 19:39:27,738 |jsse-nio-8443-exec-2 |ScreenFactory
|I| Got 25 screens in 0.007s from:
file:/C:/projectsASF/Git/ofbiz-framework/themes/common-theme/widget/CommonScreens.xml
2020-02-25 19:39:27,741 |jsse-nio-8443-exec-2 |HtmlWidget
|E| Error rendering included template at location
[component://rainbowstone/template/includes/Header.ftl]: java.io.IOException
java.io.IOException: null
at
org.apache.ofbiz.webapp.ftl.CsrfTokenAjaxTransform$1.close(CsrfTokenAjaxTransform.java:59)
~[main/:?]
{noformat}
I'll check that before creating the fork
> POC for CSRF Token
> --
>
> Key: OFBIZ-11306
> URL: https://issues.apache.org/jira/browse/OFBIZ-11306
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Labels: CSRF
> Fix For: Upcoming Branch
>
> Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java,
> CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch,
> OFBIZ-11306-alternative merged with James's.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-v2.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch,
> OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch,
> OFBIZ-11306_Plugins.patch, partyTokenMap.webtools.txt
>
>
> CRSF tokens are generated using SecureRandom class (maybe later a JWT with a
> "time out").
> They are stored in the user sessions (for AJAX calls and unauthenticated HTTP
> calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during
> POST request.
> # In *controllers* a new csrf-token attribute is added to the security tag to
> exempt or force CSRF token check.
> # In *Widget Forms* a hidden token field is auto-generated.
> # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the
> change. Using <@ofbizUrl> macro to generate the CSRF token means there is no
> need to manually add the CSRF token field to each form in the ftl files. It
> will save time for users doing custom implementation and maintenance. While
> there is CSRF token in the form URL, the token is invalidated during form
> submission. So it's uniqueand harmless even though the CSRF token of the form
> submission is shown in the browser address bar.
> # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added
> through OfbizUtil.js (itself called at start in decorators and such)
> # The html metadata is storing the csrf token used by JQuery AJAX. This token
> will not change to another value after it is consumed
> # Csrf tokens for the user are removed from the UtilCache when the user logs
> out or session invalidated.
> The general rule are as follows:
> * RequestMap configured with 'get' method will be exempted from CSRF token
> check.
> * RequestMap configured with 'post' or 'all' method will be subjected to CSRF
> token check. (Note there are discussions that RequestMap with ‘all’ method
> should also not be subjected to CSRF token check. This will be done after
> ensuring a separate uri is used when posting changes.)
> * "main" request URIs are exempted from CSRF token check.
> * Setting csrf-token to false or true on the Request Map will override the
> general rules above.
> To Discuss:
> * Invalidate authenticated user session when CSRF token check fails.
> * Configure the general rules in a Service method (which will be run inside
> the constructor of RequestMap class) when determining the final
> securityCsrfToken value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-10001) Convert CategoryContentServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10001. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Dennis, Deepak and Sebastian! > Convert CategoryContentServices.xml mini lang to groovy > --- > > Key: OFBIZ-10001 > URL: https://issues.apache.org/jira/browse/OFBIZ-10001 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Labels: refactoring > Fix For: Upcoming Branch > > Attachments: > OFBIZ-10001_org.apache.ofbiz.product.category.CategoryContentServices_convert.patch, > > OFBIZ-10001_org.apache.ofbiz.product.category.CategoryContentServices_convert.patch > > > Migration of the CategoryContentServices.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10001) Convert CategoryContentServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044771#comment-17044771 ] ASF subversion and git services commented on OFBIZ-10001: - Commit f3d3547515aaba8d62f93b364116b8a4d4285034 in ofbiz-framework's branch refs/heads/trunk from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f3d3547 ] Improved: Convert CategoryContentServices.xml mini lang to groovy. (OFBIZ-10001) Thanks Dennis Balkir for reporting and the initial work, Deepak Dixit for review and Sebastian Berg for the refactored patch. > Convert CategoryContentServices.xml mini lang to groovy > --- > > Key: OFBIZ-10001 > URL: https://issues.apache.org/jira/browse/OFBIZ-10001 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Labels: refactoring > Attachments: > OFBIZ-10001_org.apache.ofbiz.product.category.CategoryContentServices_convert.patch, > > OFBIZ-10001_org.apache.ofbiz.product.category.CategoryContentServices_convert.patch > > > Migration of the CategoryContentServices.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11418) Using FlexibleStringExpander in form widget lookup field field target parameters
Daniel Watford created OFBIZ-11418: -- Summary: Using FlexibleStringExpander in form widget lookup field field target parameters Key: OFBIZ-11418 URL: https://issues.apache.org/jira/browse/OFBIZ-11418 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Daniel Watford OFBIZ-11330 added use of FlexibleStringExpander when generating the parameter-name for a Form Widget Field. The form widget's Lookup field makes use of a target-parameter attribute to determine the input fields which should be read from when making a lookup request. Since we can now generate field parameter names from FlexibleStringExpander expressions it seems appropriate to be able to populate the target-parameter with the same expressions. Not doing so means that we can potentially generate parameter names that cannot be referenced by a lookup field. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11418) Using FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford reassigned OFBIZ-11418: -- Assignee: Daniel Watford > Using FlexibleStringExpander in form widget lookup field field target > parameters > > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Major > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11407) Upgrade Tomcat from 9.0.29 to 9.0.31 (CVE-2020-1938)
[ https://issues.apache.org/jira/browse/OFBIZ-11407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044541#comment-17044541 ] ASF subversion and git services commented on OFBIZ-11407: - Commit 018ebbb26577a634fbffbf32e9afe725af429692 in ofbiz-framework's branch refs/heads/release18.12 from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=018ebbb ] Upgrade Tomcat from 9.0.29 to 9.0.31 (OFBIZ-11407) Overriding the new default property secretRequired to be not required and added the default property "secret" in the commented out section. > Upgrade Tomcat from 9.0.29 to 9.0.31 (CVE-2020-1938) > > > Key: OFBIZ-11407 > URL: https://issues.apache.org/jira/browse/OFBIZ-11407 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > CVE-2020-1938 AJP Request Injection and potential Remote Code Execution > Severity: High > Vendor: The Apache Software Foundation > Versions Affected: > Apache Tomcat 9.0.0.M1 to 9.0.30 > Apache Tomcat 8.5.0 to 8.5.50 > Apache Tomcat 7.0.0 to 7.0.99 > Description: > When using the Apache JServ Protocol (AJP), care must be taken when > trusting incoming connections to Apache Tomcat. Tomcat treats AJP > connections as having higher trust than, for example, a similar HTTP > connection. If such connections are available to an attacker, they can > be exploited in ways that may be surprising. > Prior to Tomcat 9.0.31, 8.5.51 and 7.0.100, Tomcat shipped with an AJP > Connector enabled by default that listened on all configured IP > addresses. It was expected (and recommended in the security guide) that > this Connector would be disabled if not required. > Prior to this vulnerability report, the known risks of an attacker being > able to access the AJP port directly were: > - bypassing security checks based on client IP address > - bypassing user authentication if Tomcat was configured to trust > authentication data provided by the reverse proxy > This vulnerability report identified a mechanism that allowed the following: > - returning arbitrary files from anywhere in the web application > including under the WEB-INF and META-INF directories or any other > location reachable via ServletContext.getResourceAsStream() > - processing any file in the web application as a JSP > Further, if the web application allowed file upload and stored those > files within the web application (or the attacker was able to control > the content of the web application by some other means) then this, along > with the ability to process a file as a JSP, made remote code execution > possible. > Mitigation: > It is important to note that mitigation is only required if an AJP port > is accessible to untrusted users. > - If AJP support is not required, the Connector may be disabled e.g. by > removing the AJP Connector element from the server.xml file > - If AJP support is required, untrusted users may be prevented from > accessing the AJP port by one or more of the following means: > - configuring appropriate network firewall rules > - configuring an explicit address attribute to the connector so that > the Connector listens on a non-public interface > - configuring a shared secret for the AJP connection > Users wishing to take a defence-in-depth approach and block the vector > that permits returning arbitrary files and execution as JSP may upgrade to: > - Apache Tomcat 9.0.31 or later > - Apache Tomcat 8.5.51 or later > - Apache Tomcat 7.0.100 or later > Users should note that a number of changes were made to the default AJP > Connector configuration in these versions to harden the default > configuration. The changes are: > - The AJP Connector is commented out in the provided server.xml file. > - The "requiredSecret" attribute has been renamed "secret" (the old name > continues to work but is deprecated). > - A new attribute "secretRequired" has been added which defaults to > "true". When this attribute is "true", the AJP Connector will not > start unless a shared secret has been configured. > - The default listen address for the AJP Connector is now the loopback > address. > It is likely that users upgrading to 9.0.31, 8.5.51 or 7.0.100 and later > will need to make small changes to their configurations as a result. > References: > [1] http://tomcat.apache.org/security-9.html > [2] http://tomcat.apache.org/security-8.html > [3] http://tomcat.apache.org/securit -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11407) Upgrade Tomcat from 9.0.29 to 9.0.31 (CVE-2020-1938)
[ https://issues.apache.org/jira/browse/OFBIZ-11407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044540#comment-17044540 ] ASF subversion and git services commented on OFBIZ-11407: - Commit 0ea9173e8dd83bfbf5255548079de96c82a88544 in ofbiz-framework's branch refs/heads/release17.12 from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0ea9173 ] Upgrade Tomcat from 9.0.29 to 9.0.31 (OFBIZ-11407) Overriding the new default property secretRequired to be not required and added the default property "secret" in the commented out section. > Upgrade Tomcat from 9.0.29 to 9.0.31 (CVE-2020-1938) > > > Key: OFBIZ-11407 > URL: https://issues.apache.org/jira/browse/OFBIZ-11407 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > CVE-2020-1938 AJP Request Injection and potential Remote Code Execution > Severity: High > Vendor: The Apache Software Foundation > Versions Affected: > Apache Tomcat 9.0.0.M1 to 9.0.30 > Apache Tomcat 8.5.0 to 8.5.50 > Apache Tomcat 7.0.0 to 7.0.99 > Description: > When using the Apache JServ Protocol (AJP), care must be taken when > trusting incoming connections to Apache Tomcat. Tomcat treats AJP > connections as having higher trust than, for example, a similar HTTP > connection. If such connections are available to an attacker, they can > be exploited in ways that may be surprising. > Prior to Tomcat 9.0.31, 8.5.51 and 7.0.100, Tomcat shipped with an AJP > Connector enabled by default that listened on all configured IP > addresses. It was expected (and recommended in the security guide) that > this Connector would be disabled if not required. > Prior to this vulnerability report, the known risks of an attacker being > able to access the AJP port directly were: > - bypassing security checks based on client IP address > - bypassing user authentication if Tomcat was configured to trust > authentication data provided by the reverse proxy > This vulnerability report identified a mechanism that allowed the following: > - returning arbitrary files from anywhere in the web application > including under the WEB-INF and META-INF directories or any other > location reachable via ServletContext.getResourceAsStream() > - processing any file in the web application as a JSP > Further, if the web application allowed file upload and stored those > files within the web application (or the attacker was able to control > the content of the web application by some other means) then this, along > with the ability to process a file as a JSP, made remote code execution > possible. > Mitigation: > It is important to note that mitigation is only required if an AJP port > is accessible to untrusted users. > - If AJP support is not required, the Connector may be disabled e.g. by > removing the AJP Connector element from the server.xml file > - If AJP support is required, untrusted users may be prevented from > accessing the AJP port by one or more of the following means: > - configuring appropriate network firewall rules > - configuring an explicit address attribute to the connector so that > the Connector listens on a non-public interface > - configuring a shared secret for the AJP connection > Users wishing to take a defence-in-depth approach and block the vector > that permits returning arbitrary files and execution as JSP may upgrade to: > - Apache Tomcat 9.0.31 or later > - Apache Tomcat 8.5.51 or later > - Apache Tomcat 7.0.100 or later > Users should note that a number of changes were made to the default AJP > Connector configuration in these versions to harden the default > configuration. The changes are: > - The AJP Connector is commented out in the provided server.xml file. > - The "requiredSecret" attribute has been renamed "secret" (the old name > continues to work but is deprecated). > - A new attribute "secretRequired" has been added which defaults to > "true". When this attribute is "true", the AJP Connector will not > start unless a shared secret has been configured. > - The default listen address for the AJP Connector is now the loopback > address. > It is likely that users upgrading to 9.0.31, 8.5.51 or 7.0.100 and later > will need to make small changes to their configurations as a result. > References: > [1] http://tomcat.apache.org/security-9.html > [2] http://tomcat.apache.org/security-8.html > [3] http://tomcat.apache.org/securit -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11407) Upgrade Tomcat from 9.0.29 to 9.0.31 (CVE-2020-1938)
[ https://issues.apache.org/jira/browse/OFBIZ-11407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044521#comment-17044521 ] ASF subversion and git services commented on OFBIZ-11407: - Commit 3856b0aebe67d49d8c3810663f6c91c999f18aaa in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3856b0a ] Upgrade Tomcat from 9.0.19 to 9.0.31 (OFBIZ-11407) Backported by hand (cherry pick failed) because of CVE-2020-1938 > Upgrade Tomcat from 9.0.29 to 9.0.31 (CVE-2020-1938) > > > Key: OFBIZ-11407 > URL: https://issues.apache.org/jira/browse/OFBIZ-11407 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > CVE-2020-1938 AJP Request Injection and potential Remote Code Execution > Severity: High > Vendor: The Apache Software Foundation > Versions Affected: > Apache Tomcat 9.0.0.M1 to 9.0.30 > Apache Tomcat 8.5.0 to 8.5.50 > Apache Tomcat 7.0.0 to 7.0.99 > Description: > When using the Apache JServ Protocol (AJP), care must be taken when > trusting incoming connections to Apache Tomcat. Tomcat treats AJP > connections as having higher trust than, for example, a similar HTTP > connection. If such connections are available to an attacker, they can > be exploited in ways that may be surprising. > Prior to Tomcat 9.0.31, 8.5.51 and 7.0.100, Tomcat shipped with an AJP > Connector enabled by default that listened on all configured IP > addresses. It was expected (and recommended in the security guide) that > this Connector would be disabled if not required. > Prior to this vulnerability report, the known risks of an attacker being > able to access the AJP port directly were: > - bypassing security checks based on client IP address > - bypassing user authentication if Tomcat was configured to trust > authentication data provided by the reverse proxy > This vulnerability report identified a mechanism that allowed the following: > - returning arbitrary files from anywhere in the web application > including under the WEB-INF and META-INF directories or any other > location reachable via ServletContext.getResourceAsStream() > - processing any file in the web application as a JSP > Further, if the web application allowed file upload and stored those > files within the web application (or the attacker was able to control > the content of the web application by some other means) then this, along > with the ability to process a file as a JSP, made remote code execution > possible. > Mitigation: > It is important to note that mitigation is only required if an AJP port > is accessible to untrusted users. > - If AJP support is not required, the Connector may be disabled e.g. by > removing the AJP Connector element from the server.xml file > - If AJP support is required, untrusted users may be prevented from > accessing the AJP port by one or more of the following means: > - configuring appropriate network firewall rules > - configuring an explicit address attribute to the connector so that > the Connector listens on a non-public interface > - configuring a shared secret for the AJP connection > Users wishing to take a defence-in-depth approach and block the vector > that permits returning arbitrary files and execution as JSP may upgrade to: > - Apache Tomcat 9.0.31 or later > - Apache Tomcat 8.5.51 or later > - Apache Tomcat 7.0.100 or later > Users should note that a number of changes were made to the default AJP > Connector configuration in these versions to harden the default > configuration. The changes are: > - The AJP Connector is commented out in the provided server.xml file. > - The "requiredSecret" attribute has been renamed "secret" (the old name > continues to work but is deprecated). > - A new attribute "secretRequired" has been added which defaults to > "true". When this attribute is "true", the AJP Connector will not > start unless a shared secret has been configured. > - The default listen address for the AJP Connector is now the loopback > address. > It is likely that users upgrading to 9.0.31, 8.5.51 or 7.0.100 and later > will need to make small changes to their configurations as a result. > References: > [1] http://tomcat.apache.org/security-9.html > [2] http://tomcat.apache.org/security-8.html > [3] http://tomcat.apache.org/securit -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11306) POC for CSRF Token
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044505#comment-17044505 ] Jacques Le Roux commented on OFBIZ-11306: - OK, it's not an issue related to this efffort. There is also a strange behaviour on trunk demo. I have created OFBIZ-11417 for that. I'll proceed to sequel... > POC for CSRF Token > -- > > Key: OFBIZ-11306 > URL: https://issues.apache.org/jira/browse/OFBIZ-11306 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Labels: CSRF > Fix For: Upcoming Branch > > Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, > CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-v2.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, partyTokenMap.webtools.txt > > > CRSF tokens are generated using SecureRandom class (maybe later a JWT with a > "time out"). > They are stored in the user sessions (for AJAX calls and unauthenticated HTTP > calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during > POST request. > # In *controllers* a new csrf-token attribute is added to the security tag to > exempt or force CSRF token check. > # In *Widget Forms* a hidden token field is auto-generated. > # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the > change. Using <@ofbizUrl> macro to generate the CSRF token means there is no > need to manually add the CSRF token field to each form in the ftl files. It > will save time for users doing custom implementation and maintenance. While > there is CSRF token in the form URL, the token is invalidated during form > submission. So it's uniqueand harmless even though the CSRF token of the form > submission is shown in the browser address bar. > # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added > through OfbizUtil.js (itself called at start in decorators and such) > # The html metadata is storing the csrf token used by JQuery AJAX. This token > will not change to another value after it is consumed > # Csrf tokens for the user are removed from the UtilCache when the user logs > out or session invalidated. > The general rule are as follows: > * RequestMap configured with 'get' method will be exempted from CSRF token > check. > * RequestMap configured with 'post' or 'all' method will be subjected to CSRF > token check. (Note there are discussions that RequestMap with ‘all’ method > should also not be subjected to CSRF token check. This will be done after > ensuring a separate uri is used when posting changes.) > * "main" request URIs are exempted from CSRF token check. > * Setting csrf-token to false or true on the Request Map will override the > general rules above. > To Discuss: > * Invalidate authenticated user session when CSRF token check fails. > * Configure the general rules in a Service method (which will be run inside > the constructor of RequestMap class) when determining the final > securityCsrfToken value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11417) "Check/Update Database" does not work
[
https://issues.apache.org/jira/browse/OFBIZ-11417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11417:
Environment: Trunk demo and local
> "Check/Update Database" does not work
> --
>
> Key: OFBIZ-11417
> URL: https://issues.apache.org/jira/browse/OFBIZ-11417
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk
> Environment: Trunk demo and local
>Reporter: Jacques Le Roux
>Priority: Major
>
> The error in log is confuse:
> {noformat}
> 2020-02-25 13:11:00,082 |7.0.0.1-8009-exec-10 |ControlServlet
> |T| [[[webtools::view (Domain:https://demo-trunk.ofbiz.apache.org)] Request
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-02-25 13:11:00,084 |7.0.0.1-8009-exec-10 |RequestHandler
> |I| Rendering View [checkdb]. Hidden sessionId by default.
> 2020-02-25 13:11:00,085 |7.0.0.1-8009-exec-10 |ServiceDispatcher
> |T| Sync service [webtools/getUserPreferenceGroup] finished in [1]
> milliseconds
> 2020-02-25 13:11:00,090 |7.0.0.1-8009-exec-10 |ScreenFactory
> |I| Got 20 screens in 0.005s from:
> file:/home/ofbizDemo/trunk/framework/webtools/widget/EntityScreens.xml
> 2020-02-25 13:11:00,239 |7.0.0.1-8009-exec-10 |ScreenFactory
> |I| Got 26 screens in 0.004s from:
> file:/home/ofbizDemo/trunk/framework/common/widget/CommonScreens.xml
> 2020-02-25 13:11:00,363 |7.0.0.1-8009-exec-10 |ScreenFactory
> |I| Got 25 screens in 0.005s from:
> file:/home/ofbizDemo/trunk/themes/common-theme/widget/CommonScreens.xml
> 2020-02-25 13:11:00,372 |7.0.0.1-8009-exec-10 |ModelService
> |I| Set default value [SECURITY] for parameter [primaryPermission]
> 2020-02-25 13:11:00,372 |7.0.0.1-8009-exec-10 |Log
> |I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This
> simple-method-call is deprecated! Please use a service-call of
> genericBasePermissionCheck instead.
> 2020-02-25 13:11:00,438 |7.0.0.1-8009-exec-10 |ServiceDispatcher
> |T| Sync service [webtools/genericBasePermissionCheck] finished in [65]
> milliseconds
> 2020-02-25 13:11:00,438 |7.0.0.1-8009-exec-10 |ServiceDispatcher
> |T| Sync service [webtools/securityPermissionCheck] finished in [67]
> milliseconds
> 2020-02-25 13:11:00,452 |7.0.0.1-8009-exec-10 |ServerHitBin
> |I| Visit delegatorName=default, ServerHitBin delegatorName=default
> 2020-02-25 13:11:00,453 |7.0.0.1-8009-exec-10 |ControlServlet
> |T| [[[webtools::view (Domain:https://demo-trunk.ofbiz.apache.org)] Request
> Done- total:0.371,since last([webtools::view (...):0.371]]
> 2020-02-25 13:11:02,708 |27.0.0.1-8009-exec-1 |ControlServlet
> |T| [[[webtools::view (Domain:https://demo-trunk.ofbiz.apache.org)] Request
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-02-25 13:11:02,709 |27.0.0.1-8009-exec-1 |RequestHandler
> |W| You should check if this request is really a problem or a false alarm:
> https://demo-trunk.ofbiz.apache.org/webtools/control/view/images/masthead.gif
> 2020-02-25 13:11:02,709 |27.0.0.1-8009-exec-1 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [view]; this request does not exist or cannot be called directly.
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:252)
> ~[main/:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:232)
> [main/:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:96)
> [main/:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:634)
> [tomcat-servlet-api-9.0.31.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
> [tomcat-servlet-api-9.0.31.jar:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-9.0.31.jar:9.0.31]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.31.jar:9.0.31]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
> [tomcat-embed-websocket-9.0.27.jar:9.0.27]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.31.jar:9.0.31]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.31.jar:9.0.31]
> at
>
[jira] [Created] (OFBIZ-11417) "Check/Update Database" does not work
Jacques Le Roux created OFBIZ-11417:
---
Summary: "Check/Update Database" does not work
Key: OFBIZ-11417
URL: https://issues.apache.org/jira/browse/OFBIZ-11417
Project: OFBiz
Issue Type: Bug
Components: framework/webtools
Affects Versions: Trunk
Reporter: Jacques Le Roux
The error in log is confuse:
{noformat}
2020-02-25 13:11:00,082 |7.0.0.1-8009-exec-10 |ControlServlet
|T| [[[webtools::view (Domain:https://demo-trunk.ofbiz.apache.org)] Request
Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-02-25 13:11:00,084 |7.0.0.1-8009-exec-10 |RequestHandler
|I| Rendering View [checkdb]. Hidden sessionId by default.
2020-02-25 13:11:00,085 |7.0.0.1-8009-exec-10 |ServiceDispatcher
|T| Sync service [webtools/getUserPreferenceGroup] finished in [1] milliseconds
2020-02-25 13:11:00,090 |7.0.0.1-8009-exec-10 |ScreenFactory
|I| Got 20 screens in 0.005s from:
file:/home/ofbizDemo/trunk/framework/webtools/widget/EntityScreens.xml
2020-02-25 13:11:00,239 |7.0.0.1-8009-exec-10 |ScreenFactory
|I| Got 26 screens in 0.004s from:
file:/home/ofbizDemo/trunk/framework/common/widget/CommonScreens.xml
2020-02-25 13:11:00,363 |7.0.0.1-8009-exec-10 |ScreenFactory
|I| Got 25 screens in 0.005s from:
file:/home/ofbizDemo/trunk/themes/common-theme/widget/CommonScreens.xml
2020-02-25 13:11:00,372 |7.0.0.1-8009-exec-10 |ModelService
|I| Set default value [SECURITY] for parameter [primaryPermission]
2020-02-25 13:11:00,372 |7.0.0.1-8009-exec-10 |Log
|I| [CommonPermissionServices.xml#genericBasePermissionCheck line 59] This
simple-method-call is deprecated! Please use a service-call of
genericBasePermissionCheck instead.
2020-02-25 13:11:00,438 |7.0.0.1-8009-exec-10 |ServiceDispatcher
|T| Sync service [webtools/genericBasePermissionCheck] finished in [65]
milliseconds
2020-02-25 13:11:00,438 |7.0.0.1-8009-exec-10 |ServiceDispatcher
|T| Sync service [webtools/securityPermissionCheck] finished in [67]
milliseconds
2020-02-25 13:11:00,452 |7.0.0.1-8009-exec-10 |ServerHitBin
|I| Visit delegatorName=default, ServerHitBin delegatorName=default
2020-02-25 13:11:00,453 |7.0.0.1-8009-exec-10 |ControlServlet
|T| [[[webtools::view (Domain:https://demo-trunk.ofbiz.apache.org)] Request
Done- total:0.371,since last([webtools::view (...):0.371]]
2020-02-25 13:11:02,708 |27.0.0.1-8009-exec-1 |ControlServlet
|T| [[[webtools::view (Domain:https://demo-trunk.ofbiz.apache.org)] Request
Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-02-25 13:11:02,709 |27.0.0.1-8009-exec-1 |RequestHandler
|W| You should check if this request is really a problem or a false alarm:
https://demo-trunk.ofbiz.apache.org/webtools/control/view/images/masthead.gif
2020-02-25 13:11:02,709 |27.0.0.1-8009-exec-1 |ControlServlet
|E| Error in request handler:
org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
[view]; this request does not exist or cannot be called directly.
at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:252)
~[main/:?]
at
org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:232)
[main/:?]
at
org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:96)
[main/:?]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:634)
[tomcat-servlet-api-9.0.31.jar:?]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
[tomcat-servlet-api-9.0.31.jar:?]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
[tomcat-catalina-9.0.31.jar:9.0.31]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-9.0.31.jar:9.0.31]
at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
[tomcat-embed-websocket-9.0.27.jar:9.0.27]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-9.0.31.jar:9.0.31]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-9.0.31.jar:9.0.31]
at
org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:187)
[main/:?]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-9.0.31.jar:9.0.31]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-9.0.31.jar:9.0.31]
at
org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
[jira] [Created] (OFBIZ-11416) Manufacturing Docbook help file migration to asciidoc format
Olivier Heintz created OFBIZ-11416: -- Summary: Manufacturing Docbook help file migration to asciidoc format Key: OFBIZ-11416 URL: https://issues.apache.org/jira/browse/OFBIZ-11416 Project: OFBiz Issue Type: Improvement Components: manufacturing Affects Versions: Trunk Reporter: Olivier Heintz Assignee: Olivier Heintz Migrate all Help files in docbook format to asciidoc format and include them in a global manufacturing.adoc document. manufacturing.adoc follow the template describe in Example structure for adoc files in the wiki https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Documentation+Team -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11415) Backport - Using FlexibleStringExpander in form widget field's parameter names
[ https://issues.apache.org/jira/browse/OFBIZ-11415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford updated OFBIZ-11415: --- Description: Request for backport of OFBIZ-11330 to release18.10. To allow a single form to be included on a screen multiple times, and for a collective submission from those forms to be handled by a service, it is necessary to ensure each form input can be rendered with a unique name. The name attribute of the rendered HTML form input is rendered according to the parameterName of a field in the form widget. To allow generation of unique field parameterNames we can use the FlexibleStringExpander type. PR: [https://github.com/apache/ofbiz-framework/pull/31] Improvement initially raised on dev mailing list - [https://lists.apache.org/thread.html/r20cf244d32587768e83a78d4f69d1ef1cd064b093c0e6a8e6caa74c4%40%3Cdev.ofbiz.apache.org%3E] was: Request for backport of OFBIZ-11330 to release18.10. To allow a single form to be included on a screen multiple times, and for a collective submission from those forms to be handled by a service, it is necessary to ensure each form input can be rendered with a unique name. The name attribute of the rendered HTML form input is rendered according to the parameterName of a field in the form widget. To allow generation of unique field parameterNames we can use the FlexibleStringExpander type. PR: To be created. Improvement initially raised on dev mailing list - [https://lists.apache.org/thread.html/r20cf244d32587768e83a78d4f69d1ef1cd064b093c0e6a8e6caa74c4%40%3Cdev.ofbiz.apache.org%3E] > Backport - Using FlexibleStringExpander in form widget field's parameter names > -- > > Key: OFBIZ-11415 > URL: https://issues.apache.org/jira/browse/OFBIZ-11415 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Nicolas Malin >Priority: Major > Labels: backport-needed > Fix For: Upcoming Branch > > Time Spent: 10m > Remaining Estimate: 0h > > Request for backport of OFBIZ-11330 to release18.10. > To allow a single form to be included on a screen multiple times, and for a > collective submission from those forms to be handled by a service, it is > necessary to ensure each form input can be rendered with a unique name. > The name attribute of the rendered HTML form input is rendered according to > the parameterName of a field in the form widget. > To allow generation of unique field parameterNames we can use the > FlexibleStringExpander type. > > PR: [https://github.com/apache/ofbiz-framework/pull/31] > > Improvement initially raised on dev mailing list - > [https://lists.apache.org/thread.html/r20cf244d32587768e83a78d4f69d1ef1cd064b093c0e6a8e6caa74c4%40%3Cdev.ofbiz.apache.org%3E] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11415) Backport - Using FlexibleStringExpander in form widget field's parameter names
[ https://issues.apache.org/jira/browse/OFBIZ-11415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford reassigned OFBIZ-11415: -- Assignee: (was: Nicolas Malin) > Backport - Using FlexibleStringExpander in form widget field's parameter names > -- > > Key: OFBIZ-11415 > URL: https://issues.apache.org/jira/browse/OFBIZ-11415 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Priority: Major > Labels: backport-needed > Fix For: Upcoming Branch > > Time Spent: 10m > Remaining Estimate: 0h > > Request for backport of OFBIZ-11330 to release18.10. > To allow a single form to be included on a screen multiple times, and for a > collective submission from those forms to be handled by a service, it is > necessary to ensure each form input can be rendered with a unique name. > The name attribute of the rendered HTML form input is rendered according to > the parameterName of a field in the form widget. > To allow generation of unique field parameterNames we can use the > FlexibleStringExpander type. > > PR: [https://github.com/apache/ofbiz-framework/pull/31] > > Improvement initially raised on dev mailing list - > [https://lists.apache.org/thread.html/r20cf244d32587768e83a78d4f69d1ef1cd064b093c0e6a8e6caa74c4%40%3Cdev.ofbiz.apache.org%3E] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11415) Backport - Using FlexibleStringExpander in form widget field's parameter names
[ https://issues.apache.org/jira/browse/OFBIZ-11415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford updated OFBIZ-11415: --- Sprint: OFBiz Community Day (Feb 2020) Description: Request for backport of OFBIZ-11330 to release18.10. To allow a single form to be included on a screen multiple times, and for a collective submission from those forms to be handled by a service, it is necessary to ensure each form input can be rendered with a unique name. The name attribute of the rendered HTML form input is rendered according to the parameterName of a field in the form widget. To allow generation of unique field parameterNames we can use the FlexibleStringExpander type. PR: To be created. Improvement initially raised on dev mailing list - [https://lists.apache.org/thread.html/r20cf244d32587768e83a78d4f69d1ef1cd064b093c0e6a8e6caa74c4%40%3Cdev.ofbiz.apache.org%3E] was: To allow a single form to be included on a screen multiple times, and for a collective submission from those forms to be handled by a service, it is necessary to ensure each form input can be rendered with a unique name. The name attribute of the rendered HTML form input is rendered according to the parameterName of a field in the form widget. To allow generation of unique field parameterNames we can use the FlexibleStringExpander type. PR created: [https://github.com/apache/ofbiz-framework/pull/7] Improvement initially raised on dev mailing list - [https://lists.apache.org/thread.html/r20cf244d32587768e83a78d4f69d1ef1cd064b093c0e6a8e6caa74c4%40%3Cdev.ofbiz.apache.org%3E] Labels: backport-needed (was: ) > Backport - Using FlexibleStringExpander in form widget field's parameter names > -- > > Key: OFBIZ-11415 > URL: https://issues.apache.org/jira/browse/OFBIZ-11415 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Nicolas Malin >Priority: Major > Labels: backport-needed > Fix For: Upcoming Branch > > > Request for backport of OFBIZ-11330 to release18.10. > To allow a single form to be included on a screen multiple times, and for a > collective submission from those forms to be handled by a service, it is > necessary to ensure each form input can be rendered with a unique name. > The name attribute of the rendered HTML form input is rendered according to > the parameterName of a field in the form widget. > To allow generation of unique field parameterNames we can use the > FlexibleStringExpander type. > > PR: To be created. > > Improvement initially raised on dev mailing list - > [https://lists.apache.org/thread.html/r20cf244d32587768e83a78d4f69d1ef1cd064b093c0e6a8e6caa74c4%40%3Cdev.ofbiz.apache.org%3E] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
