[jira] [Commented] (OFBIZ-4035) change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander
[
https://issues.apache.org/jira/browse/OFBIZ-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064079#comment-17064079
]
ASF subversion and git services commented on OFBIZ-4035:
Commit 1348f9d3be8730f510fc5e5071d570821abe5818 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1348f9d ]
Improved: Added unit testing, using JMockit, to ensure that form macros are
rendered using ids from ModelFormField#getCurrentContainerId.
(OFBIZ-4035)
Fixes check style errors
> change the id Attribute for input fields in the model macro form renderer
> from String to FlexibleStringExpander
> ---
>
> Key: OFBIZ-4035
> URL: https://issues.apache.org/jira/browse/OFBIZ-4035
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Sascha Schumann
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: patch-available
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-4035_ModelFormField.java.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> hi there,
> here a little useful improvement. i changed the ID Field of an input field in
> in the macro form renderer from a normal String to a flexible String
> expander.
> The advantage is that i can use ${} variables in the id description, that
> helps me for example creating automatically unique id's.
> Cheers
> Sascha
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-4035) change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander
[
https://issues.apache.org/jira/browse/OFBIZ-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064077#comment-17064077
]
ASF subversion and git services commented on OFBIZ-4035:
Commit 28e961c062e073ac9831810ea14b0c1a0d5a13d7 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=28e961c ]
Improved: Added unit testing, using JMockit, to ensure that form macros are
rendered using ids from ModelFormField#getCurrentContainerId.
(OFBIZ-4035)
Fixes an issue due to Eclipse automated import organisation.
There are still check style errors
> change the id Attribute for input fields in the model macro form renderer
> from String to FlexibleStringExpander
> ---
>
> Key: OFBIZ-4035
> URL: https://issues.apache.org/jira/browse/OFBIZ-4035
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Sascha Schumann
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: patch-available
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-4035_ModelFormField.java.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> hi there,
> here a little useful improvement. i changed the ID Field of an input field in
> in the macro form renderer from a normal String to a flexible String
> expander.
> The advantage is that i can use ${} variables in the id description, that
> helps me for example creating automatically unique id's.
> Cheers
> Sascha
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-4035) change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander
[
https://issues.apache.org/jira/browse/OFBIZ-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064064#comment-17064064
]
ASF subversion and git services commented on OFBIZ-4035:
Commit 322df2750c2cee965159573c6de279bff82f7a06 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=322df27 ]
Improved: Added unit testing, using JMockit, to ensure that form macros are
rendered using ids from ModelFormField#getCurrentContainerId.
(OFBIZ-4035)
Fixes a check issue (line too long)
Notice: on Windows I get 20 errors when compiling:
> Task :compileTestJava FAILED
C:\projectsASF\Git\ofbiz-framework\framework\widget\src\test\java\org\apache\
ofbiz\widget\renderer\macro\MacroFormRendererTest.java:134:
error: annotation type not applicable to this kind of declaration
@Mock
^
I guess the change in build.gradle are not enough for Windows, to be seen
later...
> change the id Attribute for input fields in the model macro form renderer
> from String to FlexibleStringExpander
> ---
>
> Key: OFBIZ-4035
> URL: https://issues.apache.org/jira/browse/OFBIZ-4035
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Sascha Schumann
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: patch-available
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-4035_ModelFormField.java.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> hi there,
> here a little useful improvement. i changed the ID Field of an input field in
> in the macro form renderer from a normal String to a flexible String
> expander.
> The advantage is that i can use ${} variables in the id description, that
> helps me for example creating automatically unique id's.
> Cheers
> Sascha
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10948) Convert DimensionServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064051#comment-17064051 ] Pierre Smits commented on OFBIZ-10948: -- Thanks Jacques. > Convert DimensionServices.xml minilang to groovy > > > Key: OFBIZ-10948 > URL: https://issues.apache.org/jira/browse/OFBIZ-10948 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: Minilang, dimension, dwh, groovy,, services > Fix For: Upcoming Branch > > Attachments: OFBIZ-10948-updated.patch, OFBIZ-10948.patch > > Time Spent: 10m > Remaining Estimate: 0h > > With the purpose to deprecate mini-lang OFBIZ-9350, convert > DimensionServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-4035) change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander
[
https://issues.apache.org/jira/browse/OFBIZ-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064028#comment-17064028
]
ASF subversion and git services commented on OFBIZ-4035:
Commit e2142dd00ef6d58c0ab87f1a33e5a6cf07fb3c9e in ofbiz-framework's branch
refs/heads/trunk from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e2142dd ]
Improved: Added license header to MacroFormRendererTest
(OFBIZ-4035)
> change the id Attribute for input fields in the model macro form renderer
> from String to FlexibleStringExpander
> ---
>
> Key: OFBIZ-4035
> URL: https://issues.apache.org/jira/browse/OFBIZ-4035
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Sascha Schumann
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: patch-available
> Attachments: OFBIZ-4035_ModelFormField.java.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> hi there,
> here a little useful improvement. i changed the ID Field of an input field in
> in the macro form renderer from a normal String to a flexible String
> expander.
> The advantage is that i can use ${} variables in the id description, that
> helps me for example creating automatically unique id's.
> Cheers
> Sascha
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-4035) change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander
[
https://issues.apache.org/jira/browse/OFBIZ-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064027#comment-17064027
]
ASF subversion and git services commented on OFBIZ-4035:
Commit 05d734206a833bdd69dafc16470b4265613053aa in ofbiz-framework's branch
refs/heads/trunk from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=05d7342 ]
Improved: Added unit testing, using JMockit, to ensure that form macros are
rendered using ids from ModelFormField#getCurrentContainerId.
(OFBIZ-4035)
> change the id Attribute for input fields in the model macro form renderer
> from String to FlexibleStringExpander
> ---
>
> Key: OFBIZ-4035
> URL: https://issues.apache.org/jira/browse/OFBIZ-4035
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Sascha Schumann
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: patch-available
> Attachments: OFBIZ-4035_ModelFormField.java.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> hi there,
> here a little useful improvement. i changed the ID Field of an input field in
> in the macro form renderer from a normal String to a flexible String
> expander.
> The advantage is that i can use ${} variables in the id description, that
> helps me for example creating automatically unique id's.
> Cheers
> Sascha
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-4035) change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander
[
https://issues.apache.org/jira/browse/OFBIZ-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-4035.
--
Fix Version/s: Upcoming Branch
Resolution: Implemented
> change the id Attribute for input fields in the model macro form renderer
> from String to FlexibleStringExpander
> ---
>
> Key: OFBIZ-4035
> URL: https://issues.apache.org/jira/browse/OFBIZ-4035
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Sascha Schumann
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: patch-available
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-4035_ModelFormField.java.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> hi there,
> here a little useful improvement. i changed the ID Field of an input field in
> in the macro form renderer from a normal String to a flexible String
> expander.
> The advantage is that i can use ${} variables in the id description, that
> helps me for example creating automatically unique id's.
> Cheers
> Sascha
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-4035) change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander
[
https://issues.apache.org/jira/browse/OFBIZ-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064026#comment-17064026
]
Jacques Le Roux commented on OFBIZ-4035:
Thanks Daniel,
Only MacroFormRendererTest was missing, I tested locally and it works as
expected, I merge and close.
> change the id Attribute for input fields in the model macro form renderer
> from String to FlexibleStringExpander
> ---
>
> Key: OFBIZ-4035
> URL: https://issues.apache.org/jira/browse/OFBIZ-4035
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Sascha Schumann
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: patch-available
> Attachments: OFBIZ-4035_ModelFormField.java.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> hi there,
> here a little useful improvement. i changed the ID Field of an input field in
> in the macro form renderer from a normal String to a flexible String
> expander.
> The advantage is that i can use ${} variables in the id description, that
> helps me for example creating automatically unique id's.
> Cheers
> Sascha
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-4035) change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander
[
https://issues.apache.org/jira/browse/OFBIZ-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-4035:
--
Assignee: Jacques Le Roux
> change the id Attribute for input fields in the model macro form renderer
> from String to FlexibleStringExpander
> ---
>
> Key: OFBIZ-4035
> URL: https://issues.apache.org/jira/browse/OFBIZ-4035
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Sascha Schumann
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: patch-available
> Attachments: OFBIZ-4035_ModelFormField.java.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> hi there,
> here a little useful improvement. i changed the ID Field of an input field in
> in the macro form renderer from a normal String to a flexible String
> expander.
> The advantage is that i can use ${} variables in the id description, that
> helps me for example creating automatically unique id's.
> Cheers
> Sascha
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-10948) Convert DimensionServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10948. --- Resolution: Fixed > Convert DimensionServices.xml minilang to groovy > > > Key: OFBIZ-10948 > URL: https://issues.apache.org/jira/browse/OFBIZ-10948 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: Minilang, dimension, dwh, groovy,, services > Fix For: Upcoming Branch > > Attachments: OFBIZ-10948-updated.patch, OFBIZ-10948.patch > > Time Spent: 10m > Remaining Estimate: 0h > > With the purpose to deprecate mini-lang OFBIZ-9350, convert > DimensionServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10948) Convert DimensionServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064021#comment-17064021 ] ASF subversion and git services commented on OFBIZ-10948: - Commit a8d3781cc6ae56863ef98a5092fd8a5095773d98 in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=a8d3781 ] Fixed: Convert DimensionServices.xml minilang to groovy (OFBIZ-10948) Now correctly creates the CurrencyDimension using currency.uomId No need for delegator.setNextSeqId(), looking at (now removed) DimensionServices.xml confused me. Thanks: Pierre Smits for report > Convert DimensionServices.xml minilang to groovy > > > Key: OFBIZ-10948 > URL: https://issues.apache.org/jira/browse/OFBIZ-10948 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: Minilang, dimension, dwh, groovy,, services > Fix For: Upcoming Branch > > Attachments: OFBIZ-10948-updated.patch, OFBIZ-10948.patch > > Time Spent: 10m > Remaining Estimate: 0h > > With the purpose to deprecate mini-lang OFBIZ-9350, convert > DimensionServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10948) Convert DimensionServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064018#comment-17064018 ] Jacques Le Roux commented on OFBIZ-10948: - Thanks Pierre, Oops, I must have tested with a quickInitDataWarehouse done before. I'll fix it soon... > Convert DimensionServices.xml minilang to groovy > > > Key: OFBIZ-10948 > URL: https://issues.apache.org/jira/browse/OFBIZ-10948 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: Minilang, dimension, dwh, groovy,, services > Fix For: Upcoming Branch > > Attachments: OFBIZ-10948-updated.patch, OFBIZ-10948.patch > > Time Spent: 10m > Remaining Estimate: 0h > > With the purpose to deprecate mini-lang OFBIZ-9350, convert > DimensionServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-10948) Convert DimensionServices.xml minilang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits reopened OFBIZ-10948:
--
[~jleroux]
Your recent fix in
https://github.com/apache/ofbiz-plugins/commit/350571deaadef1cecc837ad6688d9cdedd630887#diff-e9cd26f324532e93b4b0dec5717a5350
did not fix the issue.
Will you take care of this?
{code:java}
2020-03-21 14:03:07,630 |27.0.0.1-8009-exec-2 |ServiceDispatcher |T| [[Sync
service failed...- total:0.0,since last(Begin):0.0]] - 'bi /
loadCurrencyDimension'
2020-03-21 14:03:07,630 |27.0.0.1-8009-exec-2 |TransactionUtil |W| Calling
transaction setRollbackOnly; this stack trace shows where this is happening:
java.lang.Exception: Service [loadCurrencyDimension] threw an unexpected
exception/error
at
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:358)
[main/:?]
at
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:292)
[main/:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:540)
[main/:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
[main/:?]
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
[main/:?]
at org.apache.ofbiz.service.LocalDispatcher$runSync$0.call(Unknown Source)
[main/:?]
at
org.apache.ofbiz.service.engine.GroovyBaseScript.runService(GroovyBaseScript.groovy:48)
[main/:?]
at sun.reflect.GeneratedMethodAccessor492.invoke(Unknown Source) ~[?:?]
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_242]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_242]
at
org.codehaus.groovy.runtime.callsite.PlainObjectMetaMethodSite.doInvoke(PlainObjectMetaMethodSite.java:43)
[groovy-2.5.8.jar:2.5.8]
at
org.codehaus.groovy.runtime.callsite.PogoMetaMethodSite$PogoCachedMethodSite.invoke(PogoMetaMethodSite.java:167)
[groovy-2.5.8.jar:2.5.8]
at
org.codehaus.groovy.runtime.callsite.PogoMetaMethodSite.callCurrent(PogoMetaMethodSite.java:58)
[groovy-2.5.8.jar:2.5.8]
at
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:176)
[groovy-2.5.8.jar:2.5.8]
at
org.apache.ofbiz.service.engine.GroovyBaseScript.run(GroovyBaseScript.groovy:56)
[main/:?]
at org.apache.ofbiz.service.engine.GroovyBaseScript$run$1.callCurrent(Unknown
Source) [main/:?]
at
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
[groovy-2.5.8.jar:2.5.8]
at
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:156)
[groovy-2.5.8.jar:2.5.8]
at
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:168)
[groovy-2.5.8.jar:2.5.8]
at DimensionServices.quickInitDataWarehouse(DimensionServices.groovy:33)
[script:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_242]
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_242]
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_242]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_242]
at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101)
[groovy-2.5.8.jar:2.5.8]
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323)
[groovy-2.5.8.jar:2.5.8]
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1217)
[groovy-2.5.8.jar:2.5.8]
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041)
[groovy-2.5.8.jar:2.5.8]
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:821)
[groovy-2.5.8.jar:2.5.8]
at groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:44)
[groovy-2.5.8.jar:2.5.8]
at groovy.lang.Script.invokeMethod(Script.java:77) [groovy-2.5.8.jar:2.5.8]
at org.apache.ofbiz.service.engine.GroovyEngine.runSync(GroovyEngine.java:110)
[main/:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:417)
[main/:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
[main/:?]
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
[main/:?]
at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:253)
[main/:?]
at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:756)
[main/:?]
at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:477)
[main/:?]
at
org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:232)
[main/:?]
at
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:81)
[main/:?]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:660)
[tomcat-servlet-api-9.0.31.jar:?]
at
[jira] [Commented] (OFBIZ-11465) prepareProductDimensionData does not load correct fields in ProductDimension
[
https://issues.apache.org/jira/browse/OFBIZ-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063906#comment-17063906
]
Pierre Smits commented on OFBIZ-11465:
--
Thanks Michael.
> prepareProductDimensionData does not load correct fields in ProductDimension
>
>
> Key: OFBIZ-11465
> URL: https://issues.apache.org/jira/browse/OFBIZ-11465
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Labels: ProductDimension, birt, dimension, dwh, product, service
> Fix For: Upcoming Branch
>
>
> With the implementation of the patch ofOFBIZ-10948 an error was introduced
> that led to fields in the ProductDimension to be populated in a wrong way.
> The replaced minilang code encompassed:
> {code:xml}
>
>
>
>
> property="ProductProductNotFoundWithProduct"/>
>
>
>
> value-field="productDimension"/>
>
> to-value-field="productType"/>
> from-field="productType.description"/>
>
>
> {code}
> This was replace with groovy code:
> {code:java}
> def prepareProductDimensionData() {
> GenericValue product = from("Product").where("productId",
> parameters.productId).queryOne()
> if (product == null) {
> return error(UtilProperties.getMessage('ProductUiLabels',
> 'ProductProductNotFoundWithProduct', locale))
> }
> productDimension = delegator.makeValue("ProductDimension")
> productDimension.setNonPKFields(parameters)
> GenericValue productType =
> select("description").from("Product").where("productId",
> parameters.productId).queryOne()
> productDimension.productType = productType.description
> Map result = success()
> result.productDimension = productDimension
> return result
> }
> {code}
> 2 things happened:
> * the key-value pairs of the product were not injected into the
> projectDimension object, but rather only parameters (not including these
> parse);
> * the description of the productType associated with the product was not
> injected into the productDimension object, but rather the description of the
> product.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11465) prepareProductDimensionData does not load correct fields in ProductDimension
[
https://issues.apache.org/jira/browse/OFBIZ-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063902#comment-17063902
]
Michael Brohl commented on OFBIZ-11465:
---
[~pawan] did it correctly by fixing the bug independently and directly on trunk.
Pull requests/feature branches should simply be updated by pulling the latest
changes of trunk and merge possible conflicts there. This is a common
development process in every project which works with feature branches.
[~pierresmits] Merge conflicts are easy to solve in the local sandbox by using
the proper tools (git mergetool...). The GitHub UI is not recommended in such
cases.
> prepareProductDimensionData does not load correct fields in ProductDimension
>
>
> Key: OFBIZ-11465
> URL: https://issues.apache.org/jira/browse/OFBIZ-11465
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Labels: ProductDimension, birt, dimension, dwh, product, service
> Fix For: Upcoming Branch
>
>
> With the implementation of the patch ofOFBIZ-10948 an error was introduced
> that led to fields in the ProductDimension to be populated in a wrong way.
> The replaced minilang code encompassed:
> {code:xml}
>
>
>
>
> property="ProductProductNotFoundWithProduct"/>
>
>
>
> value-field="productDimension"/>
>
> to-value-field="productType"/>
> from-field="productType.description"/>
>
>
> {code}
> This was replace with groovy code:
> {code:java}
> def prepareProductDimensionData() {
> GenericValue product = from("Product").where("productId",
> parameters.productId).queryOne()
> if (product == null) {
> return error(UtilProperties.getMessage('ProductUiLabels',
> 'ProductProductNotFoundWithProduct', locale))
> }
> productDimension = delegator.makeValue("ProductDimension")
> productDimension.setNonPKFields(parameters)
> GenericValue productType =
> select("description").from("Product").where("productId",
> parameters.productId).queryOne()
> productDimension.productType = productType.description
> Map result = success()
> result.productDimension = productDimension
> return result
> }
> {code}
> 2 things happened:
> * the key-value pairs of the product were not injected into the
> projectDimension object, but rather only parameters (not including these
> parse);
> * the description of the productType associated with the product was not
> injected into the productDimension object, but rather the description of the
> product.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11465) prepareProductDimensionData does not load correct fields in ProductDimension
[
https://issues.apache.org/jira/browse/OFBIZ-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063884#comment-17063884
]
Pawan Verma commented on OFBIZ-11465:
-
[~pierresmits]
IMHO, A existing bug can not be handled in the improvement PR, it should have a
separate PR or patch.
{panel:title=If you had taken it without the slight adjustments I quess that
would not have led to the merge conflict.}
I have modified code as it was required, fetching data from Type entity should
use a cache, it's a good practice.
{panel}
{panel:title=A revert of the commit should fix the PR again}
The code I committed is right in my sense and rectifies the problem reported in
this JIRA. IMHO, it's right and I prefer to correct a PR instead of revert a
good fix.
{panel}
Thanks for your cooperation with this.
> prepareProductDimensionData does not load correct fields in ProductDimension
>
>
> Key: OFBIZ-11465
> URL: https://issues.apache.org/jira/browse/OFBIZ-11465
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Labels: ProductDimension, birt, dimension, dwh, product, service
> Fix For: Upcoming Branch
>
>
> With the implementation of the patch ofOFBIZ-10948 an error was introduced
> that led to fields in the ProductDimension to be populated in a wrong way.
> The replaced minilang code encompassed:
> {code:xml}
>
>
>
>
> property="ProductProductNotFoundWithProduct"/>
>
>
>
> value-field="productDimension"/>
>
> to-value-field="productType"/>
> from-field="productType.description"/>
>
>
> {code}
> This was replace with groovy code:
> {code:java}
> def prepareProductDimensionData() {
> GenericValue product = from("Product").where("productId",
> parameters.productId).queryOne()
> if (product == null) {
> return error(UtilProperties.getMessage('ProductUiLabels',
> 'ProductProductNotFoundWithProduct', locale))
> }
> productDimension = delegator.makeValue("ProductDimension")
> productDimension.setNonPKFields(parameters)
> GenericValue productType =
> select("description").from("Product").where("productId",
> parameters.productId).queryOne()
> productDimension.productType = productType.description
> Map result = success()
> result.productDimension = productDimension
> return result
> }
> {code}
> 2 things happened:
> * the key-value pairs of the product were not injected into the
> projectDimension object, but rather only parameters (not including these
> parse);
> * the description of the productType associated with the product was not
> injected into the productDimension object, but rather the description of the
> product.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11465) prepareProductDimensionData does not load correct fields in ProductDimension
[
https://issues.apache.org/jira/browse/OFBIZ-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063880#comment-17063880
]
Pierre Smits commented on OFBIZ-11465:
--
A revert of the commit should fix the PR again (this being the easiest way to
avoid a lot of effort to go into handling the merge conflict). Can you do that?
> prepareProductDimensionData does not load correct fields in ProductDimension
>
>
> Key: OFBIZ-11465
> URL: https://issues.apache.org/jira/browse/OFBIZ-11465
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Labels: ProductDimension, birt, dimension, dwh, product, service
> Fix For: Upcoming Branch
>
>
> With the implementation of the patch ofOFBIZ-10948 an error was introduced
> that led to fields in the ProductDimension to be populated in a wrong way.
> The replaced minilang code encompassed:
> {code:xml}
>
>
>
>
> property="ProductProductNotFoundWithProduct"/>
>
>
>
> value-field="productDimension"/>
>
> to-value-field="productType"/>
> from-field="productType.description"/>
>
>
> {code}
> This was replace with groovy code:
> {code:java}
> def prepareProductDimensionData() {
> GenericValue product = from("Product").where("productId",
> parameters.productId).queryOne()
> if (product == null) {
> return error(UtilProperties.getMessage('ProductUiLabels',
> 'ProductProductNotFoundWithProduct', locale))
> }
> productDimension = delegator.makeValue("ProductDimension")
> productDimension.setNonPKFields(parameters)
> GenericValue productType =
> select("description").from("Product").where("productId",
> parameters.productId).queryOne()
> productDimension.productType = productType.description
> Map result = success()
> result.productDimension = productDimension
> return result
> }
> {code}
> 2 things happened:
> * the key-value pairs of the product were not injected into the
> projectDimension object, but rather only parameters (not including these
> parse);
> * the description of the productType associated with the product was not
> injected into the productDimension object, but rather the description of the
> product.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11465) prepareProductDimensionData does not load correct fields in ProductDimension
[
https://issues.apache.org/jira/browse/OFBIZ-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063878#comment-17063878
]
Pierre Smits commented on OFBIZ-11465:
--
That is why I fixed it in the PR. If you had taken it without the slight
adjustments I quess that would not have led to the merge conflict. Merge
conflicts are a big pain in the a*s. And we could have done the improvements
afterwards.
> prepareProductDimensionData does not load correct fields in ProductDimension
>
>
> Key: OFBIZ-11465
> URL: https://issues.apache.org/jira/browse/OFBIZ-11465
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Labels: ProductDimension, birt, dimension, dwh, product, service
> Fix For: Upcoming Branch
>
>
> With the implementation of the patch ofOFBIZ-10948 an error was introduced
> that led to fields in the ProductDimension to be populated in a wrong way.
> The replaced minilang code encompassed:
> {code:xml}
>
>
>
>
> property="ProductProductNotFoundWithProduct"/>
>
>
>
> value-field="productDimension"/>
>
> to-value-field="productType"/>
> from-field="productType.description"/>
>
>
> {code}
> This was replace with groovy code:
> {code:java}
> def prepareProductDimensionData() {
> GenericValue product = from("Product").where("productId",
> parameters.productId).queryOne()
> if (product == null) {
> return error(UtilProperties.getMessage('ProductUiLabels',
> 'ProductProductNotFoundWithProduct', locale))
> }
> productDimension = delegator.makeValue("ProductDimension")
> productDimension.setNonPKFields(parameters)
> GenericValue productType =
> select("description").from("Product").where("productId",
> parameters.productId).queryOne()
> productDimension.productType = productType.description
> Map result = success()
> result.productDimension = productDimension
> return result
> }
> {code}
> 2 things happened:
> * the key-value pairs of the product were not injected into the
> projectDimension object, but rather only parameters (not including these
> parse);
> * the description of the productType associated with the product was not
> injected into the productDimension object, but rather the description of the
> product.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11465) prepareProductDimensionData does not load correct fields in ProductDimension
[
https://issues.apache.org/jira/browse/OFBIZ-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063876#comment-17063876
]
Pawan Verma commented on OFBIZ-11465:
-
Okay, But that change was necessary to fix the existing bug :)
> prepareProductDimensionData does not load correct fields in ProductDimension
>
>
> Key: OFBIZ-11465
> URL: https://issues.apache.org/jira/browse/OFBIZ-11465
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Labels: ProductDimension, birt, dimension, dwh, product, service
> Fix For: Upcoming Branch
>
>
> With the implementation of the patch ofOFBIZ-10948 an error was introduced
> that led to fields in the ProductDimension to be populated in a wrong way.
> The replaced minilang code encompassed:
> {code:xml}
>
>
>
>
> property="ProductProductNotFoundWithProduct"/>
>
>
>
> value-field="productDimension"/>
>
> to-value-field="productType"/>
> from-field="productType.description"/>
>
>
> {code}
> This was replace with groovy code:
> {code:java}
> def prepareProductDimensionData() {
> GenericValue product = from("Product").where("productId",
> parameters.productId).queryOne()
> if (product == null) {
> return error(UtilProperties.getMessage('ProductUiLabels',
> 'ProductProductNotFoundWithProduct', locale))
> }
> productDimension = delegator.makeValue("ProductDimension")
> productDimension.setNonPKFields(parameters)
> GenericValue productType =
> select("description").from("Product").where("productId",
> parameters.productId).queryOne()
> productDimension.productType = productType.description
> Map result = success()
> result.productDimension = productDimension
> return result
> }
> {code}
> 2 things happened:
> * the key-value pairs of the product were not injected into the
> projectDimension object, but rather only parameters (not including these
> parse);
> * the description of the productType associated with the product was not
> injected into the productDimension object, but rather the description of the
> product.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11465) prepareProductDimensionData does not load correct fields in ProductDimension
[
https://issues.apache.org/jira/browse/OFBIZ-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063873#comment-17063873
]
Pierre Smits commented on OFBIZ-11465:
--
[~pawan],
Your slight adjustment now causes the PR to fail (merge conflicts).
> prepareProductDimensionData does not load correct fields in ProductDimension
>
>
> Key: OFBIZ-11465
> URL: https://issues.apache.org/jira/browse/OFBIZ-11465
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Labels: ProductDimension, birt, dimension, dwh, product, service
> Fix For: Upcoming Branch
>
>
> With the implementation of the patch ofOFBIZ-10948 an error was introduced
> that led to fields in the ProductDimension to be populated in a wrong way.
> The replaced minilang code encompassed:
> {code:xml}
>
>
>
>
> property="ProductProductNotFoundWithProduct"/>
>
>
>
> value-field="productDimension"/>
>
> to-value-field="productType"/>
> from-field="productType.description"/>
>
>
> {code}
> This was replace with groovy code:
> {code:java}
> def prepareProductDimensionData() {
> GenericValue product = from("Product").where("productId",
> parameters.productId).queryOne()
> if (product == null) {
> return error(UtilProperties.getMessage('ProductUiLabels',
> 'ProductProductNotFoundWithProduct', locale))
> }
> productDimension = delegator.makeValue("ProductDimension")
> productDimension.setNonPKFields(parameters)
> GenericValue productType =
> select("description").from("Product").where("productId",
> parameters.productId).queryOne()
> productDimension.productType = productType.description
> Map result = success()
> result.productDimension = productDimension
> return result
> }
> {code}
> 2 things happened:
> * the key-value pairs of the product were not injected into the
> projectDimension object, but rather only parameters (not including these
> parse);
> * the description of the productType associated with the product was not
> injected into the productDimension object, but rather the description of the
> product.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11467) Missing map files for 3rd party javascript libraries
[
https://issues.apache.org/jira/browse/OFBIZ-11467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063874#comment-17063874
]
Pawan Verma commented on OFBIZ-11467:
-
[~pierresmits], Tried again but did not get any luck :(
> Missing map files for 3rd party javascript libraries
>
>
> Key: OFBIZ-11467
> URL: https://issues.apache.org/jira/browse/OFBIZ-11467
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Pierre Smits
>Priority: Major
> Attachments: Screen Shot 2020-03-21 at 10.51.16.png, Screen Shot
> 2020-03-21 at 10.51.49.png
>
>
> Mozilla browser debugger shows following errors:
> {code}
> Source map error: Error: request failed with status 404
> Resource URL: https://localhost:8443/common/js/plugins/OpenLayers-5.3.0.js
> Source Map URL: ol.js.map
> {code}
> and
> {code}
> Source map error: Error: request failed with status 404
> Resource URL:
> https://localhost:8443/common/js/jquery/plugins/jquery-jgrowl/jquery.jgrowl-1.4.6.min.js
> Source Map URL: jquery.jgrowl.map
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11465) prepareProductDimensionData does not load correct fields in ProductDimension
[
https://issues.apache.org/jira/browse/OFBIZ-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Verma closed OFBIZ-11465.
---
Fix Version/s: Upcoming Branch
Resolution: Fixed
> prepareProductDimensionData does not load correct fields in ProductDimension
>
>
> Key: OFBIZ-11465
> URL: https://issues.apache.org/jira/browse/OFBIZ-11465
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Labels: ProductDimension, birt, dimension, dwh, product, service
> Fix For: Upcoming Branch
>
>
> With the implementation of the patch ofOFBIZ-10948 an error was introduced
> that led to fields in the ProductDimension to be populated in a wrong way.
> The replaced minilang code encompassed:
> {code:xml}
>
>
>
>
> property="ProductProductNotFoundWithProduct"/>
>
>
>
> value-field="productDimension"/>
>
> to-value-field="productType"/>
> from-field="productType.description"/>
>
>
> {code}
> This was replace with groovy code:
> {code:java}
> def prepareProductDimensionData() {
> GenericValue product = from("Product").where("productId",
> parameters.productId).queryOne()
> if (product == null) {
> return error(UtilProperties.getMessage('ProductUiLabels',
> 'ProductProductNotFoundWithProduct', locale))
> }
> productDimension = delegator.makeValue("ProductDimension")
> productDimension.setNonPKFields(parameters)
> GenericValue productType =
> select("description").from("Product").where("productId",
> parameters.productId).queryOne()
> productDimension.productType = productType.description
> Map result = success()
> result.productDimension = productDimension
> return result
> }
> {code}
> 2 things happened:
> * the key-value pairs of the product were not injected into the
> projectDimension object, but rather only parameters (not including these
> parse);
> * the description of the productType associated with the product was not
> injected into the productDimension object, but rather the description of the
> product.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11465) prepareProductDimensionData does not load correct fields in ProductDimension
[
https://issues.apache.org/jira/browse/OFBIZ-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063870#comment-17063870
]
Pawan Verma commented on OFBIZ-11465:
-
[~pierresmits] Your slightly modified patch is in Trunk at
38112fb34691c8efb2d70d2661dac296ecb8b654. Thanks, for your contribution.
> prepareProductDimensionData does not load correct fields in ProductDimension
>
>
> Key: OFBIZ-11465
> URL: https://issues.apache.org/jira/browse/OFBIZ-11465
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Labels: ProductDimension, birt, dimension, dwh, product, service
>
> With the implementation of the patch ofOFBIZ-10948 an error was introduced
> that led to fields in the ProductDimension to be populated in a wrong way.
> The replaced minilang code encompassed:
> {code:xml}
>
>
>
>
> property="ProductProductNotFoundWithProduct"/>
>
>
>
> value-field="productDimension"/>
>
> to-value-field="productType"/>
> from-field="productType.description"/>
>
>
> {code}
> This was replace with groovy code:
> {code:java}
> def prepareProductDimensionData() {
> GenericValue product = from("Product").where("productId",
> parameters.productId).queryOne()
> if (product == null) {
> return error(UtilProperties.getMessage('ProductUiLabels',
> 'ProductProductNotFoundWithProduct', locale))
> }
> productDimension = delegator.makeValue("ProductDimension")
> productDimension.setNonPKFields(parameters)
> GenericValue productType =
> select("description").from("Product").where("productId",
> parameters.productId).queryOne()
> productDimension.productType = productType.description
> Map result = success()
> result.productDimension = productDimension
> return result
> }
> {code}
> 2 things happened:
> * the key-value pairs of the product were not injected into the
> projectDimension object, but rather only parameters (not including these
> parse);
> * the description of the productType associated with the product was not
> injected into the productDimension object, but rather the description of the
> product.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11465) prepareProductDimensionData does not load correct fields in ProductDimension
[
https://issues.apache.org/jira/browse/OFBIZ-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Verma reassigned OFBIZ-11465:
---
Assignee: Pawan Verma (was: Pierre Smits)
> prepareProductDimensionData does not load correct fields in ProductDimension
>
>
> Key: OFBIZ-11465
> URL: https://issues.apache.org/jira/browse/OFBIZ-11465
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Labels: ProductDimension, birt, dimension, dwh, product, service
>
> With the implementation of the patch ofOFBIZ-10948 an error was introduced
> that led to fields in the ProductDimension to be populated in a wrong way.
> The replaced minilang code encompassed:
> {code:xml}
>
>
>
>
> property="ProductProductNotFoundWithProduct"/>
>
>
>
> value-field="productDimension"/>
>
> to-value-field="productType"/>
> from-field="productType.description"/>
>
>
> {code}
> This was replace with groovy code:
> {code:java}
> def prepareProductDimensionData() {
> GenericValue product = from("Product").where("productId",
> parameters.productId).queryOne()
> if (product == null) {
> return error(UtilProperties.getMessage('ProductUiLabels',
> 'ProductProductNotFoundWithProduct', locale))
> }
> productDimension = delegator.makeValue("ProductDimension")
> productDimension.setNonPKFields(parameters)
> GenericValue productType =
> select("description").from("Product").where("productId",
> parameters.productId).queryOne()
> productDimension.productType = productType.description
> Map result = success()
> result.productDimension = productDimension
> return result
> }
> {code}
> 2 things happened:
> * the key-value pairs of the product were not injected into the
> projectDimension object, but rather only parameters (not including these
> parse);
> * the description of the productType associated with the product was not
> injected into the productDimension object, but rather the description of the
> product.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11465) prepareProductDimensionData does not load correct fields in ProductDimension
[
https://issues.apache.org/jira/browse/OFBIZ-11465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063868#comment-17063868
]
ASF subversion and git services commented on OFBIZ-11465:
-
Commit 38112fb34691c8efb2d70d2661dac296ecb8b654 in ofbiz-plugins's branch
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=38112fb ]
Fixed: prepareProductDimensionData does not load correct fields in
ProductDimension
(OFBIZ-11465)
Thanks: Pierre Smits for your contribution.
> prepareProductDimensionData does not load correct fields in ProductDimension
>
>
> Key: OFBIZ-11465
> URL: https://issues.apache.org/jira/browse/OFBIZ-11465
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Labels: ProductDimension, birt, dimension, dwh, product, service
>
> With the implementation of the patch ofOFBIZ-10948 an error was introduced
> that led to fields in the ProductDimension to be populated in a wrong way.
> The replaced minilang code encompassed:
> {code:xml}
>
>
>
>
> property="ProductProductNotFoundWithProduct"/>
>
>
>
> value-field="productDimension"/>
>
> to-value-field="productType"/>
> from-field="productType.description"/>
>
>
> {code}
> This was replace with groovy code:
> {code:java}
> def prepareProductDimensionData() {
> GenericValue product = from("Product").where("productId",
> parameters.productId).queryOne()
> if (product == null) {
> return error(UtilProperties.getMessage('ProductUiLabels',
> 'ProductProductNotFoundWithProduct', locale))
> }
> productDimension = delegator.makeValue("ProductDimension")
> productDimension.setNonPKFields(parameters)
> GenericValue productType =
> select("description").from("Product").where("productId",
> parameters.productId).queryOne()
> productDimension.productType = productType.description
> Map result = success()
> result.productDimension = productDimension
> return result
> }
> {code}
> 2 things happened:
> * the key-value pairs of the product were not injected into the
> projectDimension object, but rather only parameters (not including these
> parse);
> * the description of the productType associated with the product was not
> injected into the productDimension object, but rather the description of the
> product.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11470) Ensure that the SameSite attribute is set to 'strict' for all cookies.
[ https://issues.apache.org/jira/browse/OFBIZ-11470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063857#comment-17063857 ] ASF subversion and git services commented on OFBIZ-11470: - Commit c2fb314a1b93e9f3c1d96dce2356a7b39a01fa72 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c2fb314 ] Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies. (OFBIZ-11470) Fixes a typo > Ensure that the SameSite attribute is set to 'strict' for all cookies. > -- > > Key: OFBIZ-11470 > URL: https://issues.apache.org/jira/browse/OFBIZ-11470 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.01, 17.12.02 > > > As reported by OWASP ZAP: > bq. A cookie has been set without the SameSite attribute, which means that > the cookie can be sent as a result of a 'cross-site' request. The SameSite > attribute is an effective counter measure to cross-site request forgery, > cross-site script inclusion, and timing attacks. > The solution was not obvious in OFBiz for 2 reasons: > # There is no HttpServletResponse::setHeader. So we need to use a filter > (SameSiteFilter) and even that is not enough because of 2: > # To prevent session fixation we force Tomcat to generates a new jsessionId, > ultimately put in cookie, in LoginWorker::login. So we need to add a call to > SameSiteFilter::addSameSiteCookieAttribute in > UtilHttp::setResponseBrowserDefaultSecurityHeaders. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11470) Ensure that the SameSite attribute is set to 'strict' for all cookies.
[ https://issues.apache.org/jira/browse/OFBIZ-11470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063854#comment-17063854 ] ASF subversion and git services commented on OFBIZ-11470: - Commit 16172268977aae2c43f8535d1421fb735d1ccb6d in ofbiz-framework's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1617226 ] Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies. (OFBIZ-11470) It's better to allow users to change from strict to lax, at least for all cookies. Some could want to change it by cookie type. I let the exercise for them :) See:https://blog.mozilla.org/security/2018/04/24/same-site-cookies-in-firefox-60 Conflicts handled by hand framework/security/config/security.properties > Ensure that the SameSite attribute is set to 'strict' for all cookies. > -- > > Key: OFBIZ-11470 > URL: https://issues.apache.org/jira/browse/OFBIZ-11470 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.01, 17.12.02 > > > As reported by OWASP ZAP: > bq. A cookie has been set without the SameSite attribute, which means that > the cookie can be sent as a result of a 'cross-site' request. The SameSite > attribute is an effective counter measure to cross-site request forgery, > cross-site script inclusion, and timing attacks. > The solution was not obvious in OFBiz for 2 reasons: > # There is no HttpServletResponse::setHeader. So we need to use a filter > (SameSiteFilter) and even that is not enough because of 2: > # To prevent session fixation we force Tomcat to generates a new jsessionId, > ultimately put in cookie, in LoginWorker::login. So we need to add a call to > SameSiteFilter::addSameSiteCookieAttribute in > UtilHttp::setResponseBrowserDefaultSecurityHeaders. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11470) Ensure that the SameSite attribute is set to 'strict' for all cookies.
[ https://issues.apache.org/jira/browse/OFBIZ-11470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063855#comment-17063855 ] ASF subversion and git services commented on OFBIZ-11470: - Commit d08a0527c465642da43ff4d8d0e9876cf8b697f6 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d08a052 ] Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies. (OFBIZ-11470) It's better to allow users to change from strict to lax, at least for all cookies. Some could want to change it by cookie type. I let the exercise for them :) See:https://blog.mozilla.org/security/2018/04/24/same-site-cookies-in-firefox-60 > Ensure that the SameSite attribute is set to 'strict' for all cookies. > -- > > Key: OFBIZ-11470 > URL: https://issues.apache.org/jira/browse/OFBIZ-11470 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.01, 17.12.02 > > > As reported by OWASP ZAP: > bq. A cookie has been set without the SameSite attribute, which means that > the cookie can be sent as a result of a 'cross-site' request. The SameSite > attribute is an effective counter measure to cross-site request forgery, > cross-site script inclusion, and timing attacks. > The solution was not obvious in OFBiz for 2 reasons: > # There is no HttpServletResponse::setHeader. So we need to use a filter > (SameSiteFilter) and even that is not enough because of 2: > # To prevent session fixation we force Tomcat to generates a new jsessionId, > ultimately put in cookie, in LoginWorker::login. So we need to add a call to > SameSiteFilter::addSameSiteCookieAttribute in > UtilHttp::setResponseBrowserDefaultSecurityHeaders. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11470) Ensure that the SameSite attribute is set to 'strict' for all cookies.
[ https://issues.apache.org/jira/browse/OFBIZ-11470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063856#comment-17063856 ] ASF subversion and git services commented on OFBIZ-11470: - Commit fd1e7f477b8800a2071bb21a3115c43d31d919d3 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fd1e7f4 ] Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies. (OFBIZ-11470) It's better to allow users to change from strict to lax, at least for all cookies. Some could want to change it by cookie type. I let the exercise for them :) See:https://blog.mozilla.org/security/2018/04/24/same-site-cookies-in-firefox-60 > Ensure that the SameSite attribute is set to 'strict' for all cookies. > -- > > Key: OFBIZ-11470 > URL: https://issues.apache.org/jira/browse/OFBIZ-11470 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.01, 17.12.02 > > > As reported by OWASP ZAP: > bq. A cookie has been set without the SameSite attribute, which means that > the cookie can be sent as a result of a 'cross-site' request. The SameSite > attribute is an effective counter measure to cross-site request forgery, > cross-site script inclusion, and timing attacks. > The solution was not obvious in OFBiz for 2 reasons: > # There is no HttpServletResponse::setHeader. So we need to use a filter > (SameSiteFilter) and even that is not enough because of 2: > # To prevent session fixation we force Tomcat to generates a new jsessionId, > ultimately put in cookie, in LoginWorker::login. So we need to add a call to > SameSiteFilter::addSameSiteCookieAttribute in > UtilHttp::setResponseBrowserDefaultSecurityHeaders. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11467) Missing map files for 3rd party javascript libraries
[
https://issues.apache.org/jira/browse/OFBIZ-11467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063829#comment-17063829
]
Pierre Smits commented on OFBIZ-11467:
--
HI [~pawan],
See attached images regarding the result on demo-trunk.
!Screen Shot 2020-03-21 at 10.51.49.png! !Screen Shot 2020-03-21 at
10.51.16.png!
As you can see from the URI this is happening in the BI Component on selection
of the 'Report Builder' menu item.
But it is also happening on switching to the Accounting component.
> Missing map files for 3rd party javascript libraries
>
>
> Key: OFBIZ-11467
> URL: https://issues.apache.org/jira/browse/OFBIZ-11467
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Pierre Smits
>Priority: Major
> Attachments: Screen Shot 2020-03-21 at 10.51.16.png, Screen Shot
> 2020-03-21 at 10.51.49.png
>
>
> Mozilla browser debugger shows following errors:
> {code}
> Source map error: Error: request failed with status 404
> Resource URL: https://localhost:8443/common/js/plugins/OpenLayers-5.3.0.js
> Source Map URL: ol.js.map
> {code}
> and
> {code}
> Source map error: Error: request failed with status 404
> Resource URL:
> https://localhost:8443/common/js/jquery/plugins/jquery-jgrowl/jquery.jgrowl-1.4.6.min.js
> Source Map URL: jquery.jgrowl.map
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11467) Missing map files for 3rd party javascript libraries
[
https://issues.apache.org/jira/browse/OFBIZ-11467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-11467:
-
Attachment: Screen Shot 2020-03-21 at 10.51.16.png
Screen Shot 2020-03-21 at 10.51.49.png
> Missing map files for 3rd party javascript libraries
>
>
> Key: OFBIZ-11467
> URL: https://issues.apache.org/jira/browse/OFBIZ-11467
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Pierre Smits
>Priority: Major
> Attachments: Screen Shot 2020-03-21 at 10.51.16.png, Screen Shot
> 2020-03-21 at 10.51.49.png
>
>
> Mozilla browser debugger shows following errors:
> {code}
> Source map error: Error: request failed with status 404
> Resource URL: https://localhost:8443/common/js/plugins/OpenLayers-5.3.0.js
> Source Map URL: ol.js.map
> {code}
> and
> {code}
> Source map error: Error: request failed with status 404
> Resource URL:
> https://localhost:8443/common/js/jquery/plugins/jquery-jgrowl/jquery.jgrowl-1.4.6.min.js
> Source Map URL: jquery.jgrowl.map
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11467) Missing map files for 3rd party javascript libraries
[
https://issues.apache.org/jira/browse/OFBIZ-11467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063823#comment-17063823
]
Pawan Verma commented on OFBIZ-11467:
-
Hey [~pierresmits]
I tried to regenerate this issue on the demo trunk on Firefox 72.0.2 (64-bit)
(Ubuntu) and got success for both the files. Below are more details:
{code:java}
Request
URL:https://demo-trunk.ofbiz.apache.org/common/js/jquery/plugins/jquery-jgrowl/jquery.jgrowl-1.4.6.min.js
Status Code:200
{code}
{code:java}
Request
URL:https://demo-trunk.ofbiz.apache.org/common/js/plugins/OpenLayers-5.3.0.js
Status Code:200
{code}
Am I missing something?
> Missing map files for 3rd party javascript libraries
>
>
> Key: OFBIZ-11467
> URL: https://issues.apache.org/jira/browse/OFBIZ-11467
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> Mozilla browser debugger shows following errors:
> {code}
> Source map error: Error: request failed with status 404
> Resource URL: https://localhost:8443/common/js/plugins/OpenLayers-5.3.0.js
> Source Map URL: ol.js.map
> {code}
> and
> {code}
> Source map error: Error: request failed with status 404
> Resource URL:
> https://localhost:8443/common/js/jquery/plugins/jquery-jgrowl/jquery.jgrowl-1.4.6.min.js
> Source Map URL: jquery.jgrowl.map
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11414) Improve the BI component
[ https://issues.apache.org/jira/browse/OFBIZ-11414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063808#comment-17063808 ] Pierre Smits commented on OFBIZ-11414: -- On March 19 added: * OFBIZ-10986 - Have a StoreDimension * OFBIZ-11075 - Have a service to load the StoreDimension > Improve the BI component > > > Key: OFBIZ-11414 > URL: https://issues.apache.org/jira/browse/OFBIZ-11414 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Upcoming Branch, Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: birt, dwh > Time Spent: 10m > Remaining Estimate: 0h > > Improving the BI component enhances the feature set of OFBiz. > The BI component is essential for doing analysis (trend and otherwise) on > data captured from transactions, while avoiding heavy (query) loads on the > transaction system. An additional benefit is that data analysts don't need > access/permissions to the transaction system. > This is a placeholder ticket to capture all underlying tickets (tasks) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11453) repository ofbiz-tools does not have a license
[ https://issues.apache.org/jira/browse/OFBIZ-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063801#comment-17063801 ] Pierre Smits commented on OFBIZ-11453: -- [~jleroux], I am not going to add the NOTICE file to the PR. Either you do it yourself or raise another ticket. I am not going to cater to your tendency to inflate tickets with 'whatabouts'. > repository ofbiz-tools does not have a license > -- > > Key: OFBIZ-11453 > URL: https://issues.apache.org/jira/browse/OFBIZ-11453 > Project: OFBiz > Issue Type: Bug > Components: tools >Reporter: Pierre Smits >Priority: Major > Labels: license > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11452) repository ofbiz-site does not have a license
[ https://issues.apache.org/jira/browse/OFBIZ-11452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063800#comment-17063800 ] Pierre Smits commented on OFBIZ-11452: -- [~jleroux], I am not going to add the NOTICE file to the PR. Either you do it yourself or raise another ticket. I am not going to cater to your tendency to inflate tickets with 'whatabouts'. > repository ofbiz-site does not have a license > - > > Key: OFBIZ-11452 > URL: https://issues.apache.org/jira/browse/OFBIZ-11452 > Project: OFBiz > Issue Type: Bug > Components: site >Reporter: Pierre Smits >Priority: Major > Labels: license > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
